On 1/23/20 5:58 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela <quint...@redhat.com> --- hw/core/qdev-properties.c | 2 +- migration/Makefile.objs | 1 + migration/migration.c | 6 + migration/multifd-zstd.c | 304 +++++++++++++++++++++++++++++++++++ migration/multifd.h | 20 +++ migration/ram.c | 1 - qapi/migration.json | 2 +- tests/qtest/migration-test.c | 10 ++ 8 files changed, 343 insertions(+), 3 deletions(-) create mode 100644 migration/multifd-zstd.c
+++ b/migration/Makefile.objs @@ -9,6 +9,7 @@ common-obj-y += qjson.o common-obj-y += block-dirty-bitmap.o common-obj-y += multifd.o common-obj-y += multifd-zlib.o +common-obj-$(CONFIG_ZSTD) += multifd-zstd.o
zstd support is conditional...
+++ b/qapi/migration.json @@ -499,7 +499,7 @@ # ## { 'enum': 'MultifdCompress', - 'data': [ 'none', 'zlib' ] } + 'data': [ 'none', 'zlib', 'zstd' ] }
...so I would expect an 'if' conditional here when declaring the enum. It also needs documentation.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org