[PATCH v3] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-16 Thread Laurent Vivier
A regression that was introduced, with the refactor to TranslatorOps, drops two lines that update the PC when single-stepping is being performed. Fixes: 11ab74b01e0a ("target/m68k: Convert to TranslatorOps") Reported-by: Lucien Murray-Pitts Suggested-by: Lucien Murray-Pitts Suggested-by: Richard

Re: [PATCH v2] m68k: Fix regression causing Single-Step via GDB/RSP to not single step

2020-01-16 Thread Laurent Vivier
Le 16/01/2020 à 17:54, Laurent Vivier a écrit : > A regression that was introduced, with the refactor to TranslatorOps, > drops two lines that update the PC when single-stepping is being performed. > > Fixes: 11ab74b01e0a ("target/m68k: Convert to TranslatorOps") > Reported-by: Lucien Murray-Pitts

Re: [PATCH v2 83/86] tests:numa-test: make top level args dynamic and g_autofree(cli) cleanups

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 17:35:32 +0100 Thomas Huth wrote: > On 15/01/2020 16.07, Igor Mammedov wrote: > > Use GString to pass argument to make_cli() so that it would be easy > > to dynamically change test case arguments from main(). The follow up > > patch will use it to change RAM size options depen

Re: [PATCH v2 85/86] numa: make exit() usage consistent

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 17:43:30 +0100 Thomas Huth wrote: > On 15/01/2020 16.07, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > > CC: ehabk...@redhat.com > > --- > > hw/core/numa.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/core/numa.c b/

[Bug 1859916] Re: coreaudio not working on MacOS

2020-01-16 Thread JS
I am not using any audio enhancing software. I start trying qemu + Ubuntu Desktop a few weeks ago and put all configurations together last week, so I never try coreaudio on 4.1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:/

Re: [PATCH v6 0/8] blockdev: Fix AioContext handling for various blockdev actions

2020-01-16 Thread Paolo Bonzini
On 08/01/20 15:31, Sergio Lopez wrote: > This patch series includes fixes for various issues related to > AioContext mismanagement for various blockdev-initiated actions. > > It also adds tests for those actions when executed on drives running > on an IOThread AioContext. Testing the latest addit

Re: [PATCH 093/104] virtiofsd: introduce inode refcount to prevent use-after-free

2020-01-16 Thread Stefan Hajnoczi
On Thu, Jan 16, 2020 at 09:25:42PM +0900, Misono Tomohiro wrote: > > From: Stefan Hajnoczi > > > > If thread A is using an inode it must not be deleted by thread B when > > processing a FUSE_FORGET request. > > > > The FUSE protocol itself already has a counter called nlookup that is > > used in

[PATCH v3 18/86] arm:kzm: drop RAM size fixup

2020-01-16 Thread Igor Mammedov
If the user provided too large a RAM size, the code used to complain and trim it to the max size. Now tht RAM is allocated by generic code, that's no longer possible, so generate an error and exit instead. Signed-off-by: Igor Mammedov --- v3: * rephrase commit message in nicer way ("Chubb, P

Re: [PATCH] target/arm/arm-semi: fix SYS_OPEN to return nonzero filehandle

2020-01-16 Thread Peter Maydell
On Thu, 9 Jan 2020 at 04:13, Masahiro Yamada wrote: > > According to the specification "Semihosting for AArch32 and Aarch64", > the SYS_OPEN operation should return: > > - A nonzero handle if the call is successful > - -1 if the call is not successful > > So, it should never return 0. > > Prior

Re: [PATCH v2 08/86] arm:aspeed: actually check RAM size

2020-01-16 Thread Igor Mammedov
On Thu, 16 Jan 2020 09:41:03 +0100 Cédric Le Goater wrote: > On 1/15/20 4:06 PM, Igor Mammedov wrote: > > It's supposed that SOC will check if "-m" provided > > RAM size is valid by setting "ram-size" property and > > then board would read back valid (possibly corrected > > value) to map RAM Memo

[PATCH] docs: qemu-cpu-models: Document '-noTSX' variants and 'mds-no'

2020-01-16 Thread Kashyap Chamarthy
- Add the -noTSX variants for CascadeLake and SkyLake. - Add a note aboute the 'mds-no' MSR. Two confusing things about this: (1) The 'mds-no' will _not_ show up in the guest's /proc/cpuinfo. Rather it is used to fill in the guest's sysfs: sys/devices/system/cpu/vulnerabilities/

[PATCH] MAINTAINERS: update Leif Lindholm's address

2020-01-16 Thread Leif Lindholm
Update address to reflect new employer. Signed-off-by: Leif Lindholm --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 483edfbc0b..3c8653f26f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -735,7 +735,7 @@ F: include/hw/ssi/imx_spi

Re: [PATCH 093/104] virtiofsd: introduce inode refcount to prevent use-after-free

2020-01-16 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Thu, Jan 16, 2020 at 09:25:42PM +0900, Misono Tomohiro wrote: > > > From: Stefan Hajnoczi > > > > > > If thread A is using an inode it must not be deleted by thread B when > > > processing a FUSE_FORGET request. > > > > > > The FUSE protocol it

Re: [PATCH] MAINTAINERS: update Leif Lindholm's address

2020-01-16 Thread Leif Lindholm
On Thu, Jan 16, 2020 at 17:42:26 +, Leif Lindholm wrote: > Update address to reflect new employer. > > Signed-off-by: Leif Lindholm Reviewed-by: Leif Lindholm > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 48

Re: Extraneous nesting in QAPI schema

2020-01-16 Thread Christophe de Dinechin
> On 16 Dec 2019, at 17:59, Markus Armbruster wrote: > > Kevin suggested to investigate a more generic flattening solutions. > > Of course, flattening is only possible as long as there are no name > clashes. Or you could reverse the name sequence and allow the “upper” layers to disambiguate.

Re: [PATCH v2] i.MX: add an emulation for RNGC

2020-01-16 Thread Peter Maydell
On Wed, 8 Jan 2020 at 08:46, Martin Kaiser wrote: > > Add an emulation for the RNGC random number generator and the compatible > RNGB variant. These peripherals are included (at least) in imx25 and > imx35 chipsets. > > The emulation supports the initial self test, reseeding the prng and > reading

Re: [PATCH v2] target/arm: adjust program counter for wfi exception in AArch32

2020-01-16 Thread Peter Maydell
On Mon, 13 Jan 2020 at 15:59, Jeff Kubascik wrote: > > The wfi instruction can be configured to be trapped by a higher exception > level, such as the EL2 hypervisor. When the instruction is trapped, the > program counter should contain the address of the wfi instruction that > caused the exception

Re: [PATCH] arm/gicv3: update virtual irq state after IAR register read

2020-01-16 Thread Peter Maydell
On Mon, 13 Jan 2020 at 15:46, Jeff Kubascik wrote: > > The IAR0/IAR1 register is used to acknowledge an interrupt - a read of the > register activates the highest priority pending interrupt and provides its > interrupt ID. Activating an interrupt can change the CPU's virtual interrupt > state - th

[PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-16 Thread Olaf Hering
With commit 7fccf2a06890e3bc3b30e29827ad3fb93fe88fea a new member smbus_no_migration_support was added, and enabled in two places. With commit 4ab2f2a8aabfea95cc53c64e13b3f67960b27fdf the vmstate_acpi got new elements, which are conditionally filled. As a result, an incoming migration expected smbu

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Greg Kurz
On Thu, 16 Jan 2020 17:16:07 +0100 Christian Schoenebeck wrote: > On Donnerstag, 16. Januar 2020 14:15:03 CET Greg Kurz wrote: > > On Mon, 13 Jan 2020 23:21:04 +0100 > > > > Christian Schoenebeck wrote: > > > A client establishes a session by sending a Tversion request along with > > > a 'msize

Re: [PATCH 1/2] qdev: Introduce qdev_get_bus_device

2020-01-16 Thread Philippe Mathieu-Daudé
Hi Julia, Cc'ing Markus for the qdev/qbus analysis. On 1/15/20 11:40 PM, Julia Suvorova wrote: For bus devices, it is useful to be able to handle the parent device. Signed-off-by: Julia Suvorova --- hw/core/qdev.c | 5 + hw/pci-bridge/pci_expander_bridge.c | 4 ++

Re: [PATCH v2 10/86] arm:aspeed: use memdev for RAM

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 10:24 AM, Cédric Le Goater wrote: On 1/15/20 4:06 PM, Igor Mammedov wrote: memory_region_allocate_system_memory() API is going away, so replace it with memdev allocated MemoryRegion. The later is initialized by generic code, so board only needs to opt in to memdev scheme by providing

Re: [PATCH 3/3] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
On 1/16/20 6:26 AM, Alex Bennée wrote: >> +/* >> + * Perform the syscall. None of the vsyscalls should need restarting, >> + * and all faults should have been caught above. >> + */ >> +ret = do_syscall(env, syscall, env->regs[R_EDI], env->regs[R_ESI], >> + e

Re: [PATCH v3 1/5] multifd: Make sure that we don't do any IO after an error

2020-01-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 22 +- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index ba6e0eea15..8f9f3b

Re: [PATCH 3/3] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
On 1/16/20 8:19 AM, Richard Henderson wrote: > On 1/16/20 6:26 AM, Alex Bennée wrote: >>> +/* >>> + * Perform the syscall. None of the vsyscalls should need restarting, >>> + * and all faults should have been caught above. >>> + */ >>> +ret = do_syscall(env, syscall, env->regs[

Re: [PATCH v3 18/86] arm:kzm: drop RAM size fixup

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 6:26 PM, Igor Mammedov wrote: If the user provided too large a RAM size, the code used to complain and trim it to the max size. Now tht RAM is allocated by generic code, that's no longer possible, so generate an error and exit instead. Signed-off-by: Igor Mammedov --- v3: * rephra

Re: [PATCH] MAINTAINERS: update Leif Lindholm's address

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 6:42 PM, Leif Lindholm wrote: Update address to reflect new employer. Signed-off-by: Leif Lindholm --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 483edfbc0b..3c8653f26f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-16 Thread Paolo Bonzini
On 16/01/20 19:03, Olaf Hering wrote: > With commit 7fccf2a06890e3bc3b30e29827ad3fb93fe88fea a new member > smbus_no_migration_support was added, and enabled in two places. > With commit 4ab2f2a8aabfea95cc53c64e13b3f67960b27fdf the vmstate_acpi > got new elements, which are conditionally filled. As

Re: [PATCH] spapr: Fail CAS if option vector table cannot be parsed

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 5:13 PM, Greg Kurz wrote: On Thu, 16 Jan 2020 16:34:06 +0100 Philippe Mathieu-Daudé wrote: Hi Greg, Hi Phil, On 1/16/20 4:05 PM, Greg Kurz wrote: Most of the option vector helpers have assertions to check their arguments aren't null. The guest can provide an arbitrary address

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Greg Kurz
On Thu, 16 Jan 2020 13:14:35 +0100 Greg Kurz wrote: > On Thu, 16 Jan 2020 11:37:24 +0100 > Laurent Vivier wrote: > > > On 16/01/2020 09:48, Greg Kurz wrote: > > > On Wed, 15 Jan 2020 19:10:37 +0100 > > > Laurent Vivier wrote: > > > > > >> Hi, > > >> > > >> On 15/01/2020 18:48, Greg Kurz wrote

Fixed unknown audio format with SDL2

2020-01-16 Thread KJ Liew
SDL2 (version >=2.0) prefers float32 audio format over integer audio format. QEMU sdlaudio.c does not handle any kind of AUDIO_F32 formats, but SDL_OpenAudio(req, obt) will return float32 audio format in obt and QEMU prints error about unknown format 33056 (0x8120). The following simple patch

Re: [PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
On 1/16/20 4:30 AM, Alex Bennée wrote: > /x86_64-linux-user/qemu-x86_64 > ~/lsrc/linux.git/tools/testing/selftests/x86/test_vsyscall_64 > [WARN] failed to find vDSO > no vsyscall map in /proc/self/maps > [RUN] test gettimeofday() > [RUN] test time() > [RUN] getcpu() on CPU 0 > [RUN]

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-16 Thread Olaf Hering
Am Thu, 16 Jan 2020 19:26:39 +0100 schrieb Paolo Bonzini : > xenfv does not support cross-version migration compatibility. Wait, what does that mean? So far live migration of a running domU must be possible from Xen N to Xen N+1. It would be more than unexpected if the target host running "Xen N+

[PATCH v2] spapr: Fail CAS if option vector table cannot be parsed

2020-01-16 Thread Greg Kurz
Most of the option vector helpers have assertions to check their arguments aren't null. The guest can provide an arbitrary address for the CAS structure that would result in such null arguments. Fail CAS with H_PARAMETER and print a warning instead of aborting QEMU. Signed-off-by: Greg Kurz Revie

Re: [PATCH v1 1/2] target/arm: detect 64 bit overflow caused by high cval + voff

2020-01-16 Thread Peter Maydell
On Fri, 10 Jan 2020 at 16:16, Alex Bennée wrote: > > If we don't detect this we will be stuck in a busy loop as we schedule > a timer for before now which will continually trigger gt_recalc_timer > even though we haven't reached the state required to trigger the IRQ. > > Bug: https://bugs.launchpa

Re: [PATCH v2] hw/i386: disable smbus migration for xenfv

2020-01-16 Thread Paolo Bonzini
Il gio 16 gen 2020, 19:33 Olaf Hering ha scritto: > Am Thu, 16 Jan 2020 19:26:39 +0100 > schrieb Paolo Bonzini : > > > xenfv does not support cross-version migration compatibility. > > Wait, what does that mean? > So far live migration of a running domU must be possible from Xen N to Xen > N+1. >

[Bug 1859989] Re: qemu-img has broken output with large snapshot names

2020-01-16 Thread pevogam
** Description changed: - On Qemu 4.1.1 the output of snalshots breaks if the chosen state name is + On Qemu 4.1.1 the output of snapshots breaks if the chosen state name is too long: ``` # qemu-img snapshot -l /mnt/local/some_image.qcow2 Snapshot list: IDTAG V

Re: [PATCH 0/3] linux-user: Implement x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
On 1/16/20 4:05 AM, Alex Bennée wrote: > It turns out the /sbin/ldconfig crash is a regression w.r.t from > stretch->buster so unrelated to these patches. However I've been giving > them a spin with the linux vdso selftests and stuff is breaking which I > guess means it's incomplete? ... > Also fro

[PATCH v2 0/5] linux-user: Implement x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
Changes since v2: * Add /proc/self/maps line I'm not sure this is really necessary. The linux kernel self-test checks for it, and modifies the set of tests that it runs based on it. But otherwise I think it's unused. * Fix errors in base gettimeofday syscall

[PATCH v2 2/5] linux-user/i386: Split out gen_signal

2020-01-16 Thread Richard Henderson
This is a bit tidier than open-coding the 5 lines necessary to initialize the target_siginfo_t. In addition, this zeros the remaining bytes of the target_siginfo_t, rather than passing in garbage. Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-of

[PATCH v2 5/5] linux-user: Flush out implementation of gettimeofday

2020-01-16 Thread Richard Henderson
The first argument, timeval, is allowed to be NULL. The second argument, timezone, was missing. While its use is deprecated, it is still present in the syscall. Signed-off-by: Richard Henderson --- linux-user/syscall.c | 27 +-- 1 file changed, 25 insertions(+), 2 delet

[PATCH v2 1/5] target/i386: Renumber EXCP_SYSCALL

2020-01-16 Thread Richard Henderson
We are not short of numbers for EXCP_*. There is no need to confuse things by having EXCP_VMEXIT and EXCP_SYSCALL overlap, even though the former is only used for system mode and the latter is only used for user mode. Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mat

[PATCH v2 4/5] linux-user: Add x86_64 vsyscall page to /proc/self/maps

2020-01-16 Thread Richard Henderson
The page isn't (necessarily) present in the host /proc/self/maps, and even if it might be it isn't present in page_flags, and even if it was it might not have the same set of page permissions. The easiest thing to do, particularly when it comes to the "[vsyscall]" note at the end of line, is to sp

Re: [PATCH v2 0/5] linux-user: Implement x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
On 1/16/20 9:43 AM, Richard Henderson wrote: > Changes since v2: > > * Add /proc/self/maps line > > I'm not sure this is really necessary. The linux kernel > self-test checks for it, and modifies the set of tests that > it runs based on it. But otherwise I think it's unused.

[PATCH v2 3/5] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-16 Thread Richard Henderson
Notice the magic page during translate, much like we already do for the arm32 commpage. At runtime, raise an exception to return cpu_loop for emulation. Reviewed-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/i386/cpu.h | 1 + linux-user/i386/cpu_loop.c | 105

Re: [PATCH 3/3] linux-user/i386: Emulate x86_64 vsyscalls

2020-01-16 Thread Alex Bennée
Richard Henderson writes: > On 1/16/20 6:26 AM, Alex Bennée wrote: >>> +/* >>> + * Perform the syscall. None of the vsyscalls should need restarting, >>> + * and all faults should have been caught above. >>> + */ >>> +ret = do_syscall(env, syscall, env->regs[R_EDI], env->re

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-16 Thread Matthew Rosato
On 1/16/20 7:20 AM, Thomas Huth wrote: The AIS feature has been disabled late in the v2.10 development cycle since there were some issues with migration (see commit 3f2d07b3b01ea61126b - "s390x/ais: for 2.10 stable: disable ais facility"). We originally wanted to enable it again for newer machine

[PATCH v3 0/2] Fix hyperv synic on vhost

2020-01-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hyperv's synic (that we emulate) is a feature that allows the guest to place some magic (4k) pages of RAM anywhere it likes in GPA. This confuses vhost's RAM section merging when these pages land over the top of hugepages. This v3 takes a different approach to v2 a

[PATCH v3 1/2] vhost: Add names to section rounded warning

2020-01-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add the memory region names to section rounding/alignment warnings. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 4da0d5a6c5..774d

[PATCH v3 2/2] vhost: Only align sections for vhost-user

2020-01-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I added hugepage alignment code in c1ece84e7c9 to deal with vhost-user + postcopy which needs aligned pages when using userfault. However, on x86 the lower 2MB of address space tends to be shotgun'd with small fragments around the 512-640k range - e.g. video RAM, an

[PATCH] qapi: Fix code generation with Python 3.5

2020-01-16 Thread Markus Armbruster
Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from for entity in self._entity_list: effectively to for mod in self._module_dict.values(): for entity in mod._entity_list: Visits in the same order as long as .values() i

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-16 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: > Am 16.01.20 um 13:47 schrieb Peter Lieven: > > Am 13.01.20 um 17:25 schrieb Peter Lieven: > > > Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: > > > > * Peter Lieven (p...@kamp.de) wrote: > > > > > Am 08.01.20 um 16:04 schrieb Dr. David Alan Gilbert: > >

Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again

2020-01-16 Thread Cornelia Huck
On Thu, 16 Jan 2020 15:19:13 -0500 Matthew Rosato wrote: > On 1/16/20 7:20 AM, Thomas Huth wrote: > > The AIS feature has been disabled late in the v2.10 development > > cycle since there were some issues with migration (see commit > > 3f2d07b3b01ea61126b - "s390x/ais: for 2.10 stable: disable ai

[Bug 1859713] Re: ARM v8.3a pauth not working

2020-01-16 Thread Vincent Dehors
Hi, Here is a patch for this bug. The sbox function was using "b+=16" instead of "b+=4". Also, you check test vector using : ```c uint64_t P = 0xfb623599da6e8127ull; uint64_t T = 0x477d469dec0b8762ull; uint64_t w0 = 0x84be85ce9804e94bull; uint64_t k0 = 0xec2802d4e0a488e9ull;

[PATCH v2 0/4] vl: Fixes for cleanups to -accel

2020-01-16 Thread Richard Henderson
Running qemu-system-foo with no options should not generate a warning for "invalid accelerator bar". Changes in v2: * Rebase on master, getting the free accel_list fix from upstream. Re-word the resulting patch 2 to merely reduce the scope of the local variables. * Use g_str_has_suffix

[PATCH v2 1/4] vl: Remove unused variable in configure_accelerators

2020-01-16 Thread Richard Henderson
The accel_initialised variable no longer has any setters. Fixes: 6f6e1698a68c Acked-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed by: Aleksandar Markovic Signed-off-by: Richard Henderson --- vl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-

[PATCH v2 4/4] vl: Only choose enabled accelerators in configure_accelerators

2020-01-16 Thread Richard Henderson
By choosing "tcg:kvm" when kvm is not enabled, we generate an incorrect warning: "invalid accelerator kvm". At the same time, use g_str_has_suffix rather than open-coding the same operation. Presumably the inverse is also true with --disable-tcg. Fixes: 28a0961757fc Acked-by: Paolo Bonzini Revi

[PATCH v2 3/4] vl: Remove useless test in configure_accelerators

2020-01-16 Thread Richard Henderson
The result of g_strsplit is never NULL. Acked-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed by: Aleksandar Markovic Signed-off-by: Richard Henderson --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 3e2b77

[PATCH v2 2/4] vl: Reduce scope of variables in configure_accelerators

2020-01-16 Thread Richard Henderson
The accel_list and tmp variables are only used when manufacturing -machine accel, options based on -accel. Acked-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed by: Aleksandar Markovic Signed-off-by: Richard Henderson --- v2: The freeing of accel_list was fixed in adb464ff671d. --- vl.c |

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-16 Thread Peter Lieven
> Am 16.01.2020 um 21:26 schrieb Dr. David Alan Gilbert : > > * Peter Lieven (p...@kamp.de) wrote: >> Am 16.01.20 um 13:47 schrieb Peter Lieven: >>> Am 13.01.20 um 17:25 schrieb Peter Lieven: Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: > * Peter Lieven (p...@kamp.de) wrote: >>

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-16 Thread John Snow
On 1/16/20 3:25 PM, Markus Armbruster wrote: > Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" > modules" switched QAPISchema.visit() from > > for entity in self._entity_list: > > effectively to > > for mod in self._module_dict.values(): > for entity in

Re: [PATCH v3 02/11] 9pfs: require msize >= 4096

2020-01-16 Thread Christian Schoenebeck
On Donnerstag, 16. Januar 2020 19:07:48 CET Greg Kurz wrote: > > The point here was that there must be some kind of absolute minimum msize, > > Then the absolute minimum size is 7, the size of the header part that is > common to all messages: > > size[4] Message tag[2] > > > even though the prot

[Bug 1859713] Re: ARM v8.3a pauth not working

2020-01-16 Thread Richard Henderson
Ooof. Good catch on the sbox error. That said, how did you test pauth_computepac? I still do not get the C5 result above, but 0x99d88f4472f3be39. The following test case sets up the parameters. ** Patch added: "test case" https://bugs.launchpad.net/qemu/+bug/1859713/+attachment/5320967/+fil

[Bug 1859713] Re: ARM v8.3a pauth not working

2020-01-16 Thread Richard Henderson
Oops again. The test case has the parts of the key the wrong way around. I'll submit the pair of patches to the mailing list. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859713 Title: ARM v8.3a

[PATCH 12/12] linux-user: Add support for KCOV_INIT_TRACE ioctl

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic KCOV_INIT_TRACE ioctl plays the role in kernel coverage tracing. This ioctl's third argument is of type 'unsigned long', and the implementation in QEMU is straightforward. Reviewed-by: Laurent Vivier Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h |

[PATCH 02/12] linux-user: Add support for FS_IOC32_FLAGS ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic These FS_IOC32_FLAGS ioctls are identical to FS_IOC_FLAGS ioctls, but without the anomaly of their number defined as if their third argument is of type long, while it is treated internally in kernel as is of type int. Reviewed-by: Laurent Vivier Signed-off-by: Aleksand

[PATCH 03/12] linux-user: Add support for FS_IOC32_VERSION ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic These FS_IOC32_VERSION ioctls are identical to FS_IOC_VERSION ioctls, but without the anomaly of their number defined as if their third argument is of type long, while it is treated internally in kernel as is of type int. Reviewed-by: Laurent Vivier Signed-off-by: Alek

[PATCH 00/12] linux-user: Add support for fs, fd,and kcov ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic This series is a spin-off of v5 of earlier series "linux-user: Misc patches for 5.0", that became too large to manage. I will submit the rest of that large series separately. The only difference between patches in this series and in the former series is that all Laurent

[PATCH 06/12] linux-user: Add support for FIFREEZE and FITHAW ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic Both FIFREEZE and FITHAW ioctls accept an integer as their third argument. All ioctls in this group (FI* ioctl) are guarded with "#ifdef", so the guards are used in this implementation too for consistency (however, many of ioctls in FI* group became old enough that thei

[PATCH 05/12] linux-user: Add support for FITRIM ioctl

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic FITRIM ioctl accepts a pointer to the structure struct fstrim_range { __u64 start; __u64 len; __u64 minlen; }; as its third argument. All ioctls in this group (FI* ioctl) are guarded with "#ifdef", so the guards are used in this implementation too for cons

[PATCH 01/12] linux-user: Add support for FS_IOC_VERSION ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic A very specific thing for these two ioctls is that their code implies that their third argument is of type 'long', but the kernel uses that argument as if it is of type 'int'. This anomaly is recognized also in commit 6080723 (linux-user: Implement FS_IOC_GETFLAGS and FS

[PATCH 07/12] linux-user: Add support for FD ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands for controlling error reporting of a floppy drive. FDSETEMSGTRESH's third agrument is a pointer to the structure: struct floppy_max_errors { unsigned int abort, /* number of errors to be

[PATCH 10/12] configure: Detect kcov support and introduce CONFIG_KCOV

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic kcov is kernel code coverage tracing tool. It requires kernel 4.4+ compiled with certain kernel options. This patch checks if kcov header "sys/kcov.h" is present on build machine, and stores the result in variable CONFIG_KCOV, meant to be used in linux-user code related

[PATCH 11/12] linux-user: Add support for KCOV_ ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic KCOV_ENABLE and KCOV_DISABLE play the role in kernel coverage tracing. These ioctls do not use the third argument of ioctl() system call and are straightforward to implement in QEMU. Reviewed-by: Laurent Vivier Signed-off-by: Aleksandar Markovic --- linux-user/ioctls

[PATCH 09/12] linux-user: Add support for FDGETFDCSTAT ioctl

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic FDGETFDCSTAT's third agrument is a pointer to the structure: struct floppy_fdc_state { int spec1; int spec2; int dtr; unsigned char version; unsigned char dor; unsigned long address; unsigned int rawcmd:2; unsigned int reset:1; unsign

[PATCH 08/12] linux-user: Add support for FDFMT ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls provide means for controlling formatting of a floppy drive. FDFMTTRK's third agrument is a pointer to the structure: struct format_descr { unsigned int device,head,track; }; defined in Linux kernel header . Since all fields

[PATCH 04/12] linux-user: Add support for FS_IOC_FSXATTR ioctls

2020-01-16 Thread Aleksandar Markovic
From: Aleksandar Markovic Both FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR accept a pointer to the structure struct fsxattr { __u32 fsx_xflags; /* xflags field value (get/set) */ __u32 fsx_extsize;/* extsize field value (get/set)*/ __u32 fsx_nextents; /*

[PATCH 0/4] target/arm: Fix ComputePAC (LP 1859713)

2020-01-16 Thread Richard Henderson
Thanks to Vincent and Adrien for both reporting the bug and providing the solution. I've converted their manual testing into executable tests. r~ Richard Henderson (3): tests/tcg/aarch64: Fix compilation parameters for pauth-% tests/tcg/aarch64: Add pauth-3 tests/tcg/aarch64: Add pauth-4

[PATCH 3/4] tests/tcg/aarch64: Add pauth-3

2020-01-16 Thread Richard Henderson
This is the test vector from the QARMA paper, run through PACGA. Suggested-by: Vincent Dehors Signed-off-by: Richard Henderson --- tests/tcg/aarch64/system/pauth-3.c| 40 +++ tests/tcg/aarch64/Makefile.softmmu-target | 5 ++- 2 files changed, 44 insertions(+), 1 del

[PATCH 2/4] tests/tcg/aarch64: Fix compilation parameters for pauth-%

2020-01-16 Thread Richard Henderson
Hiding the required architecture within asm() is not correct. Add it to the cflags of the (cross-) compiler. Signed-off-by: Richard Henderson --- tests/tcg/aarch64/pauth-1.c | 2 -- tests/tcg/aarch64/pauth-2.c | 2 -- tests/tcg/aarch64/Makefile.target | 1 + 3 files changed, 1 insert

[PATCH 4/4] tests/tcg/aarch64: Add pauth-4

2020-01-16 Thread Richard Henderson
Perform the set of operations and test described in LP 1859713. Suggested-by: Adrien GRASSEIN Signed-off-by: Richard Henderson --- tests/tcg/aarch64/pauth-4.c | 25 + tests/tcg/aarch64/Makefile.target | 2 +- 2 files changed, 26 insertions(+), 1 deletion(-) creat

Re: [PATCH 0/4] migration: Replace gemu_log with qemu_log

2020-01-16 Thread Josh Kunz
On Tue, Jan 14, 2020 at 3:02 AM Alex Bennée wrote: > > Josh Kunz writes: > > > > > > Not tested: > > * Build/logging with bsd-user. I do not have easy access to a BSD > > system. > > If you have the time we have vm-build-netbsd: > > make vm-build-netbsd EXTRA_CONFIGURE_OPTS="--disable-syste

Re: [PATCH 0/4] migration: Replace gemu_log with qemu_log

2020-01-16 Thread Josh Kunz
On Mon, Jan 13, 2020 at 7:06 PM Warner Losh wrote: > The bsd-user that is in tree doesn't work. I've been trying to catch up to > qemu head of tree, but I'm only up to 3.2... chances are the bsd-user > changes will not change the state of things... > Ah good to know. Would you all prefer I don't

[PATCH 1/4] target/arm: Fix PAuth sbox functions

2020-01-16 Thread Richard Henderson
From: Vincent Dehors In the PAC computation, sbox was applied over wrong bits. As this is a 4-bit sbox, bit index should be incremented by 4 instead of 16. Test vector from QARMA paper (https://eprint.iacr.org/2016/444.pdf) was used to verify one computation of the pauth_computepac() function wh

Re: [PATCH v2 4/4] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-01-16 Thread Alberto Garcia
On Tue 14 Jan 2020 03:15:48 PM CET, Max Reitz wrote: >> @@ -219,7 +219,7 @@ static int l2_load(BlockDriverState *bs, uint64_t offset, >> * Writes one sector of the L1 table to the disk (can't update single >> entries >> * and we really don't want bdrv_pread to perform a read-modify-write) >>

[Bug 1860053] [NEW] Possible lack of precision when calling clock_gettime via vDSO on user mode ppc64le

2020-01-16 Thread Patrick Meiring
Public bug reported: Occurs on QEMU v4.2.0 run on docker (via the qemu-user-static:v4.2.0-2 image) on an AMD64 Ubuntu 18.04.3 LTS machine provided by travis-ci.org. >From golang's https://github.com/golang/go/issues/36592: It was discovered that golang's time.NewTicker() and time.Sleep() malfunc

Re: [PATCH] util/cacheinfo: fix crash when compiling with uClibc

2020-01-16 Thread Richard Henderson
On 12/16/19 1:18 AM, Carlos Santos wrote: > On Thu, Oct 17, 2019 at 8:06 PM Carlos Santos wrote: >> >> On Thu, Oct 17, 2019 at 9:47 AM Peter Maydell >> wrote: >>> >>> On Thu, 17 Oct 2019 at 13:39, wrote: From: Carlos Santos uClibc defines _SC_LEVEL1_ICACHE_LINESIZE and _SC_

Re: [PATCH v3 0/2] Fix hyperv synic on vhost

2020-01-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200116202414.157959-1-dgilb...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200116202414.157959-1-dgilb...@redhat.com Type: series Subject: [PATCH v3 0/2] Fix hyperv synic on

Re: [PATCH V2] vhost-user-test: fix a memory leak

2020-01-16 Thread Pan Nengyuan
On 1/16/2020 9:29 PM, Thomas Huth wrote: > On 15/01/2020 10.13, Thomas Huth wrote: >> On 15/01/2020 04.10, Pan Nengyuan wrote: >>> >>> On 1/13/2020 10:32 AM, Pan Nengyuan wrote: On 1/12/2020 6:39 PM, Thomas Huth wrote: >> [...] > ... and now I had to unqueue the patch again. It is

[PATCH v2 0/2] target/arm: Fix ISSIs16Bit

2020-01-16 Thread Richard Henderson
Changes in v2: - Include the merge_syn_data_abort fix, as a self-contained patch. r~ Jeff Kubascik (1): target/arm: Return correct IL bit in merge_syn_data_abort Richard Henderson (1): target/arm: Set ISSIs16Bit in make_issinfo target/arm/tlb_helper.c | 2 +- target/arm/translate.c |

[PATCH v2 2/2] target/arm: Set ISSIs16Bit in make_issinfo

2020-01-16 Thread Richard Henderson
During the conversion to decodetree, the setting of ISSIs16Bit got lost. This causes the guest os to incorrectly adjust trapping memory operations. Cc: qemu-sta...@nongnu.org Fixes: 46beb58efbb8a2a32 ("target/arm: Convert T16, load (literal)") Reported-by: Jeff Kubascik Signed-off-by: Richard He

[PATCH v2 1/2] target/arm: Return correct IL bit in merge_syn_data_abort

2020-01-16 Thread Richard Henderson
From: Jeff Kubascik The IL bit is set for 32-bit instructions, thus passing false with the is_16bit parameter to syn_data_abort_with_iss() makes a syn mask that always has the IL bit set. Pass is_16bit as true to make the initial syn mask have IL=0, so that the final IL value comes from or'ing t

RE: [PATCH 093/104] virtiofsd: introduce inode refcount to prevent use-after-free

2020-01-16 Thread misono.tomoh...@fujitsu.com
> > On Thu, Jan 16, 2020 at 09:25:42PM +0900, Misono Tomohiro wrote: > > > > From: Stefan Hajnoczi > > > > > > > > If thread A is using an inode it must not be deleted by thread B > > > > when processing a FUSE_FORGET request. > > > > > > > > The FUSE protocol itself already has a counter called n

Re: [PATCH] target/openrisc: Fix FPCSR mask to allow setting DZF

2020-01-16 Thread Richard Henderson
On 1/10/20 11:28 AM, Stafford Horne wrote: > The mask used when setting FPCSR allows setting bits 10 to 1. However, > OpenRISC has flags and config bits in 11 to 1, 11 being Divide by Zero > Flag (DZF). This seems like an off-by-one bug. > > This was found when testing the GLIBC test suite which

[PULL 1/1] target/openrisc: Fix FPCSR mask to allow setting DZF

2020-01-16 Thread Richard Henderson
From: Stafford Horne The mask used when setting FPCSR allows setting bits 10 to 1. However, OpenRISC has flags and config bits in 11 to 1, 11 being Divide by Zero Flag (DZF). This seems like an off-by-one bug. This was found when testing the GLIBC test suite which has test cases to set and cle

[PULL 0/1] target/openrisc patch queue

2020-01-16 Thread Richard Henderson
The following changes since commit 28b58f19d269633b3d14b6aebf1e92b3cd3ab56e: ui/gtk: Get display refresh rate with GDK version 3.22 or later (2020-01-16 14:03:45 +) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-or1k-20200116 for you to fetch

[Bug 1860056] [NEW] mips binaries segfault

2020-01-16 Thread mcandre
Public bug reported: Hello World appears to segfault with qemu mips, on a Debian 10.0.0 Buster amd64 host. Example: $ cat mips/test/hello.cpp #include using std::cout; int main() { cout << "Hello World!\n"; return 0; } $ mips-linux-gnu-g++ -o hello hello.cpp && ./hello qemu: uncaugh

Re: [PATCH v2 0/3] hw/hppa/machine: Restrict the total memory size to 3GB

2020-01-16 Thread Richard Henderson
On 1/8/20 2:05 PM, Philippe Mathieu-Daudé wrote: > Following the discussion of Igor's patch "hppa: allow max > ram size upto 4Gb" [1] I tried to simplify the current > code so Igor's series doesn't change the CLI with this > machine. > > v2: Simplify by limiting to 3GB (Helge review) > > [1] http

RE: [PATCH RFC 01/12] migration: Add multiRDMA capability support

2020-01-16 Thread fengzhimin
Thanks for your review. I will modify its according to your suggestions. -Original Message- From: Juan Quintela [mailto:quint...@redhat.com] Sent: Thursday, January 16, 2020 9:19 PM To: Dr. David Alan Gilbert Cc: fengzhimin ; arm...@redhat.com; ebl...@redhat.com; qemu-devel@nongnu.org;

RE: [PATCH RFC 04/12] migration/rdma: Create multiRDMA migration threads

2020-01-16 Thread fengzhimin
Thanks for your review. I will merge this with multifd. -Original Message- From: Juan Quintela [mailto:quint...@redhat.com] Sent: Thursday, January 16, 2020 9:25 PM To: fengzhimin Cc: dgilb...@redhat.com; arm...@redhat.com; ebl...@redhat.com; qemu-devel@nongnu.org; Zhanghailiang ; jemm

  1   2   3   4   >