Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Guoheyi
Hi Michael, Any more comments? Or shall I refine the commit message? Thanks, Heyi 在 2020/1/6 10:10, Guoheyi 写道: 在 2020/1/5 20:53, Michael S. Tsirkin 写道: On Sun, Jan 05, 2020 at 07:34:01AM -0500, Michael S. Tsirkin wrote: On Thu, Dec 19, 2019 at 02:47:59PM +0800, Heyi Guo wrote: According

Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-13 Thread Paul Durrant
On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy wrote: [snip] > +/* > + * ERRP_AUTO_PROPAGATE > + * > + * This macro is created to be the first line of a function which use > + * Error **errp parameter to report error. It's needed only in cases where we > + * want to use error_prepend,

Re: [PATCH v6 11/11] xen: introduce ERRP_AUTO_PROPAGATE

2020-01-13 Thread Paul Durrant
On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy wrote: > > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &error_fatal > (the program will exit prior to t

Re: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-13 Thread Igor Mammedov
On Fri, 10 Jan 2020 02:56:35 + "Zengtao (B)" wrote: > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: Thursday, January 09, 2020 5:54 PM > > To: Zengtao (B) > > Cc: Michael S. Tsirkin; qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > > Shannon Zhao

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-13 Thread Andrea Bolognani
On Wed, 2020-01-08 at 13:34 +1100, Alexey Kardashevskiy wrote: > On 07/01/2020 20:39, Andrea Bolognani wrote: > > On Tue, 2020-01-07 at 12:55 +1100, Alexey Kardashevskiy wrote: > > > Petitboot kernel+initramdisk almost replaces SLOF + GRUB. > > > > Is this necessarily a good thing? > > The bare m

Re: [PATCH v4 19/24] nvme: handle dma errors

2020-01-13 Thread Klaus Birkelund Jensen
On Jan 9 11:35, Beata Michalska wrote: > Hi Klaus, > Hi Beata, Your reviews are, as always, much appreciated! Thanks! > On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote: > > @@ -1595,7 +1611,12 @@ static void nvme_process_sq(void *opaque) > > > > while (!(nvme_sq_empty(sq) || QTAILQ_EMPT

Re: [PATCH v28 17/22] hw/rx: RX Target hardware definition

2020-01-13 Thread Igor Mammedov
On Sun, 12 Jan 2020 21:49:08 +0900 Yoshinori Sato wrote: > rx62n - RX62N cpu. > rx-virt - RX QEMU virtual target. > > v23 changes. > Add missing includes. > > v21 changes. > rx_load_image move to rx-virt.c > > Signed-off-by: Yoshinori Sato > > Message-Id: <20190616142836.10614-17-ys...@users

Re: [PATCH v4 17/24] nvme: allow multiple aios per command

2020-01-13 Thread Klaus Birkelund Jensen
On Jan 9 11:40, Beata Michalska wrote: > Hi Klaus, > > On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote: > > +static NvmeAIO *nvme_aio_new(BlockBackend *blk, int64_t offset, size_t len, > > +QEMUSGList *qsg, QEMUIOVector *iov, NvmeRequest *req, > > +NvmeAIOCompletionFunc *cb) > > Minor:

Re: [PATCH v6 02/11] error: auto propagated local_err

2020-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2020 11:50, Paul Durrant wrote: > On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy > wrote: > [snip] >> +/* >> + * ERRP_AUTO_PROPAGATE >> + * >> + * This macro is created to be the first line of a function which use >> + * Error **errp parameter to report error. It's needed only in

Re: [PATCH v6 11/11] xen: introduce ERRP_AUTO_PROPAGATE

2020-01-13 Thread Vladimir Sementsov-Ogievskiy
13.01.2020 11:57, Paul Durrant wrote: > On Fri, 10 Jan 2020 at 19:42, Vladimir Sementsov-Ogievskiy > wrote: >> >> If we want to add some info to errp (by error_prepend() or >> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. >> Otherwise, this info will not be added when errp == &e

Re: [PATCH v4 20/24] nvme: add support for scatter gather lists

2020-01-13 Thread Klaus Birkelund Jensen
On Jan 9 11:44, Beata Michalska wrote: > Hi Klaus, > > On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote: > > @@ -73,7 +73,12 @@ static inline bool nvme_addr_is_cmb(NvmeCtrl *n, hwaddr > > addr) > > > > static int nvme_addr_read(NvmeCtrl *n, hwaddr addr, void *buf, int size) > > { > > -if

Re: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.01.2020 um 07:13 hat Pavel Dovgalyuk geschrieben: >> Ping. > > I think you have my Acked-by for the block-related patches in this > series now. If I missed something, please let me know. Pavel, whom are you nudging to do what?

RE: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-13 Thread Pavel Dovgalyuk
> From: Markus Armbruster [mailto:arm...@redhat.com] > Kevin Wolf writes: > > > Am 09.01.2020 um 07:13 hat Pavel Dovgalyuk geschrieben: > >> Ping. > > > > I think you have my Acked-by for the block-related patches in this > > series now. If I missed something, please let me know. > > Pavel, whom

RE: [PATCH] xhci: Fix memory leak in xhci_kick_epctx when poweroff GuestOS

2020-01-13 Thread Chenqun (kuhn)
>-Original Message- >From: Gerd Hoffmann [mailto:kra...@redhat.com] >Sent: Monday, January 13, 2020 3:48 PM >To: Philippe Mathieu-Daudé >Cc: Chenqun (kuhn) ; qemu- >de...@nongnu.org; qemu-triv...@nongnu.org; Pannengyuan >; Zhanghailiang > >Subject: Re: [PATCH] xhci: Fix memory leak in xhci

Re: [PATCH v2] hw/usb: Introduce Kconfig switches for the CCID card devices

2020-01-13 Thread Gerd Hoffmann
On Tue, Jan 07, 2020 at 08:36:07AM +0100, Gerd Hoffmann wrote: > On Wed, Dec 11, 2019 at 11:20:29AM +0100, Thomas Huth wrote: > > In our downstream distribution of QEMU, we need more fine-grained > > control on the set of CCID card devices that we want to include. > > So let's introduce some proper

Re: [PATCH 1/2] qcow2: introduce Qcow2Metadata structure

2020-01-13 Thread Andrey Shinkevich
On 08/01/2020 01:07, Eric Blake wrote: > On 12/27/19 5:43 AM, Andrey Shinkevich wrote: >> The preliminary patch to provide an extendable structure for dumping >> QCOW2 metadata allocations in image. >> >> Suggested-by: Vladimir Sementsov-Ogievskiy >> Signed-off-by: Andrey Shinkevich >> --- >>

Re: [PULL 00/38] Misc patches for 2020-01-08

2020-01-13 Thread Peter Maydell
On Wed, 8 Jan 2020 at 12:37, Paolo Bonzini wrote: > > The following changes since commit c4d1069c2563f70a5271af6e9e000add64e593be: > > Merge remote-tracking branch > 'remotes/elmarco/tags/dbus-vmstate7-pull-request' into staging (2020-01-06 > 18:22:42 +) > > are available in the git reposi

[Bug 1859418] [NEW] disk driver with iothread setting hangs live migrations

2020-01-13 Thread Mark Zealey
Public bug reported: Per report raised at https://bugzilla.redhat.com/show_bug.cgi?id=1790093 Description of problem: A disk driver definition using iothread parameter causes live migration with copy storage to hang during or just before the final ram sync stage. Interestingly, having the scsi

Re: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-13 Thread Kevin Wolf
Am 13.01.2020 um 10:35 hat Pavel Dovgalyuk geschrieben: > > From: Markus Armbruster [mailto:arm...@redhat.com] > > Kevin Wolf writes: > > > > > Am 09.01.2020 um 07:13 hat Pavel Dovgalyuk geschrieben: > > >> Ping. > > > > > > I think you have my Acked-by for the block-related patches in this > > >

Re: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-13 Thread Peter Maydell
On Mon, 13 Jan 2020 at 10:07, Kevin Wolf wrote: > In MAINTAINERS, you are listed yourself as the maintainer for > record/replay. I wonder whether you shouldn't just be sending pull > requests after getting Acked-by or Reviewed-by from the maintainers of > other subsystems you touch. Ideally someb

Re: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-13 Thread Kevin Wolf
Am 13.01.2020 um 11:14 hat Peter Maydell geschrieben: > On Mon, 13 Jan 2020 at 10:07, Kevin Wolf wrote: > > In MAINTAINERS, you are listed yourself as the maintainer for > > record/replay. I wonder whether you shouldn't just be sending pull > > requests after getting Acked-by or Reviewed-by from t

Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Andrey Shinkevich
On 08/01/2020 01:11, Eric Blake wrote: > On 12/27/19 5:43 AM, Andrey Shinkevich wrote: >> Let QEMU-IMG CHECK command show QCOW2 structure to inform a user about >> metadata allocations on disk. Introduce '-M'('--dump-meta') key option. >> >> Suggested-by: Vladimir Sementsov-Ogievskiy >> Signed-o

[PATCH] docs/devel: fix stable process doc formatting

2020-01-13 Thread Cornelia Huck
Enumeration of stable criteria needs proper bullet points. Signed-off-by: Cornelia Huck --- docs/devel/stable-process.rst | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/devel/stable-process.rst b/docs/devel/stable-process.rst index 98736a9ea487..e541b983fac7 10064

[qemu-web PATCH] documentation: update links to readthedocs

2020-01-13 Thread Alex Bennée
..and extemporise a little about their state. Signed-off-by: Alex Bennée --- documentation.md | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/documentation.md b/documentation.md index f4ef9f4..55d5db6 100644 --- a/documentation.md +++ b/documentation.md @@ -3,9 +3,12

Re: [PATCH v6 08/11] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2020-01-13 Thread Greg Kurz
On Fri, 10 Jan 2020 22:41:55 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == &error_fatal > (the program will exit prior

Re: [PATCH 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-13 Thread Kevin Wolf
Am 10.01.2020 um 20:00 hat Eric Blake geschrieben: > On 1/9/20 12:35 PM, Kevin Wolf wrote: > > This patch adds a new 'coroutine' flag to QMP command definitions that > > tells the QMP dispatcher than the command handler is safe to be run in a > > s/than/that/ Thanks. If this remains the only chan

Re: [for-5.0 PATCH 00/11] Support for reverse debugging with GDB

2020-01-13 Thread Peter Maydell
On Mon, 13 Jan 2020 at 10:27, Kevin Wolf wrote: > > Am 13.01.2020 um 11:14 hat Peter Maydell geschrieben: > > On Mon, 13 Jan 2020 at 10:07, Kevin Wolf wrote: > > > In MAINTAINERS, you are listed yourself as the maintainer for > > > record/replay. I wonder whether you shouldn't just be sending pul

Re: [PATCH v3 04/15] block/io_uring: implements interfaces for io_uring

2020-01-13 Thread Stefano Garzarella
On Wed, Dec 18, 2019 at 04:32:17PM +, Stefan Hajnoczi wrote: > From: Aarushi Mehta > > Aborts when sqe fails to be set as sqes cannot be returned to the > ring. Adds slow path for short reads for older kernels > > Signed-off-by: Aarushi Mehta > Signed-off-by: Stefan Hajnoczi > --- > v11: >

Re: [PULL 0/5] Trivial branch patches

2020-01-13 Thread Peter Maydell
On Wed, 8 Jan 2020 at 16:02, Laurent Vivier wrote: > > The following changes since commit 035eed4c0d257c905a556fa0f4865a0c077b4e7f: > > Merge remote-tracking branch > 'remotes/vivier/tags/q800-for-5.0-pull-request' into staging (2020-01-07 > 17:08:21 +) > > are available in the Git reposit

Re: [PATCH v3 08/15] block/file-posix.c: extend to use io_uring

2020-01-13 Thread Stefano Garzarella
On Wed, Dec 18, 2019 at 04:32:21PM +, Stefan Hajnoczi wrote: > From: Aarushi Mehta > > Signed-off-by: Aarushi Mehta > Reviewed-by: Maxim Levitsky > Signed-off-by: Stefan Hajnoczi > --- > block/file-posix.c | 95 -- > 1 file changed, 75 insertion

Re: [PATCH v3 00/15] io_uring: add Linux io_uring AIO engine

2020-01-13 Thread Stefano Garzarella
The series LGTM, just some comments on patches 4 and 8. I succefully tried iotests on raw and qcow2 with io_uring, so Acked-by: Stefano Garzarella Thanks, Stefano On Wed, Dec 18, 2019 at 04:32:13PM +, Stefan Hajnoczi wrote: > v12: > * Reword BlockdevAioOptions QAPI schema commit descripti

[Bug 1859359] Re: xHCI and event ring handling

2020-01-13 Thread Gerd Hoffmann
qemu behavior matches linux guest driver expectations on erdp writes, I don't think we have a bug there. And, yes, qemu doesn't support multiple segments and correctly says so in the capabilities registers. ** Changed in: qemu Status: New => Invalid -- You received this bug notification

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Igor Mammedov
On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: > According to ACPI spec, _ADR should be used for device which is on a > bus that has a standard enumeration algorithm. It does not make sense > to have a _ADR object for devices which already have _HID and will be > enumerated by OSPM. > > Sign

[Bug 1859378] Re: xhci Control Transfer requiring a Status TRB before starting transfer

2020-01-13 Thread Gerd Hoffmann
Well, no. Status TB not being present is an error. The host adapter is not required to check for that error condition though. If the host adapter checks for that error condition it should queue an transfer error. So, yes, we could improve qemu a bit here, by throwing an error instead of silentl

Re: [PATCH 1/2] arm/virt/acpi: remove meaningless sub device "PR0" from PCI0

2020-01-13 Thread Igor Mammedov
On Thu, 19 Dec 2019 14:47:58 +0800 Heyi Guo wrote: > The sub device "PR0" under PCI0 in ACPI/DSDT does not make any sense, > so simply remote it. Could you make commit message more concrete so it would say why it doesn't make any sense. It seems to be there to describe root port, I'd rather have

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2020-01-13 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/17/19 7:42 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> How do you want to proceed with all the information provided in this >>> thread? I think a big table in the wiki collecting the answers is ideal. >>> What do you think? >> >>

Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

2020-01-13 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 06.12.2019 13:53, Vladimir Sementsov-Ogievskiy wrote: >> 06.12.2019 10:46, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: [...] So much attention to that function :) I'd also propose the following: [...] >>> >>> Looks like

Re: [PULL 00/28] Migration pull patches

2020-01-13 Thread Peter Maydell
On Fri, 10 Jan 2020 at 17:32, Juan Quintela wrote: > > The following changes since commit f38a71b01f839c7b65ea73ddd507903cb9489ed6: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-semihosting-090120-2' into staging > (2020-01-10 13:19:34 +) > > are available in th

[PULL 0/5] Usb 20200113 patches

2020-01-13 Thread Gerd Hoffmann
The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20200113-pu

[PULL 1/5] usb-host: remove 'remote wakeup' flag from configuration descriptor

2020-01-13 Thread Gerd Hoffmann
From: Yuri Benditovich If the redirected device has this capability, Windows guest may place the device into D2 and expect it to wake when the device becomes active, but this will never happen. For example, when internal Bluetooth adapter is redirected, keyboards and mice connected to it do not w

[PULL 4/5] xhci: Fix memory leak in xhci_kick_epctx when poweroff GuestOS

2020-01-13 Thread Gerd Hoffmann
From: Chen Qun start vm with libvirt, when GuestOS running, enter poweroff command using the xhci keyboard, then ASAN shows memory leak stack: Direct leak of 80 byte(s) in 5 object(s) allocated from: #0 0xfffd1e6431cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb) #1 0xfffd1e10716

[PULL 5/5] xhci: recheck slot status

2020-01-13 Thread Gerd Hoffmann
Factor out slot status check into a helper function. Add an additional check after completing transfers. This is needed in case a guest queues multiple transfers in a row and a device unplug happens while qemu processes them. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1786413 Signed-of

[PULL 3/5] usbredir: Prevent recursion in usbredir_write

2020-01-13 Thread Gerd Hoffmann
From: "Dr. David Alan Gilbert" I've got a case where usbredir_write manages to call back into itself via spice; this patch causes the recursion to fail (0 bytes) the write; this seems to avoid the deadlock I was previously seeing. I can't say I fully understand the interaction of usbredir and sp

[PULL 2/5] usb-redir: remove 'remote wakeup' flag from configuration descriptor

2020-01-13 Thread Gerd Hoffmann
From: Yuri Benditovich If the redirected device has this capability, Windows guest may place the device into D2 and expect it to wake when the device becomes active, but this will never happen. For example, when internal Bluetooth adapter is redirected, keyboards and mice connected to it do not w

RE: [PATCH 0/5] ARM virt: Add NVDIMM support

2020-01-13 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nongn > u.org] On Behalf Of Igor Mammedov > Sent: 09 January 2020 17:13 > To: Shameerali Kolothum Thodi > Cc: peter.mayd...@linaro.org; drjo...@redhat.com; > xiaoguangrong.e...@gmail

Re: [PULL 00/28] Migration pull patches

2020-01-13 Thread Daniel P . Berrangé
On Mon, Jan 13, 2020 at 01:05:22PM +, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 17:32, Juan Quintela wrote: > > > > The following changes since commit f38a71b01f839c7b65ea73ddd507903cb9489ed6: > > > > Merge remote-tracking branch > > 'remotes/stsquad/tags/pull-testing-and-semihosting-09

Re: Making QEMU easier for management tools and applications

2020-01-13 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Stefan Hajnoczi writes: >> > 4. Go and Rust bindings would also be useful. There is >> > https://github.com/intel/govmm but I think it makes sense to keep it >> > in qemu.git and provide an interface similar to

Re: [Bug 1859384] [NEW] arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Alex Bennée
Alex Longwall <1859...@bugs.launchpad.net> writes: > Public bug reported: > > For a 1-N interrupt (any SPI on the GICv2), as mandated by the TRM, only > one CPU can acknowledge the IRQ until it becomes inactive. > > The TRM also mandates that SGIs and PPIs follow the N-N model and that > SPIs fo

[PATCH v7] migration: Support QLIST migration

2020-01-13 Thread Eric Auger
Support QLIST migration using the same principle as QTAILQ: 94869d5c52 ("migration: migrate QTAILQ"). The VMSTATE_QLIST_V macro has the same proto as VMSTATE_QTAILQ_V. The change mainly resides in QLIST RAW macros: QLIST_RAW_INSERT_HEAD and QLIST_RAW_REVERSE. Tests also are provided. Signed-off-

Re: [PULL 00/28] Migration pull patches

2020-01-13 Thread Auger Eric
Hi Juan, Peter, On 1/13/20 2:05 PM, Peter Maydell wrote: > On Fri, 10 Jan 2020 at 17:32, Juan Quintela wrote: >> >> The following changes since commit f38a71b01f839c7b65ea73ddd507903cb9489ed6: >> >> Merge remote-tracking branch >> 'remotes/stsquad/tags/pull-testing-and-semihosting-090120-2' in

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Guoheyi
在 2020/1/13 20:08, Igor Mammedov 写道: On Thu, 19 Dec 2019 14:47:59 +0800 Heyi Guo wrote: According to ACPI spec, _ADR should be used for device which is on a bus that has a standard enumeration algorithm. It does not make sense to have a _ADR object for devices which already have _HID and wil

[Bug 1859359] Re: xHCI and event ring handling

2020-01-13 Thread Benjamin David Lunt
The xHCI specification states that after processing the Event TRB, software is to write the address of that TRB to the xHC_INTERRUPTER_DEQUEUE. QEMU currently checks this value written and compares it to its own current pointer, which is now incremented to the next available TRB, therefore not mat

[Bug 1859378] Re: xhci Control Transfer requiring a Status TRB before starting transfer

2020-01-13 Thread Benjamin David Lunt
I believe it is required to send an error event. It checked for the STATUS TRB and found that it was missing, therefore it must send an Error Event. This is (not so clearly) stated in the specification and I have quoted this in a previous comment. I took it as: If the controller checks for the e

Re: [RFC PATCH] qapi: Incorrect attempt to fix building with MC146818RTC=n

2020-01-13 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > When configured with --without-default-devices and setting > MC146818RTC=n, the build fails: > > LINKx86_64-softmmu/qemu-system-x86_64 > /usr/bin/ld: qapi/qapi-commands-misc-target.o: in function > `qmp_marshal_rtc_reset_reinjection': > qapi/qapi-comm

[RFC PATCH] pcie: Defer hot unplug until migration is complete

2020-01-13 Thread Yury Kotov
Devices hot-plug during migration is not allowed and disabled in corresponding QMP-commands (device_add, device_del). But guest still can unplug device by powering it off (Example: echo 0 > /sys/bus/pci/slots/XXX/power). Fix it by deferring unplugging until the migration is complete. Signed-off-b

Re: [PATCH] i386:acpi: Remove _HID from the SMBus ACPI entry

2020-01-13 Thread Michael S. Tsirkin
On Tue, Jan 07, 2020 at 02:11:06PM -0600, Corey Minyard wrote: > On Tue, Jan 07, 2020 at 05:58:21PM +0100, Igor Mammedov wrote: > > On Mon, 6 Jan 2020 09:27:05 -0600 > > miny...@acm.org wrote: > > > > > From: Corey Minyard > > > > > > Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is no

Re: [RFC PATCH 0/1] Removing RAMBlocks during migration

2020-01-13 Thread Yury Kotov
Hi! 07.01.2020, 23:08, "Michael S. Tsirkin" : > On Fri, Jan 03, 2020 at 11:44:27AM +, Dr. David Alan Gilbert wrote: >>  > 1) Guest: writes to slot's pci config >>  > 2) QEMU: pcie_cap_slot_write_config -> pcie_unplug_device >>  > >>  > So, it's only guest driven action and qdev_unplug doesn't

Re: [PULL v2 0/8] qtests and docs

2020-01-13 Thread Peter Maydell
On Sun, 12 Jan 2020 at 11:28, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' > into staging (2020-01-10 16:15:04 +) > > are available in the Git

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Peter Maydell
It would probably help if you were a bit more specific about describing the expected versus actual behaviour you see. I think here that we're talking about the GICD_ICFGR registers and more specifically the bits [2F] that may indicate N-N vs 1-N model. The GIC architecture specification says that

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Alex Longwall
> You might find there is enough in kvm-unit-tests GIC tests already to build a test case for what you are seeing. Right, I will do so as soon as possible. For bug 1) however, a simpler test can be made _start: // x0=gicd mov x0, #0x0800 // Read icfgr[for irqid=32...] ldr

Re: Priority of -accel

2020-01-13 Thread Markus Armbruster
Thomas Huth writes: > On 07/01/2020 15.27, Daniel P. Berrangé wrote: >> On Tue, Jan 07, 2020 at 03:20:40PM +0100, Philippe Mathieu-Daudé wrote: >>> On 1/7/20 3:14 PM, Thomas Huth wrote: On 07/01/2020 13.54, Daniel P. Berrangé wrote: > On Tue, Jan 07, 2020 at 01:23:18PM +0100, Paolo Bonzi

[PATCH] i386:acpi: Remove _HID from the SMBus ACPI entry

2020-01-13 Thread minyard
From: Corey Minyard Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required on enumerated buses (like PCI in this case), _ADR is required (and is already there). And the _HID value is wrong. Linux appears to ignore the _HID entry, but Windows 10 detects it as 'Unknown Device' and

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Peter Maydell
Oops, yes, missed that use of GIC_DIST_TEST_MODEL because it was in the header file... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859384 Title: arm gic: interrupt model never 1 on non-mpcore an

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Alex Longwall
> about describing the expected versus actual behaviour you see. Expected behavior: * core 0 (or 1) reads irqId (irqId becomes active/active-pending) * core 1 (or resp. 0) reads 1023 * core 0 handles and deactivates the interrupt What I am getting instead: * core 0 reads irqId * core 1 also rea

[PATCH] console: make QMP screendump use coroutine

2020-01-13 Thread Marc-André Lureau
Thanks to the QMP coroutine support, the screendump handler can trigger a graphic_hw_update(), yield and let the main loop run until update is done. Then the handler is resumed, and the ppm_save() will write the screen image to disk in the coroutine context (thus non-blocking). For now, HMP doesn'

Re: [PULL 00/28] Migration pull patches

2020-01-13 Thread Juan Quintela
Daniel P. Berrangé wrote: >> I also saw this on aarch32 host (more precisely, on the >> aarch32-environment-in-aarch64-chroot setup I use for aarch32 build >> and test): >> >> malloc_consolidate(): invalid chunk size >> Broken pipe >> qemu-system-i386: check_section_footer: Read section footer fa

Re: [PULL 0/5] Usb 20200113 patches

2020-01-13 Thread Peter Maydell
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20200113-pull-request > > for you to fetch changes up to 236846a019c4f7aa3111026fc9a1fe09684c8978: > > xhci: recheck slot status (2020-01-13 14:05:55 +0100) > > ---

Issue: whpx mode can not install windows 7 os.

2020-01-13 Thread Yonggang Luo
any idea about how to resolve this problem. ENV: MSYS2 newest. ``` mkdir build-qemu-x64 cd build-qemu-x64 ../qemu.org/configure --python=python3 --prefix=/usr --disable-gtk --disable-sdl --disable-virtfs --disable-werror \ --enable-capstone=system \ --target-list=i386-softmmu,x86_64-softmmu,ppc

Re: [PATCH v1 12/59] virtfs-proxy-helper.c: remove 'err_out' label in setugid()

2020-01-13 Thread Markus Armbruster
Greg Kurz writes: > On Mon, 6 Jan 2020 15:23:38 -0300 > Daniel Henrique Barboza wrote: > >> 'err_out' can be removed and be replaced by 'return -errno' >> in its only instance in the function. >> >> CC: Greg Kurz >> Signed-off-by: Daniel Henrique Barboza >> --- > > I don't really mind, but I

Re: [PATCH v1 40/59] hsb/hcd-ehci.c: remove unneeded labels

2020-01-13 Thread Markus Armbruster
Typo in subject: s/hsb/usb/

Re: [PATCH 2/2] arm/virt/acpi: remove _ADR from devices identified by _HID

2020-01-13 Thread Andrew Jones
On Mon, Jan 13, 2020 at 09:57:55PM +0800, Guoheyi wrote: > > 在 2020/1/13 20:08, Igor Mammedov 写道: > > On Thu, 19 Dec 2019 14:47:59 +0800 > > Heyi Guo wrote: > > > > > According to ACPI spec, _ADR should be used for device which is on a > > > bus that has a standard enumeration algorithm. It does

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Alex Longwall
For 2): since I've never written to ispendr, the level interrupt is still considered as pending on the other core because GIC_DIST_TEST_LEVEL(...) evaluates to true. I believe ack should clear the level on other cores for 1-n interrupts > For part (2), I think you're saying that we're missing the

Re: [PATCH v1 00/59] trivial unneeded labels cleanup

2020-01-13 Thread Markus Armbruster
Corey Minyard writes: > On Mon, Jan 06, 2020 at 03:23:26PM -0300, Daniel Henrique Barboza wrote: >> Hello, >> >> This is the type of cleanup I've contributed to Libvirt >> during the last year. Figured QEMU also deserves the same >> care. >> >> The idea here is remove unneeded labels. By 'unnee

Re: [PATCH RFC 01/12] migration: Add multiRDMA capability support

2020-01-13 Thread Markus Armbruster
Zhimin Feng writes: > From: fengzhimin > > Signed-off-by: fengzhimin > --- [...] > diff --git a/qapi/migration.json b/qapi/migration.json > index b7348d0c8b..c995ffdc4c 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -421,6 +421,8 @@ > # @validate-uuid: Send the UUID of the

Re: [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter

2020-01-13 Thread Markus Armbruster
Zhimin Feng writes: > From: fengzhimin > > Indicates the number of RDMA threads that we would create. > By default we create 2 threads for RDMA migration. > > Signed-off-by: fengzhimin [...] > diff --git a/qapi/migration.json b/qapi/migration.json > index c995ffdc4c..ab79bf0600 100644 > --- a/q

[Bug 1859384] Re: arm gic: interrupt model never 1 on non-mpcore and race condition in gic_acknowledge_irq

2020-01-13 Thread Alex Longwall
Err, I meant 3.2 subitem 5 "Note" "In a multiprocessor implementation, the GIC handles(...)" too, sorry -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1859384 Title: arm gic: interrupt model never 1

[Bug 1622582] Re: Can't install Windows 7 with q35 (SATA)

2020-01-13 Thread Yonggang Luo
I also face this problem, any idea to resolve. I am using qemeu 4.2 + whpx support but failed to install ./qemu-system-x86_64 -m 4096 \ -vga vmware \ -machine q35 \ -accel whpx \ -usb -device usb-kbd \ -device usb-mouse -device usb-audio -boot c \ -netdev tap,id=mynet0,ifname=tap0,script=no,downsc

[PATCH] arm/gicv3: update virtual irq state after IAR register read

2020-01-13 Thread Jeff Kubascik
The IAR0/IAR1 register is used to acknowledge an interrupt - a read of the register activates the highest priority pending interrupt and provides its interrupt ID. Activating an interrupt can change the CPU's virtual interrupt state - this change makes sure the virtual irq state is updated. Signed

PCIe device paththrough via vfio issue

2020-01-13 Thread yurij
Hello everybody! I have a specific PCIe device (sorry, but I can't tell about what is it and what it does) but PCI configuration space consists of 4 BARs (lspci output brief): lspci -s 84:00.00 -vvv . . . Region 0: Memory at fa00 (64-bit, non-prefetchable) [size=16M] Region 2: Me

[PATCH v2 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Andrey Shinkevich
Let QEMU-IMG CHECK command show QCOW2 structure to inform a user about metadata allocations on disk. Introduce '-M'('--dump-meta') key option. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/qcow2-bitmap.c | 54 +--- block/qcow

[PATCH v2 1/2] qcow2: introduce Qcow2Metadata structure

2020-01-13 Thread Andrey Shinkevich
The preliminary patch to provide an extendable structure for dumping QCOW2 metadata allocations in image. The command line optional key is introduced in the patch that follows. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- qapi/block-core.json | 209 +++

Re: Difference between 'current_machine' vs MACHINE(qdev_get_machine())

2020-01-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/01/20 12:23, Philippe Mathieu-Daudé wrote: >> >> >>     current_machine = >> MACHINE(object_new_with_class(OBJECT_CLASS(machine_class))); >>     object_property_add_child(object_get_root(), "machine", >>   OBJECT(current_machine), &error

[PATCH v2 0/2] Dump QCOW2 metadata

2020-01-13 Thread Andrey Shinkevich
The information about QCOW2 metadata allocations in an image ELF-file is helpful for finding issues with the image data integrity. v2: Descriptions of the new key option were added and the names of identifiers were amended (suggested by Eric). Discussed in the email thread with ID <1577447

Re: [PATCH v6 00/25] monitor: add asynchronous command type

2020-01-13 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jan 7, 2020 at 9:17 AM Kevin Wolf wrote: >> >> Am 06.01.2020 um 19:21 hat Marc-André Lureau geschrieben: >> > > What my patch does is moving everything into a coroutine. This is wrong >> > > because not everything can be run in a coroutine, so it needs

[PATCH v2] target/arm: adjust program counter for wfi exception in AArch32

2020-01-13 Thread Jeff Kubascik
The wfi instruction can be configured to be trapped by a higher exception level, such as the EL2 hypervisor. When the instruction is trapped, the program counter should contain the address of the wfi instruction that caused the exception. The program counter is adjusted for this in the wfi op helpe

Re: [PATCH v2 1/1] s390x/event-facility.c: remove unneeded labels

2020-01-13 Thread Thomas Huth
On 08/01/2020 15.46, Daniel Henrique Barboza wrote: > 'out' label from write_event_mask() and and write_event_data() > can be replaced by 'return'. > > The 'out' label from read_event_data() can also be replaced. > However, as suggested by Cornelia Huck, instead of simply > replacing the 'out' lab

Re: [PATCH v1 41/59] intc/s390_flic_kvm.c: remove unneeded label in kvm_flic_load()

2020-01-13 Thread Thomas Huth
On 06/01/2020 19.24, Daniel Henrique Barboza wrote: > 'out' label can be replaced by 'return' with the apropriate s/apropriate/appropriate/ > value that is set by 'r' right before the jump. > > Christian Borntraeger Missing "Cc:" ? With this line and the typo removed/fixed: Reviewed-by: Thoma

Re: [PATCH] i386:acpi: Remove _HID from the SMBus ACPI entry

2020-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200113144228.16660-1-miny...@acm.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

[PATCH v2] qcow2: Assert that host cluster offsets fit in L2 table entries

2020-01-13 Thread Alberto Garcia
The standard cluster descriptor in L2 table entries has a field to store the host cluster offset. When we need to get that offset from an entry we use L2E_OFFSET_MASK to ensure that we only use the bits that belong to that field. But while that mask is used every time we read from an L2 entry, it

Re: Priority of -accel

2020-01-13 Thread Christophe de Dinechin
> On 13 Jan 2020, at 15:39, Markus Armbruster wrote: > > Thomas Huth writes: 'any' is a russian roulette, you don't want it to return 'qtest' ;) >>> >>> We could make it return "qtest" only on April 1st ;-P >> >> ... or we finally dare to let QEMU chose the "best" accelerator by

Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Eric Blake
On 1/13/20 4:30 AM, Andrey Shinkevich wrote: -    c = getopt_long(argc, argv, ":hf:r:T:qU", +    c = getopt_long(argc, argv, ":hf:r:T:qU:M", We are already inconsistent, but I tend to add options in alphabetical order, both here... If I merely move 'M' forward like ':hf:M:r:T:qU', w

Re: [PATCH v2 2/3] gitlab-ci.yml: Add jobs to build the EDK2 firmware binaries

2020-01-13 Thread Thomas Huth
On 07/01/2020 16.31, Philippe Mathieu-Daudé wrote: > Add two GitLab job to build the EDK2 firmware binaries. > > The first job build a Docker image with the packages requisite > to build EDK2, and store this image in the GitLab registry. > The second job pull the image from the registry and build

Re: Priority of -accel

2020-01-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/01/20 14:55, Christophe de Dinechin wrote: >> So what about ranking the accelerators, so that all combinaisons >> -accel=kvm:tcg, -accel=tcg:kvm, -accel kvm -accel tcg, etc would > > (I assume you mean "-machine accel=kvm:tcg" and "-machine accel=tcg:kvm" > for the f

Re: Priority of -accel

2020-01-13 Thread Paolo Bonzini
On 13/01/20 17:14, Christophe de Dinechin wrote: > % ./x86_64-softmmu/qemu-system-x86_64 > qemu-system-x86_64: invalid accelerator kvm > qemu-system-x86_64: falling back to tcg That is a bug, Richard Henderson has posted patches to fix it. Paolo

Re: Priority of -accel

2020-01-13 Thread Paolo Bonzini
On 13/01/20 17:17, Markus Armbruster wrote: > Perfect opportunity to change the default to something more useful. I am not sure acutally if it's that more useful, now that we have sanctioned qemu-kvm as the fast alternative. Particularly it would be confusing for qemu-system-x86_64 to use hardwar

Re: qemu-4.0.1: vhost_region_add_section:Section rounded to 0 prior to previous a0000

2020-01-13 Thread Peter Lieven
Am 09.01.20 um 19:44 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 08.01.20 um 16:04 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Hi, I have a Qemu 4.0.1 machine with vhost-net network adapter, thats polluting the log with the above message.

Re: [PATCH RFC 01/12] migration: Add multiRDMA capability support

2020-01-13 Thread Eric Blake
On 1/8/20 10:59 PM, Zhimin Feng wrote: From: fengzhimin Signed-off-by: fengzhimin --- +++ b/qapi/migration.json @@ -421,6 +421,8 @@ # @validate-uuid: Send the UUID of the source to allow the destination # to ensure it is the same. (since 4.2) # +# @multirdma: Use more

Re: PCIe device paththrough via vfio issue

2020-01-13 Thread Alex Williamson
On Mon, 13 Jan 2020 18:49:21 +0300 yurij wrote: > Hello everybody! > > I have a specific PCIe device (sorry, but I can't tell about what is it > and what it does) but PCI configuration space consists of 4 BARs (lspci > output brief): > > lspci -s 84:00.00 -vvv > > . . . > Region 0: Memory at

Re: Making QEMU easier for management tools and applications

2020-01-13 Thread Stefan Hajnoczi
On Tue, Jan 07, 2020 at 06:11:13PM +0100, Christophe de Dinechin wrote: > > On 20 Dec 2019, at 17:13, Stefan Hajnoczi wrote: > So I think that Daniel is right. We may need at some point to start > a NEMU-style offshoot that does not attempt to be compatible, > but explores describing an increasing

Re: [PATCH] console: make QMP screendump use coroutine

2020-01-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200113144848.2168018-1-marcandre.lur...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

  1   2   3   >