Re: [PATCH] x86: Check for machine state object class before typecasting it

2020-01-07 Thread Paolo Bonzini
On 30/12/19 14:17, Michal Prívozník wrote: > On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: >> On 12/30/19 10:35 AM, Michal Prívozník wrote: >>> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: > In v4.2.0-246-ged9e923c3c the SMM property

Re: [PATCH 032/104] virtiofsd: passthrough_ll: create new files in caller's context

2020-01-07 Thread Daniel P . Berrangé
On Mon, Jan 06, 2020 at 07:08:43PM +, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Thu, Dec 12, 2019 at 04:37:52PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: Vivek Goyal

Re: [PATCH v3 4/7] dt-bindings: gpio: Add gpio-repeater bindings

2020-01-07 Thread Harish Jenny K N
On 06/01/20 1:42 PM, Geert Uytterhoeven wrote: > Hi Rob, > > On Fri, Dec 6, 2019 at 4:04 PM Rob Herring wrote: >> On Fri, Dec 6, 2019 at 3:17 AM Geert Uytterhoeven >> wrote: >>> On Thu, Dec 5, 2019 at 10:06 PM Rob Herring wrote: On Wed, Nov 27, 2019 at 09:42:50AM +0100, Geert Uytterhoeve

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

2020-01-07 Thread Stefano Garzarella
On Mon, Dec 30, 2019 at 09:28:56AM +0100, Philippe Mathieu-Daudé wrote: > To avoid scrolling each instruction when reviewing tcg > helpers written for the decodetree script, display the > .decode files (similar to header declarations) before > the C source (implementation of previous declarations).

Re: [PULL v2 0/9] Add dbus-vmstate

2020-01-07 Thread Peter Maydell
On Mon, 6 Jan 2020 at 14:46, Marc-André Lureau wrote: > > The following changes since commit b0b74e1f17508cb8cef8afd698558db1bd8999cc: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2020-01-06 > 11:39:55 +) > > are available in the Git rep

Re: [RFC PATCH 14/14] hw/intc/Kconfig: Let APIC select IOAPIC

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > apic_eoi() calls ioapic_eoi_broadcast(), so APIC has to > select the IOAPIC Kconfig. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: "Michael S. Tsirkin" > > RFC because I'm not sure the design is correct (meanwhile the fix is, > however

Re: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-07 Thread Michael S. Tsirkin
On Tue, Jan 07, 2020 at 05:18:49PM +0800, Zeng Tao wrote: > When booting the guest linux with the following numa configuration: > -numa node,node_id=1,cpus=0-3 > -numa node,node_id=0,cpus=4-7 > We can get the following numa topology in the guest system: > Architecture: aarch64 > Byte Order

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > Only the PC-based machines use the fw_cfg device. In particular, > the MicroVM machine does not use it. Only compile/link it when > machines require it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Sergio Lopez > --- > hw/i386/Makefile

RE: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-07 Thread Zengtao (B)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, January 07, 2020 5:33 PM > To: Zengtao (B) > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; Shannon Zhao; > Peter Maydell; Igor Mammedov; qemu-...@nongnu.org > Subject: Re: [PATCH] hw/arm/acpi: Pa

Re: Making QEMU easier for management tools and applications

2020-01-07 Thread Kevin Wolf
Am 23.12.2019 um 16:04 hat Michal Prívozník geschrieben: > On 12/21/19 10:02 AM, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > > > >> 4. Go and Rust bindings would also be useful. There is > >> https://github.com/intel/govmm but I think it makes sense to keep it > >> in qemu.git a

Re: [PATCH v2] accel/kvm: Make "kernel_irqchip" default on

2020-01-07 Thread Paolo Bonzini
On 28/12/19 11:43, Xiaoyao Li wrote: > Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an > accelerator property") moves kernel_irqchip property from "-machine" to > "-accel kvm", but it forgets to set the default value of > kernel_irqchip_allowed and kernel_irqchip_split. > > Also

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-07 Thread Andrea Bolognani
On Tue, 2020-01-07 at 12:55 +1100, Alexey Kardashevskiy wrote: > On 07/01/2020 01:15, Daniel Henrique Barboza wrote: > > Question: does Petitboot already replaces SLOF in every possible > > scenario for all > > the spapr machine features? > > Petitboot kernel+initramdisk almost replaces SLOF + GRU

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 11:01 AM, Paolo Bonzini wrote: On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: Only the PC-based machines use the fw_cfg device. In particular, the MicroVM machine does not use it. Only compile/link it when machines require it. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Sergio Lo

[PATCH v2 1/3] migration-test: Add migration multifd test

2020-01-07 Thread Juan Quintela
We set multifd-channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Tested-by: Wei Yang Signed-off-by: Juan Quintela --- tests/migration-test.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/tests

Re: [PATCH 1/3] roms/edk2-funcs: Force softfloat ARM toolchain prefix on Debian

2020-01-07 Thread Laszlo Ersek
On 01/06/20 19:45, Philippe Mathieu-Daudé wrote: > The Debian (based) distributions currently provides 2 ARM > toolchains, documented as [1]: > > * The ARM EABI (armel) port targets a range of older 32-bit ARM > devices, particularly those used in NAS hardware and a variety > of *plug computer

Re: [PATCH 12/14] hw/nvram/Kconfig: Add an entry for the NMC93xx EEPROM

2020-01-07 Thread Paolo Bonzini
On 01/01/20 11:31, Philippe Mathieu-Daudé wrote: > On 12/31/19 7:32 PM, Philippe Mathieu-Daudé wrote: >> The NMC93xx EEPROM is only used by few NIC cards and the >> Am53C974 SCSI controller. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: Stefan Weil >> --- >>   hw/net/Kconfig |

Re: [PATCH v3] docs: build an index page for the HTML docs

2020-01-07 Thread Thomas Huth
On 19/12/2019 14.56, Stefan Hajnoczi wrote: > There is no index.html start page for the QEMU HTML documentation. An > index page is needed so that documentation can be browsed easily on the > web. > > This patch adds an index.html.in template file where the QEMU version > number is expanded. It

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > Only the PC-based machines use the fw_cfg device. In particular, > the MicroVM machine does not use it. Only compile/link it when > machines require it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Sergio Lopez > --- > hw/i386/Makefile

Re: [PATCH v1] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35

2020-01-07 Thread Paolo Bonzini
On 07/01/20 10:24, Cornelia Huck wrote: > On Mon, 23 Dec 2019 10:28:56 +0300 > Denis Plotnikov wrote: > >> 5.0 machine type uses 4.2 compats. This seems to be incorrect, since >> the latests machine type by now is 5.0 and it should use its own >> compat or shouldn't use any relying on the default

Re: [PATCH 3/3] gitlab-ci-edk2.yml: Use ccache

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 11:19 AM, Laszlo Ersek wrote: On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: By using ccache we reduce the job duration from 40 minutes 26 seconds to 32 minutes 6 seconds. Running after script... $ ccache --show-stats cache hit (direct) 6604 files in cac

[Bug 1856706] Re: target/mips/op_helper.c:971:duplicated branches ?

2020-01-07 Thread Philippe Mathieu-Daudé
** Tags added: mips -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856706 Title: target/mips/op_helper.c:971:duplicated branches ? Status in QEMU: New Bug description: qemu-4.2.0/target/mips/

Re: [PATCH 056/104] virtiofsd: add security guide document

2020-01-07 Thread Daniel P . Berrangé
On Mon, Jan 06, 2020 at 05:53:55PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:38:16PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: Stefan Hajnoczi > > > > > > Many people want to know: what's up with virti

[Bug 1858046] Re: qemu-aarch64 hangs on cptofs during a build of NixOS SD card image

2020-01-07 Thread Philippe Mathieu-Daudé
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858046 Title: qemu-aarch64 hangs on cptofs during a build of NixOS SD card image Status in QEMU: New Bug description:

Re: [Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-07 Thread Thomas Huth
On 07/01/2020 00.38, puchuu wrote: > ** Patch added: "generated_mips_syscall_table.template.patch" > > https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5318010/+files/generated_mips_syscall_table.template.patch > Please do not attach patches to the bug tracker, send them to the qemu-d

[Bug 1856549] Re: qemu-4.2.0/hw/misc/mac_via.c: 2 * bad test ?

2020-01-07 Thread Philippe Mathieu-Daudé
Patch posted: https://www.mail-archive.com/qemu- de...@nongnu.org/msg666836.html ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856549 Title:

Re: [PULL 0/3] target/xtensa queue

2020-01-07 Thread Peter Maydell
On Mon, 6 Jan 2020 at 20:05, Max Filippov wrote: > > Hi Peter, > > please pull the following target/xtensa batch. > > The following changes since commit f4d8cf148e43d942ef1202071e0cd66ce40322e0: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-01-06' > into staging (2020-

Re: [PATCH 2/3] gitlab-ci.yml: Add a job to build EDK2 firmware binaries

2020-01-07 Thread Laszlo Ersek
On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: > Add a GitLab job to build the EDK2 firmware binaries. > This job is only built when the roms/edk2/ submodule is updated, > when a git-ref starts with 'edk2' or when the last commit contains > 'EDK2'. keyword "or"; okay. > > GitLab CI generates a

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-07 Thread Yuri Benditovich
On Mon, Jan 6, 2020 at 12:37 PM Yuri Benditovich < yuri.benditov...@daynix.com> wrote: > > On Mon, Jan 6, 2020 at 11:58 AM Michael S. Tsirkin wrote: > >> I guess it somehow has to do with the following: >> >> if (proxy->disable_legacy == ON_OFF_AUTO_AUTO) { >> proxy->disable_legacy =

Re: [PATCH v2 1/3] migration-test: Add migration multifd test

2020-01-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We set multifd-channels. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Thomas Huth > Tested-by: Wei Yang > Signed-off-by: Juan Quintela > --- > tests/migration-test.c | 56 +

Re: [PATCH 061/104] virtiofsd: Handle reinit

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:21PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Allow init->destroy->init for mount->umount->mount > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_lowlevel.c | 2 ++ > 1 file changed, 2 insertions(+) Re

[Bug 1858623] [NEW] VNC outputs garbage in zlib mode

2020-01-07 Thread Artyom
Public bug reported: TL;DR: When QEMU is launched with VNC as the output and viewed with a client that defaults to zlib VNC encoding, the resulting output tends to accumulate artifacts. Reproduction: Launch QEMU (tried with versions 4.2.0 and 4.1.0 on Linux 64bit) with -vnc 0.0.0.0:0 Connect to

[PATCH v2 3/3] migration-test: Make sure that multifd and cancel works

2020-01-07 Thread Juan Quintela
Test that this sequerce works: - launch source - launch target - start migration - cancel migration - relaunch target - do migration again Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- - Wait for 1st trhead to move to cancelled before launc

[PATCH v2 0/1] block/rbd: Add support for ceph namespaces

2020-01-07 Thread Florian Florensa
Happy new year everyone, please find attached the v2 of the patch, updated with the input from Stefano, Jason and Eric. What has changed from v1 : - renamed the variables from nspace to namespace - made the argument in qapi optional - add the `(Since 5.0)` tag in qapi documentation Florian Fl

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Michael S. Tsirkin
On Tue, Jan 07, 2020 at 11:01:48AM +0100, Paolo Bonzini wrote: > On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > > Only the PC-based machines use the fw_cfg device. In particular, > > the MicroVM machine does not use it. Only compile/link it when > > machines require it. > > > > Signed-off-by:

[Bug 1851972] Re: pc-q35-4.1 and AMD Navi 5700/XT incompatible

2020-01-07 Thread Philippe Mathieu-Daudé
Paolo Bonzini commented on IRC: AMD avic requires kernel_irqchip=split. Can you try using it? (released QEMU uses -machine ...,kernel_irqchip=split, git QEMU expects -accel kernel_irqchip=split). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

Re: [PATCH 3/3] gitlab-ci-edk2.yml: Use ccache

2020-01-07 Thread Laszlo Ersek
On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: > By using ccache we reduce the job duration from > 40 minutes 26 seconds to 32 minutes 6 seconds. > > Running after script... > $ ccache --show-stats > cache hit (direct) 6604 > files in cache 12090 >

Re: [PATCH v2 2/4] tcg: Search includes in the parent source directory

2020-01-07 Thread Paolo Bonzini
On 01/01/20 12:23, Philippe Mathieu-Daudé wrote: > All the *.inc.c files included by tcg/$TARGET/tcg-target.inc.c > are in tcg/, their parent directory. To simplify the preprocessor > search path, include the relative parent path: '..'. > > Patch created mechanically by running: > > $ for x in

Re: [PATCH v2] hppa: allow max ram size upto 4Gb

2020-01-07 Thread Igor Mammedov
On Mon, 6 Jan 2020 18:03:49 +0100 Helge Deller wrote: > On 06.01.20 17:24, Igor Mammedov wrote: > > On Mon, 6 Jan 2020 12:28:51 +0100 > > Helge Deller wrote: > > > >> On 06.01.20 11:48, Igor Mammedov wrote: > >>> On Sat, 4 Jan 2020 16:00:19 +0100 > >>> Philippe Mathieu-Daudé wrote: > >>>

[PATCH v2 2/3] migration: Make sure that we don't call write() in case of error

2020-01-07 Thread Juan Quintela
If we are exiting due to an error/finish/ Just don't try to even touch the channel with one IO operation. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/ram.c | 25 + 1 file changed, 25 insertions(+) diff

Re: [PATCH 067/104] virtiofsd: passthrough_ll: disable readdirplus on cache=never

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:27PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > ...because the attributes sent in the READDIRPLUS reply would be discarded > anyway. > > Signed-off-by: Miklos Szeredi > --- > tools/virtiofsd/passthrough_ll.c | 4 > 1 file changed, 4

Re: [PATCH v2 2/3] migration: Make sure that we don't call write() in case of error

2020-01-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > If we are exiting due to an error/finish/ Just don't try to even > touch the channel with one IO operation. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/ram.c | 25

Re: Making QEMU easier for management tools and applications

2020-01-07 Thread Michal Privoznik
On 1/7/20 10:36 AM, Kevin Wolf wrote: The easy way out would be tying libvirt to a specific QEMU version. And I'm only half joking. If libvirt didn't exist yet and we needed a management library for QEMU, what we would build now would probably not look much like libvirt looks today. We wouldn't

Re: [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus

2020-01-07 Thread Paolo Bonzini
On 24/12/19 12:16, Philippe Mathieu-Daudé wrote: > The MC146818 sits on an ISA bus. Since it can not be used > without it, select ISA in the Kconfig. > > Fixes: 82f5181777e > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw

Re: [PATCH v18 1/7] Wrapper function to wait on condition for the main loop mutex

2020-01-07 Thread Ganesh
On 1/5/20 8:47 PM, Greg Kurz wrote: On Thu, 2 Jan 2020 13:21:05 +0530 Ganesh Goudar wrote: From: Aravinda Prasad Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the c

Re: [RFC PATCH] qapi: Incorrect attempt to fix building with MC146818RTC=n

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:49, Philippe Mathieu-Daudé wrote: > When configured with --without-default-devices and setting > MC146818RTC=n, the build fails: > > LINKx86_64-softmmu/qemu-system-x86_64 > /usr/bin/ld: qapi/qapi-commands-misc-target.o: in function > `qmp_marshal_rtc_reset_reinjection': >

Re: [PATCH 2/2] target/mips: Correct data on deprecated r4k machine

2020-01-07 Thread Thomas Huth
On 19/12/2019 15.15, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change the release since r4k machine is deprecated from 4.2 to 5.0. > > Signed-off-by: Aleksandar Markovic > --- > qemu-deprecated.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu

Re: [PATCH v1 30/59] util/module.c: remove unneeded label in module_load_file()

2020-01-07 Thread Thomas Huth
On 06/01/2020 19.23, Daniel Henrique Barboza wrote: > 'out' can be replaced by the apropriate return values set > in 'ret' for each case. > > CC: Paolo Bonzini > Signed-off-by: Daniel Henrique Barboza > --- > util/module.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > >

Re: [PATCH 078/104] virtiofsd: cleanup allocated resource in se

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:38PM +, Dr. David Alan Gilbert (git) wrote: > From: Liu Bo > > This cleans up unfreed resources in se on quiting, including > se->virtio_dev, se->vu_socket_path, se->vu_socketfd. > > Signed-off-by: Liu Bo > --- > tools/virtiofsd/fuse_lowlevel.c | 7 +++ >

Re: [PATCH v1 57/59] linux-user/syscall.c: fix trailing whitespaces and style

2020-01-07 Thread Peter Maydell
On Mon, 6 Jan 2020 at 19:19, Daniel Henrique Barboza wrote: > > There are trailing whitespaces in this file that, if removed > by a text editor that refuses to let the traiing whitespace > alone, which happens to be the editor I am using, will cause > checkpatch.pl to warn about styling problems i

Re: [PATCH] freebsd: use python37

2020-01-07 Thread Alex Bennée
Gerd Hoffmann writes: > FreeBSD seems to use python37 by default now, which breaks the build > script. Add python to the package list, to explicitly pick the version, > and also adapt the configure command line. > > Signed-off-by: Gerd Hoffmann Queued to testing/next, thanks. > --- > tests

Re: [PATCH v2 3/3] migration-test: Make sure that multifd and cancel works

2020-01-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Test that this sequerce works: > > - launch source > - launch target > - start migration > - cancel migration > - relaunch target > - do migration again > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Qu

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

2020-01-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > To avoid scrolling each instruction when reviewing tcg > helpers written for the decodetree script, display the > .decode files (similar to header declarations) before > the C source (implementation of previous declarations). > > Signed-off-by: Philippe Mathieu-

Re: [PATCH 065/104] contrib/libvhost-user: Protect slave fd with mutex

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:25PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In future patches we'll be performing commands on the slave-fd driven > by commands on queues, since those queues will be driven by individual > threads we need to make sure they don

Re: [PATCH 077/104] virtiofsd: fix error handling in main()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:37PM +, Dr. David Alan Gilbert (git) wrote: > From: Liu Bo > > Neither fuse_parse_cmdline() nor fuse_opt_parse() goes to the right place > to do cleanup. > > Signed-off-by: Liu Bo > --- > tools/virtiofsd/passthrough_ll.c | 5 +++-- > 1 file changed, 3 insertio

Re: [PATCH 1/2] travis.yml: avocado: Print logs of non-pass tests only

2020-01-07 Thread Alex Bennée
Wainer dos Santos Moschetta writes: > The acceptance tests build on Travis is configured to print > the entire Avocado's job log in case any test fail. Usually one is > interested on failed tests only though. So this change the Travis > configuration in order to show the log of tests which stat

[PATCH v2 0/3] Fix multifd + cancel + multifd

2020-01-07 Thread Juan Quintela
Hi In the v2 series: - get the multifd test patch - drop the ->shutdown fix it break postcopy recovery test. Still trying to determine if the problem is inside the recover test or the recover code. - upgrade the migrate_cancel test Please review. [v1] This series: - create a test that does:

Re: [PATCH 086/104] virtiofsd: use fuse_lowlevel_is_virtio() in fuse_session_destroy()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:46PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > vu_socket_path is NULL when --fd=FDNUM was used. Use > fuse_lowlevel_is_virtio() instead. > > Signed-off-by: Stefan Hajnoczi > pull request 10 Extraneous line > --- > tools/virtiofsd/

Re: [PATCH v2 3/7] configure: Do not force pie=no for non-x86

2020-01-07 Thread Philippe Mathieu-Daudé
On 12/18/19 11:34 PM, Richard Henderson wrote: PIE is supported on many other hosts besides x86. The default for non-x86 is now the same as x86: pie is used if supported, and may be forced via --enable/--disable-pie. The original commit (40d6444e91c) said: "Non-x86 are not changed, as they

Re: [PATCH 066/104] virtiofsd: passthrough_ll: add renameat2 support

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:26PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > No glibc support yet, so use syscall(). It exists in glibc in my Fedora 31 install. Presumably this is related to an older version > Signed-off-by: Miklos Szeredi > --- > tools/virtiofsd/

Re: [PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list

2020-01-07 Thread Paolo Bonzini
On 01/01/20 12:22, Philippe Mathieu-Daudé wrote: > Noticed we could clean this while reviewing Richard patch last night: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html > > Since v1: > - moved headers to include/tcg/ (Paolo) > - include in .inc.c relative to parent (Stefan) >

Re: [PATCH v2 0/3] Fix multifd + cancel + multifd

2020-01-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200107104914.1814-1-quint...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is availa

Re: [PATCH 069/104] virtiofsd: rename unref_inode() to unref_inode_lolocked()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:29PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) Reviewed-by:

Re: [PATCH 060/104] virtiofsd: Add timestamp to the log with FUSE_LOG_DEBUG level

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:20PM +, Dr. David Alan Gilbert (git) wrote: > From: Masayoshi Mizuma > > virtiofsd has some threads, so we see a lot of logs with debug option. > It would be useful for debugging if we can see the timestamp. > > Add nano second timestamp, which got by get_clock(

Re: [PATCH 083/104] virtiofsd: fix incorrect error handling in lo_do_lookup

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:43PM +, Dr. David Alan Gilbert (git) wrote: > From: Eric Ren > > Signed-off-by: Eric Ren > --- > tools/virtiofsd/passthrough_ll.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH RFC] i386/kvm: fix enlightened VMCS with fine-grained VMX feature enablement

2020-01-07 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > On 02/01/20 21:39, Vitaly Kuznetsov wrote: >> When enlightened VMCS is enabled, certain VMX controls disappear, e.g. >> posted interrupts for PINBASED_CTLS. With fine-grained VMX feature >> enablement QEMU tries to do KVM_SET_MSRS with default (matching CPU >> model) value

[PATCH] trace: update qemu-trace-stap to Python 3

2020-01-07 Thread Stefan Hajnoczi
qemu-trace-stap does not support Python 3 yet: $ scripts/qemu-trace-stap list path/to/qemu-system-x86_64 Traceback (most recent call last): File "scripts/qemu-trace-stap", line 175, in main() File "scripts/qemu-trace-stap", line 171, in main args.func(args) File "scrip

Re: [PATCH] tests/vm: update openbsd to release 6.6

2020-01-07 Thread Alex Bennée
Gerd Hoffmann writes: > Signed-off-by: Gerd Hoffmann Queued to testing/next, thanks. > --- > tests/vm/openbsd | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/vm/openbsd b/tests/vm/openbsd > index b92c39f89a6f..9f82cd459fde 100755 > --- a/tests/vm/openbsd >

Re: [PATCH v2] hppa: allow max ram size upto 4Gb

2020-01-07 Thread Helge Deller
On 07.01.20 12:21, Igor Mammedov wrote: > On Mon, 6 Jan 2020 18:03:49 +0100 >> So, I'd suggest to drop your wrong patch #43. > As you noted in your first reply, patch is correct. You probably got me wrong. Your patch #43 is wrong, and your fixup patch to some degree reverts it back again. In pat

Re: [PATCH 073/104] virtiofsd: passthrough_ll: clean up cache related options

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:33PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > - Rename "cache=never" to "cache=none" to match 9p's similar option. > > - Rename CACHE_NORMAL constant to CACHE_AUTO to match the "cache=auto" >option. > > Signed-off-by: Miklos Szere

Re: [PATCH v6 00/25] monitor: add asynchronous command type

2020-01-07 Thread Marc-André Lureau
Hi On Tue, Jan 7, 2020 at 9:17 AM Kevin Wolf wrote: > > Am 06.01.2020 um 19:21 hat Marc-André Lureau geschrieben: > > > What my patch does is moving everything into a coroutine. This is wrong > > > because not everything can be run in a coroutine, so it needs to be made > > > optional (like you d

[PATCH v2 1/1] block/rbd: Add support for ceph namespaces

2020-01-07 Thread Florian Florensa
Starting from ceph Nautilus, RBD has support for namespaces, allowing for finer grain ACLs on images inside a pool, and tenant isolation. In the rbd cli tool documentation, the new image-spec and snap-spec are : - [pool-name/[namespace-name/]]image-name - [pool-name/[namespace-name/]]image-name@

Re: [Qemu-devel] [PATCH v3] RISC-V: Select FPU gdb xml file based on the supported extensions

2020-01-07 Thread Alex Bennée
Georg Kotheimer writes: > The size of the FPU registers depends solely on the floating point > extensions supported by the target architecture. > However, in the previous implementation the floating point register > size was derived from whether the target architecture is 32-bit or > 64-bit. >

Re: [PATCH 062/104] virtiofsd: Handle hard reboot

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:22PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Handle a > mount > hard reboot (without unmount) > mount > > we get another 'init' which FUSE doesn't normally expect. > > Signed-off-by: Dr. David Alan Gilbert > --- > too

Re: [PATCH 096/104] virtiofsd: Reset O_DIRECT flag during file open

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:56PM +, Dr. David Alan Gilbert (git) wrote: > From: Vivek Goyal > > If an application wants to do direct IO and opens a file with O_DIRECT > in guest, that does not necessarily mean that we need to bypass page > cache on host as well. So reset this flag on host.

Re: [PATCH 063/104] virtiofsd: Kill threads when queues are stopped

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:23PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Kill the threads we've started when the queues get stopped. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 37 +++---

Re: [PATCH 088/104] virtiofsd: make lo_release() atomic

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:48PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Hold the lock across both lo_map_get() and lo_map_remove() to prevent > races between two FUSE_RELEASE requests. In this case I don't see a > serious bug but it's safer to do things atomical

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-07 Thread Thomas Huth
On 07/01/2020 11.14, Paolo Bonzini wrote: > On 07/01/20 11:03, Thomas Huth wrote: >>> >>> vm = QEMUMachine(iotests.qemu_prog) >>> -vm.add_args('-machine', 'accel=kvm:tcg') >>> +vm.add_args('-accel', 'kvm', '-accel', 'tcg') >> Looking at this, I wonder whether we really want the "-accel" option t

Re: [PATCH 076/104] virtiofsd: support nanosecond resolution for file timestamp

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:36PM +, Dr. David Alan Gilbert (git) wrote: > From: Jiufei Xue > > Define HAVE_STRUCT_STAT_ST_ATIM to 1 if `st_atim' is member of `struct > stat' which means support nanosecond resolution for the file timestamp > fields. > > Signed-off-by: Jiufei Xue > --- > c

Re: [PATCH 064/104] vhost-user: Print unexpected slave message types

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:24PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When we receive an unexpected message type on the slave fd, print > the type. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/virtio/vhost-user.c | 2 +- > 1 file changed, 1

Re: [PATCH v1 44/59] 9p-local.c: remove unneeded label in local_unlinkat_common()

2020-01-07 Thread Christian Schoenebeck
On Montag, 6. Januar 2020 19:24:10 CET Daniel Henrique Barboza wrote: > 'err_out' can be replaced by 'return ret' in the error conditions > the jump was being made. > > CC: Greg Kurz > Signed-off-by: Daniel Henrique Barboza > --- > hw/9pfs/9p-local.c | 12 +--- > 1 file changed, 5 inser

Re: [PATCH v2 1/7] configure: Drop adjustment of textseg

2020-01-07 Thread Alex Bennée
Richard Henderson writes: > This adjustment was random and unnecessary. The user mode > startup code in probe_guest_base() will choose a value for > guest_base that allows the host qemu binary to not conflict > with the guest binary. > > With modern distributions, this isn't even used, as the

Re: [PATCH 098/104] virtiofsd: add definition of fuse_buf_writev()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:58PM +, Dr. David Alan Gilbert (git) wrote: > From: piaojun > > Define fuse_buf_writev() which use pwritev and writev to improve io > bandwidth. Especially, the src bufs with 0 size should be skipped as > their mems are not *block_size* aligned which will cause w

Re: [PATCH 092/104] virtiofsd: add man page

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:52PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Signed-off-by: Stefan Hajnoczi > --- > Makefile | 7 +++ > tools/virtiofsd/virtiofsd.texi | 85 ++ > 2 files changed, 92 insertions(+)

Re: [RFC PATCH qemu] spapr: Kill SLOF

2020-01-07 Thread Thomas Huth
On 07/01/2020 10.39, Andrea Bolognani wrote: > On Tue, 2020-01-07 at 12:55 +1100, Alexey Kardashevskiy wrote: >> On 07/01/2020 01:15, Daniel Henrique Barboza wrote: >>> Question: does Petitboot already replaces SLOF in every possible >>> scenario for all >>> the spapr machine features? >> >> Petitb

Re: [PATCH 2/3] gitlab-ci.yml: Add a job to build EDK2 firmware binaries

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 11:12 AM, Laszlo Ersek wrote: On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: Add a GitLab job to build the EDK2 firmware binaries. This job is only built when the roms/edk2/ submodule is updated, when a git-ref starts with 'edk2' or when the last commit contains 'EDK2'. keyword "or

KVM call for agenda for 2020-01-14

2020-01-07 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. We have already one topic for this call already: * Multi-process QEMU and muser By popular demand, a google calendar public entry with it https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAu

Re: [PATCH 095/104] virtiofsd: convert more fprintf and perror to use fuse log infra

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:55PM +, Dr. David Alan Gilbert (git) wrote: > From: Eryu Guan > > Signed-off-by: Eryu Guan > --- > tools/virtiofsd/fuse_signals.c | 6 +- > tools/virtiofsd/helper.c | 9 ++--- > 2 files changed, 11 insertions(+), 4 deletions(-) Reviewed-by: Danie

Re: [PATCH 068/104] virtiofsd: passthrough_ll: control readdirplus

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:28PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > What is readdirplus and what do we need a command line option to control it ? What's the user benefit of changing the setting ? > Signed-off-by: Miklos Szeredi > --- > tools/virtiofsd/passthr

Re: [PATCH 079/104] virtiofsd: fix memory leak on lo.source

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:39PM +, Dr. David Alan Gilbert (git) wrote: > From: Liu Bo > > valgrind reported that lo.source is leaked on quiting, but it was defined > as (const char*) as it may point to a const string "/". > > Signed-off-by: Liu Bo > --- > tools/virtiofsd/passthrough_ll.

Re: Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-07 Thread Paolo Bonzini
On 07/01/20 13:18, Thomas Huth wrote: > I don't think we need a separate priority parameter here. But IMHO it's > really rather common practice to prioritize the last option. So while > it might be more "self-explanatory" to a CLI newbie if the first > occurrence got the highest priority, it might

Re: [PATCH 032/132] meson: uncompress edk2 bios

2020-01-07 Thread Paolo Bonzini
On 03/01/20 11:52, Philippe Mathieu-Daudé wrote: > > +foreach f : fds > Can strip space between f/column. Could, but it seems like other meson.build files usually leave a space in. Paolo

Re: [PATCH RFC] i386/kvm: fix enlightened VMCS with fine-grained VMX feature enablement

2020-01-07 Thread Paolo Bonzini
On 07/01/20 13:08, Vitaly Kuznetsov wrote: > Honestly I forgot the story why we filtered out these features upon > eVMCS enablement in KVM. As there are no corresponding eVMCS fields, > there's no way a guest can actually use them. Well, mostly because we mimicked what Hyper-V was doing I guess.

Re: [RFC PATCH 1/1] target/arm: kvm: Handle DABT with no valid ISS

2020-01-07 Thread Beata Michalska
On Mon, 6 Jan 2020 at 17:15, Peter Maydell wrote: > > On Fri, 20 Dec 2019 at 20:27, Beata Michalska > wrote: > > > > On ARMv7 & ARMv8 some load/store instructions might trigger a data abort > > exception with no valid ISS info to be decoded. The lack of decode info > > makes it at least tricky to

Re: [PATCH 01/14] hw/usb/redirect: Do not link 'usb-redir' device when USB not enabled

2020-01-07 Thread Thomas Huth
On 31/12/2019 19.32, Philippe Mathieu-Daudé wrote: > The 'usb-redir' device requires the USB core code to work. Do not > link it when there is no USB support. This fixes: > > $ qemu-system-tricore -M tricore_testboard -device usb-redir > qemu-system-tricore: -device usb-redir: No 'usb-bus' bus

Re: [PATCH v18 6/7] migration: Include migration support for machine check handling

2020-01-07 Thread Ganesh
On 1/3/20 7:55 AM, David Gibson wrote: On Thu, Jan 02, 2020 at 01:21:10PM +0530, Ganesh Goudar wrote: From: Aravinda Prasad This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete

Re: [PATCH v2 4/9] tests/virtio-9p: added readdir test

2020-01-07 Thread Christian Schoenebeck
On Montag, 6. Januar 2020 18:22:52 CET Greg Kurz wrote: > > diff --git a/tests/virtio-9p-test.c b/tests/virtio-9p-test.c > > index 06263edb53..48c0eca292 100644 > > --- a/tests/virtio-9p-test.c > > +++ b/tests/virtio-9p-test.c > > @@ -68,6 +68,11 @@ static void v9fs_memread(P9Req *req, void *addr,

Re: [PATCH 080/104] virtiofsd: add helper for lo_data cleanup

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:40PM +, Dr. David Alan Gilbert (git) wrote: > From: Liu Bo > > This offers an helper function for lo_data's cleanup. > > Signed-off-by: Liu Bo > --- > tools/virtiofsd/passthrough_ll.c | 37 ++-- > 1 file changed, 21 insertions(+), 1

Re: [PATCH v2 0/1] block/rbd: Add support for ceph namespaces

2020-01-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200107111340.334965-1-fflore...@online.net/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at http://patchew.org/logs/2020010711134

Re: [PATCH 074/104] virtiofsd: passthrough_ll: use hashtable

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:34PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > Improve performance of inode lookup by using a hash table. > > Signed-off-by: Miklos Szeredi > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Liu Bo > --- > tools/virtiofsd/passth

Re: [PATCH v2 01/10] ppc: Drop PPC_EMULATE_32BITS_HYPV stub

2020-01-07 Thread Cédric Le Goater
On 1/7/20 5:48 AM, David Gibson wrote: > The only effect of the PPC_EMULATE_32BITS_HYPV define is to change how > MSR_HVB is defined. This appears to be something to handle hypervisor mode > for 32-bit CPUs, but there's really no other code to handle this. The > MSR_THV bit, which it uses is impl

  1   2   3   4   5   6   >