Il dom 22 dic 2019, 08:49 Ani Sinha ha scritto:
>
> Ping …
>
Why ping? You got questions from Eduardo, so you need to answer them and/or
send a fixed version of the patch.
Thanks,
Paolo
> > On Dec 18, 2019, at 5:23 PM, Paolo Bonzini wrote:
> >
> > On 18/12/19 10:05, Ani Sinha wrote:
> >> CL
Hi Helge,
On Sat, Dec 21, 2019 at 11:24:02PM +0100, Helge Deller wrote:
> When qemu was started with the -nographic option, do not enable the
> artist graphic card emulation.
Hmm, isn't '-nographic -vnc' a valid option that wouldn't work anymore in that
case? I used '-nographic -vga none' to disa
On Thu, Dec 19, 2019 at 07:11:45PM +0100, Cédric Le Goater wrote:
> This removes the need of the intermediate link under PSI to pass the
> XICS link to the underlying ICSState object.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Greg Kurz
> Signed-off-by: Cédric Le Goater
LGTM, but will
Hi,
I've since confirmed that this bug also exist (as expected) on Linux
guests, as well as Zen1 EPYC 7401 CPUs, to make sure this wasn't a
problem with the detection of the newer consumer platform.
Basically it seems (looking at the code with layman eyes) that as long
as you have a topology that
This is the commit I am referencing:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=8f4202fb1080f86958782b1fca0bf0279f67d136
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1856335
Title:
Cache Layo
Hi Sven,
On 22.12.19 09:39, Sven Schnelle wrote:
> On Sat, Dec 21, 2019 at 11:24:02PM +0100, Helge Deller wrote:
>> When qemu was started with the -nographic option, do not enable the
>> artist graphic card emulation.
>
> Hmm, isn't '-nographic -vnc' a valid option that wouldn't work anymore in
>
On 20/12/19 16:42, Philippe Mathieu-Daudé wrote:
> In commit 6c730e4af9 we introduced a stub to build the MicroVM
> machine without Intel IOMMU. This stub is incomplete for the
> other PC machines. Add the missing stubs.
In other words, without this patch you cannot build without Q35 (which
brings
On 19/12/2019 20:14, Laurent Vivier wrote:
> The command byte is not decoded correctly.
>
> This patch reworks the RTC/PRAM interface and fixes the problem.
> It adds a comment before the function to explain how are encoded commands
> and some trace-events to ease debugging.
>
> Bug: https://bug
On 18/12/2019 19:25, Philippe Mathieu-Daudé wrote:
> When building with GCC9 using CFLAG -Wimplicit-fallthrough=2 we get:
>
> hw/display/tcx.c: In function ‘tcx_dac_writel’:
> hw/display/tcx.c:453:26: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 453 |
Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an
image has subclusters. Instead, the individual 'all zeroes' bits must
be used.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/block/qcow
This patch adds QCow2SubclusterType, which is the subcluster-level
version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the
the same meaning as their QCOW2_CLUSTER_* equivalents (when they
exist). See below for details and caveats.
In images without extended L2 entries clusters are trea
Ideally it should be possible to zero individual subclusters using
this function, but this is currently not implemented.
Signed-off-by: Alberto Garcia
---
block/qcow2.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 242001afa2..0267722065 100644
---
When writing to a qcow2 file there are two functions that take a
virtual offset and return a host offset, possibly allocating new
clusters if necessary:
- handle_copied() looks for normal data clusters that are already
allocated and have a reference count of 1. In those clusters we
ca
handle_alloc() creates a QCowL2Meta structure in order to update the
image metadata and perform the necessary copy-on-write operations.
This patch moves that code to a separate function so it can be used
from other places.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 77 +++
The L2 bitmap needs to be updated after each write to indicate what
new subclusters are now allocated.
This needs to happen even if the cluster was already allocated and the
L2 entry was otherwise valid.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 17 +
1 file chan
For a given offset, return the subcluster number within its cluster
(i.e. with 32 subclusters per cluster it returns a number between 0
and 31).
Signed-off-by: Alberto Garcia
---
block/qcow2.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/block/qcow2.h b/block/qcow2.h
index 941330cfc9
Extended L2 entries are 128-bit wide: 64 bits for the entry itself and
64 bits for the subcluster allocation bitmap.
In order to support them correctly get/set_l2_entry() need to be
updated so they take the entry width into account in order to
calculate the correct offset.
This patch also adds th
This patch adds the following new fields to BDRVQcow2State:
- subclusters_per_cluster: Number of subclusters in a cluster
- subcluster_size: The size of each subcluster, in bytes
- subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size
Images without subclusters are treated as if
Signed-off-by: Alberto Garcia
---
tests/qemu-iotests/271 | 256 +
tests/qemu-iotests/271.out | 208 ++
tests/qemu-iotests/group | 1 +
3 files changed, 465 insertions(+)
create mode 100755 tests/qemu-iotests/271
create mode
l2meta_cow_start() and l2meta_cow_end() are not necessarily
cluster-aligned if the image has subclusters, so update the
calculation of old_start and old_end to guarantee that no two requests
try to write on the same cluster.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 4 ++--
1 fil
The bdrv_co_pwrite_zeroes() call here fills complete clusters with
zeroes, but it can happen that some subclusters are not part of the
write request or the copy-on-write. This patch makes sure that only
the affected subclusters are overwritten.
A potential improvement would be to also fill with ze
Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an
image has subclusters. Instead, the individual 'all zeroes' bits must
be used.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-cluster.c
Compressed clusters always have the bitmap part of the extended L2
entry set to 0.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index ed291a4042..af0f01621c 100644
--- a/block/qcow2-cl
If an image has subclusters then there are more copy-on-write
scenarios that we need to consider. Let's say we have a write request
from the middle of subcluster #3 until the end of the cluster:
- If the cluster is new, then subclusters #0 to #3 from the old
cluster must be copied into the
Setting the QCOW_OFLAG_ZERO bit of the L2 entry is forbidden if an
image has subclusters. Instead, the individual 'all zeroes' bits must
be used.
Signed-off-by: Alberto Garcia
---
block/qcow2-refcount.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-refc
When dealing with subcluster types there is a new value called
QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC that has no equivalent in
QCow2ClusterType.
This patch handles that value in all places where subcluster types
are processed.
Signed-off-by: Alberto Garcia
---
block/qcow2.c | 12 +---
1 fi
The size of an L2 entry is 64 bits, but if we want to have subclusters
we need extended L2 entries. This means that we have to access L2
tables and slices differently depending on whether an image has
extended L2 entries or not.
This patch replaces all l2_slice[] accesses with calls to
get_l2_entr
Hi,
here's the new version of the patches to add subcluster allocation
support to qcow2.
Please refer to the cover letter of the first version for a full
description of the patches:
https://lists.gnu.org/archive/html/qemu-block/2019-10/msg00983.html
This version fixes many of the problems hi
Two changes are needed in order to add subcluster support to this
function: deallocated clusters must have their bitmaps cleared, and
expanded clusters must have all the "subcluster allocated" bits set.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.c | 6 ++
1 file changed, 6 inserti
This function will be used by the qcow2 code to check if an image has
subclusters or not.
At the moment this simply returns false. Once all patches needed for
subcluster support are ready then QEMU will be able to create and
read images with subclusters and this function will return the actual
val
The logic of this function remains pretty much the same, except that
it uses count_contiguous_subclusters(), which combines the logic of
count_contiguous_clusters() / count_contiguous_clusters_unallocated()
and checks individual subclusters.
Signed-off-by: Alberto Garcia
---
block/qcow2-cluster.
We are going to need it in other places.
Signed-off-by: Alberto Garcia
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-cluster.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index
Subcluster allocation in qcow2 is implemented by extending the
existing L2 table entries and adding additional information to
indicate the allocation status of each subcluster.
This patch documents the changes to the qcow2 format and how they
affect the calculation of the L2 cache size.
Signed-of
Extended L2 entries are bigger than normal L2 entries so this has an
impact on the amount of metadata needed for a qcow2 file.
Signed-off-by: Alberto Garcia
---
block/qcow2.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
in
qcow2 images with subclusters have 128-bit L2 entries. The first 64
bits contain the same information as traditional images and the last
64 bits form a bitmap with the status of each individual subcluster.
Because of that we cannot assume that L2 entries are sizeof(uint64_t)
anymore. This function
In order to support extended L2 entries some functions of the qcow2
driver need to start dealing with subclusters instead of clusters.
qcow2_get_cluster_offset() is modified to return the subcluster
type instead of the cluster type, and all callers are updated to
replace all values of QCow2Cluster
Now that the implementation of subclusters is complete we can finally
add the necessary options to create and read images with this feature,
which we call "extended L2 entries".
Signed-off-by: Alberto Garcia
---
block/qcow2.c| 65 ++--
block/qcow2.h
On 5/17/19 7:42 PM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
>> How do you want to proceed with all the information provided in this
>> thread? I think a big table in the wiki collecting the answers is ideal.
>> What do you think?
>
> Yes, please! I haven't been able to find
On 21/12/19 17:21, Peter Wu wrote:
> When the 'vga=' parameter is succeeded by another parameter, QEMU 4.2.0
> would refuse to start with a rather cryptic message:
>
> $ qemu-system-x86_64 -kernel /boot/vmlinuz-linux -append 'vga=792 quiet'
> qemu: can't parse 'vga' parameter: Invalid argu
On 12/20/19 10:15 PM, Sven Schnelle wrote:
> Helge Deller (13):
> Add PDC_MEM_MAP and ENTRY_INIT_SRCH_FRST for OSF/MkLinux
> Return non-existant BTLB for PDC_BLOCK_TLB
> Add serial, parallel and LAN port support of LASI chip
> Implement ENTRY_IO_BBLOCK_IN IODC function
>
On 12/20/19 10:15 PM, Sven Schnelle wrote:
> This adds emulation of Artist graphics good enough
> to get a Text console on both Linux and HP-UX. The
> X11 server from HP-UX also works.
>
> Signed-off-by: Sven Schnelle
> ---
> hw/display/Kconfig |4 +
> hw/display/Makefile.objs |1 +
On Fri, Dec 20, 2019 at 06:24:43PM +, Peter Maydell wrote:
> On Thu, 19 Dec 2019 at 13:27, Michael S. Tsirkin wrote:
> >
> > The following changes since commit b0ca999a43a22b38158a33d3f5881648bb4f:
> >
> > Update version for v4.2.0 release (2019-12-12 16:45:57 +)
> >
> > are availabl
On Fri, Dec 20, 2019 at 06:24:43PM +, Peter Maydell wrote:
> On Thu, 19 Dec 2019 at 13:27, Michael S. Tsirkin wrote:
> >
> > The following changes since commit b0ca999a43a22b38158a33d3f5881648bb4f:
> >
> > Update version for v4.2.0 release (2019-12-12 16:45:57 +)
> >
> > are availabl
On Fri, Dec 20, 2019 at 05:09:03PM +0300, Denis Plotnikov wrote:
> v5:
> * rebased on the recent master [MST]
> * NOTE: the test doesn't pass because 5.0 machine type use 4.2 compat
> instead of it's own or no compat at all. The test will pass
> once the new 5.0 compat is us
Public bug reported:
I'm encountering a bug with the e1000e network driver, that appears to
got previously reported at rhbz. Steps to reproduce are provided in
detail there:
https://bugzilla.redhat.com/show_bug.cgi?id=1707646
It is about switching off network link state (set_link net0 off) havin
On Sun, 22 Dec 2019 01:03:04 +0900,
Aleksandar Markovic wrote:
>
> [1 ]
> [2 ]
> On Saturday, December 21, 2019, Yoshinori Sato
> wrote:
>
> Signed-off-by: Yoshinori Sato
>
> Message-Id: <20190616142836.10614-4-ys...@users.sourceforge.jp>
> Reviewed-by: Richard Henderson
>
On Wednesday, December 18, 2019, Michael Rolnik wrote:
> This includes:
> - ADD, ADC, ADIW
> - SBIW, SUB, SUBI, SBC, SBCI
> - AND, ANDI
> - OR, ORI, EOR
> - COM, NEG
> - INC, DEC
> - MUL, MULS, MULSU
> - FMUL, FMULS, FMULSU
> - DES
>
>
>
...
+
> +/*
> + * Performs the logical AND between the co
On Wednesday, December 18, 2019, Michael Rolnik wrote:
> Signed-off-by: Michael Rolnik
> Reviewed-by: Philippe Mathieu-Daudé
> Tested-by: Philippe Mathieu-Daudé
> ---
> target/avr/translate.c | 143 +
> 1 file changed, 143 insertions(+)
> create mode 1
This fixes a freeze at reboot, introduced in
c627e7526a902dd5bb1907dbbd5cf961679dfa68
Signed-off-by: Hervé Poussineau
---
hw/dma/rc4030.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
index c4cf8236f4..76302fe431 100644
--- a/hw/dma/rc4030.c
+++ b/hw/dma/
Public bug reported:
Hello,
I am working with windows qemu version:
qemu-w64-setup-20190815
I have installed a msdos virtual machine on qemu with sp keyboard layout
(Spain at Europe). I have found that some keys do not work in the way
they should. I believe that the problem is that es qemu span
On Thu, Dec 19, 2019 at 07:11:46PM +0100, Cédric Le Goater wrote:
> POWER8 is the only chip using the XICS interface. Add a "xics" link
> and a XICSFabric attribute under this chip to remove the use of
> qdev_get_machine()
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Greg Kurz
> Signed-off
On Thu, Dec 19, 2019 at 07:11:47PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> The XIVE router base class currently inherits an empty realize hook
> from the sysbus device base class, but it will soon implement one
> of its own to perform some sanity checks. Do the preliminary plumbing
>
On Thu, Dec 19, 2019 at 07:11:48PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> The XIVE router base class currently inherits an empty realize hook
> from the sysbus device base class, but it will soon implement one
> of its own to perform some sanity checks. Do the preliminary plumbing
>
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1605506
Title:
qemu driver
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1575561
Title:
config qemu
On Tue, Dec 17, 2019 at 02:48:20AM -0600, Shivaprasad G Bhat wrote:
> nvdimm_device_list is required for parsing the list for devices
> in subsequent patches. Move it to common utility area.
>
> Signed-off-by: Shivaprasad G Bhat
> Reviewed-by: Igor Mammedov
Reviewed-by: David Gibson
> ---
>
On Tue, Dec 17, 2019 at 02:48:49AM -0600, Shivaprasad G Bhat wrote:
> For ppc64, PAPR requires the nvdimm device to have UUID property
> set in the device tree. Add an option to get it from the user.
>
> Signed-off-by: Shivaprasad G Bhat
Reviewed-by: David Gibson
> ---
> hw/mem/nvdimm.c
On Thu, Dec 19, 2019 at 07:11:49PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> In order to get rid of qdev_get_machine(), first add a pointer to the
> XIVE fabric under the XIVE router and make it configurable through a
> QOM link property.
>
> Configure it in the spapr and pnv machine.
On Thu, Dec 19, 2019 at 07:11:51PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> Set it at chip creation and forward it to the cores. This allows to drop
> a call to qdev_get_machine().
>
> Signed-off-by: Greg Kurz
> Signed-off-by: Cédric Le Goater
Reviewed-by: David Gibson
But will
On Thu, Dec 19, 2019 at 07:11:50PM +0100, Cédric Le Goater wrote:
> From: Greg Kurz
>
> Now that the spapr and pnv machines do set the "xive-fabric" link, the
> use of the XIVE fabric pointer becomes mandatory. This is checked with
> an assert() in a new realize hook. Since the XIVE router is rea
On Thu, Dec 19, 2019 at 07:11:42PM +0100, Cédric Le Goater wrote:
> Hello,
>
> The PowerNV and sPAPR machine use qdev_get_machine() and
> get_system_memory() in some places. This is not a good modeling
> pratice and it should be avoided. This series replaces the uses of
> these routines with a set
On Thu, Dec 19, 2019 at 01:38:54PM -0300, Maxiwell S. Garcia wrote:
> The env->hflags is computed in ppc_cpu_reset(), using the MSR register
> as input. But at the point ppc_disas_set_info() is called the MSR_LE bit
> in env->hflags doesn't contain the same information that env->msr.
>
> Signed-of
5.0 machine type uses 4.2 compats. This seems to be incorrect, since
the latests machine type by now is 5.0 and it should use its own
compat or shouldn't use any relying on the defaults.
Seems, like this appeared because of some problems on merge/rebase.
Signed-off-by: Denis Plotnikov
---
hw/i38
在 2019/12/20 下午9:45, Marc-André Lureau 写道:
Migration from old to new code works, however the other way fails for
devices that use serial_init/serial_mm_init with "base", used as
instance_id previously.
(with qdev_set_legacy_instance_id, the alias_id is only used in
savevm.c:find_se(), and thus c
Commit 6f6e1698a68ceb made these options incompatible, but it breaks
iotests:
-accel qtest comes from QEMUQtestMachine
and
-machine accel=qtest comes from QEMU_OPTIONS
After this patch, -accel may still be duplicated, but this is less
invasive.
Also, fix extra comma in comment, added by the
在 2019/12/20 下午9:45, Marc-André Lureau 写道:
Internally, qemu may create chardev without ID. Those will not be
looked up with qemu_chr_find(), which prevents using qdev_prop_set_chr().
Use id_generate(), to generate an internal name (prefixed with #), so
no conflict exist with user-named chardev.
在 2019/12/20 下午9:45, Marc-André Lureau 写道:
Migration from old to new code works, however the other way fails for
devices that use serial_init/serial_mm_init with "base", used as
instance_id previously.
(with qdev_set_legacy_instance_id, the alias_id is only used in
savevm.c:find_se(), and thus
67 matches
Mail list logo
