On 20/12/19 16:42, Philippe Mathieu-Daudé wrote:
> In commit 6c730e4af9 we introduced a stub to build the MicroVM
> machine without Intel IOMMU. This stub is incomplete for the
> other PC machines. Add the missing stubs.
In other words, without this patch you cannot build without Q35 (which
brings in the IOMMU, at least unless building
--without-default-devices). Is this correct?
Paolo
>
> Fixes: 6c730e4af9
> Reported-by: Travis-CI
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> ---
> hw/i386/x86-iommu-stub.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/i386/x86-iommu-stub.c b/hw/i386/x86-iommu-stub.c
> index 03576cdccb..c5ba077f9d 100644
> --- a/hw/i386/x86-iommu-stub.c
> +++ b/hw/i386/x86-iommu-stub.c
> @@ -32,3 +32,12 @@ X86IOMMUState *x86_iommu_get_default(void)
> return NULL;
> }
>
> +bool x86_iommu_ir_supported(X86IOMMUState *s)
> +{
> + return false;
> +}
> +
> +IommuType x86_iommu_get_type(void)
> +{
> + abort();
> +}
>
