In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT),
The initiator represents processor which access to memory. And in 5.2.27.3
Memory Proximity Domain Attributes Structure, the attached initiator is
defined as where the memory controller responsible for a memory proximity
domain
From: Liu Jingqi
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
Signed-off-
From: Liu Jingqi
HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table
(HMAT). The specification references below link:
http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf
It describes the memory attributes, such as memory side cache
attributes and bandw
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
Heterogeneous Memory with boot option '-numa node'.
Add test cases on PC and Q35 machines with 2 numa nodes.
Because HMAT is generated when system enable numa, the
following tables need to be added for this test:
tests/data/a
From: Liu Jingqi
Add -numa hmat-cache option to provide Memory Side Cache Information.
These memory attributes help to build Memory Side Cache Information
Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
Reviewed-by: Daniel Black
Signed-off-by: Liu Jingqi
Signed-off-by: Tao Xu
From: Liu Jingqi
This structure describes memory side cache information for memory
proximity domains if the memory side cache is present and the
physical device forms the memory side cache.
The software could use this information to effectively place
the data in memory to maximize the performance
On 14.11.19 18:39, janine.schnei...@fau.de wrote:
> Hello,
>
> thank you for the quick feedback. I am sorry that I expressed myself so
> unclearly. I don't want to use qemu but want to know how qemu converts vmdk
> to raw. So how exactly is the conversion programmed? How are the sparse
> grains pu
Check configuring HMAT usecase
Suggested-by: Igor Mammedov
Signed-off-by: Tao Xu
---
New patch in v16.
---
tests/numa-test.c | 51 +++
1 file changed, 51 insertions(+)
diff --git a/tests/numa-test.c b/tests/numa-test.c
index 8de8581231..15889c26c0 1
On Wed, Nov 13, 2019 at 05:45:57PM +0100, Markus Armbruster wrote:
> Wolfgang Bumiller writes:
>
> > When a monitor's queue is filled up in handle_qmp_command()
> > it gets suspended. It's the dispatcher bh's job currently to
> > resume the monitor, which it does after processing an event
> > fro
I totally agree with everything you said! That would allow accessible use of
remote virtual machines, which I initially thought of as rather unnecessary but
it definitely is not. I just did not dare to even think of the new
possibilities it would offer!
Brlapi already has a file descriptor. Cou
On 11/13/19 10:30 PM, Peter Maydell wrote:
> Coverity may also be looking at the case where
> TARGET_AARCH64 is not defined. The fallback definition
> of arm_cpu_vq_map_next_smaller() for that situation
> always returns 0.
Yeah, that makes more sense.
I think we can make the fallback g_assert_not_
Add new version of Snowridge, Denverton, Opteron_G3, EPYC, and Dhyana
CPU model to remove MONITOR/MWAIT feature.
After QEMU/KVM use "-overcommit cpu-pm=on" to expose MONITOR/MWAIT
(commit id 6f131f13e68d648a8e4f083c667ab1acd88ce4cd), the MONITOR/MWAIT
feature in these CPU model is unused.
Signed-
Is this a fresh image or is it possible that it already had some latent
corruption from a previous run with an unfixed version? If it wasn't
fresh, did you run qemu-img check after upgrading QEMU and it still was
clean, so we know the corruption was introduced by the new version?
Is the problem ea
Patchew URL: https://patchew.org/QEMU/20191115075352.17734-1-tao3...@intel.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v16 00/14] Build ACPI Heterogeneous Memory Attribute Table
(HMAT)
Type: series
Message-id: 201911150
On Thu, Nov 14, 2019 at 02:34:49PM +0100, Jens Freimann wrote:
> When an error occurs in migrate_add_blocker() it sets a
> negative return value and uses error pointer we pass in.
> Instead of just looking at the error pointer check for a negative return
> value and avoid a coverity error because t
When a monitor's queue is filled up in handle_qmp_command()
it gets suspended. It's the dispatcher bh's job currently to
resume the monitor, which it does after processing an event
from the queue. However, it is possible for a
CHR_EVENT_CLOSED event to be processed before before the bh
is scheduled
On Wed, Nov 13, 2019 at 05:00:40PM +0100, Greg Kurz wrote:
> On Wed, 13 Nov 2019 15:31:58 +
> Peter Maydell wrote:
>
> > On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote:
> > > David is away until the 19th of November, which is the release date
> > > of rc2 according to the planning [*]. Then w
On 14.11.19 12:59, Vladimir Sementsov-Ogievskiy wrote:
> 14.11.2019 14:27, Max Reitz wrote:
>> On 13.11.19 19:43, Andrey Shinkevich wrote:
>>> Allow writing all the data compressed through the filter driver.
>>> The written data will be aligned by the cluster size.
>>> Based on the QEMU current imp
On Mon, 11 Nov 2019 09:40:45 +0800
Xiang Zheng wrote:
> From: Dongjiu Geng
>
> This patch implements APEI GHES Table generation via fw_cfg blobs. Now
> it only supports ARMv8 SEA, a type of GHESv2 error source. Afterwards,
> we can extend the supported types if needed. For the CPER section,
> c
On Mon, 11 Nov 2019 09:40:44 +0800
Xiang Zheng wrote:
> From: Dongjiu Geng
>
> Add APEI/GHES detailed design document
>
> Signed-off-by: Dongjiu Geng
> Signed-off-by: Xiang Zheng
> Reviewed-by: Michael S. Tsirkin
> ---
> docs/specs/acpi_hest_ghes.rst | 95 ++
On 15/11/2019 12:32, Max Reitz wrote:
> On 14.11.19 12:59, Vladimir Sementsov-Ogievskiy wrote:
>> 14.11.2019 14:27, Max Reitz wrote:
>>> On 13.11.19 19:43, Andrey Shinkevich wrote:
Allow writing all the data compressed through the filter driver.
The written data will be aligned by the
This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
[1]
https://kvmforum2019.sched.com/event/Tmwr/micro-optimizing-kvm-vm-exits-andrea-arcangeli-red-hat-inc
Signed-off-by: Kashyap Chamarthy
---
v2: Address Ri
On Thu, 14 Nov 2019 18:42:35 +0100
Pierre Morel wrote:
> On 2019-11-14 14:19, Cornelia Huck wrote:
> > On Thu, 14 Nov 2019 14:02:35 +0100
> > Halil Pasic wrote:
> >
> >> On Thu, 14 Nov 2019 11:38:23 +0100
> >> Cornelia Huck wrote:
> >>
> >>> On Wed, 13 Nov 2019 20:02:33 +0100
> >>> Pierre M
On 15/11/2019 10:20, David Gibson wrote:
> On Wed, Nov 13, 2019 at 05:00:40PM +0100, Greg Kurz wrote:
>> On Wed, 13 Nov 2019 15:31:58 +
>> Peter Maydell wrote:
>>
>>> On Wed, 13 Nov 2019 at 15:10, Greg Kurz wrote:
David is away until the 19th of November, which is the release date
o
15.11.2019 12:32, Max Reitz wrote:
> On 14.11.19 12:59, Vladimir Sementsov-Ogievskiy wrote:
>> 14.11.2019 14:27, Max Reitz wrote:
>>> On 13.11.19 19:43, Andrey Shinkevich wrote:
Allow writing all the data compressed through the filter driver.
The written data will be aligned by the cluste
On Thu, 14 Nov 2019 at 22:27, Keith Packard wrote:
>
> Richard Henderson writes:
>
> > For semi-hosting, it seems even better if the semi-hosting syscall
> > instruction
> > is not "real", because you're explicitly requesting services from "unreal"
> > hardware. It should be specified to genera
15.11.2019 13:52, Vladimir Sementsov-Ogievskiy wrote:
> 15.11.2019 12:32, Max Reitz wrote:
>> On 14.11.19 12:59, Vladimir Sementsov-Ogievskiy wrote:
>>> 14.11.2019 14:27, Max Reitz wrote:
On 13.11.19 19:43, Andrey Shinkevich wrote:
> Allow writing all the data compressed through the filter
On Fri, 15 Nov 2019 at 05:03, Michael Goffioul
wrote:
> When running QEMU user mode on some code compiled by clang (dynamic linker
> from AOSP-10), the emulator chokes on this instruction:
>
>9aa92: e8c0 2277 strexd r7, r2, r2, [r0]
I think that ought to be a valid insn...
> Fr
On Thu, Nov 14, 2019 at 08:25:31PM +0300, Alexander Popov wrote:
The commit a718978ed58a from July 2015 introduced the assertion which
implies that the size of successful DMA transfers handled in ide_dma_cb()
should be multiple of 512 (the size of a sector). But guest systems can
initiate DMA tra
Hi,
> > I am afraid it will be slightly unreadable when looking at file histories.
> > The only commit that didn't change was:
> > [SeaBIOS] [PATCH v4 2/5] boot: Reorder functions in boot.c
>
> Hmm, looks like there have been more changes than I remember.
Yep, v3..v4 diff is pretty big, so rev
The LPC object has both a pointer and a "psi" property pointing to the
PSI object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
Signed-off-by: Greg Kurz
---
hw/ppc/pnv.c |8
hw/ppc/pnv_lpc.c |
Patchew URL:
https://patchew.org/QEMU/20191115102406.31316-1-kcham...@redhat.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ==
There's a recurring pattern in the code where a const link is added to a
newly instanciated object and the link is then used in the object's realize
function to keep a pointer to the QOM entity which the link points to.
void create_obj_B(Object *obj_a)
{
Object *obj_b;
obj_b = object_new(
On Tue, Nov 12, 2019 at 11:48:11AM +0100, Cornelia Huck wrote:
> Add 5.0 machine types for arm/i440fx/q35/s390x/spapr.
>
> For i440fx and q35, unversioned cpu models are still translated
> to -v1; I'll leave changing this (if desired) to the respective
> maintainers.
>
> Signed-off-by: Cornelia H
Looks great
Sam
On Fri, Nov 15, 2019 at 1:35 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > I am afraid it will be slightly unreadable when looking at file histories.
> > > The only commit that didn't change was:
> > > [SeaBIOS] [PATCH v4 2/5] boot: Reorder functions in boot.c
> >
> > Hmm, looks like
The TCTX object has both a pointer and a "cpu" property pointing to the
vCPU object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
Signed-off-by: Greg Kurz
---
hw/intc/xive.c | 25 -
1 f
The source object has both a pointer and a "xive" property pointing to the
notifier object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
The property isn't optional : not being able to set the link is a bug
and QEM
The OCC object has both a pointer and a "psi" property pointing to the
PSI object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
Signed-off-by: Greg Kurz
---
hw/ppc/pnv.c |8
hw/ppc/pnv_occ.c |
The END source object has both a pointer and a "xive" property pointing to
the router object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
The property isn't optional : not being able to set the link is a bug
and Q
The homer object has both a pointer and a "chip" property pointing to the
chip object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
Signed-off-by: Greg Kurz
---
hw/ppc/pnv.c |8
hw/ppc/pnv_hom
On 15.11.19 11:12, Andrey Shinkevich wrote:
>
>
> On 15/11/2019 12:32, Max Reitz wrote:
>> On 14.11.19 12:59, Vladimir Sementsov-Ogievskiy wrote:
>>> 14.11.2019 14:27, Max Reitz wrote:
On 13.11.19 19:43, Andrey Shinkevich wrote:
> Allow writing all the data compressed through the filter
The XIVE object has both a pointer and a "chip" property pointing to the
chip object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
While here, rename pnv_xive_init() to pnv_xive_instance_init() for
clarity.
Signe
The core object has both a pointer and a "chip" property pointing to the
chip object. Confusing bugs could arise if these ever go out of sync.
Change the property definition so that it explicitely sets the pointer.
Signed-off-by: Greg Kurz
---
hw/ppc/pnv.c |4 ++--
hw/ppc/pnv_c
On 15.11.19 11:55, Vladimir Sementsov-Ogievskiy wrote:
> 15.11.2019 13:52, Vladimir Sementsov-Ogievskiy wrote:
>> 15.11.2019 12:32, Max Reitz wrote:
>>> On 14.11.19 12:59, Vladimir Sementsov-Ogievskiy wrote:
14.11.2019 14:27, Max Reitz wrote:
> On 13.11.19 19:43, Andrey Shinkevich wrote:
>
Hi Klaus,
On Wed, 13 Nov 2019 at 06:12, Klaus Birkelund wrote:
>
> On Tue, Nov 12, 2019 at 03:04:38PM +, Beata Michalska wrote:
> > Hi Klaus
> >
>
> Hi Beata,
>
> Thank you very much for your thorough reviews! I'll start going through
> them one by one :) You might have seen that I've posted
On 13/11/19 19:54, Sunil Muthuswamy wrote:
> This refactors the load library of WHV libraries to make it more
> modular. It makes a helper routine that can be called on demand.
> This allows future expansion of load library/functions to support
> functionality that is dependent on some feature bein
On 08/11/2019 10.22, Kashyap Chamarthy wrote:
> This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
> given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
>
Hi Kashyap,
first thanks for writing up this article! It's a really nice summary of
the presentation, I
Cc'ing Markus & Stefan.
On 11/15/19 8:53 AM, Tao Xu wrote:
Add do_strtomul() to convert string according to different suffixes.
Reviewed-by: Eduardo Habkost
Signed-off-by: Tao Xu
---
No changes in v16.
Changes in v15:
- Add a new patch to refactor do_strtosz() (Eduardo)
---
util/cuti
On 15/11/2019 12:53, Greg Kurz wrote:
> There's a recurring pattern in the code where a const link is added to a
> newly instanciated object and the link is then used in the object's realize
> function to keep a pointer to the QOM entity which the link points to.
>
> void create_obj_B(Object *obj_
On 15/11/19 13:08, Thomas Huth wrote:
> On 08/11/2019 10.22, Kashyap Chamarthy wrote:
>> This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
>> given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
>>
>
> Hi Kashyap,
>
> first thanks for writing up this article!
Taylor Simpson writes:
> Signed-off-by: Taylor Simpson
> ---
> tests/tcg/multiarch/float_helpers.c | 13 -
> tests/tcg/multiarch/linux-test.c| 2 +-
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/multiarch/float_helpers.c
> b/tests/tcg/multiar
> diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h
> index 5ecd3ba6ed24..d82484ecf669 100644
> --- a/include/hw/ppc/pnv.h
> +++ b/include/hw/ppc/pnv.h
> @@ -87,9 +87,9 @@ typedef struct Pnv8Chip {
> typedef struct Pnv9Chip {
> /*< private >*/
> PnvChip parent_obj;
> +Pnv
> diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> index 55eee95104da..fce6d8d9b31b 100644
> --- a/include/hw/ppc/pnv_core.h
> +++ b/include/hw/ppc/pnv_core.h
> @@ -36,11 +36,11 @@ typedef struct PnvChip PnvChip;
> typedef struct PnvCore {
> /*< private >*/
> CPUCore
Thomas Huth writes:
> On 08/11/2019 10.22, Kashyap Chamarthy wrote:
>> This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
>> given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
>>
>
> Hi Kashyap,
>
> first thanks for writing up this article! It's a really ni
Add ioctls for all RTC features that are currently supported in linux kernel.
This series covers following 22 iocts:
* RTC_AIE_ON
* RTC_AIE_OFF
* RTC_UIE_ON
* RTC_UIE_OFF
* RTC_PIE_ON
* RTC_PIE_OFF
* RTC_WIE_ON
* RTC_WIE_OFF
* RTC_ALM_SET
* RTC_ALM_READ
RTC_VL_READ - Read voltage low detection information
Read the voltage low for RTCs that support voltage low.
The third ioctl's' argument points to an int in which
the voltage low is returned.
RTC_VL_CLR - Clear voltage low information
Clear the information about voltage low for R
On Fri, Nov 15, 2019 at 01:08:53PM +0100, Thomas Huth wrote:
> On 08/11/2019 10.22, Kashyap Chamarthy wrote:
> > This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
> > given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
> >
>
> Hi Kashyap,
>
> first thanks fo
This patch implements functionalities of following ioctls:
RTC_PLL_GET - Get PLL correction
Read the PLL correction for RTCs that support PLL. The PLL correction
is returned in the following structure:
struct rtc_pll_info {
int pll_ctrl;/* placeholder for fanc
This patch implements functionalities of following ioctls:
RTC_WKALM_SET, RTC_WKALM_GET - Get/Set wakeup alarm
Some RTCs support a more powerful alarm interface, using these
ioctls to read or write the RTC's alarm time (respectively)
with this structure:
struct rtc_wkalrm {
This patch implements functionalities of following ioctls:
RTC_AIE_ON, RTC_AIE_OFF - Alarm interrupt enable on/off
Enable or disable the alarm interrupt, for RTCs that support
alarms. The third ioctl's argument is ignored.
RTC_UIE_ON, RTC_UIE_OFF - Update interrupt enable on/off
En
This patch implements functionalities of following ioctls:
RTC_IRQP_READ, RTC_IRQP_SET - Read/Set IRQ rate
Read and set the frequency for periodic interrupts, for RTCs
that support periodic interrupts. The periodic interrupt must
be separately enabled or disabled using the RTC_PIE_ON
This patch implements functionalities of following ioctls:
RTC_RD_TIME - Read RTC time
Returns this RTC's time in the following structure:
struct rtc_time {
int tm_sec;
int tm_min;
int tm_hour;
int tm_mday;
int tm_mon;
On Fri, 15 Nov 2019 at 04:41, Palmer Dabbelt wrote:
>
> The following changes since commit aa464db69b40b4b695be31085e6d2f1e90956c89:
>
> Update version for v4.2.0-rc1 release (2019-11-12 18:40:02 +)
>
> are available in the Git repository at:
>
> g...@github.com:palmer-dabbelt/qemu.git tag
On Fri, Nov 15, 2019 at 01:08:53PM +0100, Thomas Huth wrote:
> On 08/11/2019 10.22, Kashyap Chamarthy wrote:
> > This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
> > given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
> >
>
> Hi Kashyap,
>
> first thanks fo
On 15/11/19 13:37, Kashyap Chamarthy wrote:
>> Opinions? Ideas?
> Another _potential_ venue: Given the topic is kernel space-related, it
> is likely to fit in with the LWN audience. LWN itself says they
> generally look for kernel-related articles. Although, I'm aware that
> there's already a few
On Fri, 15 Nov 2019 13:24:50 +0100
Cédric Le Goater wrote:
> > diff --git a/include/hw/ppc/pnv_core.h b/include/hw/ppc/pnv_core.h
> > index 55eee95104da..fce6d8d9b31b 100644
> > --- a/include/hw/ppc/pnv_core.h
> > +++ b/include/hw/ppc/pnv_core.h
> > @@ -36,11 +36,11 @@ typedef struct PnvChip PnvC
On 11/08/19 10:22, Kashyap Chamarthy wrote:
> This blog post summarizes the talk "Micro-Optimizing KVM VM-Exits"[1],
> given by Andrea Arcangeli at the recently concluded KVM Forum 2019.
>
> [1]
> https://kvmforum2019.sched.com/event/Tmwr/micro-optimizing-kvm-vm-exits-andrea-arcangeli-red-hat-inc
On Fri, 15 Nov 2019 13:25:01 +0100
Cédric Le Goater wrote:
> > diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h
> > index 5ecd3ba6ed24..d82484ecf669 100644
> > --- a/include/hw/ppc/pnv.h
> > +++ b/include/hw/ppc/pnv.h
> > @@ -87,9 +87,9 @@ typedef struct Pnv8Chip {
> > typedef struct Pnv
This patch adds thread safety to the qemu_logfile handle. This now
allows changing the logfile while logging is active, and also solves
the issue of a seg fault while changing the logfile.
This patch adds use of RCU for handling the swap out of the
old qemu_logfile file descriptor.
Also added
After freeing the logfilename, we set logfilename to NULL, in case of an
error which returns without setting logfilename.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
v2
- moved this change to the beginning of the patch series.
---
v1
- This is new in the patch v1.
---
util/
Also added some explanation of the reasoning behind the branches.
Signed-off-by: Robert Foley
---
v2
- This is new in patch v2.
---
util/log.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/util/log.c b/util/log.c
index 4316fe74ee..417d16ec66 10064
This now allows changing the logfile while logging is active,
and also solves the issue of a seg fault while changing the logfile.
Any read access to the qemu_logfile handle will use
the rcu_read_lock()/unlock() around the use of the handle.
To fetch the handle we will use atomic_rcu_read().
We al
Also added qemu_logfile_init() for initializing the logfile mutex.
Signed-off-by: Robert Foley
---
v2
- In qemu_set_log() moved location of mutex lock/unlock
due to cleanup changes.
---
v1
- changed qemu_logfile_init() to use __constructor__.
---
util/log.c | 14 ++
1
qemu_log_lock() now returns a handle and qemu_log_unlock() receives a
handle to unlock. This allows for changing the handle during logging
and ensures the lock() and unlock() are for the same file.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
v1
- Moved this up in the patch sequ
Coverity reports, in sve_zcr_get_valid_len,
"Subtract operation overflows on operands
arm_cpu_vq_map_next_smaller(cpu, start_vq + 1U) and 1U"
First, fix the aarch32 stub version to not return 0, but to
simply assert unreachable. Because that nonsense return value
does exactly what Coverity repor
One test ensures that the logfile handle is still valid even if
the logfile is changed during logging.
The other test validates that the logfile handle remains valid under
the logfile lock even if the logfile is closed.
Signed-off-by: Robert Foley
Reviewed-by: Alex Bennée
---
v1
- Changes f
On Fri, 15 Nov 2019 02:10:50 +0100
Christian Schoenebeck wrote:
> I'm currently reading up on how client requests (T messages) are currently
> dispatched in general by 9pfs, to understand where potential inefficiencies
> are that I am encountering.
>
> I mean 9pfs is pretty fast on raw I/O (re
On Fri, 15 Nov 2019 13:16:22 +0100
Cédric Le Goater wrote:
> On 15/11/2019 12:53, Greg Kurz wrote:
> > There's a recurring pattern in the code where a const link is added to a
> > newly instanciated object and the link is then used in the object's realize
> > function to keep a pointer to the QOM
On Tue 05 Nov 2019 01:47:58 PM CET, Max Reitz wrote:
>> @@ -1347,6 +1347,12 @@ static int coroutine_fn
>> qcow2_do_open(BlockDriverState *bs, QDict *options,
>> s->subcluster_size = s->cluster_size / s->subclusters_per_cluster;
>> s->subcluster_bits = ctz32(s->subcluster_size);
>>
>> +
> You can now access the latest QEMU HTML documentation built from
https://wiki.qemu.org/docs/qemu-doc.html
This is a welcome start. Could we add version support to the URL?
What I mean is add the version number to the path of the URL.
Like this:
https://wiki.qemu.org/docs/4.2/qemu-doc.html
Th
On Tue, Nov 12, 2019 at 11:48:11AM +0100, Cornelia Huck wrote:
> Add 5.0 machine types for arm/i440fx/q35/s390x/spapr.
>
> For i440fx and q35, unversioned cpu models are still translated
> to -v1; I'll leave changing this (if desired) to the respective
> maintainers.
>
> Signed-off-by: Cornelia H
Without volatile, clang turns that statement into a call to abort.
It is discussed here (Chris Lattner's blog from 2011)
http://blog.llvm.org/2011/05/what-every-c-programmer-should-know.html
Here is the relevant paragraph
If you're using an LLVM-based compiler, you can dereference a "volatile" nu
If main job coroutine called job_yield (while some background process
is in progress), we should give it a chance to call job_pause_point().
It will be used in backup, when moved on async block-copy.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
job.c | 1 +
1 file changed, 1 insertion(+)
dif
In block_copy_do_copy we fallback to read+write if copy_range failed.
In this case copy_size is larger than defined for buffered IO, and
there is corresponding commit. Still, backup copies data cluster by
cluster, and most of requests are limited to one cluster anyway, so the
only source of this on
Hi all!
These series does the following things:
1. bring block_status to block-copy, for efficient chunk sizes and
handling ZERO clusters. (mirror does it)
2. bring aio-task-pool to block-copy, for parallel copying loop
iteration. (mirror does it its own way)
4. add speed limit and cancelling pos
They will be used for backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-copy.h | 5 +
block/block-copy.c | 9 +++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
index 407de7e520..
We are going to use async block-copy call in backup, so we'll need to
passthrough setting backup speed to block-copy call.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/blockjob_int.h | 2 ++
blockjob.c | 6 ++
2 files changed, 8 insertions(+)
diff --git a/
Comment "Called only on full-dirty region" without corresponding
assertion is a very unsafe thing. Adding assertion means call
bdrv_dirty_bitmap_next_zero twice. Instead, let's move
bdrv_dirty_bitmap_next_zero call to block_copy_task_create. It also
allows to drop cur_bytes variable which partly du
Split block_copy_find_inflight_req to be used in seprate.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/block/block-copy.c b/block/block-copy.c
index 74295d93d5..94e7e855ef
We are going to use aio-task-pool API and extend in-flight request
structure to be a successor of AioTask, so rename things appropriately.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 82 ++
1 file changed, 40 insertions(+), 42
Simple movement without any change. It's needed for the following
patch, as this function will need to use some staff which is currently
below it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 64 +++---
1 file changed, 32 insertions
This brings async request handling and block-status driven chunk sizes
to backup out of the box, which improves backup performance.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block-core.json | 9 +-
include/block/block_int.h | 7 +
block/backup.c | 159 ++
We are going to use aio-task-pool API, so tasks will be handled in
parallel. We need therefore separate allocated task on each iteration.
Introduce this logic now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 18 +++---
1 file changed, 11 insertions(+), 7 dele
offset/bytes pair is more usual naming in block layer, let's use it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-copy.h | 2 +-
block/block-copy.c | 80 +++---
2 files changed, 41 insertions(+), 41 deletions(-)
diff --git a/includ
Add function to cancel running async block-copy call. It will be used
in backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-copy.h | 7 +++
block/block-copy.c | 20 ++--
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/
We are going to directly use one async block-copy operation for backup
job, so we need rate limitator.
We want to maintain current backup behavior: only background copying is
limited and copy-before-write operations only participate in limit
calculation. Therefore we need one rate limitator for bl
Hide structure definitions and add explicit API instead, to keep an
eye on the scope of the shared fields.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-copy.h | 57 +++--
block/backup-top.c | 6 ++--
block/backup.c | 27
We'll need async block-copy invocation to use in backup directly.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-copy.h | 13 +++
block/block-copy.c | 48 +++---
2 files changed, 58 insertions(+), 3 deletions(-)
diff --git a/i
We are going to use aio-task-pool API, so we'll need state pointer in
BlockCopyTask anyway. Add it now and use where possible.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/block-copy.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/block/b
On Fri, 8 Nov 2019 at 11:39, Stefan Hajnoczi wrote:
> You are right:
> * The hidden documents are included in the navigation bar (different
> from the table of contents).
> * The search index (which install-doc omits!) includes content from
> the hidden documents.
What is install-doc failing to
1 - 100 of 246 matches
Mail list logo
