Taylor Simpson <tsimp...@quicinc.com> writes:
> Signed-off-by: Taylor Simpson <tsimp...@quicinc.com>
> ---
> tests/tcg/multiarch/float_helpers.c | 13 ++++++++++++-
> tests/tcg/multiarch/linux-test.c | 2 +-
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/multiarch/float_helpers.c
> b/tests/tcg/multiarch/float_helpers.c
> index 8ee7903..437247c 100644
> --- a/tests/tcg/multiarch/float_helpers.c
> +++ b/tests/tcg/multiarch/float_helpers.c
<snip>
> diff --git a/tests/tcg/multiarch/linux-test.c
> b/tests/tcg/multiarch/linux-test.c
> index 673d7c8..edfc02c 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -485,7 +485,7 @@ static void test_signal(void)
> act.sa_flags = SA_SIGINFO;
> chk_error(sigaction(SIGSEGV, &act, NULL));
> if (setjmp(jmp_env) == 0) {
> - *(uint8_t *)0 = 0;
> + *(volatile uint8_t *)0 = 0;
This looks suspicious - volatile is almost never the answer to a
question. What are we trying to achieve here?
> }
>
> act.sa_handler = SIG_DFL;
--
Alex Bennée
