Re: [PULL 0/4] Trivial branch patches

2019-11-06 Thread Greg Kurz
On Tue, 5 Nov 2019 16:56:11 +0100 Laurent Vivier wrote: > Greg, Dave, > > could you fix that? > > Thanks, > Laurent > > Le 05/11/2019 à 16:48, no-re...@patchew.org a écrit : > > Patchew URL: > > https://patchew.org/QEMU/20191105144247.10301-1-laur...@vivier.eu/ > > > > > > > > Hi, > > > >

RE: [RFC v2 15/22] intel_iommu: bind/unbind guest page table to host

2019-11-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Tuesday, November 5, 2019 4:26 AM > To: Liu, Yi L > Subject: Re: [RFC v2 15/22] intel_iommu: bind/unbind guest page table to host > > On Thu, Oct 24, 2019 at 08:34:36AM -0400, Liu Yi L wrote: > > This patch captures the guest PASID table entry m

RE: [RFC v2 12/22] intel_iommu: add present bit check for pasid table entries

2019-11-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Sunday, November 3, 2019 12:21 AM > To: Liu, Yi L > Subject: Re: [RFC v2 12/22] intel_iommu: add present bit check for pasid table > entries > > On Thu, Oct 24, 2019 at 08:34:33AM -0400, Liu Yi L wrote: > > The present bit check for pasid entry

RE: [RFC v2 07/22] hw/pci: introduce pci_device_iommu_context()

2019-11-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Saturday, November 2, 2019 2:10 AM > To: Liu, Yi L > Subject: Re: [RFC v2 07/22] hw/pci: introduce pci_device_iommu_context() > > On Thu, Oct 24, 2019 at 08:34:28AM -0400, Liu Yi L wrote: > > This patch adds pci_device_iommu_context() to get an

RE: [RFC v2 06/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2019-11-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Saturday, November 2, 2019 2:09 AM > To: Liu, Yi L > Subject: Re: [RFC v2 06/22] hw/pci: modify pci_setup_iommu() to set > PCIIOMMUOps > > On Thu, Oct 24, 2019 at 08:34:27AM -0400, Liu Yi L wrote: > > This patch modifies pci_setup_iommu() to se

RE: [RFC v2 06/22] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2019-11-06 Thread Liu, Yi L
> From: David Gibson > Sent: Monday, October 28, 2019 1:44 AM > To: Liu, Yi L > Subject: Re: [RFC v2 06/22] hw/pci: modify pci_setup_iommu() to set > PCIIOMMUOps > > On Thu, Oct 24, 2019 at 08:34:27AM -0400, Liu Yi L wrote: > > This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of

RE: [RFC v2 07/22] hw/pci: introduce pci_device_iommu_context()

2019-11-06 Thread Liu, Yi L
> From: David Gibson > Sent: Tuesday, October 29, 2019 7:51 PM > To: Liu, Yi L > Subject: Re: [RFC v2 07/22] hw/pci: introduce pci_device_iommu_context() > > On Thu, Oct 24, 2019 at 08:34:28AM -0400, Liu Yi L wrote: > > This patch adds pci_device_iommu_context() to get an iommu_context for > > a

[PULL 0/1] Audio 20191106 patches

2019-11-06 Thread Gerd Hoffmann
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-201

[PULL 1/1] audio: add -audiodev pa,in|out.latency= to documentation

2019-11-06 Thread Gerd Hoffmann
From: Stefan Hajnoczi The "latency" parameter wasn't covered by the documentation. Signed-off-by: Stefan Hajnoczi Reviewed-by: Marc-André Lureau Message-id: 20191004125641.24383-1-stefa...@redhat.com Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 5 + 1 file changed, 5 insertions(+)

Re: [PATCH] vhost-user: Refractor vhost_user_set_mem_table Functions

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1572477125-25344-2-git-send-email-raphael.norw...@nutanix.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] vhost-user: Refractor vhost_user_set_mem_table Functions Type: series Message-

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2019 at 11:02:44AM +0100, Dietmar Maurer wrote: > Example: Backup from ceph disk (rbd_cache=false) to local disk: > > backup_calculate_cluster_size returns 64K (correct for my local .raw image) > > Then the backup job starts to read 64K blocks from ceph. > > But ceph always reads

[PATCH v7 0/3] RTC support for QEMU RISC-V virt machine

2019-11-06 Thread Anup Patel
This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is already available in Linux so we just need to enable it in Kco

[PATCH v7 3/3] MAINTAINERS: Add maintainer entry for Goldfish RTC

2019-11-06 Thread Anup Patel
Add myself as Goldfish RTC maintainer until someone else is willing to maintain it. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2a68555ae..492c0d1baa 100644 --- a/MAINTAINERS

[PATCH v7 2/3] riscv: virt: Use Goldfish RTC device

2019-11-06 Thread Anup Patel
We extend QEMU RISC-V virt machine by adding Goldfish RTC device to it. This will allow Guest Linux to sync it's local date/time with Host date/time via RTC device. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- hw/riscv/Kconfi

[PATCH v7 1/3] hw: rtc: Add Goldfish RTC device

2019-11-06 Thread Anup Patel
This patch adds model for Google Goldfish virtual platform RTC device. We will be adding Goldfish RTC device to the QEMU RISC-V virt machine for providing real date-time to Guest Linux. The corresponding Linux driver for Goldfish RTC device is already available in upstream Linux. For now, VM migr

Re: [PATCH v14 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-11-06 Thread Tao Xu
Ping for comments:) On 10/28/2019 3:52 PM, Xu, Tao3 wrote: This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related t

Re: guest / host buffer sharing ...

2019-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2019 at 11:54:56AM +0100, Gerd Hoffmann wrote: > The issue of sharing buffers between guests and hosts keeps poping > up again and again in different contexts. Most recently here: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg656685.html > > So, I'm grabbing the recip

Re: [PATCH v2] virtio: notify virtqueue via host notifier when available

2019-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2019 at 03:09:46PM +0100, Stefan Hajnoczi wrote: > Host notifiers are used in several cases: > 1. Traditional ioeventfd where virtqueue notifications are handled in >the main loop thread. > 2. IOThreads (aio_handle_output) where virtqueue notifications are >handled in an IOT

Re: [PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised

2019-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2019 at 09:22:17PM +0300, Evgeny Yakovlev wrote: > Virtio spec 1.1 (and earlier), 5.2.5.2 Driver Requirements: Device > Initialization: > > "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if > they offer VIRTIO_BLK_F_CONFIG_WCE" > > Currently F_CONFIG_WCE and F_

Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-06 Thread Stefan Hajnoczi
On Wed, Nov 06, 2019 at 07:46:31AM +, Denis Plotnikov wrote: > > On 05.11.2019 23:56, Michael S. Tsirkin wrote: > > On Tue, Nov 05, 2019 at 07:11:02PM +0300, Denis Plotnikov wrote: > >> The patch protects from creating illegal virtio device configuration > >> via direct virtqueue size property

Re: [PULL 0/1] Audio 20191106 patches

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191106082604.9548-1-kra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2019 at 03:56:43PM -0500, Michael S. Tsirkin wrote: > On Tue, Nov 05, 2019 at 07:11:02PM +0300, Denis Plotnikov wrote: > > @@ -47,6 +48,15 @@ static void virtio_scsi_pci_realize(VirtIOPCIProxy > > *vpci_dev, Error **errp) > > VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(vdev); >

Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-06 Thread Stefan Hajnoczi
On Wed, Nov 06, 2019 at 07:46:31AM +, Denis Plotnikov wrote: > Could I ask why one want to the check > whether accessing through the modern interface and how it could be checked? BTW the VERSION_1 check I mentioned won't work in .realize() since feature negotiation happens later at guest run-

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: > It tests proper queue size settings for all available machine types. > > Signed-off-by: Denis Plotnikov > --- > tests/qemu-iotests/267 | 154 + > tests/qemu-iotests/267.out | 1 + > tests

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Max Reitz
On 06.11.19 09:32, Stefan Hajnoczi wrote: > On Tue, Nov 05, 2019 at 11:02:44AM +0100, Dietmar Maurer wrote: >> Example: Backup from ceph disk (rbd_cache=false) to local disk: >> >> backup_calculate_cluster_size returns 64K (correct for my local .raw image) >> >> Then the backup job starts to read 6

RE: [RFC v2 03/22] intel_iommu: modify x-scalable-mode to be string option

2019-11-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Tuesday, November 5, 2019 8:50 PM > To: Liu, Yi L > Subject: Re: [RFC v2 03/22] intel_iommu: modify x-scalable-mode to be string > option > > On Tue, Nov 05, 2019 at 09:14:08AM +, Liu, Yi L wrote: > > > Something like: > > > > > > - s->sc

Re: guest / host buffer sharing ...

2019-11-06 Thread Gerd Hoffmann
Hi, > > Reason is: Meanwhile I'm wondering whenever "just use virtio-gpu > > resources" is really a good answer for all the different use cases > > we have collected over time. Maybe it is better to have a dedicated > > buffer sharing virtio device? Here is the rough idea: > > My concern is

Re: Sparc Solaris 10

2019-11-06 Thread Zainuddin AR
Thank you very much for the reply and information. Will check it out. On Mon, Nov 4, 2019, 17:17 Artyom Tarasenko wrote: > On Sun, Nov 3, 2019 at 10:01 PM Mark Cave-Ayland > wrote: > > > > On 02/11/2019 19:56, Philippe Mathieu-Daudé wrote: > > > > > Cc'ing the SPARC maintainers. > > > > > > On

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-06 Thread Max Reitz
On 06.11.19 10:24, Stefan Hajnoczi wrote: > On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: >> It tests proper queue size settings for all available machine types. >> >> Signed-off-by: Denis Plotnikov >> --- >> tests/qemu-iotests/267 | 154

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-06 Thread Denis Lunev
On 11/5/19 9:51 PM, Michael S. Tsirkin wrote: > On Tue, Nov 05, 2019 at 07:11:03PM +0300, Denis Plotnikov wrote: >> seg_max has a restriction to be less or equal to virtqueue size >> according to Virtio 1.0 specification >> >> Although seg_max can't be set directly, it's worth to express this >> de

Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-11-06 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > > Reason is: Meanwhile I'm wondering whenever "just use virtio-gpu > > > resources" is really a good answer for all the different use cases > > > we have collected over time. Maybe it is better to have a dedicated > > > buffer sharing virt

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Alexander Popov
On 27.07.2019 00:09, Alexander Popov wrote: > On 26.07.2019 2:25:03 GMT+02:00, John Snow wrote: >> Oh, this is fun. > ... >> I can worry about a proper fix for 4.2+. > > Hello John, > > Thanks for your letter. > > I double-checked the git history and mailing list, I'm still sure > that my fix for

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Dietmar Maurer
> The thing is, it just seems unnecessary to me to take the source cluster > size into account in general. It seems weird that a medium only allows > 4 MB reads, because, well, guests aren’t going to take that into account. Maybe it is strange, but it is quite obvious that there is an optimal clu

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Wolfgang Bumiller
On Wed, Nov 06, 2019 at 10:37:04AM +0100, Max Reitz wrote: > On 06.11.19 09:32, Stefan Hajnoczi wrote: > > On Tue, Nov 05, 2019 at 11:02:44AM +0100, Dietmar Maurer wrote: > >> Example: Backup from ceph disk (rbd_cache=false) to local disk: > >> > >> backup_calculate_cluster_size returns 64K (correc

Re: [PULL 0/1] Require Python >= 3.5 to build QEMU

2019-11-06 Thread Daniel P . Berrangé
On Tue, Nov 05, 2019 at 08:25:03PM +, Alex Bennée wrote: > > Eduardo Habkost writes: > > > On Thu, Oct 31, 2019 at 08:12:01AM +, Peter Maydell wrote: > >> On Fri, 25 Oct 2019 at 21:34, Eduardo Habkost wrote: > >> > > >> > The following changes since commit > >> > 03bf012e523ecdf047ac56

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Max Reitz
On 06.11.19 11:18, Dietmar Maurer wrote: >> The thing is, it just seems unnecessary to me to take the source cluster >> size into account in general. It seems weird that a medium only allows >> 4 MB reads, because, well, guests aren’t going to take that into account. > > Maybe it is strange, but

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Max Reitz
On 06.11.19 11:34, Wolfgang Bumiller wrote: > On Wed, Nov 06, 2019 at 10:37:04AM +0100, Max Reitz wrote: >> On 06.11.19 09:32, Stefan Hajnoczi wrote: >>> On Tue, Nov 05, 2019 at 11:02:44AM +0100, Dietmar Maurer wrote: Example: Backup from ceph disk (rbd_cache=false) to local disk: ba

RE: [RFC v2 08/22] intel_iommu: provide get_iommu_context() callback

2019-11-06 Thread Liu, Yi L
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, November 1, 2019 10:55 PM > To: Liu, Yi L > Subject: Re: [RFC v2 08/22] intel_iommu: provide get_iommu_context() callback > > On Thu, Oct 24, 2019 at 08:34:29AM -0400, Liu Yi L wrote: > > This patch adds get_iommu_context() callback to r

Re: [PATCH v17 4/7] target/ppc: Build rtas error log upon an MCE

2019-11-06 Thread Ganesh
On 11/4/19 9:40 PM, David Gibson wrote: On Thu, Oct 24, 2019 at 01:13:04PM +0530, Ganesh Goudar wrote: From: Aravinda Prasad Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas

RE: [RFC v2 05/22] vfio/common: add iommu_ctx_notifier in container

2019-11-06 Thread Liu, Yi L
> From: Peter Xu > Sent: Friday, November 1, 2019 10:59 PM > To: Liu, Yi L > Subject: Re: [RFC v2 05/22] vfio/common: add iommu_ctx_notifier in container > > On Thu, Oct 24, 2019 at 08:34:26AM -0400, Liu Yi L wrote: > > [...] > > > +typedef struct VFIOIOMMUContext { > > +VFIOContainer *cont

Re: [SeaBIOS] 1.13 release?

2019-11-06 Thread Gerd Hoffmann
On Wed, Oct 16, 2019 at 12:44:12PM +0200, Gerd Hoffmann wrote: > Hi, > > Almost a year since 1.12.0 was tagged (Nov 17th to be exact), > time to plan the 1.13 release I think ... > > How about freeze in a week or two, release by mid-november? > > Pending stuff I'm aware of is the disk geometry

Re: [PULL 0/1] Require Python >= 3.5 to build QEMU

2019-11-06 Thread Peter Maydell
On Wed, 6 Nov 2019 at 10:36, Daniel P. Berrangé wrote: > At what point do we declare that NetBSD CI is broken and is no longer > considered a supported platform from POV of blocking the merging of > PULL requests ? It has been preventing the dropping of python2 for > quite a while now. It isn't th

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Dietmar Maurer
> And if it issues a smaller request, there is no way for a guest device > to tell it “OK, here’s your data, but note we have a whole 4 MB chunk > around it, maybe you’d like to take that as well...?” > > I understand wanting to increase the backup buffer size, but I don’t > quite understand why w

RE: [RFC v2 04/22] hw/iommu: introduce IOMMUContext

2019-11-06 Thread Liu, Yi L
> From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Monday, October 28, 2019 1:39 AM > To: Liu, Yi L > Subject: Re: [RFC v2 04/22] hw/iommu: introduce IOMMUContext > > On Thu, Oct 24, 2019 at 08:34:25AM -0400, Liu Yi L wrote: > > From: Peter Xu > > > > This patch adds IOMMUContext

Re: [PATCH for-4.2 0/2] qcow2: Fix QCOW2_COMPRESSED_SECTOR_MASK

2019-11-06 Thread Max Reitz
On 28.10.19 17:18, Max Reitz wrote: > This fixes a bug reported on > https://bugs.launchpad.net/qemu/+bug/185. The problem is that > QCOW2_COMPRESSED_SECTOR_MASK is a 32-bit mask when it really needs to be > a 64-bit mask. > > The launchpad report mentions only problems with qemu-img check on

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Max Reitz
On 06.11.19 12:18, Dietmar Maurer wrote: >> And if it issues a smaller request, there is no way for a guest device >> to tell it “OK, here’s your data, but note we have a whole 4 MB chunk >> around it, maybe you’d like to take that as well...?” >> >> I understand wanting to increase the backup buff

[PATCH v2 0/2] dp8393x: fix problems detected with Quadra 800 machine

2019-11-06 Thread Laurent Vivier
This series starts with a cleanup of the DMA buffer, moving it from the stack to the state structure. The following patch allows to negociate the IP address with the DHCP server. v2: remove PATCH 3 (will be reworked later) modifies PATCH 2 to adjust the offset of the field, not the size,

[PATCH v2 2/2] dp8393x: fix dp8393x_receive()

2019-11-06 Thread Laurent Vivier
RXpkt.in_use is always 16 bit wide, but when the bus access mode is 32bit and the endianness is big, we must access the second word and not the first. This patch adjusts the offset according to the size and endianness. This fixes DHCP for Q800 guest. Fixes: be9208419865 ("dp8393x: manage big endi

[PATCH v2 1/2] dp8393x: put the DMA buffer in the state structure

2019-11-06 Thread Laurent Vivier
Move it from the stack. It's only 24 bytes, and this simplifies the dp8393x_get()/ dp8393x_put() interface. Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- hw/net/dp8393x.c | 105 ++- 1 file changed, 50 insertions(+), 55 deletions(-)

[PATCH v3 02/12] tests/tcg/multiarch/linux-test: Fix error check for shmat

2019-11-06 Thread Richard Henderson
The error indicator for this syscall is -1, not 0. Fixes: e374bfa35bfb ("shm tests - disabled clone test") Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191025113921.9412-3-richard.hender...@linaro.org> Signed-off-by: Laurent Viv

[PATCH v3 01/12] scripts/qemu-binfmt-conf: Update for sparc64

2019-11-06 Thread Richard Henderson
Also note that we were missing the qemu_target_list entry for plain sparc; fix that at the same time. Reviewed-by: Laurent Vivier Tested-by: Laurent Vivier Signed-off-by: Richard Henderson Message-Id: <20191025113921.9412-2-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- scrip

[PATCH v3 00/12] linux-user sparc fixes

2019-11-06 Thread Richard Henderson
Changes in v3: * Fix checkpatch errors in patches 5 and 8. There's lots more style errors left to clean up in these files, but this is enough for now. r~ Richard Henderson (12): scripts/qemu-binfmt-conf: Update for sparc64 tests/tcg/multiarch/linux-test: Fix error check for shmat

[PATCH v3 05/12] linux-user/sparc: Begin using WREG constants in sparc/signal.c

2019-11-06 Thread Richard Henderson
This is non-obvious because the UREG constants are in fact wrong. s/UREG_I/WREG_O/g s/UREG_O/WREG_I/g s/UREG_L/WREG_L/g These substitutions have identical integer values. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20191025113921.9412-6-richard.hender...@linaro.or

[PATCH v3 03/12] target/sparc: Define an enumeration for accessing env->regwptr

2019-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson Message-Id: <20191025113921.9412-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- target/sparc/cpu.h | 33 + 1 file changed, 33 insertions(+) diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h index 778aa8e073..

Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 07:46:31AM +, Denis Plotnikov wrote: > > On 05.11.2019 23:56, Michael S. Tsirkin wrote: > > On Tue, Nov 05, 2019 at 07:11:02PM +0300, Denis Plotnikov wrote: > >> The patch protects from creating illegal virtio device configuration > >> via direct virtqueue size property

[PATCH v3 06/12] linux-user/sparc: Use WREG_SP constant in sparc/signal.c

2019-11-06 Thread Richard Henderson
s/UREG_FP/WREG_SP/g This is non-obvious because the UREG_FP constant is fact wrong. However, the previous search-and-replace patch made it clear that UREG_FP expands to WREG_O6, and we can see from the enumeration in target/sparc/cpu.h that WREG_O6 is in fact WREG_SP, the stack pointer. The UREG_

[PATCH v3 10/12] linux-user: Introduce cpu_clone_regs_parent

2019-11-06 Thread Richard Henderson
We will need a target-specific hook for adjusting registers in the parent during clone. Add an empty inline function for each target, and invoke it from the proper places. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <201910251139

[PATCH v3 04/12] linux-user/sparc: Use WREG constants in sparc/target_cpu.h

2019-11-06 Thread Richard Henderson
This fixes a naming bug wherein we used "UREG_FP" to access the stack pointer. OTOH, the "UREG_FP" constant was also defined incorrectly such that it *did* reference the stack pointer. Note that the kernel legitimately uses the name "FP", because it utilizes the rolled stack window in processing

[PATCH v3 08/12] linux-user/sparc64: Fix target_signal_frame

2019-11-06 Thread Richard Henderson
Instructions are always 4 bytes; use uint32_t not abi_ulong. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20191025113921.9412-9-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH v3 09/12] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child

2019-11-06 Thread Richard Henderson
We will need a target-specific hook for adjusting registers in the parent during clone. To avoid confusion, rename the one we have to make it clear it affects the child. At the same time, pass in the flags from the clone syscall. We will need them for correct behaviour for Sparc. Reviewed-by: La

[PATCH v3 11/12] linux-user/sparc: Fix cpu_clone_regs_*

2019-11-06 Thread Richard Henderson
We failed to set the secondary return value in %o1 we failed to advance the PC past the syscall, we failed to adjust regwptr into the new structure, we stored the stack pointer into the wrong register. Signed-off-by: Richard Henderson Message-Id: <20191025113921.9412-12-richard.hender...@linaro.o

[PATCH v3 07/12] linux-user/sparc: Fix WREG usage in setup_frame

2019-11-06 Thread Richard Henderson
Use WREG_I0 not WREG_O0 in order to properly save the "ins". The "outs" were saved separately in setup___siginfo. Signed-off-by: Richard Henderson Message-Id: <20191025113921.9412-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 2 +- 1 file changed,

Re: [RESEND PATCH 0/2] PCI DMA alias support

2019-11-06 Thread Michael S. Tsirkin
On Mon, Nov 04, 2019 at 03:03:53PM -0700, Alex Williamson wrote: > On Wed, 23 Oct 2019 16:47:02 -0600 > Alex Williamson wrote: > > > Previous posting: > > https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg06182.html > > > > Rebased (no change) and added Peter's R-b. Please apply for QEMU

[PATCH v3 12/12] linux-user/alpha: Set r20 secondary return value

2019-11-06 Thread Richard Henderson
This value is not, as far as I know, used by any linux software, but it is set by the kernel and is part of the ABI. Signed-off-by: Richard Henderson Reviewed-by: Laurent Vivier Message-Id: <20191025113921.9412-13-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/alpha

Re: [PATCH 1/2] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices

2019-11-06 Thread Michael S. Tsirkin
On Tue, Oct 29, 2019 at 05:38:02PM -0400, Raphael Norwitz wrote: > Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user > backend. Disabling all rings, and resetting all internal state, ready > for the backend to be reinitialized. > > A backend has to report it supports this featu

Re: [PATCH v2] virtio: notify virtqueue via host notifier when available

2019-11-06 Thread Michael S. Tsirkin
On Tue, Nov 05, 2019 at 03:09:46PM +0100, Stefan Hajnoczi wrote: > Host notifiers are used in several cases: > 1. Traditional ioeventfd where virtqueue notifications are handled in >the main loop thread. > 2. IOThreads (aio_handle_output) where virtqueue notifications are >handled in an IOT

Re: guest / host buffer sharing ...

2019-11-06 Thread Stefan Hajnoczi
On Wed, Nov 6, 2019 at 10:51 AM Gerd Hoffmann wrote: > > > Reason is: Meanwhile I'm wondering whenever "just use virtio-gpu > > > resources" is really a good answer for all the different use cases > > > we have collected over time. Maybe it is better to have a dedicated > > > buffer sharing virt

Re: backup_calculate_cluster_size does not consider source

2019-11-06 Thread Max Reitz
On 06.11.19 12:22, Max Reitz wrote: > On 06.11.19 12:18, Dietmar Maurer wrote: >>> And if it issues a smaller request, there is no way for a guest device >>> to tell it “OK, here’s your data, but note we have a whole 4 MB chunk >>> around it, maybe you’d like to take that as well...?” >>> >>> I und

Re: [PATCH v1 1/4] virtio: protect non-modern devices from too big virtqueue size setting

2019-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 10:18:12AM +0100, Stefan Hajnoczi wrote: > On Tue, Nov 05, 2019 at 03:56:43PM -0500, Michael S. Tsirkin wrote: > > On Tue, Nov 05, 2019 at 07:11:02PM +0300, Denis Plotnikov wrote: > > > @@ -47,6 +48,15 @@ static void virtio_scsi_pci_realize(VirtIOPCIProxy > > > *vpci_dev, E

Re: [PATCH v7 2/3] riscv: virt: Use Goldfish RTC device

2019-11-06 Thread Anup Patel
On Wed, Nov 6, 2019 at 2:05 PM Anup Patel wrote: > > We extend QEMU RISC-V virt machine by adding Goldfish RTC device > to it. This will allow Guest Linux to sync it's local date/time > with Host date/time via RTC device. > > Signed-off-by: Anup Patel > Reviewed-by: Palmer Dabbelt > Acked-by: Pa

Re: [PULL 0/1] Require Python >= 3.5 to build QEMU

2019-11-06 Thread Alex Bennée
Peter Maydell writes: > On Wed, 6 Nov 2019 at 10:36, Daniel P. Berrangé wrote: >> At what point do we declare that NetBSD CI is broken and is no longer >> considered a supported platform from POV of blocking the merging of >> PULL requests ? It has been preventing the dropping of python2 for >

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 10:07:02AM +, Denis Lunev wrote: > On 11/5/19 9:51 PM, Michael S. Tsirkin wrote: > > On Tue, Nov 05, 2019 at 07:11:03PM +0300, Denis Plotnikov wrote: > >> seg_max has a restriction to be less or equal to virtqueue size > >> according to Virtio 1.0 specification > >> > >>

Re: [PULL 0/5] Block patches for 4.2-rc0

2019-11-06 Thread Peter Maydell
On Mon, 4 Nov 2019 at 09:03, Max Reitz wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git repository a

[PATCH v8 0/3] RTC support for QEMU RISC-V virt machine

2019-11-06 Thread Anup Patel
This series adds RTC device to QEMU RISC-V virt machine. We have selected Goldfish RTC device model for this. It's a pretty simple synthetic device with few MMIO registers and no dependency external clock. The driver for Goldfish RTC is already available in Linux so we just need to enable it in Kco

[PATCH v8 1/3] hw: rtc: Add Goldfish RTC device

2019-11-06 Thread Anup Patel
This patch adds model for Google Goldfish virtual platform RTC device. We will be adding Goldfish RTC device to the QEMU RISC-V virt machine for providing real date-time to Guest Linux. The corresponding Linux driver for Goldfish RTC device is already available in upstream Linux. For now, VM migr

[PATCH v8 2/3] riscv: virt: Use Goldfish RTC device

2019-11-06 Thread Anup Patel
We extend QEMU RISC-V virt machine by adding Goldfish RTC device to it. This will allow Guest Linux to sync it's local date/time with Host date/time via RTC device. Signed-off-by: Anup Patel Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt Reviewed-by: Alistair Francis --- hw/riscv/Kconfi

[PATCH v8 3/3] MAINTAINERS: Add maintainer entry for Goldfish RTC

2019-11-06 Thread Anup Patel
Add myself as Goldfish RTC maintainer until someone else is willing to maintain it. Signed-off-by: Anup Patel Reviewed-by: Alistair Francis --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2a68555ae..492c0d1baa 100644 --- a/MAINTAINERS

Re: [PATCH] virtio: fix IO request length in virtio SCSI/block #PSBM-78839

2019-11-06 Thread Michael S. Tsirkin
On Thu, Oct 24, 2019 at 11:34:34AM +, Denis Lunev wrote: > On 10/24/19 12:28 AM, Michael S. Tsirkin wrote: > > On Fri, Oct 18, 2019 at 02:55:47PM +0300, Denis Plotnikov wrote: > >> From: "Denis V. Lunev" > >> > >> Linux guests submit IO requests no longer than PAGE_SIZE * max_seg > >> field re

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Michael S. Tsirkin
On Thu, Jul 25, 2019 at 08:25:03PM -0400, John Snow wrote: > > > On 7/5/19 10:07 AM, Alexander Popov wrote: > > This assertion was introduced in the commit a718978ed58a in July 2015. > > It implies that the size of successful DMA transfers handled in > > ide_dma_cb() should be multiple of 512 (th

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2019 at 01:17:51PM +0300, Alexander Popov wrote: > On 27.07.2019 00:09, Alexander Popov wrote: > > On 26.07.2019 2:25:03 GMT+02:00, John Snow wrote: > >> Oh, this is fun. > > ... > >> I can worry about a proper fix for 4.2+. > > > > Hello John, > > > > Thanks for your letter. > > >

Re: [RFC PATCH 01/18] qemu-storage-daemon: Add barebone tool

2019-11-06 Thread Max Reitz
On 17.10.19 15:01, Kevin Wolf wrote: > This adds a new binary qemu-storage-daemon that doesn't yet do more than > some typical initialisation for tools and parsing the basic command > options --version, --help and --trace. > > Signed-off-by: Kevin Wolf > --- > configure | 2 +- > q

RE: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid alloc/free

2019-11-06 Thread Liu, Yi L
> From: David Gibson [mailto:da...@gibson.dropbear.id.au] > Sent: Tuesday, October 29, 2019 8:16 PM > To: Liu, Yi L > Subject: Re: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid > alloc/free > > On Thu, Oct 24, 2019 at 08:34:30AM -0400, Liu Yi L wrote: > > This patch adds pasid al

Re: [PATCH v2 2/4] Memory: Enable writeback for given memory region

2019-11-06 Thread Richard Henderson
On 11/6/19 12:40 AM, Beata Michalska wrote: > +void qemu_ram_writeback(RAMBlock *block, ram_addr_t start, ram_addr_t length) > +{ > +void *addr = ramblock_ptr(block, start); > + > +/* > + * The requested range might spread up to the very end of the block > + */ > +if ((start + l

RE: [RFC v2 14/22] vfio/pci: add iommu_context notifier for pasid bind/unbind

2019-11-06 Thread Liu, Yi L
> From: David Gibson > Sent: Tuesday, November 5, 2019 12:02 AM > To: Liu, Yi L > Subject: Re: [RFC v2 14/22] vfio/pci: add iommu_context notifier for pasid > bind/unbind > > On Thu, Oct 24, 2019 at 08:34:35AM -0400, Liu Yi L wrote: > > This patch adds notifier for pasid bind/unbind. VFIO registe

[PULL 0/1] Seabios 20191106 patches

2019-11-06 Thread Gerd Hoffmann
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/seabios-201

[PULL 0/3] virtio, pci: fixes

2019-11-06 Thread Michael S. Tsirkin
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/

[PULL 2/3] hw/i386: AMD-Vi IVRS DMA alias support

2019-11-06 Thread Michael S. Tsirkin
From: Alex Williamson When we account for DMA aliases in the PCI address space, we can no longer use a single IVHD entry in the IVRS covering all devices. We instead need to walk the PCI bus and create alias ranges when we find a conventional bus. These alias ranges cannot overlap with a "Selec

[PULL 3/3] virtio: notify virtqueue via host notifier when available

2019-11-06 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Host notifiers are used in several cases: 1. Traditional ioeventfd where virtqueue notifications are handled in the main loop thread. 2. IOThreads (aio_handle_output) where virtqueue notifications are handled in an IOThread AioContext. 3. vhost where virtqueue notifica

[PULL 1/3] pci: Use PCI aliases when determining device IOMMU address space

2019-11-06 Thread Michael S. Tsirkin
From: Alex Williamson PCIe requester IDs are used by modern IOMMUs to differentiate devices in order to provide a unique IOVA address space per device. These requester IDs are composed of the bus/device/function (BDF) of the requesting device. Conventional PCI pre-dates this concept and is simp

Re: [PATCH v2 4/4] target/arm: Add support for DC CVAP & DC CVADP ins

2019-11-06 Thread Richard Henderson
On 11/6/19 12:41 AM, Beata Michalska wrote: > ARMv8.2 introduced support for Data Cache Clean instructions > to PoP (point-of-persistence) - DC CVAP and PoDP (point-of-deep-persistence) > - DV CVADP. Both specify conceptual points in a memory system where all writes > that are to reach them are con

Re: guest / host buffer sharing ...

2019-11-06 Thread Gerd Hoffmann
On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote: > > (1) The virtio device > > = > > > > Has a single virtio queue, so the guest can send commands to register > > and unregister buffers. Buffers are allocated in guest ram. Each buffer > > has a list of memory ran

RE: [RFC v2 10/22] intel_iommu: add virtual command capability support

2019-11-06 Thread Liu, Yi L
> From: Peter Xu > Sent: Saturday, November 2, 2019 2:06 AM > To: Liu, Yi L > Subject: Re: [RFC v2 10/22] intel_iommu: add virtual command capability > support > > On Thu, Oct 24, 2019 at 08:34:31AM -0400, Liu Yi L wrote: > > This patch adds virtual command support to Intel vIOMMU per > > Intel

Re: [PULL v2 00/73] tcg plugins and testing updates

2019-11-06 Thread Markus Armbruster
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> I hate to interfere with the merging of working code for non-technical >>> reasons >>> >>> This is a plugin interface. As I wrote in reply to v4, I'd like to see >>> a pragmatic argument why abuse of the

[PATCH] numa: Add missing \n to error message

2019-11-06 Thread Greg Kurz
If memory allocation fails when using -mem-path, QEMU is supposed to print out a message to indicate that fallback to anonymous RAM is deprecated. This is done with error_printf() which does output buffering. As a consequence, the message is only printed at the next flush, eg. when quiting QEMU, an

RE: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid alloc/free

2019-11-06 Thread Liu, Yi L
> From: Peter Xu > Sent: Saturday, November 2, 2019 1:26 AM > To: David Gibson > Subject: Re: [RFC v2 09/22] vfio/pci: add iommu_context notifier for pasid > alloc/free > > On Tue, Oct 29, 2019 at 01:15:44PM +0100, David Gibson wrote: > > > +union IOMMUCTXPASIDReqDesc { > > > +struct { > > >

Re: guest / host buffer sharing ...

2019-11-06 Thread Gerd Hoffmann
Hi, > In the graphics buffer sharing use case, how does the other side > determine how to interpret this data? The idea is to have free form properties (name=value, with value being a string) for that kind of metadata. > Shouldn't there be a VIRTIO > device spec for the messaging so compatible

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-06 Thread Max Reitz
On 17.10.19 15:01, Kevin Wolf wrote: > Add a --nbd-server option to qemu-storage-daemon to start the built-in > NBD server right away. It maps the arguments for nbd-server-start to the > command line. Well, it doesn’t quite, because nbd-server-start takes a SocketAddressLegacy, and this takes a So

Re: [PATCH] numa: Add missing \n to error message

2019-11-06 Thread Greg Kurz
Oops I hadn't realized that Marcel had a new e-mail address... since last year :-\ Sorry for the noise. On Wed, 06 Nov 2019 13:46:40 +0100 Greg Kurz wrote: > If memory allocation fails when using -mem-path, QEMU is supposed to print > out a message to indicate that fallback to anonymous RAM is d

Re: [PATCH] numa: Add missing \n to error message

2019-11-06 Thread Laurent Vivier
Le 06/11/2019 à 13:46, Greg Kurz a écrit : > If memory allocation fails when using -mem-path, QEMU is supposed to print > out a message to indicate that fallback to anonymous RAM is deprecated. This > is done with error_printf() which does output buffering. As a consequence, > the message is only p

Re: [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

2019-11-06 Thread Max Reitz
On 13.09.19 13:49, Max Reitz wrote: > Another gentle ping. And another. Max signature.asc Description: OpenPGP digital signature

  1   2   3   >