This activates HIOMAP support on the QEMU PowerNV machine. The PnvPnor
model is used to access the flash contents. The model simply maps the
contents at a fix offset and enables or disables the mapping.
HIOMAP Protocol description :
https://github.com/openbmc/hiomapd/blob/master/Documentation/p
Now that Focal is open I have opened proper Focal MP replacing the old one and
also an Eoan SRU MP right away.
=>
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/374770
=>
https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/374771
--
You received t
Hello,
On a POWERPC PowerNV system, the host firmware is stored in a PNOR
flash chip which contents is mapped on the LPC bus. This model adds a
simple dummy device to map the contents of a block device in the host
address space and activates HIOMAP support on the QEMU PowerNV machine
to let the ho
The routine ipmi_register_oem_netfn() lets external modules register
command handlers for OEM functions. Required for the PowerNV machine.
Cc: Corey Minyard
Reviewed-by: Corey Minyard
Signed-off-by: Cédric Le Goater
---
Changed in v2:
- export IPMI_BMC_SIMULATOR()
- export ipmi_register_net
On 10/26/2019 3:44 AM, Markus Armbruster wrote:
Igor Mammedov writes:
[...]
1st: above is applicable to both bw and lat values and should be documented
as such
2nd: 'max NUM is 65534' when different suffixes is fleeting target,
spec says that entry with 0x is unreachable, s
Refactor the exec_command_and_wait_for_pattern() utility method
so we can reuse it in other files.
Signed-off-by: Philippe Mathieu-Daudé
---
v2: fix self -> test, failure_message is optional, added doc
v3: reword because after rebasing only 1 file has to be modified
---
tests/acceptance/avocado_
Hi,
These Avocado-related patches were posted some weeks/months ago
but got lost in the mailing list traffic.
Please review,
Phil.
Cleber Rosa (1):
Acceptance tests: refactor wait_for_console_pattern
Philippe Mathieu-Daudé (25):
python/qemu/machine: Allow to use other serial consoles than
From: Philippe Mathieu-Daudé
Release notes:
http://www.helenos.org/wiki/Download#HelenOS0.6.0
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
tests/acceptance/machine_sparc_leon3.py | 37 +
2 files changed, 38 insertions(+)
cre
From: Philippe Mathieu-Daudé
Currently the QEMU Python module limits the QEMUMachine class to
use the first serial console.
Some machines/guest might use another console than the first one as
the 'boot console'. For example the Raspberry Pi uses the second
(AUX) console.
To be able to use the N
Similarly to the MachineTest base class, this class contains
methods common to linux-user tests.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acc
Make pick_default_qemu_bin() generic to find qemu-system or
qemu-user binaries.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/
From: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index 4ca0d0fdf1..2a1013f8f4 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -267,7 +267,7 @@ mat
From: Philippe Mathieu-Daudé
Gaisler provides convenient images:
https://www.gaisler.com/index.php/downloads/linux
HOWTO build:
https://www.gaisler.com/index.php/products/operating-systems/linux
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/machine_sparc_leon3.py | 28 +++
From: Cleber Rosa
The same utility method is already present in two different test
files, so let's consolidate it into a single utility function.
Signed-off-by: Cleber Rosa
Message-Id: <20190916164011.7653-1-cr...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
[PMD: failure_message is optiona
From: Philippe Mathieu-Daudé
User case from:
https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html
Acked-by: David Gibson
Acked-by: Artyom Tarasenko
Tested-by: Cleber Rosa
Reviewed-by: Cleber Rosa
Signed-off-by: Philippe Mathieu-Daudé
---
v3: use avocado_qemu.wait_for_console_pat
From: Philippe Mathieu-Daudé
Similar to the x86_64/pc test, it boots a Linux kernel on a raspi2
board and verify the serial is working.
The kernel image and DeviceTree blob are built by the Raspbian
project (based on Debian):
https://www.raspbian.org/RaspbianImages
as recommended by the Raspberr
Because of a possible deadlock (QEMU waiting for the socket to
become writable) let's close the console socket as soon as we
stop to use it.
Suggested-by: Cleber Rosa
Signed-off-by: Philippe Mathieu-Daudé
---
tests/acceptance/avocado_qemu/__init__.py | 1 +
1 file changed, 1 insertion(+)
diff
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
---
If this list continues to grow we can
- split it (as other jobs)
- move them to GitLab where we can have multi-stage jobs,
avocado tests run on top of build jobs.
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 d
From: Philippe Mathieu-Daudé
Add a test which boots Linux and run basic commands using the serial
port console.
The kernel image is built by the Debian project:
https://wiki.debian.org/RaspberryPi
The DeviceTree blob comes from the official Raspberry Pi project:
https://www.raspberrypi.org/
Th
From: Philippe Mathieu-Daudé
This test boots a Linux kernel on a smdkc210 board and verify
the serial output is working.
The cpio image used comes from the linux-build-test project:
https://github.com/groeck/linux-build-test
If ARM is a target being built, "make check-acceptance" will
automatic
From: Philippe Mathieu-Daudé
Some firmwares don't parse the control character and
expect a .
Signed-off-by: Philippe Mathieu-Daudé
---
since previous: do not send NewLine
---
tests/acceptance/boot_linux_console.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/accep
From: Philippe Mathieu-Daudé
As of this commit, NetBSD 4.0 is very old. However it is enough to
test the PRep/40p machine.
User case from:
http://mail-index.netbsd.org/port-prep/2017/04/11/msg000112.html
Reviewed-by: Hervé Poussineau
Acked-by: David Gibson
Acked-by: Artyom Tarasenko
Signed-o
This class is used to test QEMU machines, rename it as MachineTest.
This will allow us to add a UserTest class for qemu-user tests.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/devel/testing.rst| 8
tests/acceptance/avocado_qemu/__init__.py | 7 ++-
tests/accep
From: Philippe Mathieu-Daudé
This tests boots a Linux kernel on a Malta machine up to a
busybox shell on the serial console. Few commands are executed
before halting the machine (via reboot).
We use the Fedora 24 kernel extracted from the image at:
https://fedoraproject.org/wiki/Architectures/MI
From: Philippe Mathieu-Daudé
Add a test which boots a HP-UX firmware upgrade CD-ROM.
It exercise the PCI LSI53C895A SCSI controller.
The ISO image comes from:
https://web.archive.org/web/20101204061612/http://ftp.parisc-linux.org/kernels/712/PF_C7120023
This test is very quick, less than 3s:
From: Philippe Mathieu-Daudé
Add a very quick test that runs a busybox binary in bFLT format:
$ avocado --show=app run tests/acceptance/load_bflt.py
JOB ID : db94d5960ce564c50904d666a7e259148c27e88f
JOB LOG: ~/avocado/job-results/job-2019-06-25T10.52-db94d59/job.log
(1/1) tests/
From: Philippe Mathieu-Daudé
Add a test which loads the root filesystem on a SD card.
Use a kernel recent enough to also test the thermal sensor.
The kernel image comes from:
https://github.com/sakaki-/bcmrpi3-kernel#description
The cpio image used comes from the linux-build-test project:
https
To convert strings with time suffixes to numbers, support time unit are
"ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s"
for second. Add test for qemu_strtotime_ns, test the input of basic,
time suffixes, float, invaild, trailing and overflow.
Signed-off-by: Tao Xu
---
Chan
This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
according to the command line. The ACPI HMAT describes the memory attributes,
such as memory side cache attributes and bandwidth and latency details,
related to the Memory Proximity Domain.
The software is expected to use
From: Philippe Mathieu-Daudé
User case from:
https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
Acked-by: David Gibson
Signed-off-by: Philippe Mathieu-Daudé
---
v3:
- use avocado_qemu.wait_for_console_pattern (Cleber)
- use MD5 hash
---
tests/acceptance/ppc_prep_40p.py | 32 +++
From: Liu Jingqi
This structure describes memory side cache information for memory
proximity domains if the memory side cache is present and the
physical device forms the memory side cache.
The software could use this information to effectively place
the data in memory to maximize the performance
Add tests for time input such as zero, around limit of precision,
signed upper limit, actual upper limit, beyond limits, time suffixes,
and etc.
Signed-off-by: Tao Xu
---
Changes in v14:
- Drop time unit picosecond (Eric)
---
tests/test-keyval.c| 122
From: Philippe Mathieu-Daudé
User case from:
https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html
Sandalfoot info:
http://www.juneau-lug.org/sandalfoot.php
Acked-by: David Gibson
Signed-off-by: Philippe Mathieu-Daudé
---
v3:
- use avocado_qemu.wait_for_console_pattern (Cleber)
-
From: Liu Jingqi
This structure describes the memory access latency and bandwidth
information from various memory access initiator proximity domains.
The latency and bandwidth numbers represented in this structure
correspond to rated latency and bandwidth for the platform.
The software could use
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
Heterogeneous Memory with boot option '-numa node'.
Add test cases on PC and Q35 machines with 2 numa nodes.
Because HMAT is generated when system enable numa, the
following tables need to be added for this test:
tests/acpi-tes
Compress HMAT latency and bandwidth raw data into uint16_t data,
which can be stored in HMAT table.
Suggested-by: Igor Mammedov
Signed-off-by: Tao Xu
---
Changes in v14:
- Convert latency from ns to ps, because ACPI 6.3 HMAT table use
ps as minimum unit
---
hw/core/numa.c | 59 ++
From: Philippe Mathieu-Daudé
Avocado 67.0 [*] introduced the avocado.utils.archive module which
provides handling of gzip files. Use the gzip_uncompress() method.
[*]
https://avocado-framework.readthedocs.io/en/67.0/api/utils/avocado.utils.html#avocado.utils.archive.gzip_uncompress
Suggested-b
From: Liu Jingqi
Add -numa hmat-cache option to provide Memory Side Cache Information.
These memory attributes help to build Memory Side Cache Information
Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
Reviewed-by: Daniel Black
Signed-off-by: Liu Jingqi
Signed-off-by: Tao Xu
On Monday, October 28, 2019, Philippe Mathieu-Daudé
wrote:
> Because of a possible deadlock (QEMU waiting for the socket to
> become writable) let's close the console socket as soon as we
> stop to use it.
>
> Suggested-by: Cleber Rosa
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/acce
From: Philippe Mathieu-Daudé
The current do_test_arm_raspi2() case tests the PL011 UART0.
Our model also supports the AUX UART (16550 based).
We can very simply test the UART1 with Linux, modifying the
kernel command line.
Add few lines to expand our previous test and cover the AUX
UART.
Review
From: Liu Jingqi
HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table
(HMAT). The specification references below link:
http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf
It describes the memory attributes, such as memory side cache
attributes and bandw
Hi Michael.
Totally agree with you. I investigated that for a short time but in
the end I tested manually with the coverage instrumentation, trying to
exercise the same "code" as current tests touches in split virtqueues.
I will automate at least these paths.
Thanks!
On Fri, Oct 25, 2019 at 1:
From: Philippe Mathieu-Daudé
This test boots a Linux kernel on a smdkc210 board and verify
the serial output is working.
The cpio image used comes from the linux-build-test project:
https://github.com/groeck/linux-build-test
Since this test is not reliable due to clock timing issues,
it is disa
On Monday, October 28, 2019, Philippe Mathieu-Daudé
wrote:
> From: Cleber Rosa
>
> The same utility method is already present in two different test
> files, so let's consolidate it into a single utility function.
>
> Signed-off-by: Cleber Rosa
> Message-Id: <20190916164011.7653-1-cr...@redhat.c
Add optional builtin type time, fallback is uint64. This type use
qemu_strtotime_ns() for pre-converting time suffix to numbers.
Signed-off-by: Tao Xu
---
Changes in v14:
- Drop time unit picosecond (Eric)
---
include/qapi/visitor-impl.h | 4
include/qapi/visitor.h | 8 +++
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT),
The initiator represents processor which access to memory. And in 5.2.27.3
Memory Proximity Domain Attributes Structure, the attached initiator is
defined as where the memory controller responsible for a memory proximity
domain
From: Liu Jingqi
Add -numa hmat-lb option to provide System Locality Latency and
Bandwidth Information. These memory attributes help to build
System Locality Latency and Bandwidth Information Structure(s)
in ACPI Heterogeneous Memory Attribute Table (HMAT).
Signed-off-by: Liu Jingqi
Signed-off-
On Monday, October 28, 2019, Philippe Mathieu-Daudé
wrote:
> From: Philippe Mathieu-Daudé
>
> This tests boots a Linux kernel on a Malta machine up to a
> busybox shell on the serial console. Few commands are executed
> before halting the machine (via reboot).
>
>
A very nice test.
Reviewed-by
Patchew URL: https://patchew.org/QEMU/20191028073441.6448-1-phi...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!
28.10.2019 9:33, Tuguoyi wrote:
> In check_constraints_on_bitmap(), the sanity check on the
> granularity will cause uint64_t integer left-shift overflow
> when cluster_size is 2M and the granularity is BIGGER than
> 32K. As a result, for a qcow2 disk with cluster_size set to
> 2M, we could not eve
On Mon, Oct 28, 2019 at 12:01:34PM +0800, gengdongjiu wrote:
> Hi Michael/All
>
> On 2019/10/27 18:17, Michael S. Tsirkin wrote:
> > On Sat, Oct 26, 2019 at 11:24:42AM +0800, Xiang Zheng wrote:
> >> In the ARMv8 platform, the CPU error types are synchronous external
> >> abort(SEA)
> >> and SErro
Patchew URL: https://patchew.org/QEMU/20191028075220.25673-1-tao3...@intel.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
On Mon, Oct 28, 2019 at 03:52:20PM +0800, Tao Xu wrote:
> ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
> Heterogeneous Memory with boot option '-numa node'.
>
> Add test cases on PC and Q35 machines with 2 numa nodes.
> Because HMAT is generated when system enable numa, the
On 27/10/2019 17:48, Andrey Shinkevich wrote:
> The stress test for an NBD client. The NBD server is disconnected after
> a client write operation. The NBD client should reconnect and retry the
> operation.
>
> Suggested-by: Denis V. Lunev
> Signed-off-by: Andrey Shinkevich
> ---
> tests/qem
On 10/28/2019 4:39 PM, Michael S. Tsirkin wrote:
On Mon, Oct 28, 2019 at 03:52:20PM +0800, Tao Xu wrote:
ACPI table HMAT has been introduced, QEMU now builds HMAT tables for
Heterogeneous Memory with boot option '-numa node'.
Add test cases on PC and Q35 machines with 2 numa nodes.
Because HMAT
On 26.10.19 19:52, Vladimir Sementsov-Ogievskiy wrote:
> 26.10.2019 20:37, Nir Soffer wrote:
>> On Fri, Oct 25, 2019 at 1:11 PM Max Reitz wrote:
>>>
>>> Hi,
>>>
>>> It seems to me that there is a bug in Linux’s XFS kernel driver, as
>>> I’ve explained here:
>>>
>>> https://lists.nongnu.org/archive
Peter Maydell writes:
> On Fri, 25 Oct 2019 at 21:24, Markus Armbruster wrote:
>> Alex Bennée writes:
>> > I'd rather not unless we can make an exception for late merging of the
>> > PR. I've worked quite hard to make sure everything is ready for the 4.2
>> > window and I'd rather not miss a
On 27.10.19 13:35, Stefan Hajnoczi wrote:
> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
>> As for how we can address the issue, I see three ways:
>> (1) The one presented in this series: On XFS with aio=native, we extend
>> tracked requests for post-EOF fallocate() calls (i.e., w
On 28.10.19 10:24, Max Reitz wrote:
> On 27.10.19 13:35, Stefan Hajnoczi wrote:
>> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
>>> As for how we can address the issue, I see three ways:
>>> (1) The one presented in this series: On XFS with aio=native, we extend
>>> tracked reques
Patchew URL: https://patchew.org/QEMU/20191028073441.6448-1-phi...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!
On 28.10.19 10:30, Max Reitz wrote:
> On 28.10.19 10:24, Max Reitz wrote:
>> On 27.10.19 13:35, Stefan Hajnoczi wrote:
>>> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
As for how we can address the issue, I see three ways:
(1) The one presented in this series: On XFS with ai
On 10/27/19 3:48 PM, Andrey Shinkevich wrote:
The stress test for an NBD client. The NBD server is disconnected after
a client write operation. The NBD client should reconnect and retry the
operation.
Suggested-by: Denis V. Lunev
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/277
28.10.2019 12:56, Max Reitz wrote:
> On 28.10.19 10:30, Max Reitz wrote:
>> On 28.10.19 10:24, Max Reitz wrote:
>>> On 27.10.19 13:35, Stefan Hajnoczi wrote:
On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
> As for how we can address the issue, I see three ways:
> (1) The on
On 28.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote:
> 28.10.2019 12:56, Max Reitz wrote:
>> On 28.10.19 10:30, Max Reitz wrote:
>>> On 28.10.19 10:24, Max Reitz wrote:
On 27.10.19 13:35, Stefan Hajnoczi wrote:
> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
>> As for ho
28.10.2019 10:55, Eric Blake wrote:
> On 10/27/19 3:48 PM, Andrey Shinkevich wrote:
>> The stress test for an NBD client. The NBD server is disconnected after
>> a client write operation. The NBD client should reconnect and retry the
>> operation.
>>
>> Suggested-by: Denis V. Lunev
>> Signed-off-b
On 28/10/2019 13:17, Vladimir Sementsov-Ogievskiy wrote:
> 28.10.2019 10:55, Eric Blake wrote:
>> On 10/27/19 3:48 PM, Andrey Shinkevich wrote:
>>> The stress test for an NBD client. The NBD server is disconnected after
>>> a client write operation. The NBD client should reconnect and retry the
>
The test for an NBD client. The NBD server is disconnected after the
client write operation. The NBD client should reconnect and retry
the operation.
Suggested-by: Denis V. Lunev
Signed-off-by: Andrey Shinkevich
---
tests/qemu-iotests/277 | 94
Hi Michael,
I addressed all comments and feedback and think this can be merged but
I'm unclear about which tree it should go to. Will you merge it into
the virtio-tree?
regards,
Jens
On Fri, Oct 25, 2019 at 02:19:19PM +0200, Jens Freimann wrote:
This is implementing the host side of the net_fa
On 13.09.19 15:36, Maxim Levitsky wrote:
> This is the second part of the patches I prepared
> for this driver back when I worked on mdev-nvme.
>
> V2: addressed review feedback, no major changes
>
> Best regards,
> Maxim Levitsky
>
> Maxim Levitsky (2):
> block/nvme: add support for wri
On 16.10.19 13:13, Vladimir Sementsov-Ogievskiy wrote:
> 14.10.2019 18:39, Max Reitz wrote:
>> Sometimes it is useful to be able to add a node to the block graph that
>> takes or unshare a certain set of permissions for debugging purposes.
>> This patch adds this capability to blkdebug.
>>
>> (Note
Am 26.10.2019 um 18:58 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 26.10.2019 14:29, Philippe Mathieu-Daudé wrote:
> > On 10/26/19 12:12 PM, Vladimir Sementsov-Ogievskiy wrote:
> >> Make it obvious, from the two values which is found at path and which
> >> is expected.
> >
> > Maybe:
> >
> >
On 14.10.19 17:39, Max Reitz wrote:
> Hi,
>
> v2’s cover letter should explain everything:
>
> https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01079.html
>
>
> v3:
> - Patch 2: Use input visitor as proposed by Vladimir
>
> git-backport-diff against v2:
>
> Key:
> [] : patches
On 11.10.19 17:27, Max Reitz wrote:
> Hi,
>
> The v1 cover letter explained this series’s purpose:
> https://lists.nongnu.org/archive/html/qemu-block/2019-07/msg01290.html
>
> The v2 cover letter explained the v2 changes:
> https://lists.nongnu.org/archive/html/qemu-block/2019-08/msg00921.html
>
Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben:
> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
> > As for how we can address the issue, I see three ways:
> > (1) The one presented in this series: On XFS with aio=native, we extend
> > tracked requests for post-EOF fallocate
Apologies if this mail is messed up. I'm having trouble with a hotel's network
and am forced to use a webui.
- Original Message -
> On Fri, 25 Oct 2019 at 14:52, Andrew Jones wrote:
> >
> > On Fri, Oct 25, 2019 at 01:06:26PM +0100, Peter Maydell wrote:
> > > Fails 'make check' on my aa
28.10.2019 13:10, Max Reitz wrote:
> On 28.10.19 11:07, Vladimir Sementsov-Ogievskiy wrote:
>> 28.10.2019 12:56, Max Reitz wrote:
>>> On 28.10.19 10:30, Max Reitz wrote:
On 28.10.19 10:24, Max Reitz wrote:
> On 27.10.19 13:35, Stefan Hajnoczi wrote:
>> On Fri, Oct 25, 2019 at 11:58:46A
On 18.09.19 11:51, Max Reitz wrote:
> Hi,
>
> This series is supposed to pull out some of the problems from my
> “Generic file creation fallback” series.
>
> The blk_truncate_for_formatting() function added there was buggy, as
> Maxim noted, in that it did not check whether blk_truncate() actuall
On 18.09.19 22:52, Maxim Levitsky wrote:
> On Wed, 2019-09-18 at 11:51 +0200, Max Reitz wrote:
>> This is a change in behavior, so all instances need a good
>> justification. The comments added here should explain my reasoning.
>>
>> qed already had a comment that suggests it always expected
>> bd
On 18.09.19 22:50, Maxim Levitsky wrote:
> On Wed, 2019-09-18 at 11:51 +0200, Max Reitz wrote:
>> We have two drivers (iscsi and file-posix) that (in some cases) return
>> success from their .bdrv_co_truncate() implementation if the block
>> device is larger than the requested offset, but cannot be
28.10.2019 14:04, Kevin Wolf wrote:
> Am 27.10.2019 um 13:35 hat Stefan Hajnoczi geschrieben:
>> On Fri, Oct 25, 2019 at 11:58:46AM +0200, Max Reitz wrote:
>>> As for how we can address the issue, I see three ways:
>>> (1) The one presented in this series: On XFS with aio=native, we extend
>>>
28.10.2019 13:46, Max Reitz wrote:
> On 16.10.19 13:13, Vladimir Sementsov-Ogievskiy wrote:
>> 14.10.2019 18:39, Max Reitz wrote:
>>> Sometimes it is useful to be able to add a node to the block graph that
>>> takes or unshare a certain set of permissions for debugging purposes.
>>> This patch adds
On 25.10.19 17:38, Eric Blake wrote:
> On 10/25/19 9:50 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 264 is unprepared to run with different formats, for example luks needs
>> handling keys, cloop doesn't support image creation, vpc creates image
>> larger than requested (which breaks "Backup complet
case_notrun() does not actually skip the current test case. It just
adds a "notrun" note and then returns to the caller, who manually has to
skip the test. Generally, skipping a test case is as simple as
returning from the current function, but not always: For example, this
model does not allow s
The following changes since commit 187f35512106501fe9a11057f4d8705431e0026d:
Merge remote-tracking branch
'remotes/stsquad/tags/pull-testing-next-251019-3' into staging (2019-10-26
10:13:48 +0100)
are available in the Git repository at:
https://github.com/XanClic/qemu.git tags/pull-block-2
null-aio may not be whitelisted. Skip all test cases that require it.
Signed-off-by: Max Reitz
Message-id: 20190917092004.999-7-mre...@redhat.com
Reviewed-by: Andrey Shinkevich
Reviewed-by: John Snow
Signed-off-by: Max Reitz
---
tests/qemu-iotests/136 | 14 ++
1 file changed, 10
We use null-co basically everywhere in the iotests. Unless we want to
test null-aio specifically, we should use it instead (for consistency).
Signed-off-by: Max Reitz
Reviewed-by: John Snow
Reviewed-by: Thomas Huth
Message-id: 20190917092004.999-2-mre...@redhat.com
Reviewed-by: Andrey Shinkevi
This lets tests use skip_if_unsupported() with a potentially variable
list of required formats.
Suggested-by: Kevin Wolf
Signed-off-by: Max Reitz
Message-id: 20190917092004.999-5-mre...@redhat.com
Reviewed-by: Andrey Shinkevich
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 8 ++
null-aio may not be whitelisted. Skip all test cases that require it.
(And skip the whole test if null-co is not whitelisted.)
Signed-off-by: Max Reitz
Message-id: 20190917092004.999-6-mre...@redhat.com
Reviewed-by: Andrey Shinkevich
Reviewed-by: John Snow
Signed-off-by: Max Reitz
---
tests
Specifying this optional parameter allows creating temporary files in
other directories than the test_dir; for example in sock_dir.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Message-id: 20191017133155.5327-4-mre...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py |
Signed-off-by: Max Reitz
Reviewed-by: John Snow
Message-id: 20190917092004.999-8-mre...@redhat.com
Reviewed-by: Andrey Shinkevich
Signed-off-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/io
skip_if_unsupported() should use the stronger variant case_skip(),
because this allows it to be used even with setUp() (in a meaningful
way).
In the process, make it explicit what we expect the first argument of
the func_wrapper to be (namely something derived of QMPTestCase).
Signed-off-by: Max
From: Vladimir Sementsov-Ogievskiy
Passing zero length to these functions leads to unpredicted results.
Zero-length set/reset may occur in active-mirror, on zero-length write
(which is unlikely, but not guaranteed to never happen).
Let's just do nothing on zero-length request.
Signed-off-by: Vl
From: Vladimir Sementsov-Ogievskiy
This reverts commit 9adc1cb49af8d4e54f57980b1eed5c0a4b2dafa6.
"mirror: Only mirror granularity-aligned chunks"
Since previous commit unaligned chunks are supported by
do_sync_target_write.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Message-id: 20191017133155.5327-5-mre...@redhat.com
Reviewed-by: Thomas Huth
Signed-off-by: Max Reitz
---
tests/qemu-iotests/common.filter | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.filter
Unix sockets generally have a maximum path length. Depending on your
$TEST_DIR, it may be exceeded and then all tests that create and use
Unix sockets there may fail.
Circumvent this by adding a new scratch directory specifically for
Unix socket files. It defaults to a temporary directory (mktem
From: Vladimir Sementsov-Ogievskiy
do_sync_target_write is called from bdrv_mirror_top_do_write after
write/discard operation, all inside active_write/active_write_settle
protecting us from mirror iteration. So the whole area is dirty for
sure, no reason to examine dirty bitmap.
Signed-off-by: V
From: Vladimir Sementsov-Ogievskiy
Add blk write function with qiov_offset parameter. It's needed for the
following commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-id: 20191011090711.19940-4-vsement...@virtuozzo.com
Signed-off-by: Max Reitz
---
include/syse
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Thomas Huth
Message-id: 20191017133155.5327-8-mre...@redhat.com
Signed-off-by: Max Reitz
---
tests/qemu-iotests/140 | 8
tests/qemu-iotests/140.out | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/
From: Vladimir Sementsov-Ogievskiy
Prior 9adc1cb49af8d do_sync_target_write had a bug: it reset aligned-up
region in the dirty bitmap, which means that we may not copy some bytes
and assume them copied, which actually leads to producing corrupted
target.
So 9adc1cb49af8d forced dirty bitmap gran
In addition, drop the nbd_unix_socket assignment in 241 because it does
not really do anything.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Message-id: 20191017133155.5327-6-mre...@redhat.com
Reviewed-by: Thomas Huth
Signed-off-by: Max Reitz
---
tests/qemu-iotests/241| 2 --
test
1 - 100 of 316 matches
Mail list logo
