On 28/10/2019 13:17, Vladimir Sementsov-Ogievskiy wrote: > 28.10.2019 10:55, Eric Blake wrote: >> On 10/27/19 3:48 PM, Andrey Shinkevich wrote: >>> The stress test for an NBD client. The NBD server is disconnected after >>> a client write operation. The NBD client should reconnect and retry the >>> operation. >>> >>> Suggested-by: Denis V. Lunev <d...@openvz.org> >>> Signed-off-by: Andrey Shinkevich <andrey.shinkev...@virtuozzo.com> >>> --- >>> tests/qemu-iotests/277 | 91 >>> ++++++++++++++++++++++++++++++++++++++++++++++ >>> tests/qemu-iotests/277.out | 7 ++++ >>> tests/qemu-iotests/group | 1 + >>> 3 files changed, 99 insertions(+) >>> create mode 100755 tests/qemu-iotests/277 >>> create mode 100644 tests/qemu-iotests/277.out >> >> How does this differ from 264? If it adds anything new, can it be merged >> into the existing test? >> > > 264 is backup over NBD with reconnect. Here is another thing: check that the > only small request works > with reconnect, if disconnect occurs exactly after request was accepted by > server and client knows, > that requests is successfully accepted. We want to check that client will not > wait reply forever but > resend the request to new started NBD server. > > So, I think, they are different enough to keep them in separate. Still, if we > want to merge them, it > means that we should rewrite them in unittest style, with test-cases, as I > think that huge text-camparing > tests with several test cases are bad thing, I'll write a separate letter > about it to discuss a bit later. >
Please look at the v2 coming... -- With the best regards, Andrey Shinkevich
