[PULL v2 24/73] plugin: add implementation of the api

[AJB: split from the core code commit] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index d9c1ca3b4cf..b9a4a4b6841 100644 --- a/include/qemu/qemu-plugin.h +++ b/include/qemu/qemu-plugin.h @@ -285,9 +285,6 @@ bool q

[PULL v2 30/73] atomic_template: add inline trace/plugin helpers

From: "Emilio G. Cota" In preparation for plugin support. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/accel/tcg/atomic_common.inc.c b/accel/tcg/atomic_common.inc.c new file mode 100644 index 000..a86098fb2de --- /dev/null +++ b

[PULL v2 28/73] tcg: add tcg_gen_st_ptr

From: "Emilio G. Cota" Will gain a user soon. Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index e9cf172762e..7c778f96f3b 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -1249,6 +1249,11 @@ static inline void

[PULL v2 20/73] translate-all: use cpu_in_exclusive_work_context() in tb_flush

From: "Emilio G. Cota" tb_flush will be called by the plugin module from a safe work environment. Prepare for that. Suggested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/accel/tcg/translate-al

[PULL v2 60/73] tests/tcg/Makefile.target: fix path to config-host.mak

Since moving where the tests are run the path to config-host.mak has been wrong. This doesn't affect much but things like the time fallback for CONFIG_DEBUG_TCG and will also get in the way of checking for PLUGINS support. Fixes: fc76c56d3f4 Signed-off-by: Alex Bennée Reviewed-by: Richard Henders

[PULL v2 72/73] MAINTAINERS: add me for the TCG plugins code

Signed-off-by: Alex Bennée diff --git a/MAINTAINERS b/MAINTAINERS index ed41d7d1b6c..ade2187eae4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2328,6 +2328,12 @@ M: Richard Henderson S: Maintained F: tcg/ +TCG Plugins +M: Alex Bennée +S: Maintained +F: plugins/ +F: tests/plugin + AArch64

[PULL v2 49/73] target/xtensa: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index d20e60ce770..a99f5296e2f 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -859,7 +85

[PULL v2 25/73] queue: add QTAILQ_REMOVE_SEVERAL

From: "Emilio G. Cota" This is faster than removing elements one by one. Will gain a user soon. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/qemu/queue.h b/include/qemu/queue.h index 73bf4a984d8..4764d93ea3f 100644 --- a/includ

[PULL v2 36/73] cpu: hook plugin vcpu events

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/cpus.c b/cpus.c index fabbeca6f46..63bda152f57 100644 --- a/cpus.c +++ b/cpus.c @@ -45,6 +45,7 @@ #include "exec/exec-all.h" #include "qemu/thread.h" +#include "qemu

[PULL v2 55/73] plugin: add qemu_plugin_insn_disas helper

Give the plugins access to the QEMU dissasembler so they don't have to re-invent the wheel. We generate a warning when there are spare bytes in the decode buffer. This is usually due to the front end loading in more bytes than decoded. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson d

[PULL v2 71/73] scripts/checkpatch.pl: don't complain about (foo, /* empty */)

It's quite common to have a mini comment inside braces to acknowledge we know it's empty. Expand the inline detection to allow closing braces before the end of line. Signed-off-by: Alex Bennée Reviewed-by: Aaron Lindsay diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index aa9a354a0e

[PULL v2 41/73] target/ppc: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Acked-by: David Gibson Signed-off-by: Alex Bennée diff --git a/target/ppc/translate.c b/target/ppc/translate.c index adb8fd516f1..f5fe5d06118 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @

[PULL v2 38/73] cputlb: ensure _cmmu helper functions follow the naming standard

We document this in docs/devel/load-stores.rst so lets follow it. The 32 bit and 64 bit access functions have historically not included the sign so we leave those as is. We also introduce some signed helpers which are used for loading immediate values in the translator. Fixes: 282dffc8 Signed-off-

[PULL v2 50/73] target/openrisc: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 6addbac8d63..8dd28d6cf17 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -1

[PULL v2 32/73] plugins: implement helpers for resolving hwaddr

We need to keep a local per-cpu copy of the data as other threads may be running. Currently we can provide insight as to if the access was IO or not and give the offset into a given device (usually the main RAMBlock). We store enough information to get details such as the MemoryRegion which might b

[PULL v2 40/73] target/arm: fetch code with translator_ld

From: "Emilio G. Cota" Now the arm_ld*_code functions are only used at translate time we can just pass down to translator_ld functions. Signed-off-by: Emilio G. Cota [AJB: convert from plugin_insn_append to translator_ld] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a

[PULL v2 58/73] linux-user: support -plugin option

From: Lluís Vilanova Signed-off-by: Lluís Vilanova [ cota: s/instrument/plugin ] Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/linux-user/main.c b/linux-user/main.c index 560d053f724..6ff7851e86f 100644 --- a/linux-user/main.c +++ b/linu

[PULL v2 35/73] *-user: plugin syscalls

From: "Emilio G. Cota" To avoid too much duplication add a wrapper that the existing trace and the new plugin calls can live in. We could move the -strace code here as well but that is left for a future series as the code is subtly different between the bsd and linux. Signed-off-by: Emilio G. Co

Re: [PATCH v6 0/9] Packed virtqueue for virtio

Hi Jason! I can post a new version. You will have it in a moment. Thanks! On Fri, Oct 25, 2019 at 5:20 AM Jason Wang wrote: > > > On 2019/10/25 上午1:13, Eugenio Pérez wrote: > > Hi: > > > > This is an updated version of packed virtqueue support based on Wei and > > Jason's > > V5, mainly solvin

[PULL v2 62/73] tests/tcg: move "virtual" tests to EXTRA_TESTS

Otherwise clever expanders like the plugins test get unstuck. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 84abbd24f34..96646130020 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -66

[PULL v2 57/73] vl: support -plugin option

From: Lluís Vilanova Signed-off-by: Lluís Vilanova [ cota: s/instrument/plugin ] Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/qemu-options.hx b/qemu-options.hx index 996b6fba746..fb6df45193f 100644 --- a/qemu-options.hx +++ b/qemu-optio

[PULL v2 34/73] *-user: notify plugin of exit

From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 1ee6195d9ff..84a983a9a12 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -332,6 +332,

[PULL v2 61/73] tests/tcg: set QEMU_OPTS for all cris runs

This will important for ensuring the plugin test variants will also work. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/tcg/cris/Makefile.target b/tests/tcg/cris/Makefile.target index c1173ead422..24c7f2e7616 100644 --- a/tests/tcg/cris/Makefile.target +++ b/tests

[PULL v2 69/73] include/exec: wrap cpu_ldst.h in CONFIG_TCG

This gets around a build problem with --disable-tcg. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index eadcf29d0c4..d85e610e85b 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -22,7 +22,9 @@ #i

[PULL v2 17/73] trace: expand mem_info:size_shift to 4 bits

From: "Emilio G. Cota" This will allow us to trace 32k-long memory accesses (although our maximum is something like 256 bytes at the moment). Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota [AJB: expanded to 3->4 bits] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --

[PULL v2 39/73] translator: add translator_ld{ub,sw,uw,l,q}

From: "Emilio G. Cota" We don't bother with replicating the fast path (tlb_hit) of the old cpu_ldst helpers as it has no measurable effect on performance. This probably indicates we should consider flattening the whole set of helpers but that is out of scope for this change. Suggested-by: Richar

[PULL v2 70/73] .travis.yml: add --enable-plugins tests

check-tcg will automatically run the plugins against most TCG tests if it is enabled in the build. We exclude sparc64-linux-user for now as there are pending patches that need to be merged fixing it's fork implementation. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/.t

[PULL v2 18/73] trace: add mmu_index to mem_info

We are going to re-use mem_info later for plugins and will need to track the mmu_idx for softmmu code. Signed-off-by: Alex Bennée diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h index 287433d809b..473d7e5a943 100644 --- a/accel/tcg/atomic_template.h +++ b/accel/tcg/atomic_

[PULL v2 31/73] tcg: let plugins instrument virtual memory accesses

From: "Emilio G. Cota" To capture all memory accesses we need hook into all the various helper functions that are involved in memory operations as well as the injected inline helper calls. A later commit will allow us to resolve the actual guest HW addresses by replaying the lookup. Signed-off-b

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

On 25.10.19 04:25, Eduardo Habkost wrote: We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model versions using Interesting, I was not aware of that. On s390x, we somewhat have versioned CPU models, but we decided against giving them explicit names (

[PULL v2 15/73] tests/docker: set HOST_ARCH if we don't have ARCH

As the docker rules want to be able to be run on a virgin unconfigured checkout add a fallback and use it if we need to. Signed-off-by: Alex Bennée diff --git a/.shippable.yml b/.shippable.yml index bbc6f88510f..f74a3de3ffd 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -27,8 +27,6 @@ env:

Re: [PATCH 3/3] migration/multifd: fix potential wrong acception order of IOChannel

On 2019/10/24 22:34, Daniel P. Berrangé wrote: > On Thu, Oct 24, 2019 at 09:53:24PM +0800, cenjiahui wrote: >> On 2019/10/24 17:52, Daniel P. Berrangé wrote: >>> On Wed, Oct 23, 2019 at 11:32:14AM +0800, cenjiahui wrote: From: Jiahui Cen Multifd assumes the migration thread IOCha

[PULL v2 67/73] tests/plugin: add hotpages to analyse memory access patterns

This plugin gives a summary of access patterns grouped by "pages" and showing read/write patterns by vCPUS. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/plugin/Makefile b/tests/plugin/Makefile index 3656429d46b..75467b6db85 100644 --- a/tests/plugin/Makefile +++

Re: [PATCH] i386: Use g_autofree in a few places

On Thu, Oct 24, 2019 at 11:56:32PM -0300, Eduardo Habkost wrote: > Get rid of 12 explicit g_free() calls. > > Signed-off-by: Eduardo Habkost > --- > target/i386/cpu.c | 41 + > 1 file changed, 13 insertions(+), 28 deletions(-) > The changes LGTM: Reviewe

[PULL v2 42/73] target/sh4: fetch code with translator_ld

From: "Emilio G. Cota" There is a small wrinkle with the gUSA instruction. The translator effectively treats a (known) gUSA sequence as a single instruction. For the purposes of the plugin we end up with a long multi-instruction qemu_plugin_insn. If the known sequence isn't detected we shall nev

[PULL v2 46/73] target/alpha: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/alpha/translate.c b/target/alpha/translate.c index a69f58bf658..f7f1ed0f411 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -2987,7 +2987,

[PULL v2 37/73] plugin-gen: add plugin_insn_append

From: "Emilio G. Cota" By adding it to plugin-gen's header file, we can export is as an inline, since tcg.h is included in the header (we need tcg_ctx). Signed-off-by: Emilio G. Cota [AJB: use g_byte_array] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/exec/p

[PULL v2 45/73] target/m68k: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 24c1dd3408a..fcdb7bc8e4e 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -384,7 +384,7 @@ s

[PULL v2 51/73] translator: inject instrumentation from plugins

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 70c66c538cf..f977682be79 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -16,6 +16,7 @@ #inclu

[PULL v2 43/73] target/i386: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/i386/translate.c b/target/i386/translate.c index 868b0acafe8..77e932d8276 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -1925,28 +1925,28

[PULL v2 33/73] translate-all: notify plugin code of tb_flush

From: "Emilio G. Cota" Plugins might allocate per-TB data that then they get passed each time a TB is executed (via the *userdata pointer). Notify plugin code every time a code cache flush occurs, so that plugins can then reclaim the memory of the per-TB data. Reviewed-by: Alex Bennée Signed-o

[PULL v2 48/73] target/sparc: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/sparc/translate.c b/target/sparc/translate.c index c68bf4a2e41..edc23a7c403 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5884,7 +5884,

[PULL v2 44/73] target/hppa: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/target/hppa/translate.c b/target/hppa/translate.c index c1b2822f605..2f8d407a82b 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -4221,7 +4221,7 @@

[PULL v2 27/73] cputlb: introduce get_page_addr_code_hostp

From: "Emilio G. Cota" This will be used by plugins to get the host address of instructions. Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index a8f90695823..82a5783a2bc 100644 --- a/accel/tcg/cput

[PULL v2 47/73] target/riscv: fetch code with translator_ld

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Acked-by: Palmer Dabbelt diff --git a/target/riscv/translate.c b/target/riscv/translate.c index adeddb85f67..b26533d4fd7 100644 --- a/target/riscv/tra

[PULL v2 14/73] travis.yml: --enable-debug-tcg to check-tcg

This adds a whole bunch of asserts which will catch bugs you might introduce into the TCG code. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/.travis.yml b/.travis.yml index c43597f1331..ba3a8d4cfc9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -334,14 +334,14 @@ m

[PULL v2 63/73] tests/tcg: drop test-i386-fprem from TESTS when not SLOW

This is a very slow running test which we only enable explicitly. However having it in the TESTS lists would confuse additional tests like the plugins test which want to run on all currently enabled tests. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/tcg/i386/Mak

[PULL v2 26/73] cputlb: document get_page_addr_code

From: "Emilio G. Cota" Suggested-by: Alex Bennée Signed-off-by: Emilio G. Cota Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 04795c49bf4..e4206cb1735 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-

Re: [PATCH v2 0/3] Convert sparc devices to new ptimer API

On Thu, 24 Oct 2019 at 19:10, Mark Cave-Ayland wrote: > > On 24/10/2019 13:19, Peter Maydell wrote: > > I'm going to apply these to target-arm.next; I know they haven't > > been on list long but the change since v1 is only minor and > > they've all been reviewed. > > Thanks Peter! Not sure if you

[PULL v2 23/73] plugin: add core code

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota [AJB: moved directory and merged various fixes] Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/Makefile b/Makefile index 0e994a275d4..94d25185511 100644 --- a/Makefile +++ b/Makefile @@ -853,7 +853,11 @@ endif ICO

[PULL v2 64/73] tests/tcg: enable plugin testing

If CONFIG_PLUGINS is enabled then lets enable testing for all our TCG targets. This is a simple smoke test that ensure we don't crash or otherwise barf out by running each plugin against each test. There is a minor knock on effect for additional runners which need specialised QEMU_OPTS which will

Re: [PATCH v5 06/11] qapi: add failover negotiated event

On Fri, Oct 25, 2019 at 07:35:28AM +0200, Markus Armbruster wrote: We ask patch submitters to cc: subject matter experts for review. You did. When such patches touch the QAPI schema, it's best to cc the qapi schema maintainers (Eric Blake and me) as well, because we can't require all subject ma

[PULL v2 66/73] tests/plugin: add instruction execution breakdown

This gives a break down of instruction classes and individual instruction types. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/plugin/Makefile b/tests/plugin/Makefile index e74940eaac5..3656429d46b 100644 --- a/tests/plugin/Makefile +++ b/tests/plugin/Makefile @@

Re: [PATCH v3 00/16] hw/arm/raspi: Add thermal/timer, improve address space, run U-boot

On Thu, 24 Oct 2019 at 20:46, Philippe Mathieu-Daudé wrote: > In my patches I stop using system_memory, each CPU use its > own AS view on the GPU AXI bus. That seems an odd thing to do -- is there really no common baseline view of the physical address space that the CPUs all share ? thanks -- P

[PULL v2 16/73] tests/docker: update Travis image to a more current version

This isn't the latest one available on hub.docker.com but it does match the ID reported by the Xenial builds running on Travis: instance: ... travis-ci-sardonyx-xenial-1553530528-f909ac5 Signed-off-by: Alex Bennée diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles

[PULL v2 68/73] accel/stubs: reduce headers from tcg-stub

We don't need much for these. However I do wonder why these aren't just null inlines in exec-all.h Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index e2d23edafe0..677191a69cf 100644 --- a/accel/stubs/tcg-stub.c +++ b/acce

Re: [PATCH v3 21/33] lance: replace PROP_PTR with PROP_LINK

On Thu, 24 Oct 2019 at 19:07, Eduardo Habkost wrote: > On Thu, Oct 24, 2019 at 12:52:28PM +0100, Peter Maydell wrote: > > I don't think this is a good plan -- users shouldn't have to know > > about the memory map of their boards. Plus it doesn't deal with > > the complications of multiple address

[PULL v2 73/73] travis.yml: enable linux-gcc-debug-tcg cache

Create a new cache for the --enable-debug-tcg builds which is separate from the normal debug builds which generate different code. We also enable debug-tcg for the new plugins based builds as we want to ensure any breakage to TCG is picked up by the sanity checks. Signed-off-by: Alex Bennée Revie

USB-audio sound issues with qemu-system-ppc in Linux and Windows.

Hi, I'm experiencing several issues related to sound using usb-audio when running qemu-system-ppc in Linux and Windows. Guests tried are Mac OS 9.2 and Mac OS X 10.0, 10.1, 10.2 and 10.3. (10.4 and 10.5 never have the usb-audio device available for audio playback, even though the device is recogn

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

On 25.10.19 09:17, David Hildenbrand wrote: > On 25.10.19 04:25, Eduardo Habkost wrote: >> We had introduced versioned CPU models in QEMU 4.1, including a >> method for querying for CPU model versions using > > Interesting, I was not aware of that. > > On s390x, we somewhat have versioned CPU

[PULL v2 29/73] plugin-gen: add module for TCG-related code

From: "Emilio G. Cota" We first inject empty instrumentation from translator_loop. After translation, we go through the plugins to see what they want to register for, filling in the empty instrumentation. If if turns out that some instrumentation remains unused, we remove it. This approach suppo

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

On 25.10.19 09:55, Christian Borntraeger wrote: On 25.10.19 09:17, David Hildenbrand wrote: On 25.10.19 04:25, Eduardo Habkost wrote: We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model versions using Interesting, I was not aware of that. On s3

[PATCH v7 0/8] Packed virtqueue for virtio

Hi: This is an updated version of packed virtqueue support based on Wei and Jason's V6, mainly solving the clang leak detector error CI gave. Please review. Changes from V6: - Commit reorder: Squash bugfix and sepparate big changes into smaller commits. Changes from V5: - Fix qemu's CI asan err

[PATCH v7 1/8] virtio: basic structure for packed ring

From: Wei Xu Define packed ring structure according to Qemu nomenclature, field data(wrap counter, etc) are also included. Signed-off-by: Wei Xu Signed-off-by: Jason Wang Signed-off-by: Eugenio Pérez Reviewed-by: Jens Freimann --- hw/virtio/virtio.c | 15 +++ 1 file changed, 15

[PULL 03/19] util/async: avoid useless cast

From: Frediano Ziglio event_notifier_dummy_cb is already compatible with EventNotifierHandler. Signed-off-by: Frediano Ziglio Reviewed-by: Laurent Vivier Message-Id: <20191023122652.2999-1-fzig...@redhat.com> Signed-off-by: Laurent Vivier --- util/async.c | 1 - 1 file changed, 1 deletion(-)

[PULL 02/19] pci_bridge: fix a typo in comment

From: Mao Zhongyi Signed-off-by: Mao Zhongyi Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190909031446.1331810-1-maozhon...@cmss.chinamobile.com> Signed-off-by: Laurent Vivier --- hw/pci/pci_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pci_bridge.c

[PATCH v7 2/8] virtio: device/driver area size calculation refactor for split ring

From: Wei Xu There is slight size difference between split/packed rings. This is the refactor of split ring as well as a helper to expanding device and driver area size calculation for packed ring. Signed-off-by: Wei Xu Signed-off-by: Jason Wang Signed-off-by: Eugenio Pérez Reviewed-by: Jens

[PULL 00/19] Trivial branch patches

The following changes since commit 58560ad254fbda71d4daa6622d71683190070ee2: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' into staging (2019-10-24 16:22:58 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pull-re

[PULL 10/19] hw: Move M41T80 device from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé The M41T80 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191003230404.19384-6-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS

[PULL 07/19] hw: Move PL031 device from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé The PL031 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384-3-phi...@redhat.com> Signed-off-by: Laurent Vivier -

[PULL 04/19] event_notifier: avoid dandling file descriptor in event_notifier_cleanup

From: Frediano Ziglio If rfd is equal to wfd the file descriptor is closed but rfd will still have the closed value. The EventNotifier structure should not be used again after calling event_notifier_cleanup or should be initialized again but make sure to not have dandling file descriptors around.

[PULL 01/19] qemu-options.hx: Update for reboot-timeout parameter

From: Han Han Since ee5d0f89d, -1 is not valid for the value of reboot-timeout. Update that in qemu-options doc. Signed-off-by: Han Han Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191015151451.727323-1-h...@redhat.com> Signed-off-by: Laurent Vivier ---

[PATCH v7 4/8] virtio: Free rnd virqueue at unrealize()

The function virtio_del_queue was not called at unrealize() callback. This was detected due to add an allocated element on the vq introduce in future commits (used_elems) and running address sanitizer memory leak detector. Signed-off-by: Eugenio Pérez --- hw/virtio/virtio-rng.c | 1 + 1 file ch

[PATCH v7 3/8] virtio: Free blk virqueues at unrealize()

The function virtio_del_queue was not called at unrealize() callback. This was detected due to add an allocated element on the vq introduce in future commits (used_elems) and running address sanitizer memory leak detector. Signed-off-by: Eugenio Pérez --- hw/block/virtio-blk.c | 5 + 1 file

[PULL 12/19] hw: Move TWL92230 device from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé The TWL92230 is an "energy management device" companion with a RTC. Since we mostly model the RTC, move it under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384

[PULL 06/19] hw/timer: Compile devices not target-dependent as common object

From: Philippe Mathieu-Daudé All these devices do not contain any target-specific. While most of them are arch-specific, they are shared between different targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, endianess, ...). Put them into common-obj-y to compile them once for all targ

[PULL 05/19] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms

From: Frediano Ziglio Signed-off-by: Frediano Ziglio Reviewed-by: Laurent Vivier Message-Id: <20191023122652.2999-3-fzig...@redhat.com> [lv: removed the two useless casts] Reviewed-by: Eric Blake Signed-off-by: Laurent Vivier --- util/qemu-timer.c | 6 +- 1 file changed, 1 insertion(+),

[PATCH v7 5/8] virtio: basic packed virtqueue support

From: Jason Wang This patch implements basic support for the packed virtqueue. Compare the split virtqueue which has three rings, packed virtqueue only have one which is supposed to have better cache utilization and more hardware friendly. Please refer virtio specification for more information.

[PULL 18/19] hw/rtc/xlnx-zynqmp-rtc: Remove unused "ptimer.h" include

From: Philippe Mathieu-Daudé The "hw/ptimer.h" header is not used, remove it. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384-14-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/rtc/xlnx-zynqmp-rtc.c | 1 -

[PULL 11/19] hw: Move sun4v hypervisor RTC from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé Move RTC devices under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Artyom Tarasenko Message-Id: <20191003230404.19384-7-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS

[PATCH v7 6/8] virtio: event suppression support for packed ring

From: Jason Wang This patch implements event suppression through device/driver area. Please refer virtio specification for more information. Signed-off-by: Wei Xu Signed-off-by: Jason Wang Signed-off-by: Eugenio Pérez --- hw/virtio/virtio.c | 142 +

[PULL 17/19] hw/rtc/mc146818: Include mc146818rtc_regs.h a bit less

From: Philippe Mathieu-Daudé Only 2 source files require the "mc146818rtc_regs.h" header. Instead of having it processed 12 times, by all objects using "mc146818rtc.h", include it directly where used. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <201910032304

[PULL 09/19] hw: Move M48T59 device from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé The M48T59 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191003230404.19384-5-phi...@redhat.com> Signed-off-by: Laurent Vivier --- MAINTAINERS

[PULL 19/19] hw/rtc/aspeed_rtc: Remove unused includes

From: Philippe Mathieu-Daudé The system include is already provided by "osdep.h" (the scripts/clean-includes file clean such headers). Commit 64552b6be47 suggests we don't need to include "hw/irq.h": Move the qemu_irq and qemu_irq_handler typedefs from hw/irq.h to qemu/typedefs.h, and

[PULL 15/19] hw: Move Exynos4210 RTC from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé Move RTC devices under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384-11-phi...@redhat.com> Signed-off-by: Laurent Vivier --- hw/rtc/Makefile.objs

[PULL 14/19] hw: Move Xilinx ZynqMP RTC from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé Move RTC devices under the hw/rtc/ subdirectory. Remove Alistair outdated email address (see commit c22e580c2ad). Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384-10-phi...@redhat.com> S

[PULL 08/19] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé The MC146818 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Use copyright statement from 80cabfad163 for "hw/rtc/mc146818rtc.h". Reviewed-by: Alistair Francis Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20

[PULL 13/19] hw: Move DS1338 device from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé The DS1338 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384-9-phi...@redhat.com> Signed-off-by: Laurent Vivier

[PATCH v7 7/8] vhost_net: enable packed ring support

From: Jason Wang Signed-off-by: Jason Wang Signed-off-by: Eugenio Pérez Reviewed-by: Jens Freimann --- hw/net/vhost_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index e975700f95..6b82803fa7 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vho

[PATCH v7 8/8] virtio: add property to enable packed virtqueue

From: Jason Wang Signed-off-by: Jason Wang Signed-off-by: Eugenio Pérez Reviewed-by: Jens Freimann --- include/hw/virtio/virtio.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index d123d5b181..40ddeafadb 100644

Re: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24

Patchew URL: https://patchew.org/QEMU/1571925835-31930-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/39] Misc (mostly x86) patches for 2019-10-24 Type: series Message-id: 1571925835-3193

[PULL 16/19] hw: Move Aspeed RTC from hw/timer/ to hw/rtc/ subdirectory

From: Philippe Mathieu-Daudé Move RTC devices under the hw/rtc/ subdirectory. Reviewed-by: Cédric Le Goater Reviewed-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Acked-by: Peter Maydell Message-Id: <20191003230404.19384-12-phi...@redhat.com> Signed-off-by: Laurent Vivier ---

[PATCH 1/1] target/arm: Add support for cortex-m7 CPU

This is derived from cortex-m4 description, adding DP support and FPv5 instructions with the corresponding flags in isar and mvfr2. Checked that it could successfully execute vrinta.f32 s15, s15 while cortex-m4 emulation rejects it with "illegal instruction". Signed-off-by: Christophe Lyon ---

Re: [PULL 00/11] MIPS queue for October 24th, 2019

On Thu, 24 Oct 2019 at 12:07, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit ea0ec714d3109e0d0523b9dacb38030e4cb142a8: > > Merge remote-tracking branch 'remotes/xtensa/tags/20191023-xtensa' into > staging (2019-10-24 09:55:01 +0100) > > are avai

Re: [PATCH v3 5/6] hppa: Add emulation of Artist graphics

Hi Mark, On Thu, Oct 24, 2019 at 09:51:31PM +0100, Mark Cave-Ayland wrote: > On 22/10/2019 21:59, Sven Schnelle wrote: > > > This adds emulation of Artist graphics good enough > > to get a Text console on both Linux and HP-UX. The > > X11 server from HP-UX also works. > > > > Signed-off-by: Sve

[PATCH 4/4] scsi-disk: add FUA support for COMPARE_AND_WRITE

It is implemented in the blk_aio_pwritev's callback function in a way similar to its emulation in scsi_write_do_fua function Signed-off-by: Yaowei Bai --- hw/scsi/scsi-disk.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 4bff862..

[PATCH 0/4] SCSI COMPARE_AND_WRITE support

Recently ceph/librbd added several interfaces to handle SCSI commands like COMPARE_AND_WRITE directly. However they were only be used in special scenarios, i.e. ISCSI. That involves more software components which makes the IO path longer and could bring more potential issues. Actually we're maintai

[PATCH 3/4] hw/scsi: add SCSI COMPARE_AND_WRITE support

This patch emulates COMPARE_AND_WRITE command with the BDRV_REQ_COMPARE_AND_WRITE flag introduced by last patch. It matches the SBC-4 standard except the FUA bit support, it'll be finished in the next patch. Note that cmd->xfer is set 2 * the number got by scsi_data_cdb_xfer so we could touch the

Re: [PATCH v3] net: add tulip (dec21143) driver

On 2019/10/23 下午4:42, Sven Schnelle wrote: This adds the basic functionality to emulate a Tulip NIC. Implemented are: - RX and TX functionality - Perfect Frame Filtering - Big/Little Endian descriptor support - 93C46 EEPROM support - LXT970 PHY Not implemented, mostly because i had no OS usi

[PATCH 1/4] block: add SCSI COMPARE_AND_WRITE support

Some storages(i.e. librbd) already have interfaces to handle some SCSI commands directly. This patch adds COMPARE_AND_WRITE command support through the write path in the block io layer by introducing a new element BDRV_REQ_COMPARE_AND_WRITE into BdrvRequestFlags which indicates a COMPARE_AND_WRITE

  1   2   3   4   5   >