Re: [PATCH v2 15/23] iotests/201: Create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/201 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/201 b/tests/qemu-iotests/201 > index 7abf740fe4..86fa37e714 100755 > --- a/tests/

Re: Default CPU models on s390x and ppc64

On 17.10.19 17:31, David Hildenbrand wrote: On 17.10.19 17:18, David Hildenbrand wrote: On 17.10.19 17:16, Jiri Denemark wrote: Hi David and David, I'm working on libvirt's support [1] for query-machines' default-cpu-type, which is supposed to return the type of the default CPU model that QEMU

Re: [PATCH v2 05/23] iotests: Let common.nbd create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > In addition, drop the nbd_unix_socket assignment in 241 because it does > not really do anything. Right, common.nbd is included afterwards, so it gets overwritten. Reviewed-by: Thomas Huth

Re: [PATCH v2 22/23] iotests/267: Create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/267 | 4 ++-- > tests/qemu-iotests/267.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 02/32] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

On 17/10/2019 17.31, Philippe Mathieu-Daudé wrote: > On 10/17/19 5:04 PM, Thomas Huth wrote: >> On 15/10/2019 18.26, Philippe Mathieu-Daudé wrote: >>> Move the KVM-related call to "sysemu/kvm.h". >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>>   include/hw/i386/pc.h | 1 - >>>   include/s

Re: [PATCH v2 13/23] iotests/192: Create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/192 | 4 ++-- > tests/qemu-iotests/192.out | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/8] hw/timer/sh_timer: Switch to transaction-based ptimer API

On 10/17/19 3:28 PM, Peter Maydell wrote: Switch the sh_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create

Re: [PATCH 4/8] hw/watchdog/milkymist-sysctl.c: Switch to transaction-based ptimer API

On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the milkymist-sysctl code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to

Re: [PATCH v2 20/23] iotests/223: Create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/223 | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Thomas Huth

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Thu, Oct 17, 2019 at 5:25 PM Vivek Goyal wrote: > > On Thu, Oct 17, 2019 at 01:23:57PM +0200, Miklos Szeredi wrote: > > On Thu, Oct 17, 2019 at 12:05 PM Stefan Hajnoczi > > wrote: > > > > > > On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote: > > > > Hello, > > > > > > > > I tes

Re: [PATCH 3/8] hw/timer/lm32_timer: Switch to transaction-based ptimer API

On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the lm32_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to creat

Re: [PATCH 1/4] target/arm: Vectorize USHL and SSHL

Richard Henderson writes: > These instructions shift left or right depending on the sign > of the input, and 7 bits are significant to the shift. This > requires several masks and selects in addition to the actual > shifts to form the complete answer. > > That said, the operation is still a sm

Re: Default CPU models on s390x and ppc64

On 17.10.19 18:13, Peter Maydell wrote: On Thu, 17 Oct 2019 at 17:09, David Hildenbrand wrote: The default model under KVM is "host", under TCG it's "qemu". We should not use "qemu" under KVM, although it might work on some setups ... Possibly a tangent, but on Arm the approach we used to dea

Re: [PATCH 6/8] hw/watchdog/etraxfs_timer.c: Switch to transaction-based ptimer API

On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the etraxfs_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to cr

Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support

On Thu, Oct 17, 2019 at 04:52:54PM +0200, Thomas Huth wrote: > On 11/10/2019 10.56, Stefan Hajnoczi wrote: > > Implement the VIRTIO 1.0 virtio-pci interface. The main change here is > > that the register layout is no longer a fixed layout in BAR 0. Instead > > we have to iterate of PCI Capabiliti

Re: [PATCH v2 7/7] libqos: add VIRTIO PCI 1.0 support

On 17/10/2019 18.07, Stefan Hajnoczi wrote: > On Thu, Oct 17, 2019 at 04:52:54PM +0200, Thomas Huth wrote: >> On 11/10/2019 10.56, Stefan Hajnoczi wrote: >>> Implement the VIRTIO 1.0 virtio-pci interface. The main change here is >>> that the register layout is no longer a fixed layout in BAR 0. I

Re: [Virtio-fs] [PATCH 2/2] virtiofsd: move to a new pid namespace

On Thu, Oct 17, 2019 at 10:45:53AM -0400, Vivek Goyal wrote: > On Wed, Oct 16, 2019 at 05:01:57PM +0100, Stefan Hajnoczi wrote: > > [..] > > + /* > > +* If the mounts have shared propagation then we want to opt out so our > > +* mount changes don't affect the parent mount namespace. > >

Re: [PATCH 0/3] hw/arm/raspi: Split the UART block from the AUX block

On Mon, 7 Oct 2019 at 18:06, Philippe Mathieu-Daudé wrote: > > The BCM2838 has many more peripherals than his little brother, > the BCM2837. With the raspi4, the Linux kernel takes more steps > to configure the various MUXed devices. At some point it started > to bug me, so I plan to add a dummy s

Re: [PATCH v2 16/23] iotests/205: Create socket in $SOCK_DIR

On 17/10/2019 15.31, Max Reitz wrote: > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/205 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205 > index 76f6c5fa2b..4bb2c21e8b 100755 > --- a/tests/

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On 10/17/19 9:45 AM, Christian Borntraeger wrote: On 17.10.19 16:21, Thomas Huth wrote: There is no USB on s390x, so running qemu-system-s390x with "-machine ...,usb=on" is certainly wrong. Emit a warning to make the users aware of their misconfiguration. Signed-off-by: Thomas Huth --- Aft

Re: [PATCH v4 1/4] block: support compressed write at generic layer

16.10.2019 19:28, Andrey Shinkevich wrote: > To inform the block layer about writing all the data compressed, we > introduce the 'compress' command line option. Based on that option, the > written data will be aligned by the cluster size at the generic layer. > > Suggested-by: Roman Kagan > Sugge

Re: [PATCH 1/8] hw/timer/puv3_ost.c: Switch to transaction-based ptimer API

On 10/17/19 3:28 PM, Peter Maydell wrote: Switch the puv3_ost code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to create

Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state

On 10/17/19 8:26 AM, Peter Maydell wrote: > Don't we also need to do something to rebuild the hflags > for M-profile writes to the memory mapped system registers? > For instance rebuild_hflags_m32() bakes in state which > cares about env->v7m.ccr, which is set via nvic_writel(), > but I don't see a

Re: [PATCH v6 3/9] target/arm: Allow SVE to be disabled via a CPU property

On Wed, Oct 16, 2019 at 10:54:02AM +0200, Andrew Jones wrote: > Since 97a28b0eeac14 ("target/arm: Allow VFP and Neon to be disabled via > a CPU property") we can disable the 'max' cpu model's VFP and neon > features, but there's no way to disable SVE. Add the 'sve=on|off' > property to give it that

[PATCH v3 0/9] tests/acceptance: Add tests for the PReP/40p machine

From: PhilMD Quick tests worth to avoid regressions with the 40p machine. idea from the "Maintainers, please tell us how to boot your machines" thread: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04177.html v3: addressed review comment from v2 v2: Split Travis job, added Hervé R-b t

Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

On 10/17/19 3:29 PM, Peter Maydell wrote: Switch the altera_timer code away from bottom-half based ptimers to the new transaction-based ptimer API. This just requires adding begin/commit calls around the various places that modify the ptimer state, and using the new ptimer_init() function to cre

Re: [PATCH v6 4/9] target/arm/cpu64: max cpu: Introduce sve properties

On Wed, Oct 16, 2019 at 10:54:03AM +0200, Andrew Jones wrote: > Introduce cpu properties to give fine control over SVE vector lengths. > We introduce a property for each valid length up to the current > maximum supported, which is 2048-bits. The properties are named, e.g. > sve128, sve256, sve384,

[PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386

Commit a6c7040fb09 restricted the rtc-reset-reinjection command to the I386 target. Restrict the "qapi/qapi-commands-misc-target.h" header to it too. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/mc146818rtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/mc14

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Thu, Oct 17, 2019 at 01:23:57PM +0200, Miklos Szeredi wrote: > On Thu, Oct 17, 2019 at 12:05 PM Stefan Hajnoczi wrote: > > > > On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote: > > > Hello, > > > > > > I test xattr operation on virtiofs using xfstest generic/062 > > > (with -o xa

[PATCH v3 9/9] .travis.yml: Let the avocado job run the 40p tests

Acked-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d0b9e099b9..69a37f7387 100644 --- a/.travis.yml +++ b/.travis.yml @@ -267,7 +267,7 @@ matrix: # Acceptance (Funct

[PATCH] vhost-user-scsi: implement handle_output

Originally, vhost-user-scsi did not implement a handle_output callback as that didn't seem necessary. Turns out it is. Depending on which other devices are presented to a VM, SeaBIOS may decide to map vhost-user-scsi devices on the 64-bit range of the address space. As a result, SeaBIOS will kick

Re: [PATCH v6 7/9] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features

On Wed, Oct 16, 2019 at 10:54:06AM +0200, Andrew Jones wrote: > kvm_arm_create_scratch_host_vcpu() takes a struct kvm_vcpu_init > parameter. Rather than just using it as an output parameter to > pass back the preferred target, use it also as an input parameter, > allowing a caller to pass a selecte

Re: [PATCH 5/8] hw/timer/altera_timer.c: Switch to transaction-based ptimer API

On Thu, 17 Oct 2019 at 17:09, Philippe Mathieu-Daudé wrote: > > On 10/17/19 3:29 PM, Peter Maydell wrote: > > -t->bh = qemu_bh_new(timer_hit, t); > > -t->ptimer = ptimer_init_with_bh(t->bh, PTIMER_POLICY_DEFAULT); > > +t->ptimer = ptimer_init(timer_hit, t, PTIMER_POLICY_DEFAULT); > > +

Re: [PATCH v6 6/9] target/arm/kvm64: max cpu: Enable SVE when available

On Wed, Oct 16, 2019 at 10:54:05AM +0200, Andrew Jones wrote: > Enable SVE in the KVM guest when the 'max' cpu type is configured > and KVM supports it. KVM SVE requires use of the new finalize > vcpu ioctl, so we add that now too. For starters SVE can only be > turned on or off, getting all vector

Re: Default CPU models on s390x and ppc64

On Thu, 17 Oct 2019 at 17:09, David Hildenbrand wrote: > The default model under KVM is "host", under TCG it's "qemu". We should > not use "qemu" under KVM, although it might work on some setups ... Possibly a tangent, but on Arm the approach we used to deal with "'-cpu host' only works for kvm"

[RFC PATCH v3 2/9] tests/acceptance: Fix wait_for_console_pattern() hangs

From: Philippe Mathieu-Daudé Because of a possible deadlock (QEMU waiting for the socket to become writable) let's close the console socket as soon as we stop to use it. Suggested-by: Cleber Rosa Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 1 + 1 file

Re: [PATCH v6 8/9] target/arm/cpu64: max cpu: Support sve properties with KVM

On Wed, Oct 16, 2019 at 10:54:07AM +0200, Andrew Jones wrote: > Extend the SVE vq map initialization and validation with KVM's > supported vector lengths when KVM is enabled. In order to determine > and select supported lengths we add two new KVM functions for getting > and setting the KVM_REG_ARM6

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Monday, October 14, 2019, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target/avr/translate.c | 132 + > 1 file changed, 132 insertions(+) > create mode 100644 target/avr/translate.c > > diff --git a/target/avr/translate.c b/target/av

[PATCH v3 4/9] tests/acceptance: Refactor exec_command_and_wait_for_pattern()

From: Philippe Mathieu-Daudé The same utility method is already present in two different test files, so let's consolidate it into a single utility function. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/avocado_qemu/__init__.py | 19 +++ tests/acceptance/boot_linux

Re: [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope

On Thursday, October 17, 2019, Philippe Mathieu-Daudé wrote: > On 10/17/19 5:16 PM, Aleksandar Markovic wrote: > >> On Tuesday, October 15, 2019, Philippe Mathieu-Daudé > > wrote: >> >> pc_gsi_create() is the single function that uses gsi_handler. >> Make it a st

Re: [Virtio-fs] [PATCH 0/2] virtiofsd: Two fix for xattr operation

On Thu, Oct 17, 2019 at 6:09 PM Stefan Hajnoczi wrote: > > On Thu, Oct 17, 2019 at 01:23:57PM +0200, Miklos Szeredi wrote: > > On Thu, Oct 17, 2019 at 12:05 PM Stefan Hajnoczi > > wrote: > > > > > > On Wed, Oct 16, 2019 at 07:37:52PM +0900, Misono Tomohiro wrote: > > > > Hello, > > > > > > > > I

[PATCH v3 8/9] tests/acceptance: Test Sandalfoot initrd on the PReP/40p

User case from: https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html Sandalfoot info: http://www.juneau-lug.org/sandalfoot.php Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé --- v3: - use avocado_qemu.wait_for_console_pattern (Cleber) - use exec_command_and_wait_for_p

Re: iotest failure -- test possibly not using sufficiently unique temp filename?

On Fri, 27 Sep 2019 at 17:44, Max Reitz wrote: > > On 27.09.19 18:39, Peter Maydell wrote: > > Hi; I just saw this iotest failure (on an s390x box, as it happens): > > > > TESTiotest-qcow2: 130 [fail] > > QEMU -- > > "/home/linux1/qemu/build/all/tests/qemu-iotests/../../s390x-softmm

Re: [PATCH v4 2/4] qcow2: Allow writing compressed data of multiple clusters

16.10.2019 19:28, Andrey Shinkevich wrote: > QEMU currently supports writing compressed data of the size equal to > one cluster. This patch allows writing QCOW2 compressed data that > exceed one cluster. Now, we split buffered data into separate clusters > and write them compressed using the existi

Re: [PATCH v6 5/9] target/arm/kvm64: Add kvm_arch_get/put_sve

On Wed, Oct 16, 2019 at 10:54:04AM +0200, Andrew Jones wrote: > These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the > swabbing is different than it is for fpsmid because the vector format > is a little-endian stream of words. > > Signed-off-by: Andrew Jones > Reviewed-by: Richard

[PATCH v3 1/9] Acceptance tests: refactor wait_for_console_pattern

From: Cleber Rosa The same utility method is already present in two different test files, so let's consolidate it into a single utility function. Signed-off-by: Cleber Rosa Message-Id: <20190916164011.7653-1-cr...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé [PMD: rebased fixing conflicts i

[PATCH v3 6/9] tests/acceptance: Test Open Firmware on the PReP/40p

User case from: https://tyom.blogspot.com/2019/04/aixprep-under-qemu-how-to.html Acked-by: David Gibson Acked-by: Artyom Tarasenko Tested-by: Cleber Rosa Reviewed-by: Cleber Rosa Signed-off-by: Philippe Mathieu-Daudé --- v3: use avocado_qemu.wait_for_console_pattern (Cleber) --- tests/accept

Re: [PATCH v6 9/9] target/arm/kvm: host cpu: Add support for sve properties

On Wed, Oct 16, 2019 at 10:54:08AM +0200, Andrew Jones wrote: > Allow cpu 'host' to enable SVE when it's available, unless the > user chooses to disable it with the added 'sve=off' cpu property. > Also give the user the ability to select vector lengths with the > sve properties. We don't adopt 'max

[PATCH v3 7/9] tests/acceptance: Test OpenBIOS on the PReP/40p

User case from: https://mail.coreboot.org/pipermail/openbios/2018-May/010360.html Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé --- v3: - use avocado_qemu.wait_for_console_pattern (Cleber) - use MD5 hash --- tests/acceptance/ppc_prep_40p.py | 32

[PATCH v3 3/9] tests/acceptance: Send on serial lines

Some firmwares don't parse the control character and expect a . Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py i

[PATCH v3 5/9] tests/acceptance: Add test that runs NetBSD 4.0 installer on PRep/40p

As of this commit, NetBSD 4.0 is very old. However it is enough to test the PRep/40p machine. User case from: http://mail-index.netbsd.org/port-prep/2017/04/11/msg000112.html Reviewed-by: Hervé Poussineau Acked-by: David Gibson Acked-by: Artyom Tarasenko Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v7 0/4] delete created files when block_crypto_co_create_opts_luks fails

Ping On 9/3/19 10:57 AM, Daniel Henrique Barboza wrote: Changes from previous version 6 [1]: - bdrv_delete_file() now uses BlockDriverState as a parameter rather than a filename string. [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00139.html Daniel Henrique Barboza (4): blo

Re: [PATCH v6 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state

On Thu, 17 Oct 2019 at 17:25, Richard Henderson wrote: > > On 10/17/19 8:26 AM, Peter Maydell wrote: > > Don't we also need to do something to rebuild the hflags > > for M-profile writes to the memory mapped system registers? > > For instance rebuild_hflags_m32() bakes in state which > > cares abo

Re: [PULL 00/23] tcg patch queue

On Thu, 17 Oct 2019 at 15:55, Richard Henderson wrote: > > On 10/13/19 3:25 PM, Richard Henderson wrote: > > The following changes since commit 9e5319ca52a5b9e84d55ad9c36e2c0b317a122bb: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging (2019-10-04 18:32:3

Re: [PATCH v4 4/4] tests/qemu-iotests: add case for block-stream compress

16.10.2019 19:28, Andrey Shinkevich wrote: > Add a case to the iotest #030 that tests the 'compress' option for a > block-stream job. > > Signed-off-by: Andrey Shinkevich > --- > tests/qemu-iotests/030 | 51 > +- > tests/qemu-iotests/030.out |

Re: [PATCH v4 3/4] tests/qemu-iotests: add case to write compressed data of multiple clusters

16.10.2019 19:28, Andrey Shinkevich wrote: > Add the test case to the iotest #214 that checks possibility of writing > compressed data of more than one cluster size. > > Signed-off-by: Andrey Shinkevich > --- > tests/qemu-iotests/214 | 35 +++ > tests/qemu-i

Re: [PATCH v7 0/4] delete created files when block_crypto_co_create_opts_luks fails

Ping On 9/3/19 10:57 AM, Daniel Henrique Barboza wrote: Changes from previous version 6 [1]: - bdrv_delete_file() now uses BlockDriverState as a parameter rather than a filename string. [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00139.html Daniel Henrique Barboza (4): blo

Re: [PATCH] hw/s390x: Emit a warning if user tried to enable USB

On 10/17/19 4:40 PM, Thomas Huth wrote: On 17/10/2019 16.34, Cornelia Huck wrote: On Thu, 17 Oct 2019 16:21:23 +0200 Thomas Huth wrote: There is no USB on s390x, so running qemu-system-s390x with "-machine ...,usb=on" is certainly wrong. Emit a warning to make the users aware of their misconf

[PATCH v7 01/20] target/arm: Split out rebuild_hflags_common

Create a function to compute the values of the TBFLAG_ANY bits that will be cached. For now, the env->hflags variable is not used, and the results are fed back to cpu_get_tb_cpu_state. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h| 29 ++

[PATCH v7 02/20] target/arm: Split out rebuild_hflags_a64

Create a function to compute the values of the TBFLAG_A64 bits that will be cached. For now, the env->hflags variable is not used, and the results are fed back to cpu_get_tb_cpu_state. Note that not all BTI related flags are cached, so we have to test the BTI feature twice -- once for those bits

[PATCH v7 00/20] target/arm: Reduce overhead of cpu_get_tb_cpu_state

Changes since v6: * Regen hflags in two more places for m-profile (patch 19). Changes since v5: * Fix the debug assertion ifdef in the final patch. * Add more calls to arm_rebuild_hflags: CPSR and M-profile These become two new patches, 18 & 19. * Update some comments per review. (Alex

[PATCH v7 17/20] target/arm: Rebuild hflags at MSR writes

Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 13 +++-- target/arm/translate.c | 28 +++- 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/target/

[PATCH v7 09/20] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state

We do not need to compute any of these values for M-profile. Further, XSCALE_CPAR overlaps VECSTRIDE so obviously the two sets must be mutually exclusive. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 21 ++--- 1 file changed, 14 insertions(

[PATCH v7 03/20] target/arm: Split out rebuild_hflags_common_32

Create a function to compute the values of the TBFLAG_A32 bits that will be cached, and are used by all profiles. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/target/arm/he

[PATCH v7 05/20] target/arm: Split out rebuild_hflags_m32

Create a function to compute the values of the TBFLAG_A32 bits that will be cached, and are used by M-profile. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 45 ++--- 1 file changed, 30 insertions(+), 15 deletions(-)

[PATCH v7 14/20] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state

By performing this store early, we avoid having to save and restore the register holding the address around any function calls. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/helper

[PATCH v7 04/20] target/arm: Split arm_cpu_data_is_big_endian

Set TBFLAG_ANY.BE_DATA in rebuild_hflags_common_32 and rebuild_hflags_a64 instead of rebuild_hflags_common, where we do not need to re-test is_a64() nor re-compute the various inputs. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h| 49

[PATCH v7 06/20] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state

Hoist the computation of some TBFLAG_A32 bits that only apply to M-profile under a single test for ARM_FEATURE_M. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 49 + 1 file changed, 23 insertions(+), 26 deletions(

[PATCH v7 11/20] target/arm: Hoist computation of TBFLAG_A32.VFPEN

There are 3 conditions that each enable this flag. M-profile always enables; A-profile with EL1 as AA64 always enables. Both of these conditions can easily be cached. The final condition relies on the FPEXC register which we are not prepared to cache. Reviewed-by: Alex Bennée Signed-off-by: Ri

[PATCH v7 12/20] target/arm: Add arm_rebuild_hflags

This function assumes nothing about the current state of the cpu, and writes the computed value to env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h| 6 ++ target/arm/helper.c | 30 ++ 2 files changed, 28 insertions(

[PATCH v7 07/20] target/arm: Split out rebuild_hflags_a32

Currently a trivial wrapper for rebuild_hflags_common_32. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 296a4b2232..d1cd54cc93 100644 --

[PATCH v7 13/20] target/arm: Split out arm_mmu_idx_el

Avoid calling arm_current_el() twice. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/internals.h | 9 + target/arm/helper.c| 12 +++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/target/arm/in

[PATCH v7 16/20] target/arm: Rebuild hflags at EL changes

Begin setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- linux-user/syscall.c| 1 + target/arm/cpu.c| 1 + target/arm/helper-a64.c | 3 +++ target/arm/helper.c | 2 ++ target/arm/machine.c| 1 + target/arm/op_helper.c |

[PATCH v7 08/20] target/arm: Split out rebuild_hflags_aprofile

Create a function to compute the values of the TBFLAG_ANY bits that will be cached, and are used by A-profile. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/target/arm/h

[PATCH v7 20/20] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state

This is the payoff. >From perf record -g data of ubuntu 18 boot and shutdown: BEFORE: - 23.02% 2.82% qemu-system-aar [.] helper_lookup_tb_ptr - 20.22% helper_lookup_tb_ptr + 10.05% tb_htable_lookup - 9.13% cpu_get_tb_cpu_state 3.20% aa64_va_parameters_both

[PATCH v7 10/20] target/arm: Simplify set of PSTATE_SS in cpu_get_tb_cpu_state

Hoist the variable load for PSTATE into the existing test vs is_a64. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index e2a62c

[PATCH v7 18/20] target/arm: Rebuild hflags at CPSR writes

Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/op_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index ccc2cecb46..b529d6c1bf 100644 --- a/target/arm/o

[PATCH v7 19/20] target/arm: Rebuild hflags for M-profile.

Continue setting, but not relying upon, env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v7: Add rebuilds for v7m_msr and nvic_writel to v7m.ccr. --- hw/intc/armv7m_nvic.c | 1 + target/arm/m_helper.c | 6 ++ target/arm/translate.c | 5 - 3 files changed, 11

[PATCH v7 15/20] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32})

This functions are given the mode and el state of the cpu and writes the computed value to env->hflags. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.h | 4 target/arm/helper.c | 24 2 files changed, 28 insertions(+) diff --git a

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Thu, Oct 17, 2019 at 8:25 PM Aleksandar Markovic wrote: > > > > On Monday, October 14, 2019, Michael Rolnik wrote: >> >> Signed-off-by: Michael Rolnik >> --- >> target/avr/translate.c | 132 + >> 1 file changed, 132 insertions(+) >> create mode 100644

Re: [PATCH] migration: savevm_state_insert_handler: constant-time element insertion

On Thu, Oct 17, 2019 at 10:43:08AM +0200, Juan Quintela wrote: > Scott Cheloha wrote: > > > Registering a SaveStateEntry object via savevm_state_insert_handler() > > is an O(n) operation because the list is a priority queue maintained by > > walking the list from head to tail to find a suitable i

Re: [PATCH for 4.2 v6 00/54] Support for TCG plugins

Patchew URL: https://patchew.org/QEMU/20191017131615.19660-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 4.2 v6 00/54] Support for TCG plugins Type: series Message-id: 20191017131615.19660-1-alex.

Re: [PULL v2 00/19] Bitmaps patches

On 10/17/19 7:07 AM, Peter Maydell wrote: > On Mon, 14 Oct 2019 at 20:29, John Snow wrote: >> >> The following changes since commit c760cb77e511eb05094df67c1b30029a952efa35: >> >> Merge remote-tracking branch >> 'remotes/dgilbert/tags/pull-migration-20191011a' into staging (2019-10-14 >> 16

Re: [PATCH] configure: Require Python >= 3.5

On 10/17/19 7:21 AM, Kevin Wolf wrote: > Am 17.10.2019 um 00:48 hat John Snow geschrieben: >> >> >> On 10/16/19 6:42 PM, Eduardo Habkost wrote: >>> Python 3.5 is the oldest Python version available on our >>> supported build platforms, and Python 2 end of life will be 3 >>> weeks after the plann

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

> > > >> +static TCGv cpu_Cf; > >> +static TCGv cpu_Zf; > >> +static TCGv cpu_Nf; > >> +static TCGv cpu_Vf; > >> +static TCGv cpu_Sf; > >> +static TCGv cpu_Hf; > >> +static TCGv cpu_Tf; > >> +static TCGv cpu_If; > >> + > > > > > > Hello, Michael, > > > > Is there any particular reason or motivation

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

Oh, there's no problem checking the file once it's on the local filesystem: $ wget http://10.193.37.117/cloud/bionic-server-cloudimg-amd64.img --2019-10-17 17:51:33-- http://10.193.37.117/cloud/bionic-server-cloudimg-amd64.img Connecting to 10.193.37.117:80... connected. HTTP request sent, await

[Bug 1848556] [NEW] qemu-img check failing on remote image in Eoan

Public bug reported: The "qemu-img check" function is failing on remote (HTTP-hosted) images, beginning with Ubuntu 19.10 (qemu-utils version 1:4.0+dfsg-0ubuntu9). With previous versions, through Ubuntu 19.04/qemu-utils version 1:3.1 +dfsg-2ubuntu3.5, the following worked: $ /usr/bin/qemu-img che

Re: [RFC 3/5] vfio/pci: Respond to KVM irqchip change notifier

On Thu, 17 Oct 2019 16:42:16 +1100 David Gibson wrote: > VFIO PCI devices already respond to the pci intx routing notifier, in order > to update kernel irqchip mappings when routing is updated. However this > won't handle the case where the irqchip itself is replaced by a different > model while

Re: [PATCH v32 04/13] target/avr: Add instruction translation - Registers definition

On Thu, Oct 17, 2019 at 11:17 PM Aleksandar Markovic wrote: >> >> >> >> +static TCGv cpu_Cf; >> >> +static TCGv cpu_Zf; >> >> +static TCGv cpu_Nf; >> >> +static TCGv cpu_Vf; >> >> +static TCGv cpu_Sf; >> >> +static TCGv cpu_Hf; >> >> +static TCGv cpu_Tf; >> >> +static TCGv cpu_If; >> >> + >> > >>

[PATCH v2 0/2] migration: faster savevm_state_handler_insert()

The savevm_state.handlers queue of SaveStateEntry objects is a priority queue with an O(n) insertion cost. This is makes startup extremely slow when a VM has many such objects to register. For instance, a ppc64 VM with a large (8T+) maxmem needs to register tens of thousands of SaveStateEntry han

[PATCH v2 1/2] migration: add savevm_state_handler_remove()

Create a function to abstract common logic needed when removing a SaveStateEntry element from the savevm_state.handlers queue. For now we just remove the element. Soon it will involve additional cleanup. Signed-off-by: Scott Cheloha --- migration/savevm.c | 9 +++-- 1 file changed, 7 inser

[PATCH v2 2/2] migration: savevm_state_handler_insert: constant-time element insertion

savevm_state's SaveStateEntry TAILQ is a priority queue. Priority sorting is maintained by searching from head to tail for a suitable insertion spot. Insertion is thus an O(n) operation. If we instead keep track of the head of each priority's subqueue within that larger queue we can reduce this

Re: [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__()

"fields" in the commit message. On 10/16/19 3:24 PM, Eduardo Habkost wrote: > This makes the formatting code simpler, and safer if we change > the type of self.value from str to bytes. > > Signed-off-by: Eduardo Habkost > --- > tests/image-fuzzer/qcow2/layout.py | 4 ++-- > 1 file changed, 2 in

Re: [PATCH 00/10] image-fuzzer: Port to Python 3

On 10/16/19 3:24 PM, Eduardo Habkost wrote: > This series ports image-fuzzer to Python 3. > > Eduardo Habkost (10): > image-fuzzer: Open image files in binary mode > image-fuzzer: Write bytes instead of string to image file > image-fuzzer: Explicitly use integer division operator > imag

Re: [PATCH v1 0/5] target/arm/kvm: Provide an option to adjust virtual time

Hi Drew, Thank you for posting the patches, they seems to work well because the softlockup is gone and the timestamp jump of dmesg and ftrace record also disappeared after the guest is virsh resume'ed. Let me add comments. I think the kvm-adjvtime behavior should be the default. How about introdu

Re: [PATCH 00/10] image-fuzzer: Port to Python 3

On Thu, Oct 17, 2019 at 05:11:29PM -0400, John Snow wrote: > > > On 10/16/19 3:24 PM, Eduardo Habkost wrote: > > This series ports image-fuzzer to Python 3. > > > > Eduardo Habkost (10): > > image-fuzzer: Open image files in binary mode > > image-fuzzer: Write bytes instead of string to imag

[PULL v3 00/19] Bitmaps patches

The following changes since commit f22f553efffd083ff624be116726f843a39f1148: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20191013' into staging (2019-10-17 16:48:56 +0100) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request for y

[PULL v3 01/19] util/hbitmap: strict hbitmap_reset

From: Vladimir Sementsov-Ogievskiy hbitmap_reset has an unobvious property: it rounds requested region up. It may provoke bugs, like in recently fixed write-blocking mode of mirror: user calls reset on unaligned region, not keeping in mind that there are possible unrelated dirty bytes, covered by

[PULL v3 05/19] block/dirty-bitmap: drop meta

From: Vladimir Sementsov-Ogievskiy Drop meta bitmaps, as they are unused. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Message-id: 20190916141911.5255-2-vsement...@virtuozzo.com Signed-off-by: John Snow --- include/block/dirty-bitmap.h | 5 block/dirty-bitmap.c

[PULL v3 18/19] MAINTAINERS: Add Vladimir as a reviewer for bitmaps

I already try to make sure all bitmaps patches have been reviewed by both Red Hat and Virtuozzo anyway, so this formalizes the arrangement. Fam meanwhile is no longer as active, so I am removing him as a co-maintainer simply to reflect the current practice. Signed-off-by: John Snow Reviewed-by:

<    1   2   3   4   5   >