Patchew URL: https://patchew.org/QEMU/20191017131615.19660-1-alex.ben...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH for 4.2 v6 00/54] Support for TCG plugins Type: series Message-id: 20191017131615.19660-1-alex.ben...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20191017185110.539-1-richard.hender...@linaro.org -> patchew/20191017185110.539-1-richard.hender...@linaro.org Switched to a new branch 'test' 424fada scripts/checkpatch.pl: don't complain about (foo, /* empty */) e435145 .travis.yml: add --enable-plugins tests 800ea86 include/exec: wrap cpu_ldst.h in CONFIG_TCG cace239 accel/stubs: reduce headers from tcg-stub 17ea011 tests/plugin: add hotpages to analyse memory access patterns d1e0501 tests/plugin: add instruction execution breakdown 5e851ac tests/plugin: add a hotblocks plugin 031417f tests/tcg: enable plugin testing cd80d32 tests/tcg: drop test-i386-fprem from TESTS when not SLOW 836d35e tests/tcg: move "virtual" tests to EXTRA_TESTS e58c3d7 tests/tcg: set QEMU_OPTS for all cris runs afdfac7 tests/tcg/Makefile.target: fix path to config-host.mak efa9ea6 tests/plugin: add sample plugins c996ea3 linux-user: support -plugin option 78836ba vl: support -plugin option a1403cc plugin: add qemu_plugin_outs helper 55a654e plugin: add qemu_plugin_insn_disas helper 1aece9d plugin: expand the plugin_init function to include an info block 247bda5 plugin: add API symbols to qemu-plugins.symbols d6b63ea configure: add --enable-plugins 3aee2bc translator: inject instrumentation from plugins c521ff1 target/openrisc: fetch code with translator_ld afb1f51 target/xtensa: fetch code with translator_ld d5c9d50 target/sparc: fetch code with translator_ld 9d57fb8 target/riscv: fetch code with translator_ld 7aa7c68 target/alpha: fetch code with translator_ld 8d6a86c target/m68k: fetch code with translator_ld 6568577 target/hppa: fetch code with translator_ld 50cf013 target/i386: fetch code with translator_ld 01c5eeb target/sh4: fetch code with translator_ld 907646f target/ppc: fetch code with translator_ld 9526a0d target/arm: fetch code with translator_ld 3fe9ad0 translator: add translator_ld{ub,sw,uw,l,q} 81c8125 plugin-gen: add plugin_insn_append bd1b9b0 cpu: hook plugin vcpu events 7fa995f *-user: plugin syscalls c2af9e4 *-user: notify plugin of exit 3d94758 translate-all: notify plugin code of tb_flush d9a108b plugins: implement helpers for resolving hwaddr 81e3a25 tcg: let plugins instrument virtual memory accesses fe8a752 atomic_template: add inline trace/plugin helpers 87cdf09 plugin-gen: add module for TCG-related code 85a2f31 tcg: add tcg_gen_st_ptr 0f2859a cputlb: introduce get_page_addr_code_hostp 3f80bfe cputlb: document get_page_addr_code f922c60 queue: add QTAILQ_REMOVE_SEVERAL 2b99a40 plugin: add implementation of the api 7530e15 plugin: add core code 5a3bcca plugin: add user-facing API 2edfb61 docs/devel: add plugins.rst design document 047e572 translate-all: use cpu_in_exclusive_work_context() in tb_flush 115a3d6 cpu: introduce cpu_in_exclusive_context() 31eb5a5 trace: add mmu_index to mem_info 02b2b09 trace: expand mem_info:size_shift to 4 bits === OUTPUT BEGIN === 1/54 Checking commit 02b2b09bb33a (trace: expand mem_info:size_shift to 4 bits) 2/54 Checking commit 31eb5a5236bf (trace: add mmu_index to mem_info) 3/54 Checking commit 115a3d682ea4 (cpu: introduce cpu_in_exclusive_context()) 4/54 Checking commit 047e57223d83 (translate-all: use cpu_in_exclusive_work_context() in tb_flush) 5/54 Checking commit 2edfb615818c (docs/devel: add plugins.rst design document) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 5/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/54 Checking commit 5a3bcca9a3f2 (plugin: add user-facing API) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 WARNING: architecture specific defines should be avoided #41: FILE: include/qemu/qemu-plugin.h:22: +#if defined _WIN32 || defined __CYGWIN__ WARNING: architecture specific defines should be avoided #49: FILE: include/qemu/qemu-plugin.h:30: + #if __GNUC__ >= 4 total: 0 errors, 3 warnings, 351 lines checked Patch 6/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/54 Checking commit 7530e151b9fd (plugin: add core code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #99: new file mode 100644 ERROR: externs should be avoided in .c files #947: FILE: plugins/loader.c:63: +extern struct qemu_plugin_state plugin; total: 1 errors, 1 warnings, 1284 lines checked Patch 7/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/54 Checking commit 2b99a4056e5e (plugin: add implementation of the api) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 ERROR: "foo * bar" should be "foo *bar" #295: FILE: plugins/api.c:255: +static MachineState * get_ms(void) total: 1 errors, 1 warnings, 290 lines checked Patch 8/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/54 Checking commit f922c60682c5 (queue: add QTAILQ_REMOVE_SEVERAL) WARNING: Block comments use a leading /* on a separate line #32: FILE: include/qemu/queue.h:431: + } while (/*CONSTCOND*/0) total: 0 errors, 1 warnings, 16 lines checked Patch 9/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/54 Checking commit 3f80bfe2f96d (cputlb: document get_page_addr_code) 11/54 Checking commit 0f2859a5487c (cputlb: introduce get_page_addr_code_hostp) 12/54 Checking commit 85a2f31fc0d0 (tcg: add tcg_gen_st_ptr) 13/54 Checking commit 87cdf0983ce9 (plugin-gen: add module for TCG-related code) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 1123 lines checked Patch 13/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/54 Checking commit fe8a752ceac1 (atomic_template: add inline trace/plugin helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 299 lines checked Patch 14/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/54 Checking commit 81e3a259f840 (tcg: let plugins instrument virtual memory accesses) WARNING: line over 80 characters #111: FILE: include/exec/cpu_ldst_template.h:91: + uint16_t meminfo = trace_mem_build_info(SHIFT, false, MO_TE, false, mmu_idx); total: 0 errors, 1 warnings, 325 lines checked Patch 15/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/54 Checking commit d9a108ba74c8 (plugins: implement helpers for resolving hwaddr) ERROR: line over 90 characters #61: FILE: accel/tcg/cputlb.c:1279: + data->v.io.section = iotlb_to_section(cpu, iotlbentry->addr, iotlbentry->attrs); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 WARNING: line over 80 characters #137: FILE: include/qemu/qemu-plugin.h:294: +uint64_t qemu_plugin_hwaddr_device_offset(const struct qemu_plugin_hwaddr *haddr); WARNING: line over 80 characters #193: FILE: plugins/api.c:279: +uint64_t qemu_plugin_hwaddr_device_offset(const struct qemu_plugin_hwaddr *haddr) WARNING: line over 80 characters #198: FILE: plugins/api.c:284: + ram_addr_t ram_addr = qemu_ram_addr_from_host((void *) haddr->v.ram.hostaddr); WARNING: line over 80 characters #200: FILE: plugins/api.c:286: + error_report("Bad ram pointer %"PRIx64"", haddr->v.ram.hostaddr); total: 1 errors, 5 warnings, 174 lines checked Patch 16/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/54 Checking commit 3d94758e07c4 (translate-all: notify plugin code of tb_flush) 18/54 Checking commit c2af9e46b38b (*-user: notify plugin of exit) 19/54 Checking commit 7fa995fbf335 (*-user: plugin syscalls) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 0 errors, 1 warnings, 127 lines checked Patch 19/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/54 Checking commit bd1b9b025e4d (cpu: hook plugin vcpu events) 21/54 Checking commit 81c8125e35cd (plugin-gen: add plugin_insn_append) 22/54 Checking commit 3fe9ad03d7aa (translator: add translator_ld{ub,sw,uw,l,q}) ERROR: space prohibited before that close parenthesis ')' #118: FILE: include/exec/translator.h:198: +GEN_TRANSLATOR_LD(translator_ldub, ldb, ldub, uint8_t, 0, /* no swap */ ) total: 1 errors, 0 warnings, 95 lines checked Patch 22/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/54 Checking commit 9526a0da1e1c (target/arm: fetch code with translator_ld) 24/54 Checking commit 907646f9be4b (target/ppc: fetch code with translator_ld) 25/54 Checking commit 01c5eebe48bf (target/sh4: fetch code with translator_ld) 26/54 Checking commit 50cf013b7e17 (target/i386: fetch code with translator_ld) 27/54 Checking commit 656857780e94 (target/hppa: fetch code with translator_ld) 28/54 Checking commit 8d6a86c77096 (target/m68k: fetch code with translator_ld) 29/54 Checking commit 7aa7c680b9f8 (target/alpha: fetch code with translator_ld) 30/54 Checking commit 9d57fb88230d (target/riscv: fetch code with translator_ld) 31/54 Checking commit d5c9d509ef57 (target/sparc: fetch code with translator_ld) 32/54 Checking commit afb1f511a450 (target/xtensa: fetch code with translator_ld) 33/54 Checking commit c521ff16b95d (target/openrisc: fetch code with translator_ld) 34/54 Checking commit 3aee2bc39a59 (translator: inject instrumentation from plugins) 35/54 Checking commit d6b63ea4d0f2 (configure: add --enable-plugins) 36/54 Checking commit 247bda5f4517 (plugin: add API symbols to qemu-plugins.symbols) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #136: new file mode 100644 total: 0 errors, 1 warnings, 166 lines checked Patch 36/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 37/54 Checking commit 1aece9df1a24 (plugin: expand the plugin_init function to include an info block) ERROR: line over 90 characters #84: FILE: plugins/loader.c:65: +typedef int (*qemu_plugin_install_func_t)(qemu_plugin_id_t, const qemu_info_t *, int, char **); total: 1 errors, 0 warnings, 100 lines checked Patch 37/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 38/54 Checking commit 55a654edc5a1 (plugin: add qemu_plugin_insn_disas helper) 39/54 Checking commit a1403cc00e88 (plugin: add qemu_plugin_outs helper) 40/54 Checking commit 78836bac5a5a (vl: support -plugin option) 41/54 Checking commit c996ea306b37 (linux-user: support -plugin option) 42/54 Checking commit efa9ea66c152 (tests/plugin: add sample plugins) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 42/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 43/54 Checking commit afdfac7a7739 (tests/tcg/Makefile.target: fix path to config-host.mak) 44/54 Checking commit e58c3d7ecfbe (tests/tcg: set QEMU_OPTS for all cris runs) 45/54 Checking commit 836d35ed6625 (tests/tcg: move "virtual" tests to EXTRA_TESTS) 46/54 Checking commit cd80d326a9ea (tests/tcg: drop test-i386-fprem from TESTS when not SLOW) 47/54 Checking commit 031417f8a076 (tests/tcg: enable plugin testing) 48/54 Checking commit 5e851ac30abd (tests/plugin: add a hotblocks plugin) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 WARNING: line over 80 characters #101: FILE: tests/plugin/hotblocks.c:64: + g_string_append_printf(report, "%#016"PRIx64", %d, %ld, %"PRId64"\n", total: 0 errors, 2 warnings, 150 lines checked Patch 48/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 49/54 Checking commit d1e0501fbbde (tests/plugin: add instruction execution breakdown) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #100: FILE: tests/plugin/howvec.c:69: + { " Add/Sub (imm,tags)","asit", 0x1f800000, 0x11800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #123: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #123: FILE: tests/plugin/howvec.c:92: + { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #125: FILE: tests/plugin/howvec.c:94: + { " AdvSimd ldst++", "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #129: FILE: tests/plugin/howvec.c:98: + { " ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS}, ^ ERROR: space required after that ',' (ctx:VxV) #133: FILE: tests/plugin/howvec.c:102: + { " ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS}, ^ WARNING: line over 80 characters #154: FILE: tests/plugin/howvec.c:123: + { "Unclassified", "unclas", 0x00000000, 0x00000000, COUNT_INDIVIDUAL}, WARNING: line over 80 characters #163: FILE: tests/plugin/howvec.c:132: + { "Unclassified", "unclas", 0x00000000, 0x00000000, COUNT_INDIVIDUAL}, WARNING: line over 80 characters #168: FILE: tests/plugin/howvec.c:137: + { "Unclassified", "unclas", 0x00000000, 0x00000000, COUNT_INDIVIDUAL}, ERROR: that open brace { should be on the previous line #178: FILE: tests/plugin/howvec.c:147: +static ClassSelector class_tables[] = +{ WARNING: line over 80 characters #213: FILE: tests/plugin/howvec.c:182: + g_string_append_printf(report, "Class: %-24s\tcounted individually\n", ERROR: space required after that ',' (ctx:VxV) #229: FILE: tests/plugin/howvec.c:198: + g_string_append_printf(report,"Individual Instructions:\n"); ^ WARNING: line over 80 characters #235: FILE: tests/plugin/howvec.c:204: + g_string_append_printf(report, "Instr: %-24s\t(%ld hits)\t(op=%#08x/%s)\n", ERROR: "foo * bar" should be "foo *bar" #259: FILE: tests/plugin/howvec.c:228: +static uint64_t * find_counter(struct qemu_plugin_insn *insn) WARNING: line over 80 characters #295: FILE: tests/plugin/howvec.c:264: + GUINT_TO_POINTER(opcode)); total: 9 errors, 7 warnings, 359 lines checked Patch 49/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 50/54 Checking commit 17ea0115341e (tests/plugin: add hotpages to analyse memory access patterns) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #27: new file mode 100644 WARNING: line over 80 characters #107: FILE: tests/plugin/hotpages.c:76: + g_autoptr(GString) report = g_string_new("Addr, RCPUs, Reads, WCPUs, Writes\n"); total: 0 errors, 2 warnings, 198 lines checked Patch 50/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 51/54 Checking commit cace23961aa9 (accel/stubs: reduce headers from tcg-stub) 52/54 Checking commit 800ea86d70fb (include/exec: wrap cpu_ldst.h in CONFIG_TCG) 53/54 Checking commit e435145d5f74 (.travis.yml: add --enable-plugins tests) 54/54 Checking commit 424fada85333 (scripts/checkpatch.pl: don't complain about (foo, /* empty */)) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191017131615.19660-1-alex.ben...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
