[PATCH v16 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-10-10 Thread Ganesh Goudar
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error belon

[PATCH v16 1/7] Wrapper function to wait on condition for the main loop mutex

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by:

[PATCH v16 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine ch

[PATCH v16 4/7] target/ppc: Build rtas error log upon an MCE

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the gu

[PATCH v16 3/7] target/ppc: Handle NMI guest exit

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reaso

[PATCH v16 2/7] ppc: spapr: Introduce FWNMI capability

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad Introduce the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200

[PATCH v16 7/7] ppc: spapr: Activate the FWNMI functionality

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index eac3123d83..d27c1f1

[PATCH v16 6/7] migration: Include migration support for machine check handling

2019-10-10 Thread Ganesh Goudar
From: Aravinda Prasad This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware. [Do not set

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-10 Thread Markus Armbruster
Paolo Bonzini writes: > On 09/10/19 18:44, Mario Smarduch wrote: >> }; >> @@ -1263,6 +1267,7 @@ static void realtime_init(void) >> static void configure_msg(QemuOpts *opts) >> { >> enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true); >> +enable_guestname_msg = qemu_opt_g

Re: [PATCH v3] migration: Support gtree migration

2019-10-10 Thread Auger Eric
Hi Juan, On 10/5/19 12:34 AM, Juan Quintela wrote: > Eric Auger wrote: >> Introduce support for GTree migration. A custom save/restore >> is implemented. Each item is made of a key and a data. >> >> If the key is a pointer to an object, 2 VMSDs are passed into >> the GTree VMStateField. >> >> Whe

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread Thomas Huth
On 10/10/2019 00.43, John Snow wrote: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. > > Either way, we don't need this. > > Libvirt-checked-by: Peter Krempa > Signed-of

Re: [PATCH v3] migration: Support gtree migration

2019-10-10 Thread Auger Eric
Hi Peter, On 10/9/19 8:28 AM, Peter Xu wrote: > On Fri, Oct 04, 2019 at 01:20:25PM +0200, Eric Auger wrote: >> Introduce support for GTree migration. A custom save/restore >> is implemented. Each item is made of a key and a data. >> >> If the key is a pointer to an object, 2 VMSDs are passed into

Re: [PATCH] monitor/qmp: resume monitor when clearing its queue

2019-10-10 Thread Wolfgang Bumiller
On Wed, Oct 09, 2019 at 09:18:04PM +0200, Markus Armbruster wrote: > Wolfgang Bumiller writes: > > > On Wed, Oct 09, 2019 at 10:39:44AM +0200, Markus Armbruster wrote: > >> Cc: Marc-André for additional monitor and chardev expertise. > >> > >> Wolfgang Bumiller writes: > >> > >> > When a monit

[PATCH] error: Fix -msg timestamp default

2019-10-10 Thread Markus Armbruster
-msg parameter "timestamp" defaults to "off" if you don't specify msg, and to "on" if you do. Messed up right in commit 5e2ac51917 "add timestamp to error_report()". Mostly harmless, because "timestamp" is the only parameter, so "if you do" is "-msg ''", which nobody does. Change the default to

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-10 Thread Markus Armbruster
I don't think merging this via qemu-trivial is a good idea. First, it's not sufficiently trivial, as we shall see below. Second, the code in question has a maintainer willing to review and merge patches: me. I can't always review as quickly as we all would like; sorry about that. Mario Smarduch

Re: [PATCH v4] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-10 Thread Alex Bennée
David Hildenbrand writes: > MVCL is interruptible and we should check for interrupts and process > them after writing back the variables to the registers. Let's check > for any exit requests and exit to the main loop. Introduce a new helper > function for that: cpu_loop_exit_requested(). > > Wh

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread Markus Armbruster
John Snow writes: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. > > Either way, we don't need this. > > Libvirt-checked-by: Peter Krempa > Signed-off-by: John Snow Re

Re: [PATCH] monitor/qmp: resume monitor when clearing its queue

2019-10-10 Thread Markus Armbruster
Wolfgang Bumiller writes: > On Wed, Oct 09, 2019 at 09:18:04PM +0200, Markus Armbruster wrote: >> Wolfgang Bumiller writes: >> >> > On Wed, Oct 09, 2019 at 10:39:44AM +0200, Markus Armbruster wrote: >> >> Cc: Marc-André for additional monitor and chardev expertise. >> >> >> >> Wolfgang Bumille

Re: [PATCH v7 00/12] Introduce the microvm machine type

2019-10-10 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Tue, Oct 08, 2019 at 03:55:26PM +0200, Sergio Lopez wrote: >> Microvm is a machine type inspired by Firecracker and constructed >> after the its machine model. >> >> It's a minimalist machine type without PCI nor ACPI support, designed >> for short-lived guests.

Re: [RFC PATCH 12/12] virt/acpi: add SDEI table if SDEI is enabled

2019-10-10 Thread Igor Mammedov
On Tue, 24 Sep 2019 23:21:51 +0800 Heyi Guo wrote: > Add SDEI table if SDEI is enabled, so that guest OS can get aware and > utilize the interfaces. > > Signed-off-by: Heyi Guo > Cc: Peter Maydell > Cc: Dave Martin > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: James Morse > Cc: Shannon Zhao

Re: [PATCH v4 02/10] hw/core: create Resettable QOM interface

2019-10-10 Thread Damien Hedde
On 9/27/19 3:07 PM, Peter Maydell wrote: > On Tue, 24 Sep 2019 at 12:21, Damien Hedde wrote: > > My takes: > * I think we should keep the reset type. Among other things, >we probably want a reset type for "PCI bus reset" and >"SCSI bus reset", when we come to conversion of those > * I d

Re: [PATCH 4/5] travis.yml: Fix the ccache lines

2019-10-10 Thread Thomas Huth
On 09/10/2019 21.04, Philippe Mathieu-Daudé wrote: > On 10/9/19 7:07 PM, Thomas Huth wrote: >> The "command -v ccache && ccache ..." likely were supposed to test >> the availability of ccache before running the program. But this >> shell construct causes Travis to abort if ccache is not available.

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Igor Mammedov
On Wed, 9 Oct 2019 23:01:21 +0200 Laszlo Ersek wrote: > On 10/08/19 17:59, Igor Mammedov wrote: > > On Tue, 8 Oct 2019 12:52:58 +0200 > > Laszlo Ersek wrote: > > > >> FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > >> due to historical reasons. That value is not

Re: [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface

2019-10-10 Thread Michael S. Tsirkin
On Wed, Oct 09, 2019 at 09:22:49AM -0400, Igor Mammedov wrote: > As an alternative to passing to firmware topology info via new fwcfg files > so it could recreate APIC IDs based on it and order CPUs are enumerated, > > extend CPU hotplug interface to return APIC ID as response to the new command >

Re: [PATCH 3/4] hw/i386: add facility to expose CPU topology over fw-cfg

2019-10-10 Thread Michael S. Tsirkin
On Tue, Oct 08, 2019 at 05:59:31PM +0200, Igor Mammedov wrote: > On Tue, 8 Oct 2019 12:52:58 +0200 > Laszlo Ersek wrote: > > > FW_CFG_MAX_CPUS exposes the (exclusive) maximum APIC ID to guest firmware, > > due to historical reasons. That value is not useful to edk2, however. For > > supporting V

[PATCH 0/2] qcow2: Limit total allocation range to INT_MAX

2019-10-10 Thread Max Reitz
Hi, While looking for why handle_alloc_space() seems to cause issues on ppc64le+XFS (performance degradation and data corruption), I spotted this other issue. It isn’t as bad, but still needs fixing. See patch 1 for what is fixed and patch 2 for what breaks otherwise. Max Reitz (2): qcow2: L

[PATCH 1/2] qcow2: Limit total allocation range to INT_MAX

2019-10-10 Thread Max Reitz
When the COW areas are included, the size of an allocation can exceed INT_MAX. This is kind of limited by handle_alloc() in that it already caps avail_bytes at INT_MAX, but the number of clusters still reflects the original length. This can have all sorts of effects, ranging from the storage laye

[PATCH 2/2] iotests: Test large write request to qcow2 file

2019-10-10 Thread Max Reitz
Without HEAD^, the following happens when you attempt a large write request to a qcow2 file such that the number of bytes covered by all clusters involved in a single allocation will exceed INT_MAX: (A) handle_alloc_space() decides to fill the whole area with zeroes and fails because bdrv_co_p

Re: [PATCH v4] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-10 Thread David Hildenbrand
On 10.10.19 10:26, Alex Bennée wrote: > > David Hildenbrand writes: > >> MVCL is interruptible and we should check for interrupts and process >> them after writing back the variables to the registers. Let's check >> for any exit requests and exit to the main loop. Introduce a new helper >> funct

RE: [PATCH v6 4/4] colo: Update Documentation for continuous replication

2019-10-10 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Wednesday, October 9, 2019 11:17 PM > To: Zhang, Chen > Cc: qemu-devel ; Jason Wang > ; Wen Congyang ; > Xie Changlong ; Kevin Wolf > ; Max Reitz ; qemu-block > > Subject: Re: [PATCH v6 4/4] colo: Update Documentation for continuous > re

Re: [PATCH 5/5] travis.yml: Compile on arm64, too

2019-10-10 Thread Alex Bennée
Thomas Huth writes: > On 09/10/2019 21.06, Philippe Mathieu-Daudé wrote: >> On 10/9/19 7:07 PM, Thomas Huth wrote: >>> Travis now features an arm64 build host, so let's check compilation >>> there, too. >>> >>> Unfortunately, there are some quirks: >>> - block/ssh.c does not compile properly in

[PATCH] MAINTAINERS: Downgrade status of virtio-9p to "Odd Fixes"

2019-10-10 Thread Greg Kurz
Latest submissions for 9pfs made me realize that I no longer have time and motivation to actively support it. I'll stay around for odd fixes though. Signed-off-by: Greg Kurz --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3ca

Re: [PATCH 5/5] travis.yml: Compile on arm64, too

2019-10-10 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 07:07:01PM +0200, Thomas Huth wrote: > Travis now features an arm64 build host, so let's check compilation > there, too. > > Unfortunately, there are some quirks: > - block/ssh.c does not compile properly in this environment, so we have > to use --disable-libssh until tha

[PATCH v3 1/3] qapi: Add feature flags to commands in qapi

2019-10-10 Thread Peter Krempa
Similarly to features for struct types introduce the feature flags also for commands. This will allow notifying management layers of fixes and compatible changes in the behaviour of a command which may not be detectable any other way. The changes were heavily inspired by commit 6a8c0b51025. Signe

[PATCH v3 0/3] qapi: Add detection for the 'savevm' fix for blockdev

2019-10-10 Thread Peter Krempa
Add 'features' field in the schema for commands and add a feature flag to advertise that the fix for savevm [1] is present. [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html v3: - added tests - mentioned commit fixing savevm in the patch adding the new feature - mentioned

[PATCH v3 2/3] tests: qapi: Test 'features' of commands

2019-10-10 Thread Peter Krempa
Signed-off-by: Peter Krempa --- tests/qapi-schema/qapi-schema-test.json | 26 ++ tests/qapi-schema/qapi-schema-test.out | 29 + tests/qapi-schema/test-qapi.py | 4 tests/test-qmp-cmds.c | 28 4

[PATCH v3 3/3] qapi: Allow introspecting fix for savevm's cooperation with blockdev

2019-10-10 Thread Peter Krempa
'savevm' was buggy as it considered all monitor-owned block device nodes for snapshot. With introduction of -blockdev the common usage made all nodes including protocol and backing file nodes monitor-owned and thus considered for snapshot. This is a problem since the 'file' protocol nodes can't ha

Re: [PATCH 4/5] travis.yml: Fix the ccache lines

2019-10-10 Thread Philippe Mathieu-Daudé
On 10/10/19 11:38 AM, Thomas Huth wrote: On 09/10/2019 21.04, Philippe Mathieu-Daudé wrote: On 10/9/19 7:07 PM, Thomas Huth wrote: The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache before running the program. But this shell construct causes Travis to

Re: [PATCH] error: Fix -msg timestamp default

2019-10-10 Thread Paolo Bonzini
I'll queue this patch. On 10/10/19 10:15, Markus Armbruster wrote: > -bool enable_timestamp_msg; Would you like me to also rename his enable_guestname_msg variable to error_with_guest_name? Paolo

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread Philippe Mathieu-Daudé
On 10/10/19 12:43 AM, John Snow wrote: It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Libvirt-checked-by: Peter Krempa Peter made a comment

Re: [PATCHv2 1/2] util/qemu-error: add guest name helper with -msg options

2019-10-10 Thread Paolo Bonzini
[Sorry Markus, I missed this message before] On 10/10/19 10:16, Markus Armbruster wrote: > I don't think merging this via qemu-trivial is a good idea. First, it's > not sufficiently trivial, as we shall see below. Second, the code in > question has a maintainer willing to review and merge patche

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread Peter Krempa
On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote: > On 10/10/19 12:43 AM, John Snow wrote: > > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > > I'd like to refactor these some day, and getting rid of the super-object > > will make that easier. > > > >

Re: [PATCH v2 3/4] qemu-iotests: 044: pass is actually a noop, so remove it

2019-10-10 Thread Philippe Mathieu-Daudé
On 10/9/19 9:47 PM, Cleber Rosa wrote: Reviewed-by: Eric Blake Signed-off-by: Cleber Rosa --- tests/qemu-iotests/044 | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index 8b2afa2a11..aa2a00ceed 100755 --- a/tests/qemu-iotests/044 +++ b/te

Re: [PATCH 4/5] travis.yml: Fix the ccache lines

2019-10-10 Thread Thomas Huth
On 10/10/2019 13.16, Philippe Mathieu-Daudé wrote: > On 10/10/19 11:38 AM, Thomas Huth wrote: >> On 09/10/2019 21.04, Philippe Mathieu-Daudé wrote: >>> On 10/9/19 7:07 PM, Thomas Huth wrote: The "command -v ccache && ccache ..." likely were supposed to test the availability of ccache befo

[PULL 02/31] s390x/mmu: Move DAT protection handling out of mmu_translate_asce()

2019-10-10 Thread David Hildenbrand
We'll reuse the ilen and tec definitions in mmu_translate soon also for all other DAT exceptions we inject. Move it to the caller, where we can later pair it up with other protection checks, like IEP. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand ---

[PULL 03/31] s390x/mmu: Inject DAT exceptions from a single place

2019-10-10 Thread David Hildenbrand
Let's return the PGM from the translation functions on error and inject based on that. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 63 +++ 1 file changed, 17 insertions(+), 46 delet

[PULL 00/31] s390x/tcg update

2019-10-10 Thread David Hildenbrand
Hi Peter, The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100) are available in the Git repository at: https://github.com/davidhildenbrand/qemu.git tags/

[PULL 01/31] s390x/mmu: Drop debug logging from MMU code

2019-10-10 Thread David Hildenbrand
Let's get it out of the way to make some further refactorings easier. Personally, I've never used these debug statements at all. And if I had to debug issues, I used plain GDB instead (debug prints are just way too much noise in the MMU). We might want to introduce tracing at some point instead, so

[PULL 06/31] s390x/mmu: DAT table definition overhaul

2019-10-10 Thread David Hildenbrand
Let's use consistent names for the region/section/page table entries and for the macros to extract relevant parts from virtual address. Make them match the definitions in the PoP - e.g., how the relevant bits are actually called. Introduce defines for all bits declared in the PoP. This will come i

[PULL 05/31] s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte()

2019-10-10 Thread David Hildenbrand
While ASCE_ORIGIN is not wrong, it is certainly confusing. We want a page frame address. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/mmu_h

[PULL 10/31] s390x/mmu: Implement Instruction-Execution-Protection Facility

2019-10-10 Thread David Hildenbrand
IEP support in the mmu is fairly easy. Set the right permissions for TLB entries and properly report an exception. Make sure to handle EDAT-2 by setting bit 56/60/61 of the TEID (TEC) to the right values. Let's keep s390_cpu_get_phys_page_debug() working even if IEP is active. Switch MMU_DATA_LOA

[PULL 04/31] s390x/mmu: Inject PGM_ADDRESSING on bogus table addresses

2019-10-10 Thread David Hildenbrand
Let's document how it works and inject PGM_ADDRESSING if reading of table entries fails. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-)

[PULL 09/31] s390x/mmu: Implement ESOP-2 and access-exception-fetch/store-indication facility

2019-10-10 Thread David Hildenbrand
We already implement ESOP-1. For ESOP-2, we only have to indicate all protection exceptions properly. Due to EDAT-1, we already indicate DAT exceptions properly. We don't trigger KCP/ALCP/IEP exceptions yet. So all we have to do is set the TEID (TEC) to the right values (bit 56, 60, 61) in case of

[PULL 08/31] s390x/mmu: Add EDAT2 translation support

2019-10-10 Thread David Hildenbrand
This only adds basic support to the DAT translation, but no EDAT2 support for TCG. E.g., the gdbstub under kvm uses this function, too, to translate virtual addresses. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 15 --- 1 file changed, 1

Re: [PATCH v3] migration: Support gtree migration

2019-10-10 Thread Peter Xu
On Thu, Oct 10, 2019 at 09:57:01AM +0200, Auger Eric wrote: > >> +static gboolean put_gtree_elem(gpointer key, gpointer value, gpointer > >> data) > >> +{ > >> +struct put_gtree_data *capsule = (struct put_gtree_data *)data; > >> +QEMUFile *f = capsule->f; > >> +int ret; > >> + > >> +

[PULL 07/31] s390x/mmu: Convert to non-recursive page table walk

2019-10-10 Thread David Hildenbrand
A non-recursive implementation allows to make better use of the branch predictor, avoids function calls, and makes the implementation of new features only for a subset of region table levels easier. We can now directly compare our implementation to the KVM gaccess implementation in arch/s390/kvm/g

[PULL 16/31] target/s390x: Use tcg_s390_program_interrupt in TCG helpers

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Replace all uses of s390_program_interrupt within files that are marked CONFIG_TCG. These are necessarily tcg-only. This lets each of these users benefit from the QEMU_NORETURN attribute on tcg_s390_program_interrupt. Acked-by: David Hildenbrand Signed-off-by: Richard

[PULL 12/31] s390x/cpumodel: Add new TCG features to QEMU cpu model

2019-10-10 Thread David Hildenbrand
We now implement a bunch of new facilities we can properly indicate. ESOP-1/ESOP-2 handling is discussed in the PoP Chafter 3-15 ("Suppression on Protection"). The "Basic suppression-on-protection (SOP) facility" is a core part of z/Architecture without a facility indication. ESOP-2 is indicated b

[PULL 23/31] target/s390x: Remove fail variable from s390_cpu_tlb_fill

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Now that excp always contains a real exception number, we can use that instead of a separate fail variable. This allows a redundant test to be removed. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-12-richard.hender...

[PULL 11/31] s390x/cpumodel: Prepare for changes of QEMU model

2019-10-10 Thread David Hildenbrand
Setup the 4.1 compatibility model so we can add new features to the LATEST model. Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 ++ target/s390x/gen-features.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-)

[PULL 13/31] target/s390x: Add ilen to unwind data

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Use ILEN_UNWIND to signal that we have in fact that cpu_restore_state will have been called by the time we arrive in do_program_interrupt. Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-2-richard.hender...@linaro.org> Reviewed-by: David Hildenbrand Si

[PULL 17/31] target/s390x: Push trigger_pgm_exception lower in s390_cpu_tlb_fill

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Delay triggering an exception until the end, after we have determined ultimate success or failure, and also taken into account whether this is a non-faulting probe. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-6-richar

[PULL 30/31] target/s390x: Remove ILEN_UNWIND

2019-10-10 Thread David Hildenbrand
From: Richard Henderson This setting is no longer used. Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-19-richard.hender...@linaro.org> Reviewed-by: David Hildenbrand Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PULL 18/31] target/s390x: Handle tec in s390_cpu_tlb_fill

2019-10-10 Thread David Hildenbrand
From: Richard Henderson As a step toward moving all excption handling out of mmu_translate, copy handling of the LowCore tec value from trigger_access_exception into s390_cpu_tlb_fill. So far this new plumbing isn't used. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message

[PULL 19/31] target/s390x: Return exception from mmu_translate_real

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Do not raise the exception directly within mmu_translate_real, but pass it back so that caller may do so. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-8-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand -

[PULL 14/31] target/s390x: Remove ilen parameter from tcg_s390_program_interrupt

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Since we begin the operation with an unwind, we have the proper value of ilen immediately available. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-3-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand --- t

Re: [PATCH v2 1/1] IDE: deprecate ide-drive

2019-10-10 Thread Philippe Mathieu-Daudé
On 10/10/19 1:26 PM, Peter Krempa wrote: On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote: On 10/10/19 12:43 AM, John Snow wrote: It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object

[PULL 21/31] target/s390x: Return exception from mmu_translate

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Do not raise the exception directly within mmu_translate, but pass it back so that caller may do so. Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-10-richard.hender...@linaro.org> Reviewed-by: David Hildenbrand Signed-off-by: David Hildenbrand ---

[PULL 15/31] target/s390x: Remove ilen parameter from s390_program_interrupt

2019-10-10 Thread David Hildenbrand
From: Richard Henderson This is no longer used, and many of the existing uses -- particularly within hw/s390x -- seem questionable. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-4-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand

[PULL 20/31] target/s390x: Remove exc argument to mmu_translate_asce

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Now that mmu_translate_asce returns the exception instead of raising it, the argument is unused. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-9-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand --- targe

[PULL 26/31] target/s390x: Rely on unwinding in s390_cpu_virt_mem_rw

2019-10-10 Thread David Hildenbrand
From: Richard Henderson For TCG, we will always call s390_cpu_virt_mem_handle_exc, which will go through the unwinder to set ILEN. For KVM, we do not go through do_program_interrupt, so this argument is unused. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191

[PULL 06/36] block/backup: fix max_transfer handling for copy_range

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Of course, QEMU_ALIGN_UP is a typo, it should be QEMU_ALIGN_DOWN, as we are trying to find aligned size which satisfy both source and target. Also, don't ignore too small max_transfer. In this case seems safer to disable copy_range. Fixes: 9ded4a0114968e Signed

[PULL 25/31] target/s390x: Rely on unwinding in s390_cpu_tlb_fill

2019-10-10 Thread David Hildenbrand
From: Richard Henderson We currently set ilen to AUTO, then overwrite that during unwinding, then overwrite that for the code access case. This can be simplified to setting ilen to our arbitrary value for the (undefined) code access case, then rely on unwinding to overwrite that with the correct

[PULL 22/31] target/s390x: Return exception from translate_pages

2019-10-10 Thread David Hildenbrand
From: Richard Henderson Do not raise the exception directly within translate_pages, but pass it back so that caller may do so. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-11-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand ---

[PULL 31/31] s390x/tcg: MVCL: Exit to main loop if requested

2019-10-10 Thread David Hildenbrand
MVCL is interruptible and we should check for interrupts and process them after writing back the variables to the registers. Let's check for any exit requests and exit to the main loop. Introduce a new helper function for that: cpu_loop_exit_requested(). When booting Fedora 30, I can see a handful

[PULL 08/36] block/backup: split shareable copying part from backup_do_cow

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Split copying logic which will be shared with backup-top filter. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190920142056.12778-4-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- block/backup.c | 47

[PULL 28/31] target/s390x: Remove ilen argument from trigger_access_exception

2019-10-10 Thread David Hildenbrand
From: Richard Henderson The single caller passes ILEN_UNWIND; pass that along to trigger_pgm_exception directly. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-17-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand --- target/s390x

[PULL 24/31] target/s390x: Simplify helper_lra

2019-10-10 Thread David Hildenbrand
From: Richard Henderson We currently call trigger_pgm_exception to set cs->exception_index and env->int_pgm_code and then read the values back and then reset cs->exception_index so that the exception is not delivered. Instead, use the exception type that we already have directly without ever tri

Re: [Qemu-devel] [PATCH v31 0/8] QEMU AVR 8 bit cores

2019-10-10 Thread Aleksandar Markovic
On Wednesday, October 9, 2019, Michael Rolnik wrote: > Hello Aleksandar. > > > https://ww1.microchip.com/downloads/en/devicedoc/atmel-2549-8-bit-avr- > microcontroller-atmega640-1280-1281-2560-2561_datasheet.pdf > > >> Thanks, Michael! Could you please provide also a link to AVR instruction set

[PULL 11/36] block/backup: fix block-comment style

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy We need to fix comment style around block-copy functions before further moving them to separate file to satisfy checkpatch. But do more: fix all comments style. Also, seems like doubled first asterisk is not forbidden, but drop it too for consistency. Signed-of

Re: [PATCH v7 03/12] hw/i386/pc: fix code style issues on functions that will be moved out

2019-10-10 Thread Philippe Mathieu-Daudé
Hi Sergio, On 10/8/19 3:55 PM, Sergio Lopez wrote: Fix code style issues detected by checkpatch.pl on functions that will be moved out to x86.c on the next patch. Signed-off-by: Sergio Lopez --- hw/i386/pc.c | 86 1 file changed, 46 inser

[PULL 27/31] target/s390x: Remove ILEN_AUTO

2019-10-10 Thread David Hildenbrand
From: Richard Henderson This setting is no longer used. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <20191001171614.8405-16-richard.hender...@linaro.org> Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 2 -- target/s390x/excp_helper.c | 3 ---

[PULL 00/36] Block patches

2019-10-10 Thread Max Reitz
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2019-10-1

[PULL 10/36] block/backup: introduce BlockCopyState

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Split copying code part from backup to "block-copy", including separate state structure and function renaming. This is needed to share it with backup-top filter driver in further commits. Notes: 1. As BlockCopyState keeps own BlockBackend objects, remaining jo

Re: [PATCH v7 12/12] MAINTAINERS: add microvm related files

2019-10-10 Thread Philippe Mathieu-Daudé
On 10/8/19 3:55 PM, Sergio Lopez wrote: Add a new "Microvm" section under "X86 Machines" with the new files related to this machine type. Signed-off-by: Sergio Lopez --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3ca814850e..df

[PULL 29/31] target/s390x: Remove ilen argument from trigger_pgm_exception

2019-10-10 Thread David Hildenbrand
From: Richard Henderson All but one caller passes ILEN_UNWIND, which is not stored. For the one use case in s390_cpu_tlb_fill, set int_pgm_ilen directly, simply to avoid the assert within do_program_interrupt. Reviewed-by: David Hildenbrand Signed-off-by: Richard Henderson Message-Id: <2019100

[PULL 03/36] block/qcow2: refactor qcow2_co_preadv_part

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Further patch will run partial requests of iterations of qcow2_co_preadv in parallel for performance reasons. To prepare for this, separate part which may be parallelized into separate function (qcow2_co_preadv_task). While being here, also separate encrypted c

[PULL 16/36] iotests: 257: drop device_add

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy SCSI devices are unused in test, drop them. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190920142056.12778-12-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- tests/qemu-iotests/257 | 8 --- tests/qemu-iote

[PULL 07/36] block/backup: fix backup_cow_with_offload for last cluster

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy We shouldn't try to copy bytes beyond EOF. Fix it. Fixes: 9ded4a0114968e Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow Message-id: 20190920142056.12778-3-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- bloc

[PULL 02/36] block: introduce aio task pool

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Common interface for aio task loops. To be used for improving performance of synchronous io loops in qcow2, block-stream, copy-on-read, and may be other places. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190916175324.1847

[PULL 04/36] block/qcow2: refactor qcow2_co_pwritev_part

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Similarly to previous commit, prepare for parallelizing write-loop iterations. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190916175324.18478-5-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- block/qcow2.c | 154 ++

[PULL 24/36] file-posix: account discard operations

2019-10-10 Thread Max Reitz
From: Anton Nefedov This will help to identify how many of the user-issued discard operations (accounted on a device level) have actually suceeded down on the host file (even though the numbers will not be exactly the same if non-raw format driver is used (e.g. qcow2 sending metadata discards)).

[PULL 13/36] block: teach bdrv_debug_breakpoint skip filters with backing

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Teach bdrv_debug_breakpoint and bdrv_debug_remove_breakpoint skip filters with backing. This is needed to implement and use in backup job it's own backup_top filter driver (like mirror already has one), and without this improvement, breakpoint removal will fail

[PULL 09/36] block/backup: improve comment about image fleecing

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190920142056.12778-5-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- block/backup.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/bl

[PULL 01/36] qemu-iotests: ignore leaks on failure paths in 026

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Upcoming asynchronous handling of sub-parts of qcow2 requests will change number of leaked clusters and even make it racy. As a preparation, ignore leaks on failure parts in 026. It's not trivial to just grep or substitute qemu-img output for such thing. Instea

[PULL 12/36] block: move block_copy from block/backup.c to separate file

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Split block_copy to separate file, to be cleanly shared with backup-top filter driver in further commits. It's a clean movement, the only change is drop "static" from interface functions. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Mes

[PULL 36/36] iotests/162: Fix for newer Linux 5.3+

2019-10-10 Thread Max Reitz
Linux 5.3 has made 0.0.0.0/8 a working IPv4 subnet. As such, "42" is now a valid host, and the connection to it will (hopefully) time out over a long period rather than quickly return with EINVAL. So let us use a negative integer for testing that NBD will not crash when it receives integer hosts.

[PULL 05/36] block/qcow2: introduce parallel subrequest handling in read and write

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy It improves performance for fragmented qcow2 images. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20190916175324.18478-6-vsement...@virtuozzo.com Signed-off-by: Max Reitz --- block/qcow2.h | 3 ++ block/qcow2.c | 125 ++

[PULL 15/36] iotests: 257: drop unused Drive.device field

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy After previous commit Drive.device is actually unused. Drop it together with .name property. While being here reuse .node in qmp commands instead of writing 'drive0' twice. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 201909

[PULL 35/36] tests: fix I/O test for hosts defaulting to LUKSv2

2019-10-10 Thread Max Reitz
From: Daniel P. Berrangé Some distros are now defaulting to LUKS version 2 which QEMU cannot process. For our I/O test that validates interoperability between the kernel/cryptsetup and QEMU, we need to explicitly ask for version 1 of the LUKS format. Signed-off-by: Daniel P. Berrangé Message-id

  1   2   3   4   >