Paolo Bonzini <pbonz...@redhat.com> writes:
> On 09/10/19 18:44, Mario Smarduch wrote:
>> };
>> @@ -1263,6 +1267,7 @@ static void realtime_init(void)
>> static void configure_msg(QemuOpts *opts)
>> {
>> enable_timestamp_msg = qemu_opt_get_bool(opts, "timestamp", true);
>> + enable_guestname_msg = qemu_opt_get_bool(opts, "name", false);
>> }
>
> Before, the msg option certainly had a timestamp suboption, but this
> might not be the case now. So that "true" needs to become "false".
> I'll fix it up when applying.
Hold your horses.
Before this patch, -msg "" enables timestamps. If you apply it with
your fixup, it doesn't anymore. I don't disagree with that change, but
it needs to be its own commit, with a proper explanation.
I have more comments on this patch.
