[Qemu-devel] Problems with MIPS Malta SSH tests in make check-acceptance

Hi, I'm finding make check-acceptance is currently useless for me as a pre-pull test, because a bunch of the tests are not at all reliable. There are a bunch which I'm still investigating, but for now I'm looking at the MIPS Malta SSH tests. There seem to be at least two problems here. First, th

[Qemu-devel] [RESEND PATCH] tests/acceptance: Specify arch for QueryCPUModelExpansion

At the moment this test runs on whatever the host arch is. But it looks for 'unavailable-features' which is an x86 specific cpu property. Tag it to always use qemu-system-x86_64. Signed-off-by: David Gibson Reviewed-by: Wainer dos Santos Moschetta --- tests/acceptance/cpu_queries.py | 3 +++

Re: [Qemu-devel] vhost, iova, and dirty page tracking

> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September 18, 2019 2:04 PM > > On 2019/9/18 上午9:31, Tian, Kevin wrote: > >> From: Alex Williamson [mailto:alex.william...@redhat.com] > >> Sent: Tuesday, September 17, 2019 10:54 PM > >> > >> On Tue, 17 Sep 2019 08:48:36 + > >>

[Qemu-devel] [PATCH RESEND v4 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE

UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. This patch adds support for user wait instructions in KVM. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may be executed at any

[Qemu-devel] [PATCH RESEND v4 0/2] x86: Enable user wait instructions

UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ente

[Qemu-devel] [PATCH RESEND v4 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

UMWAIT and TPAUSE instructions use 32bits IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in guest. Co-developed-by: Jingqi Liu Signed-off-by

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

On 17/09/2019 22.04, Pierre Muller wrote: > > Hello, > > I submitted September 12. a bug report about wrong handling of > infinity values for m68k emulator. > > https://bugs.launchpad.net/qemu/+bug/1843651 > > The analysis I made in the bug report is wrong, because > I did not know that m68

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

Am 17.09.2019 um 21:10 hat John Snow geschrieben: > > > On 9/17/19 10:46 AM, Kevin Wolf wrote: > > Am 17.09.2019 um 16:39 hat Eric Blake geschrieben: > >> On 9/17/19 5:20 AM, Greg Kurz wrote: > >>> Ensure that hints are added even if errp is &error_fatal or &error_abort. > >>> > >>> Signed-off-by

[Qemu-devel] KVM call for 2019-09-24

Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH v3 18/29] s390x/tcg: MVCS/MVCP: Use access_memmove()

On 17.09.19 22:20, Richard Henderson wrote: > On 9/16/19 9:57 AM, David Hildenbrand wrote: >> As we are moving between address spaces, we can use access_memmove_idx() >> without checking for destructive overlaps (especially of real storage >> locations): >> "Each storage operand is processed le

Re: [Qemu-devel] vhost, iova, and dirty page tracking

> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September 18, 2019 2:10 PM > > On 2019/9/18 上午9:44, Tian, Kevin wrote: > >> From: Jason Wang [mailto:jasow...@redhat.com] > >> Sent: Tuesday, September 17, 2019 6:36 PM > >> > >> On 2019/9/17 下午4:48, Tian, Kevin wrote: > From:

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

On 17/09/2019 12.03, Philippe Mathieu-Daudé wrote: > On 9/17/19 7:07 AM, Thomas Huth wrote: >> On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: >>> The MC146818 is a Real Time Clock, not a timer. >>> Move it under the hw/rtc/ subdirectory. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >> [...] >

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

Am 17.09.2019 um 23:48 hat Eduardo Habkost geschrieben: > On Tue, Sep 17, 2019 at 03:57:26PM +0200, Kevin Wolf wrote: > > Am 11.06.2019 um 19:12 hat Eduardo Habkost geschrieben: > > > On Tue, Jun 11, 2019 at 05:07:55PM +0100, Peter Maydell wrote: > > > > On Tue, 11 Jun 2019 at 17:03, Eduardo Habkos

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

On Tue, 17 Sep 2019 17:40:11 + Vladimir Sementsov-Ogievskiy wrote: > 17.09.2019 18:37, Greg Kurz wrote: > > On Tue, 17 Sep 2019 13:25:03 + > > Vladimir Sementsov-Ogievskiy wrote: > > > >> 17.09.2019 13:20, Greg Kurz wrote: > >>> Ensure that hints are added even if errp is &error_fatal o

Re: [Qemu-devel] [PATCH v1 0/9] testing/next (docker, podman, float)

Patchew URL: https://patchew.org/QEMU/20190917184109.12564-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1 0/9] testing/next (docker,podman,float) Message-id: 20190917184109.12564-1-ale

[Qemu-devel] [PATCH v14 3/7] target/ppc: Handle NMI guest exit

Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI in

[Qemu-devel] [PATCH v14 2/7] ppc: spapr: Introduce FWNMI capability

Introduce the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. This patch als

[Qemu-devel] [PATCH v14 4/7] target/ppc: Build rtas error log upon an MCE

Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the guest registered machine c

[Qemu-devel] [PATCH v14 1/7] Wrapper function to wait on condition for the main loop mutex

Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad Reviewe

[Qemu-devel] [PATCH v14 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the same

Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb

On 18/09/19 07:26, Richard Henderson wrote: > RFC because this doesn't work, and I don't quite understand why. > The only failing test is {i386,x86_64} pxe-test -- the other > migration tests that use notdirty all pass. > > Note that if you try to reproduce this on x86, you'll likely > have to --d

[Qemu-devel] [PATCH v14 7/7] ppc: spapr: Activate the FWNMI functionality

This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a72a4b1..b6a249f 100644 --- a/hw/ppc/spa

[Qemu-devel] [PATCH v14 6/7] migration: Include migration support for machine check handling

This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware. Signed-off-by: Aravinda Prasad ---

[Qemu-devel] [PATCH v14 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error belon

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

Hi Thomas, I tried to use git format-patch -s below, and change the commit message that appears below: muller@gcc123:~/gnu/qemu/qemu$ git format-patch -s a017dc6d43aaa4ffc7be40ae3adee4086be9cec2^ 0001-Fix-floatx80_invalid_encoding-function-for-m68k-cpu.patch muller@gcc123:~/gnu/qemu/qemu$ c

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev

Am 17.09.2019 um 18:33 hat Eric Blake geschrieben: > On 9/17/19 10:49 AM, Peter Krempa wrote: > > savevm was buggy as it considered all monitor owned block device nodes > > for snapshot. With introduction of -blockdev the common usage made all > > nodes including protocol nodes monitor owned and th

Re: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling

On 16.09.19 15:57, David Hildenbrand wrote: > This series fixes a bunch of issues related to some mem helpers and makes > sure that they are fault-safe, meaning no system state is modified in case > a fault is triggered. > > I can spot tons of other issues with other mem helpers that will have > t

Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

> -Original Message- > From: Alex Bennée [mailto:alex.ben...@linaro.org] > Sent: Tuesday, September 17, 2019 10:02 PM > To: Pavel Dovgalyuk > Cc: qemu-devel@nongnu.org; kw...@redhat.com; peter.mayd...@linaro.org; > crosthwaite.pe...@gmail.com; boost.li...@gmail.com; > artem.k.pisare...@

Re: [Qemu-devel] [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote: > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM, an

Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb

On 18.09.19 07:26, Richard Henderson wrote: > RFC because this doesn't work, and I don't quite understand why. > The only failing test is {i386,x86_64} pxe-test -- the other > migration tests that use notdirty all pass. > > Note that if you try to reproduce this on x86, you'll likely > have to --d

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev

On Wed, Sep 18, 2019 at 10:22:13 +0200, Kevin Wolf wrote: > Am 17.09.2019 um 18:33 hat Eric Blake geschrieben: > > On 9/17/19 10:49 AM, Peter Krempa wrote: > > > savevm was buggy as it considered all monitor owned block device nodes > > > for snapshot. With introduction of -blockdev the common usag

Re: [Qemu-devel] [RFC 1/3] exec: Adjust notdirty tracing

On 18.09.19 07:26, Richard Henderson wrote: > The memory_region_tb_read tracepoint is unreachable, since notdirty > is supposed to apply only to reads. The memory_region_tb_write > tracepoint is mis-named, because notdirty is not only used for TB > invalidation. It is also used for e.g. VGA RAM u

Re: [Qemu-devel] vhost, iova, and dirty page tracking

> From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, September 18, 2019 2:10 PM > > >> > >> Note that the HVA to GPA mapping is not an 1:1 mapping. One HVA > range > >> could be mapped to several GPA ranges. > > This is fine. Currently vfio_dma maintains IOVA->HVA mapping. > > > > bt

Re: [Qemu-devel] [PATCH] vhost-user: save features if the char dev is closed

On 9/17/19 11:40 PM, Michael S. Tsirkin wrote: > On Tue, Sep 17, 2019 at 09:19:01PM +0200, Adrian Moreno wrote: >> That way the state can be correctly restored when the device is opened >> again. This might happen if the backend is restarted. >> >> Buglink: https://bugzilla.redhat.com/show_bug.cgi?

[Qemu-devel] [PATCH v2] vhost-user: save features if the char dev is closed

That way the state can be correctly restored when the device is opened again. This might happen if the backend is restarted. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1738768 Reported-by: Pei Zhang Fixes: 6ab79a20af3a (do not call vhost_net_cleanup() on running net from char user even

Re: [Qemu-devel] [PATCH v3 00/18] ppc/pnv: add XIVE support for KVM guests

On 18/09/2019 07:44, David Gibson wrote: > On Tue, Sep 17, 2019 at 01:54:24PM +0200, Cédric Le Goater wrote: >> On 31/07/2019 16:12, Cédric Le Goater wrote: >>> Hello, >>> >>> The QEMU PowerNV machine emulates a baremetal OpenPOWER system and >>> acts as an hypervisor (L0). Supporting emulation of

[Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

Running iotests is not required to build QEMU, so we can have stricter version requirements for Python here and can make use of new features and drop compatibility code earlier. This makes qemu-iotests skip all Python tests if a Python version before 3.5 is used for the build. Suggested-by: Eduar

[Qemu-devel] qemu patches

Hi, Your recent patch https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 to the file target/i386/whpx-all.c breaks compilation when WHPX is enabled. Please add #i

Re: [Qemu-devel] [PATCH v4 02/10] hw/core: create Resettable QOM interface

On Wed, Sep 11, 2019 at 04:56:13PM +0200, Damien Hedde wrote: > > > On 9/11/19 10:06 AM, David Gibson wrote: > > On Wed, Aug 21, 2019 at 06:33:33PM +0200, Damien Hedde wrote: > >> This commit defines an interface allowing multi-phase reset. This aims > >> to solve a problem of the actual single-p

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

On 18/09/2019 10.55, Kevin Wolf wrote: > Running iotests is not required to build QEMU, so we can have stricter > version requirements for Python here and can make use of new features > and drop compatibility code earlier. > > This makes qemu-iotests skip all Python tests if a Python version befor

Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events

On Mon, Sep 16, 2019 at 12:41:44PM -0400, John Snow wrote: > On 9/16/19 12:40 PM, Philippe Mathieu-Daudé wrote: > > On 9/16/19 6:36 PM, Eric Blake wrote: > >> On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote: > >>> While the tracing frawework does not forbid trailing newline in > >> > >> framework

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > From: Pavel Dovgalyuk > > This patch updates the description of the command lines for using > record/replay with attached block devices. > > Signed-off-by: Pavel Dovgalyuk > --- > docs/replay.txt | 12 +--- > 1 file changed, 9

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

On 18.09.19 10:55, Kevin Wolf wrote: > Running iotests is not required to build QEMU, so we can have stricter > version requirements for Python here and can make use of new features > and drop compatibility code earlier. > > This makes qemu-iotests skip all Python tests if a Python version before

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format

On Mon, Sep 16, 2019 at 11:51:19AM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefan, > > I'v been confused by trailing newline in trace reports, > so this series aims to fix this, by cleaning current > formats and add a check to catch new one introduced. > > v2: > - Use regex format (easier to re

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > From: Pavel Dovgalyuk > > > > This patch updates the description of the command lines for using > > record/replay with attached block devices. > > > > Signed-off-by: Pavel Dovgalyuk > > ---

Re: [Qemu-devel] [PULL 3/8] m68k: Add NeXTcube machine

On 16/09/2019 12.48, Peter Maydell wrote: > On Sat, 7 Sep 2019 at 16:47, Thomas Huth wrote: >> >> It is still quite incomplete (no SCSI, no floppy emulation, no network, >> etc.), but the firmware already shows up the debug monitor prompt in the >> framebuffer display, so at least the very basics

Re: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling

On Wed, 18 Sep 2019 10:25:15 +0200 David Hildenbrand wrote: > On 16.09.19 15:57, David Hildenbrand wrote: > > This series fixes a bunch of issues related to some mem helpers and makes > > sure that they are fault-safe, meaning no system state is modified in case > > a fault is triggered. > > > >

Re: [Qemu-devel] [PATCH v3 00/29] s390x/tcg: mem_helper: Fault-safe handling

On 18.09.19 11:26, Cornelia Huck wrote: > On Wed, 18 Sep 2019 10:25:15 +0200 > David Hildenbrand wrote: > >> On 16.09.19 15:57, David Hildenbrand wrote: >>> This series fixes a bunch of issues related to some mem helpers and makes >>> sure that they are fault-safe, meaning no system state is modi

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

Am 18.09.2019 um 11:20 hat Max Reitz geschrieben: > On 18.09.19 10:55, Kevin Wolf wrote: > > Running iotests is not required to build QEMU, so we can have stricter > > version requirements for Python here and can make use of new features > > and drop compatibility code earlier. > > > > This makes

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > > From: Pavel Dovgalyuk > > > > > > This patch updates the description of the command lines for using > > > record/replay with atta

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > > > From: Pavel Dovgalyuk > > > > > > > > This patch updates the description of

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

On Tue, Sep 17, 2019 at 02:25:59PM +0200, Johannes Berg wrote: > diff --git a/contrib/libvhost-user/libvhost-user.c > b/contrib/libvhost-user/libvhost-user.c > index f1677da21201..17b7833d1f6b 100644 > --- a/contrib/libvhost-user/libvhost-user.c > +++ b/contrib/libvhost-user/libvhost-user.c > @@ -

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

Am 18.09.2019 um 11:37 hat Pavel Dovgalyuk geschrieben: > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > Am 17.09.2019 um 13:58 hat Pavel Dovgalyuk geschrieben: > > > > > From: Pavel

Re: [Qemu-devel] [PATCH 1/2] audio: fix buffer-length typo in documentation

On Tue, Sep 17, 2019 at 09:29:34PM +0200, Zoltán Kővágó wrote: > On 2019-09-11 16:58, Stefan Hajnoczi wrote: > > Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") > > Signed-off-by: Stefan Hajnoczi > > --- > > qemu-options.hx | 4 ++-- > > 1 file changed, 2 insertions(+

Re: [Qemu-devel] [PATCH v3 29/29] tests/tcg: target/s390x: Test MVO

David Hildenbrand writes: > Let's add the simple test based on the example from the PoP. > > Signed-off-by: David Hildenbrand > --- > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/mvo.c | 25 + > 2 files changed, 26 insertions(+) > create mode 10

Re: [Qemu-devel] [PATCH 2/2] audio: add -audiodev pa, in|out.latency= to documentation

On Tue, Sep 17, 2019 at 09:47:11PM +0200, Zoltán Kővágó wrote: > On 2019-09-11 16:58, Stefan Hajnoczi wrote: > > The "latency" parameter wasn't covered by the documentation. > > > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Zoltán Kővágó > > --- > > How is this parameter related to buffer-le

Re: [Qemu-devel] [PATCH] libvhost-user: handle NOFD flag in call/kick/err better

On Wed, 2019-09-18 at 10:39 +0100, Stefan Hajnoczi wrote: > > > vu_check_queue_msg_file(VuDev *dev, VhostUserMsg *vmsg) > > { > > int index = vmsg->payload.u64 & VHOST_USER_VRING_IDX_MASK; > > +bool nofd = vmsg->payload.u64 & VHOST_USER_VRING_NOFD_MASK; > > > > if (index >= dev->

[Qemu-devel] [PATCH 5/8] block: Evaluate @exact in protocol drivers

We have two protocol drivers that return success when trying to shrink a block device even though they cannot shrink it. This behavior is now only allowed with exact=false, so they should return an error with exact=true. Signed-off-by: Max Reitz --- block/file-posix.c | 8 +++- block/iscsi.

[Qemu-devel] [PATCH 4/8] block: Add @exact parameter to bdrv_co_truncate()

We have two drivers (iscsi and file-posix) that (in some cases) return success from their .bdrv_co_truncate() implementation if the block device is larger than the requested offset, but cannot be shrunk. Some callers do not want that behavior, so this patch adds a new parameter that they can use t

[Qemu-devel] [PATCH 0/8] block: Add @exact parameter to bdrv_co_truncate()

Hi, This series is supposed to pull out some of the problems from my “Generic file creation fallback” series. The blk_truncate_for_formatting() function added there was buggy, as Maxim noted, in that it did not check whether blk_truncate() actually resized the block node to the target offset. On

[Qemu-devel] [PATCH 1/8] block: Handle filter truncation like native impl.

Make the filter truncation (passing it through to bs->file) a first-class citizen and handle it exactly as if it was the filter driver's native implementation of .bdrv_co_truncate(). I do not see a reason not to, it makes the code a bit shorter, and may be even more correct because this gets us to

[Qemu-devel] [PATCH 6/8] block: Let format drivers pass @exact

When truncating a format node, the @exact parameter is generally handled simply by virtue of the format storing the new size in the image metadata. Such formats do not need to pass on the parameter to their file nodes. There are exceptions, though: - raw and crypto cannot store the image size, an

[Qemu-devel] [PATCH 3/8] block: Do not truncate file node when formatting

There is no reason why the format drivers need to truncate the protocol node when formatting it. When using the old .bdrv_co_create_ops() interface, the file will be created with no size option anyway, which generally gives it a size of 0. (Exceptions are block devices, which cannot be truncated

[Qemu-devel] [PATCH 2/8] block/cor: Drop cor_co_truncate()

No other filter driver has a .bdrv_co_truncate() implementation, and there is no need to because the general block layer code can handle it just as well. Signed-off-by: Max Reitz --- block/copy-on-read.c | 8 1 file changed, 8 deletions(-) diff --git a/block/copy-on-read.c b/block/copy

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

Pierre Muller writes: > Hi Thomas, > > I tried to use git format-patch -s below, > and change the commit message that appears below: > > > muller@gcc123:~/gnu/qemu/qemu$ git format-patch -s > a017dc6d43aaa4ffc7be40ae3adee4086be9cec2^ > 0001-Fix-floatx80_invalid_encoding-function-for-m68k-c

[Qemu-devel] [PATCH 7/8] block: Pass truncate exact=true where reasonable

This is a change in behavior, so all instances need a good justification. The comments added here should explain my reasoning. qed already had a comment that suggests it always expected bdrv_truncate()/blk_truncate() to behave as if exact=true were passed (c743849bee7 came eight months before 55b

[Qemu-devel] [PATCH v2 1/3] audio: fix buffer-length typo in documentation

Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bbfd936d29..a4f9f74f52 100644 --- a/qemu-options.hx +++ b/q

Re: [Qemu-devel] Call for volunteers: LWN.net articles about KVM Forum talks

On Tue, 17 Sep 2019 14:02:59 +0100 Stefan Hajnoczi wrote: > Hi, > LWN.net is a popular open source news site that covers Linux and other > open source communities (Python, GNOME, Debian, etc). It has published > a few KVM articles in the past too. > > Let's raise awareness of QEMU, KVM, and lib

Re: [Qemu-devel] [for-4.2 PATCH 3/6] replay: update docs for record/replay with block devices

> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 18.09.2019 um 11:37 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 18.09.2019 um 11:22 hat Pavel Dovgalyuk geschrieben: > > > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > > > Am 17.09.2019 um 13:58

[Qemu-devel] [PATCH v2 0/3] audio: -audiodev documentation tweaks

v2: * Added ALSA period-length fix [Zoltán] * Expanded PulseAudio latency documentation [Zoltán] Small fixes to the -audiodev documentation. Stefan Hajnoczi (3): audio: fix buffer-length typo in documentation audio: add -audiodev pa,in|out.latency= to documentation audio: fix ALSA period-

[Qemu-devel] [PATCH 8/8] Revert "qemu-img: Check post-truncation size"

This reverts commit 5279b30392da7a3248b320c75f20c61e3a95863c. We no longer need this check because exact=true forces the block driver to give the image the exact size requested by the user. Signed-off-by: Max Reitz --- qemu-img.c | 39 --- 1 file changed, 4 i

Re: [Qemu-devel] [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

On Wed, Sep 18, 2019 at 9:28 AM Stefano Garzarella wrote: > > On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote: > I volunteer for "Libvirt: Never too Late to Learn New Tricks" by > Daniel Berrange. Hi Stefano, Paolo has already volunteered for that. Is there another talk you are i

[Qemu-devel] [PATCH v2 3/3] audio: fix ALSA period-length typo in documentation

Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation") Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 6d7fe57dd4..0f79c70c37 100644 --- a/qemu-options.hx +++ b/q

Re: [Qemu-devel] [PATCH v3 3/3] virtio: add vhost-user-fs-pci device

On Wed, Sep 18, 2019 at 09:27:21AM +0800, piaojun wrote: > > > On 2019/9/18 0:00, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Add the PCI version of vhost-user-fs. > > > > Launch QEMU like this: > > > > qemu -chardev socket,path=/tmp/vhost-fs.sock,id=chr0

Re: [Qemu-devel] [PATCH v3 29/29] tests/tcg: target/s390x: Test MVO

On 18.09.19 11:47, Alex Bennée wrote: > > David Hildenbrand writes: > >> Let's add the simple test based on the example from the PoP. >> >> Signed-off-by: David Hildenbrand >> --- >> tests/tcg/s390x/Makefile.target | 1 + >> tests/tcg/s390x/mvo.c | 25 + >> 2

[Qemu-devel] [PATCH v2 2/3] audio: add -audiodev pa, in|out.latency= to documentation

The "latency" parameter wasn't covered by the documentation. Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 5 + 1 file changed, 5 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index a4f9f74f52..6d7fe57dd4 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -470,6 +47

[Qemu-devel] [PATCH] Fix wrong behavior of cpu_memory_rw_debug() function in SMM

There is a problem, that you don't have access to the data using cpu_memory_rw_debug() function when in SMM. You can't remotely debug SMM mode program because of that for example. Likely attrs version of get_phys_page_debug should be used to get correct asidx at the end to handle access properly

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

Le 18/09/2019 à 11:59, Alex Bennée a écrit : > > Pierre Muller writes: > >> Hi Thomas, >> >> I tried to use git format-patch -s below, >> and change the commit message that appears below: >> >> >> muller@gcc123:~/gnu/qemu/qemu$ git format-patch -s >> a017dc6d43aaa4ffc7be40ae3adee4086be9cec2

Re: [Qemu-devel] [PATCH 02/17] block: Pass local error object pointer to error_append_hint()

18.09.2019 10:58, Greg Kurz wrote: > On Tue, 17 Sep 2019 17:40:11 + > Vladimir Sementsov-Ogievskiy wrote: > >> 17.09.2019 18:37, Greg Kurz wrote: >>> On Tue, 17 Sep 2019 13:25:03 + >>> Vladimir Sementsov-Ogievskiy wrote: >>> 17.09.2019 13:20, Greg Kurz wrote: > Ensure that hints

Re: [Qemu-devel] [PATCH 10/17] s390x/css: Pass local error object pointer to error_append_hint()

On Tue, 17 Sep 2019 18:36:20 +0200 Greg Kurz wrote: > On Tue, 17 Sep 2019 13:24:12 +0200 > Cornelia Huck wrote: > > > On Tue, 17 Sep 2019 12:21:34 +0200 > > Greg Kurz wrote: > > > > > Ensure that hints are added even if errp is &error_fatal or &error_abort. > > > > > > Signed-off-by: Greg

Re: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specific infinity pattern.

Patchew URL: https://patchew.org/QEMU/1615bbe5-3033-3b76-5cfb-52e343dc4...@freepascal.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] * include/fpu/softfloat.h (floatx80_invalid_encoding): Handle m68k specifi

Re: [Qemu-devel] [libvirt] Call for volunteers: LWN.net articles about KVM Forum talks

On Wed, Sep 18, 2019 at 11:02:54AM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 18, 2019 at 9:28 AM Stefano Garzarella > wrote: > > > > On Tue, Sep 17, 2019 at 02:02:59PM +0100, Stefan Hajnoczi wrote: > > I volunteer for "Libvirt: Never too Late to Learn New Tricks" by > > Daniel Berrange. > > Hi

Re: [Qemu-devel] [PATCH v4 1/4] iotests: add script_initialize

18.09.2019 1:29, John Snow wrote: > > > On 9/16/19 10:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.09.2019 3:16, John Snow wrote: >>> Like script_main, but doesn't require a single point of entry. >>> Replace all existing initialization sections with this drop-in replacement. >>> >>> This bri

Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

Pavel Dovgalyuk writes: >> -Original Message- >> From: Alex Bennée [mailto:alex.ben...@linaro.org] >> Sent: Tuesday, September 17, 2019 10:02 PM >> To: Pavel Dovgalyuk >> Cc: qemu-devel@nongnu.org; kw...@redhat.com; peter.mayd...@linaro.org; >> crosthwaite.pe...@gmail.com; boost.li...@g

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

On 9/17/19 10:32 PM, Richard Henderson wrote: > On 9/16/19 11:48 AM, Philippe Mathieu-Daudé wrote: >> include/hw/rtc/mc146818rtc.h | 38 > > Same rebase failure as for patch 4? This one is actually correct, it got moved from: include/hw/timer/mc146818rtc.h

Re: [Qemu-devel] [PATCH 03/13] hw: Move MC146818 device from hw/timer/ to hw/rtc/ subdirectory

On 9/18/19 9:43 AM, Thomas Huth wrote: > On 17/09/2019 12.03, Philippe Mathieu-Daudé wrote: >> On 9/17/19 7:07 AM, Thomas Huth wrote: >>> On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: The MC146818 is a Real Time Clock, not a timer. Move it under the hw/rtc/ subdirectory. Si

Re: [Qemu-devel] Problems with MIPS Malta SSH tests in make check-acceptance

On 9/18/19 9:16 AM, David Gibson wrote: > Hi, > > I'm finding make check-acceptance is currently useless for me as a > pre-pull test, because a bunch of the tests are not at all reliable. > There are a bunch which I'm still investigating, but for now I'm > looking at the MIPS Malta SSH tests. > >

Re: [Qemu-devel] [RESEND PATCH] tests/acceptance: Specify arch for QueryCPUModelExpansion

On 9/18/19 9:06 AM, David Gibson wrote: > At the moment this test runs on whatever the host arch is. But it looks > for 'unavailable-features' which is an x86 specific cpu property. Tag it > to always use qemu-system-x86_64. > > Signed-off-by: David Gibson > Reviewed-by: Wainer dos Santos Mosch

Re: [Qemu-devel] [PATCH] iotests: Require Python 3.5 or later

On 9/18/19 11:29 AM, Kevin Wolf wrote: > Am 18.09.2019 um 11:20 hat Max Reitz geschrieben: >> On 18.09.19 10:55, Kevin Wolf wrote: >>> Running iotests is not required to build QEMU, so we can have stricter >>> version requirements for Python here and can make use of new features >>> and drop compat

Re: [Qemu-devel] [PATCH] qga: add command guest-get-devices for reporting VirtIO devices

On Mon, Sep 16, 2019 at 04:31:49PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Aug 29, 2019 at 8:06 PM Tomáš Golembiovský > wrote: > > > > Add command for reporting devices on Windows guest. The intent is not so > > much to report the devices but more importantly the driver (and its > > ver

Re: [Qemu-devel] [PATCH v3 29/29] tests/tcg: target/s390x: Test MVO

David Hildenbrand writes: > On 18.09.19 11:47, Alex Bennée wrote: >> >> David Hildenbrand writes: >> >>> Let's add the simple test based on the example from the PoP. >>> >>> Signed-off-by: David Hildenbrand >>> --- >>> tests/tcg/s390x/Makefile.target | 1 + >>> tests/tcg/s390x/mvo.c

Re: [Qemu-devel] qemu patches

Hi Ilias, On 9/18/19 10:19 AM, Ilias wrote: > Hi, > > Your recent patch > > https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 > > to the file > > target/i386/whpx-all.c >

Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > >> -Original Message- > >> From: Alex Bennée [mailto:alex.ben...@linaro.org] > >> Sent: Tuesday, September 17, 2019 10:02 PM > >> To: Pavel Dovgalyuk > >> Cc: qemu-devel@nongnu.org; kw...@redhat.com; peter.m

Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch

Richard Henderson writes: > On 9/17/19 5:00 PM, Alex Bennée wrote: +add_f32_const(0x8p-152); +add_f32_const(0x8p-152); +add_f32_const(0x8p-152); >>> >>> Why are you adding 3 of the same? >> >> To replicate the 1841491 test case where the same number is used for >> a/b

Re: [Qemu-devel] [PATCH] tests/docker: fix typo for debian9-mxe

John Snow writes: > We spelled it debian-9-mxe, but the image is debian9-mxe. > > Signed-off-by: John Snow I'll merge this fix with the other typo fix while I'm at it. Thanks. > --- > tests/docker/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test

Re: [Qemu-devel] Problems with MIPS Malta SSH tests in make check-acceptance

On Wed, Sep 18, 2019 at 01:13:29PM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/19 9:16 AM, David Gibson wrote: > > Hi, > > > > I'm finding make check-acceptance is currently useless for me as a > > pre-pull test, because a bunch of the tests are not at all reliable. > > There are a bunch which

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/6] tests/acceptance: Add tests for the PReP/40p machine

On 9/17/19 1:40 PM, David Gibson wrote: > On Tue, Sep 17, 2019 at 12:19:52PM +1000, David Gibson wrote: >> On Mon, Sep 16, 2019 at 11:56:06AM +0200, Philippe Mathieu-Daudé wrote: >>> On 9/16/19 11:52 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: > Hi David, > > O

[Qemu-devel] [PATCH] xen-block: treat XenbusStateUnknown the same as XenbusStateClosed

When a frontend gracefully disconnects from an offline backend, it will set its own state to XenbusStateClosed. The code in xen-block.c correctly deals with this and sets the backend into XenbusStateClosed. Unfortunately it is possible for toolstack to actually delete the frontend area before the s

[Qemu-devel] [PATCH] xen-bus: only set the xen device frontend state if it is missing

From: Mark Syms Some toolstack implementations will set the frontend xenstore keys to Initialising which will then trigger the in guest PV drivers to begin initialising and some implementations will then set their state to Closing. If this has occurred then device realize must not overwrite the f

Re: [Qemu-devel] WHPX build broken

On 9/18/19 1:23 PM, Philippe Mathieu-Daudé wrote: > Hi Ilias, > > On 9/18/19 10:19 AM, Ilias wrote: >> Hi, >> >> Your recent patch >> >> https://github.com/qemu/qemu/commit/12e9493df9242a2051701e7eb64175d4e904acba#diff-d98f9b48cc332d226892f0db74a86b87 >> >> to the file >> >> target/i386/whpx-all.c

  1   2   3   4   >