On 18/09/19 07:26, Richard Henderson wrote: > RFC because this doesn't work, and I don't quite understand why. > The only failing test is {i386,x86_64} pxe-test -- the other > migration tests that use notdirty all pass. > > Note that if you try to reproduce this on x86, you'll likely > have to --disable-kvm, as otherwise the pxe-test will skip tcg. > > Anyone who knows how this works willing to have a look?
I think patch 2 is doing too much. Why don't you keep memory_notdirty_write_prepare and memory_notdirty_write_complete at first (so that the atomic path is completely unchanged wrt MMU lookup), and then simplify that separately? Maybe that shows what's going on. Paolo