Re: [Qemu-devel] Is network backend netmap worth keeping?

2019-09-13 Thread Markus Armbruster
Giuseppe Lettieri writes: > Hi all, > > I have been thinking of the submodule suggestion and I have also > prepared a patch for it (attached). However, I am not sure about what > we want to achieve with it. In particular, I am not sure that the > option is useful for end users. The problem is tha

[Qemu-devel] [PATCH v4 3/3] qemu-iotests: Add test for bz #1745922

2019-09-13 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/263 | 91 ++ tests/qemu-iotests/263.out | 40 + tests/qemu-iotests/group | 1 + 3 files changed, 132 insertions(+) create mode 100755 tests/qemu-iotests/263 create mode 100644 tests/q

Re: [Qemu-devel] [PATCH v5 5/5] target/arm: remove run-time semihosting checks for linux-user

2019-09-13 Thread Peter Maydell
On Wed, 11 Sep 2019 at 17:50, Alex Bennée wrote: > > Now we do all our checking at translate time we can make cpu_loop a > little bit simpler. We also introduce a simple linux-user semihosting > test case to defend the functionality. The out-of-tree softmmu based > semihosting tests are still more

Re: [Qemu-devel] [PATCH v5 1/5] tests/tcg: clean-up some comments after the de-tangling

2019-09-13 Thread Peter Maydell
On Wed, 11 Sep 2019 at 17:50, Alex Bennée wrote: > > These were missed in the recent de-tangling so have been updated to be > more actuate. I've also built up ARM_TESTS in a manner similar to > AARCH64_TESTS for better consistency. > > Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell than

Re: [Qemu-devel] [PATCH v5 3/5] target/arm: handle A-profile semihosting at translate time

2019-09-13 Thread Peter Maydell
On Wed, 11 Sep 2019 at 17:50, Alex Bennée wrote: > > As for the other semihosting calls we can resolve this at translate > time. > > Signed-off-by: Alex Bennée > > --- > v2 > - update for change to gen_exception_internal_insn API > v3 > - update for decode tree, merge T32 & A32 commits > -

Re: [Qemu-devel] [PATCH v5 2/5] target/arm: handle M-profile semihosting at translate time

2019-09-13 Thread Peter Maydell
On Wed, 11 Sep 2019 at 17:50, Alex Bennée wrote: > > We do this for other semihosting calls so we might as well do it for > M-profile as well. > > Signed-off-by: Alex Bennée > Reviewed-by: Richard Henderson > > --- > v2 > - update for change to gen_exception_internal_insn API > v3 > - update

Re: [Qemu-devel] [PATCH v3 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Maxim Levitsky
On Fri, 2019-09-13 at 12:37 +0200, Max Reitz wrote: > On 13.09.19 00:37, Maxim Levitsky wrote: > > This commit tries to clarify few function arguments, > > and add comments describing the encrypt/decrypt interface > > > > Signed-off-by: Maxim Levitsky > > --- > > block/qcow2-cluster.c | 8 +++--

Re: [Qemu-devel] [PATCH v3] qemu-ga: Convert invocation documentation to rST

2019-09-13 Thread Peter Maydell
On Thu, 5 Sep 2019 at 14:10, Peter Maydell wrote: > > The qemu-ga documentation is currently in qemu-ga.texi in > Texinfo format, which we present to the user as: > * a qemu-ga manpage > * a section of the main qemu-doc HTML documentation > > Convert the documentation to rST format, and present

Re: [Qemu-devel] [PATCH v5 2/5] target/arm: handle M-profile semihosting at translate time

2019-09-13 Thread Alex Bennée
Peter Maydell writes: > On Wed, 11 Sep 2019 at 17:50, Alex Bennée wrote: >> >> We do this for other semihosting calls so we might as well do it for >> M-profile as well. >> >> Signed-off-by: Alex Bennée >> Reviewed-by: Richard Henderson >> >> --- >> v2 >> - update for change to gen_excepti

Re: [Qemu-devel] [PATCH v3 1/6] migration: fix vmdesc leak on vmstate_save() error

2019-09-13 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Signed-off-by: Marc-André Lureau Reviewed-by: Dr. David Alan Gilbert Could have put that as a separate patch. > --- > migration/qjson.h | 2 ++ > migration/savevm.c | 3 +-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > dif

Re: [Qemu-devel] [PATCH v5 2/5] target/arm: handle M-profile semihosting at translate time

2019-09-13 Thread Peter Maydell
On Fri, 13 Sep 2019 at 14:28, Alex Bennée wrote: > > > Peter Maydell writes: > > This is still disabling semihosting for the linux-user-mode > > build for M-profile, isn't it ? > > Sure - as rth suggested. But m-profile doesn't run Linux so why would we > support it in linux-user? (a) Linux does

Re: [Qemu-devel] [PATCH 1/2] block/nvme: add support for write zeros

2019-09-13 Thread Maxim Levitsky
On Tue, 2019-08-27 at 18:22 -0400, John Snow wrote: > Without a commit message, I have no real hope of reviewing this. I was > CC'd, though, so I'll give it a blind shot. > > We want to add write_zeroes support for block/nvme, but I can't really > verify any of that is correct or working without a

[Qemu-devel] [PATCH v2 2/2] block/nvme: add support for discard

2019-09-13 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/nvme.c | 83 ++ block/trace-events | 2 ++ 2 files changed, 85 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index d95265fae4..c17edd6aae 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -112,6 +11

Re: [Qemu-devel] [PATCH v3 4/6] tests: add qtest_expect_exit_status()

2019-09-13 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Modify the behaviour of qtest_quit() to check against the expected > exit status value. The default remains 0. > > Signed-off-by: Marc-André Lureau This looks similar to the one in the current pending migration pull by Yury Kotov: 'te

[Qemu-devel] [PATCH v2 0/2] block/nvme: add support for write zeros and discard

2019-09-13 Thread Maxim Levitsky
This is the second part of the patches I prepared for this driver back when I worked on mdev-nvme. V2: addressed review feedback, no major changes Best regards, Maxim Levitsky Maxim Levitsky (2): block/nvme: add support for write zeros block/nvme: add support for discard block/nvme

[Qemu-devel] [PATCH v2 1/2] block/nvme: add support for write zeros

2019-09-13 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- block/nvme.c | 72 +++- block/trace-events | 1 + include/block/nvme.h | 19 +++- 3 files changed, 90 insertions(+), 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 5be3a39b63..d95265fae4 1

Re: [Qemu-devel] [PULL 00/22] Block layer patches

2019-09-13 Thread Peter Maydell
On Thu, 12 Sep 2019 at 14:46, Kevin Wolf wrote: > > The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 > 09:48:34 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
Hi! 08.04.2019 14:33, Yury Kotov wrote: > It fixes heap-use-after-free which was found by clang's ASAN. > > Control flow of this use-after-free: > main_thread: > * Got SIGTERM and completes main loop > * Calls migration_shutdown >- migrate_fd_cancel (so, migration_thread begins

Re: [Qemu-devel] [PATCH v5 2/5] target/arm: handle M-profile semihosting at translate time

2019-09-13 Thread Peter Maydell
On Fri, 13 Sep 2019 at 14:31, Peter Maydell wrote: > > On Fri, 13 Sep 2019 at 14:28, Alex Bennée wrote: > > > > > > Peter Maydell writes: > > > This is still disabling semihosting for the linux-user-mode > > > build for M-profile, isn't it ? > > > > Sure - as rth suggested. But m-profile doesn't

Re: [Qemu-devel] [PATCH v5 2/5] target/arm: handle M-profile semihosting at translate time

2019-09-13 Thread Alex Bennée
Peter Maydell writes: > On Fri, 13 Sep 2019 at 14:28, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> > This is still disabling semihosting for the linux-user-mode >> > build for M-profile, isn't it ? >> >> Sure - as rth suggested. But m-profile doesn't run Linux so why would we >> suppo

[Qemu-devel] [PATCH] tests/tcg: add float_madds test to multiarch

2019-09-13 Thread Alex Bennée
This is a generic floating point multiply and accumulate test for single precision floating point values. I've split of the common float functions into a helper library so additional tests can use the same common code. Signed-off-by: Alex Bennée --- tests/tcg/multiarch/Makefile.target | 7 +-

Re: [Qemu-devel] [PATCH v2] qapi/qmp-dispatch: Fix error class for reporting disabled commands

2019-09-13 Thread Michal Privoznik
On 9/13/19 2:52 PM, Markus Armbruster wrote: Michal Privoznik writes: If a command is disabled an error is reported. But due to usage of error_setg() the class of the error is GenericError which does not help callers in distinguishing this case from a case where a qmp command fails regularly d

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2019-09-13 Thread Christophe Lyon
Regarding Cortex-M7, I've noticed that unlike Cortex-M4, it supports double precision floating-point. Is DP supported by qemu? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1721275 Title: Support m

Re: [Qemu-devel] [PATCH v2 2/2] ati: use vga_read_byte in ati_cursor_define

2019-09-13 Thread BALATON Zoltan
On Fri, 13 Sep 2019, Gerd Hoffmann wrote: This makes sure reads are confined to vga video memory. v2: fix ati_cursor_draw_line too. Reported-by: xu hang Signed-off-by: Gerd Hoffmann --- hw/display/ati.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 15:59, Maxim Levitsky wrote: > This commit tries to clarify few function arguments, > and add comments describing the encrypt/decrypt interface > > Signed-off-by: Maxim Levitsky > --- > block/qcow2-cluster.c | 9 --- > block/qcow2-threads.c | 62

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Maxim Levitsky
On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2019 15:59, Maxim Levitsky wrote: > > This commit tries to clarify few function arguments, > > and add comments describing the encrypt/decrypt interface > > > > Signed-off-by: Maxim Levitsky > > --- > > block/qcow2-c

Re: [Qemu-devel] [PATCH v2 01/16] scripts/git.orderfile: Match QAPI schema more precisely

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> Pattern *.json also matches the tests/qapi-schema/*.json. Separates >> them from the tests/qapi-schema/*.{err,exit,out} in diffs. I hate >> that. Change the pattern to match just the "real" QAPI schemata. >> >> Signed-off-by

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2019-09-13 Thread Peter Maydell
Yes, QEMU supports DP (I actually had to go to some lengths to disable the DP support for the M4 :-)) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1721275 Title: Support more ARM CPUs Status in Q

Re: [Qemu-devel] [PULL] RISC-V Patches for the 4.2 Soft Freeze, Part 1

2019-09-13 Thread Palmer Dabbelt
On Fri, 13 Sep 2019 02:17:32 PDT (-0700), Peter Maydell wrote: On Wed, 11 Sep 2019 at 09:24, Palmer Dabbelt wrote: The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09

Re: [Qemu-devel] [PATCH v6 28/42] stream: Deal with filters

2019-09-13 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Because of the recent changes that make the stream job independent of > the base node and instead track the node above it, we have to split that > "bottom" node into two cases: The bottom COW node, and the node directly > above the base node (whic

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 17:07, Maxim Levitsky wrote: > On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy wrote: >> 13.09.2019 15:59, Maxim Levitsky wrote: >>> This commit tries to clarify few function arguments, >>> and add comments describing the encrypt/decrypt interface >>> >>> Signed-off-by: M

Re: [Qemu-devel] [PATCH v2 04/16] docs/devel/qapi-code-gen: Minor specification fixes

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> The specification claims "Each expression that isn't an include >> directive may be preceded by a documentation block", but the code also >> rejects them for pragma directives. The code is correct. Fix the >> specification. >>

Re: [Qemu-devel] [PATCH v2 05/16] tests/qapi-schema: Demonstrate bad reporting of funny characters

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> Invalid name 'not\\possible' is reported as 'not\possible'. Control >> characters (quoted or not) are even more confusing. Mark FIXME. >> >> Signed-off-by: Markus Armbruster >> --- >> tests/qapi-schema/enum-bad-name.err |

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Kevin Wolf
Am 13.09.2019 um 16:07 hat Maxim Levitsky geschrieben: > On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy wrote: > > 13.09.2019 15:59, Maxim Levitsky wrote: > > > This commit tries to clarify few function arguments, > > > and add comments describing the encrypt/decrypt interface > >

[Qemu-devel] [Bug 1841592] Re: ppc: softfloat float implementation issues

2019-09-13 Thread Alex Bennée
Dave ran the above testcase on: > processor : 0 > cpu : POWER8E (raw), altivec supported > clock : 3325.00MHz > revision : 2.1 (pvr 004b 0201) And there are no diffs with what you currently get from master. So I think the invalid flag fault is fixed by a previous co

Re: [Qemu-devel] [PATCH v2 06/16] qapi: Restrict strings to printable ASCII

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> RFC 8259 on string contents: >> >>All Unicode characters may be placed within the quotation marks, >>except for the characters that MUST be escaped: quotation mark, >>reverse solidus, and the control characters (U+0

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2019-09-13 Thread Christophe Lyon
How do I activate it since --cpu cortex-m7 isn't supported? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1721275 Title: Support more ARM CPUs Status in QEMU: Won't Fix Bug description: Hi,

Re: [Qemu-devel] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

2019-09-13 Thread Palmer Dabbelt
On Fri, 06 Sep 2019 09:20:05 PDT (-0700), bmeng...@gmail.com wrote: It is not useful if we only have one management CPU. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- Changes in v8: None Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Maxim Levitsky
On Fri, 2019-09-13 at 16:24 +0200, Kevin Wolf wrote: > Am 13.09.2019 um 16:07 hat Maxim Levitsky geschrieben: > > On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy wrote: > > > 13.09.2019 15:59, Maxim Levitsky wrote: > > > > This commit tries to clarify few function arguments, > > > >

Re: [Qemu-devel] [PATCH v2 07/16] qapi: Drop support for escape sequences other than \\

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> Since the previous commit restricted strings to printable ASCII, >> \u's only use is obfuscation. Drop it. >> >> This leaves \\, \/, \', and \". Since QAPI schema strings are all >> names, and names are restricted to ASCI

Re: [Qemu-devel] [PATCH] migration: Fix use-after-free during process exit

2019-09-13 Thread Yury Kotov
Hi Vladimir! 13.09.2019, 16:43, "Vladimir Sementsov-Ogievskiy" : > Hi! > > 08.04.2019 14:33, Yury Kotov wrote: >>  It fixes heap-use-after-free which was found by clang's ASAN. >> >>  Control flow of this use-after-free: >>  main_thread: >>   * Got SIGTERM and completes main loop >>   * Ca

Re: [Qemu-devel] [PULL 00/12] migration queue

2019-09-13 Thread Peter Maydell
On Thu, 12 Sep 2019 at 15:10, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 > 0

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 17:37, Maxim Levitsky wrote: > On Fri, 2019-09-13 at 16:24 +0200, Kevin Wolf wrote: >> Am 13.09.2019 um 16:07 hat Maxim Levitsky geschrieben: >>> On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy wrote: 13.09.2019 15:59, Maxim Levitsky wrote: > This commit tries to

Re: [Qemu-devel] [PATCH v2 09/16] qapi: Permit alternates with just one branch

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> A union or alternate without branches makes no sense and doesn't work: >> it can't be instantiated. A union or alternate with just one branch >> works, but is degenerate. We accept the former, but reject the >> latter. Weird.

Re: [Qemu-devel] [PATCH] tests/tcg: add float_madds test to multiarch

2019-09-13 Thread Paul Clarke
On 9/13/19 8:49 AM, Alex Bennée wrote: > +static float f32_numbers[] = { > +-SNANF, > +-NAN, > +-INFINITY, > +-FLT_MAX, > +-1.111E+31, > +-1.111E+30, > +-1.08700982e-12, > +-1.78051176e-20, > +-FLT_MIN, > +0.0, > +FLT_MIN, > +2.98023224e-08, > +5.

Re: [Qemu-devel] [PATCH v1 4/4] elf: move ELF_ARCH definition to elf-arch.h

2019-09-13 Thread Aleksandar Markovic
On Wed, Sep 11, 2019 at 11:26 AM Alex Bennée wrote: > > Aleksandar Markovic writes: > > > 10.09.2019. 21.34, "Alex Bennée" је написао/ла: > >> > >> This is preparatory for plugins which will want to report the > >> architecture to plugins. Move the ELF_ARCH definition out of the > >> loader and

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Kevin Wolf
Am 13.09.2019 um 16:37 hat Maxim Levitsky geschrieben: > On Fri, 2019-09-13 at 16:24 +0200, Kevin Wolf wrote: > > Am 13.09.2019 um 16:07 hat Maxim Levitsky geschrieben: > > > On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy wrote: > > > > 13.09.2019 15:59, Maxim Levitsky wrote: > > >

[Qemu-devel] [Bug 1721275] Re: Support more ARM CPUs

2019-09-13 Thread Peter Maydell
You can't for an M-profile CPU. It would work without any further coding beyond getting the ID register values right if we had a Cortex-M7 model, though. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

Re: [Qemu-devel] [PATCH v4 1/3] block/qcow2: refactoring of threaded encryption code

2019-09-13 Thread Kevin Wolf
Am 13.09.2019 um 16:44 hat Vladimir Sementsov-Ogievskiy geschrieben: > 13.09.2019 17:37, Maxim Levitsky wrote: > > On Fri, 2019-09-13 at 16:24 +0200, Kevin Wolf wrote: > >> Am 13.09.2019 um 16:07 hat Maxim Levitsky geschrieben: > >>> On Fri, 2019-09-13 at 14:01 +, Vladimir Sementsov-Ogievskiy w

Re: [Qemu-devel] [PATCH] MAINTAINERS: update my email address

2019-09-13 Thread Anthony PERARD
On Fri, Sep 13, 2019 at 01:24:18PM +0100, Paul Durrant wrote: > My Citrix email address will expire shortly. > > Signed-off-by: Paul Durrant > --- > diff --git a/MAINTAINERS b/MAINTAINERS > index 50eaf005f4..3cabb9e449 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -406,7 +406,7 @@ Guest CPU

Re: [Qemu-devel] [PATCH v2 13/16] docs/devel/qapi-code-gen: Rewrite compatibility considerations

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> We have some compatibility advice buried in sections "Enumeration >> types" and "Struct types". Compatibility is actually about commands >> and events. It devolves to the types used there. All kinds of types, >> not just enum

Re: [Qemu-devel] [Bug 1843852] Re: QEMU does not express a dependency on perl-Test-Harness

2019-09-13 Thread John Snow
On 9/13/19 4:33 AM, Alex Bennée wrote: > Given we require python perhaps the simplest solution would be to re- > write the tap-driver as a python script rather than adding another > configure check? > Seems a shame to need to after Paolo *just* introduced this perl script late last year in 9df433

Re: [Qemu-devel] [PATCH v2 14/16] docs/devel/qapi-code-gen: Rewrite introduction to schema

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> The introduction to the QAPI schema is somewhat rambling. Rewrite for >> clarity. > > The curse of additions over time. Thanks for tackling this. > >> >> Signed-off-by: Markus Armbruster >> --- >> docs/devel/qapi-code-gen.t

[Qemu-devel] [PATCH v6 0/6] semihosting cleanups (plus minor tests/tcg tweak)

2019-09-13 Thread Alex Bennée
Hi Peter, I've restored the #ifndef CONFIG_USER_ONLY check to M-profile as well and split the linux-user semihosting smoke check into a new commit. Alex Bennée (6): tests/tcg: clean-up some comments after the de-tangling target/arm: handle M-profile semihosting at translate time target/arm:

[Qemu-devel] [PATCH v6 1/6] tests/tcg: clean-up some comments after the de-tangling

2019-09-13 Thread Alex Bennée
These were missed in the recent de-tangling so have been updated to be more actuate. I've also built up ARM_TESTS in a manner similar to AARCH64_TESTS for better consistency. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell --- tests/tcg/Makefile.target | 7 +-- tests/tcg/aarc

[Qemu-devel] [PATCH v6 3/6] target/arm: handle A-profile semihosting at translate time

2019-09-13 Thread Alex Bennée
As for the other semihosting calls we can resolve this at translate time. Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell --- v2 - update for change to gen_exception_internal_insn API v3 - update for decode tree, merge T32 & A32 commits - dropped r-b due to changes v4 - !IS_USER an

[Qemu-devel] [PATCH v6 6/6] tests/tcg: add linux-user semihosting smoke test for ARM

2019-09-13 Thread Alex Bennée
We already use semihosting for the system stuff so this is a simple smoke test to ensure we are working OK on linux-user. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target | 5 tests/tcg/arm/Makefile.target | 5 tests/tcg/arm/semihosting.c | 45 ++

[Qemu-devel] [PATCH v6 2/6] target/arm: handle M-profile semihosting at translate time

2019-09-13 Thread Alex Bennée
We do this for other semihosting calls so we might as well do it for M-profile as well. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - update for change to gen_exception_internal_insn API v3 - update for decode tree v4 - use !IS_USER v5 - return #ifndef CONFIG_USER -

[Qemu-devel] [PATCH v6 4/6] target/arm: remove run time semihosting checks

2019-09-13 Thread Alex Bennée
Now we do all our checking and use a common EXCP_SEMIHOST for semihosting operations we can make helper code a lot simpler. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - fix re-base conflicts - hoist EXCP_SEMIHOST check - comment cleanups v5 - move CONFIG_TCG ifdefs

[Qemu-devel] [PATCH v6 5/6] target/arm: remove run-time semihosting checks for linux-user

2019-09-13 Thread Alex Bennée
Now we do all our checking at translate time we can make cpu_loop a little bit simpler. We also introduce a simple linux-user semihosting test case to defend the functionality. The out-of-tree softmmu based semihosting tests are still more comprehensive. Signed-off-by: Alex Bennée --- linux-user

Re: [Qemu-devel] [PATCH v8 18/32] riscv: sifive_u: Set the minimum number of cpus to 2

2019-09-13 Thread Bin Meng
Hi Palmer, On Fri, Sep 13, 2019 at 10:33 PM Palmer Dabbelt wrote: > > On Fri, 06 Sep 2019 09:20:05 PDT (-0700), bmeng...@gmail.com wrote: > > It is not useful if we only have one management CPU. > > > > Signed-off-by: Bin Meng > > Reviewed-by: Alistair Francis > > > > --- > > > > Changes in v8:

[Qemu-devel] [PATCH v2 2/2] blockdev: honor bdrv_try_set_aio_context() context requirements

2019-09-13 Thread Sergio Lopez
bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the ocurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 121 + 1 file changed,

[Qemu-devel] [PATCH v2 0/2] blockdev: avoid acquiring AioContext lock twice at do_drive_backup()

2019-09-13 Thread Sergio Lopez
do_drive_backup() acquires the AioContext lock of the corresponding BlockDriverState. This is not a problem when it's called from qmp_drive_backup(), but drive_backup_prepare() also acquires the lock before calling it. Additionally, Max Reitz pointed out that bdrv_try_set_aio_context() is called a

[Qemu-devel] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare

2019-09-13 Thread Sergio Lopez
do_drive_backup() already acquires the AioContext, so release it before the call. Signed-off-by: Sergio Lopez --- blockdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index fbef6845c8..3927fdab80 100644 --- a/blockdev.c +++ b/blockdev.c @@ -

[Qemu-devel] [PATCH v5 3/3] qemu-iotests: Add test for bz #1745922

2019-09-13 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- tests/qemu-iotests/263 | 91 ++ tests/qemu-iotests/263.out | 40 + tests/qemu-iotests/group | 2 + 3 files changed, 133 insertions(+) create mode 100755 tests/qemu-iotests/263 create mode 100644 tests/q

[Qemu-devel] [PATCH v5 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-13 Thread Maxim Levitsky
Commit 8ac0f15f335 accidently broke the COW of non changed areas of newly allocated clusters, when the write spans multiple clusters, and needs COW both prior and after the write. This results in 'after' COW area being encrypted with wrong sector address, which render it corrupted. Bugzilla: https

[Qemu-devel] [PATCH v5 1/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-13 Thread Maxim Levitsky
This fixes subtle corruption introduced by luks threaded encryption in commit 8ac0f15f335 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922 The corruption happens when we do a write that * writes to two or more unallocated clusters at once * doesn't fully cover the first sector

[Qemu-devel] [PATCH v5 2/3] block/qcow2: refactor threaded encryption code

2019-09-13 Thread Maxim Levitsky
Change do_perform_cow_encrypt and its callee qcow2_co_encrypt to just receive full host and guest offsets and in pariticular remove the offset_in_cluster parameter of do_perform_cow_encrypt, since it is misleading, because that offset can be larger than cluster size currently. Also document the qc

Re: [Qemu-devel] [PATCH v3 3/3] xen: perform XenDevice clean-up in XenBus watch handler

2019-09-13 Thread Anthony PERARD
On Fri, Sep 13, 2019 at 09:21:58AM +0100, Paul Durrant wrote: > Cleaning up offline XenDevice objects directly in > xen_device_backend_changed() is dangerous as xen_device_unrealize() will > modify the watch list that is being walked. Even the QLIST_FOREACH_SAFE() > used in notifier_list_notify() i

Re: [Qemu-devel] [PATCH v2 15/16] docs/devel/qapi-code-gen: Improve QAPI schema language doc

2019-09-13 Thread Markus Armbruster
Eric Blake writes: > On 9/10/19 1:37 AM, Markus Armbruster wrote: >> We document the language by giving patterns of valid JSON objects. >> The patterns contain placeholders we don't define anywhere; their >> names have to speak for themselves. I guess they do, but I'd prefer a >> bit more rigor.

Re: [Qemu-devel] [PATCH v11 00/14] backup-top filter driver for backup

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
10.09.2019 13:23, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > These series introduce backup-top driver. It's a filter-node, which > do copy-before-write operation. Mirror uses filter-node for handling > guest writes, let's move to filter-node (from write-notifiers) for > backup too. > > v11

Re: [Qemu-devel] [PATCH v5 1/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 18:28, Maxim Levitsky wrote: > This fixes subtle corruption introduced by luks threaded encryption > in commit 8ac0f15f335 > > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1745922 > > The corruption happens when we do a write that > * writes to two or more unallocated clus

Re: [Qemu-devel] [PATCH v8 01/13] vfio: KABI for migration interface

2019-09-13 Thread Alex Williamson
On Thu, 12 Sep 2019 23:00:03 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Thursday, September 12, 2019 10:41 PM > > > > On Tue, 3 Sep 2019 06:57:27 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson [mailto:alex.william...@r

[Qemu-devel] [PULL 04/12] aspeed: Use consistent typenames

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater Improve the naming of the different controller models to ease their generation when initializing the SoC. The rename of the SMC types is breaking migration compatibility. Signed-off-by: Cédric Le Goater Message-id: 20190904070506.1052-5-...@kaod.org Reviewed-by: Peter May

[Qemu-devel] [PULL 00/12] target-arm queue

2019-09-13 Thread Peter Maydell
in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20190913 for you to fetch changes up to 27a296fce9821e3608d537756cffa6e43a46df3b: qemu-ga: Convert invocation documentation to rST (2019-09-13 16:0

[Qemu-devel] [PULL 03/12] aspeed: Remove unused SoC definitions

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater There are no QEMU Aspeed machines using the SoCs "ast2400-a0" or "ast2400". Signed-off-by: Cédric Le Goater Message-id: 20190904070506.1052-4-...@kaod.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/aspeed_soc.c | 26 -- 1

[Qemu-devel] [PULL 08/12] aspeed/smc: Calculate checksum on normal DMA

2019-09-13 Thread Peter Maydell
From: Christian Svensson This patch adds the missing checksum calculation on normal DMA transfer. According to the datasheet this is how the SMC should behave. Verified on AST1250 that the hardware matches the behaviour. Signed-off-by: Christian Svensson Reviewed-by: Joel Stanley Signed-off-b

[Qemu-devel] [PULL 01/12] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

2019-09-13 Thread Peter Maydell
From: Rashmica Gupta GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC. (Note that the ast2400 controller only goes up to group AB). A set has four groups (except set AC which only has one) and is referred to by the groups it is composed of (eg ABCD,EFGH,...,YZAAAB). Each set

[Qemu-devel] [PULL 09/12] aspeed/scu: Introduce per-SoC SCU types

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater and use a class AspeedSCUClass to define each SoC characteristics. Signed-off-by: Cédric Le Goater Message-id: 20190904070506.1052-10-...@kaod.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/hw/misc/aspeed_scu.h | 15 +++ hw/arm/aspeed_soc.c

[Qemu-devel] [PULL 02/12] aspeed: add a GPIO controller to the SoC

2019-09-13 Thread Peter Maydell
From: Rashmica Gupta Signed-off-by: Rashmica Gupta Reviewed-by: Cédric Le Goater Signed-off-by: Cédric Le Goater Message-id: 20190904070506.1052-3-...@kaod.org Signed-off-by: Peter Maydell --- include/hw/arm/aspeed_soc.h | 3 +++ hw/arm/aspeed_soc.c | 17 + 2 files c

[Qemu-devel] [PULL 11/12] atomic_template: fix indentation in GEN_ATOMIC_HELPER

2019-09-13 Thread Peter Maydell
From: "Emilio G. Cota" Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- accel/tcg/atomic_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/atomic_template.

[Qemu-devel] [PULL 06/12] aspeed/smc: Add DMA calibration settings

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater When doing calibration, the SPI clock rate in the CE0 Control Register and the read delay cycles in the Read Timing Compensation Register are set using bit[11:4] of the DMA Control Register. Signed-off-by: Cédric Le Goater Acked-by: Joel Stanley Reviewed-by: Peter Maydel

Re: [Qemu-devel] [Bug 1843852] Re: QEMU does not express a dependency on perl-Test-Harness

2019-09-13 Thread John Snow
On 9/13/19 11:06 AM, Paolo Bonzini wrote: > On 13/09/19 16:56, John Snow wrote: >> >> >> On 9/13/19 4:33 AM, Alex Bennée wrote: >>> Given we require python perhaps the simplest solution would be to re- >>> write the tap-driver as a python script rather than adding another >>> configure check? >> >>

[Qemu-devel] [PULL 05/12] aspeed/smc: Add support for DMAs

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater The FMC controller on the Aspeed SoCs support DMA to access the flash modules. It can operate in a normal mode, to copy to or from the flash module mapping window, or in a checksum calculation mode, to evaluate the best clock settings for reads. The model introduces two cu

[Qemu-devel] [PULL 07/12] aspeed/smc: Inject errors in DMA checksum

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater Emulate read errors in the DMA Checksum Register for high frequencies and optimistic settings of the Read Timing Compensation Register. This will help in tuning the SPI timing calibration algorithm. Errors are only injected when the property "inject_failure" is set to true

[Qemu-devel] [PULL 12/12] qemu-ga: Convert invocation documentation to rST

2019-09-13 Thread Peter Maydell
The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

[Qemu-devel] [PULL 10/12] aspeed/scu: Introduce a aspeed_scu_get_apb_freq() routine

2019-09-13 Thread Peter Maydell
From: Cédric Le Goater The APB frequency can be calculated directly when needed from the HPLL_PARAM and CLK_SEL register values. This removes useless state in the model. Signed-off-by: Cédric Le Goater Message-id: 20190904070506.1052-11-...@kaod.org Reviewed-by: Peter Maydell Signed-off-by: Pe

Re: [Qemu-devel] [PATCH v5 2/3] block/qcow2: refactor threaded encryption code

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 18:28, Maxim Levitsky wrote: > Change do_perform_cow_encrypt and its callee qcow2_co_encrypt > to just receive full host and guest offsets and in pariticular > remove the offset_in_cluster parameter of do_perform_cow_encrypt, > since it is misleading, because that offset can be larger th

Re: [Qemu-devel] [PATCH v5 3/3] qemu-iotests: Add test for bz #1745922

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 18:28, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/263 | 91 ++ > tests/qemu-iotests/263.out | 40 + > tests/qemu-iotests/group | 2 + > 3 files changed, 133 insertions(+) > create mod

Re: [Qemu-devel] [PATCH v5 2/3] block/qcow2: refactor threaded encryption code

2019-09-13 Thread Maxim Levitsky
On Fri, 2019-09-13 at 16:11 +, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2019 18:28, Maxim Levitsky wrote: > > Change do_perform_cow_encrypt and its callee qcow2_co_encrypt > > to just receive full host and guest offsets and in pariticular > > remove the offset_in_cluster parameter of do_perf

[Qemu-devel] [PATCH 2/2] migration/rdma.c: Swap synchronize_rcu for call_rcu

2019-09-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This fixes a deadlock that can occur on the migration source after a failed RDMA migration; as the source tries to cleanup it clears a pair of pointers and uses synchronize_rcu to wait; this is happening on the main thread. With the CPUs running a CPU thread can b

[Qemu-devel] [PATCH 0/2] migration/rdma disconnect fixes

2019-09-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This fixes a deadlock that can occur on the source after a failed RDMA migration and cleans up some warning messages that can appear during normal completion. https://bugzilla.redhat.com/show_bug.cgi?id=1746787 Dr. David Alan Gilbert (2): migration/rdma: D

[Qemu-devel] [PATCH] 9p: Print error hints if option parsing fails

2019-09-13 Thread Greg Kurz
Option parsing fonctions are called with &error_fatal, which causes error_setg() to call exit() and the hints are never printed. Use an intermediate error object so that exit() happens in error_propagate() after error_append_hint() could be called. Signed-off-by: Greg Kurz --- hw/9pfs/9p-local.

[Qemu-devel] [PATCH 1/2] migration/rdma: Don't moan about disconnects at the end

2019-09-13 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If we've already finished the migration or something has already gone wrong, don't moan about the migration stream disconnecting. Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff -

Re: [Qemu-devel] [PATCH v5 3/3] qemu-iotests: Add test for bz #1745922

2019-09-13 Thread Maxim Levitsky
On Fri, 2019-09-13 at 16:27 +, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2019 18:28, Maxim Levitsky wrote: > > Signed-off-by: Maxim Levitsky > > --- > > tests/qemu-iotests/263 | 91 ++ > > tests/qemu-iotests/263.out | 40 + > > test

Re: [Qemu-devel] [PATCH v5 3/3] qemu-iotests: Add test for bz #1745922

2019-09-13 Thread Vladimir Sementsov-Ogievskiy
13.09.2019 19:39, Maxim Levitsky wrote: > On Fri, 2019-09-13 at 16:27 +, Vladimir Sementsov-Ogievskiy wrote: >> 13.09.2019 18:28, Maxim Levitsky wrote: >>> Signed-off-by: Maxim Levitsky >>> --- >>>tests/qemu-iotests/263 | 91 ++ >>>tests/qemu-iote

Re: [Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions

2019-09-13 Thread Greg Kurz
On Thu, 5 Sep 2019 12:42:01 +0200 Christian Schoenebeck wrote: > This is v7 of a proposed patch set for fixing file ID collisions with 9pfs. > So I did some changes in 1/3 and pushed everything to 9p-next. I'll do some more manual testing and issue a PR when I'm confident enough. It would be n

Re: [Qemu-devel] [PATCH v5 3/3] qemu-iotests: Add test for bz #1745922

2019-09-13 Thread Maxim Levitsky
On Fri, 2019-09-13 at 16:57 +, Vladimir Sementsov-Ogievskiy wrote: > 13.09.2019 19:39, Maxim Levitsky wrote: > > On Fri, 2019-09-13 at 16:27 +, Vladimir Sementsov-Ogievskiy wrote: > > > 13.09.2019 18:28, Maxim Levitsky wrote: > > > > Signed-off-by: Maxim Levitsky > > > > --- > > > >tes

[Qemu-devel] [PATCH v6 2/3] block/qcow2: refactor threaded encryption code

2019-09-13 Thread Maxim Levitsky
Change the qcow2_co_encrypt to just receive full host and guest offsets and in pariticular remove the offset_in_cluster parameter of do_perform_cow_encrypt, since it is misleading, because that offset can be larger than cluster size currently. Remove the do_perform_cow_encrypt by merging it with q

[Qemu-devel] [PATCH v6 0/3] Fix qcow2+luks corruption introduced by commit 8ac0f15f335

2019-09-13 Thread Maxim Levitsky
Commit 8ac0f15f335 accidently broke the COW of non changed areas of newly allocated clusters, when the write spans multiple clusters, and needs COW both prior and after the write. This results in 'after' COW area being encrypted with wrong sector address, which render it corrupted. Bugzilla: https

<    1   2   3   >