13.09.2019 19:39, Maxim Levitsky wrote: > On Fri, 2019-09-13 at 16:27 +0000, Vladimir Sementsov-Ogievskiy wrote: >> 13.09.2019 18:28, Maxim Levitsky wrote: >>> Signed-off-by: Maxim Levitsky <mlevi...@redhat.com> >>> --- >>> tests/qemu-iotests/263 | 91 ++++++++++++++++++++++++++++++++++++++ >>> tests/qemu-iotests/263.out | 40 +++++++++++++++++ >>> tests/qemu-iotests/group | 2 + >>> 3 files changed, 133 insertions(+) >>> create mode 100755 tests/qemu-iotests/263 >>> create mode 100644 tests/qemu-iotests/263.out >>> >>> diff --git a/tests/qemu-iotests/263 b/tests/qemu-iotests/263 >>> new file mode 100755 >>> index 0000000000..d2c030fae9 >>> --- /dev/null >>> +++ b/tests/qemu-iotests/263 >> >> [..] >> >>> --- a/tests/qemu-iotests/group >>> +++ b/tests/qemu-iotests/group >>> @@ -274,5 +274,7 @@ >>> 257 rw >>> 258 rw quick >>> 262 rw quick migration >>> +263 rw quick >>> 265 rw auto quick >>> 266 rw quick >>> +>>>>>>> patched >>> >> >> last line is a mistake. > Last minute merge mistake :-( > >> >> also, test failed for me: >> >> 263 fail [19:21:35] [19:21:35] output mismatch >> (see 263.out.bad) >> --- /work/src/qemu/maxim-luks/tests/qemu-iotests/263.out 2019-09-13 >> 19:11:45.464727427 +0300 >> +++ /work/src/qemu/maxim-luks/tests/qemu-iotests/263.out.bad 2019-09-13 >> 19:21:35.535381253 +0300 >> @@ -2,6 +2,7 @@ >> >> testing LUKS qcow2 encryption >> >> +qemu-img: TEST_DIR/t.IMGFMT: No crypto library supporting PBKDF in this >> build: Function not implemented >> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 >> encrypt.format=luks encrypt.key-secret=sec0 encrypt.iter-time=10 >> == reading the whole image == >> read 1048576/1048576 bytes at offset 0 >> Failures: 263 >> Failed 1 of 1 tests >> >> >> and if reconfigure with >> --enable-gnutls --enable-gcrypt --enable-vhost-crypto >> --enable-crypto-afalg >> (don't know which one is actually needed) >> it works.. >> >> so, we at least should skip the test if it's unsupported > Don't know. I based this test on 188 and it also doesn't have anything > special about this. > Its not in auto group though. > I guess we need to ask Daniel about this. > >
Hmm, the problem was not in "configure" arguments, seems needed thing is enabled by default, but actually all works for me after installing gnutls-devel and without it 188 don't work without it (or some its dependencies) too. So it's "not a regression" and I'dont care: Tested-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> [don't forget to drop ">>>>>>> patched"] and I also checked that test fails if position it before patch 01, so it's true bug-catcher. -- Best regards, Vladimir
