[Qemu-devel] [PATCH v13 1/6] Wrapper function to wait on condition for the main loop mutex

2019-09-09 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad Reviewe

[Qemu-devel] [PATCH v13 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-09-09 Thread Aravinda Prasad
This patch set adds support for FWNMI in PowerKVM guests. System errors such as SLB multihit and memory errors that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exceptions, if the address in error belon

[Qemu-devel] [PATCH v13 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-09 Thread Aravinda Prasad
Introduce the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. This patch als

[Qemu-devel] [PATCH v13 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-09 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls and sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also

[Qemu-devel] [PATCH v13 3/6] target/ppc: Handle NMI guest exit

2019-09-09 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then the guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI in

[Qemu-devel] [PATCH v13 6/6] migration: Include migration support for machine check handling

2019-09-09 Thread Aravinda Prasad
This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as (i) these errors are specific to the source hardware and is irrelevant on the target hardware, (ii) these errors cause data corr

[Qemu-devel] [PATCH v13 4/6] target/ppc: Build rtas error log upon an MCE

2019-09-09 Thread Aravinda Prasad
Upon a machine check exception (MCE) in a guest address space, KVM causes a guest exit to enable QEMU to build and pass the error to the guest in the PAPR defined rtas error log format. This patch builds the rtas error log, copies it to the rtas_addr and then invokes the guest registered machine c

[Qemu-devel] [PATCH] ui/egl: fix framebuffer reads

2019-09-09 Thread Gerd Hoffmann
Fix egl_fb_read() to use the (destination) surface size instead of the (source) framebuffer source for glReadPixels. Pass the DisplaySurface instead of the pixeldata pointer to egl_fb_read() to make this possible. With that in place framebuffer reads work fine even if the surface and framebuffer

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

2019-09-09 Thread Max Reitz
On 03.09.19 10:32, Vladimir Sementsov-Ogievskiy wrote: > 02.09.2019 17:35, Max Reitz wrote: >> On 31.08.19 11:57, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: This includes some permission limiting (for example, we only need to take the RESIZE permission for

Re: [Qemu-devel] [PATCH] ui/egl: fix framebuffer reads

2019-09-09 Thread Marc-André Lureau
Hi On Mon, Sep 9, 2019 at 11:40 AM Gerd Hoffmann wrote: > > Fix egl_fb_read() to use the (destination) surface size instead of the > (source) framebuffer source for glReadPixels. Pass the DisplaySurface > instead of the pixeldata pointer to egl_fb_read() to make this possible. > > With that in p

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Max Reitz
On 04.09.19 18:16, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> There are BDS children that the general block layer code can access, >> namely bs->file and bs->backing. Since the introduction of filters and >> external data files, their meaning is not quite clear. bs->

Re: [Qemu-devel] [PATCH v7 1/4] block: Add zoned device model property

2019-09-09 Thread Stefano Garzarella
On Sat, Sep 07, 2019 at 06:38:38PM -0400, Dmitry Fomichev wrote: > This commit adds Zoned Device Model (as defined in T10 ZBC and > T13 ZAC standards) as a block driver property, along with some > useful access functions. > > A new backend driver permission, BLK_PERM_SUPPORT_HM_ZONED, is also > in

Re: [Qemu-devel] [PATCH v6 09/42] block: Include filters when freezing backing chain

2019-09-09 Thread Max Reitz
On 05.09.19 15:05, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> In order to make filters work in backing chains, the associated >> functions must be able to deal with them and freeze all filter links, be >> they COW or R/W filter links. >> >> In the process, rename these

Re: [Qemu-devel] [PATCH v6 11/42] block: Add bdrv_supports_compressed_writes()

2019-09-09 Thread Max Reitz
On 05.09.19 15:11, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> Filters cannot compress data themselves but they have to implement >> .bdrv_co_pwritev_compressed() still (or they cannot forward compressed >> writes). Therefore, checking whether >> bs->drv->bdrv_co_pwrit

Re: [Qemu-devel] [PATCH v2 1/2] linux-user: remove useless variable

2019-09-09 Thread Stefano Garzarella
On Sun, Sep 08, 2019 at 12:48:15PM +0200, Laurent Vivier wrote: > filename is only used to open the file if AT_EXECFD is not provided. > But exec_path already contains the path of the file to open. > Remove filename as it is only used in main.c whereas exec_path is > also used in syscall.c. > > Fi

Re: [Qemu-devel] [PATCH v6 14/42] block: Use CAFs when working with backing chains

2019-09-09 Thread Max Reitz
On 05.09.19 16:05, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> Use child access functions when iterating through backing chains so >> filters do not break the chain. >> >> Signed-off-by: Max Reitz >> --- >> block.c | 40 >> 1 f

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-09 Thread Max Reitz
On 05.09.19 18:24, Kevin Wolf wrote: > Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: >> On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: If the driver does not support .bdrv_co_flush() so bdrv_co_flush() itself has to flush the children of

Re: [Qemu-devel] [PULL v2 0/9] NBD patches through 2019-09-05

2019-09-09 Thread Peter Maydell
On Thu, 5 Sep 2019 at 22:17, Eric Blake wrote: > > The following changes since commit eac2f39602e0423adf56be410c9a22c31fec9a81: > > target/arm: Inline gen_bx_im into callers (2019-09-05 13:23:04 +0100) > > are available in the Git repository at: > > https://repo.or.cz/qemu/ericb.git tags/pull-

Re: [Qemu-devel] [EXTERNAL]Re: Proposal for amending TCG interface naming scheme

2019-09-09 Thread Aleksandar Markovic
wrote: > > ... > > tcg_gen_extend_s_i32_i64 > > tcg_gen_extend_0_i32_i64 > > These should not drift too far from the other extension names, > > tcg_gen_ext{8,16}{u,s}_i32 > tcg_gen_ext{8,16,32}{u,s}_i64 > > What if we use the AArch64 mnemonics: zxt (zero-extend) and sxt (sign-extend)? > T

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-09-09 Thread Max Reitz
On 03.09.19 10:06, Vladimir Sementsov-Ogievskiy wrote: > 02.09.2019 19:34, Max Reitz wrote: [...] >> I’m not saying that we need to abandon having BBs right now, but I think >> there are a couple of cases which show why I say it’s uglier than using >> BdrvChildren instead. >> > > OK. I'd prefer

Re: [Qemu-devel] [PATCH] nbd/client: Add hint when TLS is missing

2019-09-09 Thread Daniel P . Berrangé
On Sat, Sep 07, 2019 at 12:20:55PM -0500, Eric Blake wrote: > I received an off-list report of failure to connect to an NBD server > expecting an x509 certificate, when the client was attempting something > similar to this command line: > > $ ./x86_64-softmmu/qemu-system-x86_64 -name 'blah' -machi

[Qemu-devel] [Bug 1843151] Re: Regression: QEMU 4.1.0 qxl and KMS resoluiton only 4x10

2019-09-09 Thread Dr. David Alan Gilbert
Hi, Can you give the full qemu commandline you're using on 4.1.0 please? (If you're starting it using libvirt/virsh then please include the xml description file for the VM). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-09-09 Thread Max Reitz
On 05.09.19 19:27, John Snow wrote: [...] > You also probably require review (or at least an ACK) from Keith Busch > who maintains this file. Keith actually maintains the NVMe guest device; technically, Fam is the NVMe block driver maintainer. Max signature.asc Description: OpenPGP digital s

Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment

2019-09-09 Thread Philippe Mathieu-Daudé
On 9/9/19 5:14 AM, Mao Zhongyi wrote: > Signed-off-by: Mao Zhongyi > --- > hw/pci/pci_bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c > index 715b9a4fe6..97967d12eb 100644 > --- a/hw/pci/pci_bridge.c > +++ b/hw/pci/pci_b

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > On 04.09.19 18:16, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> There are BDS children that the general block layer code can access, > >> namely bs->file and bs->backing. Since the introduction of filters and > >>

Re: [Qemu-devel] [PATCH v6 09/42] block: Include filters when freezing backing chain

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 10:02 hat Max Reitz geschrieben: > On 05.09.19 15:05, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> In order to make filters work in backing chains, the associated > >> functions must be able to deal with them and freeze all filter links, be > >> they

[Qemu-devel] [PATCH] tests/docker: update Debian Sid image

2019-09-09 Thread Alex Bennée
While we are not currently using it we might as well keep the image for later usage. So: - update to a more recent snapshot - clean up verbiage in commentary - remove duplicate shell from a merge failure Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/doc

Re: [Qemu-devel] [PATCH] tests/docker: update Debian Sid image

2019-09-09 Thread Philippe Mathieu-Daudé
On 9/9/19 11:48 AM, Alex Bennée wrote: > While we are not currently using it we might as well keep the image > for later usage. So: > > - update to a more recent snapshot > - clean up verbiage in commentary > - remove duplicate shell from a merge failure Thank you :) FYI I'm using this ima

Re: [Qemu-devel] [PATCH v1 22/42] tests/docker: drop powerpc-user image for QEMU cross builds

2019-09-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 9/4/19 10:29 PM, Alex Bennée wrote: >> Now Jessie has entered LTS the powerpc architecture has been dropped >> so we can no longer build the image from scratch. We will still >> support a minimal powerpc-cross image for building testcases. > > This one still

Re: [Qemu-devel] [PATCH v6 14/42] block: Use CAFs when working with backing chains

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 10:25 hat Max Reitz geschrieben: > On 05.09.19 16:05, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> Use child access functions when iterating through backing chains so > >> filters do not break the chain. > >> > >> Signed-off-by: Max Reitz > >> --- >

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 10:31 hat Max Reitz geschrieben: > On 05.09.19 18:24, Kevin Wolf wrote: > > Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: > >> On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > >>> 09.08.2019 19:13, Max Reitz wrote: > If the driver does not support .bdrv_co_flush()

Re: [Qemu-devel] [PATCH v2 1/3] iotests: add script_initialize

2019-09-09 Thread Max Reitz
On 29.07.19 23:35, John Snow wrote: > Like script_main, but doesn't require a single point of entry. > Replace all existing initialization sections with this drop-in replacement. > > This brings debug support to all existing script-style iotests. > > Note: supported_oses=['linux'] was omitted, as

Re: [Qemu-devel] [PATCH v2 2/3] iotests: add protocol support to initialization info

2019-09-09 Thread Max Reitz
On 29.07.19 23:35, John Snow wrote: > This will add supported_protocols and unsupported_protocols to all of > iotests.main, iotests.script_main, and iotests.script_initialize. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/207| 4 ++-- > tests/qemu-iotests/210| 4 ++-- >

[Qemu-devel] qcow2 lock

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
Hi! I have a (may be stupid) question: what is BDRVQcow2State.lock for and when should it be locked? I faced SIGSEGV here: #0 qcow2_process_discards (bs=bs@entry=0x564b93bc8000, ret=ret@entry=0) at block/qcow2-refcount.c:737 #1 0x564b90e9f15f in qcow2_cluster_discard (bs=bs@entry=0x564b

Re: [Qemu-devel] [PATCH v2 3/3] iotests: use python logging for iotests.log()

2019-09-09 Thread Max Reitz
On 29.07.19 23:35, John Snow wrote: > We can turn logging on/off globally instead of per-function. > > Remove use_log from run_job, and use python logging to turn on > diffable output when we run through a script entry point. > > iotest 245 changes output order due to buffering reasons. > > Sign

Re: [Qemu-devel] [PATCH 0/3] target/mips: Convert to do_transaction_failed hook

2019-09-09 Thread Aleksandar Markovic
ping for Hervé. 22.08.2019. 20.16, "Aleksandar Markovic" је написао/ла: > > > 02.08.2019. 18.05, "Peter Maydell" је написао/ла: > > > > This patchset converts the MIPS target away from the > > old broken do_unassigned_access hook to the new (added in > > 2017...) do_transaction_failed hook. > >

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Add test for bz #1745922

2019-09-09 Thread Daniel P . Berrangé
On Fri, Sep 06, 2019 at 10:57:50PM +0300, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/263 | 75 ++ > tests/qemu-iotests/263.out | 19 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 95 insertions(+) >

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-09 Thread Chris Heinze
hi, On 9/8/19 1:29 AM, Samuel Thibault wrote: >> 16:49:39.430959 IP 10.0.2.2.33294 > 10.0.2.15.19003: UDP, bad length 9000 > >> 1472 > > tcpdump seems to be showing dumb output here. The packet is fragmented > by slirp, which makes tcpdump confused and show only the first > fragment. If you let

Re: [Qemu-devel] qcow2 lock

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > I have a (may be stupid) question: what is BDRVQcow2State.lock for and when > should it be locked? > > > I faced SIGSEGV here: > > #0 qcow2_process_discards (bs=bs@entry=0x564b93bc8000, ret=ret@entry=0) at > block

[Qemu-devel] [PATCH v6 0/3] High downtime with 95+ throttle pct

2019-09-09 Thread Yury Kotov
Hi, V6: * Fix "Add qemu_cond_timedwait" patch: - Changed return type for qemu_cond_timedwait (void -> bool) - Added details in commit message V5: * Updated sleep loop in throttle_thread at the suggestion of Paolo Bonzini * Fixed hanging of test V4: * The test was simplified to prevent false

[Qemu-devel] [PATCH v6 2/3] cpus: Fix throttling during vm_stop

2019-09-09 Thread Yury Kotov
Throttling thread sleeps in VCPU thread. For high throttle percentage this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. vm_stop() kicks all VCPUs and waits for them. It's called at the end of migration and because of the long sleep the migration downtime might be more than 100ms e

[Qemu-devel] [PATCH v6 3/3] tests/migration: Add a test for auto converge

2019-09-09 Thread Yury Kotov
Signed-off-by: Yury Kotov Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 120 + 1 file changed, 109 insertions(+), 11 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index a9f81cc185..7064b341e7 100644 --- a/tes

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-09 Thread Philippe Mathieu-Daudé
Hi Samuel, On 9/8/19 1:29 AM, Samuel Thibault wrote: > > Now, with MTU set to 9000, the packets just don't go at all. Could you > try the attached patch? The lowest layer of slirp was indeed limited to > 1600-byte frames for no good reason. With this and the virtio driver, I > could exchange 9000-

[Qemu-devel] [PATCH v6 1/3] qemu-thread: Add qemu_cond_timedwait

2019-09-09 Thread Yury Kotov
The new function is needed to implement conditional sleep for CPU throttling. It's possible to reuse qemu_sem_timedwait, but it's more difficult than just add qemu_cond_timedwait. Also moved compute_abs_deadline function up the code to reuse it in qemu_cond_timedwait_impl win32. Signed-off-by: Yu

Re: [Qemu-devel] [PATCH 2/3] block/qcow2: fix the corruption when rebasing luks encrypted files

2019-09-09 Thread Kevin Wolf
Am 06.09.2019 um 21:17 hat Eric Blake geschrieben: > > -assert((offset_in_cluster & ~BDRV_SECTOR_MASK) == 0); > > +assert((guest_offset & ~BDRV_SECTOR_MASK) == 0); > > +assert((host_offset & ~BDRV_SECTOR_MASK) == 0); > > assert((bytes & ~BDRV_SECTOR_MASK) == 0); >

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-09 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le lun. 09 sept. 2019 12:51:23 +0200, a ecrit: > Anyhow, if you plan to properly (with your S-o-b) commit your patch to > the libslirp repository, Actually the libslirp repository already has something there. Since IPv4/6 have a maximum of 64KB packets, it just allo

Re: [Qemu-devel] qcow2 lock

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 13:47, Kevin Wolf wrote: > Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> I have a (may be stupid) question: what is BDRVQcow2State.lock for and when >> should it be locked? >> >> >> I faced SIGSEGV here: >> >> #0 qcow2_process_discards (bs=bs@entry=0

Re: [Qemu-devel] [PATCH v6 0/3] High downtime with 95+ throttle pct

2019-09-09 Thread Paolo Bonzini
On 09/09/19 12:49, Yury Kotov wrote: > Hi, > > V6: > * Fix "Add qemu_cond_timedwait" patch: > - Changed return type for qemu_cond_timedwait (void -> bool) > - Added details in commit message > > V5: > * Updated sleep loop in throttle_thread at the suggestion of Paolo Bonzini > * Fixed hanging

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Johannes Berg
On Sun, 2019-09-08 at 09:13 -0400, Michael S. Tsirkin wrote: > > I think the only use for this extension would be for simulation > > purposes, and even then only combined with the REPLY_ACK and SLAVE_REQ > > extensions, i.e. you explicitly *want* your virtual machine to lock up / > > wait for a re

[Qemu-devel] [Bug 1843254] [NEW] HCR.TID3 traps are not implemented

2019-09-09 Thread Udo Steinberg
Public bug reported: On ARM (aarch64), HCR_EL2.TID3 [bit18] is supposed to trap ID group 3, which includes the ID_AA64{PFR,DFR,ISAR,MMFR,AFR}*_EL1 registers. However, setting that HCR bit has no effect and accesses to those ID registers are not trapped to EL2 with an EC syndrome value of 0x18. **

[Qemu-devel] [PATCH] tests/docker: pin powerpc-user-cross to a snapshot

2019-09-09 Thread Alex Bennée
Now Jessie has entered LTS the powerpc architecture has been dropped so we can no longer build the image from scratch. However we can use the snapshot archive to build the last working version. This now only lives on an example of setting up a user-cross image as at least on x86-64 we can use the

Re: [Qemu-devel] DMARC/DKIM and qemu-devel list settings

2019-09-09 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 3 Sep 2019 at 20:11, Ian Kelling wrote: >> I don't know who has the Qemu-devel list admin password, but whoever has >> it can adopt the unmodified message fix by changing >> dmarc_moderation_action to Accept here: >> https://lists.nongnu.org/mailman/admin/qemu-dev

[Qemu-devel] [Bug 1843254] Re: HCR.TID3 traps are not implemented

2019-09-09 Thread Peter Maydell
Yes, we don't currently implement most of the 'trap system register access' bits in HCR_EL2. Last time I checked we were missing TID0 TID1 TID2 TID3 TIDCP TAC TSW TPC TPU TTLB TVM TRVM TDZ, but it's possible we've implemented one or two of those since then. ** Changed in: qemu Status: New

Re: [Qemu-devel] [PATCH] tests/docker: update Debian Sid image

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909094816.1970-1-alex.ben...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN =

Re: [Qemu-devel] qcow2 lock

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 13:47, Kevin Wolf wrote: > Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> I have a (may be stupid) question: what is BDRVQcow2State.lock for and when >> should it be locked? >> >> >> I faced SIGSEGV here: >> >> #0 qcow2_process_discards (bs=bs@entry=0

Re: [Qemu-devel] [PATCH v10 02/14] block/backup: split shareable copying part from backup_do_cow

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying logic which will be shared with backup-top filter. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 47 --- > 1 file changed, 32 insertions(+), 15 deletions(

Re: [Qemu-devel] [PATCH] tests/docker: update Debian Sid image

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909094816.1970-1-alex.ben...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash m

Re: [Qemu-devel] [PATCH v10 03/14] block/backup: improve comment about image fleecing

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [qemu-web RFC PATCH] Update to Jekyll 4.0

2019-09-09 Thread Stefan Hajnoczi
On Fri, Sep 06, 2019 at 01:06:49PM +0200, Thomas Huth wrote: > - Update versions in Gemfile > - "has_key?" has to be renamed to "key?" in category_archive_plugin.rb > - Add .jekyll-cache to .gitignore file > > Signed-off-by: Thomas Huth > --- > .gitignore | 1 + > Gemfi

[Qemu-devel] [PATCH qemu-web] use precompiled sassc

2019-09-09 Thread Paolo Bonzini
--- Gemfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Gemfile b/Gemfile index 200f2c4..b76a4fd 100644 --- a/Gemfile +++ b/Gemfile @@ -22,3 +22,6 @@ gem "minima", "~> 2.5" group :jekyll_plugins do gem "jekyll-feed", "~> 0.12" end + +# for https://github.com/sass/sassc-ruby/issues

Re: [Qemu-devel] [RFC 0/3] virtiofsd: get/set log level via DBus

2019-09-09 Thread Stefan Hajnoczi
On Thu, Sep 05, 2019 at 04:21:33PM +0100, Stefan Hajnoczi wrote: > It is likely that virtiofsd will need to support "management commands" for > reconfiguring it at runtime. The first use case was proposed by Eryu Guan for > getting/setting the current log level. > > I promised to try out DBus as

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2019 at 01:35:19PM +0200, Johannes Berg wrote: > On Sun, 2019-09-08 at 09:13 -0400, Michael S. Tsirkin wrote: > > > > I think the only use for this extension would be for simulation > > > purposes, and even then only combined with the REPLY_ACK and SLAVE_REQ > > > extensions, i.e.

[Qemu-devel] action required for qemu-web committers (was Re: [qemu-web RFC PATCH] Update to Jekyll 4.0)

2019-09-09 Thread Paolo Bonzini
On 06/09/19 13:06, Thomas Huth wrote: > - Update versions in Gemfile > - "has_key?" has to be renamed to "key?" in category_archive_plugin.rb > - Add .jekyll-cache to .gitignore file > > Signed-off-by: Thomas Huth The software collections Ruby 2.5 was trivial to setup (patch to the hook after my

Re: [Qemu-devel] [PATCH v6 0/3] High downtime with 95+ throttle pct

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909104948.30253-1-yury-ko...@yandex-team.ru/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/ba

Re: [Qemu-devel] [PATCH v6 0/3] High downtime with 95+ throttle pct

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909104948.30253-1-yury-ko...@yandex-team.ru/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

Re: [Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-09 Thread Philippe Mathieu-Daudé
On 8/29/19 6:50 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE => CODING_STYLE.rst | 121 +++--- > HACKING => HACKING.rst | 123 +-- > README => README.rst | 47 +++- > scrip

Re: [Qemu-devel] qcow2 lock

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 14:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > 09.09.2019 13:47, Kevin Wolf wrote: > > Am 09.09.2019 um 12:13 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> Hi! > >> > >> I have a (may be stupid) question: what is BDRVQcow2State.lock for and > >> when should it be locke

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Split copying code part from backup to "block-copy", including separate > state structure and function renaming. This is needed to share it with > backup-top filter driver in further commits. > > Notes: > > 1. As BlockCopyState keeps own Bl

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Johannes Berg
On Mon, 2019-09-09 at 08:41 -0400, Michael S. Tsirkin wrote: > > The only thing we could do is crash if it wants to use this feature > > without the others, but would that really be helpful? > > We can return failure from SET_PROTOCOL_FEATURES. > We can also fail all following messages. Only if

Re: [Qemu-devel] [PATCH v10 05/14] block/backup: fix block-comment style

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > We need to fix comment style around block-copy functions before further > moving them to separate file to satisfy checkpatch. But do more: fix > all comments style. Also, seems like doubled first asterisk is not > forbidden, but drop it too f

[Qemu-devel] [PATCH] test-char: fix AddressSanitizer failure

2019-09-09 Thread Paolo Bonzini
The CharSocketServerTestConfig and CharSocketClientTestConfig objects escape after they are passed to g_test_add_data_func, but they cease existing after the scope that defines them is closed. Make them static to fix this issue. Fixes: e7b6ba4186f243f149b0d8cddc129fe681ba3912 Signed-off-by: Paolo

Re: [Qemu-devel] [PATCH] test-char: fix AddressSanitizer failure

2019-09-09 Thread Philippe Mathieu-Daudé
On 9/9/19 3:06 PM, Paolo Bonzini wrote: > The CharSocketServerTestConfig and CharSocketClientTestConfig > objects escape after they are passed to g_test_add_data_func, > but they cease existing after the scope that defines them is > closed. Make them static to fix this issue. > > Fixes: e7b6ba418

[Qemu-devel] [PATCH] win32: fix README file in NSIS installer

2019-09-09 Thread Paolo Bonzini
Adjust after the rST conversion and consequent renaming. Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a Signed-off-by: Paolo Bonzini --- qemu.nsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu.nsi b/qemu.nsi index d0df0f4e3a..da18438071 100644 --- a/qemu.nsi +++ b/qemu

[Qemu-devel] [PATCH v7 2/3] cpus: Fix throttling during vm_stop

2019-09-09 Thread Yury Kotov
Throttling thread sleeps in VCPU thread. For high throttle percentage this sleep is more than 10ms. E.g. for 60% - 15ms, for 99% - 990ms. vm_stop() kicks all VCPUs and waits for them. It's called at the end of migration and because of the long sleep the migration downtime might be more than 100ms e

[Qemu-devel] [PATCH v7 1/3] qemu-thread: Add qemu_cond_timedwait

2019-09-09 Thread Yury Kotov
The new function is needed to implement conditional sleep for CPU throttling. It's possible to reuse qemu_sem_timedwait, but it's more difficult than just add qemu_cond_timedwait. Also moved compute_abs_deadline function up the code to reuse it in qemu_cond_timedwait_impl win32. Signed-off-by: Yu

[Qemu-devel] [PATCH v7 3/3] tests/migration: Add a test for auto converge

2019-09-09 Thread Yury Kotov
Signed-off-by: Yury Kotov Reviewed-by: Dr. David Alan Gilbert --- tests/migration-test.c | 130 + 1 file changed, 119 insertions(+), 11 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index a9f81cc185..966d458d72 100644 --- a/tes

Re: [Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-09 Thread Daniel P . Berrangé
On Mon, Sep 09, 2019 at 02:57:08PM +0200, Philippe Mathieu-Daudé wrote: > On 8/29/19 6:50 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > CODING_STYLE => CODING_STYLE.rst | 121 +++--- > > HACKING => HACKING.rst | 123 +

[Qemu-devel] [PATCH v7 0/3] High downtime with 95+ throttle pct

2019-09-09 Thread Yury Kotov
Hi, V7: * Fix memory leak in the auto converge test V6: * Fix "Add qemu_cond_timedwait" patch: - Changed return type for qemu_cond_timedwait (void -> bool) - Added details in commit message V5: * Updated sleep loop in throttle_thread at the suggestion of Paolo Bonzini * Fixed hanging of test

Re: [Qemu-devel] [PATCH v6 0/3] High downtime with 95+ throttle pct

2019-09-09 Thread Yury Kotov
Hi, Sorry, patchew found a leak in the auto converge test. I fixed it in v7. Also, there are two other fails, but it seems these are not related to my changes: Fail 1: https://patchew.org/logs/20190909104948.30253-1-yury-ko...@yandex-team.ru/testing.docker-mingw@fedora/?type=message ...

Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer

2019-09-09 Thread Philippe Mathieu-Daudé
On 9/9/19 3:08 PM, Paolo Bonzini wrote: > Adjust after the rST conversion and consequent renaming. > > Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a > Signed-off-by: Paolo Bonzini > --- > qemu.nsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu.nsi b/qemu.nsi > i

Re: [Qemu-devel] [PATCH v3 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-09 Thread Philippe Mathieu-Daudé
On 9/9/19 3:15 PM, Daniel P. Berrangé wrote: > On Mon, Sep 09, 2019 at 02:57:08PM +0200, Philippe Mathieu-Daudé wrote: >> On 8/29/19 6:50 PM, Daniel P. Berrangé wrote: >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> CODING_STYLE => CODING_STYLE.rst | 121 +++--- >>> HACK

Re: [Qemu-devel] [PATCH] test-char: fix AddressSanitizer failure

2019-09-09 Thread Daniel P . Berrangé
On Mon, Sep 09, 2019 at 03:06:55PM +0200, Paolo Bonzini wrote: > The CharSocketServerTestConfig and CharSocketClientTestConfig > objects escape after they are passed to g_test_add_data_func, > but they cease existing after the scope that defines them is > closed. Make them static to fix this issue

Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer

2019-09-09 Thread Daniel P . Berrangé
On Mon, Sep 09, 2019 at 03:17:00PM +0200, Philippe Mathieu-Daudé wrote: > On 9/9/19 3:08 PM, Paolo Bonzini wrote: > > Adjust after the rST conversion and consequent renaming. > > > > Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a > > Signed-off-by: Paolo Bonzini > > --- > > qemu.nsi | 2 +- > >

Re: [Qemu-devel] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > After backup-top filter appearing it's not possible to see dirty > bitmaps in top node, so use node-name instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/124| 83 > tests/qemu-iotests/25

Re: [Qemu-devel] [PATCH v10 13/14] block: introduce backup-top filter driver

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Backup-top filter caches write operations and does copy-before-write > operations. > > The driver will be used in backup instead of write-notifiers. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup-top.h | 37 +++

Re: [Qemu-devel] [PATCH v10 14/14] block/backup: use backup-top instead of write notifiers

2019-09-09 Thread Max Reitz
On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: > Drop write notifiers and use filter node instead. > > = Changes = > > 1. Add filter-node-name argument for backup qmp api. We have to do it > in this commit, as 257 needs to be fixed. > > 2. There are no more write notifiers here, so is_wr

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2019 at 03:05:08PM +0200, Johannes Berg wrote: > On Mon, 2019-09-09 at 08:41 -0400, Michael S. Tsirkin wrote: > > > > The only thing we could do is crash if it wants to use this feature > > > without the others, but would that really be helpful? > > > > We can return failure from

Re: [Qemu-devel] [RFC] libvhost-user: implement VHOST_USER_PROTOCOL_F_KICK_CALL_MSGS

2019-09-09 Thread Johannes Berg
On Mon, 2019-09-09 at 09:48 -0400, Michael S. Tsirkin wrote: > > I suppose we could fail a later command that already needs a reply > > without REPLY_ACK, but that seems difficult to debug? > > Next command is GET_FEATURES. Return an error response from that > and device init will fail. Hmm, wha

Re: [Qemu-devel] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 16:25, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> After backup-top filter appearing it's not possible to see dirty >> bitmaps in top node, so use node-name instead. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/124

[Qemu-devel] [qemu-web PATCH v2] add support page

2019-09-09 Thread Alex Bennée
This is intended to be a useful page we can link to in the banner of the IRC channel explaining the various support options someone might have. Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau --- v2 - add cleanups suggested by Stefan --- support.md | 40

[Qemu-devel] [qemu-web PATCH v2] add support page

2019-09-09 Thread Alex Bennée
This is intended to be a useful page we can link to in the banner of the IRC channel explaining the various support options someone might have. Signed-off-by: Alex Bennée Reviewed-by: Marc-André Lureau --- v2 - add cleanups suggested by Stefan --- support.md | 40

Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs

2019-09-09 Thread Alex Bennée
Laurent Vivier writes: > Le 30/08/2019 à 16:36, Alex Bennée a écrit : >> Just passing NULL means we end up ignoring the bad dfilter spec >> instead of reporting it and exiting as we should. >> >> Signed-off-by: Alex Bennée >> --- >> linux-user/main.c | 2 +- >> 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Max Reitz
On 09.09.19 11:36, Kevin Wolf wrote: > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: >> On 04.09.19 18:16, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Sin

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Eric Blake
[adding git list] On 9/5/19 7:25 AM, Christian Schoenebeck wrote: > How are you sending patches ? With git send-email ? If so, maybe you > can > pass something like --from='"Christian Schoenebeck" > '. Since this is a different string, git will > assume you're sending someone

Re: [Qemu-devel] [PATCH] linux-user: fail and report on bad dfilter specs

2019-09-09 Thread Laurent Vivier
Le 09/09/2019 à 16:00, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 30/08/2019 à 16:36, Alex Bennée a écrit : >>> Just passing NULL means we end up ignoring the bad dfilter spec >>> instead of reporting it and exiting as we should. >>> >>> Signed-off-by: Alex Bennée >>> --- >>> lin

Re: [Qemu-devel] [PATCH v6 14/42] block: Use CAFs when working with backing chains

2019-09-09 Thread Max Reitz
On 09.09.19 11:55, Kevin Wolf wrote: > Am 09.09.2019 um 10:25 hat Max Reitz geschrieben: >> On 05.09.19 16:05, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: Use child access functions when iterating through backing chains so filters do not break the chain. >

Re: [Qemu-devel] [qemu-web PATCH v2] add support page

2019-09-09 Thread Daniel P . Berrangé
On Mon, Sep 09, 2019 at 02:58:42PM +0100, Alex Bennée wrote: > This is intended to be a useful page we can link to in the banner of > the IRC channel explaining the various support options someone might > have. > > Signed-off-by: Alex Bennée > Reviewed-by: Marc-André Lureau > > --- > v2 > - a

Re: [Qemu-devel] [PATCH v10 04/14] block/backup: introduce BlockCopyState

2019-09-09 Thread Vladimir Sementsov-Ogievskiy
09.09.2019 15:59, Max Reitz wrote: > On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >> Split copying code part from backup to "block-copy", including separate >> state structure and function renaming. This is needed to share it with >> backup-top filter driver in further commits. >> >> Note

Re: [Qemu-devel] [PATCH v10 08/14] iotests: prepare 124 and 257 bitmap querying for backup-top filter

2019-09-09 Thread Max Reitz
On 09.09.19 15:49, Vladimir Sementsov-Ogievskiy wrote: > 09.09.2019 16:25, Max Reitz wrote: >> On 30.08.19 18:12, Vladimir Sementsov-Ogievskiy wrote: >>> After backup-top filter appearing it's not possible to see dirty >>> bitmaps in top node, so use node-name instead. >>> >>> Signed-off-by: Vladim

Re: [Qemu-devel] [PATCH] test-char: fix AddressSanitizer failure

2019-09-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190909130655.24495-1-pbonz...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ==

  1   2   3   >