Re: [Qemu-devel] [PATCH v2 5/6] tests/libqtest: Move global_test wrapper function into a separate header

2019-09-05 Thread Thomas Huth
On 04/09/2019 21.09, Eric Blake wrote: > On 9/4/19 1:51 PM, Stefan Hajnoczi wrote: >> On Wed, Sep 04, 2019 at 03:00:46PM +0200, Thomas Huth wrote: >>> diff --git a/tests/libqtest-single.h b/tests/libqtest-single.h >>> new file mode 100644 >>> index 00..49259558a5 >>> --- /dev/null >>> +++ b

[Qemu-devel] [Bug 1528239] Re: Unable to debug PIE binaries with QEMU gdb stub.

2019-09-05 Thread Lukas Durfina
This patch https://patchew.org/QEMU/20190816233422.16715-1-...@google.com/ fixes the issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1528239 Title: Unable to debug PIE binaries with QEMU gdb s

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 04.09.2019 19:07, Eric Blake wrote: > On 9/4/19 10:29 AM, Denis Plotnikov wrote: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level of compression ratio in comparison with >> zlib, which, at the moment, has been the

Re: [Qemu-devel] git.qemu.org gitweb misrenders on git/ URLs

2019-09-05 Thread Stefan Hajnoczi
On Mon, Sep 02, 2019 at 06:35:40AM -0400, Jeff Cody wrote: > On Mon, Sep 2, 2019 at 5:25 AM Stefan Hajnoczi wrote: > > > > On Thu, Aug 29, 2019 at 06:13:34PM +0200, Andrea Bolognani wrote: > > > On Thu, 2019-08-29 at 16:48 +0100, Stefan Hajnoczi wrote: > > > > Hi Jeff, > > > > Philippe noticed tha

Re: [Qemu-devel] [PATCH] hw/misc: Mark most objects as "common" code to speed up compilation a litte bit

2019-09-05 Thread Stefan Hajnoczi
On Mon, Sep 02, 2019 at 06:26:38PM +0200, Thomas Huth wrote: > Most of the code in hw/misc/ does not directly depend on CPU-specific > code. Mark it as "common" so that the code can be shared between e.g. > qemu-system-arm and qemu-system-aarch64, or between the various mips > flavours, instead of

[Qemu-devel] [PATCH RESEND 2/2] virtiofsd: replace err(3) and errx(3) with fuse_err()

2019-09-05 Thread Stefan Hajnoczi
Do not use err(3) and errx(3) since they print to stderr. When --syslog is used these messages must go to syslog(3) instead. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/passthrough_ll.c | 107 +++-- contrib/virtiofsd/seccomp.c| 15 ++-- 2 files changed,

[Qemu-devel] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of

2019-09-05 Thread Stefan Hajnoczi
warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog option was given. In this case messages to stderr are likely to be lost and this makes troubleshooting hard. Use "fuse_log.h" APIs instead of . Stefan Hajnoczi (2): virtiofsd: replace warn(3) and warnx(3) with fuse_w

[Qemu-devel] [PULL 5/8] tests/libqtest: Move global_test wrapper function into a separate header

2019-09-05 Thread Thomas Huth
We want libqtest.h to become completely independent from global_qtest (so that the wrapper functions are not used by accident anymore). As a first step, move the wrapper functions into a separate header file. The new header is only included from libqtest.h for now, so that there is no difference t

[Qemu-devel] [PULL 0/8] qtests and misc patches

2019-09-05 Thread Thomas Huth
Hi Peter, the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-09-04 17:22:34 +0100) are available in the Git repository at: https://gitlab.com/huth/qemu.git tags/pull-request-2019-09-0

[Qemu-devel] [PATCH RESEND 1/2] virtiofsd: replace warn(3) and warnx(3) with fuse_warning()

2019-09-05 Thread Stefan Hajnoczi
Do not use warn(3) and warnx(3) since they print to stderr. When --syslog is used these messages must go to syslog(3) instead. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/passthrough_ll.c | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PULL 3/8] tests/libqos: Replace clock_step with qtest_clock_step in virtio code

2019-09-05 Thread Thomas Huth
Library functions should not rely on functions that require global_qtest (since they might get used in tests that deal with multiple states). Commit 1999a70a05ad603d ("Make generic virtio code independent from global_qtest") already tried to clean the libqos virtio code, but I missed to replace the

[Qemu-devel] [PULL 2/8] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest

2019-09-05 Thread Thomas Huth
libqos library functions should never depend on functions (like memread(), memwrite() or clock_step()) that require global_qtest to be set, since library functions might get used in qtests that track multiple states, too. Thus let's replace the global_qtest-related functions with their independent

[Qemu-devel] [PULL 7/8] tests/vm: Take the J=x setting into account for the vm-boot-ssh targets, too

2019-09-05 Thread Thomas Huth
For testing whether the VMs can deal with multiple CPUs correctly, it is useful to be able to use the "J=" setting for the vm-boot-ssh targets, too. Message-Id: <20190726100207.19112-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/vm/Makefile.include | 1 + 1 file changed, 1 insertion(+

[Qemu-devel] [PULL 4/8] tests: Remove unnecessary global_qtest references

2019-09-05 Thread Thomas Huth
We are going to remove global_qtest from the main libqtest library soon, so tests that do not urgently need global_qtest anymore should be cleaned from the unnecessary references. Message-Id: <20190904130047.25808-5-th...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-of

[Qemu-devel] [PULL 1/8] tests/migration: Do not use functions anymore that rely on global_qtest

2019-09-05 Thread Thomas Huth
The migration tests deal with multiple test states, so we really should not use functions here that rely on the single global_qtest variable. Switch from qtest_start() to qtest_init() to make sure that global_qtest is not set anymore. This also revealed a regression in the migrate() function: It ha

[Qemu-devel] [PULL 6/8] tests/libqtest: Use libqtest-single.h in tests that require global_qtest

2019-09-05 Thread Thomas Huth
Tests that require global_qtest or the related wrapper functions now use the libqtest-single.h header that is dedicated for everything related to global_qtest. The core libqtest.c and libqtest.h files are now completely indepedent from global_qtest, so that the core library is now not depending on

[Qemu-devel] [PULL 8/8] qemu-doc: Do not hard-code the name of the QEMU binary

2019-09-05 Thread Thomas Huth
In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and "qemu-system-x86_64" when we give examples to the users how to run QEMU. Some more consistency would be good here. Also some distributions use different names for the QEMU binary (e.g. "qemu-kvm" in RHEL), so providing more flexi

[Qemu-devel] [PATCH v2] numa: Introduce MachineClass::auto_enable_numa for implicit NUMA node

2019-09-05 Thread Tao Xu
Add MachineClass::auto_enable_numa field. When it is true, a NUMA node is expected to be created implicitly. Acked-by: David Gibson Suggested-by: Igor Mammedov Suggested-by: Eduardo Habkost Reviewed-by: Igor Mammedov Signed-off-by: Tao Xu --- Note: Parameter -numa node,mem is deprecated too.

Re: [Qemu-devel] [RFC PATCH 12/14] hw/arm/bcm2836: Add the BCM2838 which uses a GICv2

2019-09-05 Thread Luc Michel
Hi Philippe, On 9/4/19 7:13 PM, Philippe Mathieu-Daudé wrote: > The BCM2838 is improvement of the BCM2837: > - Cortex-A72 instead of the A53 > - peripheral block and local soc controller are mapped differently, > - GICv2 > - PCIe block > - exhanced MMU to address over 4GiB of SDRAM > > See https:

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] Alignment checks cleanup

2019-09-05 Thread Nir Soffer
Max, can you review again? On Fri, Aug 30, 2019 at 11:25 PM Nir Soffer wrote: > On Wed, Aug 28, 2019 at 11:14 PM John Snow wrote: > >> >> >> On 8/27/19 2:59 PM, Nir Soffer wrote: >> > While working on 4k support, I noticed that there is lot of code using >> > BDRV_SECTOR_SIZE (512) for checking

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 04.09.2019 19:07, Eric Blake wrote: > On 9/4/19 10:29 AM, Denis Plotnikov wrote: >> zstd significantly reduces cluster compression time. >> It provides better compression performance maintaining >> the same level of compression ratio in comparison with >> zlib, which, at the moment, has been the

Re: [Qemu-devel] [PATCH v8 0/3] NBD reconnect

2019-09-05 Thread Vladimir Sementsov-Ogievskiy
ping 21.08.2019 19:52, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > Here is NBD reconnect. Previously, if connection failed all current > and future requests will fail. After the series, nbd-client driver > will try to reconnect unlimited times. During first @reconnect-delay > seconds of reconn

Re: [Qemu-devel] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of

2019-09-05 Thread Philippe Mathieu-Daudé
Hi Stefan, On 9/5/19 10:29 AM, Stefan Hajnoczi wrote: > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog > option was given. In this case messages to stderr are likely to be lost and > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of . > > Stefan Ha

Re: [Qemu-devel] [PULL 00/13] target/openrisc updates

2019-09-05 Thread Peter Maydell
On Wed, 4 Sep 2019 at 21:45, Richard Henderson wrote: > > The following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-09-04 17:22:34 +0100) > > are available in the Git repository at: > > ht

[Qemu-devel] [PATCH v6 0/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
v6: * fixed zstd compressed length storing/loading [Eric] * fixed wording, spec section placement [Eric] v5: * type changed for compression_type at BDRVQcow2State [Kevin] * fixed typos, grammar [Kevin] * fixed default config zstd setting [Kevin] v4: * remove not feasible switch case [Vladimir] *

[Qemu-devel] [PATCH v6 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, at the moment, has been the only compression method available. The performance test results: Test compresses and decompres

[Qemu-devel] [PATCH v6 2/3] qcow2: rework the cluster compression routine

2019-09-05 Thread Denis Plotnikov
The patch allows processing the image compression type defined in the image header and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Eric Blake --- block/qcow2-threads.c | 77 +++ 1 file chan

[Qemu-devel] [PATCH v6 1/3] qcow2: introduce compression type feature

2019-09-05 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

Re: [Qemu-devel] [PATCH] block/nfs: add support for nfs_umount

2019-09-05 Thread Peter Lieven
Am 04.09.19 um 11:34 schrieb Kevin Wolf: Am 03.09.2019 um 21:52 hat Peter Lieven geschrieben: Am 03.09.2019 um 16:56 schrieb Kevin Wolf : Am 03.09.2019 um 15:44 hat Peter Lieven geschrieben: libnfs recently added support for unmounting. Add support in Qemu too. Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCH V3] block/vhdx: add check for truncated image files

2019-09-05 Thread Peter Lieven
Am 04.09.19 um 16:09 schrieb Kevin Wolf: Am 03.09.2019 um 15:35 hat Peter Lieven geschrieben: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCH v1 03/42] tests/docker: fix "cc" command to work with podman

2019-09-05 Thread Alex Bennée
John Snow writes: > On 9/4/19 4:29 PM, Alex Bennée wrote: >> Podman requires a little bit of additional magic to the uid mapping >> which was already done for the normal RunCommand. We simplify the >> logic by pushing it directly into the Docker::run method to avoid >> instantiating an extra Do

Re: [Qemu-devel] [PATCH v4 00/10] qcow2-bitmaps: rewrite reopening logic

2019-09-05 Thread Vladimir Sementsov-Ogievskiy
ping 07.08.2019 17:12, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Bitmaps reopening is buggy, reopening-rw just not working at all and > reopening-ro may lead to producing broken incremental > backup if we do temporary snapshot in a meantime. > > v4: Drop complicated solution around reope

[Qemu-devel] [Bug 1839294] Re: Latest Installer (qemu-w64-setup-20190807.exe) for windows immediately deletes installed files at the very end of the installation

2019-09-05 Thread Koganinja89
We can forget this one if nothing happens from now on; however, this problem might have a rare but systemic problem. We can always wait and see if this problem is ever duplicated. In which case there is at least a commonality to the bug. -- You received this bug notification because you are a mem

Re: [Qemu-devel] [PATCH V3] block/vhdx: add check for truncated image files

2019-09-05 Thread Peter Lieven
Am 04.09.19 um 16:09 schrieb Kevin Wolf: Am 03.09.2019 um 15:35 hat Peter Lieven geschrieben: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCH] block/nfs: add support for nfs_umount

2019-09-05 Thread ronnie sahlberg
On Thu, Sep 5, 2019 at 7:43 PM Peter Lieven wrote: > > Am 04.09.19 um 11:34 schrieb Kevin Wolf: > > Am 03.09.2019 um 21:52 hat Peter Lieven geschrieben: > >> > >>> Am 03.09.2019 um 16:56 schrieb Kevin Wolf : > >>> > >>> Am 03.09.2019 um 15:44 hat Peter Lieven geschrieben: > libnfs recently ad

Re: [Qemu-devel] [PATCH] tests/docker: Use --userns=keep-id for podman

2019-09-05 Thread Alex Bennée
John Snow writes: > The workaround that attempts to accomplish the same result as --userns=keep-id > does not appear to work well with UIDs much above 1000 (like mine, which is > above 2.) > > Since we have official support for this "trick" now, use the supported method. > > Signed-off-by:

Re: [Qemu-devel] [RFC v3 PATCH 44/45] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-09-05 Thread Gerd Hoffmann
Hi, > +Current separation models > + > +In order to separate the device emulation code from the CPU emulation > +code, the device object code must run in a different process. There are > +a couple of existing QEMU features that can run emulation code > +separately from the main QEMU process. The

Re: [Qemu-devel] [PULL 0/8] qtests and misc patches

2019-09-05 Thread Peter Maydell
On Thu, 5 Sep 2019 at 09:30, Thomas Huth wrote: > > Hi Peter, > > the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-09-04 17:22:34 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH] block/nfs: add support for nfs_umount

2019-09-05 Thread Peter Lieven
Am 05.09.19 um 12:05 schrieb ronnie sahlberg: On Thu, Sep 5, 2019 at 7:43 PM Peter Lieven wrote: Am 04.09.19 um 11:34 schrieb Kevin Wolf: Am 03.09.2019 um 21:52 hat Peter Lieven geschrieben: Am 03.09.2019 um 16:56 schrieb Kevin Wolf : Am 03.09.2019 um 15:44 hat Peter Lieven geschrieben: lib

Re: [Qemu-devel] [RFC v3 PATCH 44/45] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-09-05 Thread Peter Maydell
On Tue, 3 Sep 2019 at 22:19, Jagannathan Raman wrote: > > From: John G Johnson > > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > --- > v2 -> v3: >- Updated with latest design of this project > > docs/devel/qemu-multiprocess.txt | 627

Re: [Qemu-devel] [RFC v3 PATCH 19/45] multi-process: Add LSI device proxy object

2019-09-05 Thread Gerd Hoffmann
Hi, > +static uint64_t proxy_lsi_io_read(void *opaque, hwaddr addr, unsigned size) > +{ > +ProxyLSIState *s = opaque; > + > +return proxy_default_bar_read(PCI_PROXY_DEV(s), &s->io_io, addr, size, > + false); > +} > + > +static void proxy_lsi_io_write(void

Re: [Qemu-devel] [Virtio-fs] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of

2019-09-05 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog > option was given. In this case messages to stderr are likely to be lost and > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of . > > Stefan Hajnoczi (

Re: [Qemu-devel] [PATCH] block/nfs: add support for nfs_umount

2019-09-05 Thread ronnie sahlberg
On Thu, Sep 5, 2019 at 8:16 PM Peter Lieven wrote: > > Am 05.09.19 um 12:05 schrieb ronnie sahlberg: > > On Thu, Sep 5, 2019 at 7:43 PM Peter Lieven wrote: > >> Am 04.09.19 um 11:34 schrieb Kevin Wolf: > >>> Am 03.09.2019 um 21:52 hat Peter Lieven geschrieben: > > Am 03.09.2019 um 16:56 schri

Re: [Qemu-devel] [PULL 0/8] qtests and misc patches

2019-09-05 Thread Thomas Huth
On 05/09/2019 12.14, Peter Maydell wrote: > On Thu, 5 Sep 2019 at 09:30, Thomas Huth wrote: >> >> Hi Peter, >> >> the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging >> (2019-09-04 17:22:34

Re: [Qemu-devel] [PATCH v1 06/42] tests/tcg: move configuration to a sub-shell script

2019-09-05 Thread Alex Bennée
Alex Bennée writes: > From: Paolo Bonzini > > Avoid the repeated inclusions of config-target.mak, which have > risks of namespace pollution, and instead build minimal configuration > files in a configuration script. The same configuration files can > also be included in Makefile and Makefile.

Re: [Qemu-devel] [PATCH] block/nfs: add support for nfs_umount

2019-09-05 Thread Peter Lieven
Am 05.09.19 um 12:28 schrieb ronnie sahlberg: On Thu, Sep 5, 2019 at 8:16 PM Peter Lieven wrote: Am 05.09.19 um 12:05 schrieb ronnie sahlberg: On Thu, Sep 5, 2019 at 7:43 PM Peter Lieven wrote: Am 04.09.19 um 11:34 schrieb Kevin Wolf: Am 03.09.2019 um 21:52 hat Peter Lieven geschrieben: Am

Re: [Qemu-devel] [PATCH v1 41/42] tests/docker: --disable-libssh on ubuntu1804 builds

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 10:30 PM, Alex Bennée wrote: > Currently this stops the mega: > > make docker-test-build > > from working. Once the source is patched to deal with the case this > workaround can be removed. > > Signed-off-by: Alex Bennée > --- > tests/docker/dockerfiles/ubuntu1804.docker | 3 +++ >

Re: [Qemu-devel] [PATCH v1 40/42] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 10:30 PM, Alex Bennée wrote: > From: Cleber Rosa > > The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, > from tests/acceptance/linux_initrd.py, is currently failing to fetch > the "vmlinuz" file. The reason for the failure is that the Fedora > project retires older

Re: [Qemu-devel] [PATCH v1 10/42] tests/docker: add Buster to DOCKER_PARTIAL_IMAGES

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 10:29 PM, Alex Bennée wrote: > We need to add additional packages to the base images to be able to > build QEMU so lets avoid building with it. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [Qemu-devel] [PATCH v1 11/42] tests/docker: move our arm64 cross compile to Buster

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 10:29 PM, Alex Bennée wrote: > Now Buster is released we can unify our cross build images for both > QEMU and tests. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include| 5 ++--- > .../docker/dockerfiles/debian-arm64-cross.docker | 4 ++-- > .../d

Re: [Qemu-devel] [PATCH v1 24/42] tests/docker: add debian9-mxe to DEBIAN_PARTIAL_IMAGES

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 10:29 PM, Alex Bennée wrote: > Another image that can't be used directly to build QEMU. > > Signed-off-by: Alex Bennée > --- > tests/docker/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.i

Re: [Qemu-devel] [Virtio-fs] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of

2019-09-05 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Hi Stefan, > > On 9/5/19 10:29 AM, Stefan Hajnoczi wrote: > > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the > > --syslog > > option was given. In this case messages to stderr are likely to be lost and > > this makes tro

Re: [Qemu-devel] [PATCH v1 25/42] tests/docker: avoid $SHELL invoke bash directly

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 10:29 PM, Alex Bennée wrote: > On some images SHELL is pointing at a limited /bin/sh which doesn't > understand noprofile/norc. Given the run script is running bash just > invoke it directly. > This fixes: $ make docker-test-build@IMAGE DEBUG=1 [...] + echo ' ./test-build' ./t

Re: [Qemu-devel] [PATCH v4 60/69] target/arm: Split gen_nop_hint

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 9:30 PM, Richard Henderson wrote: > Now that all callers pass a constant value, split the switch > statement into the individual trans_* functions. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 67 +++

Re: [Qemu-devel] [PATCH v4 59/69] target/arm: Convert T16, nop hints

2019-09-05 Thread Philippe Mathieu-Daudé
On 9/4/19 9:30 PM, Richard Henderson wrote: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 3 +-- > target/arm/t16.decode | 17 + > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/target/arm/translate.c b/tar

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-05 Thread Aleksandar Markovic
04.09.2019. 05.23, "Libo Zhou" је написао/ла: > > Hi Aleksandar, > > I have spent some time looking at your MXU ASE patch. It's super helpful. I need to do exactly the same thing as you did. > > Now I just need a way to observe the memory and register file contents to debug my instruction set simu

Re: [Qemu-devel] [PATCH] linux-user: Support gdb 'qOffsets' query for ELF

2019-09-05 Thread Philippe Mathieu-Daudé
Cc'ing Alex. On 9/3/19 9:19 PM, Josh Kunz via Qemu-devel wrote: > The `Data` and `Code` flags in `qOffsets` are actually section offsets > rather than segment offsets. GDB relocates the symbols in those sections > relative to their location in the binary. So we have to use `load_bias`. > > See he

[Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

2019-09-05 Thread Thomas Huth
So far the gitlab-ci was not testing virtio-9p yet, since we did not install libattr1-dev and libcap-dev in any of the pipelines. Do it now to get some more test coverage. Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci

[Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Thomas Huth
So far we were not testing virtio-9p in Travis yet, since we forgot to install libcap-devel. Do it now to get some more test coverage. Signed-off-by: Thomas Huth --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 92b00927d4..1d46442020 100644 ---

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Philippe Mathieu-Daudé
"virito-9p" -> "virtio-9p" in subject On 9/5/19 1:33 PM, Thomas Huth wrote: > So far we were not testing virtio-9p in Travis yet, since we forgot to > install libcap-devel. Do it now to get some more test coverage. > > Signed-off-by: Thomas Huth > --- > .travis.yml | 1 + > 1 file changed, 1 in

Re: [Qemu-devel] [PATCH v6 00/16] tcg/ppc: Add vector opcodes

2019-09-05 Thread Aleksandar Markovic
ping for Richard 03.09.2019. 20.34, "Mark Cave-Ayland" је написао/ла: > > On 03/09/2019 18:37, Aleksandar Markovic wrote: > > > On Tue, Sep 3, 2019 at 7:05 PM Mark Cave-Ayland < > > mark.cave-ayl...@ilande.co.uk> wrote: > > > >> On 01/07/2019 19:34, Howard Spoelstra wrote: > >> > >>> On Mon, Jul

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-05 Thread Libo Zhou
Do you know where in the source file I should look into to add my custom logging functionality? Or, would you suggest using gdb to look at my target register and memory contents? The answer in this link below looks really promising. I'm gonna give it a try first. https://stackoverflow.com/que

[Qemu-devel] [PATCH v7 1/3] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
From: Christian Schoenebeck 'warn' (default): Only log an error message (once) on host if more than one device is shared by same export, except of that just ignore this config error though. This is the default behaviour for not breaking existing installations implying that they really know what t

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Greg Kurz
On Thu, 5 Sep 2019 13:33:46 +0200 Thomas Huth wrote: > So far we were not testing virtio-9p in Travis yet, since we forgot to > install libcap-devel. Do it now to get some more test coverage. > > Signed-off-by: Thomas Huth > --- Acked-by: Greg Kurz and Tested-by: Greg Kurz Whose tree is

[Qemu-devel] [PATCH v7 3/3] 9p: Use variable length suffixes for inode remapping

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
From: Christian Schoenebeck Use variable length suffixes for inode remapping instead of the fixed 16 bit size prefixes before. With this change the inode numbers on guest will typically be much smaller (e.g. around >2^1 .. >2^7 instead of >2^48 with the previous fixed size inode remapping. Addit

[Qemu-devel] [PATCH v7 0/3] 9p: Fix file ID collisions

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
This is v7 of a proposed patch set for fixing file ID collisions with 9pfs. v6->v7: * Rebased to https://github.com/gkurz/qemu/commits/9p-next (SHA1 7fc4c49e91). * Be pedantic and abort with error on wrong value for new command line argument 'multidevs'. * Adjusted patches to qemu

[Qemu-devel] [PATCH v7 2/3] 9p: stat_to_qid: implement slow path

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
From: Christian Schoenebeck stat_to_qid attempts via qid_path_prefixmap to map unique files (which are identified by 64 bit inode nr and 32 bit device id) to a 64 QID path value. However this implementation makes some assumptions about inode number generation on the host. If qid_path_prefixmap f

Re: [Qemu-devel] [PATCH] travis.yml: Install libcap-dev for testing virito-9p

2019-09-05 Thread Greg Kurz
On Thu, 5 Sep 2019 14:07:01 +0200 Greg Kurz wrote: > On Thu, 5 Sep 2019 13:33:46 +0200 > Thomas Huth wrote: > > > So far we were not testing virtio-9p in Travis yet, since we forgot to > > install libcap-devel. Do it now to get some more test coverage. > > > > Signed-off-by: Thomas Huth > >

Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

2019-09-05 Thread Greg Kurz
On Thu, 5 Sep 2019 13:17:29 +0200 Thomas Huth wrote: > So far the gitlab-ci was not testing virtio-9p yet, since we did not > install libattr1-dev and libcap-dev in any of the pipelines. Do it > now to get some more test coverage. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.yml | 2 +- >

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > Well, mailman is handling this correctly. It replaces the "From:" field > > > with a placeholder and instead adds my actual email address as > > > "Reply-To:" field. That's the common way to handle this on mailing > > >

Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-05 Thread Alex Bennée
Libo Zhou writes: > Do you know where in the source file I should look into to add my custom > logging functionality? > > > Or, would you suggest using gdb to look at my target register and memory > contents? The answer in this link below looks really promising. I'm gonna > give it a try fir

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-05 Thread Greg Kurz
On Thu, 05 Sep 2019 14:25:13 +0200 Christian Schoenebeck wrote: > On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > > Well, mailman is handling this correctly. It replaces the "From:" field > > > > with a placeholder and instead adds my actual email address as > > >

Re: [Qemu-devel] [PATCH v6 09/42] block: Include filters when freezing backing chain

2019-09-05 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > In order to make filters work in backing chains, the associated > functions must be able to deal with them and freeze all filter links, be > they COW or R/W filter links. > > In the process, rename these functions to reflect that they now act on

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-05 Thread Laszlo Ersek
On 09/04/19 11:52, Igor Mammedov wrote: > it could be stolen RAM + black hole like TSEG, assuming fw can live without > RAM(0x3+128K) range > (in this case fwcfg interface would only work for locking down the range) > > or > > we can actually have a dedicated SMRAM (like in my earlier

[Qemu-devel] [PATCH v3] qemu-ga: Convert invocation documentation to rST

2019-09-05 Thread Peter Maydell
The qemu-ga documentation is currently in qemu-ga.texi in Texinfo format, which we present to the user as: * a qemu-ga manpage * a section of the main qemu-doc HTML documentation Convert the documentation to rST format, and present it to the user as: * a qemu-ga manpage * part of the interop/

Re: [Qemu-devel] [PATCH v6 11/42] block: Add bdrv_supports_compressed_writes()

2019-09-05 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Filters cannot compress data themselves but they have to implement > .bdrv_co_pwritev_compressed() still (or they cannot forward compressed > writes). Therefore, checking whether > bs->drv->bdrv_co_pwritev_compressed is non-NULL is not sufficient

Re: [Qemu-devel] test-aio-multithread assertion

2019-09-05 Thread Peter Maydell
On Wed, 4 Sep 2019 at 12:50, Peter Maydell wrote: > > Hi; I've been seeing intermittently on the BSDs this assertion > running test-aio-multithread as part of 'make check': > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > tests/test-aio-multithread -m=quick -k --tap < /dev/nu

Re: [Qemu-devel] [PATCH 2/2] block/nvme: add support for discard

2019-09-05 Thread Maxim Levitsky
On Wed, 2019-08-28 at 12:03 +0300, Maxim Levitsky wrote: > On Tue, 2019-08-27 at 18:29 -0400, John Snow wrote: > > > > On 8/25/19 3:15 AM, Maxim Levitsky wrote: > > > Signed-off-by: Maxim Levitsky > > > --- > > > block/nvme.c | 83 ++ > > > block

Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] block: Generic file creation fallback

2019-09-05 Thread Maxim Levitsky
On Fri, 2019-07-12 at 19:35 +0200, Max Reitz wrote: > Hi, > > Kevin commented on my RFC, so I got what an RFC wants, and he didn’t > object to the creation fallback part. So I suppose I can go down that > route at least. (Which was actually the more important part of the > series.) > > So as in

Re: [Qemu-devel] [PATCH v3 4/4] docs: split the CODING_STYLE doc into distinct groups

2019-09-05 Thread Peter Maydell
On Thu, 29 Aug 2019 at 17:59, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.rst | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [Bug 1842925] [NEW] no batmap on convertion from qcow2 to vhd

2019-09-05 Thread Marat Salakhutdinov
Public bug reported: we run following version of qemu-img: $ qemu-img --version qemu-img version 2.5.0 (Debian 1:2.5+dfsg-5ubuntu10.41), Copyright (c) 2004-2008 Fabrice Bellard $ Here is os version: $ cat /etc/os-release NAME="Ubuntu" VERSION="16.04.6 LTS (Xenial Xerus)" ID=ubuntu ID_LIKE=debia

Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel

2019-09-05 Thread Cleber Rosa
On Thu, Sep 05, 2019 at 12:09:24PM +1000, David Gibson wrote: > On Wed, Sep 04, 2019 at 03:57:17PM -0400, Cleber Rosa wrote: > > > > Hi David, > > > > I've pushed a branch here (most of the commits have already been sent > > separately): > > > >https://github.com/clebergnu/qemu/tree/ppc64 >

Re: [Qemu-devel] [PATCH v6 1/3] qcow2: introduce compression type feature

2019-09-05 Thread Vladimir Sementsov-Ogievskiy
05.09.2019 12:31, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature to QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the compression type is set o

[Qemu-devel] [PULL 3/4] docs: document use of automatic cleanup functions in glib

2019-09-05 Thread Daniel P . Berrangé
Document the use of g_autofree and g_autoptr in glib for automatic freeing of memory. Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 85 1 file changed, 85 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_S

[Qemu-devel] [PULL 0/4] Docs patches

2019-09-05 Thread Daniel P . Berrangé
The following changes since commit 500efcfcf0fe2e0dae1d25637a13435ce7b6e421: Merge remote-tracking branch 'remotes/rth/tags/pull-or1k-20190904' into staging (2019-09-05 09:33:01 +0100) are available in the Git repository at: https://github.com/berrange/qemu tags/docs-pull-request for you t

[Qemu-devel] [PULL 1/4] docs: convert README, CODING_STYLE and HACKING to RST syntax

2019-09-05 Thread Daniel P . Berrangé
Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- CODING_STYLE => CODING_STYLE.rst | 121 +++--- HACKING => HACKING.rst | 123 +-- README => README.rst | 47 +++- scripts/checkpatch.pl|

[Qemu-devel] [PULL 4/4] docs: split the CODING_STYLE doc into distinct groups

2019-09-05 Thread Daniel P . Berrangé
Reviewed-by: Peter Maydell Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/CODING_STYLE.rst b/CODING_STYLE.rst index 39397f0f6f..427699e0e4 100644 --- a/CODING_STYLE.rst +++ b/CODING_STYLE.rst @@ -7,6 +7,9 @@ QEMU Coding Style

[Qemu-devel] [PULL 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-09-05 Thread Daniel P . Berrangé
The split of information between the two docs is rather arbitary and unclear. It is simpler for contributors if all the information is in one file. Reviewed-by: Alex Bennée Signed-off-by: Daniel P. Berrangé --- CODING_STYLE.rst | 296 ++ HACKING.rst

Re: [Qemu-devel] [PATCH v5 16/17] target/arm: Rebuild hflags at EL changes and MSR writes

2019-09-05 Thread Alex Bennée
Richard Henderson writes: > Now setting, but not relying upon, env->hflags. > > Signed-off-by: Richard Henderson > --- > linux-user/syscall.c | 1 + > target/arm/cpu.c | 1 + > target/arm/helper-a64.c| 3 +++ > target/arm/helper.c| 2 ++ > target/arm/machine.c

Re: [Qemu-devel] [PATCH] gitlab-ci.yml: Install libattr1-dev and libcap-dev to test virtio-9p

2019-09-05 Thread Thomas Huth
On 05/09/2019 14.21, Greg Kurz wrote: > On Thu, 5 Sep 2019 13:17:29 +0200 > Thomas Huth wrote: > >> So far the gitlab-ci was not testing virtio-9p yet, since we did not >> install libattr1-dev and libcap-dev in any of the pipelines. Do it >> now to get some more test coverage. >> >> Signed-off-b

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 01/17] target/arm: Split out rebuild_hflags_common

2019-09-05 Thread Alex Bennée
Richard Henderson writes: > Create a function to compute the values of the TBFLAG_ANY bits > that will be cached. For now, the env->hflags variable is not > used, and the results are fed back to cpu_get_tb_cpu_state. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > ta

Re: [Qemu-devel] Cryptic errors from PIP install if missing openssl-devel

2019-09-05 Thread Eduardo Habkost
On Thu, Sep 05, 2019 at 09:38:24AM -0400, Cleber Rosa wrote: > On Thu, Sep 05, 2019 at 12:09:24PM +1000, David Gibson wrote: > > On Wed, Sep 04, 2019 at 03:57:17PM -0400, Cleber Rosa wrote: > > > > > > Hi David, > > > > > > I've pushed a branch here (most of the commits have already been sent > >

Re: [Qemu-devel] [PATCH v6 14/42] block: Use CAFs when working with backing chains

2019-09-05 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > Use child access functions when iterating through backing chains so > filters do not break the chain. > > Signed-off-by: Max Reitz > --- > block.c | 40 > 1 file changed, 28 insertions(+), 12 deletions(-

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Eric Blake
On 9/5/19 2:44 AM, Denis Plotnikov wrote: >>> + >>> +s_size = be32_to_cpu(*(const uint32_t *) src); >> As written, this looks like you may be dereferencing an unaligned >> pointer. It so happens that be32_to_cpu() applies & to your * to get >> back at the raw pointer, and then is careful to

Re: [Qemu-devel] [RFC v3 PATCH 07/45] multi-process: define proxy-link object

2019-09-05 Thread Eric Blake
On 9/4/19 3:22 AM, Daniel P. Berrangé wrote: > On Tue, Sep 03, 2019 at 04:37:33PM -0400, Jagannathan Raman wrote: >> Defines proxy-link object which forms the communication link between >> QEMU & emulation program. >> Adds functions to configure members of proxy-link object instance. >> Adds functi

Re: [Qemu-devel] [PATCH v3 2/4] docs: merge HACKING.rst contents into CODING_STYLE.rst

2019-09-05 Thread Eric Blake
On 8/29/19 11:50 AM, Daniel P. Berrangé wrote: > The split of information between the two docs is rather arbitary and > unclear. It is simpler for contributors if all the information is in > one file. > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.rst | 296 ++

Re: [Qemu-devel] [PATCH v3 3/4] docs: document use of automatic cleanup functions in glib

2019-09-05 Thread Eric Blake
On 8/29/19 11:50 AM, Daniel P. Berrangé wrote: > Document the use of g_autofree and g_autoptr in glib for automatic > freeing of memory. > > Signed-off-by: Daniel P. Berrangé > --- > CODING_STYLE.rst | 85 > 1 file changed, 85 insertions(+) > > d

[Qemu-devel] [Bug 1842925] Re: no batmap on convertion from qcow2 to vhd

2019-09-05 Thread Marat Salakhutdinov
we use vhd-util from link http://download.cloud.com.s3.amazonaws.com/tools/vhd-util -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1842925 Title: no batmap on convertion from qcow2 to vhd Status in

Re: [Qemu-devel] [PATCH v5 3/3] qcow2: add zstd cluster compression

2019-09-05 Thread Denis Plotnikov
On 05.09.2019 17:31, Eric Blake wrote: > On 9/5/19 2:44 AM, Denis Plotnikov wrote: > > + +s_size = be32_to_cpu(*(const uint32_t *) src); >>> As written, this looks like you may be dereferencing an unaligned >>> pointer. It so happens that be32_to_cpu() applies & to your * to get >>>

Re: [Qemu-devel] [RFC v3 PATCH 01/45] multi-process: memory: alloc RAM from file at offset

2019-09-05 Thread Jag Raman
On 9/4/2019 4:11 AM, Dr. David Alan Gilbert wrote: * Jagannathan Raman (jag.ra...@oracle.com) wrote: Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. This will be ne

  1   2   >