On 05/09/2019 12.14, Peter Maydell wrote: > On Thu, 5 Sep 2019 at 09:30, Thomas Huth <th...@redhat.com> wrote: >> >> Hi Peter, >> >> the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c: >> >> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging >> (2019-09-04 17:22:34 +0100) >> >> are available in the Git repository at: >> >> https://gitlab.com/huth/qemu.git tags/pull-request-2019-09-05 >> >> for you to fetch changes up to 7bb21c0ac301e423b483dd7fc171b0d7b56de2cf: >> >> qemu-doc: Do not hard-code the name of the QEMU binary (2019-09-05 >> 09:45:09 +0200) >> >> ---------------------------------------------------------------- >> - Make the core libqtest library independent from global_qtest >> - Clean up docs from hard-coded qemu-system-* names >> ---------------------------------------------------------------- >> >> Thomas Huth (8): >> tests/migration: Do not use functions anymore that rely on global_qtest >> tests/libqos/e1000e: Make e1000e libqos functions independent from >> global_qtest >> tests/libqos: Replace clock_step with qtest_clock_step in virtio code >> tests: Remove unnecessary global_qtest references >> tests/libqtest: Move global_test wrapper function into a separate >> header >> tests/libqtest: Use libqtest-single.h in tests that require >> global_qtest >> tests/vm: Take the J=x setting into account for the vm-boot-ssh >> targets, too >> qemu-doc: Do not hard-code the name of the QEMU binary > > Hi; I'm afraid this fails to build: > > /home/pm/qemu/tests/virtio-9p-test.c: In function ‘v9fs_req_init’: > /home/pm/qemu/tests/virtio-9p-test.c:162:16: error: ‘global_qtest’ > undeclared (first use in this function); did you mean ‘g_file_test’? > req->qts = global_qtest; > ^~~~~~~~~~~~ > g_file_test > /home/pm/qemu/tests/virtio-9p-test.c:162:16: note: each undeclared > identifier is reported only once for each function it appears in > /home/pm/qemu/rules.mak:69: recipe for target 'tests/virtio-9p-test.o' failed
Oh, that's unexpected since my gitlab-ci pipeline worked fine: https://gitlab.com/huth/qemu/pipelines/80403573 Looks like both, my local system and the gitlab-ci are missing libcap-devel and/or libattr-devel, so that the 9P stuff does not get built :-( Time for some fix-up patches ... Thomas
