Re: [Qemu-devel] QEMU as ISS (Instruction Set Simulator)

2019-09-03 Thread Aleksandar Markovic
30.08.2019. 11.14, "Libo Zhou" је написао/ла: > > Hi Aleksandar, > > Thanks for explaining helper functions for me. Before getting my hands dirty, I have some more questions. After figuring them out, I can get started. > > I need to add some new registers to the CPU. In "translate.c", I found that

Re: [Qemu-devel] [PATCH v12 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-03 Thread Aravinda Prasad
On Friday 30 August 2019 07:28 PM, Greg Kurz wrote: > On Fri, 30 Aug 2019 14:43:40 +0530 > Aravinda Prasad wrote: > >> Introduce the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check exception on the >> address b

Re: [Qemu-devel] [PATCH v12 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-03 Thread Aravinda Prasad
On Friday 30 August 2019 10:38 PM, Greg Kurz wrote: > On Fri, 30 Aug 2019 14:44:07 +0530 > Aravinda Prasad wrote: > >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >> value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for mac

Re: [Qemu-devel] [PATCH 2/2] tests: fix modules-test with no default machine

2019-09-03 Thread Peter Maydell
On Mon, 2 Sep 2019 at 10:52, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Tue, 27 Aug 2019 at 15:46, Thomas Huth wrote: > >> > >> On 27/08/2019 16.02, Marc-André Lureau wrote: > >> > Fixes: eb062cfa733 ("tests: add module loading test") > >> > Signed-off-by: Marc-André Lureau > >> >

Re: [Qemu-devel] [PATCH v12 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-03 Thread Greg Kurz
On Tue, 3 Sep 2019 12:52:39 +0530 Aravinda Prasad wrote: > > > On Friday 30 August 2019 07:28 PM, Greg Kurz wrote: > > On Fri, 30 Aug 2019 14:43:40 +0530 > > Aravinda Prasad wrote: > > > >> Introduce the KVM capability KVM_CAP_PPC_FWNMI so that > >> the KVM causes guest exit with NMI as exit

Re: [Qemu-devel] [PATCH v12 3/6] target/ppc: Handle NMI guest exit

2019-09-03 Thread Greg Kurz
On Fri, 30 Aug 2019 14:43:50 +0530 Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > the guest kernel is responsible for taking suitable action. > Patch

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-09-03 Thread Vladimir Sementsov-Ogievskiy
02.09.2019 19:34, Max Reitz wrote: > On 29.08.19 16:55, Vladimir Sementsov-Ogievskiy wrote: >> 28.08.2019 22:50, Max Reitz wrote: >>> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: Drop write notifiers and use filter node instead. = Changes = 1. add filter-node-name

Re: [Qemu-devel] [PATCH 1/6] tests/migration: Do not use functions anymore that rely on global_qtest

2019-09-03 Thread Laurent Vivier
On 03/09/2019 08:18, Thomas Huth wrote: > The migration tests deal with multiple test states, so we really should > not use functions here that rely on the single global_qtest variable. > Switch from qtest_start() to qtest_init() to make sure that global_qtest > is not set anymore. This also reveal

Re: [Qemu-devel] GSoC project: API Documentation Generation links and comments

2019-09-03 Thread Peter Maydell
On Tue, 27 Aug 2019 at 22:01, John Snow wrote: > > > > On 8/27/19 4:56 PM, Peter Maydell wrote: > > On Tue, 27 Aug 2019 at 21:52, John Snow wrote: > >> - For theming, I'm a fan of the RTD theme, because I think it makes the > >> TOC tree stand out better and makes for nicer browsing than the defa

Re: [Qemu-devel] [PATCH v2 66/68] target/arm: Convert T16, long branches

2019-09-03 Thread Peter Maydell
On Wed, 28 Aug 2019 at 01:07, Richard Henderson wrote: > > On 8/27/19 2:34 AM, Peter Maydell wrote: > >> +tcg_gen_andi_i32(tmp, tmp, -4); > > > > Minor nit, but can we use 0xfffc like the old code did, > > to avoid the reader having to do 2s-complement arithmetic > > in their head to figur

Re: [Qemu-devel] [PATCH v12 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-03 Thread Aravinda Prasad
On Tuesday 03 September 2019 01:26 PM, Greg Kurz wrote: > On Tue, 3 Sep 2019 12:52:39 +0530 > Aravinda Prasad wrote: > >> >> >> On Friday 30 August 2019 07:28 PM, Greg Kurz wrote: >>> On Fri, 30 Aug 2019 14:43:40 +0530 >>> Aravinda Prasad wrote: >>> Introduce the KVM capability KVM_CAP_P

[Qemu-devel] [PATCH] net/filter: Add filter order info for "info network"

2019-09-03 Thread Zhang Chen
From: Zhang Chen People need a way to know current filter order if they want to dynamic add/remove netfilter. For example: (qemu) info network ... filters order: m0 ---> redire0 ---> redire1 ---> End ... Signed-off-by: Zhang Chen --- net/net.c | 24 1 file ch

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-09-03 Thread Peter Maydell
On Thu, 29 Aug 2019 at 08:58, Auger Eric wrote: > > Hi Zenghui, > > On 8/29/19 4:53 AM, Zenghui Yu wrote: > > For confirmation, should we also adjust the vcpu_index in > > arm_cpu_kvm_set_irq(), just like above? > > I am not familiar with this path. in arm_cpu_initfn(), there is a > comment saying

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

2019-09-03 Thread Vladimir Sementsov-Ogievskiy
02.09.2019 17:35, Max Reitz wrote: > On 31.08.19 11:57, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:13, Max Reitz wrote: >>> This includes some permission limiting (for example, we only need to >>> take the RESIZE permission for active commits where the base is smaller >>> than the top). >

Re: [Qemu-devel] [PATCH 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest

2019-09-03 Thread Laurent Vivier
On 03/09/2019 08:18, Thomas Huth wrote: > libqos library functions should never depend on functions (like memread(), > memwrite() or clock_step()) that require global_qtest to be set, since > library functions might get used in qtests that track multiple states, too. > Thus let's replace the global

Re: [Qemu-devel] [PULL 00/15] Block patches

2019-09-03 Thread Peter Maydell
On Tue, 27 Aug 2019 at 19:23, Max Reitz wrote: > > The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into > staging (2019-08-27 15:52:36 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [RFC 2/3] intc/arm_gic: Support PPI injection for more than 256 vpus

2019-09-03 Thread Auger Eric
Hi Peter, On 9/3/19 10:29 AM, Peter Maydell wrote: > On Thu, 29 Aug 2019 at 08:58, Auger Eric wrote: >> >> Hi Zenghui, >> >> On 8/29/19 4:53 AM, Zenghui Yu wrote: >>> For confirmation, should we also adjust the vcpu_index in >>> arm_cpu_kvm_set_irq(), just like above? >> >> I am not familiar with

Re: [Qemu-devel] [PATCH 0/1] BZ#1733165: network-get-interfaces Chinese NIC name

2019-09-03 Thread Bishara AbuHattoum
PING On Mon, Aug 19, 2019 at 4:22 PM Bishara AbuHattoum wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1733165 > > Uppon renaming a NIC to a Chinese name and invoking the network get > interfaces command, guest-network-get-interfaces, the returned name > field has the (\ufffd) value for ea

Re: [Qemu-devel] [PATCH 1/1] qga-win: network-get-interfaces command name field bug fix

2019-09-03 Thread Bishara AbuHattoum
PING On Mon, Aug 19, 2019 at 4:28 PM Bishara AbuHattoum wrote: > Network interface name is fetched as an encoded WCHAR array, (wide > character), then it is decoded using the guest's CP_ACP Windows code > page, which is the default code page as configure in the guest's > Windows, then it is retu

Re: [Qemu-devel] [PATCH 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code

2019-09-03 Thread Laurent Vivier
On 03/09/2019 08:18, Thomas Huth wrote: > Library functions should not rely on functions that require global_qtest > (since they might get used in tests that deal with multiple states). > Commit 1999a70a05ad603d ("Make generic virtio code independent from > global_qtest") already tried to clean the

Re: [Qemu-devel] [PATCH v2 0/5] vpc: Return 0 from vpc_co_create() on success

2019-09-03 Thread Kevin Wolf
Am 02.09.2019 um 21:33 hat Max Reitz geschrieben: > (v2 for “block: Let blockdev-create return 0 on success”) > > Jobs are expected to return 0 on success, so this extends to > .bdrv_co_create(). After some inspection, it turns out that vpc is the > only block driver that may return a positive va

Re: [Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp()

2019-09-03 Thread Peter Maydell
On Thu, 29 Aug 2019 at 21:22, Alex Bennée wrote: > > > Aleksandar Markovic writes: > > I am just curious if you found this by manual code inspection, or perhaps > > using a tool? > > I'm guessing that if you run code that exercises this while built with > --enable-tcg-debug then TCG's sanity chec

Re: [Qemu-devel] [PATCH V2] block/vhdx: add check for truncated image files

2019-09-03 Thread Peter Lieven
Am 02.09.19 um 17:24 schrieb Peter Lieven: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven --- V2: - add error reporting [Kevin] - use bd

Re: [Qemu-devel] [PATCH v4 2/6] m68k: Add NeXTcube keyboard device

2019-09-03 Thread Peter Maydell
On Sat, 31 Aug 2019 at 06:19, Thomas Huth wrote: > > Am Tue, 13 Aug 2019 11:16:44 +0100 > schrieb Peter Maydell : > > > On Tue, 9 Jul 2019 at 08:35, Thomas Huth wrote: > > > > > > It is likely still quite incomplete (e.g. mouse and interrupts are > > > not implemented yet), but it is good enough

Re: [Qemu-devel] [PATCH v6 42/42] iotests: Test committing to overridden backing

2019-09-03 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:14, Max Reitz wrote: > Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication

2019-09-03 Thread Lukas Straub
Hello Everyone, These Patches add support for continious replication to colo. This means that after the Primary fails and the Secondary did a failover, the Secondary can then become Primary and resume replication to a new Secondary. On a side note, I wrote a Pacemaker Resource Agent for colo which

[Qemu-devel] [PATCH v3 4/4] colo: Update Documentation for continious replication

2019-09-03 Thread Lukas Straub
Document the qemu command-line and qmp commands for continious replication Signed-off-by: Lukas Straub --- docs/COLO-FT.txt | 212 +++-- docs/block-replication.txt | 26 +++-- 2 files changed, 172 insertions(+), 66 deletions(-) diff --git a/docs/COLO-F

[Qemu-devel] [PATCH v3 1/4] block/replication.c: Ignore requests after failover

2019-09-03 Thread Lukas Straub
After failover the Secondary side of replication shouldn't change state, because it now functions as our primary disk. In replication_start, replication_do_checkpoint, replication_stop, ignore the request if current state is BLOCK_REPLICATION_DONE (sucessful failover) or BLOCK_REPLICATION_FAILOVER

Re: [Qemu-devel] [PATCH v5 2/4] block.c: adding bdrv_delete_file

2019-09-03 Thread Kevin Wolf
Am 29.08.2019 um 04:07 hat John Snow geschrieben: > > > On 8/7/19 10:21 AM, Daniel Henrique Barboza wrote: > > Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file > > can be used in a way similar of the existing bdrv_create_file to > > to clean up a created file. > > > > The logic is

[Qemu-devel] [PATCH v3 2/4] tests/test-replication.c: Add test for ignoring requests after failover

2019-09-03 Thread Lukas Straub
This simulates the case that happens when we resume COLO after failover. Signed-off-by: Lukas Straub --- tests/test-replication.c | 52 1 file changed, 52 insertions(+) diff --git a/tests/test-replication.c b/tests/test-replication.c index f085d1993a..45

Re: [Qemu-devel] [PATCH v4 2/6] m68k: Add NeXTcube keyboard device

2019-09-03 Thread Thomas Huth
On 03/09/2019 11.12, Peter Maydell wrote: > On Sat, 31 Aug 2019 at 06:19, Thomas Huth wrote: >> >> Am Tue, 13 Aug 2019 11:16:44 +0100 >> schrieb Peter Maydell : >> >>> On Tue, 9 Jul 2019 at 08:35, Thomas Huth wrote: It is likely still quite incomplete (e.g. mouse and interrupts are

[Qemu-devel] [PATCH v3 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-03 Thread Lukas Straub
To switch the Secondary to Primary, we need to insert new filters before the filter-rewriter. Add the options insert= and position= to be able to insert filters anywhere in the filter list. position should be either "head", "tail" or the id of another filter. insert should be either "before" or "

Re: [Qemu-devel] [PATCH v2 66/68] target/arm: Convert T16, long branches

2019-09-03 Thread Aleksandar Markovic
28.08.2019. 02.07, "Richard Henderson" је написао/ла: > > On 8/27/19 2:34 AM, Peter Maydell wrote: > >> +tcg_gen_andi_i32(tmp, tmp, -4); > > > > Minor nit, but can we use 0xfffc like the old code did, > > to avoid the reader having to do 2s-complement arithmetic > > in their head to figure

Re: [Qemu-devel] Uncaught target signal 11 (Segmentation Faullt)

2019-09-03 Thread Aleksandar Markovic
02.09.2019. 18.08, "Aleksandar Markovic" је написао/ла: > > > 02.09.2019. 06.17, "Libo Zhou" је написао/ла: > > > > I am trying to run a simple MIPS program with QEMU user mode. > > > > > > > > Host: Ubuntu 18.04 LTS on x86_64 > > QEMU config: ../configure --target-list=mips-linux-user > > > > Cr

Re: [Qemu-devel] [PATCH v5 2/4] block.c: adding bdrv_delete_file

2019-09-03 Thread Daniel Henrique Barboza
On 9/3/19 6:22 AM, Kevin Wolf wrote: Am 29.08.2019 um 04:07 hat John Snow geschrieben: On 8/7/19 10:21 AM, Daniel Henrique Barboza wrote: Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file can be used in a way similar of the existing bdrv_create_file to to clean up a created fi

Re: [Qemu-devel] [PATCH] target/arm: Fix SMMLS argument order

2019-09-03 Thread Peter Maydell
On Thu, 29 Aug 2019 at 02:34, Richard Henderson wrote: > > The previous simplification got the order of operands to the > subtraction wrong. Since the 64-bit product is the subtrahend, > we must use a 64-bit subtract to properly compute the borrow > from the low-part of the product. > > Fixes: 5f

Re: [Qemu-devel] [PATCH v6 0/4] delete created files when block_crypto_co_create_opts_luks fails

2019-09-03 Thread Daniel Henrique Barboza
Please ignore this series. I'll respin a v7 to actually do what Kevin suggested in the v4 review. Thanks, DHB On 9/2/19 5:58 PM, Daniel Henrique Barboza wrote: Changes from previous version 5 [1] suggested by John Snow: - patch 2: return ENOMEDIUM with !drv, return negative error codes in bdr

[Qemu-devel] [Bug 1840777] Re: raspi3 machine can not shutdown

2019-09-03 Thread Alex Bennée
I'm guessing from: bcm2835-pm: unimplemented device read (size 4, offset 0x20) bcm2835-pm: unimplemented device write (size 4, value 0x5a000555, offset 0x20) bcm2835-pm: unimplemented device write (size 4, value 0x5a0a, offset 0x24) bcm2835-pm: unimplemented device read (size 4, offset

Re: [Qemu-devel] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

2019-09-03 Thread Kevin Wolf
Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: > In the current implementation of the QEMU bash iotests, only qemu-io > processes may be run under the Valgrind with the switch '-valgrind'. > Let's allow the common.rc bash script running all other QEMU processes, > such as qemu-kvm, qemu-

Re: [Qemu-devel] [PULL 00/12] Block patches

2019-09-03 Thread Peter Maydell
On Tue, 27 Aug 2019 at 21:16, Stefan Hajnoczi wrote: > > The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into > staging (2019-08-27 10:00:51 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH v5 2/4] block.c: adding bdrv_delete_file

2019-09-03 Thread Kevin Wolf
Am 03.09.2019 um 11:55 hat Daniel Henrique Barboza geschrieben: > > > On 9/3/19 6:22 AM, Kevin Wolf wrote: > > Am 29.08.2019 um 04:07 hat John Snow geschrieben: > > > > > > On 8/7/19 10:21 AM, Daniel Henrique Barboza wrote: > > > > Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file

Re: [Qemu-devel] [PATCH v12 4/6] target/ppc: Build rtas error log upon an MCE

2019-09-03 Thread Greg Kurz
On Fri, 30 Aug 2019 14:43:58 +0530 Aravinda Prasad wrote: > Upon a machine check exception (MCE) in a guest address space, > KVM causes a guest exit to enable QEMU to build and pass the > error to the guest in the PAPR defined rtas error log format. > > This patch builds the rtas error log, copi

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-03 Thread Peter Xu
On Mon, Sep 02, 2019 at 11:26:47AM +1000, Tony Nguyen wrote: > Existing read rejecting validator was mistakenly cleared. > > Reads dispatched to io_mem_notdirty then segfaults as there is no read > handler. > > Signed-off-by: Tony Nguyen Reviewed-by: Peter Xu -- Peter Xu

Re: [Qemu-devel] [PATCH v1 0/9] arm semih-hosting cleanups and other misc cleanups

2019-09-03 Thread Peter Maydell
On Wed, 28 Aug 2019 at 18:08, Alex Bennée wrote: > > Hi Peter, > > Here are the ARM semi-hosting cleanup patches and a small selection of > miscellaneous TCG clean-ups. If your happy taking them all through > your tree please do otherwise I'll poke Richard. I'm just trying to > reduce the delta fo

Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-09-03 Thread Sergio Lopez
Cornelia Huck writes: > On Thu, 29 Aug 2019 18:50:27 +0200 > Sergio Lopez wrote: > >> Implement the modern (v2) personality, according to the VirtIO 1.0 >> specification. >> >> Support for v2 among guests is not as widespread as it'd be >> desirable. While the Linux driver has had it for a whi

Re: [Qemu-devel] [PATCH] block: qcow2: free 'refcount_table' in error path

2019-09-03 Thread Kevin Wolf
Am 31.08.2019 um 04:04 hat Li Qiang geschrieben: > Currently, when doing './check -qcow2 098'. We can get following > asan output: > > qemu-img: Could not empty blkdebug:TEST_DIR/blkdebug.conf:TEST_DIR/t.IMGFMT: > Input/output error > + > +=

Re: [Qemu-devel] [PATCH v12 4/6] target/ppc: Build rtas error log upon an MCE

2019-09-03 Thread Aravinda Prasad
On Tuesday 03 September 2019 03:36 PM, Greg Kurz wrote: > On Fri, 30 Aug 2019 14:43:58 +0530 > Aravinda Prasad wrote: > >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to the guest in the PAPR defined rt

Re: [Qemu-devel] [PATCH] memory: Set notdirty_mem_ops validator

2019-09-03 Thread Peter Maydell
On Mon, 2 Sep 2019 at 02:36, Tony Nguyen wrote: > > Existing read rejecting validator was mistakenly cleared. > > Reads dispatched to io_mem_notdirty then segfaults as there is no read > handler. Do you have the commit hash for where we introduced the bug that this is fixing? thanks -- PMM

Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-09-03 Thread Sergio Lopez
Stefan Hajnoczi writes: > On Thu, Aug 29, 2019 at 06:50:27PM +0200, Sergio Lopez wrote: >> case VIRTIO_MMIO_QUEUE_PFN: >> +if (!proxy->legacy) { >> +qemu_log_mask(LOG_GUEST_ERROR, >> +"%s: read from legacy register (0x%lx) in non-legacy >> mode\n", >> +

Re: [Qemu-devel] [PATCH v1 0/9] arm semih-hosting cleanups and other misc cleanups

2019-09-03 Thread Peter Maydell
On Wed, 28 Aug 2019 at 18:08, Alex Bennée wrote: > > Hi Peter, > > Here are the ARM semi-hosting cleanup patches and a small selection of > miscellaneous TCG clean-ups. If your happy taking them all through > your tree please do otherwise I'll poke Richard. I'm just trying to > reduce the delta fo

Re: [Qemu-devel] [PATCH v7 0/6] Allow Valgrind checking all QEMU processes

2019-09-03 Thread Andrey Shinkevich
On 03/09/2019 13:02, Kevin Wolf wrote: > Am 01.09.2019 um 13:53 hat Andrey Shinkevich geschrieben: >> In the current implementation of the QEMU bash iotests, only qemu-io >> processes may be run under the Valgrind with the switch '-valgrind'. >> Let's allow the common.rc bash script running all o

Re: [Qemu-devel] [PATCH v1 0/9] arm semih-hosting cleanups and other misc cleanups

2019-09-03 Thread Alex Bennée
Peter Maydell writes: > On Wed, 28 Aug 2019 at 18:08, Alex Bennée wrote: >> >> Hi Peter, >> >> Here are the ARM semi-hosting cleanup patches and a small selection of >> miscellaneous TCG clean-ups. If your happy taking them all through >> your tree please do otherwise I'll poke Richard. I'm ju

Re: [Qemu-devel] [PATCH v3 19/69] target/arm: Convert T32 ADDW/SUBW

2019-09-03 Thread Peter Maydell
On Wed, 28 Aug 2019 at 20:05, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3 22/69] target/arm: Diagnose UNPREDICTABLE ldrex/strex cases

2019-09-03 Thread Peter Maydell
On Wed, 28 Aug 2019 at 20:05, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 40 ++-- > 1 file changed, 38 insertions(+), 2 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v3 57/69] target/arm: Convert T16, Change processor state

2019-09-03 Thread Peter Maydell
On Wed, 28 Aug 2019 at 20:06, Richard Henderson wrote: > > Add a check for ARMv6 in trans_CPS. We had this correct in > the T16 path, but had previously forgotten the check on the > A32 and T32 paths. > > Signed-off-by: Richard Henderson > --- > v3: Fix cps architecture checks. Rename s/v6m/v7m

Re: [Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication

2019-09-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1567500411.git.lukasstra...@web.de/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 0/4] colo: Add support for continious replication Type: series Message-id: cover.156

Re: [Qemu-devel] [PATCH v1 2/2] hw/pvrdma: add live migration support

2019-09-03 Thread Sukrit Bhatnagar
On Sun, 1 Sep 2019 at 01:15, Marcel Apfelbaum wrote: > > > > On 8/28/19 5:23 PM, Sukrit Bhatnagar wrote: > > vmstate_pvrdma describes the PCI and MSIX states as well as the dma > > address for dsr and the gid table of device. > > vmstate_pvrdma_gids describes each gid in the gid table. > > > > pvr

Re: [Qemu-devel] [PATCH 0/3] UUID validation during migration

2019-09-03 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Hi, > > This series adds an UUID validation at the start of the migration > on the target side. The idea is to identify the source of migration. > > Possible case of problem: > 1. There are 3 servers: A, B and C > 2. Server A has a VM 1, server B

Re: [Qemu-devel] [PATCH 1/3] migration: Add x-validate-uuid capability

2019-09-03 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 8/27/19 10:36 AM, Yury Kotov wrote: > > 27.08.2019, 17:02, "Eric Blake" : > >> On 8/27/19 7:02 AM, Yury Kotov wrote: > >>>  This capability realizes simple source validation by UUID. > >>>  It's useful for live migration between hosts. > >>> > > >> > >>

Re: [Qemu-devel] [PATCH 1/3] migration: Add x-validate-uuid capability

2019-09-03 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > This capability realizes simple source validation by UUID. > It's useful for live migration between hosts. > > Signed-off-by: Yury Kotov So, ignoring the question of whether it should be a capaibility or not, I'm actually OK with this; I would re

Re: [Qemu-devel] [PATCH for-4.2 v10 08/15] virtio-iommu: Implement map/unmap

2019-09-03 Thread Auger Eric
Hi Peter, On 8/19/19 10:11 AM, Peter Xu wrote: > On Tue, Jul 30, 2019 at 07:21:30PM +0200, Eric Auger wrote: > > [...] > >> +mapping = g_tree_lookup(domain->mappings, (gpointer)(&interval)); >> + >> +while (mapping) { >> +viommu_interval current; >> +uint64_t low = mappi

Re: [Qemu-devel] [PATCH for-4.2 v10 09/15] virtio-iommu: Implement translate

2019-09-03 Thread Auger Eric
Hi Peter, On 8/19/19 10:24 AM, Peter Xu wrote: > On Tue, Jul 30, 2019 at 07:21:31PM +0200, Eric Auger wrote: >> @@ -464,19 +464,75 @@ static IOMMUTLBEntry >> virtio_iommu_translate(IOMMUMemoryRegion *mr, hwaddr addr, >> int iommu_idx) >> { >> IOM

Re: [Qemu-devel] [PATCH 0/3] UUID validation during migration

2019-09-03 Thread Daniel P . Berrangé
On Tue, Sep 03, 2019 at 12:21:40PM +0100, Dr. David Alan Gilbert wrote: > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > > Hi, > > > > This series adds an UUID validation at the start of the migration > > on the target side. The idea is to identify the source of migration. > > > > Possible cas

[Qemu-devel] [PATCH v2 1/5] Kconfig: Expose CONFIG_TCG to minikconf.py

2019-09-03 Thread Philippe Mathieu-Daudé
Expose the CONFIG_TCG selector to let minikconf.py uses it. This is useful with the --disable-tcg build, to deselect devices that are TCG-dependent. Signed-off-by: Philippe Mathieu-Daudé --- Kconfig.host | 4 1 file changed, 4 insertions(+) diff --git a/Kconfig.host b/Kconfig.host index b

[Qemu-devel] [PATCH v2 2/5] target/arm: Restrict pre-ARMv7 cpus to TCG

2019-09-03 Thread Philippe Mathieu-Daudé
KVM requires a cpu based on (at least) the ARMv7 architecture. The following CPUs are disabled: * ARMv4 - StrongARM (SA1100/1110) - OMAP1510 (TI925T) * ARMv5 - ARM926 - ARM946 - ARM1026 - XScale (PXA250/255/260/261/262/270) * ARMv6 - ARM1136 - ARM1176 - ARM11MPCore - Cort

[Qemu-devel] [PATCH v2 3/5] hw/arm: Restrict pre-ARMv7 cpus to TCG

2019-09-03 Thread Philippe Mathieu-Daudé
A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. Signed-off-by: Philippe Mathieu-Daudé --- v2: - "depends on !KVM" -> "depends on TCG" (rth) - do not modify default-configs/arm-softmmu.mak (thuth) --- hw/arm/Kconfig | 23 +++ 1 file changed, 23 insertio

[Qemu-devel] [PATCH v2 0/5] Support disabling TCG on ARM (part 2)

2019-09-03 Thread Philippe Mathieu-Daudé
Cover from Samuel Ortiz from (part 1) [1]: This patchset allows for building and running ARM targets with TCG disabled. [...] The rationale behind this work comes from the NEMU project where we're trying to only support x86 and ARM 64-bit architectures, without including the TCG code ba

[Qemu-devel] [PATCH v2 4/5] target/arm: Restrict R and M profiles to TCG

2019-09-03 Thread Philippe Mathieu-Daudé
KVM is only able to run on CPUs based on the A-Profile architecture. The following CPUs are disabled: * M-Profile Architecture - Cortex-M3 - Cortex-M4 - Cortex-M33 * R-Profile Architecture - Cortex-R5 - Cortex-R5F Signed-off-by: Philippe Mathieu-Daudé --- v2: list cpus --- target/

[Qemu-devel] [PATCH v2 5/5] hw/arm: Restrict R and M profiles to TCG

2019-09-03 Thread Philippe Mathieu-Daudé
A KVM-only build won't be able to run A or M-profile cpus, disable them. Signed-off-by: Philippe Mathieu-Daudé --- v2: - "depends on !KVM" -> "depends on TCG" (rth) - do not modify default-configs/arm-softmmu.mak (thuth) --- hw/arm/Kconfig | 14 +++--- 1 file changed, 11 insertions(+

Re: [Qemu-devel] [PATCH v2 1/5] Kconfig: Expose CONFIG_TCG to minikconf.py

2019-09-03 Thread Thomas Huth
On 03/09/2019 13.47, Philippe Mathieu-Daudé wrote: > Expose the CONFIG_TCG selector to let minikconf.py uses it. > > This is useful with the --disable-tcg build, to deselect > devices that are TCG-dependent. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Kconfig.host | 4 > 1 file chang

[Qemu-devel] [PATCH] cutils: Move size_to_str() from "qemu-common.h" to "qemu/cutils.h"

2019-09-03 Thread Philippe Mathieu-Daudé
"qemu/cutils.h" contains various qemu_strtosz_*() functions useful to convert strings to size. It seems natural to have the opposite usage (from size to string) there too. The function definition is already in util/cutils.c. Signed-off-by: Philippe Mathieu-Daudé --- There are only 5 users, is it

Re: [Qemu-devel] [PATCH v2 2/5] target/arm: Restrict pre-ARMv7 cpus to TCG

2019-09-03 Thread Thomas Huth
On 03/09/2019 13.47, Philippe Mathieu-Daudé wrote: > KVM requires a cpu based on (at least) the ARMv7 architecture. > > The following CPUs are disabled: > > * ARMv4 > > - StrongARM (SA1100/1110) > - OMAP1510 (TI925T) > > * ARMv5 > > - ARM926 > - ARM946 > - ARM1026 > - XScale (PXA25

Re: [Qemu-devel] [PATCH v4 0/5] qcow2: async handling of fragmented io

2019-09-03 Thread Vladimir Sementsov-Ogievskiy
Pinging, as Stefan's branch merged into master and now these series based on master. 16.08.2019 18:30, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is an asynchronous scheme for handling fragmented qcow2 > reads and writes. Both qcow2 read and write functions loops through > sequential

Re: [Qemu-devel] [PATCH for-4.2 v10 10/15] virtio-iommu: Implement probe request

2019-09-03 Thread Auger Eric
Hi Peter, On 8/19/19 2:08 PM, Peter Xu wrote: > On Tue, Jul 30, 2019 at 07:21:32PM +0200, Eric Auger wrote: > > [...] > >> +/* Fill the properties[] buffer with properties of type @type */ >> +static int virtio_iommu_fill_property(int type, >> + viommu_proper

Re: [Qemu-devel] [PATCH v2 2/3] raspi: Raspberry Pi 3 support

2019-09-03 Thread Philippe Mathieu-Daudé
Hi Pekka and Zoltán, On Fri, Feb 16, 2018 at 8:04 AM Pekka Enberg wrote: > > This patch adds Raspberry Pi 3 support to hw/arm/raspi.c. The > differences to Pi 2 are: > > - Firmware address > - Board ID > - Board revision > > The CPU is different too, but that's going to be configured as part o

Re: [Qemu-devel] [PULL 00/15] Block patches

2019-09-03 Thread Max Reitz
On 03.09.19 10:39, Peter Maydell wrote: > On Tue, 27 Aug 2019 at 19:23, Max Reitz wrote: >> >> The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: >> >> Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into >> staging (2019-08-27 15:52:36 +0100) >>

Re: [Qemu-devel] [PATCH v2 3/6] hw/arm: Use sysbus_init_child_obj for correct reference counting

2019-09-03 Thread Peter Maydell
On Fri, 23 Aug 2019 at 16:26, Thomas Huth wrote: > > On 8/23/19 4:32 PM, Philippe Mathieu-Daudé wrote: > > As explained in commit aff39be0ed97: > > > > Both functions, object_initialize() and qdev_set_parent_bus() > > Commit aff39be0ed97 was not about qdev_set_parent_bus(), so the first > senten

Re: [Qemu-devel] [PATCH v2] iotests: Check for enabled drivers before testing them

2019-09-03 Thread Max Reitz
On 23.08.19 15:35, Thomas Huth wrote: > It is possible to enable only a subset of the block drivers with the > "--block-drv-rw-whitelist" option of the "configure" script. All other > drivers are marked as unusable (or only included as read-only with the > "--block-drv-ro-whitelist" option). If an

Re: [Qemu-devel] [PATCH V2] block/vhdx: add check for truncated image files

2019-09-03 Thread Kevin Wolf
Am 02.09.2019 um 17:24 hat Peter Lieven geschrieben: > qemu is currently not able to detect truncated vhdx image files. > Add a basic check if all allocated blocks are reachable at open and > report all errors during bdrv_co_check. > > Signed-off-by: Peter Lieven > --- > V2: - add error reporting

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2019-09-03 Thread Peter Maydell
On Tue, 27 Aug 2019 at 21:33, Stefan Hajnoczi wrote: > > The following changes since commit dac03af5d5482ec7ee9c23db467bb7230b33c0d9: > > Merge remote-tracking branch 'remotes/rth/tags/pull-axp-20190825' into > staging (2019-08-27 10:00:51 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH V2] block/vhdx: add check for truncated image files

2019-09-03 Thread Peter Lieven
Am 03.09.19 um 15:02 schrieb Kevin Wolf: Am 02.09.2019 um 17:24 hat Peter Lieven geschrieben: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven

Re: [Qemu-devel] [PATCH 0/7] target/sparc: Convert to do_transaction_failed hook

2019-09-03 Thread Peter Maydell
Mark -- ping? Richard has reviewed this series; do you want more time to test it, or should I just apply it to master if you don't have any other pending sparc patches? thanks -- PMM On Thu, 1 Aug 2019 at 19:30, Peter Maydell wrote: > > This patchset converts the SPARC target away from the old >

Re: [Qemu-devel] [PATCH v2] iotests: Check for enabled drivers before testing them

2019-09-03 Thread Thomas Huth
On 03/09/2019 14.55, Max Reitz wrote: > On 23.08.19 15:35, Thomas Huth wrote: >> It is possible to enable only a subset of the block drivers with the >> "--block-drv-rw-whitelist" option of the "configure" script. All other >> drivers are marked as unusable (or only included as read-only with the >

[Qemu-devel] [PATCH] iotests: skip 232 when run tests as root

2019-09-03 Thread Vladimir Sementsov-Ogievskiy
chmod a-w don't help under root, so skip the test in such case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/232 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232 index 2063f78876..da35a63d85 100755 --- a/tests/qemu-i

Re: [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment

2019-09-03 Thread Dr. David Alan Gilbert
* Wei Yang (richard.weiy...@gmail.com) wrote: > On Fri, Aug 23, 2019 at 02:05:02PM +0100, Dr. David Alan Gilbert wrote: > >* Daniel P. Berrang? (berra...@redhat.com) wrote: > >> On Fri, Aug 23, 2019 at 12:06:09PM +0100, Dr. David Alan Gilbert wrote: > >> > (Copying Dan in) > >> > > >> > * Wei Yang

[Qemu-devel] [PATCH 01/10] .travis.yml: Enable multiple caching features

2019-09-03 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Using the 'multiple caching features' means explode the YAML array, thus it eases the git workflow (it is easier to move patches around). See https://docs.travis-ci.com/user/caching#enabling-multiple-caching-features Signed-off-by: Philippe Mathieu-Daudé Reviewed-b

[Qemu-devel] [PATCH 02/10] .travis.yml: Increase cache timeout from 3min to 20min

2019-09-03 Thread Philippe Mathieu-Daudé
We are going to cache few gigabytes, increase the cache timeout to avoid build failures when uploading our cache. See https://docs.travis-ci.com/user/caching/#setting-the-timeout Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.ym

[Qemu-devel] [PATCH 03/10] .travis.yml: Cache Python PIP packages

2019-09-03 Thread Philippe Mathieu-Daudé
We always install the same packages ever and ever, cache them. See https://docs.travis-ci.com/user/caching/#pip-cache Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index a65d13a592..3211667adb 100644 --- a/.tr

[Qemu-devel] [PATCH 05/10] .travis.yml: Improve ccache use

2019-09-03 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Per https://ccache.dev/manual/latest.html: By default, ccache tries to give as few false cache hits as possible. However, in certain situations it’s possible that you know things that ccache can’t take for granted. [The CCACHE_SLOPINESS environment variable]

[Qemu-devel] [PATCH 07/10] .travis.yml: Document how the build matrix use caches

2019-09-03 Thread Philippe Mathieu-Daudé
We will set the CACHE_NAME variable to improve the caching of various jobs using the same characteristics. Document it first. See https://docs.travis-ci.com/user/caching/#caches-and-build-matrices Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 6 ++ 1 file changed, 6 insertions(+)

[Qemu-devel] [PATCH 04/10] .travis.yml: Cache Avocado cache

2019-09-03 Thread Philippe Mathieu-Daudé
Avocado tests download artifacts from various sources. These sources sometime have network issues resulting in build failures. Cache Avocado cache to reduce build failure. See https://docs.travis-ci.com/user/caching/#arbitrary-directories Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml |

[Qemu-devel] [PATCH 08/10] .travis.yml: Cache Linux/GCC 'debug profile' jobs together

2019-09-03 Thread Philippe Mathieu-Daudé
These jobs build different components but use the same host features. Put them in the same cache bucket. Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index c64a551829..e362c3fe02 100644 --- a/.travis.yml +++

Re: [Qemu-devel] [PATCH V2] block/vhdx: add check for truncated image files

2019-09-03 Thread Kevin Wolf
Am 03.09.2019 um 15:10 hat Peter Lieven geschrieben: > Am 03.09.19 um 15:02 schrieb Kevin Wolf: > > Am 02.09.2019 um 17:24 hat Peter Lieven geschrieben: > > > qemu is currently not able to detect truncated vhdx image files. > > > Add a basic check if all allocated blocks are reachable at open and >

[Qemu-devel] [PATCH 00/10] travis: Use caching when possible

2019-09-03 Thread Philippe Mathieu-Daudé
This series tries to reduce Travis CI failures due to network issues, and tries to speed builds a bit, reducing failures due to job timeouting. Travis feature: https://docs.travis-ci.com/user/caching/ To see improvement over time, I recommend to apply this series on top of different merge commit

[Qemu-devel] [PATCH 06/10] .travis.yml: Enable ccache on OSX

2019-09-03 Thread Philippe Mathieu-Daudé
By default, ccache is not installed on macOS environments. See https://docs.travis-ci.com/user/caching/#ccache-on-macos Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index fccc1e091d..640d84f201 100644 --- a

[Qemu-devel] [PULL v2 04/16] iotests: Test allocate_first_block() with O_DIRECT

2019-09-03 Thread Max Reitz
From: Nir Soffer Using block_resize we can test allocate_first_block() with file descriptor opened with O_DIRECT, ensuring that it works for any size larger than 4096 bytes. Testing smaller sizes is tricky as the result depends on the filesystem used for testing. For example on NFS any size will

Re: [Qemu-devel] [PATCH 0/2] linux-user/arm: Adjust MAX_RESERVED_VA for M-profile

2019-09-03 Thread Peter Maydell
On Thu, 22 Aug 2019 at 19:59, Richard Henderson wrote: > > This is inspired by the discussion in > >https://bugs.launchpad.net/qemu/+bug/1840922 > > Previously I suggested a new CPUClass hook, but when I went > to implement that seemed like overkill. > > > r~ > > > Richard Henderson (2): > l

[Qemu-devel] [PULL v2 00/16] Block patches

2019-09-03 Thread Max Reitz
The following changes since commit 54b89db5309d5fa8b5d3fe5fe56f81704e2f9706: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-09-03 09:43:26 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2019-09-0

[Qemu-devel] [PATCH 09/10] .travis.yml: Cache Linux/GCC 'non-debug profile' jobs together

2019-09-03 Thread Philippe Mathieu-Daudé
These jobs build different components but use the same host features. Put them in the same cache bucket. Signed-off-by: Philippe Mathieu-Daudé --- .travis.yml | 13 + 1 file changed, 13 insertions(+) diff --git a/.travis.yml b/.travis.yml index e362c3fe02..7132cf8fba 100644 --- a/.t

[Qemu-devel] [PULL v2 05/16] iotests: Fix _filter_img_create()

2019-09-03 Thread Max Reitz
fe646693acc changed qemu-img create's output so that it no longer prints single quotes around parameter values. The subformat and adapter_type filters in _filter_img_create() have never been adapted to that change. Fixes: fe646693acc13ac48b98435d14149ab04dc597bc Signed-off-by: Max Reitz Reviewed

  1   2   3   4   >