On Wed, 28 Aug 2019 at 01:07, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 8/27/19 2:34 AM, Peter Maydell wrote: > >> + tcg_gen_andi_i32(tmp, tmp, -4); > > > > Minor nit, but can we use 0xfffffffc like the old code did, > > to avoid the reader having to do 2s-complement arithmetic > > in their head to figure out that we're clearing the low 2 bits? > > I always preferred "x & -c" for exactly the same reason: > to avoid the reader having to do 2s compliment arithmetic > in their head to figure out that we're aligning to c.
I guess this is mostly a personal thing -- I don't have in my head any idea of what doing a logical operation on a negative number does, so I always have to convert it back to "what are the actual bits here" before I understand it. thanks -- PMM
