[Qemu-devel] [PATCH] xhci: Fix memory leak in xhci_address_slot

2019-08-27 Thread Ying Fang
Address Sanitizer shows memory leak in xhci_address_slot hw/usb/hcd-xhci.c:2156 and the stack is as bellow: Direct leak of 64 byte(s) in 4 object(s) allocated from: #0 0x91c6f5ab in realloc (/lib64/libasan.so.4+0xd35ab) #1 0x91987243 in g_realloc (/lib64/libglib-2.0.so.0+0x57243)

[Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread Ying Fang
Address Sanitizer shows memory leak in migrate_params_test_apply migration/migration.c:1253 and the stack is as bellow: Direct leak of 45 byte(s) in 9 object(s) allocated from: #0 0xbd7fc1db in __interceptor_malloc (/lib64/libasan.so.4+0xd31db) #1 0xbd514163 in g_malloc (/lib64/lib

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

2019-08-27 Thread Peter Maydell
On Mon, 26 Aug 2019 at 22:10, Josh Kunz wrote: > That said, overall, fixing the SIGRTMIN+1 issue using a more-generic > signal-multiplexing mechanism doesn't seem *that* much better to me. It adds > a lot of complexity, and only saves a single signal (assuming glibc doesn't > add more reserved

[Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface

2019-08-27 Thread Sam Eiderman via Qemu-devel
v1: Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most likely break under QEMU/SeaBIOS if it has non-standard logical geometries - for example 56

[Qemu-devel] [PATCH v6 5/8] bootdevice: Gather LCHS from all relevant devices

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Relevant devices are: * ide-hd (and ide-cd, ide-drive) * scsi-hd (and scsi-cd, scsi-disk, scsi-block) * virtio-blk-pci We do not call del_boot_device_lchs() for ide-* since we don't need to - IDE block devices do not support unplugging. Signed-off-by: Sam Eiderman

[Qemu-devel] [PATCH v6 7/8] bootdevice: FW_CFG interface for LCHS values

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Using fw_cfg, supply logical CHS values directly from QEMU to the BIOS. Non-standard logical geometries break under QEMU. A virtual disk which contains an operating system which depends on logical geometries (consistent values being reported from BIOS INT13 AH=08) will most l

[Qemu-devel] [PATCH v6 3/8] bootdevice: Add interface to gather LCHS

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Add an interface to provide direct logical CHS values for boot devices. We will use this interface in the next commits. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman --- bootdevice.c| 55 +

[Qemu-devel] [PATCH v6 1/8] block: Refactor macros - fix tabbing

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Fixing tabbing in block related macros. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman --- hw/ide/qdev.c| 2 +- include/hw/block/block.h | 16 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/id

[Qemu-devel] [PATCH v6 4/8] scsi: Propagate unrealize() callback to scsi-hd

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman We will need to add LCHS removal logic to scsi-hd's unrealize() in the next commit. Signed-off-by: Sam Eiderman Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman --- hw/scsi/scsi-bus.c | 16 include/hw/scsi/scsi.h | 1 +

[Qemu-devel] [PATCH v6 8/8] hd-geo-test: Add tests for lchs override

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Add QTest tests to check the logical geometry override option. The tests in hd-geo-test are out of date - they only test IDE and do not test interesting MBRs. I added a few helper functions which will make adding more tests easier. QTest's fw_cfg helper functions support onl

[Qemu-devel] [PATCH v6 2/8] block: Support providing LCHS from user

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Add logical geometry variables to BlockConf. A user can now supply "lcyls", "lheads" & "lsecs" for any HD device that supports CHS ("cyls", "heads", "secs"). These devices include: * ide-hd * scsi-hd * virtio-blk-pci In future commits we will use the provided LCH

Re: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190827080512.2417-1-fangyi...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827080512.2417-1-fangyi...@huawei.com Type: series Subject: [Qemu-devel] [PATCH] qmp: Fix memory

[Qemu-devel] [PATCH] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Johannes Berg
From: Johannes Berg If you try to make a device implementation that can handle multiple connections and allow disconnections (which requires overriding the VHOST_USER_NONE handling), then glib will warn that we remove a src while it's still on the mainloop, and will poll() an FD that doesn't exis

[Qemu-devel] [PATCH v6 6/8] bootdevice: Refactor get_boot_devices_list

2019-08-27 Thread Sam Eiderman via Qemu-devel
From: Sam Eiderman Move device name construction to a separate function. We will reuse this function in the following commit to pass logical CHS parameters through fw_cfg much like we currently pass bootindex. Reviewed-by: Karl Heubaum Reviewed-by: Arbel Moshe Signed-off-by: Sam Eiderman ---

Re: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread Li Qiang
Ying Fang 于2019年8月27日周二 下午4:06写道: > Address Sanitizer shows memory leak in migrate_params_test_apply > migration/migration.c:1253 and the stack is as bellow: > > Direct leak of 45 byte(s) in 9 object(s) allocated from: > #0 0xbd7fc1db in __interceptor_malloc (/lib64/libasan.so.4+0xd31db)

Re: [Qemu-devel] [PATCH] xhci: Fix memory leak in xhci_address_slot

2019-08-27 Thread Li Qiang
Ying Fang 于2019年8月27日周二 下午4:03写道: > Address Sanitizer shows memory leak in xhci_address_slot > hw/usb/hcd-xhci.c:2156 and the stack is as bellow: > > Direct leak of 64 byte(s) in 4 object(s) allocated from: > #0 0x91c6f5ab in realloc (/lib64/libasan.so.4+0xd35ab) > #1 0x91987243 i

Re: [Qemu-devel] [PATCH v2 1/2] nbd: Use g_autofree in a few places

2019-08-27 Thread Daniel P . Berrangé
On Sat, Aug 24, 2019 at 12:28:12PM -0500, Eric Blake wrote: > Thanks to our recent move to use glib's g_autofree, I can join the > bandwagon. Getting rid of gotos is fun ;) > > There are probably more places where we could register cleanup > functions and get rid of more gotos; this patch just fo

Re: [Qemu-devel] [PATCH v2 2/2] nbd: Tolerate more errors to structured reply request

2019-08-27 Thread Daniel P . Berrangé
On Sat, Aug 24, 2019 at 12:28:13PM -0500, Eric Blake wrote: > A server may have a reason to reject a request for structured replies, > beyond just not recognizing them as a valid request; similarly, it may > have a reason for rejecting a request for a meta context. It doesn't > hurt us to continue

Re: [Qemu-devel] [PATCH 05/13] qcrypto-luks: clear the masterkey and password before freeing them always

2019-08-27 Thread Daniel P . Berrangé
On Sun, Aug 25, 2019 at 06:31:02PM +0300, Maxim Levitsky wrote: > On Thu, 2019-08-22 at 13:56 +0300, Maxim Levitsky wrote: > > On Thu, 2019-08-22 at 11:49 +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 20, 2019 at 08:12:51PM +0200, Max Reitz wrote: > > > > On 14.08.19 22:22, Maxim Levitsky wrot

Re: [Qemu-devel] [PATCH 06/13] qcrypto-luks: implement more rigorous header checking

2019-08-27 Thread Daniel P . Berrangé
On Sun, Aug 25, 2019 at 07:08:00PM +0300, Maxim Levitsky wrote: > On Sun, 2019-08-25 at 18:40 +0300, Maxim Levitsky wrote: > > On Thu, 2019-08-22 at 12:04 +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 14, 2019 at 11:22:12PM +0300, Maxim Levitsky wrote: > > > > Check that keyslots don't overlap

Re: [Qemu-devel] [PULL 0/2] Block patches

2019-08-27 Thread Peter Maydell
On Thu, 22 Aug 2019 at 16:53, Stefan Hajnoczi wrote: > > The following changes since commit 33f18cf7dca7741d3647d514040904ce83edd73d: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20190821-pull-request' into staging (2019-08-21 > 15:18:50 +0100) > > are available in the Git rep

Re: [Qemu-devel] [PATCH] hw/net/vmxnet3: Fix leftover unregister_savevm

2019-08-27 Thread Dmitry Fleytman
> On 22 Aug 2019, at 14:12, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > Commit 78dd48df3 reworked vmxnet3's live migration but left a straggling > unregister_savevm call. Remove it, although it doesn't seem to have > any bad effect. > Reviewed-by: Dmitry F

Re: [Qemu-devel] [PATCH v2 63/68] target/arm: Convert T16, shift immediate

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 26 ++ > target/arm/t16.decode | 8 > 2 files changed, 10 insertions(+), 24 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 64/68] target/arm: Convert T16, load (literal)

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread fangying
On 2019/8/27 16:38, Li Qiang wrote: Ying Fang mailto:fangyi...@huawei.com>> 于2019年8月27日周 二 下午4:06写道: Address Sanitizer shows memory leak in migrate_params_test_apply migration/migration.c:1253 and the stack is as bellow: Direct leak of 45 byte(s) in 9 object(s) allocated from

Re: [Qemu-devel] [PATCH v2 65/68] target/arm: Convert T16, Unconditional branch

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 9 ++--- > target/arm/t16.decode | 6 ++ > 2 files changed, 8 insertions(+), 7 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v29 8/8] target/avr: Add tests

2019-08-27 Thread Alex Bennée
Richard Henderson writes: > On 8/26/19 2:23 AM, Alex Bennée wrote: >> Are there any compilers available so we can add the multiarch tests to >> "check-tcg"? > > Debian has a gcc-avr package. Looking at the bios "bytes" it should be easy enough to do a simple serial based test. We can add it a

Re: [Qemu-devel] [PATCH v29 8/8] target/avr: Add tests

2019-08-27 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Richard Henderson writes: > > > On 8/26/19 2:23 AM, Alex Bennée wrote: > >> Are there any compilers available so we can add the multiarch tests to > >> "check-tcg"? > > > > Debian has a gcc-avr package. > > Looking at the bios "bytes" it sho

Re: [Qemu-devel] [PATCH v2 66/68] target/arm: Convert T16, long branches

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 89 +++--- > target/arm/t16.decode | 3 ++ > 2 files changed, 43 insertions(+), 49 deletions(-) > +static bool trans_BLX_suffix(Disa

Re: [Qemu-devel] [PATCH v2 67/68] target/arm: Clean up disas_thumb_insn

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Now that everything is converted, remove the rest of > the legacy decode. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 27 ++- > 1 file changed, 2 insertions(+), 25 deletions(-) Reviewed-

Re: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface

2019-08-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190827082427.64280-1-sam...@google.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827082427.64280-1-sam...@google.com Type: series Subject: [Qemu-devel] [PATCH v6 0/8] Add Qemu to Se

[Qemu-devel] [PATCH v6 0/3] target/ppc: Optimize emulation of some Altivec instructions

2019-08-27 Thread Stefan Brankovic
Optimize emulation of ten Altivec instructions: lvsl, lvsr, vsl, vsr, vpkpx, vgbbd, vclzb, vclzh, vclzw and vclzd. This series buils up on and complements recent work of Thomas Murta, Mark Cave-Ayland and Richard Henderson in the same area. It is based on devising TCG translation implementation fo

[Qemu-devel] [PATCH v6 3/3] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

2019-08-27 Thread Stefan Brankovic
Since I found this two instructions implemented with tcg, I refactored them so they are consistent with other similar implementations that I introduced in this patch. Also, a new dual macro GEN_VXFORM_TRANS_DUAL is added. This macro is used if one instruction is realized with direct translation, a

[Qemu-devel] [PATCH v6 1/3] target/ppc: Optimize emulation of vpkpx instruction

2019-08-27 Thread Stefan Brankovic
Optimize altivec instruction vpkpx (Vector Pack Pixel). Rearranges 8 pixels coded in 6-5-5 pattern (4 from each source register) into contigous array of bits in the destination register. In each iteration of outer loop, the instruction is to be done with the 6-5-5 pack for 2 pixels of each doublew

[Qemu-devel] [PATCH v6 2/3] target/ppc: Optimize emulation of vclzh and vclzb instructions

2019-08-27 Thread Stefan Brankovic
Optimize Altivec instruction vclzh (Vector Count Leading Zeros Halfword). This instruction counts the number of leading zeros of each halfword element in source register and places result in the appropriate halfword element of destination register. In each iteration of outer for loop count operati

Re: [Qemu-devel] [PATCH v2 68/68] target/arm: Inline gen_bx_im into callers

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > There are only two remaining uses of gen_bx_im. In each case, we > know the destination mode -- not changing in the case of gen_jmp > or changing in the case of trans_BLX_i. Use this to simplify the > surrounding code. > > For trans_BLX_

[Qemu-devel] [PATCH] hw/arm/boot: Load the Non Linux initrd to the memory

2019-08-27 Thread Dongjiu Geng
Except support linux operation system, qemu also supports other operation system which is non linux, such as microkernel system. But now Qemu only load linux initrd, so change it to load both linux and Non-linux initrd Image. Signed-off-by: Dongjiu Geng --- hw/arm/boot.c | 45 +

Re: [Qemu-devel] [PATCH v2 1/2] xen-bus: Fix backend state transition on device reset

2019-08-27 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 23 August 2019 11:16 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; qemu-sta...@nongnu.org; > Stefano Stabellini > ; Paul Durrant ; > xen-de...@lists.xenproject.org > Subject: [PATCH v2 1/2] xen-bus: Fix backend state transition on

Re: [Qemu-devel] [PATCH v2 2/2] xen-bus: Avoid rewriting identical values to xenstore

2019-08-27 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD > Sent: 23 August 2019 11:16 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; Stefano Stabellini > ; Paul > Durrant ; xen-de...@lists.xenproject.org > Subject: [PATCH v2 2/2] xen-bus: Avoid rewriting identical values to xenstore > > When QEMU

Re: [Qemu-devel] [PATCH] hw/arm/boot: Load the Non Linux initrd to the memory

2019-08-27 Thread Peter Maydell
On Tue, 27 Aug 2019 at 10:42, Dongjiu Geng wrote: > > Except support linux operation system, qemu also supports other > operation system which is non linux, such as microkernel system. > > But now Qemu only load linux initrd, so change it to load both > linux and Non-linux initrd Image. We curren

[Qemu-devel] [PATCH 2/4] virtiofsd: add --print-capabilities option

2019-08-27 Thread Stefan Hajnoczi
Add the --print-capabilities option as per vhost-user.rst "Backend programs conventions". Currently there are no advertised features. Signed-off-by: Stefan Hajnoczi --- docs/interop/vhost-user.json | 4 +++- contrib/virtiofsd/fuse_lowlevel.h | 1 + contrib/virtiofsd/helper.c |

[Qemu-devel] [PATCH 4/4] virtiofsd: add vhost-user.json file

2019-08-27 Thread Stefan Hajnoczi
Install a vhost-user.json file describing virtiofsd. This allows libvirt and other management tools to enumerate vhost-user backend programs. Signed-off-by: Stefan Hajnoczi --- Makefile| 1 + .gitignore | 1 + contrib/virtiofs

[Qemu-devel] [PATCH 0/4] virtiofsd: implement vhost-user.rst "Backend program conventions"

2019-08-27 Thread Stefan Hajnoczi
This series implements the conventions for vhost-user backend programs described in vhost-user.rst: 1. Run in the foreground by default. 2. Show vhost-user.json capabilities when --print-capabilities is given. 3. Ship a vhost-user.json file so the program can be discovered. No command-line options

[Qemu-devel] [PATCH 1/4] virtiofsd: make -f (foreground) the default

2019-08-27 Thread Stefan Hajnoczi
According to vhost-user.rst "Backend program conventions", backend programs should run in the foregound by default. Follow the conventions so libvirt and other management tools can control virtiofsd in a standard way. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/helper.c | 3 +++ 1 file

[Qemu-devel] [PATCH 3/4] virtiofsd: install virtiofsd in libexec

2019-08-27 Thread Stefan Hajnoczi
Build and install virtiofsd on Linux hosts. This is also how vhost-user-gpu is handled. Signed-off-by: Stefan Hajnoczi --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index a3dfdd6fa8..ef6eca07cc 100644 --- a/Makefile +++ b/Makefile @@ -317,6 +317,8 @@ HEL

Re: [Qemu-devel] [PULL 0/1] target/alpha queue

2019-08-27 Thread Peter Maydell
On Sun, 25 Aug 2019 at 20:37, Richard Henderson wrote: > > The following changes since commit 586f3dced9f2b354480c140c070a3d02a0c66a1e: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190822' into > staging (2019-08-23 15:15:44 +0100) > > are available in the Git repository at: >

Re: [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface

2019-08-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190827082427.64280-1-sam...@google.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827082427.64280-1-sam...@google.com Type: series Subject: [Qemu-devel] [PATCH v6 0/8] Add Qemu to Se

[Qemu-devel] [PATCH] file-posix: fix request_alignment typo

2019-08-27 Thread Stefan Hajnoczi
Fixes: a6b257a08e3d72219f03e461a52152672fec0612 ("file-posix: Handle undetectable alignment") Signed-off-by: Stefan Hajnoczi --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index fbeb0068db..67abd1f01c 10064

Re: [Qemu-devel] [PATCH] file-posix: fix request_alignment typo

2019-08-27 Thread Thomas Huth
On 27/08/2019 12.13, Stefan Hajnoczi wrote: > Fixes: a6b257a08e3d72219f03e461a52152672fec0612 >("file-posix: Handle undetectable alignment") > Signed-off-by: Stefan Hajnoczi > --- > block/file-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/file-pos

Re: [Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > This fixes an exiting bug with the T5 encoding of SUBS PC, LR, #IMM, > in that it may be executed from user mode as with any other encoding > of SUBS, not as ERET. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 119

Re: [Qemu-devel] [PATCH 1/2] Revert "target/arm: Use unallocated_encoding for aarch32"

2019-08-27 Thread Laurent Desnogues
Hi, On Mon, Aug 26, 2019 at 5:15 PM Richard Henderson wrote: > > This reverts commit 3cb36637157088892e9e33ddb1034bffd1251d3b. > > Despite the fact that the text for the call to gen_exception_insn > is identical for aarch64 and aarch32, the implementation inside > gen_exception_insn is totally di

Re: [Qemu-devel] [PATCH 2/2] target/arm: Factor out unallocated_encoding for aarch32

2019-08-27 Thread Laurent Desnogues
On Mon, Aug 26, 2019 at 5:15 PM Richard Henderson wrote: > > Make this a static function private to translate.c. > Thus we can use the same idiom between aarch64 and aarch32 > without actually sharing function implementations. > > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues

Re: [Qemu-devel] [PATCH v2 21/68] target/arm: Convert Synchronization primitives

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 560 ++--- > target/arm/a32.decode | 48 > target/arm/t32.decode | 46 > 3 files changed, 396 insertions(+), 258 deletion

Re: [Qemu-devel] [GSOC] Support for AVX within TCG: Work Product Submission

2019-08-27 Thread Stefan Hajnoczi
On Sun, Aug 25, 2019 at 03:30:49PM -0400, Jan Bobek wrote: > Hi folks, > > those of you who have been keeping up with Google Summer of Code > this year might know that it's nearly over -- meaning that it's > time for me to summarize all the work that I have done as a > participant. Without further

Re: [Qemu-devel] [PATCH v2 21/68] target/arm: Convert Synchronization primitives

2019-08-27 Thread Peter Maydell
On Tue, 27 Aug 2019 at 11:44, Peter Maydell wrote: > > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > wrote: > > > > Signed-off-by: Richard Henderson > > --- > > target/arm/translate.c | 560 ++--- > > target/arm/a32.decode | 48 > > target/arm/t32.

Re: [Qemu-devel] [PATCH v2 01/13] introduce g_autowipe

2019-08-27 Thread Tony Nguyen
Hi Maxim, On Mon, Aug 26, 2019 at 04:50:51PM +0300, Maxim Levitsky wrote: > 2. is it portable enought for us to use malloc_usable_size > to get the size of malloced pointer in the autofree callback? > This function is aviable in glibc (but no wrapper in glib). We will also need to consider host p

Re: [Qemu-devel] [PATCH] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Marc-André Lureau
Hi On Tue, Aug 27, 2019 at 12:32 PM Johannes Berg wrote: > > From: Johannes Berg > > If you try to make a device implementation that can handle multiple > connections and allow disconnections (which requires overriding the > VHOST_USER_NONE handling), then glib will warn that we remove a src > w

Re: [Qemu-devel] [PATCH v2 01/13] introduce g_autowipe

2019-08-27 Thread Daniel P . Berrangé
On Mon, Aug 26, 2019 at 04:50:51PM +0300, Maxim Levitsky wrote: > Marking a pointer with g_autowipe, will > not only free it at the scope exit, but also > erase the data it points to just prior to freeing it. > > This is first attempt to implement this feature, > as suggested by Daniel and Nir. >

Re: [Qemu-devel] [PATCH v29 1/8] target/avr: Add outward facing interfaces and core CPU logic

2019-08-27 Thread Sarah Harris
I don't mind if you want to drop my signed-off-by for commits that were based on Michael's work. You probably want to keep my sign-off for the USART/timer commit though as that was new code. Regards, Sarah Harris On Mon, 26 Aug 2019 10:00:51 +0200 Thomas Huth wrote: > On 26/08/2019 09.53, Mic

Re: [Qemu-devel] [PATCH v2 41/68] target/arm: Convert TT

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 87 +- > target/arm/t32.decode | 5 ++- > 2 files changed, 31 insertions(+), 61 deletions(-) > > diff --git a/target/arm/translat

Re: [Qemu-devel] [PATCH v2 21/68] target/arm: Convert Synchronization primitives

2019-08-27 Thread Peter Maydell
On Tue, 27 Aug 2019 at 11:46, Peter Maydell wrote: > ...OK, not this specific function, as I just noticed it's the _a32 > one, but trans_STREXB(), trans_STREXH(), etc are wrong. I did a quick grep through for places checking the 6K condition, and I think these are the only ones that need changing

[Qemu-devel] [PATCH] qmp: Fix memory leak in migrate_params_test_apply

2019-08-27 Thread Ying Fang
Address Sanitizer shows memory leak in migrate_params_test_apply migration/migration.c:1253 and the stack is as bellow: Direct leak of 45 byte(s) in 9 object(s) allocated from: #0 0xbd7fc1db in __interceptor_malloc (/lib64/libasan.so.4+0xd31db) #1 0xbd514163 in g_malloc (/lib64/lib

Re: [Qemu-devel] [PATCH v2 01/13] introduce g_autowipe

2019-08-27 Thread Maxim Levitsky
On Tue, 2019-08-27 at 11:52 +0100, Daniel P. Berrangé wrote: > On Mon, Aug 26, 2019 at 04:50:51PM +0300, Maxim Levitsky wrote: > > Marking a pointer with g_autowipe, will > > not only free it at the scope exit, but also > > erase the data it points to just prior to freeing it. > > > > This is firs

[Qemu-devel] [PATCH] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest

2019-08-27 Thread Thomas Huth
libqos library functions should never depend on functions (like memread(), memwrite() or clock_step()) that require global_qtest to be set, since library functions might get used in qtests that track multiple states, too. Thus let's replace the global_qtest-related functions with their independent

Re: [Qemu-devel] [PATCH v2 3/4] audio: paaudio: fix client name

2019-08-27 Thread Maxim Levitsky
On Tue, 2019-08-27 at 07:37 +0200, Gerd Hoffmann wrote: > On Mon, Aug 26, 2019 at 09:59:03PM +0200, Kővágó, Zoltán wrote: > > pa_context_new expects a client name, not a server socket path. > > > > Signed-off-by: Kővágó, Zoltán > > Reviewed-by: Maxim Levitsky > > --- > > audio/paaudio.c | 2 +-

Re: [Qemu-devel] [PATCH] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Johannes Berg
On Tue, 2019-08-27 at 14:47 +0400, Marc-André Lureau wrote: > Hi > > On Tue, Aug 27, 2019 at 12:32 PM Johannes Berg > wrote: > > From: Johannes Berg > > > > If you try to make a device implementation that can handle multiple > > connections and allow disconnections (which requires overriding th

Re: [Qemu-devel] [PATCH] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Marc-André Lureau
Hi On Tue, Aug 27, 2019 at 3:37 PM Johannes Berg wrote: > > On Tue, 2019-08-27 at 14:47 +0400, Marc-André Lureau wrote: > > Hi > > > > On Tue, Aug 27, 2019 at 12:32 PM Johannes Berg > > wrote: > > > From: Johannes Berg > > > > > > If you try to make a device implementation that can handle multi

Re: [Qemu-devel] [PATCH v3 1/3] qcow2: introduce compression type feature

2019-08-27 Thread Vladimir Sementsov-Ogievskiy
19.08.2019 18:00, Denis Plotnikov wrote: > The patch adds some preparation parts for incompatible compression type > feature to QCOW2 header that indicates that *all* compressed clusters > must be (de)compressed using a certain compression type. > > It is implied that the compression type is set o

Re: [Qemu-devel] [PATCH v3 2/3] qcow2: rework the cluster compression routine

2019-08-27 Thread Vladimir Sementsov-Ogievskiy
19.08.2019 18:00, Denis Plotnikov wrote: > The patch allow to process image compression type defined > in the image header and choose an appropriate method for > image clusters (de)compression. > > Signed-off-by: Denis Plotnikov > --- > block/qcow2-threads.c | 78 +++

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-27 Thread Peter Maydell
On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini wrote: > > On 23/08/19 14:07, Peter Maydell wrote: > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is > >> not built as module" to qemu.git directly? > > Is the other one also needed as a build fix ? > > Yes, otherwise the test f

[Qemu-devel] [PATCH 0/3] UUID validation during migration

2019-08-27 Thread Yury Kotov
Hi, This series adds an UUID validation at the start of the migration on the target side. The idea is to identify the source of migration. Possible case of problem: 1. There are 3 servers: A, B and C 2. Server A has a VM 1, server B has a VM 2 3. VM 1 and VM 2 want to migrate to the server C 4. T

[Qemu-devel] [PATCH 1/3] migration: Add x-validate-uuid capability

2019-08-27 Thread Yury Kotov
This capability realizes simple source validation by UUID. It's useful for live migration between hosts. Signed-off-by: Yury Kotov --- migration/migration.c | 9 + migration/migration.h | 1 + migration/savevm.c| 45 +++ qapi/migration.json

[Qemu-devel] [PATCH 3/3] tests/migration: Add a test for x-validate-uuid capability

2019-08-27 Thread Yury Kotov
Signed-off-by: Yury Kotov --- tests/migration-test.c | 140 - 1 file changed, 110 insertions(+), 30 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index b87ba99a9e..adac1c01a2 100644 --- a/tests/migration-test.c +++ b/tests/migra

Re: [Qemu-devel] [PATCH] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Johannes Berg
Hi, > What other problems? Sure we need the caller to unref. Don't recall, and now I can't reproduce it, sorry. > > > Imho, we should change the behaviour of the function to return a ref > > > source. > > > > Which "the function" do you mean? > > The vug_source_new() function. [...] > Sure we

[Qemu-devel] [PATCH 2/3] tests/libqtest: Allow to set expected exit status

2019-08-27 Thread Yury Kotov
Add qtest_set_expected_status function to set expected exit status of child process. By default expected exit status is 0. Signed-off-by: Yury Kotov --- tests/libqtest.c | 14 +++--- tests/libqtest.h | 9 + 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/tests/li

[Qemu-devel] [PATCH v2] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Johannes Berg
From: Johannes Berg If you try to make a device implementation that can handle multiple connections and allow disconnections (which requires overriding the VHOST_USER_NONE handling), then glib will warn that we remove a src while it's still on the mainloop, and will poll() an FD that doesn't exis

Re: [Qemu-devel] [Libguestfs] cross-project patches: Add NBD Fast Zero support

2019-08-27 Thread Richard W.M. Jones
On Fri, Aug 23, 2019 at 09:30:36AM -0500, Eric Blake wrote: > I've run several tests to demonstrate why this is useful, as well as > prove that because I have multiple interoperable projects, it is worth > including in the NBD standard. The original proposal was here: > https://lists.debian.org/nb

[Qemu-devel] [PATCH] target/arm: Free TCG temps in trans_VMOV_64_sp()

2019-08-27 Thread Peter Maydell
The function neon_store_reg32() doesn't free the TCG temp that it is passed, so the caller must do that. We got this right in most places but forgot to free the TCG temps in trans_VMOV_64_sp(). Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell --- target/arm/translate-vfp.inc.c | 2 ++ 1 f

Re: [Qemu-devel] [Libguestfs] [libnbd PATCH 1/1] api: Add support for FAST_ZERO flag

2019-08-27 Thread Richard W.M. Jones
Yes this libnbd patch all looks reasonable to me. ACK conditional on NBD protocol changes and agreement as discussed elsewhere. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libgues

Re: [Qemu-devel] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal)

2019-08-27 Thread Peter Maydell
On Fri, 23 Aug 2019 at 15:54, Peter Maydell wrote: > > On Mon, 19 Aug 2019 at 22:38, Richard Henderson > wrote: > > > > Signed-off-by: Richard Henderson > > --- > > target/arm/translate.c | 797 ++--- > > target/arm/a32.decode | 120 +++ > > target/arm/t

Re: [Qemu-devel] [PATCH v2 00/68] target/arm: Convert aa32 base isa to decodetree

2019-08-27 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:37, Richard Henderson wrote: > > This unifies the implementation of the actual instructions for > a32, t32, and t16. > > This has been tested by running the debian 9 armhf installer, > which does a far amount of switching between arm and thumb modes. > I've also run Peter

Re: [Qemu-devel] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Denis V. Lunev
On 8/22/19 11:09 PM, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > s/make/use/ > >> fallocate() for the unaligned byte range.

Re: [Qemu-devel] [PATCH] block: workaround for unaligned byte range in fallocate()

2019-08-27 Thread Andrey Shinkevich
On 23/08/2019 00:09, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > > s/make/use/ > >> fallocate() for the unaligned byte r

Re: [Qemu-devel] [PATCH v2] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190827121339.15815-1-johan...@sipsolutions.net/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190827121339.15815-1-johan...@sipsolutions.net Subject: [Qemu-devel] [PATCH v2] libvhost-user-

[Qemu-devel] [PATCH v3] libvhost-user-glib: fix VugDev main fd cleanup

2019-08-27 Thread Johannes Berg
From: Johannes Berg If you try to make a device implementation that can handle multiple connections and allow disconnections (which requires overriding the VHOST_USER_NONE handling), then glib will warn that we remove a src while it's still on the mainloop, and will poll() an FD that doesn't exis

Re: [Qemu-devel] [PATCH v3 3/3] qcow2: add zstd cluster compression

2019-08-27 Thread Vladimir Sementsov-Ogievskiy
19.08.2019 18:00, Denis Plotnikov wrote: > zstd significantly reduces cluster compression time. > It provides better compression performance maintaining > the same level of compression ratio in comparison with > zlib, which, at the moment, has been the only compression > method available. > > The

Re: [Qemu-devel] [PATCH 0/2] target/arm: Fix aarch64 illegal opcode exceptions

2019-08-27 Thread Peter Maydell
On Mon, 26 Aug 2019 at 16:15, Richard Henderson wrote: > > As Laurent pointed out, gen_exception_insn is very different > between aarch64 and aarch32, so we shouldn't accidentally > redirect one to the other. > > > r~ > > > Richard Henderson (2): > Revert "target/arm: Use unallocated_encoding fo

Re: [Qemu-devel] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-08-27 Thread Igor Mammedov
On Tue, 20 Aug 2019 18:07:27 +0200 Cornelia Huck wrote: > On Wed, 7 Aug 2019 11:32:41 -0400 > Igor Mammedov wrote: > > > Max memslot size supported by kvm on s390 is 8Tb, > > move logic of splitting RAM in chunks upto 8T to KVM code. > > > > This way it will hide KVM specific restrictions in

Re: [Qemu-devel] [PATCH v6 05/10] accel: adding TB_JIT_TIME and full replacing CONFIG_PROFILER

2019-08-27 Thread Alex Bennée
vandersonmr writes: > Replace all others CONFIG_PROFILER statistics and migrate it to > TBStatistics system. However, TCGProfiler still exists and can > be use to store global statistics and times. All TB related > statistics goes to TBStatistics. > > Signed-off-by: Vanderson M. do Rosario > -

Re: [Qemu-devel] [PATCH v9 05/11] numa: Extend CLI to provide initiator information for numa nodes

2019-08-27 Thread Igor Mammedov
On Tue, 20 Aug 2019 16:34:44 +0800 Tao Xu wrote: > On 8/16/2019 10:57 PM, Igor Mammedov wrote: > > On Wed, 14 Aug 2019 19:31:27 -0700 > > Dan Williams wrote: > > > >> On Wed, Aug 14, 2019 at 6:57 PM Tao Xu wrote: > >>> > >>> On 8/15/2019 5:29 AM, Dan Williams wrote: > On Tue, Aug 13

Re: [Qemu-devel] [Libguestfs] cross-project patches: Add NBD Fast Zero support

2019-08-27 Thread Eric Blake
On 8/27/19 7:14 AM, Richard W.M. Jones wrote: > > Is the plan to wait until NBD_CMF_FLAG_FAST_ZERO gets into the NBD > protocol doc before doing the rest? Also I would like to release both > libnbd 1.0 and nbdkit 1.14 before we introduce any large new features. > Both should be released this wee

Re: [Qemu-devel] [PATCH v6 06/10] log: adding -d tb_stats to control tbstats

2019-08-27 Thread Alex Bennée
vandersonmr writes: > Adding -d tb_stats to control TBStatistics collection: > > -d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=]] > > "dump_limit" is used to limit the number of dumped TBStats in > linux-user mode. > > [all+jit+exec+time] control the profilling level used > by the TBSt

[Qemu-devel] [PULL 2/4] xen: cleanup IOREQ server on exit

2019-08-27 Thread Anthony PERARD
From: Igor Druzhinin Device model is supposed to destroy IOREQ server for itself. Signed-off-by: Igor Druzhinin Acked-by: Paul Durrant Message-Id: <1564428563-1006-1-git-send-email-igor.druzhi...@citrix.com> Signed-off-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 2 ++ 1 file changed, 2 in

[Qemu-devel] [PULL 1/4] xen: Fix ring.h header

2019-08-27 Thread Anthony PERARD
The xen_[rw]?mb() macros defined in ring.h can't be used and the fact that there are gated behind __XEN_INTERFACE_VERSION__ means that it needs to be defined somewhere. QEMU doesn't implement interfaces with the Xen hypervisor so defining __XEN_INTERFACE_VERSION__ is pointless. This leads to: i

[Qemu-devel] [PULL 4/4] xen-bus: Avoid rewriting identical values to xenstore

2019-08-27 Thread Anthony PERARD
When QEMU receives a xenstore watch event suggesting that the "state" of the frontend changed, it records this in its own state but it also re-write the value back into xenstore even so there were no change. This triggers an unnecessary xenstore watch event which QEMU will process again (and maybe

[Qemu-devel] [PULL 3/4] xen-bus: Fix backend state transition on device reset

2019-08-27 Thread Anthony PERARD
When a frontend wants to reset its state and the backend one, it starts with setting "Closing", then waits for the backend (QEMU) to do the same. But when QEMU is setting "Closing" to its state, it triggers an event (xenstore watch) that re-execute xen_device_backend_changed() and set the backend

[Qemu-devel] [PULL 0/4] xen queue 2019-08-27

2019-08-27 Thread Anthony PERARD
.git tags/pull-xen-20190827 for you to fetch changes up to 705be570941b38cd1cbebc68f7f671ce7532ecb0: xen-bus: Avoid rewriting identical values to xenstore (2019-08-27 14:18:28 +0100) Xen queue * Fixes for xen-bus and exit cleanu

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

2019-08-27 Thread Marc-André Lureau
Hi On Tue, Aug 27, 2019 at 4:02 PM Peter Maydell wrote: > > On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini wrote: > > > > On 23/08/19 14:07, Peter Maydell wrote: > > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is > > >> not built as module" to qemu.git directly? > > > Is

[Qemu-devel] [Bug 1841592] [NEW] ppc: softfloat float implementation issues

2019-08-27 Thread Paul Clarke
Public bug reported: Per bug #1841491, Richard Henderson (rth) said: > The float test failure is part of a larger problem for target/powerpc > in which all float routines are implemented incorrectly. They are all > implemented as double operations with rounding to float as a second > step. Which n

[Qemu-devel] [Bug 1841592] Re: ppc: softfloat float implementation issues

2019-08-27 Thread Paul Clarke
-- ppc64le native: $ gcc -c -O2 ffma.c $ gcc -O2 test-ffma.c ffma.o -lm -o test-ffma $ ./test-ffma $(./test-ffma) ffma(0x1p-149, 0x1p-149, 0x1p-149) 0x0 0xa00 FE_INEXACT FE_UNDERFLOW 0x1p-149 -- qemu-system-ppc64: $ ./test-ffma $(./test-ffma) ffma(0x1p-149, 0x1p-149, 0x1p-149) 0x0 0x200

  1   2   3   >