Re: [Qemu-devel] [PULL 2/3] tests: Run the iotests during "make check" again

On 8/23/19 12:34 AM, Paolo Bonzini wrote: > On 17/08/19 10:54, Thomas Huth wrote: >> People often forget to run the iotests before submitting patches or pull >> requests - this is likely due to the fact that we do not run the tests >> during our mandatory "make check" tests yet. Now that we've got

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On Thu, Aug 22, 2019 at 9:42 PM Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini Reviewed-by: Marc-André Lureau > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 10064

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini wrote: > > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini I would rather build the module: -common-obj-$(call land,$(CONFIG_SPICE),$(CONFIG_GIO)) += sp

Re: [Qemu-devel] [PATCH 16/16] nvme: support multiple namespaces

On Thu, Aug 22, 2019 at 02:18:05PM +0100, Ross Lagerwall wrote: > On 7/5/19 8:23 AM, Klaus Birkelund Jensen wrote: > > I tried this patch series by installing Windows with a single NVME > controller having two namespaces. QEMU crashed in get_feature / > NVME_VOLATILE_WRITE_CACHE because req->ns wa

Re: [Qemu-devel] [PATCH 0/2] block/file-posix: Fix xfs_write_zeroes()

On 22/8/2019 7:26 PM, Max Reitz wrote: > Lukàš ran over a nasty regression in our xfs_write_zeroes() function > (sorry, my fault) made apparent by a recent patch from Anton that makes > qcow2 images heavily exercise the offending code path. > > This series fixes the bug and adds a test to prevent

Re: [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct

Hi, 19.08.2019, 20:11, "Paolo Bonzini" : > On 19/08/19 18:39, Paolo Bonzini wrote: >>  On 15/08/19 11:13, Yury Kotov wrote: >>>  Ping ping >> >>  Hi, >> >>  sorry for the delay, I was waiting for the 4.1 release. >> >>  I would like to make a small change so that preemption of QEMU does not >>  re

[Qemu-devel] [PATCH] tests/check-block: Skip iotests when sanitizers are enabled

The sanitizers (especially the address sanitizer from Clang) are sometimes printing out warnings or false positives - this spoils the output of the iotests, causing some of the tests to fail. Thus let's skip the automatic iotests during "make check" when the user configured QEMU with --enable-sanit

Re: [Qemu-devel] [PULL 2/3] tests: Run the iotests during "make check" again

On 8/23/19 9:12 AM, Thomas Huth wrote: > On 8/23/19 12:34 AM, Paolo Bonzini wrote: >> On 17/08/19 10:54, Thomas Huth wrote: >>> People often forget to run the iotests before submitting patches or pull >>> requests - this is likely due to the fact that we do not run the tests >>> during our mandator

Re: [Qemu-devel] [PATCH] tests/check-block: Skip iotests when sanitizers are enabled

On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote: > > The sanitizers (especially the address sanitizer from Clang) are > sometimes printing out warnings or false positives - this spoils > the output of the iotests, causing some of the tests to fail. > Thus let's skip the automatic iotests during "m

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On 8/22/19 7:42 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > --- a/tests/modules-test.c > +++ b/tests/mod

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On Fri, 23 Aug 2019 at 10:06, Thomas Huth wrote: > > On 8/22/19 7:42 PM, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > --- > > tests/modules-test.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/modules-test.c b/tests/modules-test.c > > index 3ae

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > To get rid of implicit filters related workarounds in future let's > deprecate them now. Interesting, could we deprecate implicit filter without deprecation of unnecessity of parameter? As actually, it's good when this parameter is not neces

Re: [Qemu-devel] [RFC PATCH qemu] qapi: Add query-memory-checksum

On Fri, Aug 23, 2019 at 07:49:31AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Aug 22, 2019 at 04:16:53PM +0200, Markus Armbruster wrote: > >> Alexey Kardashevskiy writes: > >> > >> > This returns MD5 checksum of all RAM blocks for migration debugging > >> > as th

[Qemu-devel] [PATCH 1/2] virtiofsd: replace warn(3) and warnx(3) with fuse_warning()

Do not use warn(3) and warnx(3) since they print to stderr. When --syslog is used these messages must go to syslog(3) instead. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/passthrough_ll.c | 36 +++--- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] virtiofsd: replace err(3) and errx(3) with fuse_err()

Do not use err(3) and errx(3) since they print to stderr. When --syslog is used these messages must go to syslog(3) instead. Signed-off-by: Stefan Hajnoczi --- contrib/virtiofsd/passthrough_ll.c | 107 +++-- contrib/virtiofsd/seccomp.c| 15 ++-- 2 files changed,

[Qemu-devel] [PATCH 0/2] virtiofsd: use "fuse_log.h" APIs instead of

warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog option was given. In this case messages to stderr are likely to be lost and this makes troubleshooting hard. Use "fuse_log.h" APIs instead of . Stefan Hajnoczi (2): virtiofsd: replace warn(3) and warnx(3) with fuse_w

Re: [Qemu-devel] [PATCH v7 04/13] vfio: Add save and load functions for VFIO PCI devices

* Tian, Kevin (kevin.t...@intel.com) wrote: > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > Sent: Friday, August 23, 2019 3:13 AM > > > > * Kirti Wankhede (kwankh...@nvidia.com) wrote: > > > > > > > > > On 8/22/2019 3:02 PM, Dr. David Alan Gilbert wrote: > > > > * Kirti Wankhede

Re: [Qemu-devel] [PATCH 1/2] virtio: add vhost-user-fs base device

On Thu, Aug 22, 2019 at 11:19:16AM +0200, Cornelia Huck wrote: > On Thu, 22 Aug 2019 09:52:37 +0100 > Stefan Hajnoczi wrote: > > > On Wed, Aug 21, 2019 at 08:11:18PM +0100, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Fri, Aug 16, 2019 at 03:33:20

Re: [Qemu-devel] [PATCH] contrib/gitdm: Add RT-RK to the domain-map

23.08.2019. 01.16, "Philippe Mathieu-Daudé" је написао/ла: > > This company has at least 7 contributors, add a domain-map entry. > > Signed-off-by: Philippe Mathieu-Daudé > --- > contrib/gitdm/domain-map | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/gitdm/domain-map b/contrib/

Re: [Qemu-devel] [PATCH 2/3] mailmap: Update philmd email address

23.08.2019. 01.10, "Philippe Mathieu-Daudé" је написао/ла: > > Use the email address where I spend most of my time. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Aleksandar Markovic > .mailmap | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [Qemu-devel] [PATCH] tests/check-block: Skip iotests when sanitizers are enabled

On 8/23/19 11:04 AM, Peter Maydell wrote: > On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote: >> >> The sanitizers (especially the address sanitizer from Clang) are >> sometimes printing out warnings or false positives - this spoils >> the output of the iotests, causing some of the tests to fail. >

Re: [Qemu-devel] [PULL 0/3] crypto: autofree patches

On Thu, 22 Aug 2019 at 11:54, Daniel P. Berrangé wrote: > > The following changes since commit fe066b4848bab4f9365a419f3c8ba59ccecf67c0: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-08-21 > 16:59:22 +0100) > > are available in the Git

Re: [Qemu-devel] [PATCH 1/3] mailmap: Reorder by sections

23.08.2019. 01.13, "Philippe Mathieu-Daudé" је написао/ла: > > Our mailmap currently has 4 sections somehow documented. > Reorder few entries not related to "addresses from the original > git import" into the 3rd section, and add a comment to describe > it. > > Signed-off-by: Philippe Mathieu-Daud

Re: [Qemu-devel] [PATCH 3/3] mailmap: Add many entries to improve 'git shortlog' statistics

23.08.2019. 01.10, "Philippe Mathieu-Daudé" је написао/ла: > > All of these emails have a least 1 commit with utf8/latin1 encoding > issue, or one with no author name. > When there are multiple commits, keep the author name the most used. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-

Re: [Qemu-devel] [PATCH v7 04/13] vfio: Add save and load functions for VFIO PCI devices

> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Friday, August 23, 2019 5:27 PM > > * Tian, Kevin (kevin.t...@intel.com) wrote: > > > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > > > Sent: Friday, August 23, 2019 3:13 AM > > > > > > * Kirti Wankhede (kwankh...@nv

Re: [Qemu-devel] [PATCH] tests/check-block: Skip iotests when sanitizers are enabled

On Fri, 23 Aug 2019 at 10:35, Thomas Huth wrote: > > On 8/23/19 11:04 AM, Peter Maydell wrote: > > On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote: > >> > >> The sanitizers (especially the address sanitizer from Clang) are > >> sometimes printing out warnings or false positives - this spoils > >>

Re: [Qemu-devel] [PATCH 0/2] Adding some setsockopt() options

23.08.2019. 01.15, "Shu-Chun Weng via Qemu-devel" је написао/ла: > > Shu-Chun Weng (2): > linux-user: add missing UDP and IPv6 setsockopt options > linux-user: time stamping options for setsockopt() > > linux-user/generic/sockbits.h | 4 > linux-user/mips/sockbits.h| 4 > linu

[Qemu-devel] [PATCH v1 0/9] tcg: probe_write() refactorings and watchpoints

Fix and refactore some things around probe_write() in s390x code. Introduce probe_write() for CONFIG_USER_ONLY. Finally, prepare the watchpoint logic for being called from probe_write() and add the call. This is the first step of some changes necessary to handle fault-safe access accross multiple

[Qemu-devel] [PATCH v1 1/9] s390x/tcg: Use guest_addr_valid() instead of h2g_valid() in probe_write_access()

If I'm not completely wrong, we are dealing with guest addresses here and not with host addresses. Use the right check. Fixes: c5a7392cfb96 ("s390x/tcg: Provide probe_write_access helper") Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[Qemu-devel] [PATCH v1 4/9] tcg: Enforce single page access in probe_write() for !CONFIG_USER_ONLY

While the CONFIG_USER_ONLY variant can handle multiple pages (no MMU), the !CONFIG_USER_ONLY variant can't and won't. We'll want to convert probe_write() to return a host address (similar to tlb_vaddr_to_host()) soon. This only works on page granularity. Signed-off-by: David Hildenbrand --- acce

[Qemu-devel] [PATCH v1 3/9] tcg: Factor out CONFIG_USER_ONLY probe_write() from s390x code

Factor it out, we'll do some further changes/extensions to both probe_write() implementations soon. Make sure to allow "size = 0". Signed-off-by: David Hildenbrand --- accel/tcg/user-exec.c | 16 include/exec/exec-all.h | 4 ++-- target/s390x/mem_helper.c | 7 --- 3

[Qemu-devel] [PATCH v1 5/9] mips/tcg: Call probe_write() for CONFIG_USER_ONLY as well

Let's call it also for CONFIG_USER_ONLY. While at it, add a FIXME and get rid of one local variable. MIPS code probably needs a bigger refactoring in regards of ensure_writable_pages(), similar to s390x, so for example, watchpoints can be handled reliably later. The actually accessed addresses sho

[Qemu-devel] [PATCH v1 2/9] s390x/tcg: Fix length calculation in probe_write_access()

Hm,, how did that "-" slip in (-TAGRET_PAGE_SIZE would be correct). This currently makes us exceed one page in a single probe_write() call, essentially leaving some memory unchecked. Fixes: c5a7392cfb96 ("s390x/tcg: Provide probe_write_access helper") Signed-off-by: David Hildenbrand --- target/

[Qemu-devel] [PATCH v1 9/9] tcg: Check for watchpoints in probe_write()

Let's check for write watchpoints. We'll want to do something similar for probe_read() in the future (once we introduce that). Suggested-by: Richard Henderson Signed-off-by: David Hildenbrand --- accel/tcg/cputlb.c | 16 1 file changed, 16 insertions(+) diff --git a/accel/tcg/

[Qemu-devel] [PATCH v1 6/9] hppa/tcg: Call probe_write() also for CONFIG_USER_ONLY

We now have a variant for CONFIG_USER_ONLY as well. Signed-off-by: David Hildenbrand --- target/hppa/op_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index df0f1361ef..f0516e81f1 100644 --- a/target/hppa/op_helper.c +++ b/target/h

[Qemu-devel] [PATCH v1 7/9] s390x/tcg: Pass a size to probe_write() in do_csst()

... and also call it for CONFIG_USER_ONLY. This function probably will also need some refactoring in regards to probing, however, we'll have to come back to that later, once cleaning up the other mem helpers. The alignment check always makes sure that the write access falls into a single page. Si

Re: [Qemu-devel] [PATCH] tests/check-block: Skip iotests when sanitizers are enabled

On 8/23/19 11:53 AM, Peter Maydell wrote: > On Fri, 23 Aug 2019 at 10:35, Thomas Huth wrote: >> >> On 8/23/19 11:04 AM, Peter Maydell wrote: >>> On Fri, 23 Aug 2019 at 09:43, Thomas Huth wrote: The sanitizers (especially the address sanitizer from Clang) are sometimes printing out

[Qemu-devel] [PATCH v2 0/2] Fix for the xen-bus driver

Cheers, Anthony PERARD (2): xen-bus: Fix backend state transition on device reset xen-bus: Avoid rewriting identical values to xenstore hw/xen/xen-bus.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) -- Anthony PERARD

[Qemu-devel] [PATCH v2 2/2] xen-bus: Avoid rewriting identical values to xenstore

When QEMU receives a xenstore watch event suggesting that the "state" of the frontend changed, it records this in its own state but it also re-write the value back into xenstore even so there were no change. This triggers an unnecessary xenstore watch event which QEMU will process again (and maybe

[Qemu-devel] [PATCH v1 8/9] exec.c: Factor out core logic of check_watchpoint()

We want to perform the same checks in probe_write() to trigger a cpu exit before doing any modifications. We'll have to pass a PC. Signed-off-by: David Hildenbrand --- exec.c| 23 +-- include/hw/core/cpu.h | 2 ++ 2 files changed, 19 insertions(+), 6 deletion

[Qemu-devel] [PATCH v2 1/2] xen-bus: Fix backend state transition on device reset

When a frontend wants to reset its state and the backend one, it starts with setting "Closing", then waits for the backend (QEMU) to do the same. But when QEMU is setting "Closing" to its state, it triggers an event (xenstore watch) that re-execute xen_device_backend_changed() and set the backend

Re: [Qemu-devel] [PATCH] migration: register_savevm_live doesn't need dev

On Thu, Aug 22, 2019 at 12:54:33PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Commit 78dd48df3 removed the last caller of register_savevm_live for an > instantiable device (rather than a single system wide device); > so trim out the parameter. > > Signed-off-

Re: [Qemu-devel] [PATCH 1/2] migration/qemu-file: remove check on writev_buffer in qemu_put_compression_data

* Wei Yang (richardw.y...@linux.intel.com) wrote: > The check of writev_buffer is in qemu_fflush, which means it is not > harmful if it is NULL. > > And removing it will make the code consistent since all other > add_to_iovec() is called without the check. > > Signed-off-by: Wei Yang So I think

[Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment

From: "Dr. David Alan Gilbert" Commit 11808bb removed the non-iovec based write support, the comment hung on. Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c i

Re: [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment

On Fri, Aug 23, 2019 at 11:39:46AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Commit 11808bb removed the non-iovec based write support, > the comment hung on. > > Signed-off-by: Dr. David Alan Gilbert > --- > migration/qemu-file.c | 5 ++--- > 1 file change

Re: [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment

(Copying Dan in) * Wei Yang (richardw.y...@linux.intel.com) wrote: > In add_to_iovec(), qemu_fflush() will be called if iovec is full. If > this happens, buf_index is reset. Currently, this is not checked and > buf_index would always been adjust with buf size. > > This is not harmful, but will wa

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Thu, Aug 08, 2019 at 07:03:23PM +0400, Marc-André Lureau wrote: > Hi, > > With external processes or helpers participating to the VM support, it > becomes necessary to handle their migration. Various options exist to > transfer their state: > 1) as the VM memory, RAM or devices (we could say th

Re: [Qemu-devel] [PATCH v1 8/9] exec.c: Factor out core logic of check_watchpoint()

On 23.08.19 12:07, David Hildenbrand wrote: > We want to perform the same checks in probe_write() to trigger a cpu > exit before doing any modifications. We'll have to pass a PC. > > Signed-off-by: David Hildenbrand > --- > exec.c| 23 +-- > include/hw/core/cp

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

Hi On Fri, Aug 23, 2019 at 3:21 PM Daniel P. Berrangé wrote: > > On Thu, Aug 08, 2019 at 07:03:23PM +0400, Marc-André Lureau wrote: > > Hi, > > > > With external processes or helpers participating to the VM support, it > > becomes necessary to handle their migration. Various options exist to > >

Re: [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment

On Fri, Aug 23, 2019 at 12:06:09PM +0100, Dr. David Alan Gilbert wrote: > (Copying Dan in) > > * Wei Yang (richardw.y...@linux.intel.com) wrote: > > In add_to_iovec(), qemu_fflush() will be called if iovec is full. If > > this happens, buf_index is reset. Currently, this is not checked and > > buf

Re: [Qemu-devel] [RFC PATCH qemu] qapi: Add query-memory-checksum

Daniel P. Berrangé writes: > On Fri, Aug 23, 2019 at 07:49:31AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Aug 22, 2019 at 04:16:53PM +0200, Markus Armbruster wrote: >> >> Alexey Kardashevskiy writes: >> >> >> >> > This returns MD5 checksum of all RAM blocks

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

On Fri, Aug 23, 2019 at 03:31:16PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Aug 23, 2019 at 3:21 PM Daniel P. Berrangé > wrote: > > > > On Thu, Aug 08, 2019 at 07:03:23PM +0400, Marc-André Lureau wrote: > > > Hi, > > > > > > With external processes or helpers participating to the VM supp

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

Hi On Fri, Aug 23, 2019 at 3:42 PM Daniel P. Berrangé wrote: > > On Fri, Aug 23, 2019 at 03:31:16PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Fri, Aug 23, 2019 at 3:21 PM Daniel P. Berrangé > > wrote: > > > > > > On Thu, Aug 08, 2019 at 07:03:23PM +0400, Marc-André Lureau wrote: > > > >

Re: [Qemu-devel] [PATCH v2 15/68] target/arm: Convert BX, BXJ, BLX (register)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 78 -- > target/arm/a32.decode | 7 > target/arm/t32.decode | 2 ++ > 3 files changed, 47 insertions(+), 40 deletions(-)

Re: [Qemu-devel] [PATCH v2 16/68] target/arm: Convert CLZ

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Document our choice about the T32 CONSTRAINED UNPREDICTABLE behaviour. > This matches the undocumented choice made by the legacy decoder. > > Signed-off-by: Richard Henderson > diff --git a/target/arm/a32.decode b/target/arm/a32.decode >

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On 23/08/19 11:11, Peter Maydell wrote: > On Fri, 23 Aug 2019 at 10:06, Thomas Huth wrote: >> >> On 8/22/19 7:42 PM, Paolo Bonzini wrote: >>> Signed-off-by: Paolo Bonzini >>> --- >>> tests/modules-test.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tests/modules

Re: [Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: In subject, typo: "Miscellaneous". > This fixes an exiting bug with the T5 encoding of SUBS PC, LR, #IMM, "existing" > in that it may be executed from user mode as with any other encoding > of SUBS, not as ERET. Should this paragraph be i

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

On 23/08/19 09:32, Marc-André Lureau wrote: > On Thu, Aug 22, 2019 at 9:43 PM Paolo Bonzini wrote: >> >> $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so >> ui-spice-app is always linked into QEMU. >> >> Signed-off-by: Paolo Bonzini > > I would rather build the module: > -co

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On Fri, 23 Aug 2019 at 13:04, Paolo Bonzini wrote: > > On 23/08/19 11:11, Peter Maydell wrote: > > On Fri, 23 Aug 2019 at 10:06, Thomas Huth wrote: > >> > >> On 8/22/19 7:42 PM, Paolo Bonzini wrote: > >>> Signed-off-by: Paolo Bonzini > >>> --- > >>> tests/modules-test.c | 2 +- > >>> 1 file cha

Re: [Qemu-devel] [PATCH] block: workaround for unaligned byte range in fallocate()

On 23/08/2019 00:09, Eric Blake wrote: > On 8/22/19 1:31 PM, Andrey Shinkevich wrote: >> Revert the commit 118f99442d 'block/io.c: fix for the allocation failure' >> and make better error handling for the file systems that do not support > > s/make/use/ > >> fallocate() for the unaligned byte r

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On 23/08/19 14:07, Peter Maydell wrote: >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is >> not built as module" to qemu.git directly? > Is the other one also needed as a build fix ? Yes, otherwise the test fails (it didn't fail in the meson tree). > I was planning to app

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On 8/23/19 2:10 PM, Paolo Bonzini wrote: > On 23/08/19 14:07, Peter Maydell wrote: >>> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is >>> not built as module" to qemu.git directly? >> Is the other one also needed as a build fix ? > > Yes, otherwise the test fails (it didn't

Re: [Qemu-devel] [PATCH v2 02/68] target/arm: Add stubs for aa32 decodetree

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Add the infrastructure that will become the new decoder. > No instructions adjusted so far. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2 04/68] target/arm: Convert Data Processing (reg-shifted-reg)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Convert the register shifted by register form of the data > processing insns. For A32, we cannot yet remove any code > because the legacy decoder intertwines the immediate form. > > Signed-off-by: Richard Henderson > --- > target/arm/tr

Re: [Qemu-devel] [PATCH v2 05/68] target/arm: Convert Data Processing (immediate)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Convert the modified immediate form of the data processing insns. > For A32, we can finally remove any code that was intertwined with > the register and register-shifted-register forms. > > Signed-off-by: Richard Henderson > --- > target

Re: [Qemu-devel] [PATCH v2 06/68] target/arm: Convert multiply and multiply accumulate

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 248 +++-- > target/arm/a32.decode | 17 +++ > target/arm/t32.decode | 19 > 3 files changed, 177 insertions(+), 107 deletions

Re: [Qemu-devel] [PATCH v2 09/68] target/arm: Convert Halfword multiply and multiply accumulate

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 218 +++-- > target/arm/a32.decode | 20 > target/arm/t32.decode | 29 ++ > 3 files changed, 170 insertions(+), 97 deletio

Re: [Qemu-devel] [PATCH v2 07/68] target/arm: Simplify UMAAL

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Since all of the inputs and outputs are i32, dispense with > the intermediate promotion to i64 and use tcg_gen_mulu2_i32 > and tcg_gen_add2_i32. > > Signed-off-by: Richard Henderson 8 > --- > target/arm/translate.c | 34 --

Re: [Qemu-devel] [PATCH v2 10/68] target/arm: Simplify op_smlaxxx for SMLAL*

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Since all of the inputs and outputs are i32, dispense with > the intermediate promotion to i64 and use tcg_gen_add2_i32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 15 --- > 1 file changed, 8 insert

Re: [Qemu-devel] [PATCH v2 12/68] target/arm: Convert MSR (immediate) and hints

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 60 +- > target/arm/a32.decode | 25 ++ > target/arm/t32.decode | 17 > 3 files changed, 84 insertio

Re: [Qemu-devel] [PATCH v9 00/20] Invert Endian bit in SPARCv9 MMU TTE

On 8/22/19 12:29 PM, Richard Henderson wrote: > So... after an hour only the cover letter has arrived. > I'm thinking that it didn't work. Frustratingly, I keep getting blocked. Perhaps new GMail and Mail.com accounts sending in bulk on behalf of bt.com falls foul of spam filters. *sigh* I am m

Re: [Qemu-devel] [PATCH v3 3/6] tests/docker: add podman support

One more: does docs/devel/testing.rst need an update?

Re: [Qemu-devel] [PATCH v2 11/68] target/arm: Simplify op_smlawx for SMLAW*

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > By shifting the 16-bit input left by 16, we can align the desired > portion of the 48-bit product and use tcg_gen_muls2_i32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 16 > 1 file changed, 8 i

Re: [Qemu-devel] [PATCH v2 13/68] target/arm: Convert MRS/MSR (banked, register)

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > The m-profile and a-profile, decodings overlap. Only return false > for the case of wrong profile; handle UNDEFINED for permission failure > directly. This ensures that we don't accidentally pass an insn that > applies to the wrong profi

Re: [Qemu-devel] [PATCH v2 14/68] target/arm: Convert Cyclic Redundancy Check

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 121 +++-- > target/arm/a32.decode | 9 +++ > target/arm/t32.decode | 7 +++ > 3 files changed, 72 insertions(+), 65 deletions(-)

Re: [Qemu-devel] [PATCH v2 17/68] target/arm: Convert ERET

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Pass the T5 encoding of SUBS PC, LR, #IMM through the normal SUBS path > to make it clear exactly what's happening -- we hit ALUExceptionReturn > along that path. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks

Re: [Qemu-devel] [PATCH v3 3/6] tests/docker: add podman support

Just saw this land in master, awesome. Suggestion inline. Marc-André Lureau writes: > Allow to specify the container engine to run with ENGINE variable. > > By default, ENGINE=auto and will select either podman or docker. > > Signed-off-by: Marc-André Lureau > --- > Makefile

Re: [Qemu-devel] [PATCH 0/2] virtiofsd: use "fuse_log.h" APIs instead of

On 8/23/19 11:23 AM, Stefan Hajnoczi wrote: > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog > option was given. In this case messages to stderr are likely to be lost and > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of . > > Stefan Hajnoczi (2):

Re: [Qemu-devel] [PATCH 3/3] mailmap: Add many entries to improve 'git shortlog' statistics

On 8/23/19 11:44 AM, Aleksandar Markovic wrote: > 23.08.2019. 01.10, "Philippe Mathieu-Daudé" > је написао/ла: >> >> All of these emails have a least 1 commit with utf8/latin1 encoding >> issue, or one with no author name. >> When there are multiple commits, keep the auth

Re: [Qemu-devel] [PATCH] modules-test: ui-spice-app is not built as module

On Thu, Aug 22, 2019 at 07:42:14PM +0200, Paolo Bonzini wrote: > $(call land, $(CONFIG_SPICE), $(CONFIG_GIO)) will never return "m" so > ui-spice-app is always linked into QEMU. > > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH] modules-test: fix const cast

On Thu, Aug 22, 2019 at 07:42:13PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/modules-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/modules-test.c b/tests/modules-test.c > index 3aef0e5..a8118e9 100644 > --- a/tests/modules-te

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

* Daniel P. Berrangé (berra...@redhat.com) wrote: > This means QEMU still has to iterate over every single client > on the bus to identify them. If you're doing that, there's > no point in owning a well known service at all. Just iterate > over the unique bus names and look for the exported obje

[Qemu-devel] [PATCH 2/2] iotests: Test reverse sub-cluster qcow2 writes

This exercises the regression introduced in commit 50ba5b2d994853b38fed10e0841b119da0f8b8e5. On my machine, it has close to a 50 % false-negative rate, but that should still be sufficient to test the fix. Signed-off-by: Max Reitz --- tests/qemu-iotests/265 | 67 +

Re: [Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

On Mon, 19 Aug 2019 at 22:38, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 24 +--- > target/arm/a32.decode | 1 + > target/arm/t32.decode | 19 +++ > 3 files changed, 33 insertions(+), 11 deletions(-) > > d

[Qemu-devel] [PATCH 1/2] block/file-posix: Reduce xfsctl() use

This patch removes xfs_write_zeroes() and xfs_discard(). Both functions have been added just before the same feature was present through fallocate(): - fallocate() has supported PUNCH_HOLE for XFS since Linux 2.6.38 (March 2011); xfs_discard() was added in December 2010. - fallocate() has supp

[Qemu-devel] [PATCH 0/2] block/file-posix: Reduce xfsctl() use

Hi, As suggested by Paolo, this series drops xfsctl() calls where we have working fallocate() alternatives. (And thus replaces “block/file-posix: Fix xfs_write_zeroes()”.) Unfortunately, we also use xfsctl() to inquire the request alignment for O_DIRECT, and this is the only way we currently hav

Re: [Qemu-devel] [PATCH 2/2] migration/qemu-file: fix potential buf waste for extra buf_index adjustment

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Fri, Aug 23, 2019 at 12:06:09PM +0100, Dr. David Alan Gilbert wrote: > > (Copying Dan in) > > > > * Wei Yang (richardw.y...@linux.intel.com) wrote: > > > In add_to_iovec(), qemu_fflush() will be called if iovec is full. If > > > this happens,

Re: [Qemu-devel] more automated/public CI for QEMU pullreqs

On 8/22/19 7:05 PM, Paolo Bonzini wrote: > On 22/08/19 18:50, Dr. David Alan Gilbert wrote: >> * Paolo Bonzini (pbonz...@redhat.com) wrote: >>> On 22/08/19 18:31, Dr. David Alan Gilbert wrote: > With both these points in mind, I think it is pretty hard sell to > say we should write & maint

[Qemu-devel] [PATCH v2] iotests: Check for enabled drivers before testing them

It is possible to enable only a subset of the block drivers with the "--block-drv-rw-whitelist" option of the "configure" script. All other drivers are marked as unusable (or only included as read-only with the "--block-drv-ro-whitelist" option). If an iotest is now using such a disabled block driv

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

On Thu, Aug 22, 2019 at 06:54:20PM -0300, Eduardo Habkost wrote: > On Thu, Aug 22, 2019 at 05:19:26PM -0400, Cleber Rosa wrote: > > On Thu, Aug 22, 2019 at 05:48:46PM +0100, Peter Maydell wrote: > > > On Fri, 9 Nov 2018 at 15:09, Cleber Rosa wrote: > > > > > > > > Some functionality is dependent o

Re: [Qemu-devel] [PATCH 1/4] configure: keep track of Python version

On Fri, 23 Aug 2019 at 14:41, Cleber Rosa wrote: > I see it being used by humans, so that brings a lot of subjetivity > into the matter. IMO this is not out of place within the build > system, given that a lot of requirements detected by configure will > print out their versions (GTK, nettle, spi

Re: [Qemu-devel] [Qemu-ppc] [PULL 1/2] spapr: Reset CAS & IRQ subsystem after devices

On 23/08/2019 07:39, David Gibson wrote: > On Thu, Aug 22, 2019 at 10:07:09PM +0200, Laurent Vivier wrote: >> On 13/08/2019 08:59, David Gibson wrote: >>> This fixes a nasty regression in qemu-4.1 for the 'pseries' machine, >>> caused by the new "dual" interrupt controller model. Specifically, >>>

Re: [Qemu-devel] [PATCH v2 0/2] Add dbus-vmstate

Hi On Fri, Aug 23, 2019 at 5:00 PM Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > > This means QEMU still has to iterate over every single client > > on the bus to identify them. If you're doing that, there's > > no point in owning a well known servic

[Qemu-devel] [PATCH] hostmem-file: fix pmem file size check

Commit 314aec4a6e06844937f1677f6cba21981005f389 ("hostmem-file: reject invalid pmem file sizes") added a file size check that verifies the hostmem object's size parameter against the actual devdax pmem file. This is useful because getting the size wrong results in confusing errors inside the guest.

[Qemu-devel] [PATCH 0/4] Support disabling TCG on ARM (part 2)

Cover from Samuel Ortiz from (part 1) [1]: This patchset allows for building and running ARM targets with TCG disabled. [...] The rationale behind this work comes from the NEMU project where we're trying to only support x86 and ARM 64-bit architectures, without including the TCG code ba

[Qemu-devel] [PATCH 3/4] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM

A KVM-only build won't be able to run pre-ARMv7 cpus, disable them. If KVM is not enabled, they are enabled by default. Signed-off-by: Philippe Mathieu-Daudé --- Sadly this does not work with --enable-tcg --enable-kvm dual config. --- default-configs/arm-softmmu.mak | 33 ---

Re: [Qemu-devel] [PATCH] block: posix: Always allocate the first block

On 22.08.19 21:01, Nir Soffer wrote: > On Thu, Aug 22, 2019 at 9:11 PM Max Reitz > wrote: > > On 22.08.19 18:39, Nir Soffer wrote: > > On Thu, Aug 22, 2019 at 5:28 PM Max Reitz > >

[Qemu-devel] [PATCH 4/4] RFC target/arm: Do not build A/M-profile cpus when using KVM

A KVM-only build won't be able to run A or M-profile cpus, disable them. If KVM is not enabled, they are enabled by default. Signed-off-by: Philippe Mathieu-Daudé --- Sadly this does not work with --enable-tcg --enable-kvm dual config. --- default-configs/arm-softmmu.mak | 14 ++ hw

[Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG

KVM requires at least a ARMv7 cpu. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 12 1 file changed, 12 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 2399c14471..522485a2de 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1678,6 +1678,8

[Qemu-devel] [PATCH 2/4] target/arm: Restrict R and M profiles to TCG

KVM is only able to run A profile cpus. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 522485a2de..299c59fde4 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c

  1   2   3   4   >