On Thu, Aug 22, 2019 at 02:18:05PM +0100, Ross Lagerwall wrote: > On 7/5/19 8:23 AM, Klaus Birkelund Jensen wrote: > > I tried this patch series by installing Windows with a single NVME > controller having two namespaces. QEMU crashed in get_feature / > NVME_VOLATILE_WRITE_CACHE because req->ns was NULL. >
Hi Ross, Good catch! > nvme_get_feature / nvme_set_feature look wrong to me since I can't see how > req->ns would have been set. Should they have similar code to nvme_io_cmd to > set req->ns from cmd->nsid? Definitely. I will fix that for v2. > > After working around this issue everything else seemed to be working well. > Thanks for your work on this patch series. > And thank you for trying out my patches! Cheers, Klaus
