Re: [Qemu-devel] [for-4.2 PATCH 0/6] Block-related record/replay fixes

2019-07-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SC

Re: [Qemu-devel] [PATCH 2/3] memory-device: break the loop if no hint is provided

2019-07-29 Thread Igor Mammedov
On Sun, 28 Jul 2019 21:13:03 +0800 Wei Yang wrote: > When there is no hint, the first un-overlapped range is the proper one. > Just break the loop instead of iterate the whole list. could it change default pc-dimm mapping (will address assignment stay the same as before this change)? In commit m

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Markus Armbruster
Peter Maydell writes: > On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini wrote: >> >> On 27/07/19 09:16, Markus Armbruster wrote: >> > We started with a single trace-events. That wasn't good, so we split it >> > up into one per directory. That isn't good, so what about splitting it >> > up into one

Re: [Qemu-devel] [PATCH 1/3] memory-device: not necessary to use goto for the last check

2019-07-29 Thread David Hildenbrand
On 28.07.19 15:13, Wei Yang wrote: > We are already at the last condition check. > > Signed-off-by: Wei Yang > --- > hw/mem/memory-device.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c > index 5f2c408036..df3261b32a 100644 > --- a/hw/me

Re: [Qemu-devel] [PATCH v2 09/17] ppc/xive: Extend XiveTCTX with a XiveRouter pointer

2019-07-29 Thread Cédric Le Goater
On 29/07/2019 08:11, David Gibson wrote: > On Sun, Jul 28, 2019 at 11:06:27AM +0200, Cédric Le Goater wrote: >> On 28/07/2019 09:46, David Gibson wrote: >>> On Thu, Jul 18, 2019 at 01:54:12PM +0200, Cédric Le Goater wrote: This is to perform lookups in the NVT table when a vCPU is dispatched >

Re: [Qemu-devel] [PATCH 2/3] memory-device: break the loop if no hint is provided

2019-07-29 Thread David Hildenbrand
On 28.07.19 15:13, Wei Yang wrote: > When there is no hint, the first un-overlapped range is the proper one. > Just break the loop instead of iterate the whole list. > > Signed-off-by: Wei Yang > --- > hw/mem/memory-device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/mem/memo

Re: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range

2019-07-29 Thread David Hildenbrand
On 28.07.19 15:13, Wei Yang wrote: > The memory-device list built by memory_device_build_list is ordered by > its address, this means if the tmp range exceed the hinted range, all > the following range will not overlap with it. > > Signed-off-by: Wei Yang > --- > hw/mem/memory-device.c | 2 +- >

Re: [Qemu-devel] [PATCH 2/3] memory-device: break the loop if no hint is provided

2019-07-29 Thread Wei Yang
On Mon, Jul 29, 2019 at 09:04:01AM +0200, Igor Mammedov wrote: >On Sun, 28 Jul 2019 21:13:03 +0800 >Wei Yang wrote: > >> When there is no hint, the first un-overlapped range is the proper one. >> Just break the loop instead of iterate the whole list. >could it change default pc-dimm mapping (will

Re: [Qemu-devel] [PATCH 2/3] memory-device: break the loop if no hint is provided

2019-07-29 Thread Wei Yang
On Mon, Jul 29, 2019 at 09:45:24AM +0200, David Hildenbrand wrote: >On 28.07.19 15:13, Wei Yang wrote: >> When there is no hint, the first un-overlapped range is the proper one. >> Just break the loop instead of iterate the whole list. >> >> Signed-off-by: Wei Yang >> --- >> hw/mem/memory-device

Re: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range

2019-07-29 Thread David Hildenbrand
On 29.07.19 09:49, David Hildenbrand wrote: > On 28.07.19 15:13, Wei Yang wrote: >> The memory-device list built by memory_device_build_list is ordered by >> its address, this means if the tmp range exceed the hinted range, all >> the following range will not overlap with it. >> >> Signed-off-by: W

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Pino Toscano
On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: > On 7/26/19 9:09 AM, Pino Toscano wrote: > > Add a 'private-key' option which represents the path of a private key > > to use for authentication, and 'private-key-secret' as the name of an > > object with its passphrase. > > > > Signed-off-b

[Qemu-devel] [PATCH v2 2/3] migration: add speed limit for multifd migration

2019-07-29 Thread Ivan Ren
Limit the speed of multifd migration through common speed limitation qemu file. Signed-off-by: Ivan Ren --- migration/ram.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 889148dd84..88ddd2bbe2 100644 --- a/mig

[Qemu-devel] [PATCH v2 0/3] migration: add speed limit for multifd migration

2019-07-29 Thread Ivan Ren
Currently multifd migration has not been limited and it will consume the whole bandwidth of Nic. These two patches add speed limitation to it. This is the v2 patches, differences with v1: 1. change qemu_file_update_rate_transfer interface name to qemu_file_update_transfer 2. add a new patch to

[Qemu-devel] [PATCH v2 1/3] migration: add qemu_file_update_transfer interface

2019-07-29 Thread Ivan Ren
Add qemu_file_update_transfer for just update bytes_xfer for speed limitation. This will be used for further migration feature such as multifd migration. Signed-off-by: Ivan Ren --- migration/qemu-file.c | 5 + migration/qemu-file.h | 1 + 2 files changed, 6 insertions(+) diff --git a/migra

[Qemu-devel] [PATCH v2 3/3] migration: update ram_counters for multifd sync packet

2019-07-29 Thread Ivan Ren
Multifd sync will send MULTIFD_FLAG_SYNC flag info to destination, add these bytes to ram_counters record. Signed-off-by: Ivan Ren --- migration/ram.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 88ddd2bbe2..20b6eebb7c 100644 --- a/migration/ram.c

[Qemu-devel] [Bug 1838228] Re: Slirp Broadcast traffic

2019-07-29 Thread elmarco
slirp has been moved to a standalone project, can you report here: https://gitlab.freedesktop.org/slirp/libslirp/issues I don't have an answer off the top of my head, but I would suggest looking/tweaking at the network mask. And for the receive side, debugging from sorecvfrom(). -- You received

Re: [Qemu-devel] [Virtio-fs] [PATCH 2/5] virtiofsd: prevent lo_lookup() NULL pointer dereference

2019-07-29 Thread Stefan Hajnoczi
On Fri, Jul 26, 2019 at 02:26:14PM -0700, Liu Bo wrote: > On Fri, Jul 26, 2019 at 10:11:00AM +0100, Stefan Hajnoczi wrote: > > Most lo_do_lookup() have already checked that the parent inode exists. > > lo_lookup() hasn't and can therefore hit a NULL pointer dereference when > > lo_inode(req, parent

Re: [Qemu-devel] [BUG] VM abort after migration

2019-07-29 Thread Jason Wang
On 2019/7/27 下午2:10, Longpeng (Mike) wrote: 在 2019/7/10 11:57, Jason Wang 写道: On 2019/7/10 上午11:36, Longpeng (Mike) wrote: 在 2019/7/10 11:25, Jason Wang 写道: On 2019/7/8 下午5:47, Dr. David Alan Gilbert wrote: * longpeng (longpe...@huawei.com) wrote: Hi guys, We found a qemu core in our test

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Daniel P . Berrangé
On Sat, Jul 27, 2019 at 07:20:15PM +0100, Peter Maydell wrote: > On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini wrote: > > > > On 27/07/19 09:16, Markus Armbruster wrote: > > > We started with a single trace-events. That wasn't good, so we split it > > > up into one per directory. That isn't good,

Re: [Qemu-devel] [for-4.2 PATCH 2/2] hw/i386: AMD-Vi IVRS DMA alias support

2019-07-29 Thread Peter Xu
On Fri, Jul 26, 2019 at 06:55:53PM -0600, Alex Williamson wrote: > When we account for DMA aliases in the PCI address space, we can no > longer use a single IVHD entry in the IVRS covering all devices. We > instead need to walk the PCI bus and create alias ranges when we find > a conventional bus.

Re: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range

2019-07-29 Thread Wei Yang
On Mon, Jul 29, 2019 at 09:49:37AM +0200, David Hildenbrand wrote: >On 28.07.19 15:13, Wei Yang wrote: >> The memory-device list built by memory_device_build_list is ordered by >> its address, this means if the tmp range exceed the hinted range, all >> the following range will not overlap with it.

Re: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range

2019-07-29 Thread Igor Mammedov
On Mon, 29 Jul 2019 09:49:37 +0200 David Hildenbrand wrote: > On 28.07.19 15:13, Wei Yang wrote: > > The memory-device list built by memory_device_build_list is ordered by > > its address, this means if the tmp range exceed the hinted range, all > > the following range will not overlap with it. >

Re: [Qemu-devel] [PATCH v8 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-07-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190729063127.2801-1-tao3...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make do

[Qemu-devel] [PULL 1/5] e1000: don't raise interrupt in pre_save()

2019-07-29 Thread Jason Wang
We should not raise any interrupt after VM has been stopped but this is what e1000 currently did when mit timer is active in pre_save(). Fixing this by scheduling a timer in post_load() which can make sure the interrupt was raised when VM is running. Reported-and-tested-by: Longpeng Signed-off-by

[Qemu-devel] [PULL 0/5] Net patches

2019-07-29 Thread Jason Wang
The following changes since commit fff3159900d2b95613a9cb75fc3703e67a674729: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190726' into staging (2019-07-26 16:23:07 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-requ

[Qemu-devel] [PULL 5/5] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-29 Thread Jason Wang
From: Zhang Chen This patch to fix the origin "char *data" memory leak, code style issue and add necessary check here. Reported-by: Coverity (CID 1402785) Signed-off-by: Zhang Chen Reviewed-by: Peter Maydell Signed-off-by: Jason Wang --- net/colo-compare.c | 27 --- 1

[Qemu-devel] [PULL 2/5] qemu-bridge-helper: restrict interface name to IFNAMSIZ

2019-07-29 Thread Jason Wang
From: Prasad J Pandit The network interface name in Linux is defined to be of size IFNAMSIZ(=16), including the terminating null('\0') byte. The same is applied to interface names read from 'bridge.conf' file to form ACL rules. If user supplied '--br=bridge' name is not restricted to the same len

[Qemu-devel] [PULL 3/5] qemu-bridge-helper: move repeating code in parse_acl_file

2019-07-29 Thread Jason Wang
From: Prasad J Pandit Move repeating error handling sequence in parse_acl_file routine to an 'err' label. Signed-off-by: Prasad J Pandit Reviewed-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Reviewed-by: Li Qiang Signed-off-by: Jason Wang --- qemu-bridge-helper.c | 19 +-

[Qemu-devel] [PULL 4/5] net: tap: replace snprintf with g_strdup_printf calls

2019-07-29 Thread Jason Wang
From: Prasad J Pandit When invoking qemu-bridge-helper in 'net_bridge_run_helper', instead of using fixed sized buffers, use dynamically allocated ones initialised and returned by g_strdup_printf(). Signed-off-by: Prasad J Pandit Reviewed-by: Li Qiang Reviewed-by: Daniel P. Berrangé Signed-of

Re: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range

2019-07-29 Thread David Hildenbrand
On 29.07.19 10:30, Wei Yang wrote: > On Mon, Jul 29, 2019 at 09:49:37AM +0200, David Hildenbrand wrote: >> On 28.07.19 15:13, Wei Yang wrote: >>> The memory-device list built by memory_device_build_list is ordered by >>> its address, this means if the tmp range exceed the hinted range, all >>> the

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Paolo Bonzini
On 29/07/19 09:09, Markus Armbruster wrote: > Peter Maydell writes: > >> On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini wrote: >>> >>> On 27/07/19 09:16, Markus Armbruster wrote: We started with a single trace-events. That wasn't good, so we split it up into one per directory. That isn'

Re: [Qemu-devel] [PULL 0/1] Linux user for 4.1 patches

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:35, Laurent Vivier wrote: > > The following changes since commit fff3159900d2b95613a9cb75fc3703e67a674729: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190726' into staging (2019-07-26 > 16:23:07 +0100) > > are available in the Git repos

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Peter Maydell
On Mon, 29 Jul 2019 at 09:21, Daniel P. Berrangé wrote: > You can disable warnings selectively per file using a Pragma in the > source. In at least one of these cases (libvixl) the point of using the per-file flags is that the source files are third party upstream ones which we don't want to carr

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Peter Maydell
On Mon, 29 Jul 2019 at 09:51, Paolo Bonzini wrote: > There is no case where we're using per-.o file CFLAGS for anything other > than dependencies. disas/libvixl is a counterexample -- we use per-.o-file CFLAGS for: * suppressing warnings in third-party code we don't want to carry local modifi

Re: [Qemu-devel] [PATCH 0/3] virtiofsd: add FUSE_INIT map_alignment field

2019-07-29 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > The client must know the server's alignment constraints for FUSE_SETUPMAPPING > and FUSE_REMOVEMAPPING. This is necessary because mmap(2)/munmap(2) have > alignment constraints and the guest may have a different page size from the > host. The new F

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Paolo Bonzini
On 29/07/19 11:21, Peter Maydell wrote: > On Mon, 29 Jul 2019 at 09:51, Paolo Bonzini wrote: >> There is no case where we're using per-.o file CFLAGS for anything other >> than dependencies. > > disas/libvixl is a counterexample -- we use per-.o-file CFLAGS for: > * suppressing warnings in third

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Peter Maydell
On Mon, 29 Jul 2019 at 10:29, Paolo Bonzini wrote: > > On 29/07/19 11:21, Peter Maydell wrote: > > On Mon, 29 Jul 2019 at 09:51, Paolo Bonzini wrote: > >> There is no case where we're using per-.o file CFLAGS for anything other > >> than dependencies. > > > > disas/libvixl is a counterexample --

[Qemu-devel] Reminder: rc3 tomorrow, please list any remaining release-critical issues on wiki

2019-07-29 Thread Peter Maydell
Hi; are there any remaining release-critical issues for 4.1? If you know of any, please list them on the wiki page: https://wiki.qemu.org/Planning/4.1#Known_issues (and/or just reply to this email) rc3 will be tomorrow, and ideally that will be the final rc before our release. thanks -- PMM

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2019-07-29 Thread Peter Maydell
The sigaltstack fix is now in master (commit 5bfce0b74fbd5d530) and at least in my test environment this also fixes the "can't build hello.go reliably" example. So I'm marking this as 'fix committed'. If there are still problems with running Go binaries, these are likely to be independent bugs, so

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Paolo Bonzini
On 29/07/19 11:32, Peter Maydell wrote: >> The NetBSD thing could be worked around with a static library but >> instead those -D options could be added as global C++ flags: >> >> __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS are a workaround to >> allow C++ programs to use stdint.h macros

Re: [Qemu-devel] [PATCH v3] block/rbd: add preallocation support

2019-07-29 Thread Stefano Garzarella
On Fri, Jul 26, 2019 at 08:46:56AM -0400, Jason Dillaman wrote: > On Fri, Jul 26, 2019 at 4:48 AM Stefano Garzarella > wrote: > > > > On Thu, Jul 25, 2019 at 09:30:30AM -0400, Jason Dillaman wrote: > > > On Thu, Jul 25, 2019 at 4:13 AM Stefano Garzarella > > > wrote: > > > > > > > > On Wed, Jul

[Qemu-devel] [Bug 1809453] Re: Windows qemu download Big file bug in net user mode

2019-07-29 Thread elmarco
What is your version of qemu? I understand you are running qemu on ubuntu. The VM is windows? which version? Which URL are you downloading? What is the program being used? thanks ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a membe

[Qemu-devel] [Bug 1010484] Re: slirp to accept non-local dns server

2019-07-29 Thread elmarco
ping ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1010484 Title: slirp to accept non-local dns server Status in QEMU: Incomplete Bug descr

Re: [Qemu-devel] [PATCH] Fix Guest VM crash due to iSCSI Sense Key error

2019-07-29 Thread Stefan Hajnoczi
On Fri, Jul 26, 2019 at 04:18:46PM -0400, John Snow wrote: > Paolo, Stefan and Kevin: can I loop you in here? I'm quite uncertain > about this and I'd like to clear this up quickly if it's possible: > > On 7/25/19 8:58 PM, John Snow wrote: > > > > > > On 7/7/19 10:55 PM, shaju.abra...@nutanix.co

Re: [Qemu-devel] [PULL] RISC-V Patch for 4.1-rc3

2019-07-29 Thread Peter Maydell
On Sat, 27 Jul 2019 at 00:27, Palmer Dabbelt wrote: > > The following changes since commit bf8b024372bf8abf5a9f40bfa65eeefad23ff988: > > Update version for v4.1.0-rc2 release (2019-07-23 18:28:08 +0100) > > are available in the Git repository at: > > git://github.com/palmer-dabbelt/qemu.git ta

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-29 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 7/18/19 8:20 AM, Philippe Mathieu-Daudé wrote: > On 7/16/19 8:20 PM, Philippe Mathieu-Daudé wrote: >> Hi Aleksandar, >> >> On 7/16/19 7:09 PM, Aleksandar Markovic wrote: >>> On Tue, Jul 16, 2019 at 1:54 PM Thomas Huth wrote: On 16/07/2019 13.17, Aleksandar Markovic wro

[Qemu-devel] [PATCH for-4.1] block/copy-on-read: Fix permissions for inactive node

2019-07-29 Thread Kevin Wolf
The copy-on-read drive must not request the WRITE_UNCHANGED permission for its child if the node is inactive, otherwise starting a migration destination with -incoming will fail because the child cannot provide write access yet: qemu-system-x86_64: -blockdev copy-on-read,file=img,node-name=cor:

Re: [Qemu-devel] [PATCH] Support load kernel(vmlinux)/dtb/initrd separately for Boston in QEMU.

2019-07-29 Thread Aleksandar Markovic
ping On Mon, Apr 1, 2019 at 11:26 AM Archer Yan wrote: > Currently boston in QEMU only supports boot with FIT format. Since ELF file > can provide symbol infomation in debug, this patch enables Boston boot from > vmlinux&dtb. > > Signed-off-by: Archer Yan > --- > hw/mips/boston.c | 224 +++

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Markus Armbruster
Pino Toscano writes: > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: >> On 7/26/19 9:09 AM, Pino Toscano wrote: >> > Add a 'private-key' option which represents the path of a private key >> > to use for authentication, and 'private-key-secret' as the name of an >> > object with its pass

Re: [Qemu-devel] [PATCH v4 7/7] monitor: adding info tbs, tb, and coverset

2019-07-29 Thread Alex Bennée
vandersonmr writes: > Adding info [tbs|tb|coverset] commands to HMP. > These commands allow the exploration of TBs > generated by the TCG. Understand which one > hotter, with more guest/host instructions... > and examine their guest, host and IR code. > > The goal of this command is to allow th

Re: [Qemu-devel] [PULL 0/2] ppc-for-4.1 queue 20190728

2019-07-29 Thread Peter Maydell
On Sun, 28 Jul 2019 at 07:44, David Gibson wrote: > > The following changes since commit fff3159900d2b95613a9cb75fc3703e67a674729: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190726' into staging (2019-07-26 > 16:23:07 +0100) > > are available in the Git reposit

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Kevin Wolf
Am 26.07.2019 um 16:24 hat Eric Blake geschrieben: > On 7/26/19 9:09 AM, Pino Toscano wrote: > > Add a 'private-key' option which represents the path of a private key > > to use for authentication, and 'private-key-secret' as the name of an > > object with its passphrase. > > > > Signed-off-by: Pi

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Markus Armbruster
Paolo Bonzini writes: > On 29/07/19 11:32, Peter Maydell wrote: >>> The NetBSD thing could be worked around with a static library but >>> instead those -D options could be added as global C++ flags: >>> >>> __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS are a workaround to >>> allow C++ p

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Pino Toscano
On Monday, 29 July 2019 12:57:40 CEST Markus Armbruster wrote: > Pino Toscano writes: > > > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: > >> On 7/26/19 9:09 AM, Pino Toscano wrote: > >> > Add a 'private-key' option which represents the path of a private key > >> > to use for authentic

Re: [Qemu-devel] [QUESTION] SDL 1.2 support

2019-07-29 Thread Aleksandar Markovic
> > > > > > > I already spent 2h on this today, I have to continue other tasks > > meanwhile, I might continue later. > > I spent 1 more hour installing the CodeScape MIPS SDK,... Philippe, thank you so much for your 3 hours! Regards, Aleksandar

Re: [Qemu-devel] [PULL 0/5] Net patches

2019-07-29 Thread Peter Maydell
On Mon, 29 Jul 2019 at 09:33, Jason Wang wrote: > > The following changes since commit fff3159900d2b95613a9cb75fc3703e67a674729: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20190726' into staging (2019-07-26 > 16:23:07 +0100) > > are available in the git repositor

Re: [Qemu-devel] [PATCH v3] block/rbd: add preallocation support

2019-07-29 Thread Jason Dillaman
On Mon, Jul 29, 2019 at 5:40 AM Stefano Garzarella wrote: > > On Fri, Jul 26, 2019 at 08:46:56AM -0400, Jason Dillaman wrote: > > On Fri, Jul 26, 2019 at 4:48 AM Stefano Garzarella > > wrote: > > > > > > On Thu, Jul 25, 2019 at 09:30:30AM -0400, Jason Dillaman wrote: > > > > On Thu, Jul 25, 2019

Re: [Qemu-devel] [Virtio-fs] [PATCH 2/5] virtiofsd: prevent lo_lookup() NULL pointer dereference

2019-07-29 Thread piaojun
Hi Stefan, On 2019/7/26 17:11, Stefan Hajnoczi wrote: > Most lo_do_lookup() have already checked that the parent inode exists. > lo_lookup() hasn't and can therefore hit a NULL pointer dereference when > lo_inode(req, parent) returns NULL. > > Signed-off-by: Stefan Hajnoczi > --- > contrib/virt

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Alex Bennée
Daniel P. Berrangé writes: > On Sat, Jul 27, 2019 at 07:20:15PM +0100, Peter Maydell wrote: >> On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini wrote: >> > >> > On 27/07/19 09:16, Markus Armbruster wrote: >> > > We started with a single trace-events. That wasn't good, so we split it >> > > up into

Re: [Qemu-devel] [PATCH v5] target/arm: generate a custom MIDR for -cpu max

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 12:39, Alex Bennée wrote: > > While most features are now detected by probing the ID_* registers > kernels can (and do) use MIDR_EL1 for working out of they have to > apply errata. This can trip up warnings in the kernel as it tries to > work out if it should apply workaroun

[Qemu-devel] [PATCH] tests: Set read-zeroes on for null-co driver

2019-07-29 Thread Andrey Shinkevich
This patch is to reduce the number of Valgrind report messages about using uninitialized memory with the null-co driver. It helps to filter real memory issues and is the same work done for the iotests with the commit ID a6862418fec4072. Suggested-by: Kevin Wolf Signed-off-by: Andrey Shinkevich -

Re: [Qemu-devel] [PULL 0/5] Net patches

2019-07-29 Thread Jason Wang
On 2019/7/29 下午7:47, Peter Maydell wrote: On Mon, 29 Jul 2019 at 09:33, Jason Wang wrote: The following changes since commit fff3159900d2b95613a9cb75fc3703e67a674729: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190726' into staging (2019-07-26 16:23:07 +0100)

Re: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range

2019-07-29 Thread Wei Yang
On Mon, Jul 29, 2019 at 10:30:56AM +0200, Igor Mammedov wrote: >On Mon, 29 Jul 2019 09:49:37 +0200 >David Hildenbrand wrote: > >> On 28.07.19 15:13, Wei Yang wrote: >> > The memory-device list built by memory_device_build_list is ordered by >> > its address, this means if the tmp range exceed the

[Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-29 Thread Sergio Lopez
Implement the modern (v2) personality, according to the VirtIO 1.0 specification. Support for v2 among guests is not as widespread as it'd be desirable. While the Linux driver has had it for a while, support is missing, at least, from Tianocore EDK II, NetBSD and FreeBSD. For this reason, the v2

Re: [Qemu-devel] [PATCH 3/6] hw/arm: Use sysbus_init_child_obj for correct reference counting

2019-07-29 Thread Peter Maydell
On Mon, 1 Jul 2019 at 13:31, Philippe Mathieu-Daudé wrote: > > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the r

Re: [Qemu-devel] [PATCH 4/6] hw/arm/fsl-imx: Add the cpu as child of the SoC object

2019-07-29 Thread Peter Maydell
On Mon, 1 Jul 2019 at 13:31, Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/fsl-imx25.c | 4 +++- > hw/arm/fsl-imx31.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c > index 869ee89b15.

Re: [Qemu-devel] [PATCH 1/6] hw/arm: Use ARM_CPU_TYPE_NAME() macro when appropriate

2019-07-29 Thread Peter Maydell
On Mon, 1 Jul 2019 at 13:31, Philippe Mathieu-Daudé wrote: > > Commit ba1ba5cca introduce the ARM_CPU_TYPE_NAME() macro. > Unify the code base by use it in all places. > > Signed-off-by: Philippe Mathieu-Daudé > --- > diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c > index 05505bac56..1c

Re: [Qemu-devel] [PATCH 2/6] hw/arm: Use object_initialize_child for correct reference counting

2019-07-29 Thread Peter Maydell
On Mon, 1 Jul 2019 at 13:31, Philippe Mathieu-Daudé wrote: > > As explained in commit aff39be0ed97: > > Both functions, object_initialize() and object_property_add_child() > increase the reference counter of the new object, so one of the > references has to be dropped afterwards to get the r

Re: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-07-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190729125755.45008-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC] virtio-mmio: implement modern (v2) personality (virtio-1) Message-id: 20190729

Re: [Qemu-devel] [PATCH v8 02/11] numa: move numa global variable nb_numa_nodes into MachineState

2019-07-29 Thread Igor Mammedov
On Mon, 29 Jul 2019 14:31:18 +0800 Tao Xu wrote: > Add struct NumaState in MachineState and move existing numa global > nb_numa_nodes(renamed as "num_nodes") into NumaState. And add variable > numa_support into MachineClass to decide which submachines support NUMA. > > Suggested-by: Igor Mammedo

[Qemu-devel] [PATCH for 4.1 v2 7/7] linux-user: Add support for semtimedop() syscall

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add support for semtimedop() emulation. It is based on invocation of safe_semtimedop(). Conversion is left out of safe_semtimedop(), since other safe_xxx() usually don't contain similar conversions. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --

[Qemu-devel] [PATCH for 4.1 v2 0/7] linux-user: Misc patches for 4.2

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Markovic A set of misc linux user patches for 4.2. v2->v3: - minor code formatting improvements - added a patch on semtimedop() v1->v2: - updated commit messages - minor improvements of code formatting - added three patches containing support for ten additional

[Qemu-devel] [PATCH for 4.1 v2 6/7] linux-user: Add support for RNDRESEEDCRNG ioctl

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Markovic RNDRESEEDCRNG is a newer ioctl (added in kernel 4.17), and an "ifdef" guard is used for that reason in this patch. Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/ioctls.h | 3 +++ linux-user/syscall_defs.h | 1 + 2 files changed,

[Qemu-devel] [PATCH for 4.1 v2 1/7] linux user: Add support for FDFLUSH ioctl

2019-07-29 Thread Aleksandar Markovic
From: Yunqiang Su FDFLUSH is used for flushing buffers of floppy drives. Support in QEMU is needed because some of Debian packages use this ioctl while running post-build tests. One such example is 'tar' package. Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic Reviewed-by: Lauren

[Qemu-devel] [PATCH for 4.1 v2 5/7] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Markovic FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands for controlling error reporting of a floppy drive. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h| 2 ++ linux-user/syscall_defs.h | 19 +++ linux-user/syscall_typ

[Qemu-devel] [PATCH for 4.1 v2 4/7] linux-user: Add support for FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Markovic FDFMTBEG, FDFMTTRK, and FDFMTEND ioctls provide means for controlling formatting of a floppy drive. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h| 3 +++ linux-user/syscall_defs.h | 3 +++ linux-user/syscall_types.h | 5 + 3 files changed, 11

[Qemu-devel] [PATCH for 4.1 v2 2/7] linux-user: Add support for FDMSGON and FDMSGOFF ioctls

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Markovic FDMSGON and FDMSGOFF switch informational messages of floppy drives on and off. Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/ioctls.h | 2 ++ linux-user/syscall_defs.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/linux

[Qemu-devel] [PATCH for 4.1 v2 3/7] linux-user: Add support for FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls

2019-07-29 Thread Aleksandar Markovic
From: Aleksandar Markovic FDRESET, FDRAWCMD, FDTWADDLE, and FDEJECT ioctls are misc commands for controlling a floppy drive. Signed-off-by: Aleksandar Markovic --- linux-user/ioctls.h | 4 linux-user/syscall_defs.h | 4 2 files changed, 8 insertions(+) diff --git a/linux-user/

Re: [Qemu-devel] [PULL 2/5] block/nvme: support larger that 512 bytes sector devices

2019-07-29 Thread Peter Maydell
On Mon, 22 Jul 2019 at 18:26, Max Reitz wrote: > > From: Maxim Levitsky > > Currently the driver hardcodes the sector size to 512, > and doesn't check the underlying device. Fix that. > > Also fail if underlying nvme device is formatted with metadata > as this needs special support. > > Signed-of

Re: [Qemu-devel] [PULL 2/5] block/nvme: support larger that 512 bytes sector devices

2019-07-29 Thread Max Reitz
On 29.07.19 15:16, Peter Maydell wrote: > On Mon, 22 Jul 2019 at 18:26, Max Reitz wrote: >> >> From: Maxim Levitsky >> >> Currently the driver hardcodes the sector size to 512, >> and doesn't check the underlying device. Fix that. >> >> Also fail if underlying nvme device is formatted with metada

Re: [Qemu-devel] [PATCH for 4.1 v2 7/7] linux-user: Add support for semtimedop() syscall

2019-07-29 Thread Aleksandar Markovic
On Mon, Jul 29, 2019 at 3:11 PM Aleksandar Markovic < aleksandar.marko...@rt-rk.com> wrote: > From: Aleksandar Rikalo > > Add support for semtimedop() emulation. It is based on invocation > of safe_semtimedop(). > > Conversion is left out of safe_semtimedop(), since other safe_xxx() > usually don

Re: [Qemu-devel] high-level view of packet processing for virtio NIC?

2019-07-29 Thread Stefan Hajnoczi
On Tue, Jul 23, 2019 at 10:18:01AM -0600, Chris Friesen wrote: > I'm looking for information on what the qemu architecture looks like for > processing virtio network packets in a two-vCPU guest. > > It looks like there's an IO thread doing a decent fraction of the work, > separate from the vCPU th

Re: [Qemu-devel] [PATCH for 4.1 v2 7/7] linux-user: Add support for semtimedop() syscall

2019-07-29 Thread Laurent Vivier
Le 29/07/2019 à 15:09, Aleksandar Markovic a écrit : > From: Aleksandar Rikalo > > Add support for semtimedop() emulation. It is based on invocation > of safe_semtimedop(). > > Conversion is left out of safe_semtimedop(), since other safe_xxx() > usually don't contain similar conversions. > > S

Re: [Qemu-devel] [PATCH for 4.1 v2 7/7] linux-user: Add support for semtimedop() syscall

2019-07-29 Thread Laurent Vivier
Le 29/07/2019 à 15:26, Aleksandar Markovic a écrit : > > > On Mon, Jul 29, 2019 at 3:11 PM Aleksandar Markovic > mailto:aleksandar.marko...@rt-rk.com>> > wrote: > > From: Aleksandar Rikalo > > > Add support for semtimedop() emulation. It is based on inv

Re: [Qemu-devel] [PATCH for-4.1] block/copy-on-read: Fix permissions for inactive node

2019-07-29 Thread Eric Blake
On 7/29/19 5:53 AM, Kevin Wolf wrote: > The copy-on-read drive must not request the WRITE_UNCHANGED permission > for its child if the node is inactive, otherwise starting a migration > destination with -incoming will fail because the child cannot provide > write access yet: > > qemu-system-x86_6

Re: [Qemu-devel] [PATCH 01/67] decodetree: Allow !function with no input bits

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > With this, we can have the function return a value from the DisasContext. > > Signed-off-by: Richard Henderson > --- > scripts/decodetree.py | 5 - > tests/decode/succ_function.decode | 2 ++ > 2 files changed, 6 insertio

Re: [Qemu-devel] [PATCH 02/67] target/arm: Remove offset argument to gen_exception_insn

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > The address of the current insn is still available in s->base.pc_next. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-vfp.inc.c | 6 +++--- > target/arm/translate.c | 32 > 2 f

Re: [Qemu-devel] [PATCH 03/67] target/arm: Remove offset argument to gen_exception_bkpt_insn

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > The address of the current insn is still available in s->base.pc_next. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/arm/transl

Re: [Qemu-devel] [PATCH 04/67] target/arm: Remove offset argument to gen_exception_internal_insn

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > The actual argument is 0 for all callers. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/arm/translate.c b/target/arm/translate.

Re: [Qemu-devel] [PATCH 05/67] target/arm: Use the saved value of the insn address

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > The address of the current insn is still available in s->base.pc_next, > and need not be recomputed from s->pc - 4. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 12 ++-- > 1 file changed, 6 insertions(+),

Re: [Qemu-devel] [PATCH] docs/nvdimm: add example on persistent backend setup

2019-07-29 Thread Stefan Hajnoczi
On Wed, Jul 24, 2019 at 03:03:07PM +0800, Wei Yang wrote: > Persistent backend setup requires some knowledge about nvdimm and ndctl > tool. Some users report they may struggle to gather these knowledge and > have difficulty to setup it properly. > > Here we provide two examples for persistent back

Re: [Qemu-devel] [PATCH 06/67] target/arm: Introduce pc_read

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > We currently have 3 different ways of computing the architectural > value of "PC" as seen in the ARM ARM. > > The value of s->pc has been incremented past the current insn, > but that is all. Thus for a32, PC = s->pc + 4; for t32, PC = s-

Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson

2019-07-29 Thread Paolo Bonzini
On 29/07/19 14:41, Alex Bennée wrote: >> I'd suggest we don't actually /need/ per-file compiler flags in most >> cases. eg when we add $foo.o-libs += $(FOO_LIBS) that's not really >> a per-file setting when it gets expanded onto the final linker line. >> Its just a "-lfoo" that gets used for the l

Re: [Qemu-devel] [PATCH 07/67] target/arm: Introduce add_reg_for_lit

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > Used only on the thumb side so far, but will be more obvious > once we start unifying the implementation of A32+T32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-vfp.inc.c | 34 +-- > target/arm/translate.c

[Qemu-devel] [Bug 1696773] Re: golang calls to exec crash user emulation

2019-07-29 Thread Peter Maydell
Note that this fix will be in the upcoming 4.1 release. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1696773 Title: golang calls to exec crash user emulation Status in QEMU: Fix Committed Bug

Re: [Qemu-devel] [PATCH 08/67] target/arm: Use store_reg_from_load in thumb2 code

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > There is an extra always-true ARMv5 test, but this will > become more obvious once we start unifying the > implementation of A32+T32. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 12 +++- > 1 file changed

Re: [Qemu-devel] [PATCH 09/67] target/arm: Fold a pc load into load_reg

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/target/arm/translate.c b/target/arm/translate.c > index e316eeb312..53c46fcdc4 100644 > --- a/t

Re: [Qemu-devel] [PATCH-4.2 v1 3/6] riscv: plic: Remove unused interrupt functions

2019-07-29 Thread Philippe Mathieu-Daudé
On 7/25/19 8:52 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > hw/riscv/sifive_plic.c | 12 > include/hw/riscv/sifive_plic.h | 3 --- > 2 files changed, 15 deletions(-) > > diff --git a/hw/riscv/sifive_plic.c b/hw/riscv/sifive_plic.c > index 0950e89e1

Re: [Qemu-devel] [PATCH-4.2 v1 4/6] target/riscv: Create function to test if FP is enabled

2019-07-29 Thread Philippe Mathieu-Daudé
On 7/25/19 8:52 PM, Alistair Francis wrote: > Let's creaate a function that tests if floating point support is "create" > enabled. We can then protect all floating point operations based on if > they are enabled. > > This patch so far doesn't change anything, it's just preparing for the > Hyperv

Re: [Qemu-devel] [PATCH 10/67] target/arm: Move test for AL into arm_skip_unless

2019-07-29 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:50, Richard Henderson wrote: > > We will shortly be calling this function much more often. > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/target/

  1   2   3   >