Re: [Qemu-devel] [PATCH] doc: document that the monitor console is a privileged control interface

Daniel P. Berrangé writes: > A supposed exploit of QEMU was recently announced as CVE-2019-12928 > claiming that the monitor console was insecure because the "migrate" > comand enabled arbitrary command execution for a remote attacker. > > For this to be a flaw the user launching QEMU must have c

[Qemu-devel] [PATCH 04/16] nvme: add missing fields in identify controller

Not used by the device model but added for completeness. See NVM Express 1.2.1, Section 5.11 ("Identify command"), Figure 90. Signed-off-by: Klaus Birkelund Jensen --- include/block/nvme.h | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/inc

[Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces

Matt Fitzpatrick's post ("[RFC,v1] Namespace Management Support") pushed me to finally get my head out of my a** and post this series. This is basically a follow-up to my previous series ("nvme: v1.3, sgls, metadata and new 'ocssd' device"), but I'm not tagging it as a v2 because the patches for m

[Qemu-devel] [PATCH 01/16] nvme: simplify namespace code

The device model currently only supports a single namespace and also specifically sets num_namespaces to 1. Take this into account and simplify the code. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 26 +++--- hw/block/nvme.h | 2 +- 2 files changed, 8 inserti

[Qemu-devel] [PATCH 12/16] nvme: bump supported NVMe revision to 1.3d

Add the new Namespace Identification Descriptor List (CNS 03h) and track creation of queues to enable the controller to return Command Sequence Error if Set Features is called for Number of Queues after any queues have been created. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c

[Qemu-devel] [PATCH 07/16] nvme: support Abort command

Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.1 ("Abort command"). Extracted from Keith's qemu-nvme tree. Modified to only consider queued and not executing commands. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 56

[Qemu-devel] [PATCH 03/16] nvme: fix lpa field

The Log Page Attributes in the Identify Controller structure indicates that the controller supports the SMART / Health Information log page on a per namespace basis. It does not, given that neither this log page or the Get Log Page command is implemented. Signed-off-by: Klaus Birkelund Jensen ---

[Qemu-devel] [PATCH 10/16] nvme: support Get Log Page command

Add support for the Get Log Page command and stub/dumb implementations of the mandatory Error Information, SMART/Health Information and Firmware Slot Information log pages. Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.10 ("Get Log Page command"). Signed-off-b

[Qemu-devel] [PATCH 06/16] nvme: support completion queue in cmb

While not particularly useful, allow completion queues in the controller memory buffer. Could be useful for testing. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c i

[Qemu-devel] [PATCH 09/16] nvme: support Asynchronous Event Request command

Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.2 ("Asynchronous Event Request command"). Modified from Keith's qemu-nvme tree. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 88 ++- hw/block/nvme.h

[Qemu-devel] [PATCH 11/16] nvme: add missing mandatory Features

Add support for returning a resonable response to Get/Set Features of mandatory features. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 49 --- hw/block/trace-events | 2 ++ include/block/nvme.h | 3 ++- 3 files changed, 50 insertion

[Qemu-devel] [PATCH 05/16] nvme: populate the mandatory subnqn and ver fields

Required for compliance with NVMe revision 1.2.1 or later. See NVM Express 1.2.1, Section 5.11 ("Identify command"), Figure 90 and Section 7.9 ("NVMe Qualified Names"). This also bumps the supported version to 1.2.1. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 8 +++- 1 file

[Qemu-devel] [PATCH 14/16] nvme: support multiple block requests per request

Currently, the device only issues a single block backend request per NVMe request, but as we move towards supporting metadata (and discontiguous vector requests supported by OpenChannel 2.0) it will be required to issue multiple block backend requests per NVMe request. With this patch the NVMe dev

[Qemu-devel] [PATCH 15/16] nvme: support scatter gather lists

For now, support the Data Block, Segment and Last Segment descriptor types. See NVM Express 1.3d, Section 4.4 ("Scatter Gather List (SGL)"). Signed-off-by: Klaus Birkelund Jensen --- block/nvme.c | 18 +- hw/block/nvme.c | 390 +++--- hw/block

[Qemu-devel] [PATCH 08/16] nvme: refactor device realization

Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 196 ++-- hw/block/nvme.h | 11 +++ 2 files changed, 152 insertions(+), 55 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 4b9ff51868c0..eb6af6508e2d 100644 --- a/hw/block/n

[Qemu-devel] [PATCH 13/16] nvme: simplify dma/cmb mappings

Instead of handling both QSGs and IOVs in multiple places, simply use QSGs everywhere by assuming that the request does not involve the controller memory buffer (CMB). If the request is found to involve the CMB, convert the QSG to an IOV and issue the I/O. The QSG is converted to an IOV by the dma

[Qemu-devel] [PATCH 02/16] nvme: move device parameters to separate struct

Move device configuration parameters to separate struct to make it explicit what is configurable and what is set internally. Also, clean up some includes. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 54 +++-- hw/block/nvme.h | 16 +

[Qemu-devel] [PATCH] usbredir: fix buffer-overflow on migration load

NO_INTERFACE_INFO (255) is used to indicate no info. /home/elmarco/src/qemu/hw/usb/redirect.c:1504:71: runtime error: index 32 out of bounds for type 'uint8_t [32]' /home/elmarco/src/qemu/hw/usb/redirect.c:1503:71: runtime error: index 32 out of bounds for type 'uint8_t [32]' /home/elmarco/src/q

[Qemu-devel] [PATCH 16/16] nvme: support multiple namespaces

This adds support for multiple namespaces by introducing a new 'nvme-ns' device model. The nvme device creates a bus named from the device name ('id'). The nvme-ns devices then connect to this and registers themselves with the nvme device. This changes how an nvme device is created. Example with t

Re: [Qemu-devel] [PULL 41/46] target/arm/vfp_helper: Extract vfp_set_fpscr_to_host()

Hello, On Tue, Jul 2, 2019 at 4:18 AM Peter Maydell wrote: > > From: Philippe Mathieu-Daudé > > The vfp_set_fpscr() helper contains code specific to the host > floating point implementation (here the SoftFloat library). > Extract this code to vfp_set_fpscr_to_host(). > > Signed-off-by: Philippe

Re: [Qemu-devel] [PATCH] usbredir: fix buffer-overflow on migration load

Hi On Fri, Jul 5, 2019 at 11:40 AM Marc-André Lureau wrote: > > NO_INTERFACE_INFO (255) is used to indicate no info. > > /home/elmarco/src/qemu/hw/usb/redirect.c:1504:71: runtime error: index 32 out > of bounds for type 'uint8_t [32]' > /home/elmarco/src/qemu/hw/usb/redirect.c:1503:71: runtime e

Re: [Qemu-devel] [Qemu-block] [RFC, v1] Namespace Management Support

On Tue, Jul 02, 2019 at 10:39:36AM -0700, Matt Fitzpatrick wrote: > Adding namespace management support to the nvme device. Namespace creation > requires contiguous block space for a simple method of allocation. > > I wrote this a few years ago based on Keith's fork and nvmeqemu fork and > have re

Re: [Qemu-devel] question：about introduce a new feature named “I/O hang”

Am 04.07.2019 um 17:16 hat wangjie (P) geschrieben: > Hi, everybody： > > I developed a feature named "I/O hang"，my intention is to solve the problem > like that： > If the backend storage media of VM disk is far-end storage like IPSAN or > FCSAN, storage net link will always disconnection and > mak

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

On Thu, Jul 04, 2019 at 11:28:37AM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 04, 2019 at 11:24:57AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 03, 2019 at 06:25:01PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jul 03, 2019 at 07:10:05PM +0200, Philippe Mathieu-Daudé wrote: > > > > @@ -30

Re: [Qemu-devel] [PATCH] hw/i386: Fix linker error when ISAPC is disabled

On 04/07/19 20:03, Julio Montes wrote: > How about a new header file with all devices? (see below patch) Yes, looks good. Paolo > --- > Makefile.target | 5 + > hw/i386/pc_piix.c | 11 --- > include/qemu/osdep.h | 1 + > scripts/create_config | 2 ++ > 4 files changed,

Re: [Qemu-devel] [PATCH] hw/i386: Fix linker error when ISAPC is disabled

On 04/07/19 20:03, Julio Montes wrote: > How about a new header file with all devices? (see below patch) Yes, looks good. Paolo > --- > Makefile.target | 5 + > hw/i386/pc_piix.c | 11 --- > include/qemu/osdep.h | 1 + > scripts/create_config | 2 ++ > 4 files changed,

[Qemu-devel] [PATCH v22 01/22] MAINTAINERS: Add RX

Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-18-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINER

[Qemu-devel] [PATCH v22 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core

From: Philippe Mathieu-Daudé While the VIRT machine can use different microcontrollers, the RX62N microcontroller is tied to the RX62N CPU core. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato --- hw/rx/rx-virt.c | 8 1 file changed, 8 insertions(+) diff --git a/

[Qemu-devel] [PATCH v22 10/22] target/rx: Use prt_ldmi for XCHG_mr disassembly

From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-21-ys...@users.sourceforge.jp> Tested-by: Philip

[Qemu-devel] [PATCH v22 02/22] qemu/bitops.h: Add extract8 and extract16

Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 +

[Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

Hello. This patch series is added Renesas RX target emulation. Changes for v21. rebase latest master. Remove unneeded hmp_info_tlb. Chanegs for v20. Reorderd patches. Squashed v19 changes. Changes for v19. Follow tcg changes. Cleanup cpu.c. simplify rx_cpu_class_by_name and rx_load_image move to

[Qemu-devel] [PATCH v22 03/22] hw/registerfields.h: Add 8bit and 16bit register macros

From: Philippe Mathieu-Daudé Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe Math

[Qemu-devel] [PATCH v22 05/22] target/rx: TCG helper

v21 changes Use cpu_env Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-3-ys...@users.sourceforge.jp> Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-3-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson [PMD: Removed

[Qemu-devel] [PATCH v22 09/22] target/rx: Replace operand with prt_ldmi in disassembler

From: Richard Henderson This has consistency with prt_ri(). It loads all data before beginning output. It uses exactly one call to prt() to emit the full instruction. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49

[Qemu-devel] [PATCH v22 22/22] target/rx: remove unused functions.

Signed-off-by: Yoshinori Sato --- target/rx/monitor.c | 38 -- target/rx/Makefile.objs | 1 - 2 files changed, 39 deletions(-) delete mode 100644 target/rx/monitor.c diff --git a/target/rx/monitor.c b/target/rx/monitor.c deleted file mode 100644 index 5d

[Qemu-devel] [PATCH v22 12/22] target/rx: Collect all bytes during disassembly

From: Richard Henderson Collected, to be used in the next patch. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-23-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v22 18/22] hw/rx: Honor -accel qtest

From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-16-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signe

[Qemu-devel] [PATCH v22 08/22] target/rx: Disassemble rx_index_addr into a string

From: Richard Henderson We were eliding all zero indexes. It is only ld==0 that does not have an index in the instruction. This also allows us to avoid breaking the final print into multiple pieces. Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-1

[Qemu-devel] [PATCH v22 13/22] target/rx: Dump bytes for each insn during disassembly

From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <201906070

[Qemu-devel] [PATCH v22 16/22] hw/char: RX62N serial communication interface (SCI)

This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-8-ys...@users.sourcef

[Qemu-devel] [PATCH v22 11/22] target/rx: Emit all disassembly in one prt()

From: Richard Henderson Many of the multi-part prints have been eliminated by previous patches. Eliminate the rest of them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-22-ys...@users.sourceforge.jp> Tested-by

[Qemu-devel] [PATCH v22 06/22] target/rx: CPU definition

v21 changes Add cpu-param.h Remove CPU_COMMON rx_load_image move to rx-virt. Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-4-ys...@users.sourceforge.jp> Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Hender

[Qemu-devel] [PATCH v22 14/22] hw/intc: RX62N interrupt controller (ICUa)

This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-6-ys...@users.sourcefo

[Qemu-devel] [PATCH v22 04/22] target/rx: TCG translation

This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-2-ys...@users

[Qemu-devel] [PATCH v22 20/22] Add rx-softmmu

Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-17-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson pick ed65c02993 target/rx: Add RX to SysEmuTarget pick 01372568ae tests: Add rx to machine-none-t

[Qemu-devel] [PATCH v22 21/22] BootLinuxConsoleTest: Test the RX-Virt machine

From: Philippe Mathieu-Daudé Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are very quick tests: $ avocado run -t arch:rx

[Qemu-devel] [PATCH v22 17/22] hw/rx: RX Target hardware definition

rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. v21 changes. rx_load_image move to rx-virt.c Signed-off-by: Yoshinori Sato Message-Id: <20190616142836.10614-17-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49

[Qemu-devel] [PATCH v22 07/22] target/rx: RX disassembler

Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 +

Re: [Qemu-devel] [PATCH for-4.1] hw/arm/sbsa-ref: Remove unnecessary check for secure_sysmem == NULL

On 7/4/19 4:20 PM, Peter Maydell wrote: > In the virt machine, we support TrustZone being either present or > absent, and so the code must deal with the secure_sysmem pointer > possibly being NULL. In the sbsa-ref machine, TrustZone is always > present, but some code and comments copied from virt s

[Qemu-devel] [PATCH v22 15/22] hw/timer: RX62N internal timer modules

renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philip

Re: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces

Patchew URL: https://patchew.org/QEMU/20190705072333.17171-1-kl...@birkelund.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces Message-id:

Re: [Qemu-devel] [PULL 41/46] target/arm/vfp_helper: Extract vfp_set_fpscr_to_host()

On 7/5/19 9:24 AM, Laurent Desnogues wrote: > Hello, > > On Tue, Jul 2, 2019 at 4:18 AM Peter Maydell wrote: >> >> From: Philippe Mathieu-Daudé >> >> The vfp_set_fpscr() helper contains code specific to the host >> floating point implementation (here the SoftFloat library). >> Extract this code

Re: [Qemu-devel] [PATCH 00/16] nvme: support NVMe v1.3d, SGLs and multiple namespaces

Patchew URL: https://patchew.org/QEMU/20190705072333.17171-1-kl...@birkelund.eu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make

Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141

[Qemu-devel] [Bug 1835466] Re: qemu 4.0.0 abort()s in audio_get_pdo_in (poisoned drv->driver?)

Can you set a watchpoint for (*dev)->driver and see where it fires? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1835466 Title: qemu 4.0.0 abort()s in audio_get_pdo_in (poisoned drv->driver?) Sta

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

On 04.07.19 00:47, Eric Blake wrote: > Although you generally won't use encryption with a Unix socket (after > all, everything is local, so why waste the CPU power), there are > situations in testsuites where Unix sockets are much nicer than TCP > sockets. Since nbdkit allows encryption over both

[Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

This patch allows 'qemu-img info' to show the 'disk size' for the RBD images that have the fast-diff feature enabled. If this feature is enabled, we use the rbd_diff_iterate2() API to calculate the allocated size for the image. Signed-off-by: Stefano Garzarella --- v3: - return -ENOTSUP instea

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

> > > > The following changes since commit > > > > 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > > > > > Merge remote-tracking branch > > > > 'remotes/maxreitz/tags/pull-block-2019-06-24' into staging > > > > (2019-07-01 > > > > 11:28:28 +0100) > > > > > > > > are available in the Gi

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

On Thu, 4 Jul 2019 at 22:29, Michael S. Tsirkin wrote: > > On Thu, Jul 04, 2019 at 10:25:48AM +0100, Peter Maydell wrote: > > On Tue, 2 Jul 2019 at 16:06, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > > > Merge

[Qemu-devel] [PATCH v2 for-4.1] target/arm: NS BusFault on vector table fetch escalates to NS HardFault

In the M-profile architecture, when we do a vector table fetch and it fails, we need to report a HardFault. Whether this is a Secure HF or a NonSecure HF depends on several things. If AIRCR.BFHFNMINS is 0 then HF is always Secure, because there is no NonSecure HardFault. Otherwise, the answer dep

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

On 7/5/19 10:07 AM, Stefan Hajnoczi wrote: > On Thu, Jul 04, 2019 at 11:28:37AM +0100, Daniel P. Berrangé wrote: >> On Thu, Jul 04, 2019 at 11:24:57AM +0100, Stefan Hajnoczi wrote: >>> On Wed, Jul 03, 2019 at 06:25:01PM +0100, Daniel P. Berrangé wrote: On Wed, Jul 03, 2019 at 07:10:05PM +0200,

Re: [Qemu-devel] pl031 time across vm save/reload

On 04/07/19 18:02, Peter Maydell wrote: > I've had a report that the way the PL031 model handles time > across a vm save/reload fails to correctly advance the guest > RTC when the host RTC has advanced between the save and reload. > I looked at the code and my correspondent's analysis (which > I qu

Re: [Qemu-devel] pl031 time across vm save/reload

On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > You're right, the compatibility causes wrong behavior for the default > -rtc settings (the RC pauses across migration). The right thing to do > would be to store the base rather than the offset: that is, you store > the time at which LR was writ

Re: [Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

On 05.07.19 11:32, Stefano Garzarella wrote: > This patch allows 'qemu-img info' to show the 'disk size' for > the RBD images that have the fast-diff feature enabled. > > If this feature is enabled, we use the rbd_diff_iterate2() API > to calculate the allocated size for the image. > > Signed-off

[Qemu-devel] [PATCH] ati-vga: Add registers for getting apertures

Some drivers (e.g. Linux radeon drm and MacOS) access these to find apertures to access card. Try to implement these but not sure these are correct yet. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 15 +++ hw/display/ati_dbg.c | 5 + hw/display/ati_regs.h | 5

Re: [Qemu-devel] pl031 time across vm save/reload

On 05/07/19 11:58, Peter Maydell wrote: > On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: >> You're right, the compatibility causes wrong behavior for the default >> -rtc settings (the RC pauses across migration). The right thing to do >> would be to store the base rather than the offset: that

[Qemu-devel] [PULL v3 00/19] testing/next for 4.1 (tests/vm, Travis and hyperv build fix)

The following changes since commit 57dfc2c4d51e770ed3f617e5d1456d1e2bacf3f0: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190704-1' into staging (2019-07-04 17:32:24 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testin

Re: [Qemu-devel] No symbols in LeakSanitizer output (was Re: [RFC PATCH 0/7] target/i386: support VMX features in "-cpu")

On 02/07/19 23:38, Eduardo Habkost wrote: > Can the asan build test in Patchew be updated to include > symbolize=1? > > For reference, below is the full stack trace of the leak. It > looks like it existed for a long time. Sure, just add the "export" lines to tests/docker/test-debug and Patchew w

[Qemu-devel] [PATCH v7] qemu-io: add pattern file for write command

The patch allows to provide a pattern file for write command. There was no similar ability before. Signed-off-by: Denis Plotnikov --- v7: * fix variable naming * make code more readable * extend help for write command v6: * the pattern file is read once to reduce io v5: * file name in

Re: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support

Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141

Re: [Qemu-devel] pl031 time across vm save/reload

On Fri, 5 Jul 2019 at 11:13, Paolo Bonzini wrote: > > On 05/07/19 11:58, Peter Maydell wrote: > > On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > >> You're right, the compatibility causes wrong behavior for the default > >> -rtc settings (the RC pauses across migration). The right thing to d

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

Gerd Hoffmann writes: > Instead of fetching the prebuilt image from patchew download the install > iso and prepare the image locally. Install to disk, using the serial > console. Create qemu user, configure ssh login. Install packages > needed for qemu builds. I've had to drop this from my

Re: [Qemu-devel] pl031 time across vm save/reload

On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: > By the way, the data sheet says "the counter and match values are > compared in a comparator. When both values are equal, the RTCINTR > interrupt is asserted HIGH"; QEMU compares the RTC value (read from > RTC_DR) and not the counter value, but L

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

On Wed, Jul 03, 2019 at 05:47:07PM -0500, Eric Blake wrote: > Although you generally won't use encryption with a Unix socket (after > all, everything is local, so why waste the CPU power), there are > situations in testsuites where Unix sockets are much nicer than TCP > sockets. Since nbdkit allow

Re: [Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block

On 7/2/19 7:23 PM, Paolo Bonzini wrote: > On 02/07/19 08:44, Shinichiro Kawasaki wrote: >> On 7/1/19 8:56 PM, Paolo Bonzini wrote: >>> On 01/07/19 12:14, Shinichiro Kawasaki wrote: I observe four of them listed below in sense data, when I ran basic operations to the zoned storage from the

Re: [Qemu-devel] pl031 time across vm save/reload

On 05/07/19 12:21, Peter Maydell wrote: > On Fri, 5 Jul 2019 at 11:13, Paolo Bonzini wrote: >> >> On 05/07/19 11:58, Peter Maydell wrote: >>> On Fri, 5 Jul 2019 at 10:48, Paolo Bonzini wrote: You're right, the compatibility causes wrong behavior for the default -rtc settings (the RC pau

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

On Fri, Jul 05, 2019 at 11:31:51AM +0200, Max Reitz wrote: > On 04.07.19 00:47, Eric Blake wrote: > > diff --git a/tests/qemu-iotests/233.out b/tests/qemu-iotests/233.out > > index 9b46284ab0de..b86bee020649 100644 > > --- a/tests/qemu-iotests/233.out > > +++ b/tests/qemu-iotests/233.out > > [.

Re: [Qemu-devel] [PATCH v2 RFC] qemu-nbd: Permit TLS with Unix sockets

On Wed, Jul 03, 2019 at 05:47:07PM -0500, Eric Blake wrote: > +== check TLS works over Unix == > +image: nbd+unix://?socket=SOCKET > +file format: nbd > +virtual size: 64 MiB (67108864 bytes) > +disk size: unavailable > +image: nbd+unix://?socket=SOCKET > +file format: nbd > +virtual size: 64 MiB

[Qemu-devel] [PATCH-for-4.1 v2] hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

Lei Sun found while auditing the code than a CPU write would trigger a NULL pointer deference. >From UG1085 datasheet [*] AXI writes in this region are ignored and generates an External Slave Error (SLVERR). Fix by checking the access is a READ before calling the region callback. [*] https://ww

Re: [Qemu-devel] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback

On Fri, Jul 05, 2019 at 11:58:43AM +0200, Max Reitz wrote: > On 05.07.19 11:32, Stefano Garzarella wrote: > > This patch allows 'qemu-img info' to show the 'disk size' for > > the RBD images that have the fast-diff feature enabled. > > > > If this feature is enabled, we use the rbd_diff_iterate2()

Re: [Qemu-devel] pl031 time across vm save/reload

On Fri, 5 Jul 2019 at 11:32, Paolo Bonzini wrote: > > On 05/07/19 12:21, Peter Maydell wrote: > > On Fri, 5 Jul 2019 at 11:13, Paolo Bonzini wrote: > >> Yes, something like that but I would just bump the version. Version 1 > >> has the old meaning for the first field, version 2 has the new meani

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

On 7/5/19 12:43 PM, Kamil Rytarowski wrote: > On 05.07.2019 12:24, Alex Bennée wrote: >> >> Gerd Hoffmann writes: >> >>> Instead of fetching the prebuilt image from patchew download the install >>> iso and prepare the image locally. Install to disk, using the serial >>> console. Create qemu user

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

On 05.07.2019 12:24, Alex Bennée wrote: > > Gerd Hoffmann writes: > >> Instead of fetching the prebuilt image from patchew download the install >> iso and prepare the image locally. Install to disk, using the serial >> console. Create qemu user, configure ssh login. Install packages >> needed

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

On Fri, 5 Jul 2019 at 11:43, Kamil Rytarowski wrote: > > On 05.07.2019 12:24, Alex Bennée wrote: > > > > Gerd Hoffmann writes: > > > >> Instead of fetching the prebuilt image from patchew download the install > >> iso and prepare the image locally. Install to disk, using the serial > >> console.

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

On 05.07.2019 12:47, Philippe Mathieu-Daudé wrote: > On 7/5/19 12:43 PM, Kamil Rytarowski wrote: >> On 05.07.2019 12:24, Alex Bennée wrote: >>> >>> Gerd Hoffmann writes: >>> Instead of fetching the prebuilt image from patchew download the install iso and prepare the image locally. Insta

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

On Fri, 5 Jul 2019 at 06:38, Marcel Apfelbaum wrote: > > At some point vmxnet3 live migration stopped working and git-bisect > didn't help finding a working version. > The issue is the PCI configuration space is not being migrated > successfully and MSIX remains masked at destination. > > Remove t

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

> On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: > > At some point vmxnet3 live migration stopped working and git-bisect > didn't help finding a working version. > The issue is the PCI configuration space is not being migrated > successfully and MSIX remains masked at destination. > > Remove

Re: [Qemu-devel] [PATCH v3 1/6] block/nvme: don't touch the completion entries

On 03.07.19 17:59, Maxim Levitsky wrote: > Completion entries are meant to be only read by the host and written by the > device. > The driver is supposed to scan the completions from the last point where it > left, > and until it sees a completion with non flipped phase bit. (Disclaimer: This is

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

On Fri, Jul 05, 2019 at 11:52:20AM +0100, Peter Maydell wrote: > On Fri, 5 Jul 2019 at 11:43, Kamil Rytarowski wrote: > > > > On 05.07.2019 12:24, Alex Bennée wrote: > > > > > > Gerd Hoffmann writes: > > > > > >> Instead of fetching the prebuilt image from patchew download the install > > >> iso

Re: [Qemu-devel] [PATCH v3 2/6] block/nvme: fix doorbell stride

On 03.07.19 17:59, Maxim Levitsky wrote: > Fix the math involving non standard doorbell stride > > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/nvme.c b/block/nvme.c > index 6d4e7f3d83..52798081b2 100644 > ---

Re: [Qemu-devel] [PATCH v4 09/11] tests/vm: netbsd autoinstall, using serial console

Peter Maydell writes: > On Fri, 5 Jul 2019 at 11:43, Kamil Rytarowski wrote: >> >> On 05.07.2019 12:24, Alex Bennée wrote: >> > >> > Gerd Hoffmann writes: >> > >> >> Instead of fetching the prebuilt image from patchew download the install >> >> iso and prepare the image locally. Install to d

Re: [Qemu-devel] [PATCH v3 2/6] block/nvme: fix doorbell stride

On 05.07.19 13:09, Max Reitz wrote: > On 03.07.19 17:59, Maxim Levitsky wrote: >> Fix the math involving non standard doorbell stride >> >> Signed-off-by: Maxim Levitsky >> --- >> block/nvme.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/nvme.c b/block/nvme.c

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman wrote: > > > > On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: > > > > At some point vmxnet3 live migration stopped working and git-bisect > > didn't help finding a working version. > > The issue is the PCI configuration space is not being migrated > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

On Friday 05 July 2019 12:07 AM, Greg Kurz wrote: > On Thu, 4 Jul 2019 10:49:05 +0530 > Aravinda Prasad wrote: > >> >> >> On Thursday 04 July 2019 06:42 AM, David Gibson wrote: >>> On Wed, Jul 03, 2019 at 02:30:31PM +0530, Aravinda Prasad wrote: On Wednesday 03 July 2019 08:50 A

Re: [Qemu-devel] [PATCH] hw/net: fix vmxnet3 live migration

On 7/5/19 2:14 PM, Sukrit Bhatnagar wrote: On Fri, 5 Jul 2019 at 16:29, Dmitry Fleytman wrote: On 5 Jul 2019, at 4:07, Marcel Apfelbaum wrote: At some point vmxnet3 live migration stopped working and git-bisect didn't help finding a working version. The issue is the PCI configuration spa

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

On Friday 05 July 2019 06:37 AM, David Gibson wrote: > On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 04 July 2019 06:37 AM, David Gibson wrote: >>> On Wed, Jul 03, 2019 at 02:58:24PM +0530, Aravinda Prasad wrote: On Wednesday 03 July 2019 08

Re: [Qemu-devel] [PATCH-for-4.1 v2] hw/ssi/xilinx_spips: Avoid AXI writes to the LQSPI linear memory

+-- On Fri, 5 Jul 2019, Philippe Mathieu-Daudé wrote --+ | +static bool lqspi_accepts(void *opaque, hwaddr addr, | + unsigned size, bool is_write, | + MemTxAttrs attrs) | +{ | +/* | + * From UG1085, Chapter 24 (Quad-SPI controllers): | +

[Qemu-devel] Unable to set register on qemu-system-sparc64 via gdbstub

Hi all, It looks as if the recent gdbstub code rework has broken the ability to set registers under qemu-system-sparc64: $ sparc64-linux-gdb obj-sparc64/openbios-builtin.elf.nostrip GNU gdb (GDB) 8.1 Copyright (C) 2018 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

Re: [Qemu-devel] [PATCH v3 3/6] block/nvme: support larger that 512 bytes sector devices

On 03.07.19 17:59, Maxim Levitsky wrote: > Currently the driver hardcodes the sector size to 512, > and doesn't check the underlying device. Fix that. > > Also fail if underlying nvme device is formatted with metadata > as this needs special support. > > Signed-off-by: Maxim Levitsky > --- > bl

Re: [Qemu-devel] [PATCH v3 4/6] block/nvme: add support for image creation

On 03.07.19 17:59, Maxim Levitsky wrote: > Tesed on a nvme device like that: > > # create preallocated qcow2 image > $ qemu-img create -f qcow2 nvme://:06:00.0/1 10G -o preallocation=metadata > Formatting 'nvme://:06:00.0/1', fmt=qcow2 size=10737418240 > cluster_size=65536 preallocation=m

  1   2   3   4   >