Patchew URL: https://patchew.org/QEMU/20190705083141.106254-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v22 00/22] Add RX archtecture support Message-id: 20190705083141.106254-1-ys...@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu 57dfc2c..c35d17c master -> master Switched to a new branch 'test' 7dc94c9 target/rx: remove unused functions. a1dcbc2 BootLinuxConsoleTest: Test the RX-Virt machine c9b115b Add rx-softmmu 29d1e47 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core 37d323b hw/rx: Honor -accel qtest 2e9f24e hw/rx: RX Target hardware definition c69c355 hw/char: RX62N serial communication interface (SCI) e1086fe hw/timer: RX62N internal timer modules d8646fd hw/intc: RX62N interrupt controller (ICUa) e858f68 target/rx: Dump bytes for each insn during disassembly 3a608c5 target/rx: Collect all bytes during disassembly 77d00da target/rx: Emit all disassembly in one prt() 101ed53 target/rx: Use prt_ldmi for XCHG_mr disassembly 6740c34 target/rx: Replace operand with prt_ldmi in disassembler 21b7801 target/rx: Disassemble rx_index_addr into a string c398a2a target/rx: RX disassembler e6c645d target/rx: CPU definition fa682af target/rx: TCG helper 7d10a82 target/rx: TCG translation 9fd4faa hw/registerfields.h: Add 8bit and 16bit register macros c77a02f qemu/bitops.h: Add extract8 and extract16 915fcf5 MAINTAINERS: Add RX === OUTPUT BEGIN === 1/22 Checking commit 915fcf5daaad (MAINTAINERS: Add RX) 2/22 Checking commit c77a02f0d111 (qemu/bitops.h: Add extract8 and extract16) 3/22 Checking commit 9fd4faa3b6a2 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 3/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/22 Checking commit 7d10a824502b (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 4/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/22 Checking commit fa682afe030b (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 5/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/22 Checking commit e6c645d92353 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #29: new file mode 100644 total: 0 errors, 1 warnings, 622 lines checked Patch 6/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/22 Checking commit c398a2afb28c (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 7/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/22 Checking commit 21b7801324f8 (target/rx: Disassemble rx_index_addr into a string) 9/22 Checking commit 6740c34a87e3 (target/rx: Replace operand with prt_ldmi in disassembler) 10/22 Checking commit 101ed537cf26 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 11/22 Checking commit 77d00da68ec6 (target/rx: Emit all disassembly in one prt()) 12/22 Checking commit 3a608c5b0661 (target/rx: Collect all bytes during disassembly) 13/22 Checking commit e858f6823e1e (target/rx: Dump bytes for each insn during disassembly) 14/22 Checking commit d8646fde162d (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 14/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/22 Checking commit e1086fe9b69d (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 15/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/22 Checking commit c69c355e0e1d (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 16/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/22 Checking commit 2e9f24e0f82b (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 479 lines checked Patch 17/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/22 Checking commit 37d323b91eef (hw/rx: Honor -accel qtest) 19/22 Checking commit 29d1e47b7769 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/22 Checking commit c9b115bd4c24 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 20/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/22 Checking commit a1dcbc2f2c44 (BootLinuxConsoleTest: Test the RX-Virt machine) 22/22 Checking commit 7dc94c9438c2 (target/rx: remove unused functions.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: deleted file mode 100644 total: 0 errors, 1 warnings, 5 lines checked Patch 22/22 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190705083141.106254-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com