[Qemu-devel] [PULL 1/1] console: fix cell overflow

2019-07-04 Thread Gerd Hoffmann
Linux terminal behavior (coming from vt100 I think) is somewhat strange when it comes to line wraps: When a character is printed to the last char cell of a line the cursor does NOT jump to the next line but stays where it is. The line feed happens when the next character is printed. So the valid

Re: [Qemu-devel] [PULL v2 00/20] testing/next for 4.1

2019-07-04 Thread Alex Bennée
Alex Bennée writes: > Peter Maydell writes: > >> On Tue, 2 Jul 2019 at 11:25, Alex Bennée wrote: >>> >>> The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: >>> >>> Merge remote-tracking branch >>> 'remotes/vivier2/tags/trivial-patches-pull-request' into staging >

[Qemu-devel] [PULL 0/1] Ui 20190704 patches

2019-07-04 Thread Gerd Hoffmann
The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' into staging (2019-07-02 18:56:44 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190704-pu

Re: [Qemu-devel] [PATCH v2] tests: numa-test: use -numa memdev option instead of legacy 'mem' option

2019-07-04 Thread Igor Mammedov
On Wed, 3 Jul 2019 16:37:02 -0300 Eduardo Habkost wrote: > On Wed, Jul 03, 2019 at 11:47:23AM -0400, Igor Mammedov wrote: > > it drops testing of deprecated 'mem' option and will test preferred memdev > > option instead. > > > > Signed-off-by: Igor Mammedov > > --- > > v2: > > - make backend

Re: [Qemu-devel] [PULL 0/1] Ui 20190704 patches

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190704070442.2277-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make do

Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 09:54, Gerd Hoffmann wrote: > > The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' > into staging (2019-07-02 18:56:44 +0100) > > are available in the Git repository at:

Re: [Qemu-devel] [PATCH v2 03/21] hw: timer: Add ASPEED RTC device

2019-07-04 Thread Joel Stanley
On Tue, 2 Jul 2019 at 19:19, Peter Maydell wrote: > > On Tue, 18 Jun 2019 at 17:53, Cédric Le Goater wrote: > > > > From: Joel Stanley > > > > The RTC is modeled to provide time and date functionality. It is > > initialised at zero to match the hardware. > > > > There is no modelling of the alar

Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703085416.21837-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190703085416.21837-1-kra...@redhat.com Subject: [Qemu-devel] [PULL 0/4] Vga 20190703 patch

[Qemu-devel] [PATCH v2 1/1] ati-vga: Fix reverse bit blts

2019-07-04 Thread BALATON Zoltan
The pixman library only supports blts with left to right, top to bottom order but the ATI VGA engine can also do different directions. Fix support for these via a temporary buffer for now. This fixes rendering issues related to such blts (such as moving windows) but some other glitches still remain

Re: [Qemu-devel] [PATCH for-4.2] xics/kvm: Convert assert() to error_setg()

2019-07-04 Thread Greg Kurz
On Thu, 4 Jul 2019 10:23:57 +1000 David Gibson wrote: > On Wed, Jul 03, 2019 at 07:50:12PM +0200, Greg Kurz wrote: > > ics_set_kvm_state_one() is called either during reset, in which case > > both 'saved priority' and 'current priority' are equal to 0xff, or > > during migration. In the latter ca

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-07-04 Thread Peter Xu
On Thu, Jul 04, 2019 at 01:45:41PM +0800, Jason Wang wrote: > > On 2019/6/24 下午5:18, Peter Xu wrote: > > This is an replacement work of Yan Zhao's patch: > > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > > > vtd_address_space_unmap() will do proper page mask alignment

[Qemu-devel] [PATCH 0/2] tests: acpi: improve tests reproducability

2019-07-04 Thread Igor Mammedov
series should help to make tests more reproducable and not depend on IASL being installed. IASL will be required only is user needs to get textual diff of mismatching files. Igor Mammedov (2): tests: acpi: do not require IASL for dumping AML blobs tests: acpi: do not skip tests when IASL is

[Qemu-devel] [PATCH 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Igor Mammedov
tests do binary comparition so we can check tables without IASL. Move IASL condition right before decompilation step and skip it if IASL is not installed. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH 1/2] tests: acpi: do not require IASL for dumping AML blobs

2019-07-04 Thread Igor Mammedov
IASL isn't needed when dumping ACPI tables from guest for rebuild purposes. So move this part out from IASL branch. Makes rebuild-expected-aml.sh work without IASL installed on host. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 10 -- 1 file changed, 4 insertions(+), 6 de

Re: [Qemu-devel] [PATCH] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-04 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Wednesday, July 3, 2019 6:31 PM > To: Zhang, Chen > Cc: Li Zhijian ; Jason Wang ; > qemu-dev ; Zhang Chen > Subject: Re: [PATCH] net/colo-compare.c: Fix memory leak and code style issue. > > On Wed, 3

Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703085416.21837-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190703085416.21837-1-kra...@redhat.com Subject: [Qemu-devel] [PULL 0/4] Vga 20190703 patch

[Qemu-devel] [PATCH] linux-user: check valid address in access_ok()

2019-07-04 Thread Laurent Vivier
From: Rémi Denis-Courmont Fix a crash with LTP testsuite and aarch64: tst_test.c:1015: INFO: Timeout per run is 0h 05m 00s qemu-aarch64: .../qemu/accel/tcg/translate-all.c:2522: page_check_range: Assertion `start < ((target_ulong)1 << L1_MAP_ADDR_SPACE_BITS)' failed. qemu:handle_cpu_signa

[Qemu-devel] [PATCH V2] net/colo-compare.c: Fix memory leak and code style issue.

2019-07-04 Thread Zhang Chen
From: Zhang Chen This patch to fix the origin "char *data" menory leak, code style issue and add necessary check here. Reported-by: Coverity (CID 1402785) Signed-off-by: Zhang Chen --- net/colo-compare.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-) diff

Re: [Qemu-devel] [PATCH] doc: document that the monitor console is a privileged control interface

2019-07-04 Thread Daniel P . Berrangé
On Wed, Jul 03, 2019 at 10:56:05PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > A supposed exploit of QEMU was recently announced as CVE-2019-12928 > > claiming that the monitor console was insecure because the "migrate" > > comand enabled arbitrary command execution for a remo

Re: [Qemu-devel] [PULL 0/4] Vga 20190703 patches

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703085416.21837-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190703085416.21837-1-kra...@redhat.com Subject: [Qemu-devel] [PULL 0/4] Vga 20190703 patch

Re: [Qemu-devel] [PATCH] doc: document that the monitor console is a privileged control interface

2019-07-04 Thread Alex Bennée
Daniel P. Berrangé writes: > On Wed, Jul 03, 2019 at 10:56:05PM +0100, Alex Bennée wrote: >> >> Daniel P. Berrangé writes: >> > The reality is that the monitor console (whether QMP or HMP) is >> > considered a privileged interface to QEMU and as such must only >> > be made available to truste

Re: [Qemu-devel] [PATCH] doc: document that the monitor console is a privileged control interface

2019-07-04 Thread Daniel P . Berrangé
On Thu, Jul 04, 2019 at 10:16:20AM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Wed, Jul 03, 2019 at 10:56:05PM +0100, Alex Bennée wrote: > >> > >> Daniel P. Berrangé writes: > > >> > The reality is that the monitor console (whether QMP or HMP) is > >> > considered a privi

Re: [Qemu-devel] [PATCH] doc: document that the monitor console is a privileged control interface

2019-07-04 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Jul 04, 2019 at 10:16:20AM +0100, Alex Bennée wrote: >> >> Daniel P. Berrangé writes: >> >> > On Wed, Jul 03, 2019 at 10:56:05PM +0100, Alex Bennée wrote: >> >> >> >> Daniel P. Berrangé writes: >> >> >> > The reality is that the monitor console (whether Q

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

2019-07-04 Thread Peter Maydell
On Tue, 2 Jul 2019 at 16:06, Michael S. Tsirkin wrote: > > The following changes since commit 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-24' > into staging (2019-07-01 11:28:28 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PATCH for 4.1] aspeed/timer: Provide back-pressure information for short periods

2019-07-04 Thread Philippe Mathieu-Daudé
CC'ing Stefan & Paolo for a non-ARM view on this... On 7/4/19 7:51 AM, Cédric Le Goater wrote: > From: Andrew Jeffery > > First up: This is not the way the hardware behaves. > > However, it helps resolve real-world problems with short periods being > used under Linux. Commit 4451d3f59f2a ("cloc

Re: [Qemu-devel] [PATCH 1/2] tests: acpi: do not require IASL for dumping AML blobs

2019-07-04 Thread Philippe Mathieu-Daudé
On 7/4/19 10:27 AM, Igor Mammedov wrote: > IASL isn't needed when dumping ACPI tables from guest for > rebuild purposes. So move this part out from IASL branch. > > Makes rebuild-expected-aml.sh work without IASL installed > on host. > > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathie

Re: [Qemu-devel] [PATCH] hw/ssi/xilinx_spips: add lqspi_write routine

2019-07-04 Thread Peter Maydell
On Thu, 4 Jul 2019 at 07:18, P J P wrote: > > +-- On Wed, 3 Jul 2019, no-re...@patchew.org wrote --+ > | Patchew URL: > https://patchew.org/QEMU/20190703190615.31436-1-ppan...@redhat.com/ > | > | This series failed the asan build test. Please find the testing commands and > | their output below.

Re: [Qemu-devel] [PATCH 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Philippe Mathieu-Daudé
On 7/4/19 10:27 AM, Igor Mammedov wrote: > tests do binary comparition so we can check tables without > IASL. Move IASL condition right before decompilation step > and skip it if IASL is not installed. > > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 15 ++- > 1 fi

Re: [Qemu-devel] [PATCH v3 0/3] char-socket: Fix race condition

2019-07-04 Thread Paolo Bonzini
On 03/07/19 19:51, Max Reitz wrote: > On 05.06.19 21:36, Max Reitz wrote: >> On 26.04.19 09:51, Paolo Bonzini wrote: >>> On 23/04/19 18:55, Daniel P. Berrangé wrote: ping - paolo/marc-andré - unless I'm missing something, it looks like this chardev series slipped through the cracks and mi

Re: [Qemu-devel] [PULL 0/6] qemu-sparc queue 20190702

2019-07-04 Thread Peter Maydell
On Tue, 2 Jul 2019 at 23:18, Mark Cave-Ayland wrote: > > The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' > into staging (2019-07-02 18:56:44 +0100) > > are available in the git repository a

Re: [Qemu-devel] [PATCH] hw/ssi/xilinx_spips: add lqspi_write routine

2019-07-04 Thread Philippe Mathieu-Daudé
Cc'ing the Xilinx folks. On 7/3/19 9:06 PM, P J P wrote: > From: Prasad J Pandit > > Define skeleton lqspi_write routine. Avoid NULL dereference. > > Reported-by: Lei Sun I wish reporters give more information about their findings, that would help understanding the fix is correct, or how we c

Re: [Qemu-devel] [PATCH for 4.1] aspeed/timer: Provide back-pressure information for short periods

2019-07-04 Thread Stefan Hajnoczi
On Thu, Jul 04, 2019 at 11:26:53AM +0200, Philippe Mathieu-Daudé wrote: > CC'ing Stefan & Paolo for a non-ARM view on this... I'm not familiar with the various clock smoothing techniques implemented in QEMU and KVM, but this looks okay given that Linux guests expect this. Stefan signature.asc D

Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time

2019-07-04 Thread Alex Bennée
Richard Henderson writes: > On 7/3/19 5:52 PM, Alex Bennée wrote: >> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8) >> +{ >> +if (arm_dc_feature(s, ARM_FEATURE_M) && >> +semihosting_enabled() && >> +#ifndef CONFIG_USER_ONLY >> +s->current_el != 0 && >> +#endif

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-04 Thread Stefan Hajnoczi
On Wed, Jul 03, 2019 at 06:25:01PM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 03, 2019 at 07:10:05PM +0200, Philippe Mathieu-Daudé wrote: > > @@ -306,6 +308,13 @@ bool trace_init_backends(void) > > openlog(NULL, LOG_PID, LOG_DAEMON); > > #endif > > > > +trace_init_file(getenv("QEMU_

Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time

2019-07-04 Thread Philippe Mathieu-Daudé
On 7/4/19 12:21 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 7/3/19 5:52 PM, Alex Bennée wrote: >>> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8) >>> +{ >>> +if (arm_dc_feature(s, ARM_FEATURE_M) && >>> +semihosting_enabled() && >>> +#ifndef CONFIG_U

Re: [Qemu-devel] [RFC PATCH-for-4.2] tracing: Allow to tune tracing options via the environment

2019-07-04 Thread Daniel P . Berrangé
On Thu, Jul 04, 2019 at 11:24:57AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 03, 2019 at 06:25:01PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 03, 2019 at 07:10:05PM +0200, Philippe Mathieu-Daudé wrote: > > > @@ -306,6 +308,13 @@ bool trace_init_backends(void) > > > openlog(NULL, LOG_P

Re: [Qemu-devel] [PATCH 0/2] hw/timer/m48t59: Convert to trace events

2019-07-04 Thread Philippe Mathieu-Daudé
ping? On 6/26/19 2:20 PM, Philippe Mathieu-Daudé wrote: > Another trivial cleanup series. > > Philippe Mathieu-Daudé (2): > MAINTAINERS: Add missing m48t59 files to the PReP section > hw/timer/m48t59: Convert debug printf()s to trace events > > MAINTAINERS| 2 ++ > hw/timer

Re: [Qemu-devel] [PULL] RISC-V Patches for the 4.1 Soft Freeze, Part 2 v3

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 09:41, Palmer Dabbelt wrote: > > merged tag 'mips-queue-jun-21-2019' > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 > 15:40:50 +0100

Re: [Qemu-devel] [PATCH] hw/ssi/xilinx_spips: add lqspi_write routine

2019-07-04 Thread Peter Maydell
On Thu, 4 Jul 2019 at 11:11, Philippe Mathieu-Daudé wrote: > However, looking at the datasheet 'UG1085 (v1.0) November 24, 2015', > Chapter 22: Quad-SPI Controller, I understand this region is only > accessible by the CPU in READ mode, as an AXI slave. > > So, if we model this, even logging LOG_GU

Re: [Qemu-devel] [PULL 00/22] virtio, pc, pci: features, fixes, cleanups

2019-07-04 Thread Pankaj Gupta
> > > > The following changes since commit > > 7fec76a02267598a4e437ddfdaeaeb6de09b92f3: > > > > Merge remote-tracking branch > > 'remotes/maxreitz/tags/pull-block-2019-06-24' into staging (2019-07-01 > > 11:28:28 +0100) > > > > are available in the Git repository at: > > > > git://git.ke

[Qemu-devel] [Bug 1834113] Re: QEMU touchpad input erratic after wakeup from sleep

2019-07-04 Thread Christian Ehrhardt 
Hi Avi, for the sake of giving it a try I had a second level guest and suspended/resumed the first level guest a few times. I can't reproduce it. OTOH you seem to have a hard time to identify which change introduced this - if it was any change at all and not just by accident not showing up before

Re: [Qemu-devel] [PULL 0/4] Python queue, 2019-07-01

2019-07-04 Thread Peter Maydell
On Mon, 1 Jul 2019 at 23:29, Eduardo Habkost wrote: > > The following changes since commit 7d0e02405fc02a181319b1ab8681d2f72246b7c6: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-patches-pull-request' into staging (2019-07-01 > 17:40:32 +0100) > > are available in the Git re

Re: [Qemu-devel] [PATCH 1/2] tests: acpi: do not require IASL for dumping AML blobs

2019-07-04 Thread Auger Eric
Hi Igor, On 7/4/19 10:27 AM, Igor Mammedov wrote: > IASL isn't needed when dumping ACPI tables from guest for > rebuild purposes. So move this part out from IASL branch. > > Makes rebuild-expected-aml.sh work without IASL installed > on host. > > Signed-off-by: Igor Mammedov > --- > tests/bios

Re: [Qemu-devel] [PATCH 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Auger Eric
Hi, On 7/4/19 10:27 AM, Igor Mammedov wrote: > tests do binary comparition so we can check tables without comparison > IASL. Move IASL condition right before decompilation step > and skip it if IASL is not installed. > > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 15 +++

Re: [Qemu-devel] [PATCH for 4.1] aspeed/timer: Provide back-pressure information for short periods

2019-07-04 Thread Paolo Bonzini
On 04/07/19 12:13, Stefan Hajnoczi wrote: > On Thu, Jul 04, 2019 at 11:26:53AM +0200, Philippe Mathieu-Daudé wrote: >> CC'ing Stefan & Paolo for a non-ARM view on this... > > I'm not familiar with the various clock smoothing techniques implemented > in QEMU and KVM, but this looks okay given that

[Qemu-devel] [PATCH v2 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Igor Mammedov
tests do binary comparision so we can check tables without IASL. Move IASL condition right before decompilation step and skip it if IASL is not installed. Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Reviewed-by: Philippe Mathieu-Daudé --- v2: - fix typo in commit message Eric Aug

Re: [Qemu-devel] [PATCH 2/2] tests: acpi: do not skip tests when IASL is not installed

2019-07-04 Thread Igor Mammedov
On Thu, 4 Jul 2019 11:33:19 +0200 Philippe Mathieu-Daudé wrote: > On 7/4/19 10:27 AM, Igor Mammedov wrote: > > tests do binary comparition so we can check tables without > > IASL. Move IASL condition right before decompilation step > > and skip it if IASL is not installed. > > > > Signed-off-by:

[Qemu-devel] [PATCH v2 1/1] raw-posix.c - use max transfer length / max segement count only for SCSI passthrough

2019-07-04 Thread Maxim Levitsky
Regular kernel block devices (/dev/sda*, /dev/nvme*, etc) don't have max segment size/max segment count hardware requirements exposed to the userspace, but rather the kernel block layer takes care to split the incoming requests that violate these requirements. Allowing the kernel to do the splitti

[Qemu-devel] [PATCH v2 0/1] Don't obey the kernel block device max transfer len / max segments for raw block devices

2019-07-04 Thread Maxim Levitsky
Linux block devices, even in O_DIRECT mode don't have any user visible limit on transfer size / number of segments, which underlying kernel block device can have. The kernel block layer takes care of enforcing these limits by splitting the bios. By limiting the transfer sizes, we force qemu to d

Re: [Qemu-devel] [PULL 0/2] vfio fixes 2019-07-02

2019-07-04 Thread Peter Maydell
On Tue, 2 Jul 2019 at 23:36, Alex Williamson wrote: > > The following changes since commit 506179e42112be77bfd071f050b15762d3b2cd43: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190702' > into staging (2019-07-02 18:56:44 +0100) > > are available in the Git repository at

Re: [Qemu-devel] [PULL 27/27] hw/block/pflash_cfi02: Reduce I/O accesses to 16-bit

2019-07-04 Thread Philippe Mathieu-Daudé
Cc'ing PPC/taihu_405ep and ARM/Digic4 maintainers. On 7/3/19 6:36 PM, Philippe Mathieu-Daudé wrote: > On 7/3/19 6:20 PM, Stephen Checkoway wrote: >>> On Jul 3, 2019, at 12:02, Philippe Mathieu-Daudé wrote: >>> On 7/3/19 5:52 PM, Stephen Checkoway wrote: > On Jul 1, 2019, at 20:59, P

[Qemu-devel] [PATCH v2 00/14] target/arm/kvm: enable SVE in guests

2019-07-04 Thread Zhang, Lei
Hi Andrew, This patch series works fine for my use cases. Please feel free to add. Tested-by: Zhang, Lei I suppose v3 patches will be released. I'm looking forward to the v3 patches. Best Regards, Lei Zhang

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Marc-André Lureau
Hi On Thu, May 16, 2019 at 1:04 AM Paolo Bonzini wrote: > > From: Vitaly Kuznetsov > > It was found that Hyper-V 2016 on KVM in some configurations (q35 machine + > piix4-usb-uhci) hangs on boot. Root-cause was that one of Hyper-V > level-triggered interrupt handler performs EOI before fixing th

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Li Qiang
I have posted a fix for this several weeks ago: -->https://www.mail-archive.com/qemu-devel@nongnu.org/msg626186.html Thanks, Li Qiang Marc-André Lureau 于2019年7月4日周四 下午8:57写道: > Hi > > On Thu, May 16, 2019 at 1:04 AM Paolo Bonzini wrote: > > > > From: Vitaly Kuznetsov > > > > It was found th

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Marc-André Lureau
Hi On Thu, Jul 4, 2019 at 5:01 PM Li Qiang wrote: > > I have posted a fix for this several weeks ago: > > -->https://www.mail-archive.com/qemu-devel@nongnu.org/msg626186.html Your patch looks reasonable, but I am not really able to review it. I hope Paolo and Vitaly will take care of it. Thank

Re: [Qemu-devel] [PATCH v2 03/21] hw: timer: Add ASPEED RTC device

2019-07-04 Thread Peter Maydell
On Thu, 4 Jul 2019 at 08:49, Joel Stanley wrote: > > On Tue, 2 Jul 2019 at 19:19, Peter Maydell wrote: > > > > On Tue, 18 Jun 2019 at 17:53, Cédric Le Goater wrote: > > > > > > From: Joel Stanley > > > > > > The RTC is modeled to provide time and date functionality. It is > > > initialised at z

Re: [Qemu-devel] [PULL 18/21] build: don't build hardware objects with linux-user

2019-07-04 Thread Philippe Mathieu-Daudé
On 5/21/19 10:16 PM, Laurent Vivier wrote: > On 21/05/2019 14:54, Daniel P. Berrangé wrote: >> On Tue, May 21, 2019 at 02:52:42PM +0200, Laurent Vivier wrote: >>> On 21/05/2019 13:52, Daniel P. Berrangé wrote: On Wed, May 15, 2019 at 10:50:30PM +0200, Paolo Bonzini wrote: > From: Laurent V

[Qemu-devel] [PATCH v2 3/3] qcow2: add zstd cluster compression

2019-07-04 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, by the moment, has been the only compression method available. The performance test results: Test compresses and decompres

[Qemu-devel] [PATCH v2 2/3] qcow2: rework the cluster compression routine

2019-07-04 Thread Denis Plotnikov
The patch allow to process image compression type defined in the image header and choose an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 93 --- 1 file changed, 73 insertions(+), 20 delet

[Qemu-devel] [PATCH v2 0/3] add zstd cluster compression

2019-07-04 Thread Denis Plotnikov
change log: v2: * relax the compression type setting restriction in the spec * fix qcow2 header size checking * fix error processing and messaging * fix qcow2 image specific info reporting * set Qcow2CompressionType zstd config dependant * add zstd compressed cluster format

[Qemu-devel] [PATCH v2 1/3] qcow2: introduce compression type feature

2019-07-04 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

Re: [Qemu-devel] [PULL 19/21] ioapic: allow buggy guests mishandling level-triggered interrupts to make progress

2019-07-04 Thread Paolo Bonzini
On 04/07/19 15:05, Marc-André Lureau wrote: > Hi > > On Thu, Jul 4, 2019 at 5:01 PM Li Qiang wrote: >> >> I have posted a fix for this several weeks ago: >> >> -->https://www.mail-archive.com/qemu-devel@nongnu.org/msg626186.html > > Your patch looks reasonable, but I am not really able to review

[Qemu-devel] hw/display/vga: Why architecture specific code?

2019-07-04 Thread Philippe Mathieu-Daudé
Hi Gerd, I'm looking at: static const MemoryRegionPortio vbe_portio_list[] = { { 0, 1, 2, .read = vbe_ioport_read_index, .write = vbe_ioport_write_index }, # ifdef TARGET_I386 { 1, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data }, # endif { 2, 1, 2, .read = vbe_iop

Re: [Qemu-devel] [PULL 0/1] Audio 20190703 patches

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 07:57, Gerd Hoffmann wrote: > > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 > 15:40:50 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PULL v5 00/43] Machine and x86 queue, 2019-07-03

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 22:08, Eduardo Habkost wrote: > > Changes v4 -> v5: > * Rebase and solve conflicts with commit 374f63f6810a ("Merge remote-tracking > branch 'remotes/armbru/tags/pull-monitor-2019-07-02-v2' into staging") > > Changes v3 -> v4: > * Fix ppc64 "make check" failure > > Changes

Re: [Qemu-devel] hw/display/vga: Why architecture specific code?

2019-07-04 Thread Gerd Hoffmann
On Thu, Jul 04, 2019 at 03:27:25PM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > I'm looking at: > > static const MemoryRegionPortio vbe_portio_list[] = { > { 0, 1, 2, .read = vbe_ioport_read_index, .write = > vbe_ioport_write_index }, > # ifdef TARGET_I386 > { 1, 1, 2, .read = vbe_

Re: [Qemu-devel] hw/display/vga: Why architecture specific code?

2019-07-04 Thread Paolo Bonzini
On 04/07/19 15:55, Gerd Hoffmann wrote: > On Thu, Jul 04, 2019 at 03:27:25PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Gerd, >> >> I'm looking at: >> >> static const MemoryRegionPortio vbe_portio_list[] = { >> { 0, 1, 2, .read = vbe_ioport_read_index, .write = >> vbe_ioport_write_index }, >> #

Re: [Qemu-devel] [PATCH v3 1/6] accel/tcg: adding structure to store TB statistics

2019-07-04 Thread Alex Bennée
vandersonmr writes: > We want to store statistics for each TB even after flushes. > We do not want to modify or grow the TB struct. > So we create a new struct to contain this statistics and > we link one of it to each TB as they are generated. Mini note, what happened to the cover letter? --

Re: [Qemu-devel] [PATCH v3 1/6] accel/tcg: adding structure to store TB statistics

2019-07-04 Thread Alex Bennée
vandersonmr writes: > We want to store statistics for each TB even after flushes. > We do not want to modify or grow the TB struct. > So we create a new struct to contain this statistics and > we link one of it to each TB as they are generated. > > Signed-off-by: Vanderson M. do Rosario > ---

Re: [Qemu-devel] [PATCH v2] qapi: report the default CPU type for each machine

2019-07-04 Thread Daniel P . Berrangé
ping, any comments / thoughts ? On Wed, Jun 12, 2019 at 01:41:25PM +0200, Daniel P. Berrangé wrote: > When user doesn't request any explicit CPU model with libvirt or QEMU, > a machine type specific CPU model is picked. Currently there is no way > to determine what this QEMU built-in default is,

[Qemu-devel] [PATCH for-4.1] hw/arm/sbsa-ref: Remove unnecessary check for secure_sysmem == NULL

2019-07-04 Thread Peter Maydell
In the virt machine, we support TrustZone being either present or absent, and so the code must deal with the secure_sysmem pointer possibly being NULL. In the sbsa-ref machine, TrustZone is always present, but some code and comments copied from virt still treat it as possibly not being present. Th

Re: [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > drive-backup and blockdev-backup have an awful lot of things in common > that are the same. Let's fix that. > > I don't deduplicate 'target', because the semantics actually did change > between each structure. Leave that one alone so it can be documented > sep

Re: [Qemu-devel] [PATCH v2] qapi: report the default CPU type for each machine

2019-07-04 Thread Igor Mammedov
On Wed, 12 Jun 2019 13:41:25 +0200 Daniel P. Berrangé wrote: > When user doesn't request any explicit CPU model with libvirt or QEMU, > a machine type specific CPU model is picked. Currently there is no way > to determine what this QEMU built-in default is, so libvirt cannot > report this back to

Re: [Qemu-devel] [PATCH] target/i386: kvm: Fix when nested state is needed for migration

2019-07-04 Thread Liran Alon
> On 2 Jul 2019, at 19:39, Paolo Bonzini wrote: > > On 25/06/19 01:05, Liran Alon wrote: >> When vCPU is in VMX operation and enters SMM mode, >> it temporarily exits VMX operation but KVM maintained nested-state >> still stores the VMXON region physical address, i.e. even when the >> vCPU is

[Qemu-devel] [PATCH for 4.1] linux-user: Fix structure target_ucontext for MIPS

2019-07-04 Thread Aleksandar Markovic
From: Aleksandar Markovic Structure ucontext for MIPS is defined in the following way in Linux kernel: (arch/mips/include/uapi/asm/ucontext.h, lines 54-64) struct ucontext { /* Historic fields matching asm-generic */ unsigned long uc_flags; struct ucontext *uc_link; st

Re: [Qemu-devel] [PULL v2 00/20] testing/next for 4.1

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 00:02, Peter Maydell wrote: > NetBSD vm run seemed to get stuck. I tired a rerun, but it got stuck again on the "pkgin -y install git-base pkgconf xz python37 bash gmake gsed flex bison gnutls jpeg png SDL2 gtk3+ libxkbcommon" step. thanks -- PMM

Re: [Qemu-devel] [PATCH v2 02/18] drive-backup: create do_backup_common

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Create a common core that comprises the actual meat of what the backup API > boundary needs to do, and then switch drive-backup to use it. > > Questions: > - do_drive_backup now acquires and releases the aio_context in addition >to do_backup_common doing

Re: [Qemu-devel] [PATCH v2 03/18] blockdev-backup: utilize do_backup_common

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Signed-off-by: John Snow > --- > blockdev.c | 73 +++--- > 1 file changed, 3 insertions(+), 70 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode

2019-07-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190703215542.16123-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode Type: series Message-id: 20190703215542.1

Re: [Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Depending on what a user is trying to accomplish, there might be a few > bitmap cleanup actions that occur when an operation is finished that > could be useful. > > I am proposing three: > - NEVER: The bitmap is never synchronized against what was copied. > -

[Qemu-devel] question:about introduce a new feature named “I/O hang”

2019-07-04 Thread wangjie (P)
Hi, everybody: I developed a feature named "I/O hang",my intention is to solve the problem like that: If the backend storage media of VM disk is far-end storage like IPSAN or FCSAN, storage net link will always disconnection and make I/O requests return EIO to Guest, and the status of filesyste

Re: [Qemu-devel] [PATCH v3 2/6] accel/tcg: Adding an optional tb execution counter

2019-07-04 Thread Alex Bennée
vandersonmr writes: > We add the option to instrument each TB to > count the number of times it is executed and > store this in the its TBStatistics struct. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/tcg-runtime.c | 7 +++ > accel/tcg/tcg-runtime.h | 2 ++ > accel/tc

Re: [Qemu-devel] [PATCH] target/i386: kvm: Fix when nested state is needed for migration

2019-07-04 Thread Paolo Bonzini
On 04/07/19 16:31, Liran Alon wrote: > > >> On 2 Jul 2019, at 19:39, Paolo Bonzini wrote: >> >> On 25/06/19 01:05, Liran Alon wrote: >>> When vCPU is in VMX operation and enters SMM mode, >>> it temporarily exits VMX operation but KVM maintained nested-state >>> still stores the VMXON region phy

Re: [Qemu-devel] [PATCH v2 05/18] block/backup: Add mirror sync mode 'bitmap'

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > We don't need or want a new sync mode for simple differences in > semantics. Create a new mode simply named "BITMAP" that is designed to > make use of the new Bitmap Sync Mode field. > > Because the only bitmap mode is 'conditional', this adds no new > functi

Re: [Qemu-devel] [PATCH v2 06/18] block/backup: add 'never' policy to bitmap sync mode

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > This adds a "never" policy for bitmap synchronization. Regardless of if > the job succeeds or fails, we never update the bitmap. This can be used > to perform differential backups, or simply to avoid the job modifying a > bitmap. > > Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH] target/i386: kvm: Fix when nested state is needed for migration

2019-07-04 Thread Liran Alon
> On 4 Jul 2019, at 18:29, Paolo Bonzini wrote: > > On 04/07/19 16:31, Liran Alon wrote: >> >> >>> On 2 Jul 2019, at 19:39, Paolo Bonzini wrote: >>> >>> On 25/06/19 01:05, Liran Alon wrote: When vCPU is in VMX operation and enters SMM mode, it temporarily exits VMX operation but

[Qemu-devel] [PATCH] xen: Fix ring.h header

2019-07-04 Thread Anthony PERARD
The xen_[rw]?mb() macros defined in ring.h can't be used and the fact that there are gated behind __XEN_INTERFACE_VERSION__ means that it needs to be defined somewhere. QEMU doesn't implement interfaces with the Xen hypervisor so defining __XEN_INTERFACE_VERSION__ is pointless. This leads to: i

Re: [Qemu-devel] [PATCH v2 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Nobody calls the function like this currently, but we neither prohibit > or cope with this behavior. I decided to make the function cope with it. > > Signed-off-by: John Snow > --- > util/hbitmap.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 de

Re: [Qemu-devel] [PATCH v3 3/6] accel/tcg: Collecting translation/code quality measurements

2019-07-04 Thread Alex Bennée
vandersonmr writes: > Filling other tb statistics such as number of times the > tb is compiled, its number of guest/host/IR instructions... > > Signed-off-by: vandersonmr > --- > accel/tcg/translate-all.c | 14 + > accel/tcg/translator.c| 4 ++ > disas.c | 107 +++

Re: [Qemu-devel] [PATCH v3 4/6] util/log: introduce dump of tbstats and -d hot_tbs:limit

2019-07-04 Thread Alex Bennée
vandersonmr writes: > add option to dump the N most hot TB blocks. > -d hot_tbs:N > and also add all tbstats dump functions. > > Signed-off-by: Vanderson M. do Rosario > --- > accel/tcg/Makefile.objs | 1 + > accel/tcg/tb-stats.c | 293 +++ > inc

Re: [Qemu-devel] [PULL v2 0/4] Build system patches for 2019-07-02

2019-07-04 Thread Peter Maydell
On Wed, 3 Jul 2019 at 12:49, Markus Armbruster wrote: > > The following changes since commit ab200dafc0e8a9925bb0ad0be478621f5f117c95: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-07-02 10:17:54 +0100) > > are available in the Git repository a

Re: [Qemu-devel] [PATCH v2 08/18] hbitmap: enable merging across granularities

2019-07-04 Thread Max Reitz
On 03.07.19 23:55, John Snow wrote: > Signed-off-by: John Snow > --- > util/hbitmap.c | 36 +++- > 1 file changed, 35 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

[Qemu-devel] pl031 time across vm save/reload

2019-07-04 Thread Peter Maydell
I've had a report that the way the PL031 model handles time across a vm save/reload fails to correctly advance the guest RTC when the host RTC has advanced between the save and reload. I looked at the code and my correspondent's analysis (which I quote below, lightly edited) looks correct to me, bu

[Qemu-devel] [PULL 2/9] target/arm: Restrict semi-hosting to TCG

2019-07-04 Thread Peter Maydell
From: Philippe Mathieu-Daudé Per Peter Maydell: Semihosting hooks either SVC or HLT instructions, and inside KVM both of those go to EL1, ie to the guest, and can't be trapped to KVM. Let check_for_semihosting() return False when not running on TCG. Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 0/9] target-arm queue

2019-07-04 Thread Peter Maydell
people/pmaydell/qemu-arm.git tags/pull-target-arm-20190704 for you to fetch changes up to b75f3735802b5b33f10e4bfe374d4b17bb86d29a: target/arm: Correct VMOV_imm_dp handling of short vectors (2019-07-04 16:52:05 +0100) target-arm

Re: [Qemu-devel] [PULL 33/34] roms: Add OpenSBI version 0.3

2019-07-04 Thread Stefan Hajnoczi
On Mon, Jul 01, 2019 at 07:01:12PM +0100, Peter Maydell wrote: > On Mon, 1 Jul 2019 at 18:50, Alistair Francis > wrote: > > > > On Mon, 2019-07-01 at 17:54 +0100, Peter Maydell wrote: > > > On Thu, 27 Jun 2019 at 16:24, Palmer Dabbelt > > > wrote: > > > > From: Alistair Francis > > > Also, new

[Qemu-devel] [PULL 7/9] hw/timer/armv7m_systick: Forbid non-privileged accesses

2019-07-04 Thread Peter Maydell
Like most of the v7M memory mapped system registers, the systick registers are accessible to privileged code only and user accesses must generate a BusFault. We implement that for registers in the NVIC proper already, but missed it for systick since we implement it as a separate device. Correct the

[Qemu-devel] [PULL 5/9] target/arm: v8M: Check state of exception being returned from

2019-07-04 Thread Peter Maydell
In v8M, an attempt to return from an exception which is not active is an illegal exception return. For this purpose, exceptions which can configurably target either Secure or NonSecure are not considered to be active if they are configured for the opposite security state for the one we're trying to

[Qemu-devel] [PULL 1/9] target/arm: Move debug routines to debug_helper.c

2019-07-04 Thread Peter Maydell
From: Philippe Mathieu-Daudé These routines are TCG specific. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20190701194942.10092-2-phi...@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/Makefile.objs | 2 +- target/arm/cpu.c | 9 +- target/

[Qemu-devel] [PULL 6/9] target/arm: Use _ra versions of cpu_stl_data() in v7M helpers

2019-07-04 Thread Peter Maydell
In the various helper functions for v7M/v8M instructions, use the _ra versions of cpu_stl_data() and friends. Otherwise we may get wrong behaviour or an assert() due to not being able to locate the TB if there is an exception on the memory access or if it performs an IO operation when in icount mod

  1   2   >