[Qemu-devel] [PATCH v3 2/5] tricore: add UTOF instruction

2019-06-24 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski Reviewed-by: Bastian Koppelmann --- target/tricore/fpu_helper.c | 16 target/tricore/helper.h |

[Qemu-devel] [PATCH v3 5/5] tricore: add QSEED instruction

2019-06-24 Thread David Brenken
From: Andreas Konopik Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 84 + target/tricore/helper.h | 1 + targe

[Qemu-devel] [PATCH v3 4/5] tricore: sync ctx.hflags with tb->flags

2019-06-24 Thread David Brenken
From: Georg Hofstetter Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/tricore/translate.c b/targ

[Qemu-devel] [PATCH v3 1/5] tricore: add FTOIZ instruction

2019-06-24 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski Reviewed-by: Bastian Koppelmann --- target/tricore/fpu_helper.c | 25 + target/tricore/helper.

[Qemu-devel] [PATCH v3 3/5] tricore: fix RRPW_INSERT instruction

2019-06-24 Thread David Brenken
From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski Reviewed-by: Bastian Koppelmann --- target/tricore/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [Qemu-devel] [PATCH] memory: warning on out of scope notification

2019-06-24 Thread Auger Eric
Hi Yan, On 6/24/19 7:33 AM, Yan Zhao wrote: > if an entry has parts out of scope of notifier's range, print warning > message. > > Out of scope mapping/unmapping would cause problem, as in below case: > > 1. initially there are two notifiers with ranges > 0-0xfedf, 0xfef0-0xf

[Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing

2019-06-24 Thread David Brenken
From: David Brenken Hello everyone, as discussed here is the third version of the patchset. - We finalized the implementation of QSEED according to Bastians annotations. - We do only sync ctx.hflags with tb->flags. Best regards David Andreas Konopik (1): tricore: add QSEED instruction Dav

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Yan Zhao
On Mon, Jun 24, 2019 at 02:57:50PM +0800, Peter Xu wrote: > On Mon, Jun 24, 2019 at 02:41:22AM -0400, Yan Zhao wrote: > > On Mon, Jun 24, 2019 at 02:37:33PM +0800, Peter Xu wrote: > > > From: Paolo Bonzini > > > > > > This is an replacement work of Yan Zhao's patch: > > > > > > https://www.mail-

Re: [Qemu-devel] [PATCH 1/2] intel_iommu: Fix incorrect "end" for vtd_address_space_unmap

2019-06-24 Thread Auger Eric
Hi Peter, On 6/24/19 8:37 AM, Peter Xu wrote: > From: Yan Zhao > > IOMMUNotifier is with inclusive ranges, so we should check > against (VTD_ADDRESS_SIZE(s->aw_bits) - 1). > > Signed-off-by: Yan Zhao > [peterx: split from another bigger patch] > Signed-off-by: Peter Xu Reviewed-by: Eric Auger

Re: [Qemu-devel] [PATCH] spapr_pci: Unregister listeners before destroying the IOMMU address space

2019-06-24 Thread Alexey Kardashevskiy
On 21/06/2019 19:27, Greg Kurz wrote: > Hot-unplugging a PHB with a VFIO device connected to it crashes QEMU: > > -device spapr-pci-host-bridge,index=1,id=phb1 \ > -device vfio-pci,host=0034:01:00.3,id=vfio0 > > (qemu) device_del phb1 > [ 357.207183] iommu: Removing device 0001:00:00.0 from g

Re: [Qemu-devel] [PATCH] memory: warning on out of scope notification

2019-06-24 Thread Yan Zhao
On Mon, Jun 24, 2019 at 03:09:24PM +0800, Auger Eric wrote: > Hi Yan, > > On 6/24/19 7:33 AM, Yan Zhao wrote: > > if an entry has parts out of scope of notifier's range, print warning > > message. > > > > Out of scope mapping/unmapping would cause problem, as in below case: > > > > 1. initially

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

2019-06-24 Thread Klaus Birkelund
On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > On 06/17/19 10:12, Klaus Birkelund wrote: > > Hi all, > > > > I'm thinking about how to support multiple namespaces in the NVMe > > device. My first idea was to add a "namespaces" property array to the > > device that references block

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
On Mon, Jun 24, 2019 at 03:04:50AM -0400, Yan Zhao wrote: [...] > I think it might be helpful if there anything wrong in code. > for example, when previously, size = end - start, it will happen that > size will eventually be less than page size. Well, if with such an error we'd better fix it rig

Re: [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing

2019-06-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190624070339.4408-1-david.bren...@efs-auto.org/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commi

[Qemu-devel] [PATCH v2] memory: warning on out of scope notification

2019-06-24 Thread Yan Zhao
if an entry has parts out of scope of notifier's range, print warning message. Out of scope mapping/unmapping would cause problem, as in below case: 1. initially there are two notifiers with ranges 0-0xfedf, 0xfef0-0x, IOVAs from 0x3c00 - 0x3c1f is in shadow page t

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Yan Zhao
Tested-by: Yan Zhao On Mon, Jun 24, 2019 at 02:37:33PM +0800, Peter Xu wrote: > From: Paolo Bonzini > > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to ma

Re: [Qemu-devel] [PATCH] Makefile: Rename the 'vm-test' target as 'vm-help'

2019-06-24 Thread Stefano Garzarella
On Thu, Jun 20, 2019 at 01:03:28PM +0200, Philippe Mathieu-Daudé wrote: > Hi Stefano, > > On 5/31/19 9:38 AM, Stefano Garzarella wrote: > > On Fri, May 31, 2019 at 08:43:41AM +0200, Philippe Mathieu-Daudé wrote: > >> We already have 'make check-help', use the 'make vm-help' form > >> to display he

Re: [Qemu-devel] [Qemu-arm] [RFC v2 PATCH] hw/arm/virt: makes virt a default machine type

2019-06-24 Thread Andrea Bolognani
On Sat, 2019-06-22 at 16:58 +0100, Peter Maydell wrote: > On Fri, 21 Jun 2019 at 20:04, Cleber Rosa wrote: > > You can consider me biased (I do consider myself), but trying to wear > > the hat of a user first interacting with QEMU, I would expect a (any) > > reasonably capable environment that can

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-06-24 Thread Greg Kurz
On Mon, 24 Jun 2019 11:39:21 +1000 Suraj Jitindar Singh wrote: > The ibm,get_system_parameter rtas call is used by the guest to retrieve > data relating to certain parameters of the system. The SPLPAR > characteristics option (token 20) is used to determin characteristics of > the environment in

[Qemu-devel] [PATCH v3] memory: warning on out of scope notification

2019-06-24 Thread Yan Zhao
if an entry has parts out of scope of notifier's range, print warning message. Out of scope mapping/unmapping would cause problem, as in below case: 1. initially there are two notifiers with ranges 0-0xfedf, 0xfef0-0x, IOVAs from 0x3c00 - 0x3c1f is in shadow page t

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Paolo Bonzini
On 24/06/19 10:06, Peter Xu wrote: > Well, if with such an error we'd better fix it right away in this > patch... :) > > Let me wait for some more comments, I'll touch that up too if I need a > repost. Looks good to me, except for one minor issue in this patch. But do not attribute this one to m

Re: [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-24 Thread Markus Armbruster
Igor Mammedov writes: > Fallback might affect guest or worse whole host performance > or functionality if backing file were used to share guest RAM > with another process. > > Patch deprecates fallback so that we could remove it in future > and ensure that QEMU will provide expected behavior and

[Qemu-devel] [PATCH v2] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-24 Thread Igor Mammedov
QEMU will crash when device-memory-region-size property is read if ms->device_memory wasn't initialized yet. Crash can be reproduced with: $QEMU -preconfig -qmp unix:qmp_socket,server,nowait & ./scripts/qmp/qom-get -s qmp_socket /machine.device-memory-region-size Instead of crashing return 0 i

Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command

2019-06-24 Thread Markus Armbruster
Suraj Jitindar Singh writes: > On Wed, 2019-05-01 at 15:35 +1000, Suraj Jitindar Singh wrote: >> Add a monitor command "dump-stack" to be used to dump the stack for >> the >> current cpu. > > To summarise the discussion which occured on this patch, > > - It looks like it's ok to duplicate this fu

Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value

2019-06-24 Thread Markus Armbruster
Paolo Bonzini writes: > While indeed we do not want to have > > return (a); > > it is less clear that this applies to > > return (a && > b); > > Some editors indent more nicely if you have parentheses, and some people's > eyes may appreciate that as well. No objection. > Sig

Re: [Qemu-devel] [PATCH v3 0/5] tricore: adding new instructions and fixing

2019-06-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190624070339.4408-1-david.bren...@efs-auto.org/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commi

Re: [Qemu-devel] [PATCH] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-06-24 Thread Igor Mammedov
On Thu, 20 Jun 2019 22:46:15 -0300 Eduardo Habkost wrote: > On Fri, Jun 21, 2019 at 02:29:29AM +0200, Paolo Bonzini wrote: > > On 10/06/19 15:50, Igor Mammedov wrote: > > > QEMU will crash when device-memory-region-size property is read if > > > ms->device_memory > > > wasn't initialized yet.

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
On Mon, Jun 24, 2019 at 10:43:21AM +0200, Paolo Bonzini wrote: > On 24/06/19 10:06, Peter Xu wrote: > > Well, if with such an error we'd better fix it right away in this > > patch... :) > > > > Let me wait for some more comments, I'll touch that up too if I need a > > repost. > > Looks good to me

Re: [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema

2019-06-24 Thread Andrey Shinkevich
On 17/06/2019 14:57, Kevin Wolf wrote: > Commit cd219eb1e55 added the read-zeroes option for the null-co and > null-aio block driver, but forgot to add them to the QAPI schema. > Therefore, this option wasn't available in -blockdev and blockdev-add > until now. > > Add the missing option in the

[Qemu-devel] [PATCH] docs: clarify multiqueue vs multiple virtqueues

2019-06-24 Thread Stefan Hajnoczi
The vhost-user specification does not explain when VHOST_USER_PROTOCOL_F_MQ must be implemented. This may lead implementors of vhost-user masters to believe that this protocol feature is required for any device that has multiple virtqueues. That would be a mistake since existing vhost-user slaves

Re: [Qemu-devel] [Qemu-discuss] qemu-io-cmds does not compile on macOS

2019-06-24 Thread Alex Bennée
Peter Maydell writes: > On Sun, 23 Jun 2019 at 16:22, Juan Rafael García Blanco > wrote: >> I think the latest changes to qemu-io-cmds.c make it impossible to compile >> under macOS. It now uses clock_gettime, which is not available in this OS. >> I’m using 10.9.5; I think this function is n

Re: [Qemu-devel] [PATCH] Makefile: Rename the 'vm-test' target as 'vm-help'

2019-06-24 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > We already have 'make check-help', use the 'make vm-help' form > to display helps about VM testing. Keep the old target to not > bother old customs. > > Signed-off-by: Philippe Mathieu-Daudé Queued to testing/next, thanks. > --- > Based-on: <20190530101603.22

[Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
This is an replacement work of Yan Zhao's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html vtd_address_space_unmap() will do proper page mask alignment to make sure each IOTLB message will have correct masks for notification messages (2^N-1), but sometimes it can be expand

[Qemu-devel] [PATCH v2 1/2] intel_iommu: Fix incorrect "end" for vtd_address_space_unmap

2019-06-24 Thread Peter Xu
From: Yan Zhao IOMMUNotifier is with inclusive ranges, so we should check against (VTD_ADDRESS_SIZE(s->aw_bits) - 1). Signed-off-by: Yan Zhao [peterx: split from another bigger patch] Reviewed-by: Eric Auger Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 ++-- 1 file changed, 2 insert

[Qemu-devel] [PATCH v2 0/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
v2: - rename helper to get_naturally_aligned_size(), simplify the codes as suggested [Paolo] - check against vtd page size when looping over for unmaps [Yan] - add r-b for Eric Please review, thanks. Peter Xu (1): intel_iommu: Fix unexpected unmaps during global unmap Yan Zhao (1): intel_i

Re: [Qemu-devel] [PATCH v1 9/9] target/riscv: Add Zifencei and Zicsr as command line options

2019-06-24 Thread Palmer Dabbelt
On Mon, 17 Jun 2019 18:31:25 PDT (-0700), Alistair Francis wrote: For completeness let's add Zifencei and Zicsr as command line options, even though they can't be disabled at the moment. Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 9 + target/riscv/cpu.h | 2 ++ 2 files ch

Re: [Qemu-devel] [PATCH v1 3/9] target/riscv: Comment in the mcountinhibit CSR

2019-06-24 Thread Palmer Dabbelt
On Mon, 17 Jun 2019 18:31:08 PDT (-0700), Alistair Francis wrote: Add a comment for the new mcountinhibit which conflicts with the CSR_MUCOUNTEREN from version 1.09.1. This can be updated when we remove 1.09.1. Signed-off-by: Alistair Francis --- target/riscv/cpu_bits.h | 1 + target/riscv/csr

Re: [Qemu-devel] [PATCH v1 0/9] Update the RISC-V specification versions

2019-06-24 Thread Palmer Dabbelt
On Mon, 17 Jun 2019 18:31:00 PDT (-0700), Alistair Francis wrote: Based-on: Now that the RISC-V spec has started to be ratified let's update our QEMU implementation. There are a few things going on here: - Add priv version 1.11.0 to QEMU - This is the ratified version of the Privledge spec

Re: [Qemu-devel] [PATCH v7 1/3] block: include base when checking image chain for block allocation

2019-06-24 Thread Andrey Shinkevich
On 19/06/2019 22:27, Max Reitz wrote: > On 29.05.19 19:56, Andrey Shinkevich wrote: >> This patch is used in the 'block/stream: introduce a bottom node' >> that is following. Instead of the base node, the caller may pass >> the node that has the base as its backing image to the function >> bdrv_i

Re: [Qemu-devel] [libvirt] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-24 Thread Daniel P . Berrangé
On Mon, Jun 24, 2019 at 10:17:33AM +0200, Markus Armbruster wrote: > Igor Mammedov writes: > > > Fallback might affect guest or worse whole host performance > > or functionality if backing file were used to share guest RAM > > with another process. > > > > Patch deprecates fallback so that we cou

Re: [Qemu-devel] [PATCH v2] ioapic: use irq number instead of vector in ioapic_eoi_broadcast

2019-06-24 Thread Peter Xu
On Fri, Jun 21, 2019 at 05:21:19PM -0700, Li Qiang wrote: > When emulating irqchip in qemu, such as following command: > > x86_64-softmmu/qemu-system-x86_64 -m 1024 -smp 4 -hda /home/test/test.img > -machine kernel-irqchip=off --enable-kvm -vnc :0 -device edu -monitor stdio > > We will get a cras

Re: [Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property

2019-06-24 Thread Yongji Xie
On Sat, 22 Jun 2019 at 23:51, Greg Kurz wrote: > > On Mon, 17 Jun 2019 14:04:10 +0800 > Yongji Xie wrote: > > > On Mon, 17 Jun 2019 at 13:24, Greg Kurz wrote: > > > > > > On Mon, 17 Jun 2019 10:14:30 +0800 > > > Yongji Xie wrote: > > > > > > > On Fri, 14 Jun 2019 at 19:45, Greg Kurz wrote: > >

Re: [Qemu-devel] [Qemu-block] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-06-24 Thread Denis Plotnikov
On 21.06.2019 12:59, Vladimir Sementsov-Ogievskiy wrote: > 21.06.2019 12:16, Kevin Wolf wrote: >> Am 09.04.2019 um 12:01 hat Kevin Wolf geschrieben: >>> Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieben: On 13.03.2019 19:04, Kevin Wolf wrote: > Am 14.12.2018 um 12:54 hat Denis Plotn

Re: [Qemu-devel] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-24 Thread Igor Mammedov
On Mon, 24 Jun 2019 10:17:33 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > Fallback might affect guest or worse whole host performance > > or functionality if backing file were used to share guest RAM > > with another process. > > > > Patch deprecates fallback so that we could re

[Qemu-devel] [PATCH] ati-vga: Fixes to offset and pitch registers

2019-06-24 Thread BALATON Zoltan
Fix bit masks of registers for offset and pitch and also handle default values for both R128P and RV100. This improves picture a bit but does not resolve all problems yet so there might be some more bugs somewhere. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 32

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Auger Eric
Hi Peter, On 6/24/19 11:18 AM, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB message will have correct masks for n

Re: [Qemu-devel] [PATCH v3] memory: warning on out of scope notification

2019-06-24 Thread Auger Eric
Hi Yan, On 6/24/19 10:39 AM, Yan Zhao wrote: > if an entry has parts out of scope of notifier's range, print warning > message. > > Out of scope mapping/unmapping would cause problem, as in below case: > > 1. initially there are two notifiers with ranges > 0-0xfedf, 0xfef0-0x

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Paolo Bonzini
On 24/06/19 11:09, Peter Xu wrote: > On Mon, Jun 24, 2019 at 10:43:21AM +0200, Paolo Bonzini wrote: >> On 24/06/19 10:06, Peter Xu wrote: >>> Well, if with such an error we'd better fix it right away in this >>> patch... :) >>> >>> Let me wait for some more comments, I'll touch that up too if I nee

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Paolo Bonzini
On 24/06/19 11:18, Peter Xu wrote: > This is an replacement work of Yan Zhao's patch: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > vtd_address_space_unmap() will do proper page mask alignment to make > sure each IOTLB message will have correct masks for notification >

Re: [Qemu-devel] [Qemu-block] [RFC] nvme: how to support multiple namespaces

2019-06-24 Thread Kevin Wolf
Am 24.06.2019 um 10:01 hat Klaus Birkelund geschrieben: > On Thu, Jun 20, 2019 at 05:37:24PM +0200, Laszlo Ersek wrote: > > On 06/17/19 10:12, Klaus Birkelund wrote: > > > Hi all, > > > > > > I'm thinking about how to support multiple namespaces in the NVMe > > > device. My first idea was to add a

Re: [Qemu-devel] [PATCH] docs: clarify multiqueue vs multiple virtqueues

2019-06-24 Thread Marc-André Lureau
Hi On Mon, Jun 24, 2019 at 11:13 AM Stefan Hajnoczi wrote: > > The vhost-user specification does not explain when > VHOST_USER_PROTOCOL_F_MQ must be implemented. This may lead > implementors of vhost-user masters to believe that this protocol feature > is required for any device that has multipl

Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
On Mon, Jun 24, 2019 at 12:11:54PM +0200, Paolo Bonzini wrote: > On 24/06/19 11:09, Peter Xu wrote: > > On Mon, Jun 24, 2019 at 10:43:21AM +0200, Paolo Bonzini wrote: > >> On 24/06/19 10:06, Peter Xu wrote: > >>> Well, if with such an error we'd better fix it right away in this > >>> patch... :) >

Re: [Qemu-devel] ?==?utf-8?q? [PATCH v3 0/8] target/ppc: Optimize emulation of some Altivec

2019-06-24 Thread Stefan Brankovic
Hi Howard, Thanks for letting me know about compilation errors in my patch, I really appreciate it. Those should be fixed  in the latest version of this patch (v3), so please take a look and let me know if there is anything else that should be changed. Kind Regards, Stefan Original

Re: [Qemu-devel] [libvirt] [PATCH] deprecate -mem-path fallback to anonymous RAM

2019-06-24 Thread Igor Mammedov
On Mon, 24 Jun 2019 10:36:55 +0100 Daniel P. Berrangé wrote: > On Mon, Jun 24, 2019 at 10:17:33AM +0200, Markus Armbruster wrote: > > Igor Mammedov writes: > > > > > Fallback might affect guest or worse whole host performance > > > or functionality if backing file were used to share guest RAM

Re: [Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-06-24 Thread Alex Bennée
Roman Kagan writes: > It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, > with the following motivation: I can't find this commit in my tree. > > Because start_exclusive uses CPU_FOREACH, merge exclusive_lock with > qemu_cpu_list_lock: together with a call to exclusive_

Re: [Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments properties from bools to bits

2019-06-24 Thread Alex Bennée
Paolo Bonzini writes: > From: Vitaly Kuznetsov > > Representing Hyper-V properties as bits will allow us to check features > and dependencies between them in a natural way. > > Suggested-by: Roman Kagan > Signed-off-by: Vitaly Kuznetsov > Message-Id: <20190517141924.19024-2-vkuzn...@redhat.c

Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve

2019-06-24 Thread Dave Martin
On Fri, Jun 21, 2019 at 05:34:18PM +0100, Andrew Jones wrote: > These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the > swabbing is different than it is for fpsmid because the vector format > is a little-endian stream of words. Note, on big-endian hosts the FPSIMD view Vn and the SVE

Re: [Qemu-devel] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption

2019-06-24 Thread Dave Martin
On Fri, Jun 21, 2019 at 05:34:13PM +0100, Andrew Jones wrote: The purpose of this check should probably at least be described in a comment -- i.e., what actually depends on this? Cheers ---Dave > Suggested-by: Dave Martin > Signed-off-by: Andrew Jones > --- > target/arm/helper.c | 1 + > 1 fi

Re: [Qemu-devel] [PATCH v2 07/14] target/arm/cpu64: max cpu: Introduce sve properties

2019-06-24 Thread Dave Martin
On Fri, Jun 21, 2019 at 05:34:15PM +0100, Andrew Jones wrote: > Introduce cpu properties to give fine control over SVE vector lengths. > We introduce a property for each valid length up to the current > maximum supported, which is 2048-bits. The properties are named, e.g. > sve128, sve256, sve512,

Re: [Qemu-devel] [PATCH 01/17] MAINTAINERS: new maintainers for QOM

2019-06-24 Thread Markus Armbruster
Andreas Färber writes: > Am 19.06.19 um 22:10 schrieb Markus Armbruster: >> From: Paolo Bonzini >> >> QOM is not a particularly active subsystem now: 51 commits in two years. >> But, we need active maintainers to review and merge patches, and Git >> shows the following top committers taking on

Re: [Qemu-devel] [PATCH v2] ioapic: use irq number instead of vector in ioapic_eoi_broadcast

2019-06-24 Thread Li Qiang
Peter Xu 于2019年6月24日周一 下午5:42写道: > On Fri, Jun 21, 2019 at 05:21:19PM -0700, Li Qiang wrote: > > When emulating irqchip in qemu, such as following command: > > > > x86_64-softmmu/qemu-system-x86_64 -m 1024 -smp 4 -hda /home/test/test.img > > -machine kernel-irqchip=off --enable-kvm -vnc :0 -devic

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Peter Xu
On Mon, Jun 24, 2019 at 12:09:48PM +0200, Auger Eric wrote: > Hi Peter, > > On 6/24/19 11:18 AM, Peter Xu wrote: > > This is an replacement work of Yan Zhao's patch: > > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html > > > > vtd_address_space_unmap() will do proper page ma

Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition

2019-06-24 Thread Igor Mammedov
On Fri, 21 Jun 2019 01:17:48 +0800 gengdongjiu wrote: > On 2019/6/20 23:09, Igor Mammedov wrote: > > On Thu, 20 Jun 2019 22:04:01 +0800 > > gengdongjiu wrote: > > > >> Hi Igor, > >>Thanks for your review. > >> > >> On 2019/6/20 20:10, Igor Mammedov wrote: > + */ > +struct Acpi

Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

2019-06-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/06/19 22:10, Markus Armbruster wrote: >> Move commands device-list-properties, device_add, device-del, and >> event DEVICE_DELETED from misc.json to new qdev.json. qdev.json >> remains uncovered by MAINTAINERS, like the rest of qdev. > > qdev should be added to eith

Re: [Qemu-devel] [PATCH v2] ioapic: use irq number instead of vector in ioapic_eoi_broadcast

2019-06-24 Thread Peter Xu
On Mon, Jun 24, 2019 at 07:08:30PM +0800, Li Qiang wrote: > Do you mean the redirect table entry of ioapic update? Yes. > I think this is reasonable, I will prepare a separate patch with this one > as a patchset later. IMHO you can post that as separate patch. After all these are different issu

Re: [Qemu-devel] [PATCH 07/17] MAINTAINERS: Merge sections CPU, NUMA into Machine core

2019-06-24 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jun 19, 2019 at 10:10:40PM +0200, Markus Armbruster wrote: >> Suggested-by: Paolo Bonzini >> Cc: Eduardo Habkost >> Cc: Marcel Apfelbaum >> Signed-off-by: Markus Armbruster >> --- >> MAINTAINERS | 16 >> 1 file changed, 4 insertions(+), 1

Re: [Qemu-devel] [PATCH v2] ioapic: use irq number instead of vector in ioapic_eoi_broadcast

2019-06-24 Thread Li Qiang
Peter Xu 于2019年6月24日周一 下午7:21写道: > On Mon, Jun 24, 2019 at 07:08:30PM +0800, Li Qiang wrote: > > Do you mean the redirect table entry of ioapic update? > > Yes. > > > I think this is reasonable, I will prepare a separate patch with this one > > as a patchset later. > > IMHO you can post that as s

Re: [Qemu-devel] [PATCH v17 03/10] acpi: add build_append_ghes_notify() helper for Hardware Error Notification

2019-06-24 Thread Igor Mammedov
On Tue, 14 May 2019 04:18:16 -0700 Dongjiu Geng wrote: > It will help to add Hardware Error Notification to ACPI tables > without using packed C structures and avoid endianness > issues as API doesn't need explicit conversion. > > Signed-off-by: Dongjiu Geng > --- > hw/acpi/aml-build.c

Re: [Qemu-devel] [PATCH v2 05/14] target/arm/helper: zcr: Add build bug next to value range assumption

2019-06-24 Thread Andrew Jones
On Mon, Jun 24, 2019 at 12:05:07PM +0100, Dave Martin wrote: > On Fri, Jun 21, 2019 at 05:34:13PM +0100, Andrew Jones wrote: > > The purpose of this check should probably at least be described in a > comment -- i.e., what actually depends on this? I was thinking the already present "Bits other th

Re: [Qemu-devel] [PATCH 12/17] qapi: Split machine-target.json off target.json and misc.json

2019-06-24 Thread Markus Armbruster
Eric Blake writes: > On 6/19/19 3:10 PM, Markus Armbruster wrote: >> Move commands query-cpu-definitions, query-cpu-model-baseline, >> query-cpu-model-comparison, and query-cpu-model-expansion with their >> types from target.json to machine-target.json. Also move typee > > s/typee/types/ Will f

Re: [Qemu-devel] [PATCH 16/17] MAINTAINERS: Add Windows dump to section "Dump"

2019-06-24 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jun 19, 2019 at 10:10:49PM +0200, Markus Armbruster wrote: >> Commit 2da91b54fe9 "dump: add Windows dump format to >> dump-guest-memory" neglected to update MAINTAINERS. Do it now. >> >> Cc: Marc-André Lureau >> Signed-off-by: Markus Armbruster >> --- >>

Re: [Qemu-devel] [PATCH 17/17] dump: Move HMP command handlers to dump/

2019-06-24 Thread Markus Armbruster
Eric Blake writes: > On 6/19/19 3:10 PM, Markus Armbruster wrote: >> Move the HMP handlers related to qapi/dump.json to >> dimp/dump-hmp-cmds.c, where they are covered by MAINTAINERS section > > s/dimp/dump/ Will fix. Thanks! >> "Dump", just like qapi/dump.json. >> >> Cc: Marc-André Lureau >

Re: [Qemu-devel] [PATCH v17 06/10] docs: APEI GHES generation and CPER record description

2019-06-24 Thread Igor Mammedov
On Tue, 14 May 2019 04:18:19 -0700 Dongjiu Geng wrote: > Add APEI/GHES detailed design document > > Signed-off-by: Dongjiu Geng > --- > docs/specs/acpi_hest_ghes.txt | 97 > +++ > 1 file changed, 97 insertions(+) > create mode 100644 docs/specs/acpi_he

Re: [Qemu-devel] [PATCH 04/17] qapi: Split qom.json and qdev.json off misc.json

2019-06-24 Thread Daniel P . Berrangé
On Mon, Jun 24, 2019 at 01:19:33PM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 19/06/19 22:10, Markus Armbruster wrote: > >> Move commands device-list-properties, device_add, device-del, and > >> event DEVICE_DELETED from misc.json to new qdev.json. qdev.json > >> remains un

Re: [Qemu-devel] [PATCH v2 07/14] target/arm/cpu64: max cpu: Introduce sve properties

2019-06-24 Thread Andrew Jones
On Mon, Jun 24, 2019 at 12:05:26PM +0100, Dave Martin wrote: > On Fri, Jun 21, 2019 at 05:34:15PM +0100, Andrew Jones wrote: > > Introduce cpu properties to give fine control over SVE vector lengths. > > We introduce a property for each valid length up to the current > > maximum supported, which is

Re: [Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-06-24 Thread Roman Kagan
On Mon, Jun 24, 2019 at 11:58:23AM +0100, Alex Bennée wrote: > Roman Kagan writes: > > > It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, > > with the following motivation: > > I can't find this commit in my tree. OOPS, that was supposed to be ab129972c8b41e15b0521895a46fd9c

Re: [Qemu-devel] [PATCH v2 10/14] target/arm/kvm64: Add kvm_arch_get/put_sve

2019-06-24 Thread Andrew Jones
On Mon, Jun 24, 2019 at 12:05:35PM +0100, Dave Martin wrote: > On Fri, Jun 21, 2019 at 05:34:18PM +0100, Andrew Jones wrote: > > These are the SVE equivalents to kvm_arch_get/put_fpsimd. Note, the > > swabbing is different than it is for fpsmid because the vector format > > is a little-endian strea

Re: [Qemu-devel] ?==?utf-8?q? [PATCH v3 0/8] target/ppc: Optimize emulation of some Altivec

2019-06-24 Thread Stefan Brankovic
Hi Howard, Would you be so kind to send me exact qemu command line and applicable files(OS images or similar) that you used to bring this exact situation up. Thanks in advance. Kind Regards, Stefan Original Message Subject: Re: [PATCH v3 0/8] target/ppc: Optimize emulation

Re: [Qemu-devel] [PATCH v2 07/14] target/arm/cpu64: max cpu: Introduce sve properties

2019-06-24 Thread Andrew Jones
On Mon, Jun 24, 2019 at 01:49:11PM +0200, Andrew Jones wrote: > On Mon, Jun 24, 2019 at 12:05:26PM +0100, Dave Martin wrote: > > On Fri, Jun 21, 2019 at 05:34:15PM +0100, Andrew Jones wrote: > > > Introduce cpu properties to give fine control over SVE vector lengths. > > > We introduce a property f

Re: [Qemu-devel] [PULL 0/8] Block patches

2019-06-24 Thread Max Reitz
On 23.06.19 19:18, Peter Maydell wrote: > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: >> >> The following changes since commit 33d609990621dea6c7d056c86f707b8811320ac1: >> >> Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into >> staging (2019-06-18 17:00:52 +0100) >> >> are

Re: [Qemu-devel] [PATCH v17 01/10] hw/arm/virt: Add RAS platform version for migration

2019-06-24 Thread gengdongjiu
On 2019/6/20 20:04, Igor Mammedov wrote: > On Tue, 14 May 2019 04:18:14 -0700 > Dongjiu Geng wrote: > >> Support this feature since version 4.1, disable it by >> default in the old version. >> >> Signed-off-by: Dongjiu Geng >> --- >> hw/arm/virt.c | 6 ++ >> include/hw/arm/virt.h

Re: [Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments properties from bools to bits

2019-06-24 Thread Vitaly Kuznetsov
Alex Bennée writes: > > This looks like it's broken the build: > > configure' '--without-default-devices' '--disable-user' > > with: > > /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c: In function > ‘kvm_hv_handle_exit’: > /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c:18:19: error

Re: [Qemu-devel] [PATCH v17 07/10] ACPI: Add APEI GHES table generation support

2019-06-24 Thread Igor Mammedov
On Tue, 14 May 2019 04:18:20 -0700 Dongjiu Geng wrote: > This implements APEI GHES Table generation via fw_cfg blobs. > Now it only support GPIO-Signal and ARMv8 SEA two types of GHESv2 error > source. Afterwards, we can extend the supported types if needed. For the > CPER section type, currently

Re: [Qemu-devel] [PATCH v17 08/10] KVM: Move related hwpoison page functions to accel/kvm/ folder

2019-06-24 Thread Igor Mammedov
On Tue, 14 May 2019 04:18:21 -0700 Dongjiu Geng wrote: > kvm_hwpoison_page_add() and kvm_unpoison_all() will be used both > by X86 and ARM platforms, so move these functions to a common > accel/kvm/ folder to avoid duplicate code. > > Signed-off-by: Dongjiu Geng > --- > accel/kvm/kvm-all.c

Re: [Qemu-devel] [PATCH v17 04/10] acpi: add build_append_ghes_generic_data() helper for Generic Error Data Entry

2019-06-24 Thread gengdongjiu
On 2019/6/20 20:28, Igor Mammedov wrote: > On Tue, 14 May 2019 04:18:17 -0700 > Dongjiu Geng wrote: > >> It will help to add Generic Error Data Entry to ACPI tables >> without using packed C structures and avoid endianness >> issues as API doesn't need explicit conversion. >> >> Signed-off-by:

[Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Alex Bennée
Commit 2d384d7c8 broken the build when built with: configure --without-default-devices --disable-user The reason was the conversion of cpu->hyperv_synic to cpu->hyperv_synic_kvm_only although the rest of the patch introduces a feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC

Re: [Qemu-devel] [RFC PATCH 1/2] cpus-common: nuke finish_safe_work

2019-06-24 Thread Alex Bennée
Roman Kagan writes: > On Mon, Jun 24, 2019 at 11:58:23AM +0100, Alex Bennée wrote: >> Roman Kagan writes: >> >> > It was introduced in commit b129972c8b41e15b0521895a46fd9c752b68a5e, >> > with the following motivation: >> >> I can't find this commit in my tree. > > OOPS, that was supposed to b

Re: [Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments properties from bools to bits

2019-06-24 Thread Alex Bennée
Vitaly Kuznetsov writes: > Alex Bennée writes: > >> >> This looks like it's broken the build: >> >> configure' '--without-default-devices' '--disable-user' >> >> with: >> >> /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c: In function >> ‘kvm_hv_handle_exit’: >> /home/alex/lsrc/qemu.

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Auger Eric
On 6/24/19 1:10 PM, Peter Xu wrote: > On Mon, Jun 24, 2019 at 12:09:48PM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 6/24/19 11:18 AM, Peter Xu wrote: >>> This is an replacement work of Yan Zhao's patch: >>> >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg625340.html >>> >>> vtd_add

[Qemu-devel] [PATCH] i386/kvm: fix build with CONFIG_HYPERV=n

2019-06-24 Thread Vitaly Kuznetsov
When switching from boolean properties to bits to represent Hyper-V enlightenments we forgot to update hyperv-stub.c for CONFIG_HYPERV=n builds. Reported-by: Alex Bennée Fixes: 2d384d7c8361 ("i386/kvm: convert hyperv enlightenments properties from bools to bits") Signed-off-by: Vitaly Kuznetsov

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Vitaly Kuznetsov
Alex Bennée writes: > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduces a > feature checking mechanism. So I'v

Re: [Qemu-devel] [PATCH v17 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-06-24 Thread Igor Mammedov
On Tue, 14 May 2019 04:18:23 -0700 Dongjiu Geng wrote: > Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, > translates the host VA delivered by host to guest PA, then fill this PA > to guest APEI GHES memory, then notify guest according to the SIGBUS type. > > If guest acce

Re: [Qemu-devel] [PULL 0/8] Block patches

2019-06-24 Thread Pino Toscano
On Monday, 24 June 2019 14:20:11 CEST Max Reitz wrote: > On 23.06.19 19:18, Peter Maydell wrote: > > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote: > >> > >> The following changes since commit > >> 33d609990621dea6c7d056c86f707b8811320ac1: > >> > >> Merge remote-tracking branch 'remotes/kevin/t

Re: [Qemu-devel] [PATCH v2 2/2] intel_iommu: Fix unexpected unmaps during global unmap

2019-06-24 Thread Paolo Bonzini
On 24/06/19 14:48, Auger Eric wrote: +if (alignment <= size) { +/* Increase the alignment of start */ >>> I don't really get this comment >> This comment comes from Paolo, but I'll try to explain - it tries to >> mean that this "alignment" will be used as an increasement to "s

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Paolo Bonzini
On 24/06/19 14:38, Alex Bennée wrote: > Commit 2d384d7c8 broken the build when built with: > > configure --without-default-devices --disable-user > > The reason was the conversion of cpu->hyperv_synic to > cpu->hyperv_synic_kvm_only although the rest of the patch introduces a > feature checking

[Qemu-devel] [Bug 1831477] Re: update edk2 submodule & binaries to edk2-stable201905

2019-06-24 Thread Laszlo Ersek (Red Hat)
Merged in commit 53defa05701b ("Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-06-14' into staging", 2019-06-17). ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c

2019-06-24 Thread Paolo Bonzini
On 24/06/19 15:22, Paolo Bonzini wrote: > On 24/06/19 14:38, Alex Bennée wrote: >> Commit 2d384d7c8 broken the build when built with: >> >> configure --without-default-devices --disable-user >> >> The reason was the conversion of cpu->hyperv_synic to >> cpu->hyperv_synic_kvm_only although the res

[Qemu-devel] [PULL 00/19] testing/next (tests/vm, Travis and hyperv build fix)

2019-06-24 Thread Alex Bennée
The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-ne

[Qemu-devel] [PULL 04/19] tests/vm: add source repos on ubuntu.i386

2019-06-24 Thread Alex Bennée
From: Cleber Rosa Possibly because of different behavior on the newly update cloud-image, trying to run 'apt-get build-dep' results in: E: You must put some 'source' URIs in your sources.list This enables all source repos (even though some are not needed) for simplicity sake. Signed-off-by:

[Qemu-devel] [PULL 07/19] tests/vm: run test builds on snapshot

2019-06-24 Thread Alex Bennée
From: Gerd Hoffmann The build script doesn't shutdown the guest VMs properly, which results in filesystem corruption and guest boot failures sooner or later. Use the --snapshot to run builds on a snapshot, That way killing the VM doesn't corrupt the base image. Signed-off-by: Gerd Hoffmann Tes

  1   2   3   >