Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > The current default value for hv-spinlocks is 0x (meaning > "never retry"). However, the value is stored as a signed > integer, making the getter of the hv-spinlocks QOM property > return -1 instead of 0x. > > Fix this by changing the type of X86CPU::hyp

Re: [Qemu-devel] [PATCH v4 11/11] hmat acpi: Implement _HMA method to update HMAT at runtime

2019-06-17 Thread Tao Xu
On 6/17/2019 4:07 AM, Igor Mammedov wrote: On Wed, 8 May 2019 14:17:26 +0800 Tao Xu wrote: From: Liu Jingqi OSPM evaluates HMAT only during system initialization. Any changes to the HMAT state at runtime or information regarding HMAT for hot plug are communicated using _HMA method. _HMA is

Re: [Qemu-devel] [QEMU] [PATCH v2 7/8] bootdevice: FW_CFG interface for LCHS values

2019-06-17 Thread Gerd Hoffmann
Hi, > We serialize this information in a similar way to the "bootorder" > interface. > The fw_cfg entry is "bootdevices" and it serializes a struct. Why "bootdevices"? I'd suggest to use "geometry" or "lchs" instead. > At the moment the struct holds the values of logical CHS values but it > c

Re: [Qemu-devel] [QEMU] [PATCH v2 7/8] bootdevice: FW_CFG interface for LCHS values

2019-06-17 Thread Sam Eiderman
> On 17 Jun 2019, at 10:20, Gerd Hoffmann wrote: > > Hi, > >> We serialize this information in a similar way to the "bootorder" >> interface. >> The fw_cfg entry is "bootdevices" and it serializes a struct. > > Why "bootdevices"? I'd suggest to use "geometry" or "lchs" instead. True, if w

Re: [Qemu-devel] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface

2019-06-17 Thread Sam Eiderman
> On 17 Jun 2019, at 9:50, Gerd Hoffmann wrote: > > Hi, > >>> Ok, given that seabios has no setup any manual configuration needs to be >>> done via qemu. >>> >>> But why do we need a new interface for that? IDE can pass the geometry >>> to the guest. virtio-blk has support too (VIRTIO_BL

[Qemu-devel] [RFC] nvme: how to support multiple namespaces

2019-06-17 Thread Klaus Birkelund
Hi all, I'm thinking about how to support multiple namespaces in the NVMe device. My first idea was to add a "namespaces" property array to the device that references blockdevs, but as Laszlo writes below, this might not be the best idea. It also makes it troublesome to add per-namespace parameter

Re: [Qemu-devel] [PATCH v3 01/50] trace: expand mem_info:size_shift to 3 bits

2019-06-17 Thread Alex Bennée
Richard Henderson writes: > On 6/14/19 10:11 AM, Alex Bennée wrote: >> From: "Emilio G. Cota" >> >> This will allow us to trace 16B-long memory accesses. >> >> Reviewed-by: Alex Bennée >> Signed-off-by: Emilio G. Cota >> --- >> trace-events | 2 +- >> 1 file changed, 1 insertion(+), 1 delet

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu REPOST] spapr/rtas: Force big endian compile for rtas

2019-06-17 Thread Greg Kurz
On Wed, 12 Jun 2019 12:07:23 +1000 Alexey Kardashevskiy wrote: > At the moment the rtas's Makefile uses generic QEMU rules which means > that when QEMU is compiled on a little endian system, the spapr-rtas.bin > is compiled as little endian too which is incorrect as it is always > executed in big

Re: [Qemu-devel] [QEMU] [PATCH v2 7/8] bootdevice: FW_CFG interface for LCHS values

2019-06-17 Thread Gerd Hoffmann
Hi, > Keep it extendible for a low price of ABI + “bootdevices” name. > Or go strict and rename to “bios-geometries”? The name should reflect what is in there, so "bios-geometries" looks better to me. I'd also keep it strict, unless we have at least a vague idea what might be a useful future e

Re: [Qemu-devel] [PULL 01/29] SiFive RISC-V GPIO Device

2019-06-17 Thread Fabien Chouteau
On 14/06/2019 14:10, Palmer Dabbelt wrote: > Sorry this took a while to fix, I've just sent a patch to fix the memory leak. Thank you for taking care of this!

Re: [Qemu-devel] [PATCH v3 00/15] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-17 Thread Kevin Wolf
Am 15.06.2019 um 22:31 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > monitor.c mixes a lot of different things in a single file: The core > >> > monitor infrastructure, HMP infrastrctur

Re: [Qemu-devel] [PATCH v4 00/11] tests/vm: serial console autoinstall, misc fixes.

2019-06-17 Thread Alex Bennée
Gerd Hoffmann writes: > This patch series changes the way virtual machines for test builds are > managed. They are created locally on the developer machine now. The > installer is booted on the serial console and the scripts walks through > the dialogs to install and configure the guest. > >

[Qemu-devel] [Bug 1833048] [NEW] Guest Agent get-fsinfo doesn't show ZFS volumes

2019-06-17 Thread Stefan
Public bug reported: Calling get-fsinfo on a virtual machine does not include ZFS (zfsonlinux, debian guest tested) volumes. Calling on a system with a single ZFS disk (ZFS as root fs) simply returns '[]', if other disks exist on the guest it only shows these. Expected behaviour: Show file system

Re: [Qemu-devel] [PATCH] vfio-ccw: use vfio_set_irq_signaling

2019-06-17 Thread Cornelia Huck
On Fri, 14 Jun 2019 11:41:41 -0400 Eric Farman wrote: > On 6/14/19 11:06 AM, Auger Eric wrote: > > Hi Eric, > > > > On 6/14/19 4:30 PM, Eric Farman wrote: > >> > >> > >> On 6/14/19 5:27 AM, Cornelia Huck wrote: > >>> Use the new helper. > >>> > >>> Signed-off-by: Cornelia Huck > >>> --- > >

Re: [Qemu-devel] [Qemu-Devel][PATCH 2/3] Saving counters between tb_flush events.

2019-06-17 Thread Alex Bennée
vandersonmr writes: > A new hash map was added to store the accumulated execution > frequency of the TBs even after tb_flush events. A dump > function was also added as a way to visualize these frequencies. > > Signed-off-by: vandersonmr I forgot to mention the formatting looks a little off h

Re: [Qemu-devel] [Qemu-Devel][PATCH 1/3] Adding an optional tb execution counter.

2019-06-17 Thread Alex Bennée
[repeat of reply to wrong email...] vandersonmr writes: > An uint64_t counter was added in the TranslationBlock struct and > it is incremented every time that the TB is executed. > > Signed-off-by: vandersonmr > --- > accel/tcg/tcg-runtime.c | 6 ++ > accel/tcg/tcg-runtime.h | 2 ++ >

Re: [Qemu-devel] [QEMU] [PATCH v2 7/8] bootdevice: FW_CFG interface for LCHS values

2019-06-17 Thread Sam Eiderman
Ok, I’ll resubmit this patch series in v3, as well as v2 for SeaBIOS soon enough. * Change “bootdevices” to “bios-geometry”, and remove the struct size * Add cpu_to_le32 fix as Laszlo suggested or big endian hosts * Fix last qtest commit - automatic docker tester for some reason does not have qe

[Qemu-devel] [PATCH v2] vfio-ccw: use vfio_set_irq_signaling

2019-06-17 Thread Cornelia Huck
Use the new helper. Signed-off-by: Cornelia Huck --- v1->v2: - Don't go overboard with deleting, and keep the get_irq_info part. --- hw/vfio/ccw.c | 51 +-- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/cc

Re: [Qemu-devel] [PATCH 0/3] Collecting TB Execution Frequency

2019-06-17 Thread Alex Bennée
vandersonmr writes: > This is the first series of patches related to the TCGCodeQuality GSoC project > More at https://wiki.qemu.org/Features/TCGCodeQuality > > It adds an option to instrument TBs and collects their execution frequency. > The execution frequency is then store/accumulated in an

Re: [Qemu-devel] [PATCH v8 4/7] block: introduce backup-top filter driver

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
14.06.2019 23:03, Max Reitz wrote: > On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote: >> 14.06.2019 15:57, Max Reitz wrote: >>> On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote: 13.06.2019 18:57, Max Reitz wrote: > On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote: >> Ba

Re: [Qemu-devel] [PATCH] migration: allow private destination ram with x-ignore-shared

2019-06-17 Thread Dr. David Alan Gilbert
* Peng Tao (tao.p...@linux.alibaba.com) wrote: > By removing the share ram check, qemu is able to migrate > to private destination ram when x-ignore-shared capability > is on. Then we can create multiple destination VMs based > on the same source VM. > > This changes the x-ignore-shared migration

Re: [Qemu-devel] [PATCH] migration: allow private destination ram with x-ignore-shared

2019-06-17 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Peng Tao (tao.p...@linux.alibaba.com) wrote: > > By removing the share ram check, qemu is able to migrate > > to private destination ram when x-ignore-shared capability > > is on. Then we can create multiple destination VMs based > > on the

Re: [Qemu-devel] [PULL 0/6] update edk2 submodule & binaries to edk2-stable201905

2019-06-17 Thread Peter Maydell
On Fri, 14 Jun 2019 at 21:25, Laszlo Ersek wrote: > > The following changes since commit f3d0bec9f80e4ed7796fffa834ba0a53f2094f7f: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-14' > into staging (2019-06-14 14:46:13 +0100) > > are available in the Git repository at

Re: [Qemu-devel] [PATCH v7 2/2] hw/arm: Add arm SBSA reference machine, devices part

2019-06-17 Thread Philippe Mathieu-Daudé
On 6/16/19 1:41 PM, Hongbo Zhang wrote: > On Mon, 3 Jun 2019 at 18:54, Philippe Mathieu-Daudé wrote: >> >> Hi Hongbo, Ard. >> >> On 4/18/19 6:04 AM, Hongbo Zhang wrote: >>> Following the previous patch, this patch adds peripheral devices to the >>> newly introduced SBSA-ref machine. >>> >>> Signed

Re: [Qemu-devel] [PATCH v2] vfio-ccw: use vfio_set_irq_signaling

2019-06-17 Thread Auger Eric
Hi Connie, On 6/17/19 12:10 PM, Cornelia Huck wrote: > Use the new helper. > > Signed-off-by: Cornelia Huck Reviewed-by: Eric Auger Thanks Eric > --- > v1->v2: > - Don't go overboard with deleting, and keep the get_irq_info part. > --- > hw/vfio/ccw.c | 51 +-

Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

2019-06-17 Thread Kevin Wolf
Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > The Valgrind tool fails to manage its termination when QEMU raises the > signal SIGKILL. Lets exclude such test cases from running under the > Valgrind because there is no sense to check memory issues that way. > > Signed-off-by: Andrey S

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
06.06.2019 17:07, Vladimir Sementsov-Ogievskiy wrote: > 06.06.2019 16:55, Eric Blake wrote: >> On 6/6/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> Here is small new io API: blk_co_pcache, which does copy-on-read without >>> extra buffer for read data. This means that only par

Re: [Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory

2019-06-17 Thread Kevin Wolf
Am 13.06.2019 um 11:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.06.2019 21:02, Andrey Shinkevich wrote: > > The Valgrind uses the exported variable TMPDIR and fails if the > > directory does not exist. Let us exclude such a test case from > > being run under the Valgrind. > > > > Signed-

Re: [Qemu-devel] [Qemu-Devel][PATCH 3/3] Adding command line option to linux-user.

2019-06-17 Thread Alex Bennée
[added Markus to Cc for his view on options] vandersonmr writes: > Added -execfreq to enable execution frequency counting and dump > all the TB's addresses and their execution frequency at the end > of the execution. > > Signed-off-by: vandersonmr This works well enough but we are going to n

Re: [Qemu-devel] [PATCH 1/8] target/ppc: Optimize emulation of lvsl and lvsr instructions

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 18:46, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: +tcg_gen_addi_i64(result, sh, 7); +for (i = 7; i >= 1; i--) { +tcg_gen_shli_i64(tmp, sh, i * 8); +tcg_gen_or_i64(result, result, tmp); +tcg_gen_addi_i64(sh, sh, 1); +} Bet

Re: [Qemu-devel] [PATCH 0/8] Optimize emulation of ten Altivec instructions: lvsl,

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 19:13, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: Stefan Brankovic (8): target/ppc: Optimize emulation of lvsl and lvsr instructions target/ppc: Optimize emulation of vsl and vsr instructions target/ppc: Optimize emulation of vpkpx instruction ta

Re: [Qemu-devel] [PATCH v2] vfio-ccw: use vfio_set_irq_signaling

2019-06-17 Thread Eric Farman
On 6/17/19 6:10 AM, Cornelia Huck wrote: > Use the new helper. > > Signed-off-by: Cornelia Huck Nice simplification! Reviewed-by: Eric Farman > --- > v1->v2: > - Don't go overboard with deleting, and keep the get_irq_info part. (Sorry about that. :) > --- > hw/vfio/ccw.c | 51

Re: [Qemu-devel] [PATCH 3/7] KVM: i386: Add support for KVM_CAP_EXCEPTION_PAYLOAD

2019-06-17 Thread Liran Alon
> On 16 Jun 2019, at 15:38, Liran Alon wrote: > > > >> On 15 Jun 2019, at 3:57, Liran Alon wrote: >> >>> On 15 Jun 2019, at 3:42, Paolo Bonzini wrote: >>> >>> From: Liran Alon >>> >>> +static bool is_vmx_enabled(CPUX86State *env) >>> +{ >>> +return (IS_INTEL_CPU(env) && (env->cr[4]

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 02/23] target/arm: Makefile cleanup (ARM)

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Group ARM objects together, TCG related ones at the bottom. > This will help when restricting TCG-only objects. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/Makefile.objs | 9 ++--- > 1 file changed, 6 insertions

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu REPOST] spapr/rtas: Force big endian compile for rtas

2019-06-17 Thread David Gibson
On Mon, Jun 17, 2019 at 10:25:10AM +0200, Greg Kurz wrote: 65;5603;1c> On Wed, 12 Jun 2019 12:07:23 +1000 > Alexey Kardashevskiy wrote: > > > At the moment the rtas's Makefile uses generic QEMU rules which means > > that when QEMU is compiled on a little endian system, the spapr-rtas.bin > > is c

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 01/23] target/arm: Makefile cleanup (Aarch64)

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Group Aarch64 objects together, TCG related ones at the bottom. > This will help when restricting TCG-only objects. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/Makefile.objs | 5 +++-- > 1 file changed, 3 insertions

Re: [Qemu-devel] [PATCH 2/8] target/ppc: Optimize emulation of vsl and vsr instructions

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 19:03, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: +tcg_gen_subi_i64(tmp, sh, 64); +tcg_gen_neg_i64(tmp, tmp); Better as tcg_gen_subfi_i64(tmp, 64, sh); I was aware there must be way of doing it in a single tcg invocation, but couldn't find r

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 05/23] target/arm: Add copyright boilerplate

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Robert Bradford > Reviewed-by: Samuel Ortiz Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/target/arm/helper.c b/target/arm/helper.c

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 02/23] target/arm: Makefile cleanup (ARM)

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Group ARM objects together, TCG related ones at the bottom. > This will help when restricting TCG-only objects. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/Makefile.objs | 9 ++--- > 1 file changed, 6 insertions

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 03/23] target/arm: Makefile cleanup (KVM)

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Group KVM objects together. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/Makefile.objs | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.

Re: [Qemu-devel] [PATCH 0/4] qapi: block-dirty-bitmap-remove transaction action

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
08.06.2019 1:26, John Snow wrote: > > > On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> Here is block-dirty-bitmap-remove transaction action. >> >> It is used to do transactional movement of the bitmap (which is >> possible in conjunction with merge command). Transactional

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 06/23] target/arm: Fix multiline comment syntax

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since commit 8c06fbdf36b checkpatch.pl enforce a new multiline > comment syntax. Since we'll move this code around, fix its style > first. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/helper.c| 213 ++

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 04/23] target/arm: Makefile cleanup (softmmu)

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Group SOFTMMU objects together. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/Makefile.objs | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target/arm/Makefile.objs b/target/arm/Makefi

Re: [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors

2019-06-17 Thread Kevin Wolf
Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > The Valgrind tool reports about an uninitialised memory usage when the > initialization is actually not needed. For example, the buffer 'buf' > instantiated on a stack of the function guess_disk_lchs(). I would be careful with calling ini

[Qemu-devel] [PATCH] configure: use valid args testing sem_timedwait

2019-06-17 Thread Daniel P . Berrangé
The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release. This causes configure to fail when -Werror is used: config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:2:25: error: null argume

Re: [Qemu-devel] [PATCH 7/8] target/ppc: Optimize emulation of vclzh and vclzb instructions

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 22:38, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: Optimize Altivec instruction vclzh (Vector Count Leading Zeros Halfword). This instruction counts the number of leading zeros of each halfword element in source register and places result in the appropriate h

[Qemu-devel] [PATCH] linux-user: fix includes to find SIOCGSTAMP with latest kernel headers

2019-06-17 Thread Daniel P . Berrangé
The SIOCGSTAMP symbol was previously defined in the asm-generic/sockios.h header file. QEMU sees that header indirectly via sys/socket.h -> bits/socket.h -> asm/socket.h -> asm-generic/socket.h -> asm/sockios.h -> asm-generic/sockios.h

[Qemu-devel] [PATCH] xics/spapr: Only emulated XICS should use RTAS/hypercalls emulation

2019-06-17 Thread Greg Kurz
Checking that we're not using the in-kernel XICS is ok with the "xics" interrupt controller mode, but it is definitely not enough with the other modes since the guest could be using XIVE. Ensure XIVE is not in use when emulated XICS RTAS/hypercalls are called. Signed-off-by: Greg Kurz --- hw/in

Re: [Qemu-devel] [PATCH 8/8] target/ppc: Refactor emulation of vmrgew and vmrgow instructions

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 22:43, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: +/* + * We use this macro if one instruction is realized with direct + * translation, and second one with helper. + */ +#define GEN_VXFORM_TRANS_DUAL(name0, flg0, flg2_0, name1, flg1, flg2_1)\ +static void gl

Re: [Qemu-devel] [PATCH v2 08/23] target/arm: Move all v7m insn helpers into their own file

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > From: Samuel Ortiz > > In preparation for supporting TCG disablement on ARM, we move most > of TCG related v7m helpers and APIs into their own file. > > Signed-off-by: Samuel Ortiz > [PMD: Patch rewritten] > Signed-off-by: Philippe Mathieu-Daudé > --- > Is th

[Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema

2019-06-17 Thread Kevin Wolf
Commit cd219eb1e55 added the read-zeroes option for the null-co and null-aio block driver, but forgot to add them to the QAPI schema. Therefore, this option wasn't available in -blockdev and blockdev-add until now. Add the missing option in the schema to make it available there, too. Signed-off-b

Re: [Qemu-devel] [PATCH] linux-user: fix includes to find SIOCGSTAMP with latest kernel headers

2019-06-17 Thread Laurent Vivier
Le 17/06/2019 à 13:40, Daniel P. Berrangé a écrit : > The SIOCGSTAMP symbol was previously defined in the > asm-generic/sockios.h header file. QEMU sees that header > indirectly via > >sys/socket.h > -> bits/socket.h > -> asm/socket.h > -> asm-generic/socket.h >

Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

2019-06-17 Thread Roman Kagan
On Thu, Jun 13, 2019 at 12:47:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 11.06.2019 21:02, Andrey Shinkevich wrote: > > The Valgrind tool fails to manage its termination when QEMU raises the > > signal SIGKILL. Lets exclude such test cases from running under the > > Valgrind because there is

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-17 Thread Kevin Wolf
Am 17.06.2019 um 13:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > 06.06.2019 17:07, Vladimir Sementsov-Ogievskiy wrote: > > 06.06.2019 16:55, Eric Blake wrote: > >> On 6/6/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> Hi all! > >>> > >>> Here is small new io API: blk_co_pcache, which d

Re: [Qemu-devel] [PATCH 6/8] target/ppc: Optimize emulation of vclzw instruction

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 20:34, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: +for (i = 0; i < 2; i++) { +if (i == 0) { +/* Get high doubleword element of vB in avr. */ +get_avr64(avr, VB, true); +} else { +/* Get low doubleword e

Re: [Qemu-devel] [PATCH v2 08/23] target/arm: Move all v7m insn helpers into their own file

2019-06-17 Thread Philippe Mathieu-Daudé
On 6/17/19 1:42 PM, Alex Bennée wrote: > Philippe Mathieu-Daudé writes: > >> From: Samuel Ortiz >> >> In preparation for supporting TCG disablement on ARM, we move most >> of TCG related v7m helpers and APIs into their own file. >> >> Signed-off-by: Samuel Ortiz >> [PMD: Patch rewritten] >> Sig

Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

2019-06-17 Thread Roman Kagan
On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote: > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > > The Valgrind tool fails to manage its termination when QEMU raises the > > signal SIGKILL. Lets exclude such test cases from running under the > > Valgrind because there is no

Re: [Qemu-devel] [PATCH 4/8] target/ppc: Optimize emulation of vgbbd instruction

2019-06-17 Thread Stefan Brankovic
On 6.6.19. 20:19, Richard Henderson wrote: On 6/6/19 5:15 AM, Stefan Brankovic wrote: Optimize altivec instruction vgbbd (Vector Gather Bits by Bytes by Doubleword) All ith bits (i in range 1 to 8) of each byte of doubleword element in source register are concatenated and placed into ith byte

Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-06-17 Thread Laurent Vivier
On 11/06/2019 10:42, Laurent Vivier wrote: > Michael, > > Could you pick this series in the next virtio pull request? Or perhaps Amit? Thanks, Laurent > > If you disagree with some of my patches, could you take at least the > first one (from Kashyap)? > > Thanks, > Laurent > > On 29/05/2019

Re: [Qemu-devel] [PATCH v2] vfio-ccw: use vfio_set_irq_signaling

2019-06-17 Thread Cornelia Huck
On Mon, 17 Jun 2019 12:10:36 +0200 Cornelia Huck wrote: > Use the new helper. > > Signed-off-by: Cornelia Huck > --- > v1->v2: > - Don't go overboard with deleting, and keep the get_irq_info part. > --- > hw/vfio/ccw.c | 51 +-- > 1 file changed

Re: [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema

2019-06-17 Thread Max Reitz
On 17.06.19 13:57, Kevin Wolf wrote: > Commit cd219eb1e55 added the read-zeroes option for the null-co and > null-aio block driver, but forgot to add them to the QAPI schema. > Therefore, this option wasn't available in -blockdev and blockdev-add > until now. > > Add the missing option in the sche

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-17 Thread Vladimir Sementsov-Ogievskiy
17.06.2019 15:09, Kevin Wolf wrote: > Am 17.06.2019 um 13:20 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 06.06.2019 17:07, Vladimir Sementsov-Ogievskiy wrote: >>> 06.06.2019 16:55, Eric Blake wrote: On 6/6/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > Here is s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: use valid args testing sem_timedwait

2019-06-17 Thread Laurent Vivier
Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit : > The sem_timedwait function has been annotated as requiring > non-null args in latest header files from GCC snapshot > representing the future 2.30 release. > > This causes configure to fail when -Werror is used: > > config-temp/qemu-conf.c: In

Re: [Qemu-devel] [PATCH] nvme: do not advertise support for unsupported arbitration mechanism

2019-06-17 Thread Max Reitz
On 17.06.19 08:54, Klaus Birkelund wrote: > On Fri, Jun 14, 2019 at 10:39:27PM +0200, Max Reitz wrote: >> On 06.06.19 11:25, Klaus Birkelund Jensen wrote: >>> The device mistakenly reports that the Weighted Round Robin with Urgent >>> Priority Class arbitration mechanism is supported. >>> >>> It is

Re: [Qemu-devel] [PATCH v4] virtio-scsi: restart DMA after iothread

2019-06-17 Thread Kevin Wolf
Am 12.06.2019 um 14:04 hat Stefan Hajnoczi geschrieben: > When the 'cont' command resumes guest execution the vm change state > handlers are invoked. Unfortunately there is no explicit ordering > between vm change state handlers. When two layers of code both use vm > change state handlers, we don

Re: [Qemu-devel] [PATCH v5 04/12] block/io_uring: implements interfaces for io_uring

2019-06-17 Thread Maxim Levitsky
On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote: > Aborts when sqe fails to be set as sqes cannot be returned to the ring. > > Signed-off-by: Aarushi Mehta > --- > MAINTAINERS | 7 + > block/Makefile.objs | 3 + > block/io_uring.c| 314 +

Re: [Qemu-devel] [PATCH v5 05/12] stubs: add stubs for io_uring interface

2019-06-17 Thread Maxim Levitsky
On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > Reviewed-by: Stefan Hajnoczi > --- > MAINTAINERS | 1 + > stubs/Makefile.objs | 1 + > stubs/io_uring.c| 32 > 3 files changed, 34 insertions(+) > create mode

Re: [Qemu-devel] [PATCH] tcg: Fix mmap lock assert on translation failure

2019-06-17 Thread Christophe Lyon
On Sun, 16 Jun 2019 at 23:05, Richard Henderson wrote: > > Check page flags before letting an invalid pc cause a SIGSEGV. > > Prepare for eventially validating PROT_EXEC. The current wrinkle being > that we have a problem with our implementation of signals. We should > be using a vdso like the k

Re: [Qemu-devel] [PATCH v2 6/7] iotests: amend QEMU NBD process synchronization

2019-06-17 Thread Roman Kagan
On Tue, Jun 11, 2019 at 09:02:10PM +0300, Andrey Shinkevich wrote: > Processes are dying harder under the Valgring. It results in counting > the dying process as a newborn one. Make it sure that old NBD job get > finished before starting a new one. I think this log message is confusing. The probl

Re: [Qemu-devel] [PATCH v2 6/7] iotests: amend QEMU NBD process synchronization

2019-06-17 Thread Roman Kagan
On Thu, Jun 13, 2019 at 12:59:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 11.06.2019 21:02, Andrey Shinkevich wrote: > > Processes are dying harder under the Valgring. It results in counting > > the dying process as a newborn one. Make it sure that old NBD job get > > finished before starting

[Qemu-devel] [Bug 1833053] [NEW] qemu guest crashes on spice client USB redirected device removal

2019-06-17 Thread Nikolay Kichukov
Public bug reported: Hello, I am experiencing guest crashes, which cannot be reproduced at all times, but are pretty frequent (4 out of 5 tries it would crash). The guest crashes when a previously attached USB redirected device through SPICE has been removed by the client. Steps to reproduce: 1.

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu REPOST] spapr/rtas: Force big endian compile for rtas

2019-06-17 Thread Greg Kurz
On Mon, 17 Jun 2019 21:12:05 +1000 David Gibson wrote: > On Mon, Jun 17, 2019 at 10:25:10AM +0200, Greg Kurz wrote: > 65;5603;1c> On Wed, 12 Jun 2019 12:07:23 +1000 > > Alexey Kardashevskiy wrote: > > > > > At the moment the rtas's Makefile uses generic QEMU rules which means > > > that when

Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

2019-06-17 Thread Kevin Wolf
Am 17.06.2019 um 14:18 hat Roman Kagan geschrieben: > On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote: > > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > > > The Valgrind tool fails to manage its termination when QEMU raises the > > > signal SIGKILL. Lets exclude such test c

Re: [Qemu-devel] [PATCH v5 06/12] util/async: add aio interfaces for io_uring

2019-06-17 Thread Maxim Levitsky
On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > Reviewed-by: Stefan Hajnoczi > --- > util/async.c | 36 > 1 file changed, 36 insertions(+) > > diff --git a/util/async.c b/util/async.c > index c10642a385..2709f0edc3 10

Re: [Qemu-devel] [PULL 00/11] virtio, acpi: fixes, cleanups

2019-06-17 Thread Peter Maydell
On Sun, 16 Jun 2019 at 22:36, Michael S. Tsirkin wrote: > > The following changes since commit f3d0bec9f80e4ed7796fffa834ba0a53f2094f7f: > > Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-14' > into staging (2019-06-14 14:46:13 +0100) > > are available in the Git reposit

Re: [Qemu-devel] [PATCH v5 07/12] blockdev: accept io_uring as option

2019-06-17 Thread Maxim Levitsky
On Mon, 2019-06-10 at 19:19 +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > Reviewed-by: Stefan Hajnoczi > --- > blockdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index 3f44b891eb..a2a5b32604 100644 > --- a/blockdev.c >

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-17 Thread Eric Blake
On 6/17/19 7:09 AM, Kevin Wolf wrote: >>> >>> Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called on >>> nbd driver? >>> I didn't implement it. But may be I should.. >>> >>> May aim was only to avoid extra allocation and unnecessary reads. But if we >>> implement >>> full-featu

[Qemu-devel] [PATCH v2] linux-user: fix to handle variably sized SIOCGSTAMP with new kernels

2019-06-17 Thread Daniel P . Berrangé
The SIOCGSTAMP symbol was previously defined in the asm-generic/sockios.h header file. QEMU sees that header indirectly via sys/socket.h In linux kernel commit 0768e17073dc527ccd18ed5f96ce85f9985e9115 the asm-generic/sockios.h header no longer defines SIOCGSTAMP. Instead it provides only SIOCGSTAM

Re: [Qemu-devel] [PATCH v4 0/3] numa: deprecate '-numa node, mem' and default memory distribution

2019-06-17 Thread Igor Mammedov
On Thu, 30 May 2019 10:33:16 +0200 Igor Mammedov wrote: > Changes since v3: > - simplify series by dropping idea of showing property values in > "qom-list-properties" > and use MachineInfo in QAPI schema instead > > Changes since v2: > - taking in account previous review, implement a wa

Re: [Qemu-devel] [PATCH] linux-user: fix includes to find SIOCGSTAMP with latest kernel headers

2019-06-17 Thread Daniel P . Berrangé
On Mon, Jun 17, 2019 at 01:47:48PM +0200, Laurent Vivier wrote: > Le 17/06/2019 à 13:40, Daniel P. Berrangé a écrit : > > The SIOCGSTAMP symbol was previously defined in the > > asm-generic/sockios.h header file. QEMU sees that header > > indirectly via > > > >sys/socket.h > > -> bits/sock

Re: [Qemu-devel] [PATCH 0/3] Collecting TB Execution Frequency

2019-06-17 Thread Alex Bennée
vandersonmr writes: > This is the first series of patches related to the TCGCodeQuality GSoC project > More at https://wiki.qemu.org/Features/TCGCodeQuality > > It adds an option to instrument TBs and collects their execution frequency. > The execution frequency is then store/accumulated in an

Re: [Qemu-devel] [PATCH 0/3] block: blk_co_pcache

2019-06-17 Thread Kevin Wolf
Am 17.06.2019 um 15:09 hat Eric Blake geschrieben: > On 6/17/19 7:09 AM, Kevin Wolf wrote: > > >>> > >>> Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called on > >>> nbd driver? > >>> I didn't implement it. But may be I should.. > >>> > >>> May aim was only to avoid extra alloca

Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind

2019-06-17 Thread Roman Kagan
On Mon, Jun 17, 2019 at 02:53:55PM +0200, Kevin Wolf wrote: > Am 17.06.2019 um 14:18 hat Roman Kagan geschrieben: > > On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote: > > > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben: > > > > The Valgrind tool fails to manage its termination

[Qemu-devel] [PATCH] xics: Don't call icp_kvm_realize() from icp_realize()

2019-06-17 Thread Greg Kurz
kvm_kernel_irqchip is set by xics_kvm_init() which is always called after icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the 'dual' machine". This is thus dead code. Drop it. Signed-off-by: Greg Kurz --- hw/intc/xics.c |8 1 file changed, 8 deletions(-) dif

Re: [Qemu-devel] [PATCH] xics: Don't call icp_kvm_realize() from icp_realize()

2019-06-17 Thread Cédric Le Goater
On 17/06/2019 15:25, Greg Kurz wrote: > kvm_kernel_irqchip is set by xics_kvm_init() which is always called after > icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the > 'dual' machine". I think we still need it for CPU hotplug. C. > This is thus dead code. Drop it. > >

[Qemu-devel] [PATCH 3/6] xics/kvm: Skip rollback when KVM XICS is absent

2019-06-17 Thread Greg Kurz
There is no need to rollback anything at this point, so just return an error. Signed-off-by: Greg Kurz --- hw/intc/xics_kvm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c index 534515143ea8..377ff88701c2 100644 --- a/hw/intc/xics_

[Qemu-devel] [PATCH 1/6] xics/spapr: Drop unused function declaration

2019-06-17 Thread Greg Kurz
Commit 9fb6eb7ca50c added the declaration of xics_spapr_connect(), which has no implementation and no users. This is a leftover from a previous iteration of this patch. Drop it. Signed-off-by: Greg Kurz --- include/hw/ppc/xics_spapr.h |1 - 1 file changed, 1 deletion(-) diff --git a/includ

[Qemu-devel] [PATCH 2/6] xics/spapr: Rename xics_kvm_init()

2019-06-17 Thread Greg Kurz
Switch to using the connect/disconnect terminology like we already do for XIVE. Signed-off-by: Greg Kurz --- hw/intc/xics_kvm.c |2 +- hw/ppc/spapr_irq.c |2 +- include/hw/ppc/xics_spapr.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/intc

[Qemu-devel] [PATCH 0/6] xics/kvm: Improve error handling

2019-06-17 Thread Greg Kurz
In case XICS KVM setup fails, depending on the in-kernel irqchip being required or not, QEMU used to exit or fall back to emulated XICS, and never try to setup XICS KVM again for the machine lifetime. This is no longer the case with the "dual" interrupt controller mode of the spapr machine: QEMU w

[Qemu-devel] [PATCH 4/6] xics/kvm: Always use local_err in xics_kvm_init()

2019-06-17 Thread Greg Kurz
Passing both errp and &local_err to functions is a recipe for messing things up. Since we must use &local_err for icp_kvm_realize(), use &local_err everywhere where rollback must happen and have a single call to error_propagate() them all. While here, add errno to the error message. Signed-off-by

Re: [Qemu-devel] [PATCH] i386: Fix signedness of hyperv_spinlock_attempts

2019-06-17 Thread Roman Kagan
On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote: > The current default value for hv-spinlocks is 0x (meaning > "never retry"). However, the value is stored as a signed > integer, making the getter of the hv-spinlocks QOM property > return -1 instead of 0x. > > Fix

[Qemu-devel] [PATCH 6/6] xics/kvm: Add proper rollback to xics_kvm_init()

2019-06-17 Thread Greg Kurz
Make xics_kvm_disconnect() able to undo the changes of a partial execution of xics_kvm_connect() and use it to perform rollback. Note that kvmppc_define_rtas_kernel_token(0) never fails, no matter the RTAS call has been defined or not. Signed-off-by: Greg Kurz --- hw/intc/xics_kvm.c | 11

[Qemu-devel] [PATCH 5/6] xics/kvm: Add error propagation to ic*_set_kvm_state() functions

2019-06-17 Thread Greg Kurz
This allows errors happening there to be propagated up to spapr_irq, just like XIVE already does. Signed-off-by: Greg Kurz --- hw/intc/xics.c| 39 ++- hw/intc/xics_kvm.c| 37 ++--- include/hw/ppc/xics.h |6 ++

Re: [Qemu-devel] [PATCH] xics: Don't call icp_kvm_realize() from icp_realize()

2019-06-17 Thread Greg Kurz
On Mon, 17 Jun 2019 15:46:14 +0200 Cédric Le Goater wrote: > On 17/06/2019 15:25, Greg Kurz wrote: > > kvm_kernel_irqchip is set by xics_kvm_init() which is always called after > > icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the > > 'dual' machine". > > I think we st

Re: [Qemu-devel] [Qemu-arm] [NOTFORMERGE PATCH v2 23/23] Missing symbols when building with --disable-tcg

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > While it might be normal to disable PSCI on KVM, I doubt the > VFP helpers are correct ;) > > Anyway this allow to link the binary and run a KVM guest. But also: /home/alex/lsrc/qemu.git/target/arm/helper.c: In function ‘S1_ptw_translate’: /home/alex/lsrc/qemu

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 09/23] target/arm: Move code around

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > To ease the review of the next commit, move the > write_v7m_exception() function around. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 40 > 1 file changed, 20 inser

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 07/23] target/arm: Declare some function publicly

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > In few commits we will split the v7-M functions from this file. > Some function will be called out of helper.c. Declare them > in the "internals.h" header. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/helper.c| 6

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 10/23] target/arm: Move the v7-M Security State helpers to v7m_helper

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > target/arm/helper.c | 73 - > target/arm/v7m_helper.c | 73 + > 2 files changed, 73 insertions(+), 73

Re: [Qemu-devel] [RFC PATCH v2 22/23] target/arm: Restrict semi-hosting to TCG

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Per Peter Maydell: > > semihosting hooks either SVC or HLT instructions, and inside KVM > both of those go to EL1, ie to the guest, and can't be trapped to > KVM. > > Let check_for_semihosting() return False when not running on TCG. > > Signed-off-by: Phil

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 11/23] target/arm: Declare v7m_cpacr_pass() publicly

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > In the next commit we will move exception handling routines to > v7m_helper, so this function will be called from 2 different > files. Declare it inlined in the "internals.h" header. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- >

  1   2   3   4   >