Eduardo Habkost writes:
> The current default value for hv-spinlocks is 0x (meaning
> "never retry"). However, the value is stored as a signed
> integer, making the getter of the hv-spinlocks QOM property
> return -1 instead of 0x.
>
> Fix this by changing the type of X86CPU::hyp
On 6/17/2019 4:07 AM, Igor Mammedov wrote:
On Wed, 8 May 2019 14:17:26 +0800
Tao Xu wrote:
From: Liu Jingqi
OSPM evaluates HMAT only during system initialization.
Any changes to the HMAT state at runtime or information
regarding HMAT for hot plug are communicated using _HMA method.
_HMA is
Hi,
> We serialize this information in a similar way to the "bootorder"
> interface.
> The fw_cfg entry is "bootdevices" and it serializes a struct.
Why "bootdevices"? I'd suggest to use "geometry" or "lchs" instead.
> At the moment the struct holds the values of logical CHS values but it
> c
> On 17 Jun 2019, at 10:20, Gerd Hoffmann wrote:
>
> Hi,
>
>> We serialize this information in a similar way to the "bootorder"
>> interface.
>> The fw_cfg entry is "bootdevices" and it serializes a struct.
>
> Why "bootdevices"? I'd suggest to use "geometry" or "lchs" instead.
True, if w
> On 17 Jun 2019, at 9:50, Gerd Hoffmann wrote:
>
> Hi,
>
>>> Ok, given that seabios has no setup any manual configuration needs to be
>>> done via qemu.
>>>
>>> But why do we need a new interface for that? IDE can pass the geometry
>>> to the guest. virtio-blk has support too (VIRTIO_BL
Hi all,
I'm thinking about how to support multiple namespaces in the NVMe
device. My first idea was to add a "namespaces" property array to the
device that references blockdevs, but as Laszlo writes below, this might
not be the best idea. It also makes it troublesome to add per-namespace
parameter
Richard Henderson writes:
> On 6/14/19 10:11 AM, Alex Bennée wrote:
>> From: "Emilio G. Cota"
>>
>> This will allow us to trace 16B-long memory accesses.
>>
>> Reviewed-by: Alex Bennée
>> Signed-off-by: Emilio G. Cota
>> ---
>> trace-events | 2 +-
>> 1 file changed, 1 insertion(+), 1 delet
On Wed, 12 Jun 2019 12:07:23 +1000
Alexey Kardashevskiy wrote:
> At the moment the rtas's Makefile uses generic QEMU rules which means
> that when QEMU is compiled on a little endian system, the spapr-rtas.bin
> is compiled as little endian too which is incorrect as it is always
> executed in big
Hi,
> Keep it extendible for a low price of ABI + “bootdevices” name.
> Or go strict and rename to “bios-geometries”?
The name should reflect what is in there, so "bios-geometries" looks
better to me. I'd also keep it strict, unless we have at least a vague
idea what might be a useful future e
On 14/06/2019 14:10, Palmer Dabbelt wrote:
> Sorry this took a while to fix, I've just sent a patch to fix the memory leak.
Thank you for taking care of this!
Am 15.06.2019 um 22:31 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 14.06.2019 um 11:06 hat Markus Armbruster geschrieben:
> >> Kevin Wolf writes:
> >>
> >> > monitor.c mixes a lot of different things in a single file: The core
> >> > monitor infrastructure, HMP infrastrctur
Gerd Hoffmann writes:
> This patch series changes the way virtual machines for test builds are
> managed. They are created locally on the developer machine now. The
> installer is booted on the serial console and the scripts walks through
> the dialogs to install and configure the guest.
>
>
Public bug reported:
Calling get-fsinfo on a virtual machine does not include ZFS
(zfsonlinux, debian guest tested) volumes. Calling on a system with a
single ZFS disk (ZFS as root fs) simply returns '[]', if other disks
exist on the guest it only shows these.
Expected behaviour: Show file system
On Fri, 14 Jun 2019 11:41:41 -0400
Eric Farman wrote:
> On 6/14/19 11:06 AM, Auger Eric wrote:
> > Hi Eric,
> >
> > On 6/14/19 4:30 PM, Eric Farman wrote:
> >>
> >>
> >> On 6/14/19 5:27 AM, Cornelia Huck wrote:
> >>> Use the new helper.
> >>>
> >>> Signed-off-by: Cornelia Huck
> >>> ---
> >
vandersonmr writes:
> A new hash map was added to store the accumulated execution
> frequency of the TBs even after tb_flush events. A dump
> function was also added as a way to visualize these frequencies.
>
> Signed-off-by: vandersonmr
I forgot to mention the formatting looks a little off h
[repeat of reply to wrong email...]
vandersonmr writes:
> An uint64_t counter was added in the TranslationBlock struct and
> it is incremented every time that the TB is executed.
>
> Signed-off-by: vandersonmr
> ---
> accel/tcg/tcg-runtime.c | 6 ++
> accel/tcg/tcg-runtime.h | 2 ++
>
Ok,
I’ll resubmit this patch series in v3, as well as v2 for SeaBIOS soon enough.
* Change “bootdevices” to “bios-geometry”, and remove the struct size
* Add cpu_to_le32 fix as Laszlo suggested or big endian hosts
* Fix last qtest commit - automatic docker tester for some reason does not have
qe
Use the new helper.
Signed-off-by: Cornelia Huck
---
v1->v2:
- Don't go overboard with deleting, and keep the get_irq_info part.
---
hw/vfio/ccw.c | 51 +--
1 file changed, 13 insertions(+), 38 deletions(-)
diff --git a/hw/vfio/ccw.c b/hw/vfio/cc
vandersonmr writes:
> This is the first series of patches related to the TCGCodeQuality GSoC project
> More at https://wiki.qemu.org/Features/TCGCodeQuality
>
> It adds an option to instrument TBs and collects their execution frequency.
> The execution frequency is then store/accumulated in an
14.06.2019 23:03, Max Reitz wrote:
> On 14.06.19 18:22, Vladimir Sementsov-Ogievskiy wrote:
>> 14.06.2019 15:57, Max Reitz wrote:
>>> On 14.06.19 11:04, Vladimir Sementsov-Ogievskiy wrote:
13.06.2019 18:57, Max Reitz wrote:
> On 29.05.19 17:46, Vladimir Sementsov-Ogievskiy wrote:
>> Ba
* Peng Tao (tao.p...@linux.alibaba.com) wrote:
> By removing the share ram check, qemu is able to migrate
> to private destination ram when x-ignore-shared capability
> is on. Then we can create multiple destination VMs based
> on the same source VM.
>
> This changes the x-ignore-shared migration
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote:
> * Peng Tao (tao.p...@linux.alibaba.com) wrote:
> > By removing the share ram check, qemu is able to migrate
> > to private destination ram when x-ignore-shared capability
> > is on. Then we can create multiple destination VMs based
> > on the
On Fri, 14 Jun 2019 at 21:25, Laszlo Ersek wrote:
>
> The following changes since commit f3d0bec9f80e4ed7796fffa834ba0a53f2094f7f:
>
> Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-14'
> into staging (2019-06-14 14:46:13 +0100)
>
> are available in the Git repository at
On 6/16/19 1:41 PM, Hongbo Zhang wrote:
> On Mon, 3 Jun 2019 at 18:54, Philippe Mathieu-Daudé wrote:
>>
>> Hi Hongbo, Ard.
>>
>> On 4/18/19 6:04 AM, Hongbo Zhang wrote:
>>> Following the previous patch, this patch adds peripheral devices to the
>>> newly introduced SBSA-ref machine.
>>>
>>> Signed
Hi Connie,
On 6/17/19 12:10 PM, Cornelia Huck wrote:
> Use the new helper.
>
> Signed-off-by: Cornelia Huck
Reviewed-by: Eric Auger
Thanks
Eric
> ---
> v1->v2:
> - Don't go overboard with deleting, and keep the get_irq_info part.
> ---
> hw/vfio/ccw.c | 51 +-
Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben:
> The Valgrind tool fails to manage its termination when QEMU raises the
> signal SIGKILL. Lets exclude such test cases from running under the
> Valgrind because there is no sense to check memory issues that way.
>
> Signed-off-by: Andrey S
06.06.2019 17:07, Vladimir Sementsov-Ogievskiy wrote:
> 06.06.2019 16:55, Eric Blake wrote:
>> On 6/6/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Hi all!
>>>
>>> Here is small new io API: blk_co_pcache, which does copy-on-read without
>>> extra buffer for read data. This means that only par
Am 13.06.2019 um 11:52 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 11.06.2019 21:02, Andrey Shinkevich wrote:
> > The Valgrind uses the exported variable TMPDIR and fails if the
> > directory does not exist. Let us exclude such a test case from
> > being run under the Valgrind.
> >
> > Signed-
[added Markus to Cc for his view on options]
vandersonmr writes:
> Added -execfreq to enable execution frequency counting and dump
> all the TB's addresses and their execution frequency at the end
> of the execution.
>
> Signed-off-by: vandersonmr
This works well enough but we are going to n
On 6.6.19. 18:46, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
+tcg_gen_addi_i64(result, sh, 7);
+for (i = 7; i >= 1; i--) {
+tcg_gen_shli_i64(tmp, sh, i * 8);
+tcg_gen_or_i64(result, result, tmp);
+tcg_gen_addi_i64(sh, sh, 1);
+}
Bet
On 6.6.19. 19:13, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
Stefan Brankovic (8):
target/ppc: Optimize emulation of lvsl and lvsr instructions
target/ppc: Optimize emulation of vsl and vsr instructions
target/ppc: Optimize emulation of vpkpx instruction
ta
On 6/17/19 6:10 AM, Cornelia Huck wrote:
> Use the new helper.
>
> Signed-off-by: Cornelia Huck
Nice simplification!
Reviewed-by: Eric Farman
> ---
> v1->v2:
> - Don't go overboard with deleting, and keep the get_irq_info part.
(Sorry about that. :)
> ---
> hw/vfio/ccw.c | 51
> On 16 Jun 2019, at 15:38, Liran Alon wrote:
>
>
>
>> On 15 Jun 2019, at 3:57, Liran Alon wrote:
>>
>>> On 15 Jun 2019, at 3:42, Paolo Bonzini wrote:
>>>
>>> From: Liran Alon
>>>
>>> +static bool is_vmx_enabled(CPUX86State *env)
>>> +{
>>> +return (IS_INTEL_CPU(env) && (env->cr[4]
Philippe Mathieu-Daudé writes:
> Group ARM objects together, TCG related ones at the bottom.
> This will help when restricting TCG-only objects.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/Makefile.objs | 9 ++---
> 1 file changed, 6 insertions
On Mon, Jun 17, 2019 at 10:25:10AM +0200, Greg Kurz wrote:
65;5603;1c> On Wed, 12 Jun 2019 12:07:23 +1000
> Alexey Kardashevskiy wrote:
>
> > At the moment the rtas's Makefile uses generic QEMU rules which means
> > that when QEMU is compiled on a little endian system, the spapr-rtas.bin
> > is c
Philippe Mathieu-Daudé writes:
> Group Aarch64 objects together, TCG related ones at the bottom.
> This will help when restricting TCG-only objects.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/Makefile.objs | 5 +++--
> 1 file changed, 3 insertions
On 6.6.19. 19:03, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
+tcg_gen_subi_i64(tmp, sh, 64);
+tcg_gen_neg_i64(tmp, tmp);
Better as
tcg_gen_subfi_i64(tmp, 64, sh);
I was aware there must be way of doing it in a single tcg invocation,
but couldn't find r
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
> Reviewed-by: Robert Bradford
> Reviewed-by: Samuel Ortiz
Reviewed-by: Alex Bennée
> ---
> target/arm/helper.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
Philippe Mathieu-Daudé writes:
> Group ARM objects together, TCG related ones at the bottom.
> This will help when restricting TCG-only objects.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/Makefile.objs | 9 ++---
> 1 file changed, 6 insertions
Philippe Mathieu-Daudé writes:
> Group KVM objects together.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/Makefile.objs | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/target/arm/Makefile.objs b/target/arm/Makefile.
08.06.2019 1:26, John Snow wrote:
>
>
> On 6/3/19 8:00 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>>
>> Here is block-dirty-bitmap-remove transaction action.
>>
>> It is used to do transactional movement of the bitmap (which is
>> possible in conjunction with merge command). Transactional
Philippe Mathieu-Daudé writes:
> Since commit 8c06fbdf36b checkpatch.pl enforce a new multiline
> comment syntax. Since we'll move this code around, fix its style
> first.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/helper.c| 213 ++
Philippe Mathieu-Daudé writes:
> Group SOFTMMU objects together.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/Makefile.objs | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/arm/Makefile.objs b/target/arm/Makefi
Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben:
> The Valgrind tool reports about an uninitialised memory usage when the
> initialization is actually not needed. For example, the buffer 'buf'
> instantiated on a stack of the function guess_disk_lchs().
I would be careful with calling ini
The sem_timedwait function has been annotated as requiring
non-null args in latest header files from GCC snapshot
representing the future 2.30 release.
This causes configure to fail when -Werror is used:
config-temp/qemu-conf.c: In function ‘main’:
config-temp/qemu-conf.c:2:25: error: null argume
On 6.6.19. 22:38, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
Optimize Altivec instruction vclzh (Vector Count Leading Zeros Halfword).
This instruction counts the number of leading zeros of each halfword element
in source register and places result in the appropriate h
The SIOCGSTAMP symbol was previously defined in the
asm-generic/sockios.h header file. QEMU sees that header
indirectly via
sys/socket.h
-> bits/socket.h
-> asm/socket.h
-> asm-generic/socket.h
-> asm/sockios.h
-> asm-generic/sockios.h
Checking that we're not using the in-kernel XICS is ok with the "xics"
interrupt controller mode, but it is definitely not enough with the
other modes since the guest could be using XIVE.
Ensure XIVE is not in use when emulated XICS RTAS/hypercalls are
called.
Signed-off-by: Greg Kurz
---
hw/in
On 6.6.19. 22:43, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
+/*
+ * We use this macro if one instruction is realized with direct
+ * translation, and second one with helper.
+ */
+#define GEN_VXFORM_TRANS_DUAL(name0, flg0, flg2_0, name1, flg1, flg2_1)\
+static void gl
Philippe Mathieu-Daudé writes:
> From: Samuel Ortiz
>
> In preparation for supporting TCG disablement on ARM, we move most
> of TCG related v7m helpers and APIs into their own file.
>
> Signed-off-by: Samuel Ortiz
> [PMD: Patch rewritten]
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Is th
Commit cd219eb1e55 added the read-zeroes option for the null-co and
null-aio block driver, but forgot to add them to the QAPI schema.
Therefore, this option wasn't available in -blockdev and blockdev-add
until now.
Add the missing option in the schema to make it available there, too.
Signed-off-b
Le 17/06/2019 à 13:40, Daniel P. Berrangé a écrit :
> The SIOCGSTAMP symbol was previously defined in the
> asm-generic/sockios.h header file. QEMU sees that header
> indirectly via
>
>sys/socket.h
> -> bits/socket.h
> -> asm/socket.h
> -> asm-generic/socket.h
>
On Thu, Jun 13, 2019 at 12:47:21PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 11.06.2019 21:02, Andrey Shinkevich wrote:
> > The Valgrind tool fails to manage its termination when QEMU raises the
> > signal SIGKILL. Lets exclude such test cases from running under the
> > Valgrind because there is
Am 17.06.2019 um 13:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 06.06.2019 17:07, Vladimir Sementsov-Ogievskiy wrote:
> > 06.06.2019 16:55, Eric Blake wrote:
> >> On 6/6/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote:
> >>> Hi all!
> >>>
> >>> Here is small new io API: blk_co_pcache, which d
On 6.6.19. 20:34, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
+for (i = 0; i < 2; i++) {
+if (i == 0) {
+/* Get high doubleword element of vB in avr. */
+get_avr64(avr, VB, true);
+} else {
+/* Get low doubleword e
On 6/17/19 1:42 PM, Alex Bennée wrote:
> Philippe Mathieu-Daudé writes:
>
>> From: Samuel Ortiz
>>
>> In preparation for supporting TCG disablement on ARM, we move most
>> of TCG related v7m helpers and APIs into their own file.
>>
>> Signed-off-by: Samuel Ortiz
>> [PMD: Patch rewritten]
>> Sig
On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote:
> Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben:
> > The Valgrind tool fails to manage its termination when QEMU raises the
> > signal SIGKILL. Lets exclude such test cases from running under the
> > Valgrind because there is no
On 6.6.19. 20:19, Richard Henderson wrote:
On 6/6/19 5:15 AM, Stefan Brankovic wrote:
Optimize altivec instruction vgbbd (Vector Gather Bits by Bytes by Doubleword)
All ith bits (i in range 1 to 8) of each byte of doubleword element in
source register are concatenated and placed into ith byte
On 11/06/2019 10:42, Laurent Vivier wrote:
> Michael,
>
> Could you pick this series in the next virtio pull request?
Or perhaps Amit?
Thanks,
Laurent
>
> If you disagree with some of my patches, could you take at least the
> first one (from Kashyap)?
>
> Thanks,
> Laurent
>
> On 29/05/2019
On Mon, 17 Jun 2019 12:10:36 +0200
Cornelia Huck wrote:
> Use the new helper.
>
> Signed-off-by: Cornelia Huck
> ---
> v1->v2:
> - Don't go overboard with deleting, and keep the get_irq_info part.
> ---
> hw/vfio/ccw.c | 51 +--
> 1 file changed
On 17.06.19 13:57, Kevin Wolf wrote:
> Commit cd219eb1e55 added the read-zeroes option for the null-co and
> null-aio block driver, but forgot to add them to the QAPI schema.
> Therefore, this option wasn't available in -blockdev and blockdev-add
> until now.
>
> Add the missing option in the sche
17.06.2019 15:09, Kevin Wolf wrote:
> Am 17.06.2019 um 13:20 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> 06.06.2019 17:07, Vladimir Sementsov-Ogievskiy wrote:
>>> 06.06.2019 16:55, Eric Blake wrote:
On 6/6/19 8:48 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Here is s
Le 17/06/2019 à 13:41, Daniel P. Berrangé a écrit :
> The sem_timedwait function has been annotated as requiring
> non-null args in latest header files from GCC snapshot
> representing the future 2.30 release.
>
> This causes configure to fail when -Werror is used:
>
> config-temp/qemu-conf.c: In
On 17.06.19 08:54, Klaus Birkelund wrote:
> On Fri, Jun 14, 2019 at 10:39:27PM +0200, Max Reitz wrote:
>> On 06.06.19 11:25, Klaus Birkelund Jensen wrote:
>>> The device mistakenly reports that the Weighted Round Robin with Urgent
>>> Priority Class arbitration mechanism is supported.
>>>
>>> It is
Am 12.06.2019 um 14:04 hat Stefan Hajnoczi geschrieben:
> When the 'cont' command resumes guest execution the vm change state
> handlers are invoked. Unfortunately there is no explicit ordering
> between vm change state handlers. When two layers of code both use vm
> change state handlers, we don
On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote:
> Aborts when sqe fails to be set as sqes cannot be returned to the ring.
>
> Signed-off-by: Aarushi Mehta
> ---
> MAINTAINERS | 7 +
> block/Makefile.objs | 3 +
> block/io_uring.c| 314 +
On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta
> Reviewed-by: Stefan Hajnoczi
> ---
> MAINTAINERS | 1 +
> stubs/Makefile.objs | 1 +
> stubs/io_uring.c| 32
> 3 files changed, 34 insertions(+)
> create mode
On Sun, 16 Jun 2019 at 23:05, Richard Henderson
wrote:
>
> Check page flags before letting an invalid pc cause a SIGSEGV.
>
> Prepare for eventially validating PROT_EXEC. The current wrinkle being
> that we have a problem with our implementation of signals. We should
> be using a vdso like the k
On Tue, Jun 11, 2019 at 09:02:10PM +0300, Andrey Shinkevich wrote:
> Processes are dying harder under the Valgring. It results in counting
> the dying process as a newborn one. Make it sure that old NBD job get
> finished before starting a new one.
I think this log message is confusing.
The probl
On Thu, Jun 13, 2019 at 12:59:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 11.06.2019 21:02, Andrey Shinkevich wrote:
> > Processes are dying harder under the Valgring. It results in counting
> > the dying process as a newborn one. Make it sure that old NBD job get
> > finished before starting
Public bug reported:
Hello,
I am experiencing guest crashes, which cannot be reproduced at all
times, but are pretty frequent (4 out of 5 tries it would crash). The
guest crashes when a previously attached USB redirected device through
SPICE has been removed by the client.
Steps to reproduce:
1.
On Mon, 17 Jun 2019 21:12:05 +1000
David Gibson wrote:
> On Mon, Jun 17, 2019 at 10:25:10AM +0200, Greg Kurz wrote:
> 65;5603;1c> On Wed, 12 Jun 2019 12:07:23 +1000
> > Alexey Kardashevskiy wrote:
> >
> > > At the moment the rtas's Makefile uses generic QEMU rules which means
> > > that when
Am 17.06.2019 um 14:18 hat Roman Kagan geschrieben:
> On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote:
> > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben:
> > > The Valgrind tool fails to manage its termination when QEMU raises the
> > > signal SIGKILL. Lets exclude such test c
On Mon, 2019-06-10 at 19:18 +0530, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta
> Reviewed-by: Stefan Hajnoczi
> ---
> util/async.c | 36
> 1 file changed, 36 insertions(+)
>
> diff --git a/util/async.c b/util/async.c
> index c10642a385..2709f0edc3 10
On Sun, 16 Jun 2019 at 22:36, Michael S. Tsirkin wrote:
>
> The following changes since commit f3d0bec9f80e4ed7796fffa834ba0a53f2094f7f:
>
> Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-14'
> into staging (2019-06-14 14:46:13 +0100)
>
> are available in the Git reposit
On Mon, 2019-06-10 at 19:19 +0530, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta
> Reviewed-by: Stefan Hajnoczi
> ---
> blockdev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 3f44b891eb..a2a5b32604 100644
> --- a/blockdev.c
>
On 6/17/19 7:09 AM, Kevin Wolf wrote:
>>>
>>> Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called on
>>> nbd driver?
>>> I didn't implement it. But may be I should..
>>>
>>> May aim was only to avoid extra allocation and unnecessary reads. But if we
>>> implement
>>> full-featu
The SIOCGSTAMP symbol was previously defined in the
asm-generic/sockios.h header file. QEMU sees that header
indirectly via sys/socket.h
In linux kernel commit 0768e17073dc527ccd18ed5f96ce85f9985e9115
the asm-generic/sockios.h header no longer defines SIOCGSTAMP.
Instead it provides only SIOCGSTAM
On Thu, 30 May 2019 10:33:16 +0200
Igor Mammedov wrote:
> Changes since v3:
> - simplify series by dropping idea of showing property values in
> "qom-list-properties"
> and use MachineInfo in QAPI schema instead
>
> Changes since v2:
> - taking in account previous review, implement a wa
On Mon, Jun 17, 2019 at 01:47:48PM +0200, Laurent Vivier wrote:
> Le 17/06/2019 à 13:40, Daniel P. Berrangé a écrit :
> > The SIOCGSTAMP symbol was previously defined in the
> > asm-generic/sockios.h header file. QEMU sees that header
> > indirectly via
> >
> >sys/socket.h
> > -> bits/sock
vandersonmr writes:
> This is the first series of patches related to the TCGCodeQuality GSoC project
> More at https://wiki.qemu.org/Features/TCGCodeQuality
>
> It adds an option to instrument TBs and collects their execution frequency.
> The execution frequency is then store/accumulated in an
Am 17.06.2019 um 15:09 hat Eric Blake geschrieben:
> On 6/17/19 7:09 AM, Kevin Wolf wrote:
>
> >>>
> >>> Hmm, don't you think that blk_co_pcache sends NBD_CMD_CACHE if called on
> >>> nbd driver?
> >>> I didn't implement it. But may be I should..
> >>>
> >>> May aim was only to avoid extra alloca
On Mon, Jun 17, 2019 at 02:53:55PM +0200, Kevin Wolf wrote:
> Am 17.06.2019 um 14:18 hat Roman Kagan geschrieben:
> > On Mon, Jun 17, 2019 at 01:15:04PM +0200, Kevin Wolf wrote:
> > > Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben:
> > > > The Valgrind tool fails to manage its termination
kvm_kernel_irqchip is set by xics_kvm_init() which is always called after
icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the
'dual' machine".
This is thus dead code. Drop it.
Signed-off-by: Greg Kurz
---
hw/intc/xics.c |8
1 file changed, 8 deletions(-)
dif
On 17/06/2019 15:25, Greg Kurz wrote:
> kvm_kernel_irqchip is set by xics_kvm_init() which is always called after
> icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the
> 'dual' machine".
I think we still need it for CPU hotplug.
C.
> This is thus dead code. Drop it.
>
>
There is no need to rollback anything at this point, so just return an
error.
Signed-off-by: Greg Kurz
---
hw/intc/xics_kvm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c
index 534515143ea8..377ff88701c2 100644
--- a/hw/intc/xics_
Commit 9fb6eb7ca50c added the declaration of xics_spapr_connect(), which
has no implementation and no users.
This is a leftover from a previous iteration of this patch. Drop it.
Signed-off-by: Greg Kurz
---
include/hw/ppc/xics_spapr.h |1 -
1 file changed, 1 deletion(-)
diff --git a/includ
Switch to using the connect/disconnect terminology like we already do for
XIVE.
Signed-off-by: Greg Kurz
---
hw/intc/xics_kvm.c |2 +-
hw/ppc/spapr_irq.c |2 +-
include/hw/ppc/xics_spapr.h |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/intc
In case XICS KVM setup fails, depending on the in-kernel irqchip being
required or not, QEMU used to exit or fall back to emulated XICS, and
never try to setup XICS KVM again for the machine lifetime.
This is no longer the case with the "dual" interrupt controller mode of
the spapr machine: QEMU w
Passing both errp and &local_err to functions is a recipe for messing
things up.
Since we must use &local_err for icp_kvm_realize(), use &local_err
everywhere where rollback must happen and have a single call to
error_propagate() them all. While here, add errno to the error
message.
Signed-off-by
On Sat, Jun 15, 2019 at 05:05:05PM -0300, Eduardo Habkost wrote:
> The current default value for hv-spinlocks is 0x (meaning
> "never retry"). However, the value is stored as a signed
> integer, making the getter of the hv-spinlocks QOM property
> return -1 instead of 0x.
>
> Fix
Make xics_kvm_disconnect() able to undo the changes of a partial execution
of xics_kvm_connect() and use it to perform rollback.
Note that kvmppc_define_rtas_kernel_token(0) never fails, no matter the
RTAS call has been defined or not.
Signed-off-by: Greg Kurz
---
hw/intc/xics_kvm.c | 11
This allows errors happening there to be propagated up to spapr_irq,
just like XIVE already does.
Signed-off-by: Greg Kurz
---
hw/intc/xics.c| 39 ++-
hw/intc/xics_kvm.c| 37 ++---
include/hw/ppc/xics.h |6 ++
On Mon, 17 Jun 2019 15:46:14 +0200
Cédric Le Goater wrote:
> On 17/06/2019 15:25, Greg Kurz wrote:
> > kvm_kernel_irqchip is set by xics_kvm_init() which is always called after
> > icp_realize() since commit 3f777abc7107 "spapr/irq: add KVM support to the
> > 'dual' machine".
>
> I think we st
Philippe Mathieu-Daudé writes:
> While it might be normal to disable PSCI on KVM, I doubt the
> VFP helpers are correct ;)
>
> Anyway this allow to link the binary and run a KVM guest.
But also:
/home/alex/lsrc/qemu.git/target/arm/helper.c: In function ‘S1_ptw_translate’:
/home/alex/lsrc/qemu
Philippe Mathieu-Daudé writes:
> To ease the review of the next commit, move the
> write_v7m_exception() function around.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/helper.c | 40
> 1 file changed, 20 inser
Philippe Mathieu-Daudé writes:
> In few commits we will split the v7-M functions from this file.
> Some function will be called out of helper.c. Declare them
> in the "internals.h" header.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/helper.c| 6
Philippe Mathieu-Daudé writes:
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
> target/arm/helper.c | 73 -
> target/arm/v7m_helper.c | 73 +
> 2 files changed, 73 insertions(+), 73
Philippe Mathieu-Daudé writes:
> Per Peter Maydell:
>
> semihosting hooks either SVC or HLT instructions, and inside KVM
> both of those go to EL1, ie to the guest, and can't be trapped to
> KVM.
>
> Let check_for_semihosting() return False when not running on TCG.
>
> Signed-off-by: Phil
Philippe Mathieu-Daudé writes:
> In the next commit we will move exception handling routines to
> v7m_helper, so this function will be called from 2 different
> files. Declare it inlined in the "internals.h" header.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
> ---
>
1 - 100 of 399 matches
Mail list logo