Re: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-06-16 Thread Mark Cave-Ayland
On 12/06/2019 02:04, David Gibson wrote: > On Sun, Jun 02, 2019 at 12:08:50PM +0100, Mark Cave-Ayland wrote: >> Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX >> registers are in host endian order" functions getVSR() and putVSR() which >> used >> to convert the VSR regi

Re: [Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-06-16 Thread Mark Cave-Ayland
On 12/06/2019 20:47, Richard Henderson wrote: > On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: >> -getVSR(xt_num, &xt, env); \ >> + \ >> nb = (nb >= 16) ? 16 : nb;

Re: [Qemu-devel] [PATCH v2 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
On 12/06/2019 20:45, Richard Henderson wrote: > On 6/2/19 4:08 AM, Mark Cave-Ayland wrote: >> void helper_xvxsigsp(CPUPPCState *env, uint32_t opcode) >> { >> -ppc_vsr_t xt, xb; >> +ppc_vsr_t *xt = &env->vsr[xT(opcode)]; >> +ppc_vsr_t *xb = &env->vsr[xB(opcode)]; >> +ppc_vsr_t t =

Re: [Qemu-devel] [PATCH] RISC-V: Fix a memory leak when realizing a sifive_e

2019-06-16 Thread Palmer Dabbelt
On Fri, 14 Jun 2019 05:25:50 PDT (-0700), phi...@redhat.com wrote: On 6/14/19 2:08 PM, Palmer Dabbelt wrote: Coverity pointed out a memory leak in riscv_sifive_e_soc_realize(), where a pair of recently added MemoryRegion instances would not be freed if there were errors elsewhere in the function

Re: [Qemu-devel] [PATCH 4/7] linux-headers: import improved definition of KVM_GET/SET_NESTED_STATE structs

2019-06-16 Thread Liran Alon
> On 15 Jun 2019, at 3:42, Paolo Bonzini wrote: > > This patch improves the KVM_GET/SET_NESTED_STATE structs by detailing > the format of VMX nested state in a struct. The VMX nested state is > accessible through struct kvm_vmx_nested_state though, to avoid > changing the size of the structs,

Re: [Qemu-devel] [PATCH v7 2/2] hw/arm: Add arm SBSA reference machine, devices part

2019-06-16 Thread Hongbo Zhang
On Mon, 3 Jun 2019 at 18:54, Philippe Mathieu-Daudé wrote: > > Hi Hongbo, Ard. > > On 4/18/19 6:04 AM, Hongbo Zhang wrote: > > Following the previous patch, this patch adds peripheral devices to the > > newly introduced SBSA-ref machine. > > > > Signed-off-by: Hongbo Zhang > > --- > > hw/arm/sbs

Re: [Qemu-devel] [PATCH V1] Introducing virtio-example.

2019-06-16 Thread Yoni Bettan
Hi Stefan and thank you for your review. I am sorry for my late response, I have updated the specification according to your review (and Eduardo's review) and sent it to the virtio-comment mailing list. On 5/15/19 12:43 PM, Stefan Hajnoczi wrote: On Sun, Apr 28, 2019 at 04:26:31PM +0300, Yon

[Qemu-devel] [PATCH v3 00/15] target/ppc: remove getVSR()/putVSR() and further tidy-up

2019-06-16 Thread Mark Cave-Ayland
With the conversion of PPC VSX registers to host endian during the 4.0 development cycle, the VSX helpers getVSR() and putVSR() which were used to convert between big endian and host endian (and are currently just a no-op) can now be removed. This eliminates an extra copy for each VSX source regi

[Qemu-devel] [PATCH v3 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-06-16 Thread Mark Cave-Ayland
Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which used to convert the VSR registers into host endian order are no longer required. Signed-off-by: Mark Cave-Ayland --- target/ppc/mem_helper.c | 23 ++

[Qemu-devel] [PATCH v3 03/15] target/ppc: remove getVSR()/putVSR() from int_helper.c

2019-06-16 Thread Mark Cave-Ayland
Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which used to convert the VSR registers into host endian order are no longer required. Now that there are now no more users of getVSR()/putVSR() these funct

[Qemu-devel] [PATCH v3 05/15] target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X3 macro which performs the decode based upon xT, xA and xB at translation time. With the previous changes to the VSX_CMP generator and helper macros the opcode parameter is no longer required in

[Qemu-devel] [PATCH v3 09/15] target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X1 macro which performs the decode based upon xB at translation time. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/fpu_helper.c | 6 ++ target

[Qemu-devel] [PATCH v3 06/15] target/ppc: introduce separate generator and helper for xscvqpdp

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new generator and helper function which perform the decode based upon xT and xB at translation time. The xscvqpdp helper is the only 2 parameter xT/xB implementation that requires the opcode to be passed as an addi

[Qemu-devel] [PATCH v3 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new VSX_CMP macro which performs the decode based upon xT, xA and xB at translation time. Subsequent commits will make the same changes for other instructions however the xvcmp* instructions are different in that t

[Qemu-devel] [PATCH v3 08/15] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X2_AB macro which performs the decode based upon xA and xB at translation time. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/fpu_helper.c | 15

[Qemu-devel] [PATCH v3 07/15] target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_X2 macro which performs the decode based upon xT and xB at translation time. With the previous change to the xscvqpdp generator and helper functions the opcode parameter is no longer required in

Re: [Qemu-devel] [PATCH 3/7] KVM: i386: Add support for KVM_CAP_EXCEPTION_PAYLOAD

2019-06-16 Thread Liran Alon
> On 15 Jun 2019, at 3:57, Liran Alon wrote: > >> On 15 Jun 2019, at 3:42, Paolo Bonzini wrote: >> >> From: Liran Alon >> >> +static bool is_vmx_enabled(CPUX86State *env) >> +{ >> +return (IS_INTEL_CPU(env) && (env->cr[4] & CR4_VMXE_MASK)); >> +} >> + >> +static bool is_svm_enabled(CPU

[Qemu-devel] [PATCH v3 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order" functions getVSR() and putVSR() which used to convert the VSR registers into host endian order are no longer required. Signed-off-by: Mark Cave-Ayland --- target/ppc/fpu_helper.c | 762 +

[Qemu-devel] [PATCH v3 11/15] target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_R2 macro which performs the decode based upon rD and rB at translation time. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/fpu_helper.c | 30 +++

[Qemu-devel] [PATCH v3 12/15] target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_R2_AB macro which performs the decode based upon rA and rB at translation time. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/fpu_helper.c | 10

[Qemu-devel] [PATCH v3 13/15] target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time

2019-06-16 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/helper.h | 8 +++ target/ppc/mem_helper.c | 6 ++--- target/ppc/translate/vsx-impl.inc.c | 47 +++-- 3 files changed, 30 insertions(+), 31 deletions(-)

[Qemu-devel] [PATCH v3 14/15] target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time

2019-06-16 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/helper.h | 4 ++-- target/ppc/int_helper.c | 12 target/ppc/translate/vsx-impl.inc.c | 10 +- 3 files changed, 11 insertions(+), 15 deletions(-) diff --git a/target/pp

[Qemu-devel] [PATCH v3 10/15] target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c

2019-06-16 Thread Mark Cave-Ayland
Rather than perform the VSR register decoding within the helper itself, introduce a new GEN_VSX_HELPER_R3 macro which performs the decode based upon rD, rA and rB at translation time. Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target/ppc/fpu_helper.c | 36 +++

[Qemu-devel] [PATCH v3 15/15] target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro

2019-06-16 Thread Mark Cave-Ayland
Introduce a new GEN_VSX_HELPER_VSX_MADD macro for the generator function which enables the source and destination registers to be decoded at translation time. This enables the determination of a or m form to be made at translation time so that a single helper function can now be used for both vari

Re: [Qemu-devel] [PATCH v3 00/15] target/ppc: remove getVSR()/putVSR() and further tidy-up

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616123751.781-1-mark.cave-ayl...@ilande.co.uk/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v3 00/15] target/ppc: remove getVSR()/putVSR() and further tidy-up Type: ser

[Qemu-devel] Mapping of the guests user and kernel pages to host memory

2019-06-16 Thread Dimitris Karnikis
Hello, I am interested in understanding on how QEMU maps the user and kernel pages of a guest OS to the host OS memory (working on 3.1.0 but any version is acceptable with target x86-64 arch). Since QEMU runs on user space, these pages will be also mapped on the user space of the host machine. S

[Qemu-devel] [PATCH 1/6] m68k cpu instantiation comments improvements

2019-06-16 Thread Lucien Murray-Pitts
Improvement in comments for the instantiation functions. This is to highlight what each cpu class, in the 68000 series, contains in terms of instructions/features. Signed-off-by: Lucien Murray-Pitts --- target/m68k/cpu.c | 47 +++ target/m68k/cpu.h | 4

[Qemu-devel] [PATCH 0/6] target/m68k: Overhaul of MOVEC instruction to support exception/MSP

2019-06-16 Thread Lucien Murray-Pitts
The 68000 does not support the MOVEC instruction, it was added with the 68010. A new 68010 CPU class was created, and the MOVEC instruction moved to that class. Futher on the 68010, 68060 and CPU32 the ISP doesnt exist. These CPUs only have SSP/USP. (NOTE: ColdFire has a different MOVEC helper, t

[Qemu-devel] [PATCH 2/6] Cascade m68k_features by m680xx_cpu_initfn() to improve readability

2019-06-16 Thread Lucien Murray-Pitts
The m680XX_cpu_initfn functions have been rearranged to cascade starting from the base 68000, so that the 68010 then inherits from this, and so on until the 68060. This makes it simpler to track features since in most cases the m68k were product enhancements on each other, with only a few instruct

[Qemu-devel] [PATCH 5/6] MOVEC insn. doesnt generate exception if wrong CR is accessed

2019-06-16 Thread Lucien Murray-Pitts
Added "CPU class" m68k_feature to each CPU init func so MOVEC can detect wrong CR (Control Register) access. Added CPU class detection for each CR type in the m68k_move_to/from helpers, so that it throws and exception if an unsupported register is requested for that CPU class. Reclassified MOVEC

[Qemu-devel] [PATCH 3/6] Improved comments on m68k_move_to/from helpers

2019-06-16 Thread Lucien Murray-Pitts
Added more detailed comments to each case of m68k_move_to/from helpers to list the supported CPUs for that CR as they were wrong in some cases, and missing some cpu classes in other cases. Signed-off-by: Lucien Murray-Pitts --- target/m68k/helper.c | 41 +++--

[Qemu-devel] [PATCH 4/6] Add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to m68k_move_to/from

2019-06-16 Thread Lucien Murray-Pitts
The BUSCR/PCR CR defines were missing for 68060, and the move_to/from helper functions were also missing a decode for the 68060 M68K_CR_CAAR CR register. Added missing defines, and respective decodes for all three CR registers to the helpers. Although this patch defines them, the implementation i

[Qemu-devel] [PATCH v20 05/24] target/rx: simplify rx_cpu_class_by_name

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/cpu.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index a6dde613ab..e3d76af55d 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -72,9 +72,8 @@ static void rx_cpu_reset(

[Qemu-devel] [PATCH v20 19/24] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core

2019-06-16 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé While the VIRT machine can use different microcontrollers, the RX62N microcontroller is tied to the RX62N CPU core. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato --- hw/rx/rx-virt.c | 8 1 file changed, 8 insertions(+) diff --git a/

[Qemu-devel] [PATCH 6/6] Added MSP detection support for stack pointer swap helpers

2019-06-16 Thread Lucien Murray-Pitts
On m68k there are two varities of stack pointers, USP with SSP or ISP/MSP. Only the 68020/30/40 support the MSP register the stack swap helpers dont support this feature. This patch adds this support, as well as comments to CPUM68KState to make it clear how stacks are handled Signed-off-by: Luc

[Qemu-devel] [PATCH v20 12/24] target/rx: Dump bytes for each insn during disassembly

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <201906070

[Qemu-devel] [PATCH v20 10/24] target/rx: Emit all disassembly in one prt()

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson Many of the multi-part prints have been eliminated by previous patches. Eliminate the rest of them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-22-ys...@users.sourceforge.jp> Tested-by

[Qemu-devel] [PATCH v20 23/24] MAINTAINERS: Add RX

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-18-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINER

[Qemu-devel] [PATCH v20 17/24] target/rx: Move rx_load_image to rx-virt.

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- hw/rx/rx-virt.c | 22 ++ target/rx/cpu.c | 22 -- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c index ed0a3a1da0..4cfe2e3123 100644 --- a/hw/rx/rx-virt.c +++ b/hw/rx/rx-v

[Qemu-devel] [PATCH v20 18/24] hw/rx: Honor -accel qtest

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson Issue an error if no kernel, no bios, and not qtest'ing. Fixes make check-qtest-rx: test/qom-test. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-16-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signe

[Qemu-devel] [PATCH v20 07/24] target/rx: Disassemble rx_index_addr into a string

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson We were eliding all zero indexes. It is only ld==0 that does not have an index in the instruction. This also allows us to avoid breaking the final print into multiple pieces. Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-1

[Qemu-devel] [PATCH v20 03/24] target/rx: CPU definition

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable array, use rx_cpu_tlb_fill() extracted from patch of Yoshinori Sa

[Qemu-devel] [PATCH v20 20/24] qemu/bitops.h: Add extract8 and extract16

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 +

[Qemu-devel] [PATCH v20 22/24] Add rx-softmmu

2019-06-16 Thread Yoshinori Sato
Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-17-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson pick ed65c02993 target/rx: Add RX to SysEmuTarget pick 01372568ae tests: Add rx to machine-none-t

[Qemu-devel] [PATCH v20 15/24] hw/char: RX62N serial communication interface (SCI)

2019-06-16 Thread Yoshinori Sato
This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-8-ys...@users.sourcef

[Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread Yoshinori Sato
Hello. This patch series is added Renesas RX target emulation. Changes for v19. Follow tcg changes. Cleanup cpu.c. simplify rx_cpu_class_by_name and rx_load_image move to rx-virt. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20190616 Testing binaries

[Qemu-devel] [PATCH v20 14/24] hw/timer: RX62N internal timer modules

2019-06-16 Thread Yoshinori Sato
renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philip

[Qemu-devel] [PATCH v20 09/24] target/rx: Use prt_ldmi for XCHG_mr disassembly

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson Note that the ld == 3 case handled by prt_ldmi is decoded as XCHG_rr and cannot appear here. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-21-ys...@users.sourceforge.jp> Tested-by: Philip

[Qemu-devel] [PATCH v20 11/24] target/rx: Collect all bytes during disassembly

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson Collected, to be used in the next patch. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-23-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v20 21/24] hw/registerfields.h: Add 8bit and 16bit register macros

2019-06-16 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe Math

[Qemu-devel] [PATCH v20 06/24] target/rx: RX disassembler

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 +

[Qemu-devel] [PATCH v20 08/24] target/rx: Replace operand with prt_ldmi in disassembler

2019-06-16 Thread Yoshinori Sato
From: Richard Henderson This has consistency with prt_ri(). It loads all data before beginning output. It uses exactly one call to prt() to emit the full instruction. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49

[Qemu-devel] [PATCH v20 24/24] BootLinuxConsoleTest: Test the RX-Virt machine

2019-06-16 Thread Yoshinori Sato
From: Philippe Mathieu-Daudé Add two tests for the rx-virt machine, based on the recommended test setup from Yoshinori Sato: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg03586.html - U-Boot prompt - Linux kernel with Sash shell These are very quick tests: $ avocado run -t arch:rx

[Qemu-devel] [PATCH v20 16/24] hw/rx: RX Target hardware definition

2019-06-16 Thread Yoshinori Sato
rx62n - RX62N cpu. rx-virt - RX QEMU virtual target. Signed-off-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-9-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson [PMD: Use TYPE_RX62N_CPU, use #define for RX

[Qemu-devel] [PATCH v20 01/24] target/rx: TCG translation

2019-06-16 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-2-ys...@users

[Qemu-devel] [PATCH v20 02/24] target/rx: TCG helper

2019-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-3-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson [PMD: Removed tlb_fill, extracted from patch of Yoshinori Sato 'Convert to CPUClass::tlb_fill'] Signed

[Qemu-devel] [PATCH v20 13/24] hw/intc: RX62N interrupt controller (ICUa)

2019-06-16 Thread Yoshinori Sato
This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-6-ys...@users.sourcefo

[Qemu-devel] [PATCH v20 04/24] target/rx: Follow the change of tcg.

2019-06-16 Thread Yoshinori Sato
Add cpu-param.h Remove CPU_COMMON Use env_cpu Signed-off-by: Yoshinori Sato --- target/rx/cpu-param.h | 31 +++ target/rx/cpu.h | 21 + target/rx/cpu.c | 1 + target/rx/op_helper.c | 6 +++--- 4 files changed, 36 insertions(+), 23 del

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.

Re: [Qemu-devel] [RFC PATCH 0/2] target: Build with CONFIG_SEMIHOSTING disabled

2019-06-16 Thread Aleksandar Markovic
> Aleksandar: Can we use SEMIHOSTING on KVM MIPS? > You can assume the answer is no, we can't. But James Hogan, who maintains MIPS KVM, may have different view, and his answer would override mine. Yours, Aleksandar > For ARM Peter said: > > "semihosting hooks either SVC or HLT instructions, and

[Qemu-devel] [PATCH v3 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE

2019-06-16 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. This patch adds support for user wait instructions in KVM. Availability of the user wait instructions is indicated by the presence of the CPUID feature flag WAITPKG CPUID.0x07.0x0:ECX[5]. User wait instructions may be executed at any

[Qemu-devel] [PATCH v3 0/2] x86: Enable user wait instructions

2019-06-16 Thread Tao Xu
UMONITOR, UMWAIT and TPAUSE are a set of user wait instructions. UMONITOR arms address monitoring hardware using an address. A store to an address within the specified address range triggers the monitoring hardware to wake up the processor waiting in umwait. UMWAIT instructs the processor to ente

[Qemu-devel] [PATCH v3 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR

2019-06-16 Thread Tao Xu
UMWAIT and TPAUSE instructions use IA32_UMWAIT_CONTROL at MSR index E1H to determines the maximum time in TSC-quanta that the processor can reside in either C0.1 or C0.2. This patch is to Add support for save/load IA32_UMWAIT_CONTROL MSR in guest. Co-developed-by: Jingqi Liu Signed-off-by: Jingq

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Message-id: 20190616142836.10614-1-ys...

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.

[Qemu-devel] [PATCH] spapr/xive: Add proper rollback to kvmppc_xive_connect()

2019-06-16 Thread Greg Kurz
Make kvmppc_xive_disconnect() able to undo the changes of a partial execution of kvmppc_xive_connect() and use it to perform rollback. Based-on: <20190614165920.12670-2-...@kaod.org> Signed-off-by: Greg Kurz --- hw/intc/spapr_xive_kvm.c | 48 -- 1 fi

Re: [Qemu-devel] [PATCH v3 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-16 Thread Greg Kurz
On Fri, 14 Jun 2019 17:31:18 +0800 elohi...@gmail.com wrote: > From: Xie Yongji > > Besides virtio 1.0 transitional devices, we should also > set "start_on_kick" flag for legacy devices (virtio 0.9). > > Signed-off-by: Xie Yongji > --- Reviewed-by: Greg Kurz > hw/virtio/virtio.c |

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Message-id: 20190616142836.10614-1-ys...

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.

[Qemu-devel] [Bug 1832916] Re: linux-user does not check PROT_EXEC

2019-06-16 Thread Richard Henderson
It turns out we can't fix this without also fixing our implementation of signal trampolines. ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1832916

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190616142836.10614-1-ys...@users.sourceforge.jp Type: series Subject: [Qemu-devel] [PATCH v20

Re: [Qemu-devel] [PATCH v20 03/24] target/rx: CPU definition

2019-06-16 Thread Igor Mammedov
On Sun, 16 Jun 2019 23:28:15 +0900 Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > Reviewed-by: Richard Henderson > Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> > Signed-off-by: Richard Henderson > [PMD: Use newer QOM style, split cpu-qom.h, restrict access to > ext

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.

Re: [Qemu-devel] [PATCH v20 05/24] target/rx: simplify rx_cpu_class_by_name

2019-06-16 Thread Igor Mammedov
On Sun, 16 Jun 2019 23:28:17 +0900 Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato THere is no point in sending it as separate patch, If you'd merged this patch into 3/24 I'd ack it. So pls merge it there. > --- > target/rx/cpu.c | 20 +++- > 1 file changed, 3 insertions(

Re: [Qemu-devel] [PATCH v20 17/24] target/rx: Move rx_load_image to rx-virt.

2019-06-16 Thread Igor Mammedov
On Sun, 16 Jun 2019 23:28:29 +0900 Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > hw/rx/rx-virt.c | 22 ++ > target/rx/cpu.c | 22 -- > 2 files changed, 22 insertions(+), 22 deletions(-) > > diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c >

Re: [Qemu-devel] [PATCH v20 21/24] hw/registerfields.h: Add 8bit and 16bit register macros

2019-06-16 Thread Igor Mammedov
On Sun, 16 Jun 2019 23:28:33 +0900 Yoshinori Sato wrote: > From: Philippe Mathieu-Daudé > > Some RX peripheral using 8bit and 16bit registers. > Added 8bit and 16bit APIs. probably should go before 13/24 (i.e. before actual users start using it) this patch causes checkpatch errors but it uses

Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

2019-06-16 Thread Igor Mammedov
On Sun, 16 Jun 2019 08:18:18 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/ > > to fix MAINTAINERS warning, you can add new entry there at the first patch that introduces new directory/file and get rid of 23/2

Re: [Qemu-devel] [PATCH v4 07/11] hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI HMAT

2019-06-16 Thread Igor Mammedov
On Mon, 10 Jun 2019 21:39:12 +0800 Tao Xu wrote: > On 6/7/2019 12:45 AM, Igor Mammedov wrote: > > On Thu, 6 Jun 2019 11:00:33 +0800 > > Tao Xu wrote: > > > ... > >> > >> But the kernel HMAT can read othe Memory Side Cache Information except > >> SMBIOS entries and the host HMAT tables also ha

Re: [Qemu-devel] [PATCH v4 09/11] numa: Extend the command-line to provide memory side cache information

2019-06-16 Thread Igor Mammedov
On Wed, 8 May 2019 14:17:24 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-cache option to provide Memory Side Cache Information. > These memory attributes help to build Memory Side Cache Information > Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). > > Signed-off

Re: [Qemu-devel] [PATCH v4 11/11] hmat acpi: Implement _HMA method to update HMAT at runtime

2019-06-16 Thread Igor Mammedov
On Wed, 8 May 2019 14:17:26 +0800 Tao Xu wrote: > From: Liu Jingqi > > OSPM evaluates HMAT only during system initialization. > Any changes to the HMAT state at runtime or information > regarding HMAT for hot plug are communicated using _HMA method. > > _HMA is an optional object that enables

[Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-16 Thread Joel Sing
While working on a Go (www.golang.org) port for riscv, I've run into issues with atomics (namely LR/SC) on qemu-system-riscv64. There are several reproducers for this problem including one using gcc builtin atomics: https://gist.github.com/4a6f656c/8433032a3f70893a278259f8108aad90 And a version

Re: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64

2019-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190616191900.gh61...@hippo.sing.id.au/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] atomic failures on qemu-system-riscv64 Type: series Message-id: 20190616191900.gh61...@h

[Qemu-devel] [PATCH] tcg: Fix mmap lock assert on translation failure

2019-06-16 Thread Richard Henderson
Check page flags before letting an invalid pc cause a SIGSEGV. Prepare for eventially validating PROT_EXEC. The current wrinkle being that we have a problem with our implementation of signals. We should be using a vdso like the kernel, but we instead put the trampoline on the stack. In the mean

[Qemu-devel] [PATCH 2/2] tcg: Remove cpu_ld*_code_ra

2019-06-16 Thread Richard Henderson
These functions are not used, and are not usable in the context of code generation, because we never have a helper return address to pass in to them. Signed-off-by: Richard Henderson --- include/exec/cpu_ldst_useronly_template.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH 1/2] tcg: Introduce set/clear_helper_retaddr

2019-06-16 Thread Richard Henderson
At present we have a potential error in that helper_retaddr contains data for handle_cpu_signal, but we have not ensured that those stores will be scheduled properly before the operation that may fault. The "proper" C11 function from for this is atomic_signal_fence(). This expands to a compiler

[Qemu-devel] [PULL 00/11] virtio, acpi: fixes, cleanups

2019-06-16 Thread Michael S. Tsirkin
The following changes since commit f3d0bec9f80e4ed7796fffa834ba0a53f2094f7f: Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2019-06-14' into staging (2019-06-14 14:46:13 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/fo

[Qemu-devel] [PULL 07/11] vhost: fix vhost_log size overflow during migration

2019-06-16 Thread Michael S. Tsirkin
From: Li Hangjing When a guest which doesn't support multiqueue is migrated with a multi queues vhost-user-blk deivce, a crash will occur like: 0 qemu_memfd_alloc (name=, size=562949953421312, seals=, fd=0x7f87171fe8b4, errp=0x7f87171fe8a8) at util/memfd.c:153 1 0x7f883559d7cf in vhost_log

[Qemu-devel] [PULL 10/11] q35: update DSDT

2019-06-16 Thread Michael S. Tsirkin
update expected files and drop them from allowed diff list. Fixes: 4a4418369d6 ("q35: fix mmconfig and PCI0._CRS") Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test-allowed-diff.h | 8 tests/data/acpi/q35/DSDT | Bin 7815 -> 7841 bytes tests/data/acpi/q35/DSDT.

[Qemu-devel] [PULL 11/11] tests/rebuild-expected-aml.sh: blow out difflist

2019-06-16 Thread Michael S. Tsirkin
As expected files have been updated, make sure we do not forget to remove them from the allowed diff list. Signed-off-by: Michael S. Tsirkin --- tests/data/acpi/rebuild-expected-aml.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/ac

Re: [Qemu-devel] [PATCH v3 01/15] target/ppc: remove getVSR()/putVSR() from fpu_helper.c

2019-06-16 Thread Richard Henderson
On 6/16/19 5:37 AM, Mark Cave-Ayland wrote: > Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX > registers are in host endian order" functions getVSR() and putVSR() which used > to convert the VSR registers into host endian order are no longer required. > > Signed-off-by:

Re: [Qemu-devel] [PATCH qemu] loader: Trace loaded images

2019-06-16 Thread Alexey Kardashevskiy
On 14/06/2019 19:33, Stefan Hajnoczi wrote: > On Fri, Jun 14, 2019 at 10:13:04AM +1000, Alexey Kardashevskiy wrote: >> >> >> On 13/06/2019 23:08, Philippe Mathieu-Daudé wrote: >>> Hi Alexey, >>> >>> On 6/13/19 7:09 AM, Alexey Kardashevskiy wrote: This adds a trace point which prints every l

Re: [Qemu-devel] [PATCH v3 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c

2019-06-16 Thread Richard Henderson
On 6/16/19 5:37 AM, Mark Cave-Ayland wrote: > Since commit 8a14d31b00 "target/ppc: switch fpr/vsrl registers so all VSX > registers are in host endian order" functions getVSR() and putVSR() which used > to convert the VSR registers into host endian order are no longer required. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v3 02/50] tcg/README: fix typo s/afterwise/afterwards/

2019-06-16 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > Afterwise is "wise after the fact", as in "hindsight". > Here we meant "afterwards" (as in "subsequently"). Fix it. > > Reviewed-by: Alex Bennée > Signed-off-by: Emilio G. Cota > --- > tcg/README | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v3 01/50] trace: expand mem_info:size_shift to 3 bits

2019-06-16 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > From: "Emilio G. Cota" > > This will allow us to trace 16B-long memory accesses. > > Reviewed-by: Alex Bennée > Signed-off-by: Emilio G. Cota > --- > trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/trace-events b

Re: [Qemu-devel] [PATCH v3 1/5] virtio: add "use-started" property

2019-06-16 Thread Yongji Xie
On Fri, 14 Jun 2019 at 19:45, Greg Kurz wrote: > > On Fri, 14 Jun 2019 17:31:17 +0800 > elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > In order to avoid migration issues, we introduce a "use-started" > > property to the base virtio device to indicate whether use > > "started" flag or no

Re: [Qemu-devel] [PATCH v3 03/50] cpu: introduce cpu_in_exclusive_work_context()

2019-06-16 Thread Richard Henderson
On 6/14/19 10:11 AM, Alex Bennée wrote: > start_exclusive(); > +cpu->in_exclusive_work_context = true; > wi->func(cpu, wi->data); > +cpu->in_exclusive_work_context = false; > end_exclusive(); Is there a reason not to put those into sta

Re: [Qemu-devel] [Qemu-Devel][PATCH 1/3] Adding an optional tb execution counter.

2019-06-16 Thread Richard Henderson
On 6/14/19 6:53 AM, vandersonmr wrote: > +void HELPER(inc_exec_freq)(void *ptr) > +{ > +TranslationBlock* tb = (TranslationBlock*) ptr; > +atomic_inc(&tb->exec_freq); > +} ... > +DEF_HELPER_FLAGS_1(inc_exec_freq, TCG_CALL_NO_RWG, void, ptr) ... > uint32_t flags; /* flags defining in wh

Re: [Qemu-devel] [PATCH v7 2/2] hw/arm: Add arm SBSA reference machine, devices part

2019-06-16 Thread Hongbo Zhang
On Mon, 3 Jun 2019 at 18:54, Philippe Mathieu-Daudé wrote: > > Hi Hongbo, Ard. > > On 4/18/19 6:04 AM, Hongbo Zhang wrote: > > Following the previous patch, this patch adds peripheral devices to the > > newly introduced SBSA-ref machine. > > > > Signed-off-by: Hongbo Zhang > > --- > > hw/arm/sbs

Re: [Qemu-devel] [Qemu-Devel][PATCH 2/3] Saving counters between tb_flush events.

2019-06-16 Thread Richard Henderson
On 6/14/19 6:53 AM, vandersonmr wrote: > A new hash map was added to store the accumulated execution > frequency of the TBs even after tb_flush events. A dump > function was also added as a way to visualize these frequencies. > > Signed-off-by: vandersonmr > --- > accel/tcg/translate-all.c | 59

Re: [Qemu-devel] [Qemu-Devel][PATCH 3/3] Adding command line option to linux-user.

2019-06-16 Thread Richard Henderson
On 6/14/19 6:53 AM, vandersonmr wrote: > Added -execfreq to enable execution frequency counting and dump > all the TB's addresses and their execution frequency at the end > of the execution. > > Signed-off-by: vandersonmr > --- > linux-user/exit.c | 5 + > linux-user/main.c | 7 +++ > 2

  1   2   >