Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ys...@users.sourceforge.jp/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support Type: series Message-id: 20190616142836.10614-1-ys...@users.sourceforge.jp === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu t [tag update] patchew/20190616142836.10614-1-ys...@users.sourceforge.jp -> patchew/20190616142836.10614-1-ys...@users.sourceforge.jp Switched to a new branch 'test' 403c350609 BootLinuxConsoleTest: Test the RX-Virt machine 98f6fb5e89 MAINTAINERS: Add RX 4252de2062 Add rx-softmmu 95d29650e9 hw/registerfields.h: Add 8bit and 16bit register macros 9e3ce57c55 qemu/bitops.h: Add extract8 and extract16 dc04a4b224 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core cc47cf664c hw/rx: Honor -accel qtest ceb71505f3 target/rx: Move rx_load_image to rx-virt. f20d5cc761 hw/rx: RX Target hardware definition c37736b76c hw/char: RX62N serial communication interface (SCI) 8176ccfbcc hw/timer: RX62N internal timer modules d9a5c82129 hw/intc: RX62N interrupt controller (ICUa) 8809801630 target/rx: Dump bytes for each insn during disassembly e91060b6fc target/rx: Collect all bytes during disassembly 2e5775b8de target/rx: Emit all disassembly in one prt() 0c2a07b318 target/rx: Use prt_ldmi for XCHG_mr disassembly 5f427555c5 target/rx: Replace operand with prt_ldmi in disassembler a837728954 target/rx: Disassemble rx_index_addr into a string 4501fa194e target/rx: RX disassembler 107b638962 target/rx: simplify rx_cpu_class_by_name 108dd5166a target/rx: Follow the change of tcg. 7e87ad503c target/rx: CPU definition f34c576ead target/rx: TCG helper 4b7f3bbe5f target/rx: TCG translation === OUTPUT BEGIN === 1/24 Checking commit 4b7f3bbe5f8a (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/24 Checking commit f34c576eadb5 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 649 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit 7e87ad503c0d (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 645 lines checked Patch 3/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/24 Checking commit 108dd5166a69 (target/rx: Follow the change of tcg.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 121 lines checked Patch 4/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/24 Checking commit 107b63896230 (target/rx: simplify rx_cpu_class_by_name) 6/24 Checking commit 4501fa194ece (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 6/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/24 Checking commit a83772895452 (target/rx: Disassemble rx_index_addr into a string) 8/24 Checking commit 5f427555c5a6 (target/rx: Replace operand with prt_ldmi in disassembler) 9/24 Checking commit 0c2a07b318aa (target/rx: Use prt_ldmi for XCHG_mr disassembly) 10/24 Checking commit 2e5775b8dec1 (target/rx: Emit all disassembly in one prt()) 11/24 Checking commit e91060b6fc95 (target/rx: Collect all bytes during disassembly) 12/24 Checking commit 880980163031 (target/rx: Dump bytes for each insn during disassembly) 13/24 Checking commit d9a5c8212987 (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #40: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 13/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/24 Checking commit 8176ccfbcca6 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #50: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 14/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/24 Checking commit c37736b76c65 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 15/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/24 Checking commit f20d5cc76168 (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #21: new file mode 100644 total: 0 errors, 1 warnings, 457 lines checked Patch 16/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/24 Checking commit ceb71505f397 (target/rx: Move rx_load_image to rx-virt.) 18/24 Checking commit cc47cf664c91 (hw/rx: Honor -accel qtest) 19/24 Checking commit dc04a4b224e3 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core) 20/24 Checking commit 9e3ce57c5563 (qemu/bitops.h: Add extract8 and extract16) 21/24 Checking commit 95d29650e976 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467. ERROR: Macros with multiple statements should be enclosed in a do - while loop #27: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #31: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 21/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/24 Checking commit 4252de2062f3 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #61: new file mode 100644 total: 0 errors, 1 warnings, 73 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit 98f6fb5e8959 (MAINTAINERS: Add RX) 24/24 Checking commit 403c3506091d (BootLinuxConsoleTest: Test the RX-Virt machine) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190616142836.10614-1-ys...@users.sourceforge.jp/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
