[Qemu-devel] [PATCH v19 06/21] target/rx: Replace operand with prt_ldmi in disassembler

2019-06-11 Thread Philippe Mathieu-Daudé
From: Richard Henderson This has consistency with prt_ri(). It loads all data before beginning output. It uses exactly one call to prt() to emit the full instruction. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49

[Qemu-devel] [PATCH v19 10/21] target/rx: Dump bytes for each insn during disassembly

2019-06-11 Thread Philippe Mathieu-Daudé
From: Richard Henderson There are so many different forms of each RX instruction that it will be very useful to be able to look at the bytes to see on which path a bug may lie. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <201906070

[Qemu-devel] [PATCH v19 09/21] target/rx: Collect all bytes during disassembly

2019-06-11 Thread Philippe Mathieu-Daudé
From: Richard Henderson Collected, to be used in the next patch. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-23-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v19 20/21] MAINTAINERS: Add RX

2019-06-11 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-18-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+)

[Qemu-devel] [PATCH v19 08/21] target/rx: Emit all disassembly in one prt()

2019-06-11 Thread Philippe Mathieu-Daudé
From: Richard Henderson Many of the multi-part prints have been eliminated by previous patches. Eliminate the rest of them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato Signed-off-by: Yoshinori Sato Message-Id: <20190607091116.49044-22-ys...@users.sourceforge.jp> Tested-by

[Qemu-devel] [PATCH v19 01/21] target/rx: TCG translation

2019-06-11 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091

[Qemu-devel] [PATCH v19 04/21] target/rx: RX disassembler

2019-06-11 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-5-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson --- include/disas/dis-asm.h |5 + target/rx/disas.c | 1480 ++

[Qemu-devel] [PATCH v19 18/21] hw/registerfields.h: Add 8bit and 16bit register macros

2019-06-11 Thread Philippe Mathieu-Daudé
Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-11-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Reviewed-by: Alistai

[Qemu-devel] [PATCH v19 17/21] qemu/bitops.h: Add extract8 and extract16

2019-06-11 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190607091116.49044-10-ys...@users.sourceforge.jp> Tested-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/qemu/bitops.h | 38 ++

[Qemu-devel] [PATCH v19 16/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core

2019-06-11 Thread Philippe Mathieu-Daudé
While the VIRT machine can use different microcontrollers, the RX62N microcontroller is tied to the RX62N CPU core. Signed-off-by: Philippe Mathieu-Daudé --- hw/rx/rx-virt.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/rx/rx-virt.c b/hw/rx/rx-virt.c index ed0a3a1da0..797a090173

[Qemu-devel] [PATCH v19 03/21] target/rx: CPU definition

2019-06-11 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Signed-off-by: Yoshinori Sato Reviewed-by: Richard Henderson Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable array, use rx_cpu_tlb_fill() extracted from

Re: [Qemu-devel] [PATCH v2] q35: fix mmconfig and PCI0._CRS

2019-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2019 at 01:37:35PM +0200, Paolo Bonzini wrote: > On 07/06/19 09:34, Gerd Hoffmann wrote: > > This patch changes the handling of the mmconfig area. Thanks to the > > pci(e) expander devices we already have the logic to exclude address > > ranges from PCI0._CRS. We can simply add th

Re: [Qemu-devel] [PATCH] spapr: Don't use the "dual" interrupt controller mode with an old hypervisor

2019-06-11 Thread David Gibson
On Fri, Jun 07, 2019 at 10:17:58AM +0200, Cédric Le Goater wrote: > On 07/06/2019 02:19, David Gibson wrote: > > On Thu, Jun 06, 2019 at 07:08:59PM +0200, Greg Kurz wrote: > >> If KVM is too old to support XIVE native exploitation mode, we might end > >> up using the emulated XIVE after CAS. This i

Re: [Qemu-devel] [PATCH v5 11/12] qemu-io: adds support for io_uring

2019-06-11 Thread Fam Zheng
On Mon, 06/10 19:19, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > qemu-io.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/qemu-io.c b/qemu-io.c > index 8d5d5911cb..54b82151c4 100644 > --- a/qemu-io.c > +++ b/qemu-io.c > @@ -129,6 +129,7 @@ static void ope

Re: [Qemu-devel] [PATCH v2] q35: fix mmconfig and PCI0._CRS

2019-06-11 Thread Paolo Bonzini
On 07/06/19 09:34, Gerd Hoffmann wrote: > This patch changes the handling of the mmconfig area. Thanks to the > pci(e) expander devices we already have the logic to exclude address > ranges from PCI0._CRS. We can simply add the mmconfig address range > to the list get it excluded as well. > > Wi

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-11 Thread Cornelia Huck
On Fri, 7 Jun 2019 11:19:09 -0400 Farhan Ali wrote: > On 06/07/2019 11:09 AM, Cornelia Huck wrote: > > On Fri, 7 Jun 2019 11:02:36 -0400 > > Farhan Ali wrote: > > > >> On 06/07/2019 10:53 AM, Cornelia Huck wrote: > >>> diff --git a/hw/s390x/css.c b/hw/s390x/css.c > >>> index ad310b9f94bc..

Re: [Qemu-devel] [PATCH v5 09/12] block: add trace events for io_uring

2019-06-11 Thread Fam Zheng
On Mon, 06/10 19:19, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta > --- > block/io_uring.c | 14 -- > block/trace-events | 8 > 2 files changed, 20 insertions(+), 2 deletions(-) > > diff --git a/block/io_uring.c b/block/io_uring.c > index f327c7ef96..47e027364a 100

Re: [Qemu-devel] [PATCH] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
On Tue, Jun 11, 2019 at 11:34 AM Philippe Mathieu-Daudé wrote: > Hi Ramon, > > On 6/9/19 12:08 PM, Ramon Fried wrote: > > defining CADENCE_GEM_ERR_DEBUG causes compilation > > errors, fix that. > > > > Signed-off-by: Ramon Fried > > --- > > hw/net/cadence_gem.c | 6 +++--- > > 1 file changed, 3

Re: [Qemu-devel] [PATCH] target/arm: Fix output of PAuth Auth

2019-06-11 Thread Peter Maydell
On Sun, 9 Jun 2019 at 23:22, Richard Henderson wrote: > > The ARM pseudocode installs the error_code into the original > pointer, not the encrypted pointer. The difference applies > within the 7 bits of pac data; the result should be the sign > extension of bit 55. > > Add a testcase to that effe

Re: [Qemu-devel] [PULL 14/26] tests/tcg/arm: add ARMv6-M UNDEFINED 32-bit instruction test

2019-06-11 Thread Peter Maydell
On Tue, 12 Mar 2019 at 17:09, Alex Bennée wrote: > > From: Stefan Hajnoczi > > Test that 32-bit instructions declared UNDEFINED in the ARMv6-M > Reference Manual really do raise an exception. Also test that the 6 > 32-bit instructions defined in the ARMv6-M Reference Manual do not raise > an exc

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 2019063731.16940-1-phi...@redhat.com Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture suppo

Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list

2019-06-11 Thread David Hildenbrand
On 10.06.19 03:42, Richard Henderson wrote: > The parameter list given in general register 1 shall be aligned > on a quadword boundary. This test currently succeeds or fails > depending on the compiler version used and the accidential layout > of the function's stack frame. > > Signed-off-by: Ric

[Qemu-devel] [Bug 1830821] Re: Expose ARCH_CAP_MDS_NO in guest

2019-06-11 Thread Rafael David Tinoco
This effort, if done, would be done together with: https://bugs.launchpad.net/intel/+bug/1828495 Please read comments: https://bugs.launchpad.net/intel/+bug/1828495/comments/8 and https://bugs.launchpad.net/intel/+bug/1828495/comments/10 -- You received this bug notification because you are

[Qemu-devel] [Bug 1830821] Re: Expose ARCH_CAP_MDS_NO in guest

2019-06-11 Thread Rafael David Tinoco
** Changed in: qemu (Ubuntu Disco) Status: Fix Released => Confirmed ** Changed in: qemu (Ubuntu Disco) Importance: Undecided => Wishlist ** Changed in: qemu (Ubuntu) Status: Fix Released => Confirmed ** Changed in: qemu (Ubuntu) Importance: Undecided => Wishlist ** Changed

Re: [Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

2019-06-11 Thread Pankaj Gupta
Hi Mike, Thanks for the review Please find my reply inline. > > dm_table_supports_dax() is called multiple times (from > dm_table_set_restrictions and dm_table_determine_type). It is strange > to have a getter have a side-effect of being a setter too. Overloading > like this could get you in t

Re: [Qemu-devel] [PATCH v19 03/21] target/rx: CPU definition

2019-06-11 Thread Igor Mammedov
On Tue, 11 Jun 2019 13:37:13 +0200 Philippe Mathieu-Daudé wrote: > From: Yoshinori Sato > > Signed-off-by: Yoshinori Sato > Reviewed-by: Richard Henderson > Message-Id: <20190607091116.49044-4-ys...@users.sourceforge.jp> > Signed-off-by: Richard Henderson > [PMD: Use newer QOM style, split c

Re: [Qemu-devel] [QUESTION] How to reduce network latency to improve netperf TCP_RR drastically?

2019-06-11 Thread Jason Wang
On 2019/6/10 下午11:55, Michael S. Tsirkin wrote: On Tue, Jun 04, 2019 at 03:10:43PM +0800, Like Xu wrote: Hi Michael, At https://www.linux-kvm.org/page/NetworkingTodo, there is an entry for network latency saying: --- reduce networking latency: allow handling short packets from softirq or V

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: 2019063731.16940-1-ph

Re: [Qemu-devel] [PATCH v19 16/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core

2019-06-11 Thread Yoshinori Sato
On Tue, 11 Jun 2019 20:37:26 +0900, Philippe Mathieu-Daudé wrote: > > While the VIRT machine can use different microcontrollers, > the RX62N microcontroller is tied to the RX62N CPU core. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Yoshinori Sato > --- > hw/rx/rx-virt.c | 8 ++

[Qemu-devel] [Bug 1832353] [NEW] cpu_exec: Assertion !have_mmap_lock() failed

2019-06-11 Thread Christophe Lyon
Public bug reported: Hi, I have isolated a testcase from the GCC testsuite (actually gfortran, test proc_ptr_51.f90) which produces tons of: qemu-arm: /home/christophe.lyon/src/qemu/accel/tcg/cpu-exec.c:701: cpu_exec: Assertion `!have_mmap_lock()' failed. including with master qemu as of today.

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

[Qemu-devel] [PATCH v2 07/11] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c

2019-06-11 Thread Kevin Wolf
Now that we have a monitor/ subdirectory, let's move hmp.c and qmp.c from the root directory there. As they contain implementations of monitor commands, rename them to {hmp,qmp}-cmds.c, so that {hmp,qmp}.c are free for the HMP and QMP infrastructure. Signed-off-by: Kevin Wolf --- docs/devel/writ

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: 2019063731.16940-1-ph

[Qemu-devel] [PATCH v2 01/11] monitor: Remove unused password prompting fields

2019-06-11 Thread Kevin Wolf
Commit 788cf9f8c removed the code for password prompting from the monitor. Since then, the Monitor fields password_completion_cb and password_opaque have been unused. Remove them. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert --- monitor.c | 2 -- 1 file changed, 2 deletions(-)

[Qemu-devel] [PATCH v2 06/11] Move monitor.c to monitor/misc.c

2019-06-11 Thread Kevin Wolf
Create a new monitor/ subdirectory and move monitor.c there. As the plan is to move the monitor core into separate files, use the chance to rename it to misc.c. Signed-off-by: Kevin Wolf --- docs/devel/writing-qmp-commands.txt | 2 +- monitor.c => monitor/misc.c | 2 +- MAINTAINERS

[Qemu-devel] [PATCH v2 02/11] monitor: Split monitor_init in HMP and QMP function

2019-06-11 Thread Kevin Wolf
Instead of mixing HMP and QMP monitors in the same function, separate the monitor creation function for both. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert --- monitor.c | 86 +++ 1 file changed, 49 insertions(+), 37 deletions(

Re: [Qemu-devel] qgraph

2019-06-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/06/19 10:56, Markus Armbruster wrote: >> Yes, this is how introspection (both QMP and QOM) is commonly used. >> Just keep in mind one difference: QMP is static, QOM is dynamic. >> >> QMP being static means it's defined at compile time. So is the value of >> query-q

[Qemu-devel] [PATCH v2 04/11] monitor: Create MonitorHMP with readline state

2019-06-11 Thread Kevin Wolf
The ReadLineState in Monitor is only used for HMP monitors. Create MonitorHMP and move it there. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert --- include/monitor/monitor.h | 5 +- hmp.c | 4 +- monitor.c | 127 +---

[Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-11 Thread Kevin Wolf
monitor.c mixes a lot of different things in a single file: The core monitor infrastructure, HMP infrastrcture, QMP infrastructure, and the implementation of several HMP and QMP commands. Almost worse, struct Monitor mixes state for HMP, for QMP, and state actually shared between all monitors. moni

[Qemu-devel] [PATCH v2 09/11] monitor: Split out monitor/qmp.c

2019-06-11 Thread Kevin Wolf
Move QMP infrastructure from monitor/misc.c to monitor/qmp.c. This is code that can be shared for all targets, so compile it only once. The amount of function and particularly extern variables in monitor_int.h is probably a bit larger than it needs to be, but this way no non-trivial code modificat

Re: [Qemu-devel] qgraph

2019-06-11 Thread Andreas Färber
Am 11.06.19 um 12:31 schrieb Paolo Bonzini: > On 11/06/19 10:56, Markus Armbruster wrote: >> Yes, this is how introspection (both QMP and QOM) is commonly used. >> Just keep in mind one difference: QMP is static, QOM is dynamic. >> >> QMP being static means it's defined at compile time. So is the

[Qemu-devel] [PATCH v2 08/11] monitor: Create monitor_int.h with common definitions

2019-06-11 Thread Kevin Wolf
Before we can split monitor.c, we need to create a header file that contains the common definitions that will be used by multiple source files. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert --- monitor/monitor_int.h | 148 ++ monitor/misc.

[Qemu-devel] [PATCH v2 05/11] monitor: Move cmd_table to MonitorHMP

2019-06-11 Thread Kevin Wolf
Monitor.cmd_table contains the handlers for HMP commands, so there is no reason to keep it in the state shared with QMP. Move it to MonitorHMP. Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert --- monitor.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions

[Qemu-devel] [PATCH v2 11/11] monitor: Split out monitor/monitor.c

2019-06-11 Thread Kevin Wolf
Move the monitor core infrastructure from monitor/misc.c to monitor/monitor.c. This is code that can be shared for all targets, so compile it only once. What remains in monitor/misc.c after this patch is mostly monitor command implementations and code that requires a system emulator or is even tar

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support Type: series Message-id: 2019063731.16940-1-ph

[Qemu-devel] [PULL 3/3] i386: Save EFER for 32-bit targets

2019-06-11 Thread Eduardo Habkost
From: Pavel Dovgalyuk i386 (32 bit) emulation uses EFER in wrmsr and in MMU fault processing. But it does not included in VMState, because "efer" field is disabled with This patch adds a section for 32-bit targets which saves EFER when it's value is non-zero. Signed-off-by: Pavel Dovgalyuk Mes

[Qemu-devel] [PATCH v2 03/11] monitor: Make MonitorQMP a child class of Monitor

2019-06-11 Thread Kevin Wolf
Currently, struct Monitor mixes state that is only relevant for HMP, state that is only relevant for QMP, and some actually shared state. In particular, a MonitorQMP field is present in the state of any monitor, even if it's not a QMP monitor and therefore doesn't use the state. As a first step to

[Qemu-devel] [PATCH v2 10/11] monitor: Split out monitor/hmp.c

2019-06-11 Thread Kevin Wolf
Move HMP infrastructure from monitor/misc.c to monitor/hmp.c. This is code that can be shared for all targets, so compile it only once. The amount of function and particularly extern variables in monitor_int.h is probably a bit larger than it needs to be, but this way no non-trivial code modificat

[Qemu-devel] Flash emulation questions

2019-06-11 Thread Alex Bennée
Hi Phillipe, There has been some interest expressed in adding support for RPMB flash partitions for the benefit of secure firmwares like OPTEE. I'm just trying to scope out what sort of work would need to be done for it. RPMB (Replay Protect Memory Block) is a special eMMC partition which requi

[Qemu-devel] [PULL 0/3] x86 queue, 2019-06-11

2019-06-11 Thread Eduardo Habkost
The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into staging (2019-06-10 16:09:19 +0100) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/x86-next-pull-request for

[Qemu-devel] [PULL 1/3] i386: x86_cpu_list_feature_names() function

2019-06-11 Thread Eduardo Habkost
Extract feature name listing code from x86_cpu_class_check_missing_features(). It will be reused to return information about CPU filtered features at runtime. Message-Id: <20190422234742.15780-2-ehabk...@redhat.com> Signed-off-by: Eduardo Habkost --- target/i386/cpu.c | 35 +

[Qemu-devel] [PULL 2/3] i386: "unavailable-features" QOM property

2019-06-11 Thread Eduardo Habkost
Add a "unavailable-features" QOM property to X86CPU objects that have the same semantics of "unavailable-features" on query-cpu-definitions. The new property has the same goal of "filtered-features", but is generic enough to let any kind of CPU feature to be listed there without relying on low lev

Re: [Qemu-devel] [PATCH v2] qapi: InitSocketAddress: add keepalive option

2019-06-11 Thread Markus Armbruster
You misspelled InetSocketAddress and keep-alive in the subject. Suggest qapi: Add InetSocketAddress member keep-alive Vladimir Sementsov-Ogievskiy writes: > It's needed to provide keepalive for nbd client to track server > availability. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --

Re: [Qemu-devel] qgraph

2019-06-11 Thread Paolo Bonzini
On 11/06/19 15:39, Markus Armbruster wrote: >> Right, and we should move more towards class-based properties so that >> the dynamic nature of QOM is only used for the bare minimum needed (e.g. >> memory regions). > What are we doing to make new code conform to that? > > What are we doing to update

Re: [Qemu-devel] [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting

2019-06-11 Thread wangjie (P)
Hi, Paolo and Michal: Base on my patch, I found another problem is that:     qemu: report DISCONNECTED     libvirt: start pr-helper #1, but it will takes a while to complete this action     qemu: reconnect to start pr-helper #1 immediately and failed, so report DISCONNECTED     libvirt: b

Re: [Qemu-devel] [PULL 00/52] testing, gdbstub and cputlb fixes

2019-06-11 Thread Alex Bennée
Peter Maydell writes: > On Fri, 7 Jun 2019 at 10:05, Alex Bennée wrote: >> >> The following changes since commit 0d74f3b4277a7ecb0ccb80c865797d11f8e466f5: >> >> Merge remote-tracking branch >> 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-06-06 >> 14:09:14 +0100) >>

Re: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190611134043.9524-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc Type: series Message-id: 20190611

Re: [Qemu-devel] [PATCH v19 00/21] Add RX archtecture support

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/2019063731.16940-1-phi...@redhat.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that ha

Re: [Qemu-devel] [PATCH 1/2] docs/specs/index.rst: Fix minor syntax issues

2019-06-11 Thread Aleksandar Markovic
On Jun 11, 2019 11:51 AM, "Peter Maydell" wrote: > > On Mon, 10 Jun 2019 at 22:41, Aleksandar Markovic > wrote: > > > > > > On Jun 10, 2019 5:25 PM, "Peter Maydell" wrote: > > > > > > The docs/specs/index.rst has a couple of minor issues which > > > we didn't notice because we weren't building t

[Qemu-devel] [PATCH 0/2] ARM SMMUv3: Fix spurious notification errors and stall with vfio-pci

2019-06-11 Thread Eric Auger
The first patch fixes spurious translation configuration decoding errors rarely happening on guest IOVA invalidation notifications. The second patch fixes the guest stall observed when attempting to run a guest exposed with a SMMUv3 and a VFIO-PCI device. As a reminder SMMUv3 is not integrated wit

Re: [Qemu-devel] [RFC] vhost-user: don't ignore CTRL_VLAN feature

2019-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2019 at 02:51:37PM +0800, Tiwei Bie wrote: > The VIRTIO_NET_F_CTRL_VLAN feature requires the support of > vhost-user backend. But it will be advertised to guest driver > as long as it's enabled by users in QEMU, while it's not > supported by vhost-user backend. This patch fixes this

[Qemu-devel] [PATCH 2/2] hw/arm/smmuv3: Implement dummy replay

2019-06-11 Thread Eric Auger
On ARM we currently do not support VFIO-PCI devices protected by the IOMMU. Any attempt to run such use case results in this kind of warning: "-device vfio-pci,host=0004:01:00.0,id=hostdev0,bus=pci.1,addr=0x0: warning: SMMUv3 does not support notification on MAP: device vfio-pci will not function

[Qemu-devel] [PATCH 1/2] hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations

2019-06-11 Thread Eric Auger
An IOVA/ASID invalidation is notified to all IOMMU Memory Regions through smmuv3_inv_notifiers_iova/smmuv3_notify_iova. When the notification occurs it is possible that some of the PCIe devices associated to the notified regions do not have a valid stream table entry. In that case we output a LOG_

Re: [Qemu-devel] [PATCH] tests/acceptance: Improve failure reporting in linux_ssh_mips_malta.py

2019-06-11 Thread Aleksandar Markovic
On Jun 11, 2019 8:00 AM, "Aleksandar Markovic" wrote: > > > On Jun 11, 2019 1:24 AM, "Cleber Rosa" wrote: > > > > On Mon, Jun 10, 2019 at 09:49:10PM +0200, Aleksandar Markovic wrote: > > > From: Aleksandar Markovic > > > > > > Rather than optputing a cryptic message: > > > > > > FAIL: True not f

Re: [Qemu-devel] [PATCH] tests/tcg/s390x: Fix alignment of csst parameter list

2019-06-11 Thread Richard Henderson
On 6/11/19 6:06 AM, David Hildenbrand wrote: > Queuing it to > > https://github.com/davidhildenbrand/qemu.git s390-tcg-next > > for now. Let me know if you want to send this via a different PULL > request yourself. No, that's perfect, thanks. r~

[Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Ramon Fried
defining CADENCE_GEM_ERR_DEBUG causes compilation errors, fix that. Signed-off-by: Ramon Fried --- v2: change %lx to HWADDR_PRIx and %lx to %zdx hw/net/cadence_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 7f634

Re: [Qemu-devel] [Qemu-block] [PATCH] pr-manager-helper: fix pr process been killed when reconectting

2019-06-11 Thread Paolo Bonzini
On 11/06/19 15:51, wangjie (P) wrote: > Hi, Paolo and Michal: > > Base on my patch, I found another problem is that: > >     qemu: report DISCONNECTED > >     libvirt: start pr-helper #1, but it will takes a while to complete > this action > >     qemu: reconnect to start pr-helper #1 immediate

Re: [Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

2019-06-11 Thread Mike Snitzer
On Tue, Jun 11 2019 at 9:10am -0400, Pankaj Gupta wrote: > Hi Mike, > > Thanks for the review Please find my reply inline. > > > > > dm_table_supports_dax() is called multiple times (from > > dm_table_set_restrictions and dm_table_determine_type). It is strange > > to have a getter have a si

Re: [Qemu-devel] [PATCH v2 39/42] target/arm: Convert VJCVT to decodetree

2019-06-11 Thread Richard Henderson
On 6/11/19 3:53 AM, Peter Maydell wrote: > Convert the VJCVT instruction to decodetree. > > Signed-off-by: Peter Maydell > --- > target/arm/translate-vfp.inc.c | 28 > target/arm/translate.c | 12 +--- > target/arm/vfp.decode | 4 > 3 f

Re: [Qemu-devel] New HAXM maintainer

2019-06-11 Thread Stefan Hajnoczi
On Mon, May 27, 2019 at 05:34:24PM +0800, Yu Ning wrote: > I am leaving Intel, and will soon lose access to my Intel email accounts. > Effective today, I am no longer maintainer of the HAXM open source project > (https://github.com/intel/haxm). Colin Xu (colin DOT xu AT intel DOT com) > will take m

Re: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc

2019-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190611134043.9524-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190611134043.9524-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in

[Qemu-devel] [PULL 02/12] qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h

2019-06-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190523143508.25387-3-arm...@redhat.com> Reviewed-by: Richard Henderson --- block/ssh.c| 1 + block/vvfat.c | 1 + gdbstub.c | 2 ++ hw/core/bus.c | 2 +- hw/core/qdev-properties.c | 1

[Qemu-devel] [PULL 11/12] MAINTAINERS: Improve section headlines

2019-06-11 Thread Markus Armbruster
When scripts/get_maintainer.pl reports something like John Doe (maintainer:Overall) the user is left to wonder *which* of our three "Overall" sections applies: the one under "Guest CPU cores (TCG)", or the one under "Guest CPU Cores (KVM)", or the one under "Usermode emulation". Rename sect

[Qemu-devel] [PULL 06/12] scripts/clean-header-guards: Fix handling of trailing comments

2019-06-11 Thread Markus Armbruster
clean-header-guards.pl fails to recognize a header guard #endif when it's followed by a // comment, or multiple comments. Fix that. Signed-off-by: Markus Armbruster Message-Id: <20190604181618.19980-3-arm...@redhat.com> --- scripts/clean-header-guards.pl | 12 +++- 1 file changed, 7 ins

[Qemu-devel] [PULL 05/12] Normalize position of header guard

2019-06-11 Thread Markus Armbruster
This is the common header guard idiom: /* * File comment */ #ifndef GUARD_SYMBOL_H #define GUARD_SYMBOL_H ... actual contents ... #endif A few of our headers have some #include before the guard. target/tilegx/spr_def_64.h has #ifndef __DOXYGEN__ outside the guard.

[Qemu-devel] [PULL 09/12] Clean up a header guard symbols (again)

2019-06-11 Thread Markus Armbruster
Commit d52c454aad "contrib: add vhost-user-gpu" and "c68082c43a virtio-gpu: split virtio-gpu-pci & virtio-vga" created headers with unusual header guard symbols. Clean them up Signed-off-by: Markus Armbruster Message-Id: <20190607141321.9726-1-arm...@redhat.com> --- contrib/vhost-user-gpu/virgl

Re: [Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-07

2019-06-11 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 7 Jun 2019 at 19:21, Markus Armbruster wrote: >> >> The following changes since commit 0d74f3b4277a7ecb0ccb80c865797d11f8e466f5: >> >> Merge remote-tracking branch >> 'remotes/vivier2/tags/trivial-branch-pull-request' into staging (2019-06-06 >> 14:09:14 +0100

[Qemu-devel] [PULL 01/12] qemu-common: Move tcg_enabled() etc. to sysemu/tcg.h

2019-06-11 Thread Markus Armbruster
Other accelerators have their own headers: sysemu/hax.h, sysemu/hvf.h, sysemu/kvm.h, sysemu/whpx.h. Only tcg_enabled() & friends sit in qemu-common.h. This necessitates inclusion of qemu-common.h into headers, which is against the rules spelled out in qemu-common.h's file comment. Move tcg_enabl

[Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-11

2019-06-11 Thread Markus Armbruster
The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into staging (2019-06-10 16:09:19 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-misc-2019-06-11 for you

[Qemu-devel] [PULL 12/12] MAINTAINERS: Polish headline decorations

2019-06-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190606172408.18399-4-arm...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 550d6c5959..588c8d947a 100644

[Qemu-devel] [PULL 08/12] Supply missing header guards

2019-06-11 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20190604181618.19980-5-arm...@redhat.com> --- hw/9pfs/xen-9pfs.h| 6 +- hw/hppa/hppa_hardware.h | 5 + hw/input/adb-internal.h | 4 hw/net/e1000e_core.h | 5 + hw/net/e1

[Qemu-devel] [PULL 07/12] Clean up a few header guard symbols

2019-06-11 Thread Markus Armbruster
Commit 58ea30f5145 "Clean up header guards that don't match their file name" messed up contrib/elf2dmp/qemu_elf.h and tests/migration/migration-test.h. It missed target/cris/opcode-cris.h and tests/uefi-test-tools/UefiTestToolsPkg/Include/Guid/BiosTablesTest.h due to the scripts/clean-header-guard

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-06-11 Thread Laine Stump
On 5/17/19 8:58 AM, Jens Freimann wrote: This is another attempt at implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) Changes since last RFC: - work around circular dependency of commandline options. Just add failover=

[Qemu-devel] [PULL 10/12] MAINTAINERS: Remove duplicate entries of qemu-devel@nongnu.org

2019-06-11 Thread Markus Armbruster
From: Philippe Mathieu-Daudé The list is always selected by the 'All patches CC here' section. Signed-off-by: Philippe Mathieu-Daudé [Conflicts resolved by redoing the patch] Signed-off-by: Markus Armbruster --- MAINTAINERS | 11 --- 1 file changed, 11 deletions(-) diff --git a/MAINT

Re: [Qemu-devel] [PATCH v2 06/11] Move monitor.c to monitor/misc.c

2019-06-11 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Create a new monitor/ subdirectory and move monitor.c there. As the plan > is to move the monitor core into separate files, use the chance to > rename it to misc.c. > > Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert > --- > docs/devel/wr

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-06-11 Thread Jag Raman
On 5/23/2019 6:40 AM, Stefan Hajnoczi wrote: On Tue, May 07, 2019 at 03:00:52PM -0400, Jag Raman wrote: Hi Stefan, Thank you very much for your feedback. Following is a summary of the discussions our team had regarding your feedback. On 4/25/2019 11:44 AM, Stefan Hajnoczi wrote: Can multi

Re: [Qemu-devel] New HAXM maintainer

2019-06-11 Thread Yuan, Hang
Thank you for the good suggestion! We will prepare the patch. Regards, Henry > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Tuesday, June 11, 2019 11:16 PM > To: Xu, Colin ; Yuan, Hang > Cc: qemu-devel ; haxm-team t...@intel.com> > Subject: Re: [Qemu-de

Re: [Qemu-devel] [PULL 0/3] x86 queue, 2019-06-11

2019-06-11 Thread Peter Maydell
On Tue, 11 Jun 2019 at 14:42, Eduardo Habkost wrote: > > The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into > staging (2019-06-10 16:09:19 +0100) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-06-11 Thread Michael S. Tsirkin
On Tue, Jun 11, 2019 at 11:42:54AM -0400, Laine Stump wrote: > On 5/17/19 8:58 AM, Jens Freimann wrote: > > This is another attempt at implementing the host side of the > > net_failover concept > > (https://www.kernel.org/doc/html/latest/networking/net_failover.html) > > > > Changes since last RFC

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-11 Thread Eduardo Habkost
On Tue, Jun 11, 2019 at 04:50:34PM +0100, Peter Maydell wrote: > On Mon, 10 Jun 2019 at 13:58, Peter Maydell wrote: > > Hi. This fails to build on one of my buildtest machines: > > > > ERROR: Cannot use 'python3', Python 2 >= 2.7 or Python 3 >= 3.5 is required. > >Use --python=/path/to/pyt

[Qemu-devel] Qemu: Scroll up in qemu

2019-06-11 Thread Mukesh Ojha
How can we scroll up in the console in qemu  ? /local/mnt/workspace/mojha/qemu/qemu.git/x86_64-softmmu/qemu-system-x86_64 -kernel /local/mnt/workspace/mojha/linux/arch/x86/boot/bzImage -initrd /local/mnt/workspace/mojha/buildroot/output/images/rootfs.cpio -append "resume=/dev/sda console=ttyAMA

[Qemu-devel] [PATCH v3] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-11 Thread Eric Auger
The code used to assign an interrupt index/subindex to an eventfd is duplicated many times. Let's introduce an helper that allows to set/unset the signaling for an ACTION_TRIGGER, ACTION_MASK or ACTION_UNMASK action. Signed-off-by: Eric Auger --- v2 -> v3: - irq_to_str() simply outputs the IRQ

Re: [Qemu-devel] [PATCH v11 4/7] dm: enable synchronous dax

2019-06-11 Thread Pankaj Gupta
> > > Hi Mike, > > > > Thanks for the review Please find my reply inline. > > > > > > > > dm_table_supports_dax() is called multiple times (from > > > dm_table_set_restrictions and dm_table_determine_type). It is strange > > > to have a getter have a side-effect of being a setter too. Over

Re: [Qemu-devel] [PATCH v2 07/11] monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c

2019-06-11 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Now that we have a monitor/ subdirectory, let's move hmp.c and qmp.c > from the root directory there. As they contain implementations of > monitor commands, rename them to {hmp,qmp}-cmds.c, so that {hmp,qmp}.c > are free for the HMP and QMP infrastructure. >

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-06-11 Thread Jag Raman
On 5/30/2019 4:54 PM, Elena Ufimtseva wrote: On Tue, May 28, 2019 at 08:18:20AM -0700, Elena Ufimtseva wrote: On Thu, May 23, 2019 at 12:11:30PM +0100, Stefan Hajnoczi wrote: Hi Jag and Elena, Do you think a call would help to move discussion along more quickly? Hi Stefan, We would like

Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on

2019-06-11 Thread Laurent Vivier
Le 11/06/2019 à 16:55, Ramon Fried a écrit : > defining CADENCE_GEM_ERR_DEBUG causes compilation > errors, fix that. > > Signed-off-by: Ramon Fried > --- > v2: change %lx to HWADDR_PRIx and %lx to %zdx HWADDR_PRIx is to use with hwaddr type (packet_desc_addr). rx_desc_get_buffer() is uint64_t, y

Re: [Qemu-devel] [PATCH 0/4] add failover feature for assigned network devices

2019-06-11 Thread Laine Stump
On 6/11/19 11:51 AM, Michael S. Tsirkin wrote: On Tue, Jun 11, 2019 at 11:42:54AM -0400, Laine Stump wrote: On 5/17/19 8:58 AM, Jens Freimann wrote: This is another attempt at implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.

Re: [Qemu-devel] [PULL 0/8] Python queue, 2019-06-07

2019-06-11 Thread Peter Maydell
On Mon, 10 Jun 2019 at 13:58, Peter Maydell wrote: > Hi. This fails to build on one of my buildtest machines: > > ERROR: Cannot use 'python3', Python 2 >= 2.7 or Python 3 >= 3.5 is required. >Use --python=/path/to/python to specify a supported Python. > > The machine has python 2.7.6 and 3

Re: [Qemu-devel] [PULL 00/12] Miscellaneous patches for 2019-06-11

2019-06-11 Thread Peter Maydell
On Tue, 11 Jun 2019 at 16:44, Markus Armbruster wrote: > > The following changes since commit a578cdfbdd8f9beff5ced52b7826ddb1669abbbf: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190610' into > staging (2019-06-10 16:09:19 +0100) > > are available in the Git repository at: >

<    1   2   3   >