Patchew URL: https://patchew.org/QEMU/20190611134043.9524-1-kw...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190611134043.9524-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/11] monitor: Split monitor.c in core/HMP/QMP/misc Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20190611134043.9524-1-kw...@redhat.com -> patchew/20190611134043.9524-1-kw...@redhat.com Switched to a new branch 'test' a38b11f monitor: Split out monitor/monitor.c 2e3d743 monitor: Split out monitor/hmp.c ec837c0 monitor: Split out monitor/qmp.c 7768f93 monitor: Create monitor_int.h with common definitions 212dab6 monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c f91cabf Move monitor.c to monitor/misc.c 29cf561 monitor: Move cmd_table to MonitorHMP bdc1972 monitor: Create MonitorHMP with readline state b9b4f94 monitor: Make MonitorQMP a child class of Monitor 96e8406 monitor: Split monitor_init in HMP and QMP function 56ef4bc monitor: Remove unused password prompting fields === OUTPUT BEGIN === 1/11 Checking commit 56ef4bc625de (monitor: Remove unused password prompting fields) 2/11 Checking commit 96e84064dbfb (monitor: Split monitor_init in HMP and QMP function) 3/11 Checking commit b9b4f94fff3f (monitor: Make MonitorQMP a child class of Monitor) 4/11 Checking commit bdc1972d7f1c (monitor: Create MonitorHMP with readline state) 5/11 Checking commit 29cf56123d68 (monitor: Move cmd_table to MonitorHMP) 6/11 Checking commit f91cabfa3ac2 (Move monitor.c to monitor/misc.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 78 lines checked Patch 6/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/11 Checking commit 212dab63ea80 (monitor: Move {hmp, qmp}.c to monitor/{hmp, qmp}-cmds.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #102: rename from hmp.c total: 0 errors, 1 warnings, 73 lines checked Patch 7/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/11 Checking commit 7768f93ab68d (monitor: Create monitor_int.h with common definitions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #171: new file mode 100644 total: 0 errors, 1 warnings, 290 lines checked Patch 8/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/11 Checking commit ec837c059664 (monitor: Split out monitor/qmp.c) ERROR: return is not a function, parentheses are not required #586: FILE: monitor/monitor_int.h:154: + return (mon->flags & MONITOR_USE_CONTROL); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #610: new file mode 100644 total: 1 errors, 1 warnings, 967 lines checked Patch 9/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/11 Checking commit 2e3d7432ffd3 (monitor: Split out monitor/hmp.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 ERROR: consider using qemu_strtoull in preference to strtoull #409: FILE: monitor/hmp.c:364: + n = strtoull(pch, &p, 0); WARNING: Block comments use a leading /* on a separate line #1291: FILE: monitor/hmp.c:1246: + /* if the line ends with a space, it means we want to complete the WARNING: Block comments use a trailing */ on a separate line #1292: FILE: monitor/hmp.c:1247: + * next arg */ total: 1 errors, 3 warnings, 2878 lines checked Patch 10/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/11 Checking commit a38b11f617c4 (monitor: Split out monitor/monitor.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #706: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #1313: FILE: monitor/monitor.c:603: + { /* end of list */ } total: 0 errors, 2 warnings, 1273 lines checked Patch 11/11 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190611134043.9524-1-kw...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
