Re: [Qemu-devel] [PULL 5/5] migratioin/ram: leave RAMBlock->bmap blank on allocating

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 02:26:52PM +0200, Philippe Mathieu-Daud?? wrote: >migratioin -> migration Ah, you are right. -- Wei Yang Help you, Help me

Re: [Qemu-devel] [PULL 5/5] migratioin/ram: leave RAMBlock->bmap blank on allocating

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 01:53:18PM +0200, Juan Quintela wrote: >From: Wei Yang > >During migration, we would sync bitmap from ram_list.dirty_memory to >RAMBlock.bmap in cpu_physical_memory_sync_dirty_bitmap(). > >Since we set RAMBlock.bmap and ram_list.dirty_memory both to all 1, this >means at th

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 02:27:11PM +0200, Philippe Mathieu-Daud?? wrote: >migratioin -> migration Ah... I should take an English lesson... Thanks -- Wei Yang Help you, Help me

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 12:33:39PM +0200, Juan Quintela wrote: >Peter Xu wrote: >> On Wed, Jun 05, 2019 at 04:52:07PM +0800, Wei Yang wrote: >>> On Wed, Jun 05, 2019 at 02:41:08PM +0800, Peter Xu wrote: >>> >On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote: >>> >> In case we gets a queued

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 05:38:19PM +0800, Peter Xu wrote: >On Wed, Jun 05, 2019 at 04:52:07PM +0800, Wei Yang wrote: >> On Wed, Jun 05, 2019 at 02:41:08PM +0800, Peter Xu wrote: >> >On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote: >> >> In case we gets a queued page, the order of block is

Re: [Qemu-devel] [PULL 3/3] contrib: add vhost-user-input

2019-06-05 Thread Marc-André Lureau
Hi On Thu, May 30, 2019 at 1:17 PM Peter Maydell wrote: > > On Wed, 22 May 2019 at 09:29, Gerd Hoffmann wrote: > > > > From: Marc-André Lureau > > > > Add a vhost-user input backend example, based on virtio-input-host > > device. It takes an evdev path as argument, and can be associated with >

Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-06-05 Thread Laurent Vivier
On 05/06/2019 15:05, Markus Armbruster wrote: > Laurent Vivier writes: > >> Add a new RNG backend using QEMU builtin getrandom function. >> >> v7: rebase on master >> Make rng-builtin asynchronous with QEMUBH (removed existing R-b) > > Pardon the ignorant question: why is that necessary? >

Re: [Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content

2019-06-05 Thread Daniel P . Berrangé
On Thu, May 30, 2019 at 09:28:11PM +0200, Olaf Hering wrote: > The resulting firmware files should only contain the runtime path. > Fixes commit 26ce90fde5c ("Makefile: install the edk2 firmware images > and their descriptors") > > Signed-off-by: Olaf Hering > --- > Makefile | 2 +- > 1 file cha

[Qemu-devel] [Bug 1831750] [NEW] virtual machine cpu soft lockup when qemu attach disk

2019-06-05 Thread 贞贵李
Public bug reported: Hi, I found a problem that virtual machine cpu soft lockup when I attach a disk to the vm in the case that backend storage network has a large delay or IO pressure is too large. 1) The disk xml which I attached is: 2) Th

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/5/19 3:39 PM, Wei Yang wrote: > On Wed, Jun 05, 2019 at 02:27:11PM +0200, Philippe Mathieu-Daud?? wrote: >> migratioin -> migration > > Ah... I should take an English lesson... Your English is fine, I believe this is just a typo that slipped in ;)

Re: [Qemu-devel] qgraph

2019-06-05 Thread Natalia Fursova
I see. We need this opportunity and want to implement it. Will it ok for QOM conception? Best regards, Natalia -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Wednesday, June 05, 2019 4:07 PM To: Natalia Fursova; qemu-devel@nongnu.org; 'Паша' Subject: Re: [Qem

Re: [Qemu-devel] Headers without multiple inclusion guards

2019-06-05 Thread Daniel P . Berrangé
On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: > We have a bunch of headers without multiple inclusion guards. Some are > clearly intentional, some look accidental. Too many for me to find out > by examining each of them, so I'm asking their maintainers. > > Why do I ask? I'

Re: [Qemu-devel] [PATCH 1/5] tricore: add FTOIZ instruction

2019-06-05 Thread Bastian Koppelmann
On 6/5/19 8:11 AM, David Brenken wrote: From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 25 + target/t

Re: [Qemu-devel] [PATCH v3 1/3] docs/interop/bitmaps.rst: Fix typos

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
04.06.2019 0:46, John Snow wrote: > Pygments and Sphinx get pickier all the time; Sphinx 2.1+ now catches > these errors. > > Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy > --- > docs/interop/bitmaps.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH 2/5] tricore: add UTOF instruction

2019-06-05 Thread Bastian Koppelmann
On 6/5/19 8:11 AM, David Brenken wrote: From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/fpu_helper.c | 16 target/tricore/he

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Tue, Jun 04, 2019 at 03:43:21PM +0200, Jens Freimann wrote: > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > > > On Thu, May 30, 2019 at

Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction

2019-06-05 Thread Bastian Koppelmann
Hi David, On 6/5/19 8:11 AM, David Brenken wrote: From: David Brenken Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 11 --- 1 file changed

[Qemu-devel] [PATCH 3/6] target/mips: Unroll loops in helpers for MSA logic instructions

2019-06-05 Thread Aleksandar Markovic
From: Aleksandar Markovic Unroll loops in helpers for MSA logic instructions for better performance. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 44 1 file changed, 40 insertions(+), 4 deletions(-) diff --git a/target/mips/msa

[Qemu-devel] [PATCH 6/6] target/mips: Outline places for future MSA helpers

2019-06-05 Thread Aleksandar Markovic
From: Aleksandar Markovic Outline places for future MSA helpers to follow the same organization as in MSA tests. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 138 +++ 1 file changed, 138 insertions(+) diff --git a/target/mips/ms

[Qemu-devel] [PATCH 0/6] target/mips: Amend and clean up MSA support

2019-06-05 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains various refactorings and cleanups of MSA support. Improve support for logic instructions, add tests for shift instructions, improve code style, outline future organization. Aleksandar Markovic (6): target/mips: Fix space-related format issues im

Re: [Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Eric Blake
On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 13 + > io/channel-socket.c | 19 +++ > io/channel.c | 14 ++ > 3 files changed, 46 insertions(+) Dan, if you'd lik

[Qemu-devel] [PATCH 1/6] target/mips: Fix space-related format issues im msa_helper.c

2019-06-05 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix space-related format issues reported by checkpatch in file msa_helper.c. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/mips/msa_helper.c b/t

[Qemu-devel] [PATCH 2/6] target/mips: Fix block-comment-related issues im msa_helper.c

2019-06-05 Thread Aleksandar Markovic
From: Aleksandar Markovic Fix block-comment-related issues reported by checkpatch for file msa_helper.c. Signed-off-by: Aleksandar Markovic --- target/mips/msa_helper.c | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/target/mips/

[Qemu-devel] [PULL 0/2] SCSI/vl.c patches for 2019-06-05

2019-06-05 Thread Paolo Bonzini
The following changes since commit c87759ce876a7a0b17c2bf4f0b964bd51f0ee871: q35: Revert to kernel irqchip (2019-06-03 14:03:03 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to edfb4389c26cbfd873707306024130bda

[Qemu-devel] [PATCH 5/6] tests/tcg: target/mips: Amend and rearrange MSA wrappers

2019-06-05 Thread Aleksandar Markovic
From: Aleksandar Markovic Amend and rearrange MSA wrappers to follow the same organization as in MSA tests. Signed-off-by: Aleksandar Markovic --- tests/tcg/mips/include/wrappers_msa.h | 402 ++ 1 file changed, 265 insertions(+), 137 deletions(-) diff --git a/t

Re: [Qemu-devel] [PATCH v4 08/11] numa: Extend the command-line to provide memory latency and bandwidth information

2019-06-05 Thread Igor Mammedov
On Wed, 8 May 2019 14:17:23 +0800 Tao Xu wrote: > From: Liu Jingqi > > Add -numa hmat-lb option to provide System Locality Latency and > Bandwidth Information. These memory attributes help to build > System Locality Latency and Bandwidth Information Structure(s) > in ACPI Heterogeneous Memory

Re: [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Eric Blake
On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote: > Enable keepalive option to track server availablity. s/availablity/availability/ Do we want this unconditionally, or should it be an option (and hence exposed over QMP)? > > Requested-by: Denis V. Lunev > Signed-off-by: Vladimir Sementso

Re: [Qemu-devel] [PATCH RFC v20 3/8] target/avr: Add mechanism to check for active debugger connection

2019-06-05 Thread Richard Henderson
On 6/5/19 2:20 AM, Michael Rolnik wrote: > Hi Richard. > > I am still struggling with this one. > > The spec says. > The BREAK instruction is used by the On-chip Debug system, and is normally not > used in the application software.  > When the BREAK instruction is executed, the AVR CPU is set in

[Qemu-devel] [PULL 1/2] vl: Fix -drive / -blockdev persistent reservation management

2019-06-05 Thread Paolo Bonzini
From: Markus Armbruster qemu-system-FOO's main() acts on command line arguments in its own idiosyncratic order. There's not much method to its madness. Whenever we find a case where one kind of command line argument needs to refer to something created for another kind later, we rejigger the orde

[Qemu-devel] [PULL 2/2] vl: Document why objects are delayed

2019-06-05 Thread Paolo Bonzini
From: Markus Armbruster Objects should not be "delayed" without a reason, as the previous commit demonstrates. The remaining ones have reasons. State them. and demand future ones come with such a statement. Signed-off-by: Markus Armbruster Message-Id: <20190604151251.9903-3-arm...@redhat.com>

[Qemu-devel] [Bug 1831225] Re: guest migration 100% cpu freeze bug

2019-06-05 Thread Dion Bosschieter
Hi Jean, Could you elaborate, is it the qemu patch that you applied and didn't apply that to the current qem u version you are running? Could you try to get a crash dump from a frozen vm working, see if you get the same kind of backtrace in there. Which specific qemu version are you running, whi

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/2] iotests: test external snapshot with bitmap copying

2019-06-05 Thread Max Reitz
On 17.05.19 17:21, Vladimir Sementsov-Ogievskiy wrote: > This test shows that external snapshots and incremental backups are > friends. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/254 | 52 ++ > tests/qemu-iotests/254.out | 5

Re: [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Denis V. Lunev
On 6/5/19 5:39 PM, Eric Blake wrote: > On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote: >> Enable keepalive option to track server availablity. > s/availablity/availability/ > > Do we want this unconditionally, or should it be an option (and hence > exposed over QMP)? That is good question, i

Re: [Qemu-devel] [PATCH v2 06/22] s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)

2019-06-05 Thread Richard Henderson
On 6/5/19 4:19 AM, David Hildenbrand wrote: > On 03.06.19 11:06, David Hildenbrand wrote: >> Provide for all three instructions all four combinations of cc bit and >> s bit. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/helper.h | 12 >> target/s390x/insn-data.def

Re: [Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content

2019-06-05 Thread Philippe Mathieu-Daudé
[Odd, I'm pretty sure I replied to this last week but can't find it, so again] Cc'ing Laszlo since he wrote this. On 5/30/19 9:28 PM, Olaf Hering wrote: > The resulting firmware files should only contain the runtime path. > Fixes commit 26ce90fde5c ("Makefile: install the edk2 firmware images > an

[Qemu-devel] [PATCH 0/5] Misc vhost-user fixes

2019-06-05 Thread Marc-André Lureau
Hi, Here is a few fixes spotted by Coverity in the recently landed vhost-user-{input,gpu}. Marc-André Lureau (5): vhost-user-gpu: do not send scanout update if no GPU socket vhost-user: check unix_listen() return value vhost-user: improve error report vhost-user-input: check ioctl(EVIOCGN

[Qemu-devel] [PATCH 1/5] vhost-user-gpu: do not send scanout update if no GPU socket

2019-06-05 Thread Marc-André Lureau
Should fix coverity CID 1401760. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-gpu/main.c b/contrib/vhost-user-gpu/main.c index f9e2146b69..9614c9422c 100644 --- a/contrib/vhost-user-gpu/m

[Qemu-devel] [PATCH 5/5] vhost-user-gpu: initialize msghdr & iov at declaration

2019-06-05 Thread Marc-André Lureau
This should fix uninitialized fields found by coverity CID 1401762. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/main.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/contrib/vhost-user-gpu/main.c b/contrib/vhost-user-gpu/main.c index 0e

[Qemu-devel] [PATCH 3/5] vhost-user: improve error report

2019-06-05 Thread Marc-André Lureau
g_printerr() needs a trailing \n Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/main.c | 2 +- contrib/vhost-user-input/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/vhost-user-gpu/main.c b/contrib/vhost-user-gpu/main.c index e0b6df5b4d..0ef

[Qemu-devel] [PATCH 2/5] vhost-user: check unix_listen() return value

2019-06-05 Thread Marc-André Lureau
This check shouldn't be necessary, since &error_fatal is given as argument and will exit() on failure. However, this change should silence coverity CID 1401761 & 1401705. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/main.c | 4 contrib/vhost-user-input/main.c | 4 2 fi

[Qemu-devel] [PATCH 4/5] vhost-user-input: check ioctl(EVIOCGNAME) return value

2019-06-05 Thread Marc-André Lureau
This should fix coverity CID 1401704. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-input/main.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/vhost-user-input/main.c b/contrib/vhost-user-input/main.c index 54f882602a..8b4e7d2536 100644 --- a/contrib/

Re: [Qemu-devel] [PATCH 4/5] tricore: add QSEED instruction

2019-06-05 Thread Bastian Koppelmann
Hi, On 6/5/19 8:11 AM, David Brenken wrote: +/* + * Target TriCore QSEED.F significand Lookup Table + * + * The QSEED.F output significand depends on the least-significant + * exponent bit and the 6 most-significant significand bits. + * + * IEEE 754 float datatype + * partitioned into Sign (S),

Re: [Qemu-devel] [PATCH 4/4] qemu-sockets: do not require configured ipv4/ipv6 address

2019-06-05 Thread Daniel P . Berrangé
On Fri, May 24, 2019 at 01:40:11AM +0200, Marc-André Lureau wrote: > podman containers without network don't have ipv4/ipv6 addresses other > than loopback address. However, some of our tests require > getaddrinfo("127.0.0.1") to succeed. > > Alternatively, we may want to treat 127.0.0.1 as a spec

Re: [Qemu-devel] [RFC PATCH 0/3] hw/display: Refresh UI depending on vGPU page flip events

2019-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190604095847.10532-1-tina.zh...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash ti

Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/2] iotests: test external snapshot with bitmap copying

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2019 17:51, Max Reitz wrote: > On 17.05.19 17:21, Vladimir Sementsov-Ogievskiy wrote: >> This test shows that external snapshots and incremental backups are >> friends. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> tests/qemu-iotests/254 | 52 +

Re: [Qemu-devel] [PATCH 3/4] docker: update fedora to f30

2019-06-05 Thread Daniel P . Berrangé
On Fri, May 24, 2019 at 01:17:17PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, May 24, 2019 at 9:41 AM Philippe Mathieu-Daudé > wrote: > > > > On 5/24/19 1:40 AM, Marc-André Lureau wrote: > > > Released last month. > > > > > > Signed-off-by: Marc-André Lureau > > > --- > > > tests/docker/d

Re: [Qemu-devel] [PATCH 0/5] tricore: adding new instructions and fixing issues

2019-06-05 Thread Bastian Koppelmann
Hi Guys, On 6/5/19 8:11 AM, David Brenken wrote: From: David Brenken Hello everyone, in the scope of this patchset we added implementations for the following instructions for the target TriCore: QSEED, FTOIZ, UTOF first of all thanks for these patches. QSEED.F was one instruction that was

Re: [Qemu-devel] [PATCH RFC v20 3/8] target/avr: Add mechanism to check for active debugger connection

2019-06-05 Thread Michael Rolnik
Richard. We use break instruction for testing. (Here https://github.com/seharris/qemu-avr-tests/tree/master/instruction-tests). Each test is a big list of small tests with a break between them. We run the tests on HW and on QEMU then compare register after each break. If we don't implement break t

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Mon, Jun 03, 2019 at 12:46:52PM -0600, Alex Williamson wrote: > On Mon, 3 Jun 2019 14:10:52 -0400 > Laine Stump wrote: > > > On 6/3/19 4:24 AM, Jens Freimann wrote: > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > > >> On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Fr

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Thu, May 30, 2019 at 02:09:42PM -0400, Michael S. Tsirkin wrote: > On Thu, May 30, 2019 at 07:00:23PM +0100, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrote: > > > > Hi David, > > > > > > > > sor

[Qemu-devel] [PATCH] iotests: fix 254 for qcow (1)

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Qcow default cluster size is 4k, but default format of created overlay image on snapshot operation is qcow2 with it's default cluster of 64k. This leads to block-dirty-bitmap-merge fail when test run for qcow format, as it can't merge bitmaps with different granularities. Let's fix it by specifyin

Re: [Qemu-devel] [PATCH 3/4] docker: update fedora to f30

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/5/19 5:10 PM, Daniel P. Berrangé wrote: > On Fri, May 24, 2019 at 01:17:17PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Fri, May 24, 2019 at 9:41 AM Philippe Mathieu-Daudé >> wrote: >>> >>> On 5/24/19 1:40 AM, Marc-André Lureau wrote: Released last month. Signed-off-by: Mar

Re: [Qemu-devel] [PATCH] iotests: fix 254 for qcow (1)

2019-06-05 Thread Max Reitz
On 05.06.19 17:26, Vladimir Sementsov-Ogievskiy wrote: > Qcow default cluster size is 4k, but default format of created overlay > image on snapshot operation is qcow2 with it's default cluster of 64k. Then I wonder why we run this test even for anything but qcow2. I forgot to mention that this te

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-05 Thread Daniel P . Berrangé
On Fri, May 31, 2019 at 04:24:29PM -0300, Eduardo Habkost wrote: > Long story short: I would really like to drop support for Python > 2 in QEMU 4.1. > > What exactly prevents us from doing this? Does our deprecation > policy really apply to build dependencies? In general I do *not* consider our

Re: [Qemu-devel] [PATCH] iotests: fix 254 for qcow (1)

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2019 18:33, Max Reitz wrote: > On 05.06.19 17:26, Vladimir Sementsov-Ogievskiy wrote: >> Qcow default cluster size is 4k, but default format of created overlay >> image on snapshot operation is qcow2 with it's default cluster of 64k. > > Then I wonder why we run this test even for anything b

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-05 Thread Daniel P . Berrangé
On Mon, Jun 03, 2019 at 02:26:49PM +0200, Markus Armbruster wrote: > John Snow writes: > > > On 5/31/19 3:24 PM, Eduardo Habkost wrote: > >> Long story short: I would really like to drop support for Python > >> 2 in QEMU 4.1. > > The sooner, the better, as far as I'm concerned. > > >> What exac

[Qemu-devel] [PATCH] iotests: restrict 254 to support only qcow2

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Test fails at least for qcow, because of different cluster sizes in base and top (and therefore different granularities of bitmaps we are trying to merge). The test aim is to check block-dirty-bitmap-merge between different nodes functionality, no needs to check all formats. So, let's just drop su

Re: [Qemu-devel] [PATCH] block/io_uring: use pkg-config for liburing

2019-06-05 Thread Daniel P . Berrangé
On Sat, May 25, 2019 at 10:05:59AM +0100, Stefan Hajnoczi wrote: > Now that liburing has pkg-config support, use it instead of hardcoding > compiler flags in QEMU's build scripts. This way distros can customize > the location of liburing's headers and libraries without requiring > changes to QEMU.

Re: [Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines

2019-06-05 Thread Cleber Rosa
On Tue, May 21, 2019 at 12:06:34AM +0200, Philippe Mathieu-Daudé wrote: > Avoid to log empty lines in console debug logs. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tests

Re: [Qemu-devel] [PATCH 0/6] target/mips: Amend and clean up MSA support

2019-06-05 Thread Aleksandar Rikalo
> From: Aleksandar Markovic > Sent: Wednesday, June 5, 2019 4:35 PM > To: qemu-devel@nongnu.org > Cc: Aleksandar Markovic; Aleksandar Rikalo > Subject: [PATCH 0/6] target/mips: Amend and clean up MSA support > > From: Aleksandar Markovic > > This series contains various refactorings and cleanups

Re: [Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 01:09:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 13 + > io/channel-socket.c | 19 +++ > io/channel.c | 14 ++ > 3 files changed, 46 insertion

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Laine Stump
On 6/4/19 9:43 AM, Jens Freimann wrote: On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo Habkost wrote: > On Thu, May 30, 2019 at 04:56:45PM +0200, Jens Freimann wrot

Re: [Qemu-devel] [PATCH RFC v20 3/8] target/avr: Add mechanism to check for active debugger connection

2019-06-05 Thread Richard Henderson
On 6/5/19 10:19 AM, Michael Rolnik wrote: > Richard. > > We use break instruction for testing. > (Here  > https://github.com/seharris/qemu-avr-tests/tree/master/instruction-tests). > Each test is a big list of small tests with a break between them. We run the > tests on HW and on QEMU then compare

Re: [Qemu-devel] [PATCH 2/2] BootLinuxConsoleTest: Test the SmartFusion2 board

2019-06-05 Thread Cleber Rosa
On Tue, May 21, 2019 at 12:06:35AM +0200, Philippe Mathieu-Daudé wrote: > Similar to the x86_64/pc test, it boots a Linux kernel on an > Emcraft board and verify the serial is working. > > If ARM is a target being built, "make check-acceptance" will > automatically include this test by the use of

Re: [Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 09:38:06AM -0500, Eric Blake wrote: > On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote: > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > > include/io/channel.h | 13 + > > io/channel-socket.c | 19 +++ > > io/channel.c | 1

Re: [Qemu-devel] [PATCH RFC v20 3/8] target/avr: Add mechanism to check for active debugger connection

2019-06-05 Thread Alex Bennée
Michael Rolnik writes: > Richard. > > We use break instruction for testing. (Here > https://github.com/seharris/qemu-avr-tests/tree/master/instruction-tests). > Each test is a big list of small tests with a break between them. We run > the tests on HW and on QEMU then compare register after eac

Re: [Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2019 19:02, Daniel P. Berrangé wrote: > On Wed, Jun 05, 2019 at 01:09:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> include/io/channel.h | 13 + >> io/channel-socket.c | 19 +++ >> io/channel.c

[Qemu-devel] [PATCH 0/4] block: Keep track of parent quiescing

2019-06-05 Thread Max Reitz
We currently do not keep track of how many times a child has quiesced its parent. We just guess based on the child’s quiesce_counter. That keeps biting us when we try to leave drained sections or detach children (see e.g. commit 5cb2737e925042e). I think we need an explicit counter to keep track

[Qemu-devel] [PATCH 2/4] block: Make @parent_quiesced a bool

2019-06-05 Thread Max Reitz
Reliably ending the drain on a BDS's parents is quite difficult. What we have to achieve is to undrain exactly those parents that have been added to the BDS while its quiesce_counter was elevated. If we move decrementing the quiesce_counter before the invocation of bdrv_parent_drained_end(), that

[Qemu-devel] [PATCH 1/4] block: Introduce BdrvChild.parent_quiesce_counter

2019-06-05 Thread Max Reitz
Commit 5cb2737e925042e6c7cd3fb0b01313950b03cddf laid out why bdrv_do_drained_end() must decrement the quiesce_counter after bdrv_drain_invoke(). It did not give a very good reason why it has to happen after bdrv_parent_drained_end(), instead only claiming symmetry to bdrv_do_drained_begin(). It t

[Qemu-devel] [PATCH 4/4] iotests: Test commit with a filter on the chain

2019-06-05 Thread Max Reitz
Before the previous patches, the first case resulted in a failed assertion (which is noted as qemu receiving a SIGABRT in the test output), and the second usually triggered a segmentation fault. Signed-off-by: Max Reitz --- tests/qemu-iotests/040 | 40 +-

Re: [Qemu-devel] [PATCH] iotests: restrict 254 to support only qcow2

2019-06-05 Thread Max Reitz
On 05.06.19 17:54, Vladimir Sementsov-Ogievskiy wrote: > Test fails at least for qcow, because of different cluster sizes in > base and top (and therefore different granularities of bitmaps we are > trying to merge). > > The test aim is to check block-dirty-bitmap-merge between different > nodes f

[Qemu-devel] [PATCH 3/4] iotests: Add @has_quit to vm.shutdown()

2019-06-05 Thread Max Reitz
If a test has issued a quit command already (which may be useful to do explicitly because the test wants to show its effects), QEMUMachine.shutdown() should not do so again. Otherwise, the VM may well return an ECONNRESET which will lead QEMUMachine.shutdown() to killing it, which then turns into

[Qemu-devel] [PATCH v2 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Enable keepalive option to track server availability. Requested-by: Denis V. Lunev Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd-client.c b/block/nbd-client.c index 790ecc1ee1..b57cea8482 100644 --- a/block/nbd-c

[Qemu-devel] [PATCH v2 0/2] nbd: enable keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a suggestion to enable keepalive option to track server availablity. We suggest to enable it by default. If we need, we'll be able to add option to specify timeout by hand later. v2: 01 - Fix io channel returned errors to be -1 [Daniel] 02 - Fix typo in commit message [Eric]

[Qemu-devel] [PATCH v2 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/io/channel.h | 15 +++ io/channel-socket.c | 20 io/channel.c | 14 ++ 3 files changed, 49 insertions(+) diff --git a/include/io/channel.h b/include/io/channel.h index 59460cb1ec..b8789e

Re: [Qemu-devel] Headers without multiple inclusion guards

2019-06-05 Thread Laszlo Ersek
On 06/05/19 16:23, Daniel P. Berrangé wrote: > On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: >> We have a bunch of headers without multiple inclusion guards. Some are >> clearly intentional, some look accidental. Too many for me to find out >> by examining each of them, so I'

Re: [Qemu-devel] [PATCH 3/4] net/virtio: add failover support

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 12:04:28PM -0400, Laine Stump wrote: > On 6/4/19 9:43 AM, Jens Freimann wrote: > > On Mon, Jun 03, 2019 at 04:36:48PM -0300, Eduardo Habkost wrote: > > > On Mon, Jun 03, 2019 at 10:24:56AM +0200, Jens Freimann wrote: > > > > On Fri, May 31, 2019 at 06:47:48PM -0300, Eduardo

Re: [Qemu-devel] sigsegv in chardev on iotest 045 (raw)

2019-06-05 Thread Max Reitz
On 05.06.19 03:15, John Snow wrote: > Running tests on a development branch (I haven't touched chardev stuff, > I swear!); I ran into the below crash where s->ioc was NULL. I don't > have the time to investigate at this exact moment, so please excuse the > hasty report so I don't forget to tell som

[Qemu-devel] [PATCH v1 1/4] cputlb: use uint64_t for interim values for unaligned load

2019-06-05 Thread Alex Bennée
When running on 32 bit TCG backends a wide unaligned load ends up truncating data before returning to the guest. We specifically have the return type as uint64_t to avoid any premature truncation so we should use the same for the interim types. Fixes: https://bugs.launchpad.net/qemu/+bug/1830872 F

[Qemu-devel] [PATCH v1 4/4] tests/tcg/x86_64: add a PVHVM crt.o for x86_64 system tests

2019-06-05 Thread Alex Bennée
Instead of doing the full real to 64 bit dance we are attempting to leverage Xen's PVHVM boot spec to go from 32 bit to 64 bit. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.softmmu-target | 1 + tests/tcg/x86_64/system/boot.S | 277 + tests/tcg/x86_64/

[Qemu-devel] [PATCH v1 2/4] tests/tcg: better detect truncated reads

2019-06-05 Thread Alex Bennée
If we've truncated a wider read we can detect the condition earlier by looking at the number of zeros we've read. So we don't trip up on cases where we have written zeros to the start of the buffer we also ensure we only start each offset read from the right address. Signed-off-by: Alex Bennée --

[Qemu-devel] [PATCH v1 0/4] softmmu de-macro fix with tests

2019-06-05 Thread Alex Bennée
Hi, So this is the fix for the cputlb de-macro along with some tweaks to the testing. It turns out tests/memory would detect the failure of running aarch64-on-armv7 but we glossed over the zeroed load because the logic didn't account for multiple zeros in a row. While I was at it I updated the s

[Qemu-devel] [PATCH v1 3/4] tests/tcg: clean-up VPATH/TESTS for i386

2019-06-05 Thread Alex Bennée
Since we only run build the multiarch tests and we use a fully resolved path for the crt object we don't need the wildcard or VPATH messing about. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.softmmu-target | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/te

Re: [Qemu-devel] Headers without multiple inclusion guards

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 06:18:38PM +0200, Laszlo Ersek wrote: > On 06/05/19 16:23, Daniel P. Berrangé wrote: > > On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: > >> We have a bunch of headers without multiple inclusion guards. Some are > >> clearly intentional, some look accide

Re: [Qemu-devel] [PATCH v2 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 07:18:03PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/io/channel.h | 15 +++ > io/channel-socket.c | 20 > io/channel.c | 14 ++ > 3 files changed, 49 insert

Re: [Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content

2019-06-05 Thread Laszlo Ersek
On 06/05/19 16:46, Philippe Mathieu-Daudé wrote: > [Odd, I'm pretty sure I replied to this last week but can't find it, so > again] > Cc'ing Laszlo since he wrote this. > > On 5/30/19 9:28 PM, Olaf Hering wrote: >> The resulting firmware files should only contain the runtime path. >> Fixes commit

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on high core count ARM system

2019-06-05 Thread dann frazier
** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title:

Re: [Qemu-devel] [PATCH v1 4/4] tests/tcg/x86_64: add a PVHVM crt.o for x86_64 system tests

2019-06-05 Thread Paolo Bonzini
On 05/06/19 18:23, Alex Bennée wrote: > Instead of doing the full real to 64 bit dance we are attempting to > leverage Xen's PVHVM boot spec to go from 32 bit to 64 bit. It's PVH, "PVHVM" is something else. :) Paolo > Signed-off-by: Alex Bennée > --- > tests/tcg/i386/Makefile.softmmu-target |

Re: [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 09:39:10AM -0500, Eric Blake wrote: > On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote: > > Enable keepalive option to track server availablity. > > s/availablity/availability/ > > Do we want this unconditionally, or should it be an option (and hence > exposed over QM

Re: [Qemu-devel] [PATCH v1] Makefile: remove DESTDIR from firmware file content

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/5/19 6:31 PM, Laszlo Ersek wrote: > On 06/05/19 16:46, Philippe Mathieu-Daudé wrote: >> [Odd, I'm pretty sure I replied to this last week but can't find it, so >> again] >> Cc'ing Laszlo since he wrote this. >> >> On 5/30/19 9:28 PM, Olaf Hering wrote: >>> The resulting firmware files should o

Re: [Qemu-devel] Headers without multiple inclusion guards

2019-06-05 Thread Laszlo Ersek
On 06/05/19 18:23, Daniel P. Berrangé wrote: > On Wed, Jun 05, 2019 at 06:18:38PM +0200, Laszlo Ersek wrote: >> On 06/05/19 16:23, Daniel P. Berrangé wrote: >>> On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote: We have a bunch of headers without multiple inclusion guards. Som

Re: [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2019 19:37, Daniel P. Berrangé wrote: > On Wed, Jun 05, 2019 at 09:39:10AM -0500, Eric Blake wrote: >> On 6/5/19 5:09 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Enable keepalive option to track server availablity. >> >> s/availablity/availability/ >> >> Do we want this unconditionally, or sh

Re: [Qemu-devel] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create

2019-06-05 Thread Kevin Wolf
Am 05.06.2019 um 14:32 hat Vladimir Sementsov-Ogievskiy geschrieben: > child_role job already has .stay_at_node=true, so on bdrv_replace_node > operation these child are unchanged. Make block job blk behave in same > manner, to avoid inconsistent intermediate graph states and workarounds > like in

Re: [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Eric Blake
On 6/5/19 12:05 PM, Vladimir Sementsov-Ogievskiy wrote: >> By enabling TCP keepalives we are explicitly making the connection >> less reliable by forcing it to be terminated when keepalive >> threshold triggers, instead of waiting longer for TCP to recover. >> >> The rationale s that once a connec

Re: [Qemu-devel] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2019 20:11, Kevin Wolf wrote: > Am 05.06.2019 um 14:32 hat Vladimir Sementsov-Ogievskiy geschrieben: >> child_role job already has .stay_at_node=true, so on bdrv_replace_node >> operation these child are unchanged. Make block job blk behave in same >> manner, to avoid inconsistent intermediat

Re: [Qemu-devel] sigsegv in chardev on iotest 045 (raw)

2019-06-05 Thread John Snow
On 6/5/19 12:22 PM, Max Reitz wrote: > On 05.06.19 03:15, John Snow wrote: >> Running tests on a development branch (I haven't touched chardev stuff, >> I swear!); I ran into the below crash where s->ioc was NULL. I don't >> have the time to investigate at this exact moment, so please excuse the

Re: [Qemu-devel] [Qemu-devel PATCH v2 2/2] util/main-loop: Fix incorrect assertion

2019-06-05 Thread Lidong Chen
On 6/5/2019 1:57 AM, Philippe Mathieu-Daudé wrote: This patch doesn't seem related to the series cover. I will resent the patch to include more details to the cover. On 6/5/19 8:21 AM, Lidong Chen wrote: The check for poll_fds in g_assert() was incorrect. The correct assertion should check

Re: [Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
05.06.2019 20:12, Eric Blake wrote: > On 6/5/19 12:05 PM, Vladimir Sementsov-Ogievskiy wrote: > >>> By enabling TCP keepalives we are explicitly making the connection >>> less reliable by forcing it to be terminated when keepalive >>> threshold triggers, instead of waiting longer for TCP to recove

Re: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave

2019-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/b3540b0c-9a71-4733-8109-11b0dc7a1...@me.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/2] ui/cocoa: Fix input device issues on Mojave Type: series Message-id: b3540b0c-9

<    1   2   3   >