On Tue, May 21, 2019 at 12:06:34AM +0200, Philippe Mathieu-Daudé wrote:
> Avoid to log empty lines in console debug logs.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> tests/acceptance/boot_linux_console.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index d5c500ea30..f593f3858e 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -37,8 +37,10 @@ class BootLinuxConsole(Test):
> console = self.vm.console_socket.makefile()
> console_logger = logging.getLogger('console')
> while True:
> - msg = console.readline()
> - console_logger.debug(msg.strip())
> + msg = console.readline().strip()
> + if not msg:
> + continue
> + console_logger.debug(msg)
> if success_message in msg:
> break
> if failure_message in msg:
> --
> 2.19.1
>
This is particularly useful in the
boot_linux_console.py:BootLinuxConsole.test_s390x_s390_ccw_virtio test, where
in my experience empty lines were being logged.
Reviewed-by: Cleber Rosa <cr...@redhat.com>
Tested-by: Cleber Rosa <cr...@redhat.com>
