Re: [Qemu-devel] [PATCH v2 4/5] block/nvme: add support for write zeros

2019-06-05 Thread Fam Zheng
On Wed, 04/17 22:53, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 69 +++- > block/trace-events | 1 + > include/block/nvme.h | 19 +++- > 3 files changed, 87 insertions(+), 2 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH v3 06/10] hw/s390x: Replace global smp variables with machine smp properties

2019-06-05 Thread Eduardo Habkost
On Sun, May 19, 2019 at 04:54:24AM +0800, Like Xu wrote: > The global smp variables in s390x are replaced with smp machine properties. > > A local variable of the same name would be introduced in the declaration > phase if it's used widely in the context OR replace it on the spot if it's > only us

Re: [Qemu-devel] [PATCH v3 07/10] hw/i386: Replace global smp variables with machine smp properties

2019-06-05 Thread Eduardo Habkost
On Sun, May 19, 2019 at 04:54:25AM +0800, Like Xu wrote: > The global smp variables in i386 are replaced with smp machine properties. > To avoid calling qdev_get_machine() as much as possible, some related funtions > for acpi data generations are refactored. No semantic changes. > > A local variab

Re: [Qemu-devel] [PATCH v3 09/10] hw: Replace global smp variables with MachineState for all remaining archs

2019-06-05 Thread Eduardo Habkost
On Sun, May 19, 2019 at 04:54:27AM +0800, Like Xu wrote: > The global smp variables in alpha/hppa/mips/openrisc/sparc*/xtensa codes > are replaced with smp properties from MachineState. > > A local variable of the same name would be introduced in the declaration > phase if it's used widely in the

Re: [Qemu-devel] [PATCH v3 08/10] hw/arm: Replace global smp variables with machine smp properties

2019-06-05 Thread Eduardo Habkost
On Sun, May 19, 2019 at 04:54:26AM +0800, Like Xu wrote: > The global smp variables in arm are replaced with smp machine properties. > The init_cpus() and *_create_rpu() are refactored to pass MachineState. > > A local variable of the same name would be introduced in the declaration > phase if it'

Re: [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into machine properties

2019-06-05 Thread Eduardo Habkost
On Sun, May 19, 2019 at 04:54:18AM +0800, Like Xu wrote: > This patch series make existing cores/threads/sockets into machine > properties and get rid of global smp_* variables they use currently. > > The purpose of getting rid of globals is disentangle layer violations and > let's do it one step

Re: [Qemu-devel] [PATCH v4 07/11] hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI HMAT

2019-06-05 Thread Tao Xu
On 6/5/2019 8:12 PM, Igor Mammedov wrote: On Wed, 5 Jun 2019 14:04:10 +0800 Tao Xu wrote: On 6/4/2019 11:04 PM, Igor Mammedov wrote: On Wed, 8 May 2019 14:17:22 +0800 Tao Xu wrote: ... + +/* SMBIOS Handles */ +/* TBD: set smbios handles */ +

Re: [Qemu-devel] [PATCH v3 10/10] vl.c: Replace smp global variables with smp machine properties

2019-06-05 Thread Eduardo Habkost
On Sun, May 19, 2019 at 04:54:28AM +0800, Like Xu wrote: > The global smp variables in vl.c are completely replaced with machine > properties. > > Form this commit, the smp_cpus/smp_cores/smp_threads/max_cpus are deprecated > and only machine properties within MachineState are fully applied and e

Re: [Qemu-devel] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-05 Thread David Gibson
On Wed, May 29, 2019 at 11:10:49AM +0530, Aravinda Prasad wrote: > Enable the KVM capability KVM_CAP_PPC_FWNMI so that > the KVM causes guest exit with NMI as exit reason > when it encounters a machine check exception on the > address belonging to a guest. Without this capability > enabled, KVM red

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-05 Thread David Gibson
On Tue, Jun 04, 2019 at 12:15:26PM +0530, Aravinda Prasad wrote: > > > On Monday 03 June 2019 08:55 PM, Greg Kurz wrote: > > On Wed, 29 May 2019 11:10:49 +0530 > > Aravinda Prasad wrote: > > > >> Enable the KVM capability KVM_CAP_PPC_FWNMI so that > >> the KVM causes guest exit with NMI as exit

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-05 Thread David Gibson
On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > This patch includes migration support for machine check > handling. Especially this patch blocks VM migration > requests until the machine check error handling is > complete as (i) these errors are specific to the source > hardware

Re: [Qemu-devel] [PATCH v9 4/6] target/ppc: Build rtas error log upon an MCE

2019-06-05 Thread David Gibson
On Tue, Jun 04, 2019 at 11:01:19AM +0200, Greg Kurz wrote: > On Tue, 4 Jun 2019 11:59:13 +0530 > Aravinda Prasad wrote: > > > On Monday 03 June 2019 07:30 PM, Greg Kurz wrote: > > > On Wed, 29 May 2019 11:10:40 +0530 > > > Aravinda Prasad wrote: > > > > > >> Upon a machine check exception (MC

Re: [Qemu-devel] [PATCH v9 4/6] target/ppc: Build rtas error log upon an MCE

2019-06-05 Thread David Gibson
On Tue, Jun 04, 2019 at 11:59:13AM +0530, Aravinda Prasad wrote: > > > On Monday 03 June 2019 07:30 PM, Greg Kurz wrote: > > On Wed, 29 May 2019 11:10:40 +0530 > > Aravinda Prasad wrote: > > > >> Upon a machine check exception (MCE) in a guest address space, > >> KVM causes a guest exit to enab

Re: [Qemu-devel] [PATCH v3 04/10] hw/ppc: Replace global smp variables with machine smp properties

2019-06-05 Thread David Gibson
On Wed, Jun 05, 2019 at 11:54:56PM -0300, Eduardo Habkost wrote: > On Wed, Jun 05, 2019 at 11:52:41PM -0300, Eduardo Habkost wrote: > > On Sun, May 19, 2019 at 04:54:22AM +0800, Like Xu wrote: > > > The global smp variables in ppc are replaced with smp machine properties. > > > > > > A local varia

Re: [Qemu-devel] [PATCH v2 3/5] vl.c: Add -smp, dies=* command line support and update -smp doc

2019-06-05 Thread Eduardo Habkost
On Tue, May 21, 2019 at 12:50:54AM +0800, Like Xu wrote: > For PC target, users could configure the number of dies per one package > via command line with this patch, such as "-smp dies=2,cores=4". > > A new pc-specified pc_smp_parse() is introduced and to keep the interface > consistent, refactor

Re: [Qemu-devel] [PATCH v2 5/5] block/nvme: add support for discard

2019-06-05 Thread Fam Zheng
On Wed, 04/17 22:53, Maxim Levitsky wrote: > Signed-off-by: Maxim Levitsky > --- > block/nvme.c | 80 ++ > block/trace-events | 2 ++ > 2 files changed, 82 insertions(+) > > diff --git a/block/nvme.c b/block/nvme.c > index 35b925899f..b83912c627

Re: [Qemu-devel] [PATCH v2 1/5] target/i386: Add cpu die-level topology support for X86CPU

2019-06-05 Thread Eduardo Habkost
On Tue, May 21, 2019 at 12:50:52AM +0800, Like Xu wrote: > The die-level as the first PC-specific cpu topology is added to the > leagcy cpu topology model which only covers sockets/cores/threads. > > In the new model with die-level support, the total number of logical > processors (including offli

Re: [Qemu-devel] [PATCH v2 1/5] target/i386: Add cpu die-level topology support for X86CPU

2019-06-05 Thread Eduardo Habkost
On Tue, May 21, 2019 at 12:50:52AM +0800, Like Xu wrote: > The die-level as the first PC-specific cpu topology is added to the > leagcy cpu topology model which only covers sockets/cores/threads. > > In the new model with die-level support, the total number of logical > processors (including offli

[Qemu-devel] spapr_pci: Advertise BAR reallocation capability

2019-06-05 Thread Alexey Kardashevskiy
The pseries guests do not normally allocate PCI resouces and rely on the system firmware doing so. Furthermore at least at some point in the past the pseries guests won't even be allowed to change BARs, probably it is still the case for phyp. So since the initial commit we have [1] which prevents r

Re: [Qemu-devel] spapr_pci: Advertise BAR reallocation capability

2019-06-05 Thread Alexey Kardashevskiy
I changed my handy scripts for posting patches and the subject line broke, do I need to repost? It made it to the patchworks though. On 06/06/2019 14:09, Alexey Kardashevskiy wrote: > The pseries guests do not normally allocate PCI resouces and rely on > the system firmware doing so. Furthermore

Re: [Qemu-devel] spapr_pci: Advertise BAR reallocation capability

2019-06-05 Thread David Gibson
On Thu, Jun 06, 2019 at 02:13:20PM +1000, Alexey Kardashevskiy wrote: > I changed my handy scripts for posting patches and the subject line > broke, do I need to repost? It made it to the patchworks though. No, that's fine I've seen it and will look at it when I have the chance. > > > > On 06/

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 07:05 AM, David Gibson wrote: > On Mon, Jun 03, 2019 at 01:17:23PM +0200, Greg Kurz wrote: >> On Mon, 3 Jun 2019 12:12:43 +0200 >> Greg Kurz wrote: >> >>> On Wed, 29 May 2019 11:10:14 +0530 >>> Aravinda Prasad wrote: >>> This patch adds support in QEMU to handle "

Re: [Qemu-devel] [PATCH v9 3/6] target/ppc: Handle NMI guest exit

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 07:13 AM, David Gibson wrote: > On Wed, May 29, 2019 at 11:10:32AM +0530, Aravinda Prasad wrote: >> Memory error such as bit flips that cannot be corrected >> by hardware are passed on to the kernel for handling. >> If the memory address in error belongs to guest then >>

Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-06-05 Thread Markus Armbruster
Laurent Vivier writes: > On 05/06/2019 19:56, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> On 05/06/2019 15:05, Markus Armbruster wrote: Laurent Vivier writes: > Add a new RNG backend using QEMU builtin getrandom function. > > v7: rebase on master > M

Re: [Qemu-devel] [PATCH v7 2/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-06-05 Thread Markus Armbruster
Laurent Vivier writes: > Add a new RNG backend using QEMU builtin getrandom function. > > It can be created and used with something like: > > ... -object rng-builtin,id=rng0 -device virtio-rng,rng=rng0 ... > > Signed-off-by: Laurent Vivier > --- > backends/Makefile.objs | 2 +- > backends/

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 08:32 AM, David Gibson wrote: > On Tue, Jun 04, 2019 at 12:15:26PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 03 June 2019 08:55 PM, Greg Kurz wrote: >>> On Wed, 29 May 2019 11:10:49 +0530 >>> Aravinda Prasad wrote: >>> Enable the KVM capability KVM_CAP_PPC_F

Re: [Qemu-devel] [PATCH v4 04/11] acpi: introduce AcpiDeviceIfClass.build_mem_ranges hook

2019-06-05 Thread Tao Xu
On 5/24/2019 8:35 PM, Igor Mammedov wrote: On Wed, 8 May 2019 14:17:19 +0800 Tao Xu wrote: Add build_mem_ranges callback to AcpiDeviceIfClass and use it for generating SRAT and HMAT numa memory ranges. Suggested-by: Igor Mammedov Co-developed-by: Liu Jingqi Signed-off-by: Liu Jingqi Signe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-05 Thread Aravinda Prasad
On Tuesday 04 June 2019 08:20 PM, Greg Kurz wrote: > On Tue, 4 Jun 2019 11:38:31 +0530 > Aravinda Prasad wrote: > >> On Monday 03 June 2019 04:47 PM, Greg Kurz wrote: >>> On Mon, 3 Jun 2019 12:12:43 +0200 >>> Greg Kurz wrote: >>> On Wed, 29 May 2019 11:10:14 +0530 Aravinda Prasad

Re: [Qemu-devel] Deprecation policy and build dependencies

2019-06-05 Thread Markus Armbruster
Eric Blake writes: > On 6/5/19 3:13 PM, Eduardo Habkost wrote: > >>> IOW, I don't think RHEL-7 support as a build platform blocks us from >>> dropping py2. We merely need to tweak our build platforms doc to clarify >>> our intent wrt add-on yum repos. >> >> If we clarify the docs in QEMU 4.1, is

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 07:04 AM, David Gibson wrote: > On Wed, May 29, 2019 at 11:10:14AM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine check notification address is saved when the >> OS is

Re: [Qemu-devel] [Qemu-devel PATCH v2 2/2] util/main-loop: Fix incorrect assertion

2019-06-05 Thread Markus Armbruster
You neglected to cc: the file's maintainer. I'm doing that for you now. In the future, use scripts/get_maintainer.pl to find maintainers you might want to cc:. Lidong Chen writes: > The check for poll_fds in g_assert() was incorrect. The correct assertion > should check "n_poll_fds + w->num <=

Re: [Qemu-devel] Qemu baseline requirements/portability?

2019-06-05 Thread Markus Armbruster
"H. Peter Anvin" writes: > On 6/5/19 12:55 PM, H. Peter Anvin wrote: >> Hi, >> >> I am writing some code I'm hoping will be able to make it into Qemu, but I >> can't seem to find what the baseline portability requirements are. I'm >> specifically wondering about newer POSIX features like openat

Re: [Qemu-devel] [PATCH v6 4/6] include/elf: Add defines related to notes for GNU systems

2019-06-05 Thread Aleksandar Markovic
On Jun 5, 2019 11:03 PM, "Richard Henderson" wrote: > > This is a collection of related Related to what? > defines for notes, copied > from glibc's . We're not going to use all of these > right away, but it seemed foolish I don't think this an appropriate word for a commit message. > to cherr

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-05 Thread Greg Kurz
On Thu, 6 Jun 2019 13:06:14 +1000 David Gibson wrote: > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: > > This patch includes migration support for machine check > > handling. Especially this patch blocks VM migration > > requests until the machine check error handling is > > c

Re: [Qemu-devel] [PATCH] hw: misc: Add Aspeed XDMA device

2019-06-05 Thread Cédric Le Goater
Hello Eddie, On 04/06/2019 00:09, Eddie James wrote: > The XDMA engine embedded in the Aspeed SOCs performs PCI DMA operations > between the SOC (acting as a BMC) and a host processor in a server. > > The XDMA engine exists on the AST2400, AST2500, and AST2600 SOCs, so > enable it for all of thos

Re: [Qemu-devel] [PATCH v2 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-05 Thread Greg Kurz
On Wed, 5 Jun 2019 14:49:34 +0800 Yongji Xie wrote: > On Wed, 5 Jun 2019 at 14:42, Greg Kurz wrote: > > > > On Tue, 4 Jun 2019 15:34:56 +0800 > > elohi...@gmail.com wrote: > > > > > From: Xie Yongji > > > > > > Besides virtio 1.0 transitional devices, we should also > > > set "start_on_kick"

Re: [Qemu-devel] [PATCH 04/13] target/arm/kvm: Move the get/put of fpsimd registers out

2019-06-05 Thread Auger Eric
Hi Drew, On 5/12/19 10:36 AM, Andrew Jones wrote: > Move the getting/putting of the fpsimd registers out of > kvm_arch_get/put_registers() into their own helper functions > to prepare for alternatively getting/putting SVE registers. > > No functional change. > > Signed-off-by: Andrew Jones > --

Re: [Qemu-devel] [PATCH v2 2/5] virtio: Set "start_on_kick" for legacy devices

2019-06-05 Thread Yongji Xie
On Wed, 5 Jun 2019 at 15:14, Greg Kurz wrote: > > On Wed, 5 Jun 2019 14:49:34 +0800 > Yongji Xie wrote: > > > On Wed, 5 Jun 2019 at 14:42, Greg Kurz wrote: > > > > > > On Tue, 4 Jun 2019 15:34:56 +0800 > > > elohi...@gmail.com wrote: > > > > > > > From: Xie Yongji > > > > > > > > Besides virti

Re: [Qemu-devel] [PATCH 01/13] target/arm/kvm64: fix error returns

2019-06-05 Thread Auger Eric
Hi, On 5/12/19 10:36 AM, Andrew Jones wrote: > A couple return -EINVAL's forget their '-'s. > > Signed-off-by: Andrew Jones > --- > target/arm/kvm64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c > index e3ba1492482f..ba23

Re: [Qemu-devel] [PULL 29/44] spapr/xive: introduce a VM state change handler

2019-06-05 Thread Alexey Kardashevskiy
On 04/06/2019 18:10, Cédric Le Goater wrote: > On 04/06/2019 09:49, Alexey Kardashevskiy wrote: >> >> >> On 29/05/2019 16:50, David Gibson wrote: >>> From: Cédric Le Goater >>> >>> This handler is in charge of stabilizing the flow of event notifications >>> in the XIVE controller before migrati

Re: [Qemu-devel] [PATCH RFC v20 3/8] target/avr: Add mechanism to check for active debugger connection

2019-06-05 Thread Michael Rolnik
Hi Richard. I am still struggling with this one. The spec says. The BREAK instruction is used by the On-chip Debug system, and is normally not used in the application software. When the BREAK instruction is executed, the AVR CPU is set in the Stopped Mode. This gives the On-chip Debugger access t

Re: [Qemu-devel] [PATCH 02/13] update-linux-headers: Add sve_context.h to asm-arm64

2019-06-05 Thread Auger Eric
Hi, On 5/12/19 10:36 AM, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > scripts/update-linux-headers.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > index c3819d2b983d..e1fce54f8aa3 100755 > --- a/scri

Re: [Qemu-devel] [PULL 26/44] spapr/xive: add KVM support

2019-06-05 Thread Alexey Kardashevskiy
On 04/06/2019 17:54, Cédric Le Goater wrote: > On 04/06/2019 09:23, Alexey Kardashevskiy wrote: >> >> >> On 29/05/2019 16:49, David Gibson wrote: >>> From: Cédric Le Goater >>> >>> This introduces a set of helpers when KVM is in use, which create the >>> KVM XIVE device, initialize the interrup

Re: [Qemu-devel] [PATCH 04/13] target/arm/kvm: Move the get/put of fpsimd registers out

2019-06-05 Thread Andrew Jones
On Wed, Jun 05, 2019 at 09:15:49AM +0200, Auger Eric wrote: > Hi Drew, > > On 5/12/19 10:36 AM, Andrew Jones wrote: > > Move the getting/putting of the fpsimd registers out of > > kvm_arch_get/put_registers() into their own helper functions > > to prepare for alternatively getting/putting SVE regi

Re: [Qemu-devel] [PATCH 02/13] update-linux-headers: Add sve_context.h to asm-arm64

2019-06-05 Thread Andrew Jones
On Wed, Jun 05, 2019 at 09:21:18AM +0200, Auger Eric wrote: > Hi, > > On 5/12/19 10:36 AM, Andrew Jones wrote: > > Signed-off-by: Andrew Jones > > --- > > scripts/update-linux-headers.sh | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/scripts/update-linux-headers.sh > > b/scr

Re: [Qemu-devel] [Qemu-ppc] [PULL 09/29] target/ppc: introduce get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() helpers for VSR register access

2019-06-05 Thread Laurent Vivier
On 05/06/2019 08:32, Mark Cave-Ayland wrote: > On 04/06/2019 22:23, Laurent Vivier wrote: > >> This patch breaks something in the libcrypto. >> >> I've been able to reproduce the problem with Fedora 29: >> >> dnf install 'dnf-command(download)' >> dnf download --source coreutils-single >> rpm --ve

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/5] block/nvme: don't flip CQ phase bits

2019-06-05 Thread Maxim Levitsky
On Mon, 2019-06-03 at 18:25 -0400, John Snow wrote: > > On 4/17/19 3:53 PM, Maxim Levitsky wrote: > > Phase bits are only set by the hardware to indicate new completions > > and not by the device driver. > > > > Signed-off-by: Maxim Levitsky > > --- > > block/nvme.c | 2 -- > > 1 file changed,

Re: [Qemu-devel] [Qemu-ppc] [PULL 09/29] target/ppc: introduce get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() helpers for VSR register access

2019-06-05 Thread Mark Cave-Ayland
On 05/06/2019 08:43, Laurent Vivier wrote: > On 05/06/2019 08:32, Mark Cave-Ayland wrote: >> On 04/06/2019 22:23, Laurent Vivier wrote: >> >>> This patch breaks something in the libcrypto. >>> >>> I've been able to reproduce the problem with Fedora 29: >>> >>> dnf install 'dnf-command(download)' >

Re: [Qemu-devel] [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

2019-06-05 Thread Kevin Wolf
Am 04.06.2019 um 19:06 hat Heitke, Kenneth geschrieben: > > > On 6/4/2019 3:13 AM, Klaus Birkelund wrote: > > On Tue, Jun 04, 2019 at 10:46:45AM +0200, Kevin Wolf wrote: > > > Am 04.06.2019 um 10:28 hat Klaus Birkelund geschrieben: > > > > On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth

[Qemu-devel] Problems with Pass through of a AMD Vega 56/64

2019-06-05 Thread James Courtier-Dutton
Hi, Problem: Pass through of a AMD Vega 56 or 64 on a AMD Threadripper 1950X with X399 Motherboard , Host OS: Linux Kernel 5.1.5, did not work. Various problems were observed: 1) PCI BAR resizing - The GPU tries to resize the BAR from 256M to 8G. The resize fails, but the Guest does not know thi

Re: [Qemu-devel] [PATCH 3/4] Clean up a few header guard symbols

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/4/19 8:16 PM, Markus Armbruster wrote: > Commit 58ea30f5145 "Clean up header guards that don't match their file > name" messed up contrib/elf2dmp/qemu_elf.h and > tests/migration/migration-test.h. > > It missed target/cris/opcode-cris.h and > tests/uefi-test-tools/UefiTestToolsPkg/Include/Gui

Re: [Qemu-devel] [Qemu-devel PATCH v2 1/2] sd: Fix out-of-bounds assertions

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/5/19 8:21 AM, Lidong Chen wrote: > Due to an off-by-one error, the assert statements allow an > out-of-bound array access. Not sure via which tree this patch is going (trivial?). To the maintainer, please consider adding when applying: "This access can not happen. Fix to silent static analyz

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 02:41:08PM +0800, Peter Xu wrote: >On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote: >> In case we gets a queued page, the order of block is interrupted. We may >> not rely on the complete_round flag to say we have already searched the >> whole blocks on the list. >>

Re: [Qemu-devel] [Qemu-devel PATCH v2 2/2] util/main-loop: Fix incorrect assertion

2019-06-05 Thread Philippe Mathieu-Daudé
This patch doesn't seem related to the series cover. On 6/5/19 8:21 AM, Lidong Chen wrote: > The check for poll_fds in g_assert() was incorrect. The correct assertion > should check "n_poll_fds + w->num <= ARRAY_SIZE(poll_fds)" because the > subsequent for-loop is doing access to poll_fds[n_poll_f

Re: [Qemu-devel] [PATCH v2 5/5] virtio: add "use-started" property

2019-06-05 Thread Greg Kurz
On Tue, 4 Jun 2019 15:34:59 +0800 elohi...@gmail.com wrote: > From: Xie Yongji > > In order to avoid migration issues, we introduce a "use-started" > property to the base virtio device to indicate whether use > "started" flag or not. This property will be true by default and > set to false when

Re: [Qemu-devel] [PATCH 5/5] tricore: reset DisasContext before generating code

2019-06-05 Thread Bastian Koppelmann
Hi, On 6/5/19 8:11 AM, David Brenken wrote: From: Georg Hofstetter Signed-off-by: Andreas Konopik Signed-off-by: David Brenken Signed-off-by: Georg Hofstetter Signed-off-by: Robert Rasche Signed-off-by: Lars Biermanski --- target/tricore/translate.c | 1 + 1 file changed, 1 insertion(

Re: [Qemu-devel] [PATCH 06/13] target/arm/kvm: max cpu: Enable SVE when available

2019-06-05 Thread Auger Eric
Hi Drew, On 5/12/19 10:36 AM, Andrew Jones wrote: > Enable SVE in the KVM guest when the 'max' cpu type is configured > and KVM supports it. KVM SVE requires use of the new finalize > vcpu ioctl, so we add that now too. > > Signed-off-by: Andrew Jones > --- > target/arm/cpu64.c | 1 + > targ

Re: [Qemu-devel] [PATCH v2 5/5] virtio: add "use-started" property

2019-06-05 Thread Yongji Xie
On Wed, 5 Jun 2019 at 17:00, Greg Kurz wrote: > > On Tue, 4 Jun 2019 15:34:59 +0800 > elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > In order to avoid migration issues, we introduce a "use-started" > > property to the base virtio device to indicate whether use > > "started" flag or not

Re: [Qemu-devel] [PULL 24/24] q35: Revert to kernel irqchip

2019-06-05 Thread Greg Kurz
On Mon, 3 Jun 2019 19:10:43 +0200 Paolo Bonzini wrote: > From: Alex Williamson > > Commit b2fc91db8447 ("q35: set split kernel irqchip as default") changed > the default for the pc-q35-4.0 machine type to use split irqchip, which > turned out to have disasterous effects on vfio-pci INTx suppor

Re: [Qemu-devel] [PATCH v2 06/22] s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)

2019-06-05 Thread David Hildenbrand
On 03.06.19 11:06, David Hildenbrand wrote: > Provide for all three instructions all four combinations of cc bit and > s bit. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 12 > target/s390x/insn-data.def | 6 ++ > target/s390x/translate_vx.inc.c |

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Peter Xu
On Wed, Jun 05, 2019 at 04:52:07PM +0800, Wei Yang wrote: > On Wed, Jun 05, 2019 at 02:41:08PM +0800, Peter Xu wrote: > >On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote: > >> In case we gets a queued page, the order of block is interrupted. We may > >> not rely on the complete_round flag t

Re: [Qemu-devel] [PATCH for-4.1 0/2] hw/alpha: Add the CY82C693UB southbridge in Kconfig

2019-06-05 Thread Laurent Vivier
On 27/05/2019 18:05, Philippe Mathieu-Daudé wrote: > On 5/8/19 10:16 PM, Philippe Mathieu-Daudé wrote: >> Paolo, Thomas, >> >> On 4/29/19 1:29 PM, Philippe Mathieu-Daudé wrote: >>> CC'ing Thomas who is a Kconfig expert. >>> >>> On 3/17/19 12:44 AM, Philippe Mathieu-Daudé wrote: Explicit the CY

[Qemu-devel] [PATCH 2/2] nbd-client: enable TCP keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Enable keepalive option to track server availablity. Requested-by: Denis V. Lunev Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd-client.c b/block/nbd-client.c index 790ecc1ee1..b57cea8482 100644 --- a/block/nbd-cl

[Qemu-devel] [PATCH 0/2] nbd: enable keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a suggestion to enable keepalive option to track server availablity. Vladimir Sementsov-Ogievskiy (2): io/channel: add qio_channel_set_keepalive nbd-client: enable TCP keepalive include/io/channel.h | 13 + block/nbd-client.c | 1 + io/channel-socket.c | 19 +

[Qemu-devel] [PATCH 1/2] io/channel: add qio_channel_set_keepalive

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/io/channel.h | 13 + io/channel-socket.c | 19 +++ io/channel.c | 14 ++ 3 files changed, 46 insertions(+) diff --git a/include/io/channel.h b/include/io/channel.h index 59460cb1ec..34d871a41

Re: [Qemu-devel] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

2019-06-05 Thread Greg Kurz
On Wed, 29 May 2019 13:59:26 +0100 Anthony PERARD wrote: > On Wed, May 29, 2019 at 12:24:44PM +0200, Greg Kurz wrote: > > Xen folks are the actual maintainers for this. > > > > Signed-off-by: Greg Kurz > > --- > > MAINTAINERS |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs

2019-06-05 Thread Paul Durrant
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: 05 June 2019 11:11 > To: Anthony Perard > Cc: qemu-devel@nongnu.org; Stefano Stabellini ; Paul > Durrant > > Subject: Re: [PATCH] MAINTAINERS: Change maintership of Xen code under hw/9pfs > > On Wed, 29 May 2019 13:5

[Qemu-devel] [PATCH] tests: Add proper newlines for qmp_fd_receive

2019-06-05 Thread Peter Xu
It changes QTEST_LOG=1 results a bit more lovely, from: {"return": ... }{"execute": "query-migrate"} {"return": ... }{"execute": "query-migrate"} Into: {"execute": "query-migrate"} {"return": ... } {"execute": "query-migrate"} {"return": ... } CC: Thomas Huth CC: Laurent Vivier CC: Paolo

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Juan Quintela
Peter Xu wrote: > On Wed, Jun 05, 2019 at 04:52:07PM +0800, Wei Yang wrote: >> On Wed, Jun 05, 2019 at 02:41:08PM +0800, Peter Xu wrote: >> >On Wed, Jun 05, 2019 at 09:08:28AM +0800, Wei Yang wrote: >> >> In case we gets a queued page, the order of block is interrupted. We may >> >> not rely on th

Re: [Qemu-devel] [PATCH] migration/multifd: sync packet_num after all thread are done

2019-06-05 Thread Juan Quintela
Wei Yang wrote: > Notification from recv thread is not ordered, which means we may be > notified by one MultiFDRecvParams but adjust packet_num for another. > > Move the adjustment after we are sure each recv thread are sync-ed. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela It should

Re: [Qemu-devel] [PATCH 06/13] target/arm/kvm: max cpu: Enable SVE when available

2019-06-05 Thread Andrew Jones
On Wed, Jun 05, 2019 at 11:09:56AM +0200, Auger Eric wrote: > Hi Drew, > > On 5/12/19 10:36 AM, Andrew Jones wrote: > > Enable SVE in the KVM guest when the 'max' cpu type is configured > > and KVM supports it. KVM SVE requires use of the new finalize > > vcpu ioctl, so we add that now too. > > >

Re: [Qemu-devel] [PATCH v4 16/39] target/m68k: Use env_cpu, env_archcpu

2019-06-05 Thread Laurent Vivier
Le 04/06/2019 à 22:33, Richard Henderson a écrit : > Cleanup in the boilerplate that each target must define. > Replace m68k_env_get_cpu with env_archcpu. The combination > CPU(m68k_env_get_cpu) should have used ENV_GET_CPU to begin; > use env_cpu now. > > Reviewed-by: Alistair Francis > Reviewe

[Qemu-devel] [Bug 1831225] Re: guest migration 100% cpu freeze bug

2019-06-05 Thread Dr. David Alan Gilbert
You say it's only happened since 4.19 - that's possible - but since this bug is so tricky to trigger it's also possible that any slight change in 4.19. You could try disabling kvm_clock? Dave -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [PULL 5/5] migratioin/ram: leave RAMBlock->bmap blank on allocating

2019-06-05 Thread Juan Quintela
From: Wei Yang During migration, we would sync bitmap from ram_list.dirty_memory to RAMBlock.bmap in cpu_physical_memory_sync_dirty_bitmap(). Since we set RAMBlock.bmap and ram_list.dirty_memory both to all 1, this means at the first round this sync is meaningless and is a duplicated work. Leav

[Qemu-devel] [PULL 1/5] migration/ram.c: MultiFDSendParams.sem_sync is not really used

2019-06-05 Thread Juan Quintela
From: Wei Yang Besides init and destroy, MultiFDSendParams.sem_sync is not really used. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/ram.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 4c6086922

[Qemu-devel] [PULL 0/5] Migration patches

2019-06-05 Thread Juan Quintela
The following changes since commit 47fbad45d47af8af784bb12a5719489edcd89b4c: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-06-04 17:22:42 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/migration-pull-request

[Qemu-devel] [PULL 2/5] migration/ram.c: multifd_send_state->count is not really used

2019-06-05 Thread Juan Quintela
From: Wei Yang Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/ram.c | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 4c15f6fda1..03a9cce9f9 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -892,

[Qemu-devel] [PULL 3/5] migration: Fix fd protocol for incoming defer

2019-06-05 Thread Juan Quintela
From: Yury Kotov Currently, incoming migration through fd supports only command-line case: E.g. fork(); fd = open(); exec("qemu ... -incoming fd:%d", fd); It's possible to use add-fd commands to pass fd for migration, but it's invalid case. add-fd works with fdset but not with partic

Re: [Qemu-devel] [PATCH v2 01/12] util/iov: introduce qemu_iovec_init_extended

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
04.06.2019 19:15, Vladimir Sementsov-Ogievskiy wrote: > Introduce new initialization API, to create requests with padding. Will > be used in the following patch. New API uses qemu_iovec_init_buf if > resulting io vector has only one element, to avoid extra allocations. > So, we need to update qemu_

[Qemu-devel] [PULL 4/5] migration-test: Add a test for fd protocol

2019-06-05 Thread Juan Quintela
From: Yury Kotov Signed-off-by: Yury Kotov Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Signed-off-by: Juan Quintela --- tests/libqtest.c | 80 ++-- tests/libqtest.h | 51 - tests/migration-test.c | 101 +++

Re: [Qemu-devel] [PATCH v4 07/11] hmat acpi: Build Memory Side Cache Information Structure(s) in ACPI HMAT

2019-06-05 Thread Igor Mammedov
On Wed, 5 Jun 2019 14:04:10 +0800 Tao Xu wrote: > On 6/4/2019 11:04 PM, Igor Mammedov wrote: > > On Wed, 8 May 2019 14:17:22 +0800 > > Tao Xu wrote: > > > >> From: Liu Jingqi > >> > >> This structure describes memory side cache information for memory > >> proximity domains if the memory sid

[Qemu-devel] [PATCH v2 0/3] vmdk: Add read-only support for the new seSparse format

2019-06-05 Thread Sam Eiderman
v1: VMware introduced a new snapshot format in VMFS6 - seSparse (Space Efficient Sparse) which is the default format available in ESXi 6.7. Add read-only support for the new snapshot format. v2: Fixed after Max's review: * Removed strict sesparse checks * Reduced maximal L1 table size * Added n

[Qemu-devel] [PATCH v2 1/3] vmdk: Fix comment regarding max l1_size coverage

2019-06-05 Thread Sam Eiderman
Commit b0651b8c246d ("vmdk: Move l1_size check into vmdk_add_extent") extended the l1_size check from VMDK4 to VMDK3 but did not update the default coverage in the moved comment. The previous vmdk4 calculation: (512 * 1024 * 1024) * 512(l2 entries) * 65536(grain) = 16PB The added vmdk3 calcu

[Qemu-devel] [PATCH v2 2/3] vmdk: Reduce the max bound for L1 table size

2019-06-05 Thread Sam Eiderman
512M of L1 entries is a very loose bound, only 32M are required to store the maximal supported VMDK file size of 2TB. Fixed qemu-iotest 59# - now failure occures before on impossible L1 table size. Reviewed-by: Karl Heubaum Reviewed-by: Eyal Moscovici Reviewed-by: Liran Alon Reviewed-by: Arbel

[Qemu-devel] [PATCH v2 3/3] vmdk: Add read-only support for seSparse snapshots

2019-06-05 Thread Sam Eiderman
Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in QEMU). This format was lacking in the following: * Grain directory (L1) and grain table (L2) entries were 32-bit, allowing access to only 2TB (slightly less) of data. * The grain size (default) was 512 bytes -

Re: [Qemu-devel] [PULL 5/5] migratioin/ram: leave RAMBlock->bmap blank on allocating

2019-06-05 Thread Philippe Mathieu-Daudé
migratioin -> migration

Re: [Qemu-devel] [PATCH] migratioin/ram.c: reset complete_round when we gets a queued page

2019-06-05 Thread Philippe Mathieu-Daudé
migratioin -> migration

[Qemu-devel] [PATCH v2 1/2] block: introduce pinned blk

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Add stay_at_node fields to BlockBackend and BdrvChild, for the same behavior as stay_at_node field of BdrvChildRole. It will be used for block-job blk. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block_int.h | 6 ++ include/sysemu/block-backend.h | 2 ++ block.c

[Qemu-devel] [PATCH v2 0/2] introduce pinned blk

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
Hi all. Here is a proposal of replacing workaround in mirror, when we have to move filter node back to block-job blk after bdrv_replace_node. v2: rebased on updated blk_new, with aio context paramter. Vladimir Sementsov-Ogievskiy (2): block: introduce pinned blk blockjob: use blk_new_pinned

[Qemu-devel] [PATCH v2 2/2] blockjob: use blk_new_pinned in block_job_create

2019-06-05 Thread Vladimir Sementsov-Ogievskiy
child_role job already has .stay_at_node=true, so on bdrv_replace_node operation these child are unchanged. Make block job blk behave in same manner, to avoid inconsistent intermediate graph states and workarounds like in mirror. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 6

Re: [Qemu-devel] [PATCH] qapi: add dirty-bitmaps to query-named-block-nodes result

2019-06-05 Thread Markus Armbruster
John Snow writes: > On 5/31/19 10:55 AM, Eric Blake wrote: >> On 5/30/19 11:26 AM, John Snow wrote: >>> >>> >>> On 5/30/19 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: Let's add a possibility to query dirty-bitmaps not only on root nodes. It is useful when dealing both with snapshots a

Re: [Qemu-devel] qgraph

2019-06-05 Thread Natalia Fursova
Hello, Paolo! Thank you for your answer. I would like to clarify something about the qmp commands. For example, consider SCSI controller "lsi53c895a". For getting information we use two commands: "device-list-properties" and "qom-list-properties". Output consists of many properties, but there is n

Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-06-05 Thread Markus Armbruster
Laurent Vivier writes: > Add a new RNG backend using QEMU builtin getrandom function. > > v7: rebase on master > Make rng-builtin asynchronous with QEMUBH (removed existing R-b) Pardon the ignorant question: why is that necessary?

Re: [Qemu-devel] QMP; unsigned 64-bit ints; JSON standards compliance

2019-06-05 Thread Daniel P . Berrangé
On Tue, Jun 04, 2019 at 08:38:24AM +0200, Markus Armbruster wrote: > We've discussed possible solutions. Is anyone working or intending to > work on patches? I'm not actively working on it now, nor any plans in the near future. I would like to see it fixed sooner rather than later though. Regar

Re: [Qemu-devel] qgraph

2019-06-05 Thread Paolo Bonzini
On 05/06/19 14:34, Natalia Fursova wrote: > > Thank you for your answer. I would like to clarify something about the qmp > commands. > For example, consider SCSI controller "lsi53c895a". For getting information > we use two commands: "device-list-properties" and "qom-list-properties". > Output con

[Qemu-devel] [PATCH] docs/vhost-user.json: some firmware.json copy leftovers

2019-06-05 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- docs/interop/vhost-user.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/interop/vhost-user.json b/docs/interop/vhost-user.json index ae88c03117..da6aaf51c8 100644 --- a/docs/interop/vhost-user.json +++ b/docs/interop/vhost-u

[Qemu-devel] [Bug 1831225] Re: guest migration 100% cpu freeze bug

2019-06-05 Thread Jean-Philippe Menil
Hi, i suffer fro this bug too (or very similar) on 4.15.0-50-generic, without the patch mentionned earlier (i use this patch last year to migrate from previous qemu version). Jean-Philippe -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

Re: [Qemu-devel] [PATCH] target/i386: save EFER for 32-bit targets

2019-06-05 Thread Eduardo Habkost
On Wed, May 29, 2019 at 03:41:56PM +0300, Pavel Dovgalyuk wrote: > i386 (32 bit) emulation uses EFER in wrmsr and in MMU fault > processing. > But it does not included in VMState, because "efer" field is disabled with > #ifdef TARGET_X86_64 > > This patch adds a section for 32-bit targets which sa

Re: [Qemu-devel] [PATCH 1/1] accel: Remove unused AccelClass::opt_name attribute

2019-06-05 Thread Eduardo Habkost
On Fri, May 31, 2019 at 12:53:34PM -0400, Wainer dos Santos Moschetta wrote: > The AccelType type was converted to AccelClass QOM > object on b14a0b7469f, and the original data type had > a field to store the option name which in turn was > used to search an accelerator. The lookup method > (accel_

Re: [Qemu-devel] [PATCH] migration/multifd: sync packet_num after all thread are done

2019-06-05 Thread Wei Yang
On Wed, Jun 05, 2019 at 12:39:06PM +0200, Juan Quintela wrote: >Wei Yang wrote: >> Notification from recv thread is not ordered, which means we may be >> notified by one MultiFDRecvParams but adjust packet_num for another. >> >> Move the adjustment after we are sure each recv thread are sync-ed. >

  1   2   3   >