On 5/24/2019 8:35 PM, Igor Mammedov wrote:
On Wed,  8 May 2019 14:17:19 +0800
Tao Xu <tao3...@intel.com> wrote:

Add build_mem_ranges callback to AcpiDeviceIfClass and use
it for generating SRAT and HMAT numa memory ranges.

Suggested-by: Igor Mammedov <imamm...@redhat.com>
Co-developed-by: Liu Jingqi <jingqi....@intel.com>
Signed-off-by: Liu Jingqi <jingqi....@intel.com>
Signed-off-by: Tao Xu <tao3...@intel.com>
---
...
diff --git a/stubs/pc_build_mem_ranges.c b/stubs/pc_build_mem_ranges.c
new file mode 100644
index 0000000000..0f104ba79d
--- /dev/null
+++ b/stubs/pc_build_mem_ranges.c
@@ -0,0 +1,6 @@
+#include "qemu/osdep.h"
+#include "hw/i386/pc.h"
+
+void pc_build_mem_ranges(AcpiDeviceIf *adev, MachineState *machine)
+{
+}

why do you need stub?

Hi Igor,

I have questions here, I use stub here because we add hook pointer in piix4.c but other arch such mips use piix4. Without stub, it will failed when compile, like pc_madt_cpu_entry.
Or there are other way to make it use just in pc?

Thank you!


Reply via email to