Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: fix a typo

2019-05-28 Thread Laurent Vivier
On 25/05/2019 08:28, Li Qiang wrote: 'postocpy' should be 'postcopy'. CC: qemu-triv...@nongnu.org Signed-off-by: Li Qiang --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 4c60869226..359dc8f1bc 100644 --- a/migrat

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/rdma: Delete unused headers inclusion

2019-05-28 Thread Laurent Vivier
On 24/05/2019 07:29, Marcel Apfelbaum wrote: Hi Markus, On 5/23/19 6:24 PM, Markus Armbruster wrote: Looks stuck.  Let's try qemu-trivial. Thanks, that is a great idea. I didn't want to send a single-patch pull request, especially while another is waiting for reviews. Anyway, trivial queue c

Re: [Qemu-devel] [PATCH v4 03/11] numa: move numa global variable numa_info into MachineState

2019-05-28 Thread Tao Xu
On 23/05/2019 21:47, Igor Mammedov wrote: On Wed, 8 May 2019 14:17:18 +0800 Tao Xu wrote: ... diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 8ff08814fd..845b737ab9 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -602,7 +602,7 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_info

Re: [Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

2019-05-28 Thread Sam Eiderman
Comments inline > On 27 May 2019, at 20:39, Max Reitz wrote: > > On 24.04.19 09:49, Sam Eiderman wrote: >> Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in >> QEMU). >> >> This format was lacking in the following: >> >>* Grain directory (L1) and grain table (L2) ent

Re: [Qemu-devel] [PATCH 1/4] migration: multifd_save_setup always return 0

2019-05-28 Thread Juan Quintela
Wei Yang wrote: > Signed-off-by: Wei Yang > --- > migration/migration.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index d0a0f68f11..3aae4f2734 100644 > --- a/migration/migration.c > +++ b/migration/migration.c >

[Qemu-devel] Make target check-report.tap is broken

2019-05-28 Thread Markus Armbruster
Commit 9df43317b82 "test: replace gtester with a TAP driver" replaced targets check-report.xml and check-report.html by check-report.tap: $(patsubst %,check-report-qtest-%.tap, $(QTEST_TARGETS)) check-report-unit.tap $(call quiet-command,./scripts/tap-merge.py $^ > $@,"GEN","$@") This ne

Re: [Qemu-devel] [PATCH 2/4] migration/ram.c: use same type in MultiFDPages_t to define offsest

2019-05-28 Thread Juan Quintela
Wei Yang wrote: > MultiFDPacket_t.offset is allocated to store MultiFDPages_t.offset. > > It would be better to use the same type. > > Signed-off-by: Wei Yang > --- > migration/ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > inde

Re: [Qemu-devel] [PATCH 3/4] migration/ram.c: MultiFDSendParams.sem_sync is not really used

2019-05-28 Thread Juan Quintela
Wei Yang wrote: > Besides init and destroy, MultiFDSendParams.sem_sync is not really used. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela I mad SendParamas and RecvParams identical, but they are different. You are right.

Re: [Qemu-devel] [PATCH 4/4] migration/ram.c: multifd_send_state->count is not really used

2019-05-28 Thread Juan Quintela
Wei Yang wrote: > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Once upon a time, we checked how many threads were created to recover for errors, but this was wrong because one of the "missing" threads could be one different from the last one. Thanks, Juan.

Re: [Qemu-devel] [PATCH] migration: fix a typo

2019-05-28 Thread Juan Quintela
Li Qiang wrote: > 'postocpy' should be 'postcopy'. > > CC: qemu-triv...@nongnu.org > Signed-off-by: Li Qiang Reviewed-by: Juan Quintela Already in through trivial patches.

[Qemu-devel] [PATCH 2/4] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def

2019-05-28 Thread Markus Armbruster
When commit df2943ba3c7 moved "rm -f qemu-options.def" from distclean to clean, it also added "rm -f $$d/qemu-options.def" to the for d in $(ALL_SUBDIRS) loop. That file doesn't exist. Remove the mistaken rm. Signed-off-by: Markus Armbruster Reviewed-by: Richard Henderson Reviewed-by: Philippe

[Qemu-devel] [PATCH 4/4] Makefile: Reuse all's recursion machinery for clean and install

2019-05-28 Thread Markus Armbruster
Targets "clean" and "install" run make recursively in a for loop. This ignores -j and -k. Target "all" depends on SUBDIR/all to recurse into each SUBDIR. Behaves nicely with -j and -k. Put that to use for "clean" and "install": depend on SUBDIR/clean or SUBDIR/install, respectively, and delete t

[Qemu-devel] [PATCH 1/4] Makefile: Remove code to smooth transition to config.status

2019-05-28 Thread Markus Armbruster
When commit bdf523e6923 made configure generate config.status, it added a fallback to Makefile to smooth the transition, with a TODO "code can be removed after QEMU 1.7." It's been more than five years. Remove it. Signed-off-by: Markus Armbruster Reviewed-by: Richard Henderson Reviewed-by: Phil

[Qemu-devel] [PATCH 0/4] Makefile: Generalize recursion machinery

2019-05-28 Thread Markus Armbruster
We make a few sub-directories recursively, in particular $(TARGET_DIRS). For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k. For other goals such as "clean" and "install", the

[Qemu-devel] [PATCH 3/4] Makefile: Rename targets for make recursion

2019-05-28 Thread Markus Armbruster
We make a few sub-directories recursively, in particular $(TARGET_DIRS). For goal "all", we do it the nice way: "all" has a prerequisite subdir-T for each T in $(TARGET_DIRS), and T's recipe runs make recursively. Behaves nicely with -j and -k. For other goals such as "clean" and "install", the

Re: [Qemu-devel] [PATCH v5 2/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-28 Thread Laurent Vivier
On 14/05/2019 18:27, Laurent Vivier wrote: Add a new RNG backend using QEMU builtin getrandom function. It can be created and used with something like: ... -object rng-builtin,id=rng0 -device virtio-rng,rng=rng0 ... Reviewed-by: Richard Henderson Reviewed-by: Markus Armbruster Signed-of

Re: [Qemu-devel] [PATCH 1/2] migration: Fix fd protocol for incoming defer

2019-05-28 Thread Juan Quintela
Yury Kotov wrote: > Currently, incoming migration through fd supports only command-line case: > E.g. > fork(); > fd = open(); > exec("qemu ... -incoming fd:%d", fd); > > It's possible to use add-fd commands to pass fd for migration, but it's > invalid case. add-fd works with fdset but

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread David Hildenbrand
On 24.05.19 21:45, Christian Borntraeger wrote: > > > On 24.05.19 21:00, David Hildenbrand wrote: >> On 24.05.19 20:36, David Hildenbrand wrote: >>> On 24.05.19 20:28, Christian Borntraeger wrote: On 24.05.19 20:04, David Hildenbrand wrote: > On 24.05.19 19:54, Philippe Mathieu

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread Cornelia Huck
On Tue, 28 May 2019 10:29:09 +0200 David Hildenbrand wrote: > On 24.05.19 21:45, Christian Borntraeger wrote: > > > > > > On 24.05.19 21:00, David Hildenbrand wrote: > >> On 24.05.19 20:36, David Hildenbrand wrote: > >>> On 24.05.19 20:28, Christian Borntraeger wrote: > > >

[Qemu-devel] [PATCH 0/2] block/io: refactor padding

2019-05-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is unifying of padding code in block/io.c, the main patch is 02. Vladimir Sementsov-Ogievskiy (2): util/iov: introduce qemu_iovec_init_extended block/io: refactor padding include/qemu/iov.h | 5 + block/io.c | 344 +++-- util/iov

[Qemu-devel] [PATCH 1/2] util/iov: introduce qemu_iovec_init_extended

2019-05-28 Thread Vladimir Sementsov-Ogievskiy
Introduce new initialization API, to create requests with padding. Will be used in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/iov.h | 5 +++ util/iov.c | 89 ++ 2 files changed, 94 insertions(+) diff --g

[Qemu-devel] [PATCH 2/2] block/io: refactor padding

2019-05-28 Thread Vladimir Sementsov-Ogievskiy
We have similar padding code in bdrv_co_pwritev, bdrv_co_do_pwrite_zeroes and bdrv_co_preadv. Let's combine and unify it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 344 - 1 file changed, 179 insertions(+), 165 deletions(-) d

Re: [Qemu-devel] [PATCH v3 0/7] Kconfig dependencies for MIPS machines (but Malta)

2019-05-28 Thread Aleksandar Markovic
On May 28, 2019 8:49 AM, "Philippe Mathieu-Daudé" wrote: > > > On 5/27/19 8:31 PM, Aleksandar Markovic wrote: > > > What would be the status of this series? I am willing to integrate all > > > this, including all followups, but have hard time sorting out what > > > happend after this submission, w

Re: [Qemu-devel] [PATCH v3 1/2] vfio/mdev: add migration_version attribute for mdev device

2019-05-28 Thread Cornelia Huck
On Sun, 26 May 2019 23:43:42 -0400 Yan Zhao wrote: > migration_version attribute is used to check migration compatibility > between two mdev device of the same mdev type. s/device/devices/ > The key is that it's rw and its data is opaque to userspace. > > Userspace reads migration_version of m

Re: [Qemu-devel] [PATCH v3 2/2] drm/i915/gvt: export migration_version to mdev sysfs for Intel vGPU

2019-05-28 Thread Cornelia Huck
On Sun, 26 May 2019 23:44:37 -0400 Yan Zhao wrote: > This feature implements the migration_version attribute for Intel's vGPU > mdev devices. > > migration_version attribute is rw. > It's used to check migration compatibility for two mdev devices of the > same mdev type. > migration_version stri

[Qemu-devel] [PATCH v2 1/2] migration: Fix fd protocol for incoming defer

2019-05-28 Thread Yury Kotov
Currently, incoming migration through fd supports only command-line case: E.g. fork(); fd = open(); exec("qemu ... -incoming fd:%d", fd); It's possible to use add-fd commands to pass fd for migration, but it's invalid case. add-fd works with fdset but not with particular fds. To work

[Qemu-devel] [PATCH v2 2/2] migration-test: Add a test for fd protocol

2019-05-28 Thread Yury Kotov
Signed-off-by: Yury Kotov --- tests/libqtest.c | 80 ++-- tests/libqtest.h | 51 - tests/migration-test.c | 101 + 3 files changed, 227 insertions(+), 5 deletions(-) diff --git a/tests/libqtest.

[Qemu-devel] [PATCH v2 0/2] Deferred incoming migration through fd

2019-05-28 Thread Yury Kotov
Hi, V2: * Revert odd changes in migrate() * Add short description for socket_send_fds() and remove ifdef WIN32 as it's not needed This series is a continuation of the previous two: * migration: Fix handling fd protocol * Add 'inline-fd:' protocol for migration It's about such use case: 1. Targ

Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn

2019-05-28 Thread Philippe Mathieu-Daudé
On 5/28/19 10:33 AM, Cornelia Huck wrote: > On Tue, 28 May 2019 10:29:09 +0200 > David Hildenbrand wrote: > >> On 24.05.19 21:45, Christian Borntraeger wrote: >>> >>> >>> On 24.05.19 21:00, David Hildenbrand wrote: On 24.05.19 20:36, David Hildenbrand wrote: > On 24.05.19 20:28, Chri

Re: [Qemu-devel] [PATCH v2 04/28] semihosting: enable chardev backed output for console

2019-05-28 Thread Alex Bennée
Richard Henderson writes: > On 5/23/19 6:25 AM, Alex Bennée wrote: >> int qemu_semihosting_log_out(const char *s, int len) >> { >> -return write(STDERR_FILENO, s, len); >> +Chardev *chardev = semihosting_get_chardev(); >> +if (chardev) { >> +return qemu_chr_write_all(chard

[Qemu-devel] [PULL 05/28] target/arm: fixup some of the commentary for arm-semi

2019-05-28 Thread Alex Bennée
This cleans up a number of the block comments to fit the proper style. While we are at it we also reference the official specification and document what the return register value can be. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/target/arm/arm-semi.c b/target/a

[Qemu-devel] [PULL 02/28] semihosting: introduce CONFIG_SEMIHOSTING

2019-05-28 Thread Alex Bennée
There isn't much point building semihosting for platforms that don't support it. Introduce a new symbol and enable it only for the softmmu targets that need it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson diff

[Qemu-devel] [PULL 00/28] testing/next (system tests, docker, iotests)

2019-05-28 Thread Alex Bennée
The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging (2019-05-24 12:47:49 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-te

[Qemu-devel] [PULL 07/28] target/arm: add LOG_UNIMP messages to arm-semi

2019-05-28 Thread Alex Bennée
Clean-up our unimplemented bits with a proper message. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson diff --git a/target/arm/arm-semi.c b/target/arm/arm-semi.c index 384b01124e1..86e6ec48c2f 100644 --- a/target/arm/arm-semi.c +++ b/target/arm/arm

[Qemu-devel] [PULL 01/28] semihosting: move semihosting configuration into its own directory

2019-05-28 Thread Alex Bennée
In preparation for having some more common semihosting code let's excise the current config magic from vl.c into its own file. We shall later add more conditionals to the build configurations so we can avoid building this if we don't need it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathi

[Qemu-devel] [PULL 03/28] semihosting: implement a semihosting console

2019-05-28 Thread Alex Bennée
This provides two functions for handling console output that handle the common backend behaviour for semihosting. Signed-off-by: Alex Bennée diff --git a/hw/semihosting/Makefile.objs b/hw/semihosting/Makefile.objs index 09c19bf19ed..4ad47c05c06 100644 --- a/hw/semihosting/Makefile.objs +++ b/hw/

[Qemu-devel] [PULL 04/28] semihosting: enable chardev backed output for console

2019-05-28 Thread Alex Bennée
It will be useful for a number of use-cases to be able to re-direct output to a file like we do with serial output. This does the wiring to allow us to treat then semihosting console like just another character output device. Signed-off-by: Alex Bennée diff --git a/hw/semihosting/config.c b/hw/s

[Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

2019-05-28 Thread Alex Bennée
Now we have a common semihosting console interface use that for our string output. However ARM is currently unique in also supporting semihosting for linux-user so we need to replicate the API in linux-user. If other architectures gain this support we can move the file later. Signed-off-by: Alex B

[Qemu-devel] [PULL 13/28] tests/docker: Test more components on the Fedora default image

2019-05-28 Thread Alex Bennée
From: Philippe Mathieu-Daudé Install optional dependencies of QEMU to get better coverage. The following components are now enabled: $ ./configure ... Multipath support yes VNC SASL support yes RDMA support yes PVRDMA supportyes libiscsi support yes seccomp support

[Qemu-devel] [PULL 08/28] target/arm: correct return values for WRITE/READ in arm-semi

2019-05-28 Thread Alex Bennée
The documentation says the write should return the number of bytes not written on an error (0 means everything was written). Read provides a buffer length and the return value should be the buffer length - bytes actually read. Remove the incorrect FIXME's and return the correct values. Signed-off-

[Qemu-devel] [PULL 10/28] target/mips: convert UHI_plog to use common semihosting code

2019-05-28 Thread Alex Bennée
Rather than printing directly to stdout lets use our common semihosting code. There is one minor difference in that the output currently defaults to stderr instead of stdout however this can be controlled by connecting semihosting to a chardev. Signed-off-by: Alex Bennée Reviewed-by: Aleksandar M

[Qemu-devel] [PULL 17/28] tests/tcg/aarch64: add system boot.S

2019-05-28 Thread Alex Bennée
This provides the bootstrap and low level helper functions for an aarch64 kernel. We use semihosting to handle test output and exiting the emulation. semihosting's parameter passing is a little funky so we end up using the stack and pointing to that as the parameter block. Signed-off-by: Alex Benn

[Qemu-devel] [PULL 09/28] target/mips: only build mips-semi for softmmu

2019-05-28 Thread Alex Bennée
The is_uhi gates all semihosting calls and always returns false for CONFIG_USER_ONLY builds. There is no reason to build and link mips-semi for these builds so lets fix that. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Hen

[Qemu-devel] [PULL 24/28] Makefile: include per-target build directories in coverage report

2019-05-28 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/Makefile b/Makefile index 73370874841..f0be624f471 100644 --- a/Makefile +++ b/Makefile @@ -1009,7 +1009,9 @@ $(filter %.1 %.7 %.8,$(DOCS)): scripts/texi2pod.pl %/coverage-report.html: @mkdir -p $* $(call qui

[Qemu-devel] [PULL 11/28] MAINTAINERS: update for semihostings new home

2019-05-28 Thread Alex Bennée
Seeing as I touched it I should at least keep an eye on it. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson diff --git a/MAINTAINERS b/MAINTAINERS index 3cacd751bf3..cc1178fe692 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2562,6 +2562,13 @@ F: d

[Qemu-devel] [PULL 18/28] tests/tcg/multiarch: move the system memory test

2019-05-28 Thread Alex Bennée
There is nothing inherently architecture specific about the memory test although we may have to manage different restrictions of unaligned access across architectures. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/tcg/i386/system/memory.c b/tests/tcg/multiarch/sy

[Qemu-devel] [PULL 12/28] tests/docker: add ubuntu 18.04

2019-05-28 Thread Alex Bennée
From: Gerd Hoffmann Based on the ubuntu.docker file. Used to reproduce the build failure Peter was seeing. Others might find this useful too ;) Signed-off-by: Gerd Hoffmann Message-Id: <20190503070241.24786-1-kra...@redhat.com> Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé Revi

[Qemu-devel] [PULL 14/28] tests/tcg/multiarch: add support for multiarch system tests

2019-05-28 Thread Alex Bennée
We can certainly support some common tests for system emulation that make use of our minimal defined boot.S support. It will still be up to individual architectures to ensure they build so we provide a MULTIARCH_TESTS variable that they can tack onto TESTS themselves. Signed-off-by: Alex Bennée R

[Qemu-devel] [PULL 15/28] tests/tcg/multiarch: add hello world system test

2019-05-28 Thread Alex Bennée
This is not really i386 only, we can have the same test for all architectures supporting system tests. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/tcg/i386/Makefile.softmmu-target b/tests/tcg/i386/Makefile.softmmu-target index 53c9c5ece06..c31bbbf39a7 100644 --

[Qemu-devel] [PULL 22/28] .travis.yml: enable aarch64-softmmu and alpha-softmmu tcg tests

2019-05-28 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/.travis.yml b/.travis.yml index 6fd89b3d915..b053a836a32 100644 --- a/.travis.yml +++ b/.travis.yml @@ -284,5 +284,5 @@ matrix: # Run check-tcg against softmmu targets - env: -- CONFIG="--target-list=xtens

[Qemu-devel] [PULL 28/28] tests: Run the iotests during "make check" again

2019-05-28 Thread Alex Bennée
From: Thomas Huth People often forget to run the iotests before submitting patches or pull requests - this is likely due to the fact that we do not run the tests during our mandatory "make check" tests yet. Now that we've got a proper "auto" group of iotests that should be fine to run in every en

[Qemu-devel] [PULL 25/28] Makefile.target: support per-target coverage reports

2019-05-28 Thread Alex Bennée
Add support for generating a single targets coverage report. Execute: make coverage-report In the target build directory. This coverage report only cares about target specific blobs so only searches the target build subdirectory. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson dif

[Qemu-devel] [PULL 16/28] editorconfig: add settings for .s/.S files

2019-05-28 Thread Alex Bennée
We are starting to add assembler foe tests/tcg so lets make sure we get the mode right. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/.editorconfig b/.editorconfig index 15828833938..df6db65531d 100644 --- a/.editorconfig +++ b/.editorconfig @@ -26,6 +26,11 @@ file_type

[Qemu-devel] [PULL 27/28] tests/qemu-iotests: re-format output to for make check-block

2019-05-28 Thread Alex Bennée
This attempts to clean-up the output to better match the output of the rest of the QEMU check system when called with -makecheck. This includes: - formatting as " TESTiotest-FMT: nnn" - only dumping config on failure (when -makecheck enabled) The non-make check output has been cleaned up

[Qemu-devel] [PULL 19/28] tests/tcg/minilib: support %c format char

2019-05-28 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/tests/tcg/minilib/printf.c b/tests/tcg/minilib/printf.c index 121620cb162..10472b4f585 100644 --- a/tests/tcg/minilib/printf.c +++ b/tests/tcg/minilib/printf.c @@ -119,6 +119,9 @@ void ml_printf(const char *fmt, ...)

[Qemu-devel] [PULL 21/28] tests/tcg/alpha: add system boot.S

2019-05-28 Thread Alex Bennée
From: Richard Henderson This provides the bootstrap and low level helper functions for an alpha kernel. We use direct access to the DP264 serial port for test output, and hard machine halt to exit the emulation. Signed-off-by: Richard Henderson Message-Id: <20190501184306.15208-1-richard.hende

[Qemu-devel] [PULL 23/28] Makefile: fix coverage-report reference to BUILD_DIR

2019-05-28 Thread Alex Bennée
Commit 337f2311f actually claimed to do this in the commit log but didn't actually. Oops. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson diff --git a/Makefile b/Makefile index e02b88bcb11..73370874841 100644 --- a/Makefile +++ b/Makefile @@ -1009,7 +1009,7 @@ $(filter %.1 %.7 %.8,$(D

[Qemu-devel] [PULL 20/28] tests/tcg/multiarch: expand system memory test to cover more

2019-05-28 Thread Alex Bennée
Expand the memory test to cover move of the softmmu code. Specifically we: - improve commentary - add some helpers (for later BE support) - reduce boiler plate into helpers - add signed reads at various sizes/offsets - required -DCHECK_UNALIGNED Signed-off-by: Alex Bennée Reviewed-by:

[Qemu-devel] [PULL 26/28] tests/qemu-iotests/group: Re-use the "auto" group for tests that can always run

2019-05-28 Thread Alex Bennée
From: Thomas Huth Currently, all tests are in the "auto" group. This is a little bit pointless. OTOH, we need a group for the tests that we can automatically run during "make check" each time, too. Tests in this new group are supposed to run with every possible QEMU configuration, for example the

Re: [Qemu-devel] [PULL 00/17] Machine Core queue, 2019-05-24

2019-05-28 Thread Peter Maydell
On Fri, 24 May 2019 at 19:44, Eduardo Habkost wrote: > > The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging > (2019-05-24 12:47:49 +0100) > > are available in the Gi

Re: [Qemu-devel] [PULL] RISC-V Patches for the 4.1 Soft Freeze, Part 1

2019-05-28 Thread Peter Maydell
On Sun, 26 May 2019 at 02:10, Palmer Dabbelt wrote: > > The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging > (2019-05-24 12:47:49 +0100) > > are available in the Git

[Qemu-devel] [Bug 1829242] Re: qemu on windows host exits after savevm command

2019-05-28 Thread Dr. David Alan Gilbert
Hi Alex, I'm not sure we've tried a savevm on a windows host; I don't have one easily available. When you say 'after a few seconds qemu exits' - does it give any errors or crash or anything? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [Bug 1829242] Re: qemu on windows host exits after savevm command

2019-05-28 Thread Dr. David Alan Gilbert
Hi Alex, I'm not sure we've tried a savevm on a windows host; I don't have one easily available. When you say 'after a few seconds qemu exits' - does it give any errors or crash or anything? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

2019-05-28 Thread Max Reitz
On 28.05.19 09:57, Sam Eiderman wrote: > Comments inline > >> On 27 May 2019, at 20:39, Max Reitz > > wrote: >> >> On 24.04.19 09:49, Sam Eiderman wrote: [...] >>> @@ -498,10 +543,15 @@ static int vmdk_init_tables(BlockDriverState >>> *bs, VmdkExtent *extent, >>>   

Re: [Qemu-devel] [PATCH] hw/i386/pc: check apci hotplug capability before nvdimm's

2019-05-28 Thread Igor Mammedov
On Tue, 28 May 2019 09:35:48 +0800 Wei Yang wrote: > On Mon, May 27, 2019 at 02:21:14PM +0200, Igor Mammedov wrote: > >On Thu, 11 Apr 2019 15:17:39 +0800 > >Wei Yang wrote: > > > >> pc_memory_pre_plug() is called during hotplug for both pc-dimm and > >> nvdimm. This is more proper to check apc

Re: [Qemu-devel] [PULL 00/12] MIPS queue for May 19th, 2019 - v3

2019-05-28 Thread Peter Maydell
On Sun, 26 May 2019 at 17:19, Aleksandar Markovic wrote: > > From: Aleksandar Markovic > > The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging > (2019-05-24 12:47:49

[Qemu-devel] [Bug 1101210] Re: qemu 1.4.2: usb keyboard not fully working

2019-05-28 Thread Roland Christmann
With a freshly compiled version of qemu 4.0.50 on Widows 10 (host) I am using 3 different Belgian keyboards and I have the same behaviour - 2 USB keyboards (Logitech and HP) and - the keyboard of my laptop (HP) 3 characters on the same key cannot be used (the key seams to be dead): < (less than),

Re: [Qemu-devel] [PATCH v2 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-28 Thread Richard Henderson
On 5/24/19 4:33 AM, David Hildenbrand wrote: > Complicated stuff. Provide two different helpers for CC an !CC handling. > We might want to add more helpers later. > > zero_search() and match_index() are courtesy of Richard H. > > Signed-off-by: David Hildenbrand > --- > target/s390x/Makefile.ob

Re: [Qemu-devel] [RFC v4 08/27] hw/vfio/common: Force nested if iommu requires it

2019-05-28 Thread Auger Eric
Hi Peter, On 5/28/19 4:47 AM, Peter Xu wrote: > On Mon, May 27, 2019 at 01:41:44PM +0200, Eric Auger wrote: >> In case we detect the address space is translated by >> a virtual IOMMU which requires nested stages, let's set up >> the container with the VFIO_TYPE1_NESTING_IOMMU iommu_type. >> >> Sig

Re: [Qemu-devel] [PATCH v2 2/5] s390x/tcg: Implement VECTOR FIND ELEMENT EQUAL

2019-05-28 Thread Richard Henderson
On 5/24/19 4:33 AM, David Hildenbrand wrote: > Core logic courtesy of Richard H. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h| 6 > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c | 31 + > target/s390x/vec_stri

Re: [Qemu-devel] [PATCH v2 3/5] s390x/tcg: Implement VECTOR FIND ELEMENT NOT EQUAL

2019-05-28 Thread Richard Henderson
On 5/24/19 4:33 AM, David Hildenbrand wrote: > +/* identify the smaller element */ > +if (first_inequal < 16) { > +uint8_t enr = first_inequal / (1 << es); > +uint32_t a = s390_vec_read_element(v2, enr, es); > +uint32_t b = s390_vec_read_element(v3, enr, es); > + > +

Re: [Qemu-devel] [PATCH v2 4/5] s390x/tcg: Implement VECTOR ISOLATE STRING

2019-05-28 Thread Richard Henderson
On 5/24/19 4:33 AM, David Hildenbrand wrote: > Logic mostly courtesy of Richard H. > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h| 6 + > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c | 34 > target/s390

Re: [Qemu-devel] [PATCH v2 5/5] s390x/tcg: Implement VECTOR STRING RANGE COMPARE

2019-05-28 Thread Richard Henderson
On 5/24/19 4:33 AM, David Hildenbrand wrote: > Unfortunately, there is no easy way to avoid looping over all elements > in v2. Provide specialized variants for !cc,!rt/!cc,rt/cc,!rt/cc,rt and > all element types. Especially for different values of rt, the compiler > might be able to optimize the co

Re: [Qemu-devel] [PATCH 0/6] target/rx: Improvements to disassembly

2019-05-28 Thread Yoshinori Sato
On Tue, 28 May 2019 02:47:40 +0900, Aleksandar Markovic wrote: > > On May 27, 2019 5:44 PM, "Yoshinori Sato" > wrote: > > > > On Fri, 24 May 2019 00:07:57 +0900, > > Richard Henderson wrote: > > > > > > Here's a sample of the new output, taken from u-boot.bin: > > > > > > IN: > > > 0xfff8000a: f

Re: [Qemu-devel] [PATCH v2 3/5] s390x/tcg: Implement VECTOR FIND ELEMENT NOT EQUAL

2019-05-28 Thread David Hildenbrand
On 28.05.19 14:55, Richard Henderson wrote: > On 5/24/19 4:33 AM, David Hildenbrand wrote: >> +/* identify the smaller element */ >> +if (first_inequal < 16) { >> +uint8_t enr = first_inequal / (1 << es); >> +uint32_t a = s390_vec_read_element(v2, enr, es); >> +uint3

Re: [Qemu-devel] [PATCH v2 3/5] s390x/tcg: Implement VECTOR FIND ELEMENT NOT EQUAL

2019-05-28 Thread Richard Henderson
On 5/28/19 8:02 AM, David Hildenbrand wrote: > On 28.05.19 14:55, Richard Henderson wrote: >> On 5/24/19 4:33 AM, David Hildenbrand wrote: >>> +/* identify the smaller element */ >>> +if (first_inequal < 16) { >>> +uint8_t enr = first_inequal / (1 << es); >>> +uint32_t a = s

Re: [Qemu-devel] [PATCH v2 3/5] s390x/tcg: Implement VECTOR FIND ELEMENT NOT EQUAL

2019-05-28 Thread David Hildenbrand
On 28.05.19 15:03, Richard Henderson wrote: > On 5/28/19 8:02 AM, David Hildenbrand wrote: >> On 28.05.19 14:55, Richard Henderson wrote: >>> On 5/24/19 4:33 AM, David Hildenbrand wrote: +/* identify the smaller element */ +if (first_inequal < 16) { +uint8_t enr = fir

Re: [Qemu-devel] [PATCH v3 4/6] numa: introduce "numa-mem-supported" machine property

2019-05-28 Thread Igor Mammedov
On Mon, 27 May 2019 20:38:57 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > '-numa mem' option has a number of issues and mgmt often defaults > > to it. Unfortunately it's no possible to replace it with an alternative > > '-numa memdev' without breaking migration compatibility.

Re: [Qemu-devel] [PULL 00/28] testing/next (system tests, docker, iotests)

2019-05-28 Thread Peter Maydell
On Tue, 28 May 2019 at 10:49, Alex Bennée wrote: > > The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging > (2019-05-24 12:47:49 +0100) > > are available in the Git re

Re: [Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

2019-05-28 Thread Eduardo Habkost
On Mon, May 27, 2019 at 03:52:30PM +0200, Laurent Vivier wrote: > On 27/05/2019 14:50, Igor Mammedov wrote: > > On Mon, 27 May 2019 08:55:49 +0200 > > Laurent Vivier wrote: > > > >> On 24/05/2019 22:14, Eduardo Habkost wrote: > >>> On Fri, May 24, 2019 at 04:39:12PM +0200, Laurent Vivier wrote: >

Re: [Qemu-devel] [PULL 00/28] testing/next (system tests, docker, iotests)

2019-05-28 Thread Alex Bennée
Peter Maydell writes: > On Tue, 28 May 2019 at 10:49, Alex Bennée wrote: >> >> The following changes since commit a7b21f6762a2d6ec08106d8a7ccb11829914523f: >> >> Merge remote-tracking branch >> 'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging >> (2019-05-24 12:47:49 +010

Re: [Qemu-devel] [PATCH v3 1/6] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()

2019-05-28 Thread Igor Mammedov
On Mon, 27 May 2019 18:36:25 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > QEMU will crash when device-memory-region-size property is read if > > ms->device_memory > > wasn't initialized yet (ex: property being inspected during preconfig > > time). > > Reproduced: > > $

[Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI

2019-05-28 Thread Philippe Mathieu-Daudé
This started to fail 6 months ago [1] and lately occurs too often on the main Travis CI. Travis CI set the CONTINUOUS_INTEGRATION variable in the process environment [2]. Let's use it to disable it when running this test there. [1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430 [2] https

Re: [Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

2019-05-28 Thread Laurent Vivier
On 28/05/2019 15:44, Eduardo Habkost wrote: On Mon, May 27, 2019 at 03:52:30PM +0200, Laurent Vivier wrote: On 27/05/2019 14:50, Igor Mammedov wrote: On Mon, 27 May 2019 08:55:49 +0200 Laurent Vivier wrote: On 24/05/2019 22:14, Eduardo Habkost wrote: On Fri, May 24, 2019 at 04:39:12PM +0200

Re: [Qemu-devel] [PATCH v3] numa: improve cpu hotplug error message with a wrong node-id

2019-05-28 Thread Igor Mammedov
On Mon, 27 May 2019 15:52:30 +0200 Laurent Vivier wrote: > On 27/05/2019 14:50, Igor Mammedov wrote: > > On Mon, 27 May 2019 08:55:49 +0200 > > Laurent Vivier wrote: > > > >> On 24/05/2019 22:14, Eduardo Habkost wrote: > >>> On Fri, May 24, 2019 at 04:39:12PM +0200, Laurent Vivier wrote:

Re: [Qemu-devel] [PULL 00/28] testing/next (system tests, docker, iotests)

2019-05-28 Thread Peter Maydell
On Tue, 28 May 2019 at 14:47, Alex Bennée wrote: > Sounds like we should include the sanitizer build in our normal setup. > We currently only do: > > ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread > -fuse-ld=gold" > > with gcc-7. What are the clang configure runes you are usin

[Qemu-devel] [PATCH] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly

2019-05-28 Thread Philippe Mathieu-Daudé
Since the BusState is accesible from the SCSIBus object, it is pointless to use qbus_reset_all_fn. Use qbus_reset_all() directly. Signed-off-by: Philippe Mathieu-Daudé --- One step toward removing qbus_reset_all_fn() --- hw/scsi/vmw_pvscsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [Qemu-devel] [PATCH] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly

2019-05-28 Thread Peter Maydell
On Tue, 28 May 2019 at 15:08, Philippe Mathieu-Daudé wrote: > > Since the BusState is accesible from the SCSIBus object, > it is pointless to use qbus_reset_all_fn. > Use qbus_reset_all() directly. > > Signed-off-by: Philippe Mathieu-Daudé > --- > One step toward removing qbus_reset_all_fn() > --

[Qemu-devel] [PATCH v0 1/3] qcow2: introduce compression type feature

2019-05-28 Thread Denis Plotnikov
The patch adds some preparation parts for incompatible compression type feature to QCOW2 header that indicates that *all* compressed clusters must be (de)compressed using a certain compression type. It is implied that the compression type is set on the image creation and can be changed only later

[Qemu-devel] [PATCH v0 3/3] qcow2: add zstd cluster compression

2019-05-28 Thread Denis Plotnikov
zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of compression ratio in comparison with zlib, which, by the moment, has been the only compression method available. The performance test results: Test compresses and decompres

[Qemu-devel] [PATCH v0 0/3] add zstd cluster compression

2019-05-28 Thread Denis Plotnikov
The goal of the patch-set is to enable qcow2 to use zstd compression for clusters. ZSTD provides better (de)compression performance than currently used ZLIB. Using it will improve perforamnce (reduce compression time) when the compressed clusters is used, e.g backup scenarios. Also, the patch-set

[Qemu-devel] [PATCH v0 2/3] qcow2: add compression type processing

2019-05-28 Thread Denis Plotnikov
With the patch, qcow2 is able to process image compression type defined in the image header and choose the corresponding method for clusters compressing. Also, it rework the cluster compression code for adding more compression types. Signed-off-by: Denis Plotnikov --- block/qcow2.c | 103 ++

[Qemu-devel] [Bug 1829242] Re: qemu on windows host exits after savevm command

2019-05-28 Thread Alex
Hi, No, no messages, no crash window which appears when windows catches unhandled exceptions in software. Looks as if there was an asynchronous command to exit during savevm which executed in parallel to the command. -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI

2019-05-28 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > This started to fail 6 months ago [1] and lately occurs too > often on the main Travis CI. > > Travis CI set the CONTINUOUS_INTEGRATION variable in the process > environment [2]. Let's use it to disable it when running this test > there. > > [

Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI

2019-05-28 Thread Laurent Vivier
On 28/05/2019 16:42, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@redhat.com) wrote: This started to fail 6 months ago [1] and lately occurs too often on the main Travis CI. Travis CI set the CONTINUOUS_INTEGRATION variable in the process environment [2]. Let's use it to disab

[Qemu-devel] [Bug 1829242] Re: qemu on windows host exits after savevm command

2019-05-28 Thread Dr. David Alan Gilbert
I think you'll have to break out a debugger on it to see why it's exiting; if you can break on any exit paths and get a backtrace we can have some more guesswork. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

Re: [Qemu-devel] [PULL 00/28] testing/next (system tests, docker, iotests)

2019-05-28 Thread Alex Bennée
Peter Maydell writes: > On Tue, 28 May 2019 at 14:47, Alex Bennée wrote: >> Sounds like we should include the sanitizer build in our normal setup. >> We currently only do: >> >> ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread >> -fuse-ld=gold" >> >> with gcc-7. What are the

[Qemu-devel] [Bug 1829242] Re: qemu on windows host exits after savevm command

2019-05-28 Thread Alex
To do this I must crosscompile qemu on a linux host and debug on a windows host. Is there a gdb for 64-bit windows, since windows debuggers don't understand DWARF debugging info, and is it possible to give him paths to source files, since paths on the build machine and the debugging machine will be

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-05-28 Thread Elena Ufimtseva
On Thu, May 23, 2019 at 12:11:30PM +0100, Stefan Hajnoczi wrote: > Hi Jag and Elena, > Do you think a call would help to move discussion along more quickly? > Hi Stefan, We would like to join this call. And thank you inviting us! Elena > We could use the next KVM Community Call on June 4th to di

[Qemu-devel] [PATCH] pr-manager-helper: fix pr process been killed when reconectting

2019-05-28 Thread Jie Wang
if pr-helper been killed and qemu send disconnect event to libvirt and libvirt started a new pr-helper process, the new pr-heleper been killed again when qemu is connectting to the new pr-helper, qemu will never send disconnect to libvirt, and libvirt will never receive connected event. Signed-off

  1   2   3   >