[Qemu-devel] [Bug 1829964] Re: HOST VRAM Leak when performs android-x86 window rotation with Virt-GPU

2019-05-22 Thread Thomas Huth
Ok, sorry, got that wrong - we sometimes get bug reports about the android emulator (which is a fork of QEMU) here, and at a first glance, your bug report looked like one of these misguided bug tickets, too. Anyway, please provide some more information: Which version of QEMU are you using? Which o

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/9] target/ppc: Fix lxvw4x, lxvh8x and lxvb16x

2019-05-22 Thread Greg Kurz
On Wed, 22 May 2019 06:11:12 +1000 Anton Blanchard wrote: > Hi, > > > I've now had a bit of time to look through this and I believe it is > > correct, so: > > > > Reviewed-by: Mark Cave-Ayland > > Thanks Mark. David: any chance we could get this merged? I can't run a > recent Ubuntu image s

[Qemu-devel] [PATCH 1/2] spapr/xive: fix multiple resets when using the 'dual' interrupt mode

2019-05-22 Thread Cédric Le Goater
Today, when a reset occurs on a pseries machine using the 'dual' interrupt mode, the KVM devices are released and recreated depending on the interrupt mode selected by CAS. If XIVE is selected, the SysBus memory regions of the SpaprXive model are initialized by the KVM backend initialization routin

[Qemu-devel] [PATCH 0/2] spapr/xive: change default interrupt mode to 'dual'

2019-05-22 Thread Cédric Le Goater
Hello, Here is a little series fixing multiple resets when in 'dual' interrupt mode and changing the default mode to 'dual'. Thanks, C. Cédric Le Goater (2): spapr/xive: fix multiple resets when using the 'dual' interrupt mode spapr: change default interrupt mode to 'dual' hw/intc/spapr_x

[Qemu-devel] [PATCH 2/2] spapr: change default interrupt mode to 'dual'

2019-05-22 Thread Cédric Le Goater
Now that XIVE support is complete (QEMU emulated and KVM devices), change the pseries machine to advertise both interrupt modes: XICS (P7/P8) and XIVE (P9). The machine default interrupt modes depends on the version. Current settings are: pseries default interrupt mode 4.1 dual

[Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2019-05-22 Thread Thomas Huth
Looking through old bug tickets... can this issue still be reproduced with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [Qemu-devel] [PULL 21/38] spapr: Add forgotten capability to migration stream

2019-05-22 Thread Greg Kurz
On Wed, 22 May 2019 14:45:43 +1000 David Gibson wrote: > spapr machine capabilities are supposed to be sent in the migration stream > so that we can sanity check the source and destination have compatible > configuration. Unfortunately, when we added the hpt-max-page-size > capability, we forgot

Re: [Qemu-devel] Introducing GSoC project: API Documentation Generation

2019-05-22 Thread Paolo Bonzini
On 21/05/19 22:37, Eduardo Habkost wrote: >> But this is the one we're going with? Do we have a plan for teaching it >> not to panic for our use of named custom types? > > If I understood correctly, the patch from Paolo that I have > forwarded to this thread is all we need. Are there other issues

[Qemu-devel] [Bug 1829964] Re: HOST VRAM Leak when performs android-x86 window rotation with Virt-GPU

2019-05-22 Thread Eunseok Choi
I tested many qemu & linux versions in case of qemu, 2.12 3.10 3.12 4.0.0 All versions I tested have same problem also I tested many versions of linux ubuntu 18.04 18.10 centos 7 fedora 18 19 rhel Actually it is not only problem of windows rotation, if home launcher refreshed, vram usag

Re: [Qemu-devel] [PATCH v5 2/2] acpi: pci: use build_append_foo() API to construct MCFG

2019-05-22 Thread Igor Mammedov
On Tue, 21 May 2019 10:34:03 -0400 "Michael S. Tsirkin" wrote: > On Tue, May 21, 2019 at 04:29:58PM +0200, Igor Mammedov wrote: > > On Mon, 20 May 2019 23:37:22 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, May 21, 2019 at 11:32:49AM +0800, Wei Yang wrote: > > > > build_append_foo

[Qemu-devel] [PULL 2/3] libvhost-user: fix -Werror=format= on ppc64

2019-05-22 Thread Gerd Hoffmann
From: Marc-André Lureau That should fix the following warning: /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c: In function ‘vu_set_mem_table_exec_postcopy’: /home/pm215/qemu/contrib/libvhost-user/libvhost-user.c:666:9: error: format ‘%llx’ expects argument of type ‘long long unsigned int

[Qemu-devel] [PULL 1/3] libvhost-user: fix cast warnings on 32 bits

2019-05-22 Thread Gerd Hoffmann
From: Marc-André Lureau Fixes warnings: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190514104126.6294-2-marcandre.lur...@redhat.com Signed-off-by: Gerd Hoffmann --- contri

[Qemu-devel] [PULL 3/3] contrib: add vhost-user-input

2019-05-22 Thread Gerd Hoffmann
From: Marc-André Lureau Add a vhost-user input backend example, based on virtio-input-host device. It takes an evdev path as argument, and can be associated with a vhost-user-input device via a UNIX socket: $ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock $ qemu ... -chardev socket,id=v

Re: [Qemu-devel] [PATCH v4 0/3] hw: edu: some fixes

2019-05-22 Thread Paolo Bonzini
On 21/05/19 15:30, Li Qiang wrote: > Ping > > Paolo, could you merge these to your misc tree? Queued now, thanks. Paolo > Thanks, > Li Qiang > > Li Qiang mailto:liq...@163.com>> 于2019年5月11日周六 上 > 午12:44写道: > > Recently I am considering write a driver for edu device. > After readin

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-22 Thread Jiri Denemark
On Fri, May 10, 2019 at 17:32:03 -0300, Eduardo Habkost wrote: > On Thu, May 09, 2019 at 06:36:18PM +0200, Jiri Denemark wrote: > > On Thu, May 09, 2019 at 18:06:03 +0200, Igor Mammedov wrote: > > > On Thu, 9 May 2019 10:56:17 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Thu, May 09, 2019

[Qemu-devel] [PULL 0/3] Input 20190522 patches

2019-05-22 Thread Gerd Hoffmann
The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/input-20190522-pull-re

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] spapr/xive: fix multiple resets when using the 'dual' interrupt mode

2019-05-22 Thread Greg Kurz
On Wed, 22 May 2019 09:40:15 +0200 Cédric Le Goater wrote: > Today, when a reset occurs on a pseries machine using the 'dual' > interrupt mode, the KVM devices are released and recreated depending > on the interrupt mode selected by CAS. If XIVE is selected, the SysBus > memory regions of the Spa

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread Peter Maydell
On Tue, 21 May 2019 at 21:07, John Snow wrote: > > Sphinx, through Pygments, does not like annotated json examples very > much. In some versions of Sphinx (1.7), it will render the non-json > portions of code blocks in red, but in newer versions (2.0) it will > throw an exception and not highlight

Re: [Qemu-devel] Use of PreallocMode in block drivers

2019-05-22 Thread Stefano Garzarella
On Wed, May 8, 2019 at 1:44 PM Markus Armbruster wrote: > > Stefano Garzarella writes: > > > On Tue, May 07, 2019 at 08:34:51AM +0200, Markus Armbruster wrote: > >> Cc: Peter for a libvirt perspective. > >> > >> Stefano Garzarella writes: > >> > >> > This patch adds the support of preallocation

Re: [Qemu-devel] [PATCH 0/2] i386: "unavailable-features" QOM property

2019-05-22 Thread Jiri Denemark
On Fri, May 10, 2019 at 17:23:13 -0300, Eduardo Habkost wrote: > On Fri, May 10, 2019 at 01:33:03PM +0200, Jiri Denemark wrote: > > On Thu, May 09, 2019 at 13:08:25 -0300, Eduardo Habkost wrote: > > > On Thu, May 09, 2019 at 05:26:16PM +0200, Jiri Denemark wrote: > > > > On Thu, May 09, 2019 at 10:

[Qemu-devel] [PATCH] tests/vm: default to using a snapshot

2019-05-22 Thread Paolo Bonzini
This will allow running the tests in Patchew, which has two runners that might choose concurrently the same VM build for two different series. Signed-off-by: Paolo Bonzini --- tests/vm/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vm/Makefile.include

Re: [Qemu-devel] [Qemu-riscv] [PATCHv3 5/5] RISC-V: Fix a PMP check with the correct access size

2019-05-22 Thread Hesham Almatary
On Wed, 22 May 2019 at 03:25, Jonathan Behrens wrote: > > Hesham, > > I don't think this is quite right. If I understand correctly, PMP permissions > are only validated on TLB fills, not on all accesses. (Is anyone able to > confirm this?) If so, this function can't just validate the range of a

Re: [Qemu-devel] [PATCH] linux-user: Pass through nanosecond timestamp components for stat syscalls

2019-05-22 Thread Laurent Vivier
On 14/05/2019 16:53, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Since Linux 2.6 the stat syscalls have mostly supported nanosecond components for each of the file-related timestamps. QEMU user mode emulation currently does not pass through the nanosecond portion of the timestamp, even when the hos

Re: [Qemu-devel] [PATCH v6 1/2] hw/acpi: Consolidate build_mcfg to pci.c

2019-05-22 Thread Igor Mammedov
On Tue, 21 May 2019 14:28:35 +0800 Wei Yang wrote: > Now we have two identical build_mcfg functions. > > Consolidate them in acpi/pci.c. > > Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov > > v4: > * ACPI_PCI depends on both ACPI and PCI > * rebase on latest master, adjust arm Kcon

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] spapr/xive: fix multiple resets when using the 'dual' interrupt mode

2019-05-22 Thread Cédric Le Goater
On 5/22/19 10:52 AM, Greg Kurz wrote: > On Wed, 22 May 2019 09:40:15 +0200 > Cédric Le Goater wrote: > >> Today, when a reset occurs on a pseries machine using the 'dual' >> interrupt mode, the KVM devices are released and recreated depending >> on the interrupt mode selected by CAS. If XIVE is s

Re: [Qemu-devel] [PATCH v6 1/6] linux-user: Fix support for SIOCATMARK and SIOCGPGRP ioctls for xtensa

2019-05-22 Thread Laurent Vivier
On 19/05/2019 18:15, Aleksandar Markovic wrote: From: Aleksandar Markovic Fix support for the SIOCATMARK and SIOCGPGRP ioctls for xtensa by correcting corresponding macro definition. Values for TARGET_SIOCATMARK and TARGET_SIOCGPGRP are determined by Linux kernel. Following relevant lines (obt

[Qemu-devel] [PATCHv3 1/5] RISC-V: Only Check PMP if MMU translation succeeds

2019-05-22 Thread Hesham Almatary
The current implementation unnecessarily checks for PMP even if MMU translation failed. This may trigger a wrong PMP access exception instead of a page exception. For example, the very first instruction fetched after the first satp write in S-Mode will trigger a PMP access fault instead of an inst

[Qemu-devel] [PATCHv3 4/5] RISC-V: Fix a PMP bug where it succeeds even if PMP entry is off

2019-05-22 Thread Hesham Almatary
The current implementation returns 1 (PMP check success) if the address is in range even if the PMP entry is off. This is a bug. For example, if there is a PMP check in S-Mode which is in range, but its PMP entry is off, this will succeed, which it should not. The patch fixes this bug by only che

Re: [Qemu-devel] [PATCH v6 2/6] linux-user: Add support for SIOCSPGRP ioctl for all targets

2019-05-22 Thread Laurent Vivier
On 19/05/2019 18:15, Aleksandar Markovic wrote: From: Aleksandar Markovic Add support for setting the process (or process group) to receive SIGIO or SIGURG signals when I/O becomes possible or urgent data is available, using SIOCSPGRP ioctl. The ioctl numeric values for SIOCSPGRP are platform-

Re: [Qemu-devel] [PATCH v6 3/6] linux-user: Add support for SIOCIFPFLAGS ioctls for all targets

2019-05-22 Thread Laurent Vivier
On 19/05/2019 18:15, Aleksandar Markovic wrote: From: Neng Chen Add support for getting and setting extended private flags of a network device via SIOCSIFPFLAGS and SIOCGIFPFLAGS ioctls. The ioctl numeric values are platform-independent and determined by the file include/uapi/linux/sockios.h i

Re: [Qemu-devel] [PATCH v6 5/6] linux-user: Sanitize interp_info and, for mips only, init field fp_abi

2019-05-22 Thread Laurent Vivier
On 19/05/2019 18:15, Aleksandar Markovic wrote: From: Daniel Santos Sanitize interp_info structure in load_elf_binary() and, for MIPS only, init its field fp_abi to MIPS_ABI_FP_UNKNOWN. This fixes appearances of "Unexpected FPU mode" message in some MIPS use cases. Currently, this bug is a comp

Re: [Qemu-devel] [PATCH v6 4/6] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-05-22 Thread Laurent Vivier
On 19/05/2019 18:15, Aleksandar Markovic wrote: From: Neng Chen Add support for options IPV6_ADD_MEMBERSHIP and IPV6_DROP_MEMPEMBERSHIP of the syscall setsockopt(). These options control membership in multicast groups. Their argument is a pointer to a struct ipv6_mreq, which is in turn defined

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 1/9] qapi/block-core: add option for io_uring

2019-05-22 Thread Kevin Wolf
Am 22.05.2019 um 02:51 hat Aarushi Mehta geschrieben: > On Tue, 2019-05-21 at 19:39 -0500, Eric Blake wrote: > > On 5/21/19 6:52 PM, Aarushi Mehta wrote: > > > Signed-off-by: Aarushi Mehta > > > > Sparse on the details. The subject line says what, but without a > > 'why' > > for how io_uring is d

Re: [Qemu-devel] [PATCH v6 4/6] linux-user: Add support for setsockopt() options IPV6__MEMBERSHIP

2019-05-22 Thread Laurent Vivier
On 19/05/2019 18:15, Aleksandar Markovic wrote: From: Neng Chen Add support for options IPV6_ADD_MEMBERSHIP and IPV6_DROP_MEMPEMBERSHIP of the syscall setsockopt(). These options control membership in multicast groups. Their argument is a pointer to a struct ipv6_mreq, which is in turn defined

[Qemu-devel] [PATCH 1/5] usb-hub: tweak feature names

2019-05-22 Thread Gerd Hoffmann
Add dashes, so they don't look like two separate things when printed. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index 7e9339b8a83d..9b04b6a6ec2d 100644 --- a/hw/usb/dev-hub.

[Qemu-devel] [PATCH 3/5] usb-hub: add helpers to update port state

2019-05-22 Thread Gerd Hoffmann
Add usb_hub_port_set() and usb_hub_port_clear() helpers which care about updating the change bits (port->wPortChange) properly, so we don't need to have that logic sprinkled all over the place ;) Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 84 ++---

[Qemu-devel] [PATCH 4/5] usb-hub: add usb_hub_port_update()

2019-05-22 Thread Gerd Hoffmann
Helper function to update port status bits which depends on the connected device. We need the same logic for device attach and port reset, so factor it out. --- hw/usb/dev-hub.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/hw/usb/dev-hub.c b/

[Qemu-devel] [PATCH 2/5] usb-hub: make number of ports runtime-configurable

2019-05-22 Thread Gerd Hoffmann
Add num_ports property which allows configure the number of downstream ports. Valid range is 1-8, default is 8. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 45 + 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/hw/usb/dev-hub.c

[Qemu-devel] [PATCH 0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation.

2019-05-22 Thread Gerd Hoffmann
Gerd Hoffmann (5): usb-hub: tweak feature names usb-hub: make number of ports runtime-configurable usb-hub: add helpers to update port state usb-hub: add usb_hub_port_update() usb-hub: emulate per port power switching hw/usb/dev-hub.c | 221 +--

Re: [Qemu-devel] [PATCHv3 3/5] RISC-V: Check PMP during Page Table Walks

2019-05-22 Thread Hesham Almatary
On Tue, 21 May 2019 at 23:40, Alistair Francis wrote: > > On Tue, May 21, 2019 at 3:44 AM Hesham Almatary > wrote: > > > > The PMP should be checked when doing a page table walk, and report access > > fault exception if the to-be-read PTE failed the PMP check. > > > > Suggested-by: Jonathan Behre

[Qemu-devel] [PATCH 5/5] usb-hub: emulate per port power switching

2019-05-22 Thread Gerd Hoffmann
Add support for per port power switching. Virtual power of course ;) Use port-power=on property to enable this. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 63 1 file changed, 63 insertions(+) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-h

Re: [Qemu-devel] Running linux on qemu omap

2019-05-22 Thread Corentin Labbe
On Wed, May 22, 2019 at 02:23:23AM +0300, Aaro Koskinen wrote: > Hi, > > On Mon, May 20, 2019 at 09:05:33PM +0200, Corentin Labbe wrote: > > Hello > > > > I am working on adding a maximum set of qemu machine on kernelCI. > > That's cool. > > > For OMAP, five machine exists and I fail to boot an

Re: [Qemu-devel] [PATCH 12/13] linux-user: Fix shmat emulation by honoring host SHMLBA

2019-05-22 Thread Laurent Vivier
On 19/05/2019 22:19, Richard Henderson wrote: For those hosts with SHMLBA > getpagesize, we don't automatically select a guest address that is compatible with the host. We can achieve this by boosting the alignment of guest_base and by adding an extra alignment argument to mmap_find_vma. Signed

Re: [Qemu-devel] [PATCH 13/13] linux-user: Align mmap_find_vma to host page size

2019-05-22 Thread Laurent Vivier
On 19/05/2019 22:19, Richard Henderson wrote: This can avoid stack allocation failures for i386 guest on ppc64 (64k page) host. Suggested-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/mmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-user/mmap.c b/linux

Re: [Qemu-devel] [PATCH] linux-user: Pass through nanosecond timestamp components for stat syscalls

2019-05-22 Thread Chen-Yu Tsai
On Wed, May 22, 2019 at 5:08 PM Laurent Vivier wrote: > > On 14/05/2019 16:53, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Since Linux 2.6 the stat syscalls have mostly supported nanosecond > > components for each of the file-related timestamps. > > > > QEMU user mode emulation currently d

[Qemu-devel] [PATCH 1/3] usb: call reset handler before updating state

2019-05-22 Thread Gerd Hoffmann
That way the device reset handler can see what the before-reset state of the device is. Signed-off-by: Gerd Hoffmann --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c index 8fbd9c7d573b..3ab48a16074b 100644 --- a/hw/usb/core.c +++

[Qemu-devel] [PATCH 3/3] usb-host: avoid libusb_set_configuration calls

2019-05-22 Thread Gerd Hoffmann
Seems some devices become confused when we call libusb_set_configuration(). So before calling the function check whenever the device has multiple configurations in the first place, and in case it hasn't (which is the case for the majority of devices) simply skip the call as it will have no effect

[Qemu-devel] [PATCH 0/3] usb-host: some little tweaks to hopefully reduce usb pass-through problems.

2019-05-22 Thread Gerd Hoffmann
Gerd Hoffmann (3): usb: call reset handler before updating state usb-host: skip reset for untouched devices usb-host: avoid libusb_set_configuration calls hw/usb/core.c| 2 +- hw/usb/host-libusb.c | 21 + 2 files changed, 14 insertions(+), 9 deletions(-) --

[Qemu-devel] [PATCH 2/3] usb-host: skip reset for untouched devices

2019-05-22 Thread Gerd Hoffmann
If the guest didn't talk to the device yet, skip the reset. Without this usb-host devices get resetted a number of times at boot time for no good reason. Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/hos

[Qemu-devel] [PATCH 3/3] egl-helpers: add dmabuf modifier support.

2019-05-22 Thread Gerd Hoffmann
Add modifier parameter to egl_get_fd_for_texture(), to return the used modifier on dmabuf exports. Check and use QemuDmaBuf->modifier in egl_dmabuf_import_texture() for dmabuf imports. Signed-off-by: Gerd Hoffmann --- include/ui/egl-helpers.h | 3 ++- ui/egl-helpers.c | 37

[Qemu-devel] [PATCH 1/3] console: add dmabuf modifier field.

2019-05-22 Thread Gerd Hoffmann
dmabufs can have a format modifier (DRM_FORMAT_MOD_*) which is used for tiled layouts for example. Add a field to QemuDmaBuf so we can carry around that information. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/ui/console.h b/

[Qemu-devel] [PATCH 2/3] vfio/display: set dmabuf modifier field

2019-05-22 Thread Gerd Hoffmann
Fill the new QemuDmaBuf->modifier field properly from plane info. Signed-off-by: Gerd Hoffmann --- hw/vfio/display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index a3d9c8f5beac..13969180b2dd 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @

[Qemu-devel] [PATCH 0/3] add drm modifier support for dmabufs.

2019-05-22 Thread Gerd Hoffmann
Gerd Hoffmann (3): console: add dmabuf modifier field. vfio/display: set dmabuf modifier field egl-helpers: add dmabuf modifier support. include/ui/console.h | 1 + include/ui/egl-helpers.h | 3 ++- hw/vfio/display.c| 1 + ui/egl-helpers.c | 37

Re: [Qemu-devel] [Qemu-block] [PATCH 0/9] Assembly coroutine backend and x86 CET support

2019-05-22 Thread Paolo Bonzini
On 16/05/19 14:50, Peter Maydell wrote: > On Wed, 15 May 2019 at 10:48, Stefan Hajnoczi wrote: >> 1. It's required for Intel Control-flow Enforcement Technology (CET). >>The existing ucontext backend doesn't work with CET. >> 2. It's faster than the existing ucontext implementation. > > Mmm,

Re: [Qemu-devel] [PATCH 0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation.

2019-05-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190522092351.17920-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/5] usb-hub: cleanups, configurable port count, per-port power switching emulation. Ty

Re: [Qemu-devel] [PATCH v2] blockdev: fix missed target unref for drive-backup

2019-05-22 Thread Kevin Wolf
Am 13.05.2019 um 17:06 hat John Snow geschrieben: > If the bitmap can't be used for whatever reason, we skip putting down > the reference. Fix that. > > In practice, this means that if you attempt to gracefully exit QEMU > after a backup command being rejected, bdrv_close_all will fail and > tell

Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion

2019-05-22 Thread Cornelia Huck
On Tue, 21 May 2019 16:51:27 -0400 Farhan Ali wrote: > On 05/21/2019 12:32 PM, Cornelia Huck wrote: > > On Mon, 20 May 2019 12:29:56 -0400 > > Eric Farman wrote: > > > >> On 5/7/19 11:47 AM, Cornelia Huck wrote: > >>> A vfio-ccw device may provide an async command subregion for > >>> issuin

Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion

2019-05-22 Thread Cornelia Huck
On Tue, 21 May 2019 16:50:47 -0400 Farhan Ali wrote: > On 05/07/2019 11:47 AM, Cornelia Huck wrote: > > A vfio-ccw device may provide an async command subregion for > > issuing halt/clear subchannel requests. If it is present, use > > it for sending halt/clear request to the device; if not, fall

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] spapr: change default interrupt mode to 'dual'

2019-05-22 Thread Greg Kurz
On Wed, 22 May 2019 09:40:16 +0200 Cédric Le Goater wrote: > Now that XIVE support is complete (QEMU emulated and KVM devices), > change the pseries machine to advertise both interrupt modes: XICS > (P7/P8) and XIVE (P9). > > The machine default interrupt modes depends on the version. Current >

Re: [Qemu-devel] [PATCH] i386: Enable IA32_MISC_ENABLE MWAIT bit when exposing mwait/monitor

2019-05-22 Thread Paolo Bonzini
On 20/05/19 23:05, Eduardo Habkost wrote: > What if enable_cpu_pm is false but we're running TCG, or if > enable_cpu_pm is true but we're not using -cpu host? > > Shouldn't this be conditional on > (env->features[FEAT_1_ECX] & CPUID_EXT_MONITOR) > instead? Yes, it should. I fixed it locally.

Re: [Qemu-devel] [PATCH v2 2/2] block: avoid recursive block_status call if possible

2019-05-22 Thread Kevin Wolf
Am 08.04.2019 um 18:26 hat Vladimir Sementsov-Ogievskiy geschrieben: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where

Re: [Qemu-devel] [Qemu-block] [PATCH v2] [RFC] qcow2: add compression type feature

2019-05-22 Thread Alberto Garcia
On Mon 20 May 2019 08:20:23 AM CEST, Denis Plotnikov wrote: > +/* Compression type extension */ > +if (s->compression_type != 0) { > +Qcow2CompressionTypeExt comp_header = { > +.compression_type = cpu_to_be32(s->compression_type), > +}; Shouldn't we have an enum

Re: [Qemu-devel] [PATCH qemu-web] Add a blog post about micro:bit emulation

2019-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2019 at 10:48:21AM +0200, Thomas Huth wrote: > On 21/05/2019 10.20, Stefan Hajnoczi wrote: > > QEMU 4.0 ships the core micro:bit emulation that was implemented during > > Outreachy and GSoC 2018. This blog posts explains how to use it and > > describes the current status. > [...] >

[Qemu-devel] [PATCH v2] Add a blog post about micro:bit emulation

2019-05-22 Thread Stefan Hajnoczi
QEMU 4.0 ships the core micro:bit emulation that was implemented during Outreachy and GSoC 2018. This blog posts explains how to use it and describes the current status. Signed-off-by: Stefan Hajnoczi --- v2: * Used git format-patch --binary to include .png file contents [thuth] * s/runtime/ru

Re: [Qemu-devel] [PATCH 2/3] vfio/display: set dmabuf modifier field

2019-05-22 Thread Marc-André Lureau
On Wed, May 22, 2019 at 12:05 PM Gerd Hoffmann wrote: > > Fill the new QemuDmaBuf->modifier field properly from plane info. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau > --- > hw/vfio/display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio/display.c b/hw

Re: [Qemu-devel] [PATCH 1/3] console: add dmabuf modifier field.

2019-05-22 Thread Marc-André Lureau
On Wed, May 22, 2019 at 12:05 PM Gerd Hoffmann wrote: > > dmabufs can have a format modifier (DRM_FORMAT_MOD_*) which is used for > tiled layouts for example. Add a field to QemuDmaBuf so we can carry > around that information. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau >

Re: [Qemu-devel] [PATCH 3/3] egl-helpers: add dmabuf modifier support.

2019-05-22 Thread Marc-André Lureau
Hi On Wed, May 22, 2019 at 12:04 PM Gerd Hoffmann wrote: > > Add modifier parameter to egl_get_fd_for_texture(), to return the used > modifier on dmabuf exports. But nothing uses it yet? > > Check and use QemuDmaBuf->modifier in egl_dmabuf_import_texture() for > dmabuf imports. That could be a

Re: [Qemu-devel] [PATCH v2 for 4.1 0/2] avoid lseek on block_status

2019-05-22 Thread Kevin Wolf
Am 08.04.2019 um 18:26 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi! > > It's a continuation for > "[PATCH] qcow2: avoid lseek on block_status if possible" > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06598.html > > performance results for block-status on tmpfs [tests original

Re: [Qemu-devel] [RFC] scsi: restart dma after vm change state handlers

2019-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2019 at 01:30:59PM +0200, Kevin Wolf wrote: > Am 21.05.2019 um 13:04 hat Paolo Bonzini geschrieben: > > On 21/05/19 12:36, Stefan Hajnoczi wrote: > > > This is RFC because I am waiting for a test result on the system where > > > the bug was originally discovered. I'm also open to n

Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

2019-05-22 Thread Richard Henderson
On 5/21/19 11:04 AM, Daniel P. Berrangé wrote: > On Thu, May 16, 2019 at 07:39:01PM -0700, Richard Henderson wrote: >> For user-only, we require only the random number bits of the >> crypto subsystem. Rename crypto-aes-obj-y to crypto-user-obj-y, >> and add the random number objects, plus init.o t

Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

2019-05-22 Thread Daniel P . Berrangé
On Wed, May 22, 2019 at 06:52:45AM -0400, Richard Henderson wrote: > On 5/21/19 11:04 AM, Daniel P. Berrangé wrote: > > On Thu, May 16, 2019 at 07:39:01PM -0700, Richard Henderson wrote: > >> For user-only, we require only the random number bits of the > >> crypto subsystem. Rename crypto-aes-obj-

Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

2019-05-22 Thread Daniel P . Berrangé
On Thu, May 16, 2019 at 07:39:01PM -0700, Richard Henderson wrote: > For user-only, we require only the random number bits of the > crypto subsystem. Rename crypto-aes-obj-y to crypto-user-obj-y, > and add the random number objects, plus init.o to handle any > extra stuff the crypto library requir

Re: [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc

2019-05-22 Thread Daniel P . Berrangé
On Thu, May 16, 2019 at 07:38:59PM -0700, Richard Henderson wrote: > The change in v8 is to which objects are linked in to user-only > from the crypto directory. Daniel asked for all of crypto-obj-y > to be added, but I have been unable to find a solution that works. > > If I add crypto-obj-y, th

Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

2019-05-22 Thread Richard Henderson
On 5/22/19 6:56 AM, Daniel P. Berrangé wrote: >> I have a working configuration here in v8. Can we please leave the bikeshed >> unpainted for the moment and you can adjust the makefiles as you see fit >> afterward? > > Yep, ok. I'll be away on holiday for a while so don't have time to look > int

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-22 Thread David Hildenbrand
> I also think that, if we create a bunch more of these wrappers: > >> +DEF_VFAE_HELPER(8) >> +DEF_VFAE_HELPER(16) >> +DEF_VFAE_HELPER(32) > > then RT and ZS can be passed in as constant parameters to the above, and then > the compiler will fold away all of the stuff that's not needed for each

Re: [Qemu-devel] [PATCH v4 3/3] edu: uses uint64_t in dma operation

2019-05-22 Thread Philippe Mathieu-Daudé
On 5/10/19 6:43 PM, Li Qiang wrote: > The dma related variable dma.dst/src/cnt is dma_addr_t, it is > uint64_t in x64 platform. Change these usage from uint32_to > uint64_t to avoid trancation in edu_dma_timer. > > Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé > --- > Change sinc

Re: [Qemu-devel] [PATCH v2] Add a blog post about micro:bit emulation

2019-05-22 Thread Thomas Huth
On 22/05/2019 12.43, Stefan Hajnoczi wrote: > QEMU 4.0 ships the core micro:bit emulation that was implemented during > Outreachy and GSoC 2018. This blog posts explains how to use it and > describes the current status. > > Signed-off-by: Stefan Hajnoczi > --- > v2: > * Used git format-patch --

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-22 Thread Richard Henderson
On 5/22/19 7:01 AM, David Hildenbrand wrote: > >> I also think that, if we create a bunch more of these wrappers: >> >>> +DEF_VFAE_HELPER(8) >>> +DEF_VFAE_HELPER(16) >>> +DEF_VFAE_HELPER(32) >> >> then RT and ZS can be passed in as constant parameters to the above, and then >> the compiler will fo

Re: [Qemu-devel] [PATCH v1 1/5] s390x/tcg: Implement VECTOR FIND ANY ELEMENT EQUAL

2019-05-22 Thread David Hildenbrand
On 22.05.19 13:09, Richard Henderson wrote: > On 5/22/19 7:01 AM, David Hildenbrand wrote: >> >>> I also think that, if we create a bunch more of these wrappers: >>> +DEF_VFAE_HELPER(8) +DEF_VFAE_HELPER(16) +DEF_VFAE_HELPER(32) >>> >>> then RT and ZS can be passed in as constant para

Re: [Qemu-devel] [PATCH 1/2] block: Drain source node in bdrv_replace_node()

2019-05-22 Thread Max Reitz
On 21.05.19 21:16, Kevin Wolf wrote: > Instead of just asserting that no requests are in flight in > bdrv_replace_node(), which is a requirement that most callers ignore, we > can just drain the source node right there. This fixes at least starting > a commit job while I/O is active on the backing

Re: [Qemu-devel] [PATCH v7 00/74] linux-user: Split do_syscall

2019-05-22 Thread Richard Henderson
[Adding the mailing list back in.] On 5/22/19 2:47 AM, Aleksandar Markovic wrote: >> > Version 6 was >> > https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg04794.html >> > >> > Since v5, I've fixed the ioctl failure that Laurent found, and >> > have done a few more syscalls. >> > >> > I've

Re: [Qemu-devel] [PATCH 3/3] egl-helpers: add dmabuf modifier support.

2019-05-22 Thread Gerd Hoffmann
On Wed, May 22, 2019 at 12:47:47PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, May 22, 2019 at 12:04 PM Gerd Hoffmann wrote: > > > > Add modifier parameter to egl_get_fd_for_texture(), to return the used > > modifier on dmabuf exports. > > But nothing uses it yet? WIP still. Sneak preview

Re: [Qemu-devel] [PATCH v2 for 4.1 0/2] avoid lseek on block_status

2019-05-22 Thread Vladimir Sementsov-Ogievskiy
22.05.2019 13:47, Kevin Wolf wrote: > Am 08.04.2019 um 18:26 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Hi! >> >> It's a continuation for >> "[PATCH] qcow2: avoid lseek on block_status if possible" >> https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06598.html >> >> performance result

Re: [Qemu-devel] [PATCH v14 1/1] qcow2: skip writing zero buffers to empty COW areas

2019-05-22 Thread Alberto Garcia
On Thu 16 May 2019 04:27:49 PM CEST, Anton Nefedov wrote: > If COW areas of the newly allocated clusters are zeroes on the backing > image, efficient bdrv_write_zeroes(flags=BDRV_REQ_NO_FALLBACK) can be > used on the whole cluster instead of writing explicit zero buffers later > in perform_cow(). >

Re: [Qemu-devel] [PATCH v8 02/25] build: Link user-only with crypto random number objects

2019-05-22 Thread Laurent Vivier
On 22/05/2019 12:56, Daniel P. Berrangé wrote: On Wed, May 22, 2019 at 06:52:45AM -0400, Richard Henderson wrote: On 5/21/19 11:04 AM, Daniel P. Berrangé wrote: On Thu, May 16, 2019 at 07:39:01PM -0700, Richard Henderson wrote: For user-only, we require only the random number bits of the crypt

Re: [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc

2019-05-22 Thread Laurent Vivier
On 22/05/2019 12:58, Daniel P. Berrangé wrote: On Thu, May 16, 2019 at 07:38:59PM -0700, Richard Henderson wrote: The change in v8 is to which objects are linked in to user-only from the crypto directory. Daniel asked for all of crypto-obj-y to be added, but I have been unable to find a solutio

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-22 Thread Philippe Mathieu-Daudé
On 5/21/19 5:28 PM, Cornelia Huck wrote: > commit a188339ca5a396acc588e5851ed7e19f66b0ebd9 > > Signed-off-by: Cornelia Huck > --- [...] > #define __NR_mq_notify 184 > __SC_COMP(__NR_mq_notify, sys_mq_notify, compat_sys_mq_notify) > #define __NR_mq_getsetattr 185 > @@ -536,8 +567,10 @@ __SC_COM

Re: [Qemu-devel] [PATCH 2/2] iotests: Test commit job start with concurrent I/O

2019-05-22 Thread Max Reitz
On 21.05.19 21:16, Kevin Wolf wrote: > This tests that concurrent requests are correctly drained before making > graph modifications instead of running into assertions in > bdrv_replace_node(). > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/255| 83 +

Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion

2019-05-22 Thread Farhan Ali
On 05/22/2019 06:17 AM, Cornelia Huck wrote: On Tue, 21 May 2019 16:50:47 -0400 Farhan Ali wrote: On 05/07/2019 11:47 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clea

Re: [Qemu-devel] [PULL 21/38] spapr: Add forgotten capability to migration stream

2019-05-22 Thread David Gibson
On Wed, May 22, 2019 at 09:58:29AM +0200, Greg Kurz wrote: > On Wed, 22 May 2019 14:45:43 +1000 > David Gibson wrote: > > > spapr machine capabilities are supposed to be sent in the migration stream > > so that we can sanity check the source and destination have compatible > > configuration. Unf

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-22 Thread Cornelia Huck
On Wed, 22 May 2019 13:47:25 +0200 Philippe Mathieu-Daudé wrote: > On 5/21/19 5:28 PM, Cornelia Huck wrote: > > commit a188339ca5a396acc588e5851ed7e19f66b0ebd9 > > > > Signed-off-by: Cornelia Huck > > --- > [...] > > #define __NR_mq_notify 184 > > __SC_COMP(__NR_mq_notify, sys_mq_notify, co

Re: [Qemu-devel] [PATCH] linux-user: Pass through nanosecond timestamp components for stat syscalls

2019-05-22 Thread Laurent Vivier
On 22/05/2019 11:45, Chen-Yu Tsai wrote: On Wed, May 22, 2019 at 5:08 PM Laurent Vivier wrote: On 14/05/2019 16:53, Chen-Yu Tsai wrote: From: Chen-Yu Tsai Since Linux 2.6 the stat syscalls have mostly supported nanosecond components for each of the file-related timestamps. QEMU user mode e

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-22 Thread Laurent Vivier
On 22/05/2019 14:07, Cornelia Huck wrote: On Wed, 22 May 2019 13:47:25 +0200 Philippe Mathieu-Daudé wrote: On 5/21/19 5:28 PM, Cornelia Huck wrote: commit a188339ca5a396acc588e5851ed7e19f66b0ebd9 Signed-off-by: Cornelia Huck --- [...] #define __NR_mq_notify 184 __SC_COMP(__NR_mq_notif

Re: [Qemu-devel] [PULL 21/38] spapr: Add forgotten capability to migration stream

2019-05-22 Thread Greg Kurz
On Wed, 22 May 2019 21:10:35 +1000 David Gibson wrote: > On Wed, May 22, 2019 at 09:58:29AM +0200, Greg Kurz wrote: > > On Wed, 22 May 2019 14:45:43 +1000 > > David Gibson wrote: > > > > > spapr machine capabilities are supposed to be sent in the migration stream > > > so that we can sanity c

Re: [Qemu-devel] [PULL v3 47/55] linux headers: update against Linux 5.2-rc1

2019-05-22 Thread Cornelia Huck
On Wed, 22 May 2019 14:10:39 +0200 Laurent Vivier wrote: > On 22/05/2019 14:07, Cornelia Huck wrote: > > On Wed, 22 May 2019 13:47:25 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> On 5/21/19 5:28 PM, Cornelia Huck wrote: > >>> commit a188339ca5a396acc588e5851ed7e19f66b0ebd9 > >>> > >>> S

[Qemu-devel] [Bug 1830031] [NEW] fatal error: float32nan on QEmu 3.1

2019-05-22 Thread Daniel Casali
Public bug reported: Docker throws float32nan errors when running alpine container on a CentOS 7.6 ppc64le Distro VM, when using Fedora 30 Host qemu 3.1. I Compiled qemu 2.11.2 on the Fedora 30 and using this qemu-system-ppc64 we don't see the error. Even using qemu 3.1 and machine 2.11 we still g

Re: [Qemu-devel] is anybody experimenting with the idea of rust code in QEMU?

2019-05-22 Thread Stefan Hajnoczi
On Tue, May 21, 2019 at 03:39:40PM +0100, Peter Maydell wrote: > Hi; I have on my todo list the idea of some experimentation/prototyping > of whether being able to write some components of QEMU in Rust would > be (a) feasible (b) beneficial (c) fun to play around with even if > it is likely that it

Re: [Qemu-devel] [PATCH v2 2/6] tests/vhost-user-bridge: Fix misuse of isdigit()

2019-05-22 Thread Markus Armbruster
Thomas Huth writes: > On 14/05/2019 20.41, Thomas Huth wrote: >> On 14/05/2019 20.03, Markus Armbruster wrote: >>> vubr_set_host() passes char values to isdigit(). Undefined behavior >>> when the value is negative. >>> >>> Fix by using qemu_isdigit() instead. >>> >>> Signed-off-by: Markus Armbru

Re: [Qemu-devel] [PATCH v4 2/3] libvhost-user: fix -Werror=format= on ppc64

2019-05-22 Thread Marc-André Lureau
Hi On Wed, May 22, 2019 at 7:23 AM Gerd Hoffmann wrote: > > On Tue, May 14, 2019 at 02:33:41PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, May 14, 2019 at 2:10 PM Philippe Mathieu-Daudé > > wrote: > > > > > > Hi Marc-André, > > > > > > On 5/14/19 12:41 PM, Marc-André Lureau wrote: > >

Re: [Qemu-devel] [PULL v2 00/36] pci, pc, virtio: features, fixes

2019-05-22 Thread Igor Mammedov
On Tue, 21 May 2019 09:26:16 -0400 "Michael S. Tsirkin" wrote: > On Tue, May 21, 2019 at 12:49:48PM +0100, Peter Maydell wrote: > > On Tue, 21 May 2019 at 00:10, Michael S. Tsirkin wrote: > > > > > > The following changes since commit > > > 2259637b95bef3116cc262459271de08e038cc66: > > > > >

  1   2   3   4   >