[Qemu-devel] [PULL 1/2] pci: Allow PCI bus subtypes to support extended config space accesses

2019-04-09 Thread David Gibson
From: Greg Kurz Some PHB implementations, eg. PAPR used on pseries machine, act like a regular PCI bus rather than a PCIe bus, but allow access to the PCIe extended config space anyway. Introduce a new PCI bus class method to modelize this behaviour and use it when adjusting the config space siz

[Qemu-devel] [PULL 0/2] ppc-for-4.0 queue 20190409

2019-04-09 Thread David Gibson
The following changes since commit 5263724b78f89cdea2354c8e92c53bac1b4641a3: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-08 17:53:18 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-4.0-2019040

[Qemu-devel] [PULL 2/2] spapr_pci: Fix extended config space accesses

2019-04-09 Thread David Gibson
From: Greg Kurz The PAPR PHB acts as a legacy PCI bus but it allows PCIe extended config space accesses anyway (for pseries-2.9 and newer machine types). Introduce a specific PCI bus subtype to inform the common PCI code about that. Fixes: c2077e2ca0da7 Signed-off-by: Greg Kurz Message-Id: <15

Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-09 Thread Markus Armbruster
Thomas Huth writes: > We'd like to get rid of global_qtest in the long run (since it is > causing trouble for tests that run multiple instances of QEMU in > parallel, e.g. migration tests)... so if it is feasible, please don't > use it in new code anymore. Try to use a local variable in the funct

Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-09 Thread Thomas Huth
On 09/04/2019 09.45, Markus Armbruster wrote: > Thomas Huth writes: > >> We'd like to get rid of global_qtest in the long run (since it is >> causing trouble for tests that run multiple instances of QEMU in >> parallel, e.g. migration tests)... so if it is feasible, please don't >> use it in new

Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: use variable size of flash device to save memory

2019-04-09 Thread Kevin Wolf
Am 09.04.2019 um 08:01 hat Markus Armbruster geschrieben: > László's last sentence below is "This really needs the attention of the > block people." Cc'ing some. > > Laszlo Ersek writes: > > > On 04/08/19 15:43, Xiang Zheng wrote: > >> > >> On 2019/4/3 23:35, Laszlo Ersek wrote: > I thoug

Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-09 Thread Markus Armbruster
Thomas Huth writes: > On 09/04/2019 09.45, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> We'd like to get rid of global_qtest in the long run (since it is >>> causing trouble for tests that run multiple instances of QEMU in >>> parallel, e.g. migration tests)... so if it is feasible, p

Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-09 Thread Thomas Huth
On 09/04/2019 10.35, Markus Armbruster wrote: > Thomas Huth writes: > >> On 09/04/2019 09.45, Markus Armbruster wrote: >>> Thomas Huth writes: >>> We'd like to get rid of global_qtest in the long run (since it is causing trouble for tests that run multiple instances of QEMU in par

Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-09 Thread Markus Armbruster
Thomas Huth writes: > On 09/04/2019 10.35, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 09/04/2019 09.45, Markus Armbruster wrote: Thomas Huth writes: > We'd like to get rid of global_qtest in the long run (since it is > causing trouble for tests that run multipl

[Qemu-devel] [PATCH for-4.1 0/5] First batch of global_qtest-removement patches for QEMU 4.1

2019-04-09 Thread Thomas Huth
While global_qtest and its wrapper functions work fine for tests that only run one instance of QEMU, using the global_qtest variable in our qtests is very problematic for tests that use multiple test states (e.g. migration tests). Thus tests that still use global_qtest make it hard to share code (e

[Qemu-devel] [PATCH for-4.1 1/5] tests/tco: Make test independent of global_qtest

2019-04-09 Thread Thomas Huth
Pass around the QTestState in the TestData, so we do not need the global_qtest variable here anymore. Signed-off-by: Thomas Huth --- tests/tco-test.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/tests/tco-test.c b/tests/tc

[Qemu-devel] [PATCH for-4.1 3/5] tests/qmp-cmd-test: Use qtest_init() instead of qtest_start()

2019-04-09 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run (since global_qtest can not be used in tests that have to track multiple QEMU states, like migration tests). Use qtest_init() and qtest_quit() instead. Signed-off-by:

[Qemu-devel] [PATCH for-4.1 4/5] tests/test-hmp: Use qtest_init() instead of qtest_start()

2019-04-09 Thread Thomas Huth
qtest_start() + qtest_end() should be avoided, since they use the global_qtest variable that we want to get rid of in the long run Use qtest_init() and qtest_quit() instead. Signed-off-by: Thomas Huth --- tests/test-hmp.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH for-4.1 2/5] tests/megasas: Make test independent of global_qtest

2019-04-09 Thread Thomas Huth
The test uses memwrite() and thus relies on global_qtest. Let's replace it with qtest_memwrite(), so that we are independent from global_qtest here. Signed-off-by: Thomas Huth --- tests/megasas-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/megasas-test.c b/test

[Qemu-devel] [PATCH for-4.1 5/5] tests/ide-test: Make test independent of global_qtest

2019-04-09 Thread Thomas Huth
Pass around the QTestState, so we do not need the problematic global_qtest variable (which causes trouble for tests that have multiple test states) here anymore. Signed-off-by: Thomas Huth --- tests/ide-test.c | 284 ++- 1 file changed, 159 insertions(

Re: [Qemu-devel] [PATCH v4 1/3] block: include base when checking image chain for block allocation

2019-04-09 Thread Vladimir Sementsov-Ogievskiy
08.04.2019 21:22, Andrey Shinkevich wrote: > This patch is used in the 'block/stream: introduce a bottom node' > that is following. Instead of the base node, the caller may pass > the node that has the base as its backing image to the function > bdrv_is_allocated_above() with a new parameter includ

Re: [Qemu-devel] [PATCH v4 3/3] block/stream: introduce a bottom node

2019-04-09 Thread Vladimir Sementsov-Ogievskiy
08.04.2019 21:22, Andrey Shinkevich wrote: > The bottom node is the intermediate block device that has the base as its > backing image. It is used instead of the base node while a block stream > job is running to avoid dependency on the base that may change due to the > parallel jobs. The change ma

Re: [Qemu-devel] [PATCH] sd: Fix out-of-bounds assertions

2019-04-09 Thread Aleksandar Markovic
> > Lidong Chen writes: > > > Due to an off-by-one error, the assert statements allow an > > out-of-bounds array access. > > > > Signed-off-by: Lidong Chen > > --- > > hw/sd/sd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > > index

Re: [Qemu-devel] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-09 Thread Dr. David Alan Gilbert
* Ilya Maximets (i.maxim...@samsung.com) wrote: > > Hi everyone, > > > > > > > > The following new patches are queued for QEMU stable v3.0.1: > > > > https://github.com/mdroth/qemu/commits/stable-3.0

Re: [Qemu-devel] [PULL 0/4] NBD patches for 4.0-rc3

2019-04-09 Thread Peter Maydell
On Mon, 8 Apr 2019 at 20:04, Eric Blake wrote: > > The following changes since commit 2c573106279495795449b0d0373464b597dfe316: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-04-08' into staging (2019-04-08 > 15:21:11 +0100) > > are available in the Git reposito

Re: [Qemu-devel] [PATCH for-4.1 4/5] tests/test-hmp: Use qtest_init() instead of qtest_start()

2019-04-09 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > qtest_start() + qtest_end() should be avoided, since they use the > global_qtest variable that we want to get rid of in the long run > Use qtest_init() and qtest_quit() instead. > > Signed-off-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert > --- >

Re: [Qemu-devel] [PATCH RESEND v2 0/2] Move hvf_cpu_synchronize* calls to cpu_synchronize* functions

2019-04-09 Thread Marcel Apfelbaum
On 4/7/19 3:05 PM, Sukrit Bhatnagar wrote: Hi, Are the patches in good enough shape to be merged? Hi Sukrit, Where is the patch itself :) ? Also be sure to add the maintainers to cc. You can get them by running ./scripts/get_maintainers.pl script on your patch. Please re-send it. Thank

Re: [Qemu-devel] [PATCH 02/13] qgraph: fix qos_node_contains with options

2019-04-09 Thread Thomas Huth
On 18/03/2019 18.15, Paolo Bonzini wrote: > Currently, if qos_node_contains was passed options, it would still > create an edge without any options. Instead, in that case > NULL acts as a terminator. > > Signed-off-by: Paolo Bonzini > --- > tests/libqos/qgraph.c | 12 > tests/libqo

Re: [Qemu-devel] [PATCH] sd: Fix out-of-bounds assertions

2019-04-09 Thread Philippe Mathieu-Daudé
On 4/9/19 10:59 AM, Aleksandar Markovic wrote: >> >> Lidong Chen writes: >> >>> Due to an off-by-one error, the assert statements allow an >>> out-of-bounds array access. >>> >>> Signed-off-by: Lidong Chen >>> --- >>> hw/sd/sd.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >

Re: [Qemu-devel] [PATCH] sd: Fix out-of-bounds assertions

2019-04-09 Thread Aleksandar Markovic
Markus wrote: > This is the second fix for this bug pattern in a fortnight. Where's > one, there are more: > > $ git-grep '<= ARRAY_SIZE' > hw/intc/arm_gicv3_cpuif.c:assert(aprmax <= ARRAY_SIZE(cs->ich_apr[0])); > hw/intc/arm_gicv3_cpuif.c:assert(aprmax <= ARRAY_SIZE(cs->ich_apr[0])); >

Re: [Qemu-devel] [PATCH 03/13] libqos: move common i2c code to libqos

2019-04-09 Thread Thomas Huth
On 18/03/2019 18.15, Paolo Bonzini wrote: > The functions to read/write 8-bit or 16-bit registers are the same > in tmp105 and pca9552 tests, and in fact they are a special case of > "read block"/"write block" functionality; read block in turn is used > in ds1338-test. > > Move everything inside l

Re: [Qemu-devel] [PATCH] Update configure

2019-04-09 Thread Igor Mammedov
On Tue, 9 Apr 2019 07:33:20 +0200 Stefan Weil wrote: > The last *.aml file was removed in commit > 13b1881aacc7e5018773bd545bbaf8d5476699ee. > > Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/con

Re: [Qemu-devel] [PATCH] sd: Fix out-of-bounds assertions

2019-04-09 Thread Peter Maydell
On Tue, 9 Apr 2019 at 06:51, Markus Armbruster wrote: > $ git-grep '<= ARRAY_SIZE' Almost all of these are OK because they're the pattern of checking a loop upper bound before doing a loop. > hw/intc/arm_gicv3_cpuif.c:assert(aprmax <= ARRAY_SIZE(cs->ich_apr[0])); > hw/intc/arm_gicv3_cpuif.c:

Re: [Qemu-devel] [PATCH 05/13] pca9552-test: do not rely on state across tests

2019-04-09 Thread Thomas Huth
On 18/03/2019 18.15, Paolo Bonzini wrote: > receive_autoinc is relying on the LED state that is set by > send_and_receive. Stop doing that, because qgraph resets the > machine between tests. > > Signed-off-by: Paolo Bonzini > --- > tests/pca9552-test.c | 15 +++ > 1 file changed, 11

Re: [Qemu-devel] [PATCH 06/13] imx25-pdk: create ds1338 for qtest inside the test

2019-04-09 Thread Thomas Huth
On 18/03/2019 18.15, Paolo Bonzini wrote: > There is no need to have a test device created by the board. > Instead, create it in the qtest so that we will be able to run > it on other boards too. > > Signed-off-by: Paolo Bonzini > --- > hw/arm/imx25_pdk.c | 9 - > tests/ds1338-test.c |

Re: [Qemu-devel] [PATCH] blk: postpone request execution on a context protected with "drained section"

2019-04-09 Thread Kevin Wolf
Am 02.04.2019 um 10:35 hat Denis Plotnikov geschrieben: > > > On 13.03.2019 19:04, Kevin Wolf wrote: > > Am 14.12.2018 um 12:54 hat Denis Plotnikov geschrieben: > >> On 13.12.2018 15:20, Kevin Wolf wrote: > >>> Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben: > Sounds it should be so,

[Qemu-devel] [PATCH v4 1/8] hw/acpi: Make ACPI IO address space configurable

2019-04-09 Thread Shameer Kolothum
This is in preparation for adding support for ARM64 platforms where it doesn't use port mapped IO for ACPI IO space. Also move few MEMORY_* definitions to header so that other memory hotplug event signalling mechanisms (eg. Generic Event Device on HW-reduced acpi platforms) can use the same from t

[Qemu-devel] [PATCH v4 0/8] ARM virt: ACPI memory hotplug support

2019-04-09 Thread Shameer Kolothum
This series is an attempt to provide device memory hotplug support on ARM virt platform. This is based on Eric's recent works here[1] and carries some of the pc-dimm related patches dropped from his series. The kernel support for arm64 memory hot add was added recently by Robin and hence the gues

[Qemu-devel] [PATCH v4 2/8] hw/acpi: Do not create memory hotplug method when handler is not defined

2019-04-09 Thread Shameer Kolothum
From: Samuel Ortiz With Hardware-reduced ACPI, the GED device will manage ACPI hotplug entirely. As a consequence, make the memory specific events AML generation optional. The code will only be added when the method name is not NULL. Signed-off-by: Samuel Ortiz Signed-off-by: Shameer Kolothum

[Qemu-devel] [PATCH v4 3/8] hw/acpi: Add ACPI Generic Event Device Support

2019-04-09 Thread Shameer Kolothum
From: Samuel Ortiz The ACPI Generic Event Device (GED) is a hardware-reduced specific device[ACPI v6.1 Section 5.6.9] that handles all platform events, including the hotplug ones.This patch generates the AML code that defines GEDs. Platforms need to specify their own GedEvent array to describe w

[Qemu-devel] [PATCH v4 7/8] hw/arm/boot: Add "hotpluggable" property to DT memory node

2019-04-09 Thread Shameer Kolothum
Currently firmware has no way of differentiating the memory nodes and as a result device memory nodes might get exposed to Guest Kernel via UEFI GetMemoryMap() as early boot memory even if Guest boots with ACPI. This will prevent hot-unplug of the device memory. To address this, an additional "hotp

Re: [Qemu-devel] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality

2019-04-09 Thread Philippe Mathieu-Daudé
Hi Stephen, [Cc'ing Markus and Laszlo, we have similar interest in pflash01 testing] On 4/8/19 10:55 PM, Stephen Checkoway wrote: > The goal of this patch series implement the following AMD command-set parallel > flash functionality: > - flash interleaving; > - nonuniform sector sizes; > - erase

[Qemu-devel] [PATCH v4 4/8] hw/arm/virt: Add memory hotplug framework

2019-04-09 Thread Shameer Kolothum
From: Eric Auger This patch adds the memory hot-plug/hot-unplug infrastructure in machvirt. The device memory is not yet exposed to the Guest either though DT or ACPI and hence both cold/hot plug of memory is explicitly disabled for now. Signed-off-by: Eric Auger Signed-off-by: Kwangwoo Lee Si

[Qemu-devel] [PATCH v4 6/8] hw/arm/virt-acpi-build: Add PC-DIMM in SRAT

2019-04-09 Thread Shameer Kolothum
Generate Memory Affinity Structures for PC-DIMM ranges. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger Reviewed-by: Igor Mammedov --- hw/arm/virt-acpi-build.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 1ad39

Re: [Qemu-devel] [PATCH] Update configure

2019-04-09 Thread Philippe Mathieu-Daudé
On 4/9/19 7:33 AM, Stefan Weil wrote: > The last *.aml file was removed in commit > 13b1881aacc7e5018773bd545bbaf8d5476699ee. > > Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configure b/configure >

[Qemu-devel] [PATCH v4 5/8] hw/arm/virt: Enable device memory cold/hot plug with ACPI boot

2019-04-09 Thread Shameer Kolothum
This initializes the GED device with base memory and irq, configures ged memory hotplug event and builds the corresponding aml code. GED irq routing to Guest is also enabled. With this, both hot and cold plug of device memory is enabled now for Guest with ACPI boot. Memory cold plug support with G

[Qemu-devel] [PATCH v4 8/8] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-04-09 Thread Shameer Kolothum
This patch adds memory nodes corresponding to PC-DIMM regions. This will enable support for cold plugged device memory for Guests with DT boot. Signed-off-by: Shameer Kolothum Signed-off-by: Eric Auger --- hw/arm/boot.c | 42 ++ 1 file changed, 42 inserti

Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message

2019-04-09 Thread Philippe Mathieu-Daudé
On 4/8/19 2:31 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster wrote: >>> >>> char_pty_open() prints a "char device redirected to PTY_NAME (label >>> LABEL)" message to the current monitor or else to stderr. No other >>> C

Re: [Qemu-devel] [PATCH] sd: Fix out-of-bounds assertions

2019-04-09 Thread Liam Merwick
On 09/04/2019 06:51, Markus Armbruster wrote: Lidong Chen writes: Due to an off-by-one error, the assert statements allow an out-of-bounds array access. Signed-off-by: Lidong Chen Reviewed-by: Liam Merwick --- hw/sd/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-09 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 08 April 2019 09:12 > To: Shameerali Kolothum Thodi > Cc: Laszlo Ersek ; Auger Eric ; > Ard Biesheuvel ; peter.mayd...@linaro.org; > sa...@linux.intel.com; qemu-devel@nongnu.org; Linuxarm > ; shannon.zha...@

[Qemu-devel] [PATCH] ati-vga: Fix check for blt outside vram

2019-04-09 Thread BALATON Zoltan
Fix the check preventing calling pixman functions that would access memory outside allocated vram. The r128 X driver sometimes seem to try blits that span outside vram, this check prevents crashing QEMU in that case. (The r128 X driver may have problems even on real hardware so I'm not sure if it's

Re: [Qemu-devel] [PATCH 4/4] Header cleanups: Removed unwanted includes from cpu-common.h

2019-04-09 Thread Stefan Hajnoczi
On Sat, Apr 06, 2019 at 09:34:22AM +0530, Aruna Jayasena wrote: > Removed unwanted includes from cpu-common.h > This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks > > Signed-off-by: Aruna Jayasena > --- > include/exec/cpu-common.h | 2 -- > 1 file changed, 2 deletions(-) Hi Aru

Re: [Qemu-devel] [PATCH 03/15] char-pty: Drop "char device redirected to" message

2019-04-09 Thread Marc-André Lureau
Hi On Tue, Apr 9, 2019 at 12:40 PM Philippe Mathieu-Daudé wrote: > > On 4/8/19 2:31 PM, Markus Armbruster wrote: > > Marc-André Lureau writes: > > > >> Hi > >> > >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster > >> wrote: > >>> > >>> char_pty_open() prints a "char device redirected to PTY

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] aio: Add a knob to always poll if there are in-flight requests

2019-04-09 Thread Stefan Hajnoczi
On Tue, Apr 02, 2019 at 02:19:08PM +0200, Sergio Lopez wrote: > The polling mode in aio_poll is able to trim down ~20us on the average > request latency, but it needs manual fine tuning to adjust it to the > characteristics of the storage. > > Here we add a new knob to the IOThread object, "poll-i

Re: [Qemu-devel] How to correctly use more than 2 floppy drives?

2019-04-09 Thread Philippe Mathieu-Daudé
On 4/8/19 9:30 PM, John Snow wrote: > On 4/8/19 1:38 AM, Markus Armbruster wrote: >> Hervé Poussineau writes: >> >>> Le 05/04/2019 à 12:29, Philippe Mathieu-Daudé a écrit : Hi, I am trying to understand the possible values for the MAX_FD variable used by the floppy controller m

Re: [Qemu-devel] [PULL 0/2] Linux user for 4.0 patches

2019-04-09 Thread Peter Maydell
On Mon, 8 Apr 2019 at 20:38, Laurent Vivier wrote: > > The following changes since commit f55a585d1037e5de6088f25e75443c2776786e29: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-04-07 14:54:55 +0100) > > are available in the Git repository at: > > git:/

Re: [Qemu-devel] [PATCH for-4.0] include/qemu/bswap.h: Use __builtin_memcpy() in accessor functions

2019-04-09 Thread Peter Maydell
On Mon, 18 Mar 2019 at 17:07, Paolo Bonzini wrote: > > On 18/03/19 12:29, Peter Maydell wrote: > > In the accessor functions ld*_he_p() and st*_he_p() we use memcpy() > > to perform a load or store to a pointer which might not be aligned > > for the size of the type. We rely on the compiler to opt

Re: [Qemu-devel] [PULL 0/2] ppc-for-4.0 queue 20190409

2019-04-09 Thread Peter Maydell
he Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.0-20190409 > > for you to fetch changes up to 5cf0d326a0fec9ebac2d47c42b5f08e6bc2f686c: > > spapr_pci: Fix extended config space accesses (2019-04-09 15:03:10 +1000) > > ---

[Qemu-devel] [PATCH v2 for-4.0?] aio-posix: ensure poll mode is left when aio_notify is called

2019-04-09 Thread Paolo Bonzini
With aio=thread, adaptive polling makes latency worse rather than better, because it delays the execution of the ThreadPool's completion bottom half. event_notifier_poll() does run while polling, detecting that a bottom half was scheduled by a worker thread, but because ctx->notifier is explicitly

Re: [Qemu-devel] [PULL 05/15] multifd: Be flexible about packet size

2019-04-09 Thread Peter Maydell
On Tue, 26 Mar 2019 at 12:26, Peter Maydell wrote: > > On Mon, 25 Mar 2019 at 18:13, Juan Quintela wrote: > > > > This way we can change the packet size in the future and everything > > will work. We choose an arbitrary big number (100 times configured > > size) as a limit about how big we will

Re: [Qemu-devel] [PATCH] ati-vga: Fix check for blt outside vram

2019-04-09 Thread Philippe Mathieu-Daudé
This patch looks 4.0 worthwhile. On 4/9/19 12:56 PM, BALATON Zoltan wrote: > Fix the check preventing calling pixman functions that would access > memory outside allocated vram. The r128 X driver sometimes seem to try > blits that span outside vram, this check prevents crashing QEMU in > that case

Re: [Qemu-devel] [PATCH v3 3/3] block/stream: introduce a bottom node

2019-04-09 Thread Alberto Garcia
On Mon 08 Apr 2019 08:17:37 PM CEST, Andrey Shinkevich wrote: >>> +for (iter = bs; iter != bottom; iter = backing_bs(iter)) { >>> +block_job_add_bdrv(&s->common, "intermediate node", >>> backing_bs(iter), >>> + 0, basic_flags, &error_abort); >>> } >> >>

Re: [Qemu-devel] [PATCH for-4.0] target/i386: Generate #UD for LOCK on a register increment

2019-04-09 Thread Peter Maydell
On Thu, 28 Mar 2019 at 11:14, Paolo Bonzini wrote: > > On 28/03/19 11:47, Peter Maydell wrote: > > Fix a TCG crash due to attempting an atomic increment > > operation without having set up the address first. > > This is a similar case to that dealt with in commit > > e84fcd7f662a0d8198703, and we

Re: [Qemu-devel] [PATCH v4 3/3] block/stream: introduce a bottom node

2019-04-09 Thread Alberto Garcia
On Mon 08 Apr 2019 08:22:21 PM CEST, Andrey Shinkevich wrote: > The bottom node is the intermediate block device that has the base as its > backing image. It is used instead of the base node while a block stream > job is running to avoid dependency on the base that may change due to the > parallel

Re: [Qemu-devel] [RFC-PATCH] Introducing virtio-example device.

2019-04-09 Thread Stefan Hajnoczi
On Mon, Apr 01, 2019 at 02:18:43PM +0300, Yoni Bettan wrote: > The main goal is to add an example device to Qemu to be used as template or > guideline for contributors when they wish to create a new virtio device. > > Another reason for this device is to document "the right way" to write > a new v

Re: [Qemu-devel] [PATCH v2] qcow2: discard bitmap when removed

2019-04-09 Thread Andrey Shinkevich
On 08/04/2019 22:03, Max Reitz wrote: > On 28.02.19 10:26, Andrey Shinkevich wrote: >> When a bitmap is removed, we can clean some space on the disk. The size >> of a cluster may be larger, so is the size of the bitmap that includes >> many clusters. Some bitmaps can be as large as tens of megaby

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-04-09 Thread Stefan Hajnoczi
On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: > Signed-off-by: Kenneth Heitke > --- > hw/block/nvme.c | 120 +- > hw/block/nvme.h | 3 ++ > hw/block/trace-events | 2 + > include/block/nvme.h | 2 + > 4 files changed, 12

[Qemu-devel] [Bug 1823790] Re: QEMU forces systemd into tight loop

2019-04-09 Thread Peter Maydell
** Tags added: linux-user ** Tags added: arm -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1823790 Title: QEMU forces systemd into tight loop Status in QEMU: New Bug description: While build

[Qemu-devel] [Bug 1807675] Re: qemu commit 80422b0: tcg.c crash in temp_load

2019-04-09 Thread Peter Maydell
The patch from comment #3 is now in git master and will be in the 4.0 release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1807675

[Qemu-devel] [Bug 1823790] Re: QEMU mishandling of SO_PEERSEC forces systemd into tight loop

2019-04-09 Thread Peter Maydell
As described on the systemd issue, the syscall we're getting wrong here is getsockopt(fd, SOL_SOCKET, SO_PEERSEC, ...). Our linux- user/syscall.c:do_getsockopt() doesn't have any special case code for the payload on this function, so we treat it as if it were just an integer payload, which is not c

[Qemu-devel] [PATCH for-4.0 v3 0/2] roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools

2019-04-09 Thread Philippe Mathieu-Daudé
Hi, Two trivial fixes to avoid the latest EDK2 testing series to cause trouble to downstream distributions (in particular if they have PIE enforced). Since v2: - addressed Laszlo's suggestion - reworded patch description v2: https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01033.html v1:

[Qemu-devel] [PATCH for-4.0 v3 1/2] roms: Rename the EFIROM variable to avoid clashing with iPXE

2019-04-09 Thread Philippe Mathieu-Daudé
The iPXE's 'veryclean' recipe removes $(EFIROM) even if the EFIROM macro originates from elsewhere: $ git checkout f590a812c21~ $ make -C roms clean EFIROM=$(type -P EfiRom) make: Entering directory '/source/qemu/roms' [...] make -C ipxe/src veryclean make[1]: Entering directory '/sour

[Qemu-devel] [Bug 1812861] Re: QEMU in user-mode emulation mode crashes when the user program jumps to an invalid address

2019-04-09 Thread Peter Maydell
** Tags removed: usermode ** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1812861 Title: QEMU in user-mode emulation mode crashes when the user program jumps to an invalid

[Qemu-devel] [PATCH for-4.0 v3 2/2] roms: Allow passing configure options to the EDK2 build tools

2019-04-09 Thread Philippe Mathieu-Daudé
Since commit f590a812c210 we build the EDK2 EfiRom utility unconditionally. Some distributions require to use extra compiler/linker flags, i.e. SUSE which enforces the PIE protection (see [*]). EDK2 build tools already provide a set of variables for that, use them to allow the caller to easily in

Re: [Qemu-devel] [PATCH for-4.0 v3 0/2] roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools

2019-04-09 Thread Peter Maydell
On Tue, 9 Apr 2019 at 14:47, Philippe Mathieu-Daudé wrote: > > Hi, > > Two trivial fixes to avoid the latest EDK2 testing series to > cause trouble to downstream distributions (in particular if > they have PIE enforced). > > Since v2: > - addressed Laszlo's suggestion > - reworded patch descriptio

[Qemu-devel] [Bug 1814352] Re: SIOCGIFNAME takes a struct ifreq not an integer

2019-04-09 Thread Peter Maydell
Your suggested fix looks good -- did you want to send it to qemu-devel with a suitable Signed-off-by: line ? ** Tags added: linux-user ** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH v3 35/38] console: make screendump asynchronous

2019-04-09 Thread Marc-André Lureau
Hi On Thu, Apr 12, 2018 at 4:49 PM Dr. David Alan Gilbert wrote: > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > Make screendump asynchronous to provide correct screendumps. > > > > HMP doesn't have async support, so it has to remain synchronous and > > potentially incorrect to a

[Qemu-devel] [PATCH] msix: fix interrupt aggregation problem at the passthrough of NVMe SSD

2019-04-09 Thread Zhuangyanying
From: Zhuang Yanying Recently I tested the performance of NVMe SSD passthrough and found that interrupts were aggregated on vcpu0(or the first vcpu of each numa) by /proc/interrupts,when GuestOS was upgraded to sles12sp3 (or redhat7.6). But /proc/irq/X/smp_affinity_list shows that the interrup

Re: [Qemu-devel] [PATCH v4 1/3] block: include base when checking image chain for block allocation

2019-04-09 Thread Alberto Garcia
On Mon 08 Apr 2019 08:22:19 PM CEST, Andrey Shinkevich wrote: > * Return true if (a prefix of) the given range is allocated in any image > - * between BASE and TOP (inclusive). BASE can be NULL to check if the given > + * between BASE and TOP (TOP included). To check the BASE image, set the > +

Re: [Qemu-devel] [PATCH 0/3] vhost-scsi: Support live migration

2019-04-09 Thread Stefan Hajnoczi
On Thu, Mar 21, 2019 at 09:55:42AM +0200, Nir Weiner wrote: > Originally migration was not possible with vhost-scsi because > as part of migration, the source host target SCSI device state > needs to be saved and loaded into the destination host target SCSI > device. This cannot be done by QEMU. >

Re: [Qemu-devel] [PATCH v4 1/3] block: include base when checking image chain for block allocation

2019-04-09 Thread Vladimir Sementsov-Ogievskiy
09.04.2019 17:18, Alberto Garcia wrote: > On Mon 08 Apr 2019 08:22:19 PM CEST, Andrey Shinkevich wrote: >>* Return true if (a prefix of) the given range is allocated in any image >> - * between BASE and TOP (inclusive). BASE can be NULL to check if the given >> + * between BASE and TOP (TOP in

Re: [Qemu-devel] [PATCH v4 1/3] block: include base when checking image chain for block allocation

2019-04-09 Thread Alberto Garcia
On Tue 09 Apr 2019 04:43:12 PM CEST, Vladimir Sementsov-Ogievskiy wrote: >>> -while (intermediate && intermediate != base) { >>> +while (include_base || intermediate != base) { >>> int64_t pnum_inter; >>> int64_t size_inter; >>> >>> @@ -2360,6 +2364,10 @@ int bdrv_is_

Re: [Qemu-devel] [PATCH] msix: fix interrupt aggregation problem at the passthrough of NVMe SSD

2019-04-09 Thread Michael S. Tsirkin
On Tue, Apr 09, 2019 at 02:14:56PM +, Zhuangyanying wrote: > From: Zhuang Yanying > > Recently I tested the performance of NVMe SSD passthrough and found that > interrupts > were aggregated on vcpu0(or the first vcpu of each numa) by > /proc/interrupts,when > GuestOS was upgraded to sles12s

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-04-09 Thread Igor Mammedov
On Fri, 5 Apr 2019 16:55:30 +0800 Wei Yang wrote: > On Tue, Apr 02, 2019 at 08:15:12AM +0200, Igor Mammedov wrote: > >On Tue, 2 Apr 2019 11:53:43 +0800 > >Wei Yang wrote: > > > > > >> The migration infrastructure has several SaveStateEntry to help migrate > >> different elements. The one with

[Qemu-devel] [PATCH 1/2] qemu-img convert: ignore read errors

2019-04-09 Thread Andrey Shinkevich
The 'qemu-img convert' new command option 'force read' with the key '-R' allows converting a damaged image to get all the available information in case of the read errors. The program reports read errors and continue the image conversion. The users should keep in their minds that the resulting imag

[Qemu-devel] [PATCH 0/2] qemu-img convert: ignore read errors

2019-04-09 Thread Andrey Shinkevich
The 'qemu-img convert' new command option 'force read' with the key '-R' allows converting a damaged image to get all the available information in case of the read errors. The program reports read errors and continue the image conversion. The users should keep in their minds that the resulting imag

[Qemu-devel] [PATCH 2/2] iotests: new test 253 check qemu-img convert force read

2019-04-09 Thread Andrey Shinkevich
A new test for the patch 'qemu-img convert: ignore read errors' Signed-off-by: Andrey Shinkevich --- tests/qemu-iotests/253 | 69 ++ tests/qemu-iotests/253.out | 4 +++ tests/qemu-iotests/group | 1 + 3 files changed, 74 insertions(+) create m

Re: [Qemu-devel] [PATCH for-4.0 v3 2/2] roms: Allow passing configure options to the EDK2 build tools

2019-04-09 Thread Igor Mammedov
On Tue, 9 Apr 2019 15:45:36 +0200 Philippe Mathieu-Daudé wrote: > Since commit f590a812c210 we build the EDK2 EfiRom utility > unconditionally. > > Some distributions require to use extra compiler/linker flags, > i.e. SUSE which enforces the PIE protection (see [*]). > > EDK2 build tools alrea

[Qemu-devel] [PATCH for-4.1] q35: acpi: do not create dummy MCFG table

2019-04-09 Thread Igor Mammedov
Dummy table (with signature "QEMU") creation came from original SeaBIOS codebase. And QEMU would have to keep it around if there were Q35 machine that depended on keeping ACPI tables blob constant size. Luckily there were no versioned Q35 machine types before commit: (since 2.3) a1666142db acpi-b

Re: [Qemu-devel] [PATCH] msix: fix interrupt aggregation problem at the passthrough of NVMe SSD

2019-04-09 Thread Michael S. Tsirkin
On Tue, Apr 09, 2019 at 02:14:56PM +, Zhuangyanying wrote: > From: Zhuang Yanying > > Recently I tested the performance of NVMe SSD passthrough and found that > interrupts > were aggregated on vcpu0(or the first vcpu of each numa) by > /proc/interrupts,when > GuestOS was upgraded to sles12s

Re: [Qemu-devel] [PATCH for-4.0 v3 0/2] roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools

2019-04-09 Thread Michael S. Tsirkin
On Tue, Apr 09, 2019 at 03:45:34PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > Two trivial fixes to avoid the latest EDK2 testing series to > cause trouble to downstream distributions (in particular if > they have PIE enforced). > > Since v2: > - addressed Laszlo's suggestion > - reworded patc

Re: [Qemu-devel] [PATCH v4 8/8] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-04-09 Thread Laszlo Ersek
On 04/09/19 12:29, Shameer Kolothum wrote: > This patch adds memory nodes corresponding to PC-DIMM regions. > This will enable support for cold plugged device memory for Guests > with DT boot. > > Signed-off-by: Shameer Kolothum > Signed-off-by: Eric Auger > --- > hw/arm/boot.c | 42 +++

Re: [Qemu-devel] [PATCH for-4.0 v3 0/2] roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools

2019-04-09 Thread Peter Maydell
On Tue, 9 Apr 2019 at 16:06, Michael S. Tsirkin wrote: > > On Tue, Apr 09, 2019 at 03:45:34PM +0200, Philippe Mathieu-Daudé wrote: > > Hi, > > > > Two trivial fixes to avoid the latest EDK2 testing series to > > cause trouble to downstream distributions (in particular if > > they have PIE enforced

[Qemu-devel] [PATCH for-4.0] migration/ram.c: Fix use-after-free in multifd_recv_unfill_packet()

2019-04-09 Thread Peter Maydell
Coverity points out (CID 1400442) that in this code: if (packet->pages_alloc > p->pages->allocated) { multifd_pages_clear(p->pages); multifd_pages_init(packet->pages_alloc); } we free p->pages in multifd_pages_clear() but continue to use it in the following code. We also l

Re: [Qemu-devel] [PATCH for-4.0 v3 1/2] roms: Rename the EFIROM variable to avoid clashing with iPXE

2019-04-09 Thread Laszlo Ersek
On 04/09/19 15:45, Philippe Mathieu-Daudé wrote: > The iPXE's 'veryclean' recipe removes $(EFIROM) even if the EFIROM > macro originates from elsewhere: > > $ git checkout f590a812c21~ > $ make -C roms clean EFIROM=$(type -P EfiRom) > make: Entering directory '/source/qemu/roms' > [...] >

Re: [Qemu-devel] [PATCH for-4.0 v3 2/2] roms: Allow passing configure options to the EDK2 build tools

2019-04-09 Thread Laszlo Ersek
On 04/09/19 15:45, Philippe Mathieu-Daudé wrote: > Since commit f590a812c210 we build the EDK2 EfiRom utility > unconditionally. > > Some distributions require to use extra compiler/linker flags, > i.e. SUSE which enforces the PIE protection (see [*]). > > EDK2 build tools already provide a set o

Re: [Qemu-devel] [PATCH for-4.0 v3 0/2] roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools

2019-04-09 Thread Laszlo Ersek
On 04/09/19 16:00, Peter Maydell wrote: > On Tue, 9 Apr 2019 at 14:47, Philippe Mathieu-Daudé wrote: >> >> Hi, >> >> Two trivial fixes to avoid the latest EDK2 testing series to >> cause trouble to downstream distributions (in particular if >> they have PIE enforced). >> >> Since v2: >> - addresse

Re: [Qemu-devel] [PATCH for-4.0 v3 0/2] roms: Avoid iPXE/EDK2 EFIROM variable clash, pass CFLAGS to EDK2 build tools

2019-04-09 Thread Peter Maydell
On Tue, 9 Apr 2019 at 16:25, Laszlo Ersek wrote: > > On 04/09/19 16:00, Peter Maydell wrote: > > Thanks. This is one of a handful of remaining bugs we > > should fix for 4.0, so I would ideally like to get this > > in rc3 today (or tomorrow if we have to slip rc3 a day). > > If people wanting to r

Re: [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

2019-04-09 Thread Stephen Checkoway
On Apr 9, 2019, at 02:13, Thomas Huth wrote: > We'd like to get rid of global_qtest in the long run (since it is > causing trouble for tests that run multiple instances of QEMU in > parallel, e.g. migration tests)... so if it is feasible, please don't > use it in new code anymore. Try to use a

[Qemu-devel] [PATCH] docs: replace min-glib with fedora

2019-04-09 Thread Marc-André Lureau
min-glib.docker was removed in commit e7b3af81597db1a6b55f2c15d030d703c6b2c6ac ("glib: bump min required glib library version to 2.40"). Cc: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- docs/devel/testing.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH for-4.0] migration/ram.c: Fix use-after-free in multifd_recv_unfill_packet()

2019-04-09 Thread Juan Quintela
Peter Maydell wrote: > Coverity points out (CID 1400442) that in this code: > > if (packet->pages_alloc > p->pages->allocated) { > multifd_pages_clear(p->pages); > multifd_pages_init(packet->pages_alloc); > } > > we free p->pages in multifd_pages_clear() but continue to > u

[Qemu-devel] [PULL 4/5] hw/i386/pc: Fix crash when hot-plugging nvdimm on older machine types

2019-04-09 Thread Paolo Bonzini
From: Thomas Huth QEMU currently crashes when you try to hot-plug an "nvdimm" device on older machine types: $ qemu-system-x86_64 -monitor stdio -M pc-1.1 QEMU 3.1.92 monitor - type 'help' for more information (qemu) device_add nvdimm,id=nvdimmn1 qemu-system-x86_64: /home/thuth/devel/qemu/util/e

[Qemu-devel] [PULL 2/5] roms: Allow passing configure options to the EDK2 build tools

2019-04-09 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since commit f590a812c210 we build the EDK2 EfiRom utility unconditionally. Some distributions require to use extra compiler/linker flags, i.e. SUSE which enforces the PIE protection (see [*]). EDK2 build tools already provide a set of variables for that, use them t

[Qemu-devel] [PULL 5/5] tests: Make check-block a phony target

2019-04-09 Thread Paolo Bonzini
From: Markus Armbruster Fixes: b93b63f574c "test makefile overhaul" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20190319072104.32591-1-arm...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Qemu-devel] [PATCH 0/4] Header cleanups

2019-04-09 Thread Aruna Jayasena
Removed unwanted includes from cpu-common.h This task was under https://wiki.qemu.org/Contribute/BiteSizedTasks Signed-off-by: Aruna Jayasena --- include/exec/cpu-common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h index cef8b88a2a

  1   2   3   >