On 4/8/19 2:31 PM, Markus Armbruster wrote: > Marc-André Lureau <marcandre.lur...@redhat.com> writes: > >> Hi >> >> On Mon, Apr 8, 2019 at 10:36 AM Markus Armbruster <arm...@redhat.com> wrote: >>> >>> char_pty_open() prints a "char device redirected to PTY_NAME (label >>> LABEL)" message to the current monitor or else to stderr. No other >>> ChardevClass::open() prints anything on success. Drop the message. >>> >>> Cc: "Marc-André Lureau" <marcandre.lur...@redhat.com> >>> Cc: Paolo Bonzini <pbonz...@redhat.com> >>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >>> --- >>> chardev/char-pty.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >> >> I guess that was printed for convenience. >> >> Allocated pty can be read from "info chardev", so I suppose we can >> make qemu more silent. Fine with me: >> >> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > Thanks! > > If we should decide the message is still useful enough to be worth > keeping, I could direct it to stdout instead of dropping it.
I prefer this, if Marc-André is still OK.