> From: Jules Irenge
> Subject: [PATCH v2] target/mips: add * to comments and realign them to fix
> checkpatch warnings
>
> Add * to comments and realign to fix warnings issued by checkpatch.pl tool
> "WARNING: Block comments use a leading /* on a separate line"
> within the file "target/mips/cp
On 4/1/19 5:48 PM, Collin Walling wrote:
[...]
---
This version is posted in tandem with a new kernel patch that changes
how the execution of the diag 0x318 instruction is handled. A link to
this series will be attached as a reply to this series for convenience.
https://www.spinics.net/list
> From: Mateja Marjanovic
> Subject: [PATCH v4 1/5] target/mips: Fix MSA instructions LD. on big
> endian host
>
> From: Mateja Marjanovic
>
> Fix the case when the host is a big endian machine, and change
> the approach toward LD. instruction helpers.
>
> Signed-off-by: Mateja Marjanovic
> ---
> From: Mateja Marjanovic
> Subject: [PATCH v4 2/5] target/mips: Fix MSA instructions ST. on big
> endian host
>
> From: Mateja Marjanovic
>
> Fix the case when the host is a big endian machine, and change
> the approach toward ST. instruction helpers.
>
> Signed-off-by: Mateja Marjanovic
> ---
> From: Mateja Marjanovic
> Subject: [PATCH v4 5/5] target/mips: Refactor and fix INSERT.
> instructions
>
> From: Mateja Marjanovic
>
> The old version of the helper for the INSERT. MSA instructions
> has been replaced with four helpers that don't use switch, and change
> the endianness of th
On 3/29/19 4:20 PM, Zhang Chen wrote:
> From: Zhang Chen
>
> Add bitmap.h and bitops.h to Dirty Bitmaps field.
>
> Signed-off-by: Zhang Chen
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 56139ac8ab..360af3e8ca 100644
> ---
On Apr 2, 2019 5:20 PM, "Mateja Marjanovic"
wrote:
>
> From: Mateja Marjanovic
>
> Optimize set of MSA instructions ILVEV, using directly
> tcg registers and performing logic on them instead of
> using helpers.
>
> In the following table, the first column is the performance
> before this patch. T
On 4/1/19 9:08 AM, Eric Blake wrote:
> The NBD spec suggests that a server should never advertise a size
> inconsistent with its minimum block alignment, as that tail is
> effectively inaccessible to a compliant client obeying those block
> constraints. Since we have a habit of rounding up rather t
On Apr 2, 2019 5:20 PM, "Mateja Marjanovic"
wrote:
>
> From: Mateja Marjanovic
>
> Optimize set of MSA instructions ILVEV, using directly
Use full instruction names, with the only exception of possible Bachus-Naur
forms... again.
> tcg registers and performing logic on them instead of
> using h
On Wed, 3 Apr 2019 at 02:16, Eduardo Habkost wrote:
>
> On Tue, Apr 02, 2019 at 11:23:42PM +0700, Peter Maydell wrote:
> > One wrinkle to watch out for is code paths that are used in the
> > linux-user emulator, where there is no machine at all... For instance
> > cpu_common_realizefn() handles th
On Tue, Apr 02, 2019 at 06:10:23PM +0200, Markus Armbruster wrote:
>Wei Yang writes:
[...]
@@ -2659,7 +2655,8 @@ static const QEMUOption *lookup_opt(int argc, char
**argv,
static MachineClass *select_machine(void)
{
-MachineClass *machine_class = fin
On Tue, Apr 02, 2019 at 07:44:23PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.y...@linux.intel.com) wrote:
>> subsection_found is true implies vmdesc is not NULL.
>>
>> Signed-off-by: Wei Yang
>> ---
>> migration/vmstate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
subsection_found is true implies vmdesc is not NULL.
This patch remove the additional check on vmdesc and rename
subsection_found to vmdesc_has_subsections to make it more self-explain.
Signed-off-by: Wei Yang
---
v2:
* rename it to vmdesc_has_subsections
---
migration/vmstate.c | 8
On Tue, Apr 02, 2019 at 03:53:05PM +0200, Greg Kurz wrote:
> On Tue, 2 Apr 2019 16:40:28 +1100
> David Gibson wrote:
>
> > Since c2077e2c "pci: Adjust PCI config limit based on bus topology",
> > pci_adjust_config_limit() has been used in the config space read and write
> > paths to only permit
> -Original Message-
> From: John Snow [mailto:js...@redhat.com]
> Sent: Wednesday, April 3, 2019 5:07 AM
> To: Zhang, Chen ; Laurent Vivier ;
> qemu-dev ; Fam Zheng
> Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap
> file to related field
>
>
>
> On 3/29/19 4:20
On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine Ho wrote:
> Commit 18269069c310 ("migration: Introduce ignore-shared capability")
> addes ignore-shared capability to bypass the shared ramblock (e,g,
> membackend + numa node). It does good to live migration.
>
> This commit expectes that QEMU d
On Tue, Apr 02, 2019 at 03:41:10PM +, Elijah Shakkour wrote:
>
>
> > -Original Message-
> > From: Knut Omang
> > Sent: Monday, April 1, 2019 5:24 PM
> > To: Elijah Shakkour ; Peter Xu
> >
> > Cc: Michael S. Tsirkin ; Alex Williamson
> > ; Marcel Apfelbaum
> > ; Stefan Hajnoczi ;
> >
Previous commits have mentioned that our NBD server still sends
unaligned fragments when an active layer with large advertised minimum
block size is backed by another layer with a smaller block
size. Expand the test to actually cover this scenario, by using qcow2
encryption (which forces 512-byte a
My recent pull request for -rc2 documented several places where our
server still does not comply with the NBD specification with regards
to alignment. This series finishes the work in making everything
compliant, insofar as I could test.
The first three patches are rather trivial - they don't driv
The NBD spec requires that responses to NBD_CMD_BLOCK_STATUS be
aligned to the server's advertised min_block alignment, if the client
agreed to abide by alignments. In general, since dirty bitmap
granularity cannot go below 512, and it is hard to provoke qcow2 to go
above an alignment of 512, this
We've recently added traces for clients to flag server non-compliance;
let's do the same for servers to flag client non-compliance. According
to the spec, if the client requests NBD_INFO_BLOCK_SIZE, it is
promising to send all requests aligned to those boundaries. Of
course, if the client does not
The NBD server code used bdrv_block_status_above() to determine where
to fragment structured read and block status replies. However, the
protocol can only advertise the active layer's minimum block size; if
the active layer is backed by another file with smaller alignment,
then we can end up leaki
Previous patches mentioned how the blkdebug filter driver demonstrates
a bug present in our NBD server; the bug is also present with the raw
format driver when probing occurs. Basically, if we specify a
particular alignment > 1, but defer the actual block status to the
underlying file, and the unde
Don't increment remaining_bytes until we know that we will actually be
including the current block status extent in the reply; otherwise, the
value traced will include a bytes value that is oversized by the
length of the next block status extent which did not get sent because
it instead ended the l
In commit 0c1d50bd, I added a couple of TODO comments about whether we
consult bl.request_alignment when responding to NBD_OPT_INFO. At the
time, qemu as server was hard-coding an advertised alignment of 512 to
clients that promised to obey constraints, and there was no function
for getting at a de
Cc: Edgar E. Iglesias
Signed-off-by: Richard Henderson
---
target/cris/cpu.h | 5 +--
target/cris/cpu.c | 5 ++-
target/cris/helper.c| 67 +++--
target/cris/op_helper.c | 28 -
4 files changed, 42 insertions(+), 63 deletions(-
Cc: qemu-...@nongnu.org
Signed-off-by: Richard Henderson
---
target/arm/internals.h | 10 +++--
target/arm/cpu.c | 22 +-
target/arm/helper.c| 97 ++
target/arm/op_helper.c | 29 ++---
4 files changed, 72 insertions(+), 86 deletion
For this combination, we can tell whether or not the address
being accessed is within the 4GB range that is accessible by
the guest. Otherwise the fault must be elsewhere in qemu,
accessing qemu data structures.
Signed-off-by: Richard Henderson
---
accel/tcg/user-exec.c | 9 +
1 file ch
There is currently a lot of confusion between foo_cpu_handle_mmu_fault
and tlb_fill.
In particular, foo_cpu_handle_mmu_fault was only defined for user-only,
and its only valid action was to set up the cpu for cpu_loop_exit so
that we can deliver a SIGSEGV to the guest. And yet, we had code that
t
Signed-off-by: Richard Henderson
---
target/alpha/cpu.h| 5 ++--
target/alpha/cpu.c| 5 ++--
target/alpha/helper.c | 50 +++
target/alpha/mem_helper.c | 16 -
4 files changed, 35 insertions(+), 41 deletions(-)
diff --git a/tar
We do not support probing, but we do not need it yet either.
Cc: Paolo Bonzini
Cc: Eduardo Habkost
Signed-off-by: Richard Henderson
---
target/i386/cpu.h | 5 ++--
target/i386/cpu.c | 5 ++--
target/i386/excp_helper.c | 61 +--
target/i386/
This hook will replace the (user-only mode specific) handle_mmu_fault
hook, and the (system mode specific) tlb_fill function.
The handle_mmu_fault hook was written as if there was a valid
way to recover from an mmu fault, and had 3 possible return states.
In reality, the only valid action is to ra
Signed-off-by: Richard Henderson
---
target/hppa/cpu.h| 8
target/hppa/cpu.c| 5 ++---
target/hppa/mem_helper.c | 22 +-
3 files changed, 23 insertions(+), 12 deletions(-)
diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index c062c7969c..e0e5d879
Cc: Edgar E. Iglesias
Signed-off-by: Richard Henderson
---
target/microblaze/cpu.h | 5 +-
target/microblaze/cpu.c | 5 +-
target/microblaze/helper.c| 142 +-
target/microblaze/op_helper.c | 19 -
4 files changed, 78 insertions(+), 93 dele
Cc: Michael Walle
Signed-off-by: Richard Henderson
---
target/lm32/cpu.h | 5 +++--
target/lm32/cpu.c | 5 ++---
target/lm32/helper.c| 12 +---
target/lm32/op_helper.c | 16
4 files changed, 14 insertions(+), 24 deletions(-)
diff --git a/target/lm32/cp
Cc: Anthony Green
Signed-off-by: Richard Henderson
---
target/moxie/cpu.h| 5 ++--
target/moxie/cpu.c| 5 ++--
target/moxie/helper.c | 61 ++-
3 files changed, 19 insertions(+), 52 deletions(-)
diff --git a/target/moxie/cpu.h b/target/moxie/cpu.
Cc: qemu-...@nongnu.org
Cc: David Gibson
Signed-off-by: Richard Henderson
---
target/ppc/cpu.h| 7 +++
target/ppc/mmu_helper.c | 19 +--
target/ppc/translate_init.inc.c | 5 ++---
target/ppc/user_only_helper.c | 14 --
4 files changed,
Cc: Stafford Horne
Signed-off-by: Richard Henderson
---
target/openrisc/cpu.h | 5 ++--
target/openrisc/cpu.c | 5 ++--
target/openrisc/mmu.c | 65 ++-
3 files changed, 39 insertions(+), 36 deletions(-)
diff --git a/target/openrisc/cpu.h b/target/openri
Cc: Artyom Tarasenko
Cc: Mark Cave-Ayland
Signed-off-by: Richard Henderson
---
target/sparc/cpu.h | 5 +-
target/sparc/cpu.c | 5 +-
target/sparc/ldst_helper.c | 15
target/sparc/mmu_helper.c | 175 +++--
4 files changed, 93 insertions(
Cc: Chris Wulff
Cc: Marek Vasut
Signed-off-by: Richard Henderson
---
target/nios2/cpu.h| 5 +-
target/nios2/cpu.c| 5 +-
target/nios2/helper.c | 181 --
target/nios2/mmu.c| 12 ---
4 files changed, 92 insertions(+), 111 deletions(-)
diff
Cc: Laurent Vivier
Signed-off-by: Richard Henderson
---
target/m68k/cpu.h | 5 ++-
target/m68k/cpu.c | 2 +-
target/m68k/helper.c| 87 ++---
target/m68k/op_helper.c | 15 ---
4 files changed, 50 insertions(+), 59 deletions(-)
diff --git
Cc: Guan Xuetao
Signed-off-by: Richard Henderson
---
target/unicore32/cpu.h | 5 +++--
target/unicore32/cpu.c | 5 +
target/unicore32/helper.c| 23 ---
target/unicore32/op_helper.c | 14 --
target/unicore32/softmmu.c | 19 +++---
Note that env->active_tc.PC is removed from the qemu_log as that value
is garbage. The PC isn't recovered until cpu_restore_state, called from
cpu_loop_exit_restore, called from do_raise_exception_err.
Cc: Aleksandar Markovic
Cc: Aleksandar Rikalo
Signed-off-by: Richard Henderson
---
target/m
Cc: Bastian Koppelmann
Signed-off-by: Richard Henderson
---
target/tricore/cpu.h | 6 +++---
target/tricore/cpu.c | 1 +
target/tricore/helper.c| 27 +++
target/tricore/op_helper.c | 26 --
4 files changed, 23 insertions(+), 37 de
Note that env->pc is removed from the qemu_log as that value is garbage.
The PC isn't recovered until cpu_restore_state, called from
cpu_loop_exit_restore, called from riscv_raise_exception.
Cc: qemu-ri...@nongnu.org
Cc: Palmer Dabbelt
Cc: Alistair Francis
Signed-off-by: Richard Henderson
---
Cc: Max Filippov
Signed-off-by: Richard Henderson
---
target/xtensa/cpu.h| 5 +--
target/xtensa/cpu.c| 5 ++-
target/xtensa/helper.c | 74 +-
3 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu
Cc: Aurelien Jarno
Signed-off-by: Richard Henderson
---
target/sh4/cpu.h | 5 +-
target/sh4/cpu.c | 5 +-
target/sh4/helper.c| 197 -
target/sh4/op_helper.c | 12 ---
4 files changed, 101 insertions(+), 118 deletions(-)
diff --git a/t
Cc: qemu-s3...@nongnu.org
Cc: Cornelia Huck
Cc: David Hildenbrand
Signed-off-by: Richard Henderson
---
target/s390x/internal.h| 5 +-
target/s390x/cpu.c | 5 +-
target/s390x/excp_helper.c | 156 +
target/s390x/mem_helper.c | 29 ---
4 fi
This hook is now completely replaced by tlb_fill.
Signed-off-by: Richard Henderson
---
include/qom/cpu.h | 3 ---
accel/tcg/user-exec.c | 13 +++--
2 files changed, 3 insertions(+), 13 deletions(-)
diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 7e96a0aed3..8afcf0c427 1006
Signed-off-by: Richard Henderson
---
target/tilegx/cpu.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/target/tilegx/cpu.c b/target/tilegx/cpu.c
index bfe9be59b5..be50976c6f 100644
--- a/target/tilegx/cpu.c
+++ b/target/tilegx/cpu.c
@@ -24,6 +24,8 @@
#include "q
Most of the existing users would continue around a loop which
would fault the tlb entry in via a normal load/store. But for
SVE we have a true non-faulting case which requires the new
probing form of tlb_fill.
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 40 ---
We can now use the CPUClass hook instead of a named function.
Create a static tlb_fill function to avoid other changes within
cputlb.c. This also which also isolates the asserts implied.
Remove the named tlb_fill function from all of the targets.
Signed-off-by: Richard Henderson
---
include/ex
Hi Peter,
That command line option doesn't work for boston, although I didn't get any
obvious error, no Ethernet card appears either.
Where can I get that arm image/command which can work well for you with "
-netdev user,id=mynet -device virtio-net-pci,netdev=mynet" ?
Anyway, if that command
On Wed, 3 Apr 2019 at 10:46, Richard Henderson
wrote:
>
> For this combination, we can tell whether or not the address
> being accessed is within the 4GB range that is accessible by
> the guest. Otherwise the fault must be elsewhere in qemu,
> accessing qemu data structures.
>
> Signed-off-by: Ri
On Wed, 3 Apr 2019 at 11:52, Tommy Jin wrote:
> That command line option doesn't work for boston, although I didn't get any
> obvious error, no Ethernet card appears either.
Does the guest kernel find the PCI device (eg appears in kernel bootup
messages, appears in 'lspci' output)? It's worth do
On Wed, 3 Apr 2019 at 10:44, Richard Henderson
wrote:
> +bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> + MMUAccessType access_type, int mmu_idx,
> + bool probe, uintptr_t retaddr)
> +{
> +ARMCPU *cpu = ARM_CPU(cs);
> +
> +#ifdef CONFI
Wei Yang writes:
> On Tue, Apr 02, 2019 at 06:10:23PM +0200, Markus Armbruster wrote:
>>Wei Yang writes:
>
> [...]
>
>
> @@ -2659,7 +2655,8 @@ static const QEMUOption *lookup_opt(int argc, char
> **argv,
>
> static MachineClass *select_machine(void)
> {
> -
On 4/3/19 10:43 AM, Richard Henderson wrote:
> Cc: Artyom Tarasenko
> Cc: Mark Cave-Ayland
> Signed-off-by: Richard Henderson
> ---
> target/sparc/cpu.h | 5 +-
> target/sparc/cpu.c | 5 +-
> target/sparc/ldst_helper.c | 15
> target/sparc/mmu_helper.c | 175 +
201 - 258 of 258 matches
Mail list logo
