Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-22 Thread Philippe Mathieu-Daudé
Le ven. 22 mars 2019 00:33, Laszlo Ersek a écrit : > On 03/21/19 23:32, Laszlo Ersek wrote: > > > Cool, so let me try this. I'm going to download the xz.old file > > manually. Rename it to just xz. It will then match the built-in > > checksum, and will be used as a cached copy. Then I will try bu

Re: [Qemu-devel] [PATCH v3 14/15] spapr/irq: initialize the IRQ device only once

2019-03-22 Thread Cédric Le Goater
On 3/22/19 3:15 AM, David Gibson wrote: > On Thu, Mar 21, 2019 at 03:49:13PM +0100, Cédric Le Goater wrote: >> Add a check to make sure that the routine initializing the emulated >> IRQ device is called once. We don't have much to test on the XICS >> side, so we introduce a 'static bool'. Not very

Re: [Qemu-devel] [PATCH v3 03/15] spapr/xive: add hcall support when under KVM

2019-03-22 Thread Cédric Le Goater
On 3/22/19 1:51 AM, David Gibson wrote: > On Thu, Mar 21, 2019 at 03:49:02PM +0100, Cédric Le Goater wrote: >> XIVE hcalls are all redirected to QEMU as none are on a fast path. >> When necessary, QEMU invokes KVM through specific ioctls to perform >> host operations. QEMU should have done the nece

Re: [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc

2019-03-22 Thread Markus Armbruster
David Gibson writes: > target/ppc has a lot of old code that doesn't stick to the modern > style guidelines. That means we keep getting checkpatch warnings from > code motions in there, or from people copying the local style rather > than the global style. > > I'm sick of it, so here's a big ser

[Qemu-devel] [Bug 1819649] Re: Win10 Preview Build 18351 - no input

2019-03-22 Thread Mira Limbeck
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1819649 Title: Win10 Preview Build 18351 - no input Status in QEMU: Invalid Bug description: Th

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-22 Thread Vladimir Sementsov-Ogievskiy
On 21.03.2019 20:05, Andrey Shinkevich wrote: > > > On 21/03/2019 13:53, Kevin Wolf wrote: >> Am 20.03.2019 um 18:02 hat Alberto Garcia geschrieben: >>> On Wed 20 Mar 2019 10:16:10 AM CET, Kevin Wolf wrote: > Oh, I see. Let's use a shorter chain for simplicity: > > A <- B <- C

[Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-22 Thread P J P
From: Prasad J Pandit Device tree blob(dtb) file can not be larger than 2MB in size.[*] Add check to avoid loading large dtb files in load_device_tree(), and potential integer(dt_size) overflow. [*] linux.git/tree/Documentation/arm64/booting.txt Reported-by: Kurtis Miller Signed-off-by: Prasad

Re: [Qemu-devel] [PATCH v3 04/15] spapr/xive: add state synchronization with KVM

2019-03-22 Thread Cédric Le Goater
On 3/22/19 2:00 AM, David Gibson wrote: > On Thu, Mar 21, 2019 at 03:49:03PM +0100, Cédric Le Goater wrote: >> This extends the KVM XIVE device backend with 'synchronize_state' >> methods used to retrieve the state from KVM. The HW state of the >> sources, the KVM device and the thread interrupt co

Re: [Qemu-devel] [PATCH v1 0/3 for 4.0] reduce timeouts on Travis

2019-03-22 Thread Stefano Garzarella
On Tue, Mar 19, 2019 at 12:47:57PM +, Alex Bennée wrote: > > Hi, > > This is a fixup patch for 4.0 to help reduce the number of timeouts we > are seeing on Travis. We introduce a new way to slice the target list > and then use that to split up a few of the builds that are getting > close to t

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-22 Thread Peter Maydell
On Thu, 21 Mar 2019 at 15:32, Catherine Ho wrote: > So in igore-shared case, dtb is not required here ? Can you explain what the "ignore-shared" case is? In general, when we reset the system, we want to bring it back to exactly the state that it was in when QEMU was first started. That means we

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-22 Thread Peter Maydell
On Thu, 21 Mar 2019 at 06:20, Peter Xu wrote: > I tried to dig on how x86 implemented the "-kernel" parameter and I > noticed that it's dumping the kernel image into fw_cfg and probably > that's also the reason why this should not be a problem for x86 > because rom reset on x86 won't overwrite the

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 07:38, P J P wrote: > > From: Prasad J Pandit > > Device tree blob(dtb) file can not be larger than 2MB in size.[*] > Add check to avoid loading large dtb files in load_device_tree(), > and potential integer(dt_size) overflow. > > [*] linux.git/tree/Documentation/arm64/boot

[Qemu-devel] [RFT 1/4] virtio-bus: introduce a new method for querying the queue status

2019-03-22 Thread Jason Wang
Sometime we need to check whether a queue is enabled, e.g for vhost, we don't want to start the backend for the virtqueues that is not enabled. So introduce a new method to do this. Signed-off-by: Jason Wang --- include/hw/virtio/virtio-bus.h | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [RFT 4/4] vhost_net: don't start vhost for the virtqueue that is not enabled

2019-03-22 Thread Jason Wang
According to the spec, device should not use the virtqueues that is not enabled. So this patch just try to obey the spec by checking whether queue is enabled before starting it. Signed-off-by: Jason Wang --- hw/virtio/vhost.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/vi

Re: [Qemu-devel] [PATCH for-4.1 v3 00/12] bundle edk2 platform firmware with QEMU

2019-03-22 Thread Laszlo Ersek
On 03/22/19 08:02, Philippe Mathieu-Daudé wrote: > Le ven. 22 mars 2019 00:33, Laszlo Ersek a écrit : > >> On 03/21/19 23:32, Laszlo Ersek wrote: >> >>> Cool, so let me try this. I'm going to download the xz.old file >>> manually. Rename it to just xz. It will then match the built-in >>> checksum

[Qemu-devel] [RFT 2/4] virtio-pci: set enabled for legacy device

2019-03-22 Thread Jason Wang
We don't set enabled for legacy device, this turns out to be an issue if we want to check it through vhost. So just simply set it when setting pa of a virtqueue. Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/virtio/

[Qemu-devel] [RFT 3/4] virtio-pci: implement queue_enabled

2019-03-22 Thread Jason Wang
Signed-off-by: Jason Wang --- hw/virtio/virtio-pci.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 887ee2783c..8bce42ff6f 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @@ -1094,6 +1094,13 @@ static AddressSpace

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-03-22 Thread Jason Wang
On 2019/3/21 下午4:44, Michael S. Tsirkin wrote: On Thu, Mar 14, 2019 at 10:45:25PM +0800, Jason Wang wrote: On 2019/2/25 下午8:33, Michael S. Tsirkin wrote: On Mon, Feb 25, 2019 at 03:47:48PM +0800, Jason Wang wrote: On 2019/2/22 下午12:22, Michael S. Tsirkin wrote: On Thu, Feb 21, 2019 at 10:10

Re: [Qemu-devel] [PATCH] MAINTAINERS: DT: Remove myself and degrade

2019-03-22 Thread Peter Maydell
Alex and I just noticed that we didn't pick up this MAINTAINERS patch for the "Device Tree" section. In the interim Peter Crosthwaite has also removed himself from maintainership, so by default this will move into the "Orphan" state. Is anybody interested in taking up the maintainership role here?

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

2019-03-22 Thread Daniel P . Berrangé
On Thu, Mar 21, 2019 at 08:26:47PM -0700, John G Johnson wrote: > > > > On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: > > > >> On Mar 7, 2019, at 11:27 AM, Stefan Hajnoczi wrote: > >>> > >>> On Thu, Mar 07, 2019 at 02:51:20PM +, Daniel P. Berrangé wrote: > I gu

[Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-22 Thread Jason Wang
Hi: This series try to avoid starting virtqueue that is not enabled. This is done through querying it through a bus specific way and skip the virtqueues if not enabled when starting vhost virtqueues. Only PCI is implemented, maybe it's better to move the enable flag to virito genenic virtqueue st

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-22 Thread Kevin Wolf
Am 21.03.2019 um 18:05 hat Andrey Shinkevich geschrieben: > > > On 21/03/2019 13:53, Kevin Wolf wrote: > > Am 20.03.2019 um 18:02 hat Alberto Garcia geschrieben: > >> On Wed 20 Mar 2019 10:16:10 AM CET, Kevin Wolf wrote: > Oh, I see. Let's use a shorter chain for simplicity: > >

Re: [Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

2019-03-22 Thread Igor Mammedov
On Fri, 22 Mar 2019 08:20:27 +0800 Wei Yang wrote: > On Thu, Mar 21, 2019 at 02:50:42PM +0100, Igor Mammedov wrote: > >On Thu, 21 Mar 2019 08:21:53 +0800 > >Wei Yang wrote: > > > >> arm and i386 has almost the same function acpi_add_rom_blob(), except > >> giving different FWCfgCallback functi

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-22 Thread P J P
+-- On Fri, 22 Mar 2019, Peter Maydell wrote --+ | This document is specific to aarch64, but the part of | QEMU's device tree code being modified here is | architecture independent. | | Cc'ing David Gibson who will probably know if there is | an architecture-independent limit on DTB size we should

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322092806.21838-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190322092806.21838-1-jasow...@redhat.com Subject: [Qemu-devel] [RFT 0/4] Don't start virtqueues that

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-22 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Thu, 21 Mar 2019 at 15:32, Catherine Ho wrote: > > So in igore-shared case, dtb is not required here ? > > Can you explain what the "ignore-shared" case is? It's a migration capability added recently by Yury Kotov, which as you say below, sk

[Qemu-devel] [PATCH V5 3/4] Migration/colo.c: Add the necessary checks for colo_do_failover

2019-03-22 Thread Zhang Chen
From: Zhang Chen Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index dbe2b88807..d1ae2e6d11 100644 --- a/migration/colo.c +++ b/migration/colo

[Qemu-devel] [PATCH V5 0/4] Migration/colo: Fix upstream bugs when occur failover

2019-03-22 Thread Zhang Chen
From: Zhang Chen This series focus on COLO failover bug fix and optimization. V5: - Rewrite patch 4/4 to add new feild in query_colo_status. V4: - Remove merged patch. - Fix grammer issues in patch 2/4 to address markus's comments. - Rebased on upstream code. V3: - Fix grammer issues in p

[Qemu-devel] [PATCH V5 2/4] Migration/colo.c: Add new COLOExitReason to handle all failover state

2019-03-22 Thread Zhang Chen
From: Zhang Chen In this patch we add the processing state for COLOExitReason, because we have to identify COLO in the failover processing state or failover error state. In the way, we can handle all the failover state. We have improved the description of the COLOExitReason by the way. Signed-of

[Qemu-devel] [PATCH V5 1/4] Migration/colo.c: Fix COLO failover status error

2019-03-22 Thread Zhang Chen
From: Zhang Chen When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED. The origin codes misunderstand the FAILOVER_STATUS_REQUIRE. Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert --- migration/colo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) d

[Qemu-devel] [PATCH V5 4/4] Migration/colo.c: Make user obtain the last COLO mode info after failover

2019-03-22 Thread Zhang Chen
From: Zhang Chen Add the last_colo_mode to save the status after failover. This patch can solve the issue that user want to get last colo mode use query_colo_status after failover. Signed-off-by: Zhang Chen --- migration/colo.c| 16 qapi/migration.json | 7 ++- 2 file

Re: [Qemu-devel] [PATCH] device_tree: check device tree blob file size

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 10:11, P J P wrote: > > +-- On Fri, 22 Mar 2019, Peter Maydell wrote --+ > | This document is specific to aarch64, but the part of > | QEMU's device tree code being modified here is > | architecture independent. > | > | Cc'ing David Gibson who will probably know if there is

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322092806.21838-1-jasow...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash tim

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 10:12, Dr. David Alan Gilbert wrote: > Right, so in Catherine's patch there's a simple in_incoming_migration > and checking ramblock_is_ignored Mmm, but I think it is in the wrong place. It is being checked in address_space_write_rom_internal(). Either we want to suppress a

[Qemu-devel] [PATCH] RISC-V: fix single stepping over ret and other branching instructions

2019-03-22 Thread Fabien Chouteau
This patch introduces wrappers around the tcg_gen_exit_tb() and tcg_gen_lookup_and_goto_ptr() functions that handle single stepping, i.e. call gen_exception_debug() when single stepping is enabled. Theses functions are then used instead of the originals, bringing single stepping handling in places

[Qemu-devel] [PATCH 1/4] Clean up wrong usage of FALSE and TRUE in places that use bool from stdbool.h

2019-03-22 Thread JafarAbdi
Signed-off-by: JafarAbdi --- authz/listfile.c | 2 +- qemu.config | 2 + qemu.creator | 1 + qemu.files | 28238 + qemu.includes| 2568 + 5 files changed, 30810 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH 2/4] Clean up wrong usage of FALSE and TRUE in places that use bool from stdbool.h

2019-03-22 Thread JafarAbdi
Signed-off-by: JafarAbdi --- hw/tpm/tpm_tis.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index fd183e8..c1eb094 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -611,7 +611,7 @@ static void tpm_tis_mmio_write(void *opaque, hw

[Qemu-devel] [PATCH 3/4] Clean up wrong usage of FALSE and TRUE in places that use bool from stdbool.h

2019-03-22 Thread JafarAbdi
Signed-off-by: JafarAbdi --- tests/libqos/pci-pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c index 4ab16fa..407d8af 100644 --- a/tests/libqos/pci-pc.c +++ b/tests/libqos/pci-pc.c @@ -125,7 +125,7 @@ void qpci_init_pc(QPCIBusP

[Qemu-devel] [PATCH 4/4] Clean up wrong usage of FALSE and TRUE in places that use bool from stdbool.h

2019-03-22 Thread JafarAbdi
Signed-off-by: JafarAbdi --- tests/libqos/pci-spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/pci-spapr.c b/tests/libqos/pci-spapr.c index 6925925..58ba27a 100644 --- a/tests/libqos/pci-spapr.c +++ b/tests/libqos/pci-spapr.c @@ -156,7 +156,7 @@ void qpci_i

Re: [Qemu-devel] [PATCH] acpi: verify file entries in bios_linker_loader_add_pointer()

2019-03-22 Thread Igor Mammedov
On Thu, 21 Mar 2019 20:13:49 + Liam Merwick wrote: > The callers to bios_linker_find_file() assert that the file entry returned > is not NULL, except for those in bios_linker_loader_add_pointer(). Add two > asserts in that case for completeness and to facilitate static code analysis. > > Si

Re: [Qemu-devel] [BUG] [low severity] a strange appearance of message involving slirp while doing "empty" make

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 04:59, Thomas Huth wrote: > On 20/03/2019 22.08, Aleksandar Markovic wrote: > > $ make > > make[1]: Entering directory '/home/build/malta-mips64r6/qemu-4.0/slirp' > > make[1]: Nothing to be done for 'all'. > > make[1]: Leaving directory '/home/build/malta-mips64r6/qemu-4.0/s

[Qemu-devel] question about 9pfs fsdriver types

2019-03-22 Thread П , Алексей
Hi there. Cannot find any info and examples about "proxy" and "handle" types of fsdriver of virtfs. Can anyone advise me description of? Witrh regards/

[Qemu-devel] [PATCH v1] exec: check the range in the address_space_unmap routine

2019-03-22 Thread Dima Stepanov
In case of the virtio-blk communication, can get the following assertion for the specifically crafted virtio packet: qemu-system-x86_64: exec.c:3725: address_space_unmap: Assertion `mr != NULL' failed. This assertion is triggered if the length of the first descriptor in the block request chain

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Jan Kiszka
On 07.12.18 10:01, Luc Michel wrote: > Add the gdb_first_attached_cpu() and gdb_next_attached_cpu() to iterate > over all the CPUs in currently attached processes. > > Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to > iterate over CPUs of a given process. > > Use them to add m

[Qemu-devel] [PATCH 4/6] file-posix: Support BDRV_REQ_NO_FALLBACK for zero writes

2019-03-22 Thread Kevin Wolf
We know that the kernel implements a slow fallback code path for BLKZEROOUT, so if BDRV_REQ_NO_FALLBACK is given, we shouldn't call it. The other operations we call in the context of .bdrv_co_pwrite_zeroes should usually be quick, so no modification should be needed for them. If we ever notice that

[Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Kevin Wolf
If qemu-img convert sees that the target image isn't zero-initialised yet, it tries to do an efficient zero write for the whole image first to save the overhead of repeated explicit zero writes during the conversion. Obviously, this provides only an advantage if the pre-zeroing is actually efficien

[Qemu-devel] [PATCH 6/6] qemu-io: Add write -n for BDRV_REQ_NO_FALLBACK

2019-03-22 Thread Kevin Wolf
This makes the new BDRV_REQ_NO_FALLBACK flag available in the qemu-io write command. Signed-off-by: Kevin Wolf --- qemu-io-cmds.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index 35dcdcf413..09750a23ce 100644 --- a/qemu-io-c

Re: [Qemu-devel] [PATCH v1] exec: check the range in the address_space_unmap routine

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 13:19, Dima Stepanov wrote: > > In case of the virtio-blk communication, can get the following assertion > for the specifically crafted virtio packet: > qemu-system-x86_64: exec.c:3725: address_space_unmap: Assertion `mr != > NULL' failed. > This assertion is triggered i

[Qemu-devel] [PATCH 5/6] qemu-img: Use BDRV_REQ_NO_FALLBACK for pre-zeroing

2019-03-22 Thread Kevin Wolf
If qemu-img convert sees that the target image isn't zero-initialised yet, it tries to do an efficient zero write for the whole image first to save the overhead of repeated explicit zero writes during the conversion. Obviously, this provides only an advantage if the pre-zeroing is actually efficien

[Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-03-22 Thread Jens Freimann
This is another attempt at implementing the host side of the net_failover concept (https://www.kernel.org/doc/html/latest/networking/net_failover.html) The general idea is that we have a pair of devices, a vfio-pci and a emulated device. Before migration the vfio device is unplugged and data flows

[Qemu-devel] [PATCH 2/6] block: Add BDRV_REQ_NO_FALLBACK

2019-03-22 Thread Kevin Wolf
For qemu-img convert, we want an operation that zeroes out the whole image if this can be done efficiently, but that returns an error otherwise so we don't write explicit zeroes and immediately overwrite them with the real data, potentially doubling the amount of data to be written. Signed-off-by:

[Qemu-devel] [PATCH 3/6] block: Advertise BDRV_REQ_NO_FALLBACK in filter drivers

2019-03-22 Thread Kevin Wolf
Filter drivers that support .bdrv_co_pwrite_zeroes can safely advertise BDRV_REQ_NO_FALLBACK because they just forward the request flags to their child node. Signed-off-by: Kevin Wolf --- block/blkdebug.c | 2 +- block/copy-on-read.c | 7 +++ block/mirror.c | 3 ++- block/raw-forma

[Qemu-devel] [RFC PATCH 1/2] qdev/qbus: Add hidden device support

2019-03-22 Thread Jens Freimann
From: Sameeh Jubran Signed-off-by: Jens Freimann --- hw/core/qdev.c | 27 hw/pci/pci.c | 1 + include/hw/pci/pci.h | 2 ++ include/hw/qdev-core.h | 8 +++ qdev-monitor.c | 48 ++ vl.c

[Qemu-devel] [RFC PATCH 2/2] net/virtio: add failover support

2019-03-22 Thread Jens Freimann
From: Sameeh Jubran --- hw/net/virtio-net.c| 95 ++ include/hw/virtio/virtio-net.h | 7 +++ 2 files changed, 102 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 7e2c2a6f6a..880420a673 100644 --- a/hw/net/virtio-net.c +++ b/

[Qemu-devel] [PATCH 1/6] block: Remove error messages in bdrv_make_zero()

2019-03-22 Thread Kevin Wolf
There is only a single caller of bdrv_make_zero(), which is qemu-img convert. If the function fails, we just fall back to a different method of zeroing out blocks on the target image. There is no good reason to print error messages on stderr when the higher level operation will actually succeed. S

Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322134447.14831-1-jfreim...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190322134447.14831-1-jfreim...@redhat.com Subject: [Qemu-devel] [RFC PATCH 0/2] implem

Re: [Qemu-devel] [PATCH 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 8:21 AM, Kevin Wolf wrote: > If qemu-img convert sees that the target image isn't zero-initialised > yet, it tries to do an efficient zero write for the whole image first > to save the overhead of repeated explicit zero writes during the > conversion. Obviously, this provides only an adv

Re: [Qemu-devel] question about 9pfs fsdriver types

2019-03-22 Thread Greg Kurz
On Fri, 22 Mar 2019 11:57:04 +0200 "П, Алексей" wrote: > Hi there. Cannot find any info and examples about "proxy" and "handle" > types of fsdriver of virtfs. Can anyone advise me description of? > Witrh regards/ Hi, The "handle" backend was deprecated in QEMU 2.12, for various reasons... requi

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Jan Kiszka
On 22.03.19 15:01, Luc Michel wrote: On 3/22/19 2:29 PM, Jan Kiszka wrote: On 07.12.18 10:01, Luc Michel wrote: Add the gdb_first_attached_cpu() and gdb_next_attached_cpu() to iterate over all the CPUs in currently attached processes. Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_proc

[Qemu-devel] [PATCH 1/3] tests: refactor file monitor test to make it more understandable

2019-03-22 Thread Daniel P . Berrangé
The current file monitor unit tests are too clever for their own good making it hard to understand the desired output. Instead of trying to infer the expected events, explicitly list the events we expect in the operation sequence. Instead of dynamically building a matrix of tests, just have one g

Re: [Qemu-devel] [PATCH RFC v3 00/11] Add RX archtecture support

2019-03-22 Thread Yoshinori Sato
On Thu, 21 Mar 2019 10:35:07 +0900, Richard Henderson wrote: > > On 3/20/19 7:05 AM, Yoshinori Sato wrote: > > OK. fixed another way. > > But RX big-endian mode only data access. > > So operand value always little-endian order. > > Oh that is convenient. > Therefore the operand can always be put

[Qemu-devel] [PATCH 3/3] filemon: fix watch IDs to avoid potential wraparound issues

2019-03-22 Thread Daniel P . Berrangé
Watch IDs are allocated from incrementing a int counter against the QFileMonitor object. In very long life QEMU processes with a huge amount of USB MTP activity creating & deleting directories it is just about conceivable that the int counter can wrap around. This would result in incorrect behaviou

Re: [Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length ISA

2019-03-22 Thread Yoshinori Sato
On Thu, 21 Mar 2019 10:43:37 +0900, Richard Henderson wrote: > > On 3/20/19 7:27 AM, Yoshinori Sato wrote: > > Hi. > > I found some problem in tested RX instructions. > > It is usable in RX instructions, but I think that there > > is a better fix because I am not familiar with Python. > > The pat

Re: [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets

2019-03-22 Thread Luc Michel
On 3/22/19 2:29 PM, Jan Kiszka wrote: > On 07.12.18 10:01, Luc Michel wrote: >> Add the gdb_first_attached_cpu() and gdb_next_attached_cpu() to iterate >> over all the CPUs in currently attached processes. >> >> Add the gdb_first_cpu_in_process() and gdb_next_cpu_in_process() to >> iterate over CPU

[Qemu-devel] [PATCH 0/3] filemon: various fixes / improvements to file monitor for USB MTP

2019-03-22 Thread Daniel P . Berrangé
Previously posted in 2 separate pieces at https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04885.html https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05833.html And a failed pull request https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg06035.html The last patch ha

[Qemu-devel] [PATCH 2/3] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-03-22 Thread Daniel P . Berrangé
The watch IDs are mistakenly only unique within the scope of the directory being monitored. This is not useful for clients which are monitoring multiple directories. They require watch IDs to be unique globally within the QFileMonitor scope. Reviewed-by: Marc-André Lureau Tested-by: Bandan Das R

Re: [Qemu-devel] [PATCH for-4.0? 0/6] block: Fix slow pre-zeroing in qemu-img convert

2019-03-22 Thread Eric Blake
On 3/22/19 9:21 AM, Eric Blake wrote: > On 3/22/19 8:21 AM, Kevin Wolf wrote: >> If qemu-img convert sees that the target image isn't zero-initialised >> yet, it tries to do an efficient zero write for the whole image first >> to save the overhead of repeated explicit zero writes during the >> conv

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-22 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 22 Mar 2019 at 10:12, Dr. David Alan Gilbert > wrote: > > Right, so in Catherine's patch there's a simple in_incoming_migration > > and checking ramblock_is_ignored > > Mmm, but I think it is in the wrong place. It is being checked > in

Re: [Qemu-devel] [PULL 0/5] x86 queue for -rc1

2019-03-22 Thread Peter Maydell
On Thu, 21 Mar 2019 at 19:36, Eduardo Habkost wrote: > > The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: > > Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) > > are available in the Git repository at: > > git://github.com/ehabkost/qemu.git tags/x8

Re: [Qemu-devel] [qemu-s390x] [PATCH] hw/s390x: fix clang compilation on 32bit machines

2019-03-22 Thread Halil Pasic
On Mon, 18 Mar 2019 22:08:50 +0100 Philippe Mathieu-Daudé wrote: > Le lun. 18 mars 2019 11:34, Marcel Apfelbaum a > écrit : > > > Hi Christian, > > > > On 3/18/19 11:27 AM, Christian Borntraeger wrote: > > > > > > On 16.03.19 12:09, Philippe Mathieu-Daudé wrote: > > >> Hi Marcel, > > >> > > >>

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-22 Thread Alberto Garcia
On Thu 21 Mar 2019 03:51:12 PM CET, Alberto Garcia wrote: > I was checking the tests that run commit and stream in parallel in > 030, but they do commit on the upper images and stream on the lower > ones, so that's safe. I'll try to run them the other way around > because we might have a problem

[Qemu-devel] [PATCH 1/4] target/mips: Fix . MSA instructions for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Load and store MSA instructions when executed on a MIPS big endian CPU, didn't change the endianness, and were behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/op_helper.c | 79 ++--- 1 file cha

[Qemu-devel] [PATCH 0/4] target/mips: Add support for MSA instructions on a big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Change endianness when the host machine has a big endian CPU, for MSA instructions ., copy_., insert.. Mateja Marjanovic (4): target/mips: Fix . MSA instructions for MIPS big endian host target/mips: Fix copy_s. for MIPS big endian host target/mips: Fix copy_u.

[Qemu-devel] [PATCH 2/4] target/mips: Fix copy_s. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Signed element copy from MSA registers to GPR when executed on a MIPS big endian CPU, didn't pick the right element, and was behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/msa_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff

Re: [Qemu-devel] [PATCH] RISC-V: fix single stepping over ret and other branching instructions

2019-03-22 Thread Richard Henderson
On 3/22/19 4:22 AM, Fabien Chouteau wrote: > +/* Wrapper around tcg_gen_exit_tb that handles single stepping */ > +static void exit_tb(DisasContext *ctx, TranslationBlock *tb, unsigned idx) > +{ > +if (ctx->base.singlestep_enabled) { > +gen_exception_debug(); > +} else { > +

[Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Inserting from GPR to an element in a MSA register when executed on a MIPS big endian CPU, didn't pick the right element, and was behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/msa_helper.c | 9 + 1 file changed, 9 insertions(+)

Re: [Qemu-devel] [PATCH 0/2] trace: fix compilation issues for QEMU 4.0.0

2019-03-22 Thread Stefan Hajnoczi
On Thu, Mar 21, 2019 at 05:08:29PM +, Stefan Hajnoczi wrote: > These patches fix compilation issues spotted by Markus Armbruster > . See the patches for details. > > Stefan Hajnoczi (2): > trace: handle tracefs path truncation > trace: avoid SystemTap dtrace(1) warnings on empty files >

[Qemu-devel] [PATCH 3/4] target/mips: Fix copy_u. for MIPS big endian host

2019-03-22 Thread Mateja Marjanovic
From: Mateja Marjanovic Unsigned element copy from MSA registers to GPR when executed on a MIPS big endian CPU, didn't pick the right element, and was behaving like on little endian. Signed-off-by: Mateja Marjanovic --- target/mips/msa_helper.c | 7 +++ 1 file changed, 7 insertions(+) dif

[Qemu-devel] [PATCH 1/3] target/arm: fix crash on pmu register access

2019-03-22 Thread Andrew Jones
Fix a QEMU NULL derefence that occurs when the guest attempts to enable PMU counters with a non-v8 cpu model or a v8 cpu model which has not configured a PMU. Fixes: 4e7beb0cc0f3 ("target/arm: Add a timer to predict PMU counter overflow") Signed-off-by: Andrew Jones --- target/arm/helper.c | 4 +

Re: [Qemu-devel] [PATCH 0/5] trace-events: Clean up

2019-03-22 Thread Stefan Hajnoczi
On Thu, Mar 14, 2019 at 07:09:24PM +0100, Markus Armbruster wrote: > Markus Armbruster (5): > trace-events: Consistently point to docs/devel/tracing.txt > trace-events: Shorten file names in comments > scripts/cleanup-trace-events: Update for current practice > trace-events: Delete unused t

Re: [Qemu-devel] [PATCH] qcow2: avoid lseek on block_status if possible

2019-03-22 Thread Vladimir Sementsov-Ogievskiy
25.01.2019 17:21, Vladimir Sementsov-Ogievskiy wrote: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where are holes and

[Qemu-devel] [PATCH 2/3] target/arm: cortex-a7 and cortex-a15 have pmus

2019-03-22 Thread Andrew Jones
cortex-a7 and cortex-a15 have pmus (PMUv2) and they advertise them in ID_DFR0. Let's allow them to function. This also enables the pmu cpu property to work with these cpu types, i.e. we can now do '-cpu cortex-a15,pmu=off' to remove the pmu. Signed-off-by: Andrew Jones --- target/arm/cpu.c | 3 +

[Qemu-devel] [PATCH 0/3] target/arm: pmu fixes

2019-03-22 Thread Andrew Jones
The first two patches fix a regression I found when running the arm (as opposed to arm64) pmu kvm-unit-tests test on tcg, $ git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git $ cd kvm-unit-tests $ ./configure --arch=arm --cross-prefix=arm-linux-gnu- $ make -j $ export QEM

[Qemu-devel] [PATCH v4 2/8] slirp: relicense GPL files to BSD-3

2019-03-22 Thread Marc-André Lureau
In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp/ wit

[Qemu-devel] [PATCH v4 8/8] slirp: is not maintained by Kelly Price for a long time

2019-03-22 Thread Marc-André Lureau
slirp has been maintained by the QEMU maintainers and will be maintained under an independent project soon. Reviewed-by: Eric Blake Signed-off-by: Kelly Price Signed-off-by: Marc-André Lureau --- slirp/COPYRIGHT | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/COPYRIGHT b/slirp/COPYR

[Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Marc-André Lureau
Hi, In order to make slirp a standalone project, the project must have a clear license, and be compatible with the GPL or LGPL. Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), slirp is BSD-3. But new files have been added under slirp

[Qemu-devel] [PATCH v4 4/8] slirp: clarify license of slirp files using SPDX: explicit MIT

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit MIT license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/util.h | 1 + slirp/src/arp_table.c | 1 + slirp/src/bootp.c | 1 + slirp/src/dnssearch.c | 1 + slirp/src/slirp.c |

[Qemu-devel] [PATCH v4 7/8] slirp: remove reference to COPYRIGHT file

2019-03-22 Thread Marc-André Lureau
The slirp COPYRIGHT file is a BSD-3 license. Instead of referring to another project file, the SPDX license notice present in all source files states that unequivocally. Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake --- slirp/src/debug.h | 3 --- slirp/src/if.h | 3 ---

Re: [Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Samuel Thibault
Marc-André Lureau, le ven. 22 mars 2019 17:46:12 +0100, a ecrit: > On Fri, Mar 22, 2019 at 5:43 PM Marc-André Lureau > wrote: > > > > Hi, > > > > In order to make slirp a standalone project, the project must have a > > clear license, and be compatible with the GPL or LGPL. > > > > Since commit 2f5

[Qemu-devel] [PATCH v4 3/8] slirp: clarify license of slirp files using SPDX: explicit BSD

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with explicit 3-clause BSD license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/dhcpv6.h | 1 + slirp/src/ip.h | 1 + slirp/src/ip_icmp.h| 1 + slirp/src/mbuf.h | 1 + slirp/src/

[Qemu-devel] [PATCH v4 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License

2019-03-22 Thread Marc-André Lureau
According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the advertising clause from the slirp license"), Danny Gasparovski gave permission to license slirp code under 3-clause BSD license: Subject: RE: Slirp license Date: Thu, 8 Jan 2009 10:51:00 +1100 From: "Gasparovski,

[Qemu-devel] [PATCH v4 6/8] slirp: clarify license of slirp files using SPDX: implicit via unstated

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files without explicit license header. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/bootp.h | 1 + slirp/src/ip6.h| 1 + slirp/src/ip6_icmp.h | 1 + slirp/src/libslirp.h | 1 + slirp/src/slirp.h

Re: [Qemu-devel] [PATCH 0/3] target/arm: pmu fixes

2019-03-22 Thread Andrew Jones
On Fri, Mar 22, 2019 at 05:23:30PM +0100, Andrew Jones wrote: > The first two patches fix a regression I found when running > the arm (as opposed to arm64) pmu kvm-unit-tests test on tcg, > > $ git clone git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git > $ cd kvm-unit-tests > $ ./con

[Qemu-devel] [PATCH v4 5/8] slirp: clarify license of slirp files using SPDX: implicit via COPYRIGHT

2019-03-22 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files with reference to BSD license from slirp COPYRIGHT file. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- slirp/src/debug.h | 1 + slirp/src/if.h | 1 + slirp/src/main.h | 1 + slirp/src/misc.h | 1 + slirp/src/sb

Re: [Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Marc-André Lureau
Hi On Fri, Mar 22, 2019 at 5:43 PM Marc-André Lureau wrote: > > Hi, > > In order to make slirp a standalone project, the project must have a > clear license, and be compatible with the GPL or LGPL. > > Since commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove the > advertising clause from the

Re: [Qemu-devel] target/arm: kvm-unit-tests gicv2 test failures on tcg

2019-03-22 Thread Peter Maydell
On Fri, 22 Mar 2019 at 16:40, Andrew Jones wrote: > Hi TCG GIC developers, > > There are a few gicv2 test failures when running over TCG that we don't > see when running over KVM. I don't believe these are regressions - I'm > pretty sure they've been failing since Andre first introduced the tests.

[Qemu-devel] [PATCH] target/arm: default config

2019-03-22 Thread Andrew Jones
In the kconfig shuffle arm lost pci-testdev which is used by kvm-unit-tests. Let's add it back. Signed-off-by: Andrew Jones --- default-configs/arm-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak index 2a7efc11674a

[Qemu-devel] target/arm: kvm-unit-tests gicv2 test failures on tcg

2019-03-22 Thread Andrew Jones
Hi TCG GIC developers, There are a few gicv2 test failures when running over TCG that we don't see when running over KVM. I don't believe these are regressions - I'm pretty sure they've been failing since Andre first introduced the tests. I'm just pointing them out now in case anybody would like

[Qemu-devel] [PATCH 3/3] target/arm: make pmccntr_op_start/finish static

2019-03-22 Thread Andrew Jones
These functions are not used outside helper.c Signed-off-by: Andrew Jones --- target/arm/cpu.h| 11 --- target/arm/helper.c | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 5f23c621325c..d4d2836923df 100644 --- a/tar

Re: [Qemu-devel] [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host

2019-03-22 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH 4/4] target/mips: Fix insert. for MIPS big endian host > > From: Mateja Marjanovic > > Inserting from GPR to an element in a MSA register when > executed on a MIPS big endian CPU, didn't pick the > right element, and was behaving like on little endian

  1   2   >