[Qemu-devel] Evolve or go extinct (was: [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.)

2019-03-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote: >> On Thu, 7 Mar 2019 10:07:05 + >> Daniel P. Berrangé wrote: >> >> > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote: >> > > On Wed, 6 Mar 2019 18:16:08 + >> > > Daniel P. Berrangé

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-03-20 Thread chenxi He
On Wed, 20 Mar 2019 at 13:07, Peter Xu wrote: > > On Tue, Mar 19, 2019 at 11:49:22AM -0400, Catherine Ho wrote: > > Commit 18269069c310 ("migration: Introduce ignore-shared capability") > > addes a ignore-shared capability to bypass the shared ramblock (e,g, > > membackend + numa node). It does go

Re: [Qemu-devel] [libvirt] Evolve or go extinct (was: [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.)

2019-03-20 Thread Peter Krempa
On Wed, Mar 20, 2019 at 07:46:33 +0100, Markus Armbruster wrote: [...] > I'm with Igor on this one. I'm all for QEMU going the extra mile to > help libvirt, simply because that helps a very large fraction of our > users. I'm now asking libvirt to extend the courtesy back to QEMU. > > Please si

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-20 Thread Gerd Hoffmann
On Wed, Mar 20, 2019 at 12:32:42AM +0100, BALATON Zoltan wrote: > On Mon, 18 Mar 2019, Gerd Hoffmann wrote: > > > Does it work with the latest patch for you? > > > > No (testing with radeonfb.ko). > > I'm confused. You said here that it works with radeonfb with your patch: > http://lists.nongnu.o

Re: [Qemu-devel] Evolve or go extinct (was: [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.)

2019-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2019 at 07:46:33AM +0100, Markus Armbruster wrote: > We're going in circles. Igor keeps telling you QEMU needs to shed dead > weight, badly. In Igor's words: > > We really need to figure out how to introduce breaking change on > management (CLI) side* in QEMU and make it

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-20 Thread Kevin Wolf
Am 19.03.2019 um 17:19 hat Alberto Garcia geschrieben: > On Mon 18 Mar 2019 04:25:10 PM CET, Vladimir Sementsov-Ogievskiy > wrote: > >> So what we have now is: > >> > >> A <- B <- C <- D <- E <- F <- G <- H <- I > >> > >> and we can launch four parallel block-stream jobs: > >> > >> Fro

[Qemu-devel] [PATCH] hw/i386/Kconfig: PC uses I8257, not I82374

2019-03-20 Thread Paolo Bonzini
CONFIG_I82374 is not needed for PC machines, since they create i8257 directly instead. Reported-by: Miroslav Rezanina Signed-off-by: Paolo Bonzini --- hw/i386/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 4e4415fc88..756b1eaef8 100644 --- a/h

Re: [Qemu-devel] [PATCH for 4.0] linux-user: conditionally define gettid as it is present in new glibc

2019-03-20 Thread Daniel P . Berrangé
On Tue, Mar 19, 2019 at 05:16:17PM +, Peter Maydell wrote: > On Tue, 19 Mar 2019 at 17:08, Daniel P. Berrangé wrote: > > > > The glibc-2.29.9000-6.fc31.x86_64 package finally includes the gettid > > function as part of unistd.h when __USE_GNU is defined. This clashes > > with linux-user code w

[Qemu-devel] [PATCH] prep: do not select I82374

2019-03-20 Thread Paolo Bonzini
It is only needed through I82378, which also selects it. Signed-off-by: Paolo Bonzini --- hw/ppc/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 73b473ca24..bbe5a64865 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -64,7 +64,6 @@ config PREP

Re: [Qemu-devel] [PATCH 1/2] iotests: 030 TestParallelOps non-shared base node

2019-03-20 Thread Vladimir Sementsov-Ogievskiy
20.03.2019 12:16, Kevin Wolf wrote: > Am 19.03.2019 um 17:19 hat Alberto Garcia geschrieben: >> On Mon 18 Mar 2019 04:25:10 PM CET, Vladimir Sementsov-Ogievskiy >> wrote: So what we have now is: A <- B <- C <- D <- E <- F <- G <- H <- I and we can launch four paralle

Re: [Qemu-devel] [PATCH V3 7/7] Migration/colo.c: Make user obtain the COLO mode info after failover

2019-03-20 Thread Zhang, Chen
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Tuesday, March 19, 2019 10:57 PM To: Zhang, Chen Cc: Li Zhijian ; Zhang Chen ; Juan Quintela ; zhanghailiang ; Markus Armbruster ; Eric Blake ; qemu-dev Subject: Re: [PATCH V3 7/7] Migration/colo.c: M

Re: [Qemu-devel] What should a virtual board emulate? (was: [PATCH] mips-fulong2e: obey -vga none)

2019-03-20 Thread Philippe Mathieu-Daudé
Le mer. 20 mars 2019 07:13, Markus Armbruster a écrit : > BALATON Zoltan writes: > > > On Tue, 19 Mar 2019, Paolo Bonzini wrote: > >> Do not create an ATI VGA if "-vga none" was passed on the command line. > >> > >> Cc: BALATON Zoltan > > > > Thanks, I did not know about this variable. Although

Re: [Qemu-devel] [PATCH 1/1] block_crypto_co_create_generic: clean up created file on failure

2019-03-20 Thread Daniel P . Berrangé
On Tue, Mar 19, 2019 at 07:03:30PM -0300, Daniel Henrique Barboza wrote: > When using a non-UTF8 secret to create a volume using qemu-img, the > following error happens: > > $ qemu-img create -f luks --object > secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o > key-secret=vol

[Qemu-devel] [PATCH] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-20 Thread Vladimir Sementsov-Ogievskiy
Test that mirror job actually resume on resume command after being automatically paused on ENOSPC error. It's a follow-up test for 8d9648cbf3e "blockjob: fix user pause in block_job_error_action" Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/248 | 77 +++

Re: [Qemu-devel] [PATCH] blockjob: fix user pause in block_job_error_action

2019-03-20 Thread Vladimir Sementsov-Ogievskiy
19.03.2019 14:01, Kevin Wolf wrote: > Am 19.03.2019 um 10:24 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Job (especially mirror) may call block_job_error_action several >> times before actual pause if it has several in-flight requests. >> >> block_job_error_action will call job_pause more than

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Tue, 19 Mar 2019 14:51:07 + Daniel P. Berrangé wrote: > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote: > > On Thu, 7 Mar 2019 10:07:05 + > > Daniel P. Berrangé wrote: > > > > > On Wed, Mar 06, 2019 at 07:54:17PM +0100, Igor Mammedov wrote: > > > > On Wed, 6 Mar 20

Re: [Qemu-devel] [PATCH] hw/i386/Kconfig: PC uses I8257, not I82374

2019-03-20 Thread Stefano Garzarella
On Wed, Mar 20, 2019 at 10:32:37AM +0100, Paolo Bonzini wrote: > CONFIG_I82374 is not needed for PC machines, since they create > i8257 directly instead. > > Reported-by: Miroslav Rezanina > Signed-off-by: Paolo Bonzini > --- > hw/i386/Kconfig | 1 - > 1 file changed, 1 deletion(-) Reviewed-by

Re: [Qemu-devel] [PATCH v2 04/12] roms/edk2: advance to tag edk2-stable201903

2019-03-20 Thread Laszlo Ersek
(first of all, sorry about the delayed response, I've been away for a few days, and then I got busy with something urgent -- thanks everyone for the feedback) On 03/14/19 19:29, Eric Blake wrote: > On 3/14/19 1:02 PM, Philippe Mathieu-Daudé wrote: >> On 3/13/19 10:00 PM, Laszlo Ersek wrote: >>> Up

Re: [Qemu-devel] What should a virtual board emulate? (was: [PATCH] mips-fulong2e: obey -vga none)

2019-03-20 Thread Paolo Bonzini
On 20/03/19 11:03, Philippe Mathieu-Daudé wrote: > > > -display/-vga options suffers same clarity problems than -net. Is it a > card device or a cable linking to a network? Here is it a card device or > a cable connecting a monitor display? -display is a cable, -vga is a card ("-nic none" is a

Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU

2019-03-20 Thread Laszlo Ersek
Hi Michael, On 03/16/19 15:56, Michael Tokarev wrote: > 14.03.2019 0:00, Laszlo Ersek wrote: >> Repo:   https://github.com/lersek/qemu.git >> Branch: edk2_build_v2 >> >> Version 1, that is: >>    [Qemu-devel] [PATCH 00/10] bundle edk2 platform firmware with QEMU > ... > > Hmm. Why to do so? Isn't

Re: [Qemu-devel] [PATCH v6 1/2] hw/arm: Add arm SBSA reference machine, skeleton part

2019-03-20 Thread Ard Biesheuvel
On Mon, 18 Mar 2019 at 03:39, Hongbo Zhang wrote: > > On Fri, 15 Mar 2019 at 18:41, Ard Biesheuvel > wrote: > > > > On Fri, 15 Mar 2019 at 11:08, Hongbo Zhang wrote: > > > > > > For the Aarch64, there is one machine 'virt', it is primarily meant to > > > run on KVM and execute virtualization wo

Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU

2019-03-20 Thread Laszlo Ersek
On 03/15/19 17:42, Philippe Mathieu-Daudé wrote: > Hi, > > From my previous experience with the tests/ patches, I understood we > could still send PR that improve testing after soft freeze. > This series doesn't modify the QEMU binaries, it add EDK2 firmware blobs > in roms/ and rules to rebuild t

Re: [Qemu-devel] [PATCH v2 09/12] pc-bios: document the edk2 firmware images; add firmware descriptors

2019-03-20 Thread Laszlo Ersek
On 03/15/19 12:31, Daniel P. Berrangé wrote: > On Wed, Mar 13, 2019 at 10:00:54PM +0100, Laszlo Ersek wrote: >> Update the README file with information on the images added previously, >> and provide firmware descriptor documents that conform to >> "docs/interop/firmware.json". >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH] prep: do not select I82374

2019-03-20 Thread Stefano Garzarella
On Wed, Mar 20, 2019 at 10:35:05AM +0100, Paolo Bonzini wrote: > It is only needed through I82378, which also selects it. > > Signed-off-by: Paolo Bonzini > --- > hw/ppc/Kconfig | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Stefano Garzarella

Re: [Qemu-devel] [PATCH v3] hw/acpi: extract acpi_add_rom_blob()

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 08:37:14 +0800 Wei Yang wrote: > On Tue, Mar 19, 2019 at 10:00:38AM +0100, Igor Mammedov wrote: > >On Tue, 19 Mar 2019 08:45:23 +0800 > >Wei Yang wrote: > > > >> On Mon, Mar 18, 2019 at 01:39:12PM +0100, Igor Mammedov wrote: > >> >On Fri, 15 Mar 2019 08:44:32 +0800 > >> >

Re: [Qemu-devel] [PATCH] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-20 Thread Kevin Wolf
Am 20.03.2019 um 10:59 hat Vladimir Sementsov-Ogievskiy geschrieben: > Test that mirror job actually resume on resume command after being > automatically paused on ENOSPC error. > > It's a follow-up test for 8d9648cbf3e > "blockjob: fix user pause in block_job_error_action" > > Signed-off-by:

Re: [Qemu-devel] Evolve or go extinct

2019-03-20 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 20, 2019 at 07:46:33AM +0100, Markus Armbruster wrote: >> We're going in circles. Igor keeps telling you QEMU needs to shed dead >> weight, badly. In Igor's words: >> >> We really need to figure out how to introduce breaking change on >> managem

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-20 Thread Mateja Marjanovic
On 19.3.19. 16:27, Peter Maydell wrote: On Tue, 19 Mar 2019 at 15:22, Mateja Marjanovic wrote: From: Mateja Marjanovic Wrong type of NaN was generated for IEEE 754-2008 by MADDF. and MSUBF. instructions when the arguments were (inf, zero, nan) or (zero, inf, nan). These instructions were te

Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

2019-03-20 Thread Mateja Marjanovic
On 19.3.19. 23:02, Alex Bennée wrote: Aleksandar Markovic writes: From: Peter Maydell Subject: Re: [PATCH v3] target/mips: Fix minor bug in FPU On Tue, 19 Mar 2019 at 19:21, Aleksandar Markovic wrote: From: Mateja Marjanovic Subject: [PATCH v3] target/mips: Fix minor bug in FPU From: M

[Qemu-devel] [PATCH v8 0/7] vhost-user-blk: Add support for backend reconnecting

2019-03-20 Thread elohimes
From: Xie Yongji This patchset is aimed at supporting qemu to reconnect vhost-user-blk backend after vhost-user-blk backend crash or restart. The patch 1,2,3 introduce started flag to VirtioDevice to fix possible guest hung after migration for virtio 1.0 transitional devices. The patch 4,5,6 su

[Qemu-devel] [PATCH v8 3/7] vhost-user-blk: Use started flag in vhost_user_blk_set_status()

2019-03-20 Thread elohimes
From: Xie Yongji Use started flag in vhost_user_blk_set_status() to decide if starting vhost-user backend or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- hw/block/vhost-user-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/vhost-user-blk.c b

[Qemu-devel] [PATCH v8 1/7] virtio: Introduce started flag to VirtioDevice

2019-03-20 Thread elohimes
From: Xie Yongji The virtio 1.0 transitional devices support driver uses the device before setting the DRIVER_OK status bit. So we introduce a started flag to indicate whether driver has started the device or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- hw/virtio/virtio.c

[Qemu-devel] [PATCH v8 2/7] virtio: Use started flag in virtio_vmstate_change()

2019-03-20 Thread elohimes
From: Xie Yongji Currently, we use DRIVER_OK status bit to check whether guest driver has started the device in virtio_vmstate_change(). But it's not the case for virtio 1.0 transitional devices. If migration completes between kicking virtqueue and setting VIRTIO_CONFIG_S_DRIVER_OK, guest may be

[Qemu-devel] [PATCH v8 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-20 Thread elohimes
From: Xie Yongji Since we now support the message VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart safely because it can track inflight I/O in shared memory. This patch allows qemu to reconnect the backend after connection closed. Signed-off-by: Xie Yongj

[Qemu-devel] [PATCH v8 4/7] vhost-user-blk: Only start vhost-user backend with the first kick

2019-03-20 Thread elohimes
From: Xie Yongji We should only start vhost-user backend at the first kick for virtio 1.0 transitional devices. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- hw/block/vhost-user-blk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/block/vhost-user-blk.c b/hw/

Re: [Qemu-devel] What should a virtual board emulate? (was: [PATCH] mips-fulong2e: obey -vga none)

2019-03-20 Thread BALATON Zoltan
On Wed, 20 Mar 2019, Markus Armbruster wrote: For better or worse, we have a whole bunch of global variables (manipulated with command line options) our board code may elect to honor. Are they documented somewhere or gathered at the same place or just scattered around in source? I may not know

[Qemu-devel] [PATCH v8 5/7] vhost-user-blk: Add return value for vhost_user_blk_start()

2019-03-20 Thread elohimes
From: Xie Yongji Add a return value for vhost_user_blk_start() to check whether we start vhost-user backend successfully or not. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- hw/block/vhost-user-blk.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/bloc

[Qemu-devel] [PATCH v8 7/7] contrib/vhost-user-blk: enable inflight I/O tracking

2019-03-20 Thread elohimes
From: Xie Yongji This patch enables inflight I/O tracking for vhost-user-blk backend so that we could restart it safely. Signed-off-by: Xie Yongji Signed-off-by: Zhang Yu --- contrib/vhost-user-blk/vhost-user-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/

Re: [Qemu-devel] [PATCH v4 0/2] ati-vga: Implement DDC and EDID info from monitor

2019-03-20 Thread BALATON Zoltan
On Tue, 19 Mar 2019, Corey Minyard wrote: On Sat, Mar 16, 2019 at 03:23:09PM +0100, BALATON Zoltan wrote: On Sat, 16 Mar 2019, BALATON Zoltan wrote: Version 4 try to fix an ASan warning about leaking bitbang_i2c. I still get ASan warning but it's about gpio_i2c_init in bitbang_i2c.c which I h

Re: [Qemu-devel] [PATCH] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-20 Thread Vladimir Sementsov-Ogievskiy
20.03.2019 14:03, Kevin Wolf wrote: > Am 20.03.2019 um 10:59 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Test that mirror job actually resume on resume command after being >> automatically paused on ENOSPC error. >> >> It's a follow-up test for 8d9648cbf3e >> "blockjob: fix user pause in

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-20 Thread BALATON Zoltan
On Wed, 20 Mar 2019, Gerd Hoffmann wrote: On Wed, Mar 20, 2019 at 12:32:42AM +0100, BALATON Zoltan wrote: On Mon, 18 Mar 2019, Gerd Hoffmann wrote: Does it work with the latest patch for you? No (testing with radeonfb.ko). I'm confused. You said here that it works with radeonfb with your pa

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: > On Tue, 19 Mar 2019 14:51:07 + > Daniel P. Berrangé wrote: > > > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote: > > > On Thu, 7 Mar 2019 10:07:05 + > > > Daniel P. Berrangé wrote: > > > > > > > On Wed, Ma

[Qemu-devel] [PATCH v2] iotests: add 248: test resume mirror after auto pause on ENOSPC

2019-03-20 Thread Vladimir Sementsov-Ogievskiy
Test that mirror job actually resume on resume command after being automatically paused on ENOSPC error. It's a follow-up test for 8d9648cbf3e "blockjob: fix user pause in block_job_error_action" Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: by Kevin's comments: - use limit var

Re: [Qemu-devel] [PATCH 1/1] block_crypto_co_create_generic: clean up created file on failure

2019-03-20 Thread Daniel Henrique Barboza
On 3/20/19 6:52 AM, Daniel P. Berrangé wrote: On Tue, Mar 19, 2019 at 07:03:30PM -0300, Daniel Henrique Barboza wrote: When using a non-UTF8 secret to create a volume using qemu-img, the following error happens: $ qemu-img create -f luks --object secret,id=vol_1_encrypt0,file=vol_resize_poo

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-20 Thread Anthony PERARD
On Tue, Mar 19, 2019 at 07:34:45PM +0100, Markus Armbruster wrote: > = hw/xenpv/xen_machine_pv.c = > Stefano Stabellini (supporter:X86) > Anthony Perard (supporter:X86) > Paul Durrant (supporter:X86) > xen-de...@lists.xenproject.org (open list:X86) That machine requires Xen

[Qemu-devel] [PATCH v2] linux-user: rename gettid() to sys_gettid() to avoid clash with glibc

2019-03-20 Thread Daniel P . Berrangé
The glibc-2.29.9000-6.fc31.x86_64 package finally includes the gettid() function as part of unistd.h when __USE_GNU is defined. This clashes with linux-user code which unconditionally defines this function name itself. /home/berrange/src/virt/qemu/linux-user/syscall.c:253:16: error: static declar

Re: [Qemu-devel] [PATCH v2] linux-user: rename gettid() to sys_gettid() to avoid clash with glibc

2019-03-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190320122555.8025-1-berra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190320122555.8025-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v2] linux-user: rename gettid() t

Re: [Qemu-devel] [PATCH v4 0/2] ati-vga: Implement DDC and EDID info from monitor

2019-03-20 Thread Corey Minyard
On Wed, Mar 20, 2019 at 12:39:44PM +0100, BALATON Zoltan wrote: > On Tue, 19 Mar 2019, Corey Minyard wrote: > > On Sat, Mar 16, 2019 at 03:23:09PM +0100, BALATON Zoltan wrote: > > > On Sat, 16 Mar 2019, BALATON Zoltan wrote: > > > > Version 4 try to fix an ASan warning about leaking bitbang_i2c. >

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-20 Thread Bastian Koppelmann
On 3/18/19 8:30 AM, Markus Armbruster wrote: Bastian Koppelmann writes: On 3/12/19 6:36 PM, Markus Armbruster wrote: [snip] = hw/tricore/tricore_testboard.c = Bastian Koppelmann (maintainer:TriCore) I created a patchset for tcg tests for this board (https://lists.nongnu.org/a

[Qemu-devel] [PATCH v3] linux-user: rename gettid() to sys_gettid() to avoid clash with glibc

2019-03-20 Thread Daniel P . Berrangé
The glibc-2.29.9000-6.fc31.x86_64 package finally includes the gettid() function as part of unistd.h when __USE_GNU is defined. This clashes with linux-user code which unconditionally defines this function name itself. /home/berrange/src/virt/qemu/linux-user/syscall.c:253:16: error: static declar

Re: [Qemu-devel] [Qemu-ppc] [PATCH v6 2/2] spapr-rtas: add ibm, get-vpd RTAS interface

2019-03-20 Thread Maxiwell S. Garcia
On Thu, Mar 14, 2019 at 06:26:02PM +0100, Greg Kurz wrote: > On Thu, 14 Mar 2019 13:29:49 -0300 > "Maxiwell S. Garcia" wrote: > > > This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest > > to collect host information. It is disabled by default to avoid unwanted > > information l

Re: [Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-20 Thread Gerd Hoffmann
On Wed, Mar 20, 2019 at 12:41:30PM +0100, BALATON Zoltan wrote: > On Wed, 20 Mar 2019, Gerd Hoffmann wrote: > > On Wed, Mar 20, 2019 at 12:32:42AM +0100, BALATON Zoltan wrote: > > > On Mon, 18 Mar 2019, Gerd Hoffmann wrote: > > > > > Does it work with the latest patch for you? > > > > > > > > No (

Re: [Qemu-devel] [PATCH v3] linux-user: rename gettid() to sys_gettid() to avoid clash with glibc

2019-03-20 Thread Laurent Vivier
Le 20/03/2019 à 13:36, Daniel P. Berrangé a écrit : > The glibc-2.29.9000-6.fc31.x86_64 package finally includes the gettid() > function as part of unistd.h when __USE_GNU is defined. This clashes > with linux-user code which unconditionally defines this function name > itself. > > /home/berrange/

Re: [Qemu-devel] [PATCH 0/1] update copyright notice

2019-03-20 Thread IOMMU AUTHOR
On Wed, Mar 20, 2019 at 12:16 AM IOMMU AUTHOR wrote: > i'd rather the copyright notice on these files looks like i've put it > below and since i just simply snipped my name(i'll provide legal proof > that this is my name, if required), i don't expect this to be an issue. > is this getting queued

Re: [Qemu-devel] Cascadelake-Server missing MSR based features ?

2019-03-20 Thread Daniel P . Berrangé
On Tue, Mar 19, 2019 at 02:20:01PM -0300, Eduardo Habkost wrote: > On Tue, Mar 19, 2019 at 04:16:14PM +, Daniel P. Berrangé wrote: > > On Tue, Mar 19, 2019 at 10:35:33PM +0800, Tao Xu wrote: > > > On 3/19/2019 8:16 PM, Daniel P. Berrangé wrote: > > > > The Cascadelake-Server CPU was added last

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Eduardo Habkost
On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: [...] > > So it's rather questionable if we should care about arbitrarily old > > libvirt with new QEMU in case of new machines (especially upstream). > > As

[Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-20 Thread Zhengui li
The function fcntl maybe return -1, which is not a unsigned type. Unsigned type or Negative values should not do bitwise operator with O_ACCMODE. Signed-off-by: Zhengui li --- scsi/qemu-pr-helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-20 Thread Wei Yang
On Sat, Mar 16, 2019 at 10:31:24AM +, Wei Yang wrote: >On Thu, Mar 14, 2019 at 10:18:30AM +0100, Igor Mammedov wrote: >>On Wed, 13 Mar 2019 21:31:37 + >>Wei Yang wrote: >> >>> On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >>> >On Wed, 13 Mar 2019 13:33:59 + >>> >Wei Ya

Re: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1553089028-21628-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1553089028-21628-1-git-send-email-lizhen...@huawei.com Subject: [Qemu-devel]

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote: > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote: > > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: > [...] > > > So it's rather questionable if we should care about arbitrarily old > > > l

Re: [Qemu-devel] [PATCH 0/8] Clean up #include "..." vs "<...>" and header guards

2019-03-20 Thread Stefan Hajnoczi
On Fri, Mar 15, 2019 at 03:51:15PM +0100, Markus Armbruster wrote: > * Our use of header guards is rather sloppy. Sloppiness there can > lead to confusing compilation errors. The rest of the series cleans > up existing header guards. In particular, it normalizes guard > symbols to follow a

Re: [Qemu-devel] [PATCH v2] nrf51_gpio: reflect pull-up/pull-down to IRQs

2019-03-20 Thread Stefan Hajnoczi
On Sun, Mar 17, 2019 at 03:10:01PM +0100, Paolo Bonzini wrote: > Some drivers do I2C bitbanging by keeping the output to 0 and flipping > the GPIO direction between input and output (see for example in Linux > gpio_set_open_drain_value_commit, in drivers/gpio/gpiolib.c). > When the GPIO is set to i

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-03-20 Thread Stefan Hajnoczi
On Mon, Mar 18, 2019 at 07:07:25AM +, Fernando Casas Schössow wrote: > Wanted to share one more update regarding this issue. > Since running the new package with the patch from Natanael, the issue never > happen again. > It's been three weeks with all guests running on virtio-scsi and no issue

Re: [Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1553089028-21628-1-git-send-email-lizhen...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH RFC v3 00/11] Add RX archtecture support

2019-03-20 Thread Yoshinori Sato
On Fri, 08 Mar 2019 10:24:23 +0900, Richard Henderson wrote: > > On 3/1/19 10:21 PM, Yoshinori Sato wrote: > > My git repository is bellow. > > git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git > > Somehow patch 1 did not arrive, so I am reviewing based on > rebasing this branch against master, a

[Qemu-devel] [Bug 1821006] [NEW] qemu: Unsupported syscall: 382

2019-03-20 Thread Alexey Gavrilov
Public bug reported: I used qemu-user-static/stable,stable,now 1:2.8+dfsg-6+deb9u5 amd64 [installed] When I try to build an image of a docker for an arm, an error occurs. This affects the operation of applications. Dockerfile ARG ARCH FROM ${ARCH}/debian:buster-slim RUN \ printf "Instal

[Qemu-devel] [PATCH] qemu-pr-helper: check the return value of fcntl in do_pr_out

2019-03-20 Thread Zhengui li
The function fcntl maybe return -1, which is not a unsigned type. Unsigned type or Negative values should not do bitwise operator with O_ACCMODE. Signed-off-by: Zhengui li --- scsi/qemu-pr-helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b

Re: [Qemu-devel] Question about VM inner route entry's lost when vhost-user reconnect

2019-03-20 Thread Stefan Hajnoczi
On Tue, Mar 19, 2019 at 09:51:17AM +, Lilijun (Jerry, Cloud Networking) wrote: > After more detail test, I found two results: > 1) This route entry's lost can be reproduced on both virtio-net and > pass-through physical devices. > 2) The link down event is handled by a service named NetworkM

[Qemu-devel] [PATCH RFC v4 12/12] include/hw/regiserfields.h: Add 8bit and 16bit registers

2019-03-20 Thread Yoshinori Sato
Some RX peripheral using 8bit and 16bit registers. Added 8bit and 16bit APIs. Signed-off-by: Yoshinori Sato --- include/hw/registerfields.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/hw/registerfields.h b/include/hw/registerfields.h index 2659a58737..f6bf911990 10064

[Qemu-devel] [PATCH RFC v4 09/12] hw/rx: RX Target hardware definition

2019-03-20 Thread Yoshinori Sato
rx62n - RX62N cpu. rxqemu - QEMU virtual target. Signed-off-by: Yoshinori Sato --- include/hw/rx/rx.h| 7 ++ include/hw/rx/rx62n.h | 54 hw/rx/rx62n.c | 226 ++ hw/rx/rxqemu.c| 100 ++ hw/rx/K

[Qemu-devel] [PATCH RFC v4 00/12] Add RX archtecture support

2019-03-20 Thread Yoshinori Sato
Hello. This patch series is added Renesas RX target emulation. Update review comments and fix some issue. My git repository is bellow. git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git Testing binaries bellow. u-boot Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz starting $ gz

[Qemu-devel] [PATCH RFC v4 08/12] hw/char: RX62N serical communication interface (SCI)

2019-03-20 Thread Yoshinori Sato
This module supported only non FIFO type. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato --- include/hw/char/renesas_sci.h | 45 ++ hw/char/renesas_sci.c | 335 +

[Qemu-devel] [PATCH RFC v4 06/12] hw/intc: RX62N interrupt controller (ICUa)

2019-03-20 Thread Yoshinori Sato
This implementation supported only ICUa. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato --- include/hw/intc/rx_icu.h | 49 +++ hw/intc/rx_icu.c | 373 +++

[Qemu-devel] [PATCH RFC v4 11/12] MAINTAINERS: Add RX

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- MAINTAINERS | 19 +++ 1 file changed, 19 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 85d7d764e5..046dbd8eb6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -272,6 +272,13 @@ F: include/hw/riscv/ F: linux-user/host/riscv32/ F: linux

[Qemu-devel] [PATCH RFC v4 01/12] target/rx: TCG translation

2019-03-20 Thread Yoshinori Sato
This part only supported RXv1 instructions. Instruction manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01us0032ej0120_rxsm.pdf Signed-off-by: Yoshinori Sato --- target/rx/translate.c | 2305 target/rx/insns.decode | 628

[Qemu-devel] [PATCH RFC v4 10/12] Add rx-softmmu

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- configure | 8 default-configs/rx-softmmu.mak | 7 +++ include/sysemu/arch_init.h | 1 + arch_init.c| 2 ++ hw/Kconfig | 1 + 5 files changed, 19 insertions(+) create mode 100644 defau

[Qemu-devel] [PATCH RFC v4 07/12] hw/timer: RX62N internal timer modules

2019-03-20 Thread Yoshinori Sato
renesas_tmr: 8bit timer modules. renesas_cmt: 16bit compare match timer modules. This part use many renesas's CPU. Hardware manual. https://www.renesas.com/us/en/doc/products/mpumcu/doc/rx_family/r01uh0033ej0140_rx62n.pdf Signed-off-by: Yoshinori Sato --- include/hw/timer/renesas_cmt.h | 33 +++

[Qemu-devel] [PATCH RFC v4 05/12] target/rx: Miscellaneous files

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/gdbstub.c | 112 target/rx/monitor.c | 38 target/rx/Makefile.objs | 11 + 3 files changed, 161 insertions(+) create mode 100644 target/rx/gdbstub.c create mode 100644 tar

[Qemu-devel] [PATCH RFC v4 04/12] target/rx: RX disassembler

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- include/disas/bfd.h |5 + target/rx/disas.c | 1512 +++ 2 files changed, 1517 insertions(+) create mode 100644 target/rx/disas.c diff --git a/include/disas/bfd.h b/include/disas/bfd.h index 41b61c85f9..b2c34

[Qemu-devel] [PATCH RFC v4 03/12] target/rx: CPU definition

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/cpu-qom.h | 52 target/rx/cpu.h | 201 ++ target/rx/cpu.c | 225 3 files changed, 478 insertions(+) create mode 100644 target/rx/cpu-

[Qemu-devel] [PATCH RFC v4 02/12] target/rx: TCG helper

2019-03-20 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- target/rx/helper.h| 35 target/rx/helper.c| 147 + target/rx/op_helper.c | 557 ++ 3 files changed, 739 insertions(+) create mode 100644 target/rx/helper.h create mode 100644 target/rx/he

[Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length ISA

2019-03-20 Thread Yoshinori Sato
Hi. I found some problem in tested RX instructions. It is usable in RX instructions, but I think that there is a better fix because I am not familiar with Python. I fixed three point. - Added ctx to !function args. - Fixed group operaiton. varinsns required width field. - Fixed symbol in decode_lo

[Qemu-devel] [PATCH] xen-block: only advertize discard to the frontend when it is enabled...

2019-03-20 Thread Paul Durrant
...and properly enable it when synthesizing a drive. The Xen toolstack sets 'discard-enable' to '1' in xenstore when it wants to enable discard on a specified image. The code in xen_block_driver_create() correctly parses this and uses it to set 'discard' to 'unamp' for the file_layer, but fails to

Re: [Qemu-devel] [PATCH RFC v4 00/12] Add RX archtecture support

2019-03-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190320141610.46305-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190320141610.46305-1-ys...@users.sourceforge.jp Subject: [Qemu-devel] [PATCH RFC v4 00/12] Ad

Re: [Qemu-devel] [PATCH 0/4] tcg: fix dirty bitmap race with MTTCG

2019-03-20 Thread Alex Bennée
Paolo Bonzini writes: > On 30/10/2018 13:21, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> This is a race that can happen when migrating TCG guests under load. >>> It was introduced by the change to run vCPUs outside the big QEMU >>> lock. >> >> Did this ever get re-spun? > > No, the i

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Eduardo Habkost
On Wed, Mar 20, 2019 at 01:46:59PM +, Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote: > > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote: > > > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: > > [...] > > > > S

Re: [Qemu-devel] [PATCH 0/8] Clean up #include "..." vs "<...>" and header guards

2019-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2019 at 01:52:26PM +, Stefan Hajnoczi wrote: > On Fri, Mar 15, 2019 at 03:51:15PM +0100, Markus Armbruster wrote: > > * Our use of header guards is rather sloppy. Sloppiness there can > > lead to confusing compilation errors. The rest of the series cleans > > up existing h

Re: [Qemu-devel] [PATCH 0/2] docs: a few updates to spectre CPU flag recommendations

2019-03-20 Thread Eduardo Habkost
On Tue, Mar 19, 2019 at 10:45:47AM +, Daniel P. Berrangé wrote: > ping Sorry for missing it. I'm queueing this for -rc1, thanks! > > On Thu, Mar 07, 2019 at 12:18:36PM +, Daniel P. Berrangé wrote: > > This corrects the note about spec-ctrl and adds info about the stibp > > flag that was

[Qemu-devel] [PULL 1/1] seccomp: don't kill process for resource control syscalls

2019-03-20 Thread Eduardo Otubo
From: Daniel P. Berrangé The Mesa library tries to set process affinity on some of its threads in order to optimize its performance. Currently this results in QEMU being immediately terminated when seccomp is enabled. Mesa doesn't consider failure of the process affinity settings to be fatal to

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

2019-03-20 Thread Jason J. Herne
On 3/13/19 12:31 PM, Jason J. Herne wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl chann

[Qemu-devel] [PULL 0/1] seccomp branch queue

2019-03-20 Thread Eduardo Otubo
The following changes since commit 62a172e6a77d9072bb1a18f295ce0fcf4b90a4f2: Update version for v4.0.0-rc0 release (2019-03-19 17:17:22 +) are available in the Git repository at: https://github.com/otubo/qemu.git tags/pull-seccomp-20190320 for you to fetch changes up to

Re: [Qemu-devel] [PATCH 0/2] i386: arch_capabilities fixes + migratability

2019-03-20 Thread Eduardo Habkost
It looks like this has slipped through the cracks. I'm queueing this series for -rc1. On Fri, Jan 25, 2019 at 08:06:04PM -0200, Eduardo Habkost wrote: > This series works around KVM bugs that affect the arch_capabilities > feature. One bug made the feature be enabled incorrect on AMD hosts, > a

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 11:51:51 + Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: > > On Tue, 19 Mar 2019 14:51:07 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 19, 2019 at 02:08:01PM +0100, Igor Mammedov wrote: > > > > On Thu, 7 Mar 2

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2019 at 11:46:20AM -0300, Eduardo Habkost wrote: > On Wed, Mar 20, 2019 at 01:46:59PM +, Daniel P. Berrangé wrote: > > On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote: > > > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote: > > > > On Wed, Mar 2

Re: [Qemu-devel] Cascadelake-Server missing MSR based features ?

2019-03-20 Thread Eduardo Habkost
On Wed, Mar 20, 2019 at 01:30:26PM +, Daniel P. Berrangé wrote: > On Tue, Mar 19, 2019 at 02:20:01PM -0300, Eduardo Habkost wrote: > > On Tue, Mar 19, 2019 at 04:16:14PM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 19, 2019 at 10:35:33PM +0800, Tao Xu wrote: > > > > On 3/19/2019 8:16 PM,

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2019 at 04:20:19PM +0100, Igor Mammedov wrote: > > This could be solved if QEMU has some machine type based property > > that indicates whether "memdev" is required for a given machine, > > but crucially *does not* actually activate that property until > > several releases later. >

Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms

2019-03-20 Thread Laszlo Ersek
Hi Peter, On 03/19/19 10:22, Peter Maydell wrote: > On Mon, 18 Mar 2019 at 21:21, Philippe Mathieu-Daudé > wrote: >> >> Hi Peter, >> >> Le dim. 17 mars 2019 23:02, Peter Maydell >> a écrit : >>> >>> On Sun, 17 Mar 2019 at 20:29, Peter Maydell >>> wrote: Hi; this fails to build on OSX and O

Re: [Qemu-devel] [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.

2019-03-20 Thread Igor Mammedov
On Wed, 20 Mar 2019 13:46:59 + Daniel P. Berrangé wrote: > On Wed, Mar 20, 2019 at 10:32:53AM -0300, Eduardo Habkost wrote: > > On Wed, Mar 20, 2019 at 11:51:51AM +, Daniel P. Berrangé wrote: > > > On Wed, Mar 20, 2019 at 11:26:34AM +0100, Igor Mammedov wrote: > > [...] [...] > > If

Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms

2019-03-20 Thread Peter Maydell
On Wed, 20 Mar 2019 at 15:31, Laszlo Ersek wrote: > > Hi Peter, > > On 03/19/19 10:22, Peter Maydell wrote: > > On Mon, 18 Mar 2019 at 21:21, Philippe Mathieu-Daudé > > wrote: > >> > >> Hi Peter, > >> > >> Le dim. 17 mars 2019 23:02, Peter Maydell > >> a écrit : > >>> > >>> On Sun, 17 Mar 2019 a

[Qemu-devel] [Bug 1819649] Re: Win10 Preview Build 18351 - no input

2019-03-20 Thread Norbert Federa
Issue seems to be fixed with Windows 10 19H1 Insider Preview Build 18361 ! Quoting from Microsoft's Changelog: "We fixed an issue preventing certain VMs from being able to install or update Windows Insider Preview builds ..." Seems this was no qemu issue after all, please close. -- You receive

  1   2   >