On Tue, Mar 19, 2019 at 05:16:17PM +0000, Peter Maydell wrote: > On Tue, 19 Mar 2019 at 17:08, Daniel P. Berrangé <berra...@redhat.com> wrote: > > > > The glibc-2.29.9000-6.fc31.x86_64 package finally includes the gettid > > function as part of unistd.h when __USE_GNU is defined. This clashes > > with linux-user code which unconditionally defines this function > > itself. > > > We need to probe for its existance and conditionally define our > > own wrapper. > > I think a simpler fix would just be to rename the linux-user > function 'sys_gettid()'. This would also bring it in to line with > the other 'raw syscall wrapper' functions in that file like > sys_getdents, sys_getcpu, etc. I think the sys_ prefix is useful > as it flags that it is a raw syscall and not a libc function.
Ok, I can do a v2 taking that approach Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
